Re: [hibernate-dev] ORM 5 -> 6 first merge meeting

2018-12-20 Thread Vlad Mihalcea
gt; > On Wed, Dec 19, 2018, 3:25 PM Guillaume Smet > wrote: > >> Hi Vlad, >> >> Not sure if it's better to partially push the commits or to have them in a >> list to deal with later (tests + commit). >> >> What do the others think about it? >> >&g

Re: [hibernate-dev] 6.0 Alpha1 prep

2018-12-05 Thread Vlad Mihalcea
Hi, I also agree with Christian. For the `hibernate-entitymanager`, the problem came from Spring as they wanted to support multiple versions of Hibernate. I wrote them on Twitter about this change so that they can adjust their framework to accommodate it. Vlad On Wed, Dec 5, 2018 at 3:53 PM

Re: [hibernate-dev] Can't build Hibernate ORM 5.1 documentation

2018-11-28 Thread Vlad Mihalcea
Hi, Form 5.2, we no longer have the DocBooks tasks. The only document using DocBook in 5.1 is the Integration Guide: http://docs.jboss.org/hibernate/orm/5.1/integrationsGuide/ We converted that to AsciiDoc in 5.2 http://docs.jboss.org/hibernate/orm/5.2/integrationguide/ It's worth

Re: [hibernate-dev] Should the LocalTimeType use the globally configured TimeZone?

2018-10-05 Thread Vlad Mihalcea
on would be an AttributeConverter that handles the timezone > transformation, combined with telling Hibernate to always use UTC for the > JDBC timezone > > > On Fri, Oct 5, 2018 at 4:44 AM Sanne Grinovero > wrote: > >> On Fri, 5 Oct 2018 at 10:28, Vlad Mihalcea >> w

Re: [hibernate-dev] Should the LocalTimeType use the globally configured TimeZone?

2018-10-05 Thread Vlad Mihalcea
as 2007-12-03T10:15:30@UTC, no >> matter what's the VM's timezone or any TZ related config. This allows >> to retrieve the original value later on, also if e.g. the loading VM >> is in a different TZ. >> >> In fact I'd even recommend to use a string-based column t

[hibernate-dev] Should the LocalTimeType use the globally configured TimeZone?

2018-10-04 Thread Vlad Mihalcea
Hi, While reviewing this Jira issue: https://hibernate.atlassian.net/browse/HHH-12988 and further discussing it via Twitter, I wonder if we should persist LocalTime as-is without any TimeZone transformation that may be done if we enable `hibernate.jdbc.time_zone`? According to the Date/Time

Re: [hibernate-dev] Loggers

2018-09-18 Thread Vlad Mihalcea
I think it's a good idea. However, will this break all current applications that use the package name log appenders? Vlad On Fri, Sep 14, 2018 at 7:20 PM, Steve Ebersole wrote: > Yes, I know no one likes talking about logging. "Its not important", until > it is ;) > > TLDR I am considering

Re: [hibernate-dev] @OneToOne with @PrimaryKeyJoinColumn(s) vs @MapsId without value element

2018-09-03 Thread Vlad Mihalcea
Here are my comments: 1. I think the @MapsId behavior is the right one even if we don't enable cascading on the child-side. Although theoretically, we should not do that, in reality, if we disable this behavior, some apps will break. We could document the behavior so that, when used @MapdId or

Re: [hibernate-dev] Reducing the memory usage of HQLQueryPlan

2018-08-12 Thread Vlad Mihalcea
Pad to the nearest power of 2. The performance improvement comes from the likelihood of reusing the SQL Execution Plan on DBs that have a cache for that: Oracle, SQL Server, DB2. Vlad On Sun, 12 Aug 2018, 04:43 Steve Ebersole, wrote: > Pad to what? The number of elements in that passed list

Re: [hibernate-dev] Reducing the memory usage of HQLQueryPlan

2018-08-10 Thread Vlad Mihalcea
one added support for it recently, the padding for IN is not > for Query handling, it's for batch loading which is a very different > scenario. With batch loading we know a finite number of JDBC params - the > batch size. > > > On Fri, Aug 10, 2018, 9:17 AM Vlad Mihalcea > wro

Re: [hibernate-dev] Reducing the memory usage of HQLQueryPlan

2018-08-10 Thread Vlad Mihalcea
We already have the parameter padding for IN queries, and there's a PR for supplying ARRAY via ANY(?). For the second approach, we just have to test it thoroughly to make sure that all major JDBC Driver support it properly. Also, I'd only have the second approach activated via a config property

Re: [hibernate-dev] 5.3 cache issues [Requires Steve]

2018-07-02 Thread Vlad Mihalcea
The short name approach sounds goid and would accommodate any future cache region implementation changes. For 5.3, I'd say we allow the old named to be resolved to the new ones, like symbolic links. This will allow users to migrate to 5.3 without changing existing ehcache.xml configs. We could

Re: [hibernate-dev] ORM progress: tricky branch state

2018-07-02 Thread Vlad Mihalcea
If 5.3 cannot take new features, it's better to branch it and have a 5.4 branch for the master until 6.0 is ready. There are lots of interesting improvements that are provided via PRs or as suggestions on the forum, so it would be detrimental to our users to delay those until 6.0 can be used in

Re: [hibernate-dev] Hibernate ORM 5.2.18 to be the last in 5.2 series?

2018-06-06 Thread Vlad Mihalcea
+1. Unless there will be some serious issues that call for a 5.2.19 release, we should focus on 5.3. Vlad On Wed, Jun 6, 2018 at 3:45 PM, Steve Ebersole wrote: > +1 to stopping 5.2 releases. > > On Wed, Jun 6, 2018 at 7:40 AM Guillaume Smet > wrote: > > > On Tue, Jun 5, 2018 at 10:33 PM Gail

Re: [hibernate-dev] Health check status API

2018-05-31 Thread Vlad Mihalcea
We could do it via the Statistics mechanism which can be made available via JMX. We just have to add whatever info they are interested in to monitor. Vlad On Thu, May 31, 2018 at 7:40 PM, Sanne Grinovero wrote: > It was suggested to me that Hibernate ORM could help people developing >

[hibernate-dev] Auto-registering the cacheable entities and collections

2018-05-30 Thread Vlad Mihalcea
Hi, While upgrading my Hibernate testing repository to 5.3, I realized that we no longer auto-register the 2nd-level cache for entities and the collections even if those are annotated with the Hibernate @Cache annotation. I noticed that the Hibernate tests have been modified and we require to

Re: [hibernate-dev] Unidirectional @OneToMany @JoinColumn associations

2018-05-30 Thread Vlad Mihalcea
Hi, For the OneToMany with @JoinColumn, the user can workaround this limitation by just using the @ManyToOne on the child side on any column they want and turning the unidirectional association into a bidirectional one. I remember I tested it and it worked just fine. For the OneToMany with

Re: [hibernate-dev] Hibernate-orm-modules nmartifacts not publish

2018-05-29 Thread Vlad Mihalcea
Thanks. I will have to look if we have some outdated docs pointing to the old artefact. On Tue, 29 May 2018, 18:21 Chris Cranford, wrote: > I believe we renamed it to `hibernate-orm-jbossmodules` in 5.3.0.CR2 as I > see that with 5.3.1.Final too. > > On 05/29/2018 10:59 AM, Vlad Mi

[hibernate-dev] Hibernate-orm-modules nmartifacts not publish

2018-05-29 Thread Vlad Mihalcea
I checked this forum question: https://discourse.hibernate.org/t/org-hibernate-hibernate-orm-modules-no-longer-published/861/2 And, indeed, the Hibernate-orm-modules artefacts are missing from Maven Central. Was this intentional or do we have a problem related to publishing them? Vlad

Re: [hibernate-dev] Simplify SQL function registration when bootstrapping via JPA

2018-05-17 Thread Vlad Mihalcea
r just > FunctionContributor. This is an example of what I meant about waiting for > 6... > > On Thu, May 17, 2018 at 12:50 PM Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> Sure thing. I'll try to adapt it to using the Bean registry. >> >> Vlad >> >>

Re: [hibernate-dev] Simplify SQL function registration when bootstrapping via JPA

2018-05-17 Thread Vlad Mihalcea
------- > > *Christian Beikov* > > Am 17.05.2018 um 16:49 schrieb Vlad Mihalcea: > >> Hi, > >> > >> Looking at the SessionFactoryImpl class, the only way to provide an > >> SqlFunction

Re: [hibernate-dev] Simplify SQL function registration when bootstrapping via JPA

2018-05-17 Thread Vlad Mihalcea
contributor via ManagedBeanRegistry. > > > Mit freundlichen Grüßen, > > *Christian Beikov* > Am 17.05.2018 um 11:20 schrieb Vlad Mihalcea: > > In the end, I thought of a more generic approach to for J

Re: [hibernate-dev] Simplify SQL function registration when bootstrapping via JPA

2018-05-17 Thread Vlad Mihalcea
; > On Wed, May 16, 2018 at 6:51 AM Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> I suppose this will be refactored considerably in 6.x. >> >> However, it's just a small change and I don't think it will hinder any >> 6.x changes. >>

Re: [hibernate-dev] Simplify SQL function registration when bootstrapping via JPA

2018-05-16 Thread Vlad Mihalcea
;st...@hibernate.org> wrote: > This should maybe wait for 6.0. We are ditching SQLFunction in favor of a > more AST-friendly contract. > > Beyond that, go for it. > > > On Wed, May 16, 2018, 6:34 AM Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> Hi, &g

[hibernate-dev] Simplify SQL function registration when bootstrapping via JPA

2018-05-16 Thread Vlad Mihalcea
Hi, I realized that only the native Hibernate bootstrapping mechanism allows for passing custom SQL functions. For JPA, we can extend the Dialect to register, but that's not always desirable as it requires a code change every time the user switches to a new Dialect version. For this reason, I

Re: [hibernate-dev] SingleTableEntityPersister memory footprint in 5.3

2018-05-03 Thread Vlad Mihalcea
I asked because someone might have an idea about some change that was doe in 5.3 that might affect it. For the moment, I haven't started doing anything about it. Vlad On Thu, May 3, 2018 at 2:01 PM, Guillaume Smet <guillaume.s...@gmail.com> wrote: > On Thu, May 3, 2018 at 9:35 AM, Vlad

[hibernate-dev] SingleTableEntityPersister memory footprint in 5.3

2018-05-03 Thread Vlad Mihalcea
Hi, On Discourse, a user told us that the memory footprint has increased dramatically between 5.2 and 5.3: https://discourse.hibernate.org/t/batch-fetch-style-recommendations/631/5?u=vlad I think it's worth investigating the cause and see how we could address it in the next release. Vlad

Re: [hibernate-dev] Why do we have the date in the URL of blog posts?

2018-03-22 Thread Vlad Mihalcea
tmare... We would need a damn > good reason to do it, and I'm not sure those you mentioned are enough... > > On Thu, 22 Mar 2018 at 12:29 Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> Hi, >> >> The data in the post slug only makes sense for news si

Re: [hibernate-dev] Why do we have the date in the URL of blog posts?

2018-03-22 Thread Vlad Mihalcea
Hi, The data in the post slug only makes sense for news sites where posts are highly associated to a given date. In our case, the data works against us as people might think an article is outdated by just inspecting the slug and thinking that a 3 year-old article might not be relevant anymore.

Re: [hibernate-dev] Defaultable service strategies

2018-03-21 Thread Vlad Mihalcea
Sounds good to me. Vlad On Wed, 21 Mar 2018, 20:48 Steve Ebersole, wrote: > Thoughts on allowing certain services to be defaulted to the single > implementor registered with the `StrategySelector` service when there is > just one? > > For example, when resolving the

Re: [hibernate-dev] Null-Pointer Exception with 5.2.14

2018-03-01 Thread Vlad Mihalcea
Hi Petar, You can use this template: http://in.relation.to/2016/01/14/hibernate-jpa-test-case-template/ to create a test case that replicates the issue. You don't need to provide all entities, just the 4 entities that build that hierarchy you have mentioned in your email. If you can replicate

Re: [hibernate-dev] Why does implicit join translate to inner join?

2018-02-22 Thread Vlad Mihalcea
is based on JPA 2.1 spec, 4.4.4 Path Expressions , "Path > > expression navigability is composed using “inner join” semantics." > > > > On 22 February 2018 at 08:09, Lukas Eder <lukas.e...@gmail.com> wrote: > > > >> Hello, > >> > >>

Re: [hibernate-dev] Empty IN list support

2018-02-16 Thread Vlad Mihalcea
I see that we are only using it for testing so that we can skip the: testEmptyInListQuery query on certain Dialects. We could use this info when rendering the JPQL/HQL queries to throw an exception before executing the query. Nevertheless, an exception will be thrown anyway even if we don't do

Re: [hibernate-dev] ORM documentation info hibernate.org

2018-02-07 Thread Vlad Mihalcea
I also think it's redundant now. Vlad On Wed, Feb 7, 2018 at 8:36 PM, andrea boriero wrote: > I think it is not necessary anymore, so +1 for removing it. > > On 7 February 2018 at 18:32, Steve Ebersole wrote: > > > Now that the hibernate.org

Re: [hibernate-dev] Repackaging dependencies with Hibernate

2018-02-06 Thread Vlad Mihalcea
lly wanted to do such a thing .. >> >> I'm glad others - e.g. Spring - repackage their dependencies, so >> that's less likely to conflict with our dependencies :P >> >> Thanks, >> Sanne >> >> >> On 6 February 2018 at 12:42, Vlad Mihalcea <mihal

[hibernate-dev] Repackaging dependencies with Hibernate

2018-02-06 Thread Vlad Mihalcea
Hi, This Hibernate forum question provides a good point: https://discourse.hibernate.org/t/hibernate-in-weblogic-has-a-conflicting-antlr-version-what-to-do/189 Frameworks like EclipseLink and Spring ( https://twitter.com/starbuxman/status/960854907854249986 ) repackage dependencies to avoid the

[hibernate-dev] Support for entities without default constructor

2018-02-03 Thread Vlad Mihalcea
Hi, I realized that we could allow users to define entities without a default constructor. For Kotlin, which supportsdefault values, this could be beneficial. There is some info about how we could do that in this using Objenesis in the following Spring issue:

Re: [hibernate-dev] 5.3.0 release tomorrow

2018-02-01 Thread Vlad Mihalcea
hen > I'm ready to start. > > On Thu, Feb 1, 2018, 7:28 AM Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> Hi Steve, >> >> Is it ok to commit on the master branch today or should we wait for 5.3 >> to be released? >> >> Vlad >> On Th

Re: [hibernate-dev] Minor changes to the website

2018-02-01 Thread Vlad Mihalcea
Great job Guillaume, It looks awesome. Vlad On Wed, Jan 31, 2018 at 2:15 PM, Guillaume Smet wrote: > Hi, > > Just so you know, I just made a few minor changes to the website: > - in the Releases dymanic submenu, you now have a label stating "latest >

Re: [hibernate-dev] Should EntityManager#refresh retain an existing lock?

2018-02-01 Thread Vlad Mihalcea
Hi Gail, Steve is right. Database locks cannot be released unless you end the transaction and that's how it works on any RDBMS, either in 2PL Mode or MVCC. As for optimistic locks: 1. LockModeType.OPTIMISTIC The check is done at the end of the end of the transaction. Refresh will only update

Re: [hibernate-dev] 5.3.0 release tomorrow

2018-02-01 Thread Vlad Mihalcea
Hi Steve, Is it ok to commit on the master branch today or should we wait for 5.3 to be released? Vlad On Thu, Feb 1, 2018 at 4:03 AM, Steve Ebersole wrote: > I am waiting until I hear back from Joel from Sonatype regarding disabling > the JBoss Nexus -> OSSRH sync for

Re: [hibernate-dev] Serializable SessionFactory

2018-01-12 Thread Vlad Mihalcea
illing to invest to make the ORM bootstrap faster, that's > great but we should work on identifying what is being slow and what > can be done without making it dangerous. > > > > > On Thu, Jan 11, 2018 at 2:08 AM Vlad Mihalcea <mihalcea.v...@gmail.com> > > wrote: > >

Re: [hibernate-dev] Serializable SessionFactory

2018-01-11 Thread Vlad Mihalcea
a similarly named > SessionFactory in its org.hibernate.internal.SessionFactoryRegistry. > > On Wed, Jan 10, 2018 at 11:20 AM Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> Hi, >> >> While reviewing old PRs we have in the ORM project, I stumbled on this one &

[hibernate-dev] Serializable SessionFactory

2018-01-10 Thread Vlad Mihalcea
Hi, While reviewing old PRs we have in the ORM project, I stumbled on this one about serializing the SessionFactory. I created a new PR, rebased on top of the current master branch and all tests are passing fine. If anyone wants to take a look, this is the PR:

[hibernate-dev] Locking German and French forums

2017-12-20 Thread Vlad Mihalcea
Hi, I'm going to lock the German and French forums since users posts question there from time to time, and the questions remain answered. If someone has anything against it, let me know. Otherwise, we should use the English one until we move to Discourse. Vlad

Re: [hibernate-dev] Realising the JavaDoc jars as well

2017-12-12 Thread Vlad Mihalcea
> > Some history can easily be found: > - http://lists.jboss.org/pipermail/hibernate-dev/2017-January/015758.html > > Thanks, > Sanne > > > On 11 December 2017 at 15:24, Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > > Hi, > > > > I've

[hibernate-dev] Realising the JavaDoc jars as well

2017-12-11 Thread Vlad Mihalcea
Hi, I've noticed this Pull Request which is valid and worth integrating: https://github.com/hibernate/hibernate-orm/pull/2078 Before I merge it, I wanted to make sure whether this change was accidental or intentional. Was there any reason not to ship the JavaDoc jars along with the release

[hibernate-dev] Why does the disassembledStateText in StandardCacheEntryImpl build from the actual state[] and not from disassembledState[]?

2017-11-29 Thread Vlad Mihalcea
Hi, While working on fixing https://hibernate.atlassian.net/browse/HHH-12107, I realized that the way we create the disassembledStateText property of the StandardCacheEntryImpl object does not resemble the name of the attribute. Now, I wonder why we don't build the disassembledStateText from

Re: [hibernate-dev] JPA Compliance

2017-11-28 Thread Vlad Mihalcea
{ > return b; > } > } > > class *B*{ > List as; > > @ManyToMany(mappedBy = "bs", cascade=CascadeType.ALL) > public List getAs() { > return as; > } > } > > and it seems JPA expects the JoinTable A_B to have a PK (A_ID,B_ID). > > On 28 Novemb

Re: [hibernate-dev] JPA Compliance

2017-11-27 Thread Vlad Mihalcea
one I am very undecided. I can see very valid arguments for each. >>> >> >> probably for such case a setting may be a good option. >> >>> >>> [1] we really ought to start keeping a list of these. I have started >>> a

Re: [hibernate-dev] HHH-12125 - @GeneratedValue & 5.3

2017-11-25 Thread Vlad Mihalcea
That's a great idea. I stumbled on this issue many times, and it's very good to simplify the mapping as you suggested. +1 Vlad On Sat, Nov 25, 2017 at 6:18 PM, Steve Ebersole wrote: > The background is all in the Jira, but the crux is this... it is better to > allow a

Re: [hibernate-dev] JPA Compliance

2017-11-16 Thread Vlad Mihalcea
t;with multiple modes" aspect though. What are > these other enumerated mode values? > > > On Thu, Nov 16, 2017 at 2:15 PM Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> Where the JPA way is questionable, let's add one configuration: >> hiberna

Re: [hibernate-dev] JPA Compliance

2017-11-16 Thread Vlad Mihalcea
gt; asking about. Like to me, it really never makes sense to throw an > exception when I close something that is already closed. So how do we > handle cases like this? > > > On Thu, Nov 16, 2017 at 1:51 PM Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> Hi S

Re: [hibernate-dev] JPA Compliance

2017-11-16 Thread Vlad Mihalcea
Hi Steve, I think that for 5.2 was ok to have the isJpaBootstrap method to avoid breaking compatibility for the native bootstrap. For 6.0, maybe it's easier if we just align to the JPA spec where it makes sense, and only provide a separation where the JPA way is questionable. I noticed that the

Re: [hibernate-dev] Hibernate CI is angry: ORM build job is failing since the 2nd of November

2017-11-06 Thread Vlad Mihalcea
empty list of recipients, ignored. > > So nobody heard of this. Would be great if we could figure out a way > to notify the people who merged the PR, on top of trying to reach the > commit authors? > > > > On 6 November 2017 at 14:53, Vlad Mihalcea <mihalcea.v...@gmail.com&

Re: [hibernate-dev] Hibernate CI is angry: ORM build job is failing since the 2nd of November

2017-11-06 Thread Vlad Mihalcea
Looks like there is some indentation issue:

Re: [hibernate-dev] @db.dialect@ - yet again

2017-10-12 Thread Vlad Mihalcea
Hi, Looks like IDEA rebuilds the project and generates the @db.dialect@ issue. I tackled it with the following Bash script: @echo off > set db=%1 > set module="hibernate-core" > if not "%2"=="" SET module="hibernate-%2" > if "%2"=="doc" SET module="documentation" > set

Re: [hibernate-dev] "Hibernate Types" project

2017-09-28 Thread Vlad Mihalcea
Hi, It's because not all database support ARRAY or JSON. We've been discussing this on the mailing list (around one year ago) and I remember we concluded that we can only add these types to ORM core if the vast majority of the Hibernate-supported database offer JSON or ARRAY. Also, even if we

Re: [hibernate-dev] Too simple a solution for HHH-11147 ?

2017-09-27 Thread Vlad Mihalcea
Hi Thomas, You can send a Pull Request. I'll ask Luis Barreiro to review it since he's the expert in this area. Thanks, Vlad On Thu, Sep 28, 2017 at 12:33 AM, Thomas Reinhardt wrote: > > Hello, > > I investigated HHH-11147 (Allow enhanced entities to be returned in a >

Re: [hibernate-dev] Number of SQL statements

2017-09-22 Thread Vlad Mihalcea
HI, We already have such tool for the Hibernate tests. The one that I suggested does not use FlexyPool, but datasource-proxy. Vlad On Fri, Sep 22, 2017 at 5:55 PM, Sanne Grinovero wrote: > Hi Thomas, > > I can't answer your question - will leave that to the people working

Re: [hibernate-dev] Number of SQL statements

2017-09-22 Thread Vlad Mihalcea
Hi, 1. To validate the number of SQL statements, use this SQL Statement count validator I explained in this article: https://vladmihalcea.com/2014/02/01/how-to-detect-the-n-plus-one-query-problem-during-testing/ 2. For Hibernate Criteria, I don't think you should bother since it will be removed

Re: [hibernate-dev] [Search and more] What is new in a give release

2017-09-14 Thread Vlad Mihalcea
Hi, To be able to load the User Guide like this: https://docs.jboss.org/hibernate/orm/5.2 we have two options: 1. Either we rename the User Guide to index.adoc so that it will become index.html. 2. We leave it as-is, but when we copy the docs to

Re: [hibernate-dev] Problems with PreparedStatementSpyConnectionProvider

2017-09-10 Thread Vlad Mihalcea
Hi, The only time when I saw that class failing was for MariaDB because the Connection was final and we could not proxy it. That's when I switched to Mockito 2. However, the goal of that class is to allow it to run as a regular PS, but to proxy it so that any PS call invocation is recorded.

Re: [hibernate-dev] Are the tests in the documentation module expected to run on MySQL only?

2017-09-08 Thread Vlad Mihalcea
I test Hibernate with the following DBs mostly: - H2 - Oracle - SQL Server - PostgreSQL - MySQL and MariaDb For other databases, it's not guaranteed that all tests will run. Related to that function, we could other add a change, but it must work on the DBs above too. Or, you could just mark the

Re: [hibernate-dev] Unresolved issues targeting 5.2.11

2017-09-01 Thread Vlad Mihalcea
Much appreciated, Vlad On Fri, Sep 1, 2017 at 9:19 AM, Gail Badner <gbad...@redhat.com> wrote: > Hi Vlad, > > Thanks for letting me know. I'll take a look tomorrow. > > Regards, > Gail > > On Thu, Aug 31, 2017 at 10:25 PM, Vlad Mihalcea <mihalcea.v...@gmail.com

Re: [hibernate-dev] Unresolved issues targeting 5.2.11

2017-08-31 Thread Vlad Mihalcea
Hi Gail, My issues have Pull Requests that need to be reviewed. However, there are around 8 PRs which I'd like someone to review so that we can include them in 5.2.11: https://github.com/hibernate/hibernate-orm/pulls?q=is%3Aopen+is%3Apr+author%3Avladmihalcea+label%3A%22Ready+for+review%22

Re: [hibernate-dev] Deprecated methods of NativeQuery via SQLQuery

2017-08-30 Thread Vlad Mihalcea
That's a good question. There are some methods which don't have a replacement in JPA so we should probably move to some subclass and remove the deprecated flag. Vlad On Wed, Aug 30, 2017 at 5:59 PM, Guillaume Smet wrote: > Hi, > > In OGM tests, we have a lot of

Re: [hibernate-dev] [ORM] Documentation inconsistencies

2017-08-29 Thread Vlad Mihalcea
Hi, The inconsistencies are due to the latest release being done quite a long time ago. The 5.2 User Guide was generated when we released 5.2.10 while the GitHub repo contains many doc changes that will be available only when we release 5.2.11. Vlad On Tue, Aug 29, 2017 at 8:12 PM, Marko B

Re: [hibernate-dev] SQL Server 2016

2017-08-29 Thread Vlad Mihalcea
For SQL Server, 2012 is our latest supported Dialect. I've been running tests on my local SQL Server 2016 Express and everything worked fine. As for Jenkins, we don't have support for MSSQL. I'm not sure if the Linux version license allows us to run tests on Jenkins, but if it does, I think we

Re: [hibernate-dev] Empty composites and embeddable containing an embeddable

2017-08-14 Thread Vlad Mihalcea
I guess we should create the nested embeddable as well. Vlad On Fri, Aug 11, 2017 at 2:02 AM, Gail Badner wrote: > If an embeddable contains an embeddable, and the outer embeddable is > instantiated due to hibernate.create_empty_composites.enabled=true, should > the inner

Re: [hibernate-dev] Contributions - changes "CLA" process

2017-08-08 Thread Vlad Mihalcea
Woohoo! That's great news. Vlad On Tue, Aug 8, 2017 at 12:27 AM, Steve Ebersole wrote: > Currently we have had to rely on a less-than-ideal CLA approach as part of > the process for accepting a contribution. That CLA app is a hassle for > contributors and it is a

Re: [hibernate-dev] ORM FAQ

2017-08-04 Thread Vlad Mihalcea
Hi Steve, I read it and I have some the following suggestions: 1. For the Performance section, I'd add the transparent JDBC batch updates, the delayed connection acquisition, cacheable natural id fetching. 2. For the How does Hibernate compare to JPA section, I'd add a list of cool features

Re: [hibernate-dev] Plan on adding the JPA 2.2 Query#getResultStream() in 5.2

2017-08-03 Thread Vlad Mihalcea
ay. > > Cool, we're all on the same page then. > > 2017-08-02 21:16 GMT+01:00 Vlad Mihalcea <mihalcea.v...@gmail.com>: > >> Sure, but you may not publish something like an JPA 2.1+ with just some >>> of the 2.2 methods. >> >> >> I don't understand th

Re: [hibernate-dev] Plan on adding the JPA 2.2 Query#getResultStream() in 5.2

2017-08-02 Thread Vlad Mihalcea
at 15:21, Vlad Mihalcea <mihalcea.v...@gmail.com> wrote: > > Hi, > > > > I plan on adding the JPA 2.2 Query#getResultStream() method since we > > already support streaming and, > > this way, Hibernate 5.2 will work even if the client has a JPA 2.2 > > dep

[hibernate-dev] Plan on adding the JPA 2.2 Query#getResultStream() in 5.2

2017-08-02 Thread Vlad Mihalcea
Hi, I plan on adding the JPA 2.2 Query#getResultStream() method since we already support streaming and, this way, Hibernate 5.2 will work even if the client has a JPA 2.2 dependency in their classpath. https://jcp.org/aboutJava/communityprocess/maintenance/jsr338/ChangeLog-JPA-2.2-MR.txt While

Re: [hibernate-dev] Difference between Comment and Hint in Hibernate query

2017-08-01 Thread Vlad Mihalcea
think we need to support it since we have the comment attribute on the annotation level. Vlad On Tue, Aug 1, 2017 at 6:16 PM, Steve Ebersole <st...@hibernate.org> wrote: > See inline.. > > On Tue, Aug 1, 2017 at 9:05 AM Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: &

Re: [hibernate-dev] Difference between Comment and Hint in Hibernate query

2017-08-01 Thread Vlad Mihalcea
izer hints... > so these need to be handled differently > > On Tue, Aug 1, 2017, 8:19 AM Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> I'm asking because the >> >> org.hibernate.annotations.NamedNativeQuery or >> org.hibernate.annotations.NamedQuer

Re: [hibernate-dev] PESSIMISTIC_FORCE_INCREMENT lock mode

2017-08-01 Thread Vlad Mihalcea
; On Fri, Jul 28, 2017 at 6:17 PM, Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> In MVCC, shared and exclusive are not as significant as in 2PL >> concurrency control which only SQL Server supports by default nowadays. >> >> Even if the row is locked in sha

Re: [hibernate-dev] Difference between Comment and Hint in Hibernate query

2017-08-01 Thread Vlad Mihalcea
te.org> wrote: > Query hints are hints for the database' s query parser/optimizer. > > A comment is a... well a comment :) > > On Tue, Aug 1, 2017, 6:37 AM Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> Hi, >> >

[hibernate-dev] Difference between Comment and Hint in Hibernate query

2017-08-01 Thread Vlad Mihalcea
Hi, While working on integrating a Pull Request, I realized that the org.hibernate.engine.spi.QueryParameters provides these two attributes: private String comment; private List queryHints; Both these two are to be sent to the database, so why do we have both? I also noticed that only for

Re: [hibernate-dev] PESSIMISTIC_FORCE_INCREMENT lock mode

2017-07-28 Thread Vlad Mihalcea
e out! > > Best Regards, > Arnold > > > On Fri, Jul 28, 2017 at 7:40 AM, Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> That's how Hibernate was executing the statements when I wrote the >> article. >> >> I spotted the difference when writing

Re: [hibernate-dev] Are arrays of non-basic elements supported?

2017-07-28 Thread Vlad Mihalcea
ng a List rather than an array. > > > > On Thu, Jul 27, 2017 at 2:04 AM Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> I fixed it with the following commit: >> >> https://github.com/hibernate/hibernate-orm/commit/ >> 871722dc08ec131cd1f5238e1b48

Re: [hibernate-dev] 6.0 - procedure/function calls via NativeQuery

2017-07-27 Thread Vlad Mihalcea
stored procedures? > > I'm supporting Steve's idea to remove this complexity and force the users > to use the proper API. I think for 6.0 this change can be acceptable and > should be mentioned in the migration guide. > > Best Regards, > Arnold > > > > On Thu,

Re: [hibernate-dev] Are arrays of non-basic elements supported?

2017-07-27 Thread Vlad Mihalcea
so treats an empty array element as > equivalent to null as well. > > Vlad, thanks for correcting the documentation. > > On Wed, Jul 26, 2017 at 7:38 AM, Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> The docs says: >> >> When it comes to a

Re: [hibernate-dev] 6.0 - procedure/function calls via NativeQuery

2017-07-27 Thread Vlad Mihalcea
I run a quick Google search for "Hibernate NnativeQuery stored procedure" and found these links: http://www.baeldung.com/stored-procedures-with-hibernate-tutorial https://www.mkyong.com/hibernate/how-to-call-store-procedure-in-hibernate/ I guess people used to do this. We could use some

Re: [hibernate-dev] Are arrays of non-basic elements supported?

2017-07-26 Thread Vlad Mihalcea
The docs says: When it comes to arrays, there is quite a difference between Java arrays and relational database array types (e.g. VARRAY, ARRAY). First, not all database systems implement the SQL-99 ARRAY type, and, for this reason, Hibernate doesn’t support native database array types. Second,

[hibernate-dev] Hibernate ORM Docbook removal

2017-07-24 Thread Vlad Mihalcea
Hi, Since it's more than one year since we switched to Asciidoc, I think we should remove the docbook folder. Does anyone has anything against it or thinks this is not a good idea? Vlad ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org

Re: [hibernate-dev] Hibernate Extras module

2017-07-01 Thread Vlad Mihalcea
storic reasons. :-) > > Thank you guys! > > Best, > Arnold > > On Sat, Jul 1, 2017 at 6:31 PM, Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> Hi, >> >> Someone asked me if I can supply the JSON Type as a separate module so >> that &

[hibernate-dev] Hibernate Extras module

2017-07-01 Thread Vlad Mihalcea
Hi, Someone asked me if I can supply the JSON Type as a separate module so that it can be grabbed from Maven Central: https://vladmihalcea.com/2016/06/20/how-to-map-json-objects-using-generic-hibernate-types/ I wonder if we should supply a hibernate-extras where we include non-standard

Re: [hibernate-dev] Continue to add 5.2 deprecations for 6.0 work?

2017-06-28 Thread Vlad Mihalcea
to >> provide an alternative, not sure about the best approach in case we do not >> have a current alternative. >> >> On 28 June 2017 at 08:55, Vlad Mihalcea <mihalcea.v...@gmail.com> wrote: >> >>> I would use the regular Java deprecat

Re: [hibernate-dev] Continue to add 5.2 deprecations for 6.0 work?

2017-06-28 Thread Vlad Mihalcea
I would use the regular Java deprecation mechanism is just make sure we write the plan in the Javadoc and the User Guide. On example is Query#setResultTransformer: > > * @deprecated (since 5.2) > * @todo develop a new approach to result transformers > */ > @Deprecated > Query

Re: [hibernate-dev] Feature Request: Encrypt sensitive data with an "encrypted store/filter"

2017-06-23 Thread Vlad Mihalcea
Hi, The easiest way to do it is to use Transparent Data Encryption in the RDBMS: https://docs.microsoft.com/en-us/sql/relational-databases/security/encryption/transparent-data-encryption-tde For simple use cases, you can just use the @ColumnTransformer as explained in this article:

Re: [hibernate-dev] Migration path from 3.6 to 5.2

2017-06-13 Thread Vlad Mihalcea
Hi, You can migrate from 3.6 to 5.2 directly. Just read all the migration guides from 3.x to 5.2 to know what has changed and what you need to take into consideration. For example, 5.x uses the enhanced identifier generators which you might want to disable if you relied on the old sequence-based

Re: [hibernate-dev] Hibernate ORM 5.0 test failures

2017-06-13 Thread Vlad Mihalcea
This error: "unexpected exception opening server socket java.net.BindException: Address already in use (Bind failed)" I only got it when NVidia driver was stealing the Wildfly port, but that was never for CriteriaLockingTest. It's also curious why the Byteman agent tries to open a socket

Re: [hibernate-dev] HHH-11791

2017-06-12 Thread Vlad Mihalcea
Hi, Wouldn't that require all entities be compiled with? javac -parameters Vlad On Mon, Jun 12, 2017 at 10:19 PM, Christian Bongiorno < christian.bongio...@gmail.com> wrote: > Now that java 8 supports named parameters it becomes possible (potentially > preferrable) to use constructor

Re: [hibernate-dev] SqlTypeDescriptor bind by name limitation

2017-06-07 Thread Vlad Mihalcea
so we already know >> how to bind positionally against both PreparedStatement (and >> CallableStatement, since they are PreparedStatement). And only for >> CallableStatement does JDBC define additional support for binding by name. >> >> And 6.0 is going to bind by posi

Re: [hibernate-dev] Pull request

2017-06-07 Thread Vlad Mihalcea
at 15:46, Vlad Mihalcea <mihalcea.v...@gmail.com> wrote: > > Hi Sanne, > > > > The PR queue has not been neglected at all. The problem was that the > issue > > was still marked with the "Requires Changes" label, and I assumed it was > not > > done

Re: [hibernate-dev] Pull request

2017-06-07 Thread Vlad Mihalcea
Hi Sanne, The PR queue has not been neglected at all. The problem was that the issue was still marked with the "Requires Changes" label, and I assumed it was not done yet. Vlad On Wed, Jun 7, 2017 at 12:41 PM, Sanne Grinovero wrote: > Hi Milo, > > apologies for that. The

Re: [hibernate-dev] @org.hibernate.annotations.Index and NullPointerException in IndexOrUniqueKeySecondPass

2017-06-07 Thread Vlad Mihalcea
Hi, You should try it with JPA @Index as well, and try to replicate it with one of our test cases: http://in.relation.to/2016/01/14/hibernate-jpa-test-case-template/ If it replicates, you should open a Jira issue along with your PR. Thanks, Vlad On Wed, Jun 7, 2017 at 11:33 AM, Laurent

[hibernate-dev] SqlTypeDescriptor bind by name limitation

2017-06-07 Thread Vlad Mihalcea
Hi, While writing an example for a custom Hibernate Type which supports PostgreSQL arrays, I realized that the SqlTypeDescriptor only supports bind by name: @Override protected void doBind(CallableStatement st, X value, String name, WrapperOptions options) throws SQLException { }

  1   2   3   4   >