Re: RFR: JDK-8315457 Implementation of String Templates (Second Preview) [v4]

2023-11-06 Thread Jim Laskey
On Sat, 4 Nov 2023 13:26:04 GMT, Alan Bateman wrote: >> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits

Re: RFR: JDK-8315457 Implementation of String Templates (Second Preview) [v4]

2023-11-04 Thread Alan Bateman
On Mon, 16 Oct 2023 14:31:46 GMT, Jim Laskey wrote: > Wasn't sure about that. Thx. When in doubt, JEP 12. Alex provided good guidance for API authors on how `@since` should be used with preview APIs. - PR Review Comment:

Re: RFR: JDK-8315457 Implementation of String Templates (Second Preview) [v4]

2023-11-04 Thread Alan Bateman
On Fri, 3 Nov 2023 15:29:25 GMT, Jim Laskey wrote: >> Update String Templates for a second preview. With the addition of >> >> - Expression type and throws are determined from the `process` method of the >> processor type and not the processor type. >> >> - Qualified `STR` and `RAW` are

Re: RFR: JDK-8315457 Implementation of String Templates (Second Preview) [v4]

2023-11-03 Thread Jim Laskey
> Update String Templates for a second preview. With the addition of > > - Expression type and throws are determined from the `process` method of the > processor type and not the processor type. > > - Qualified `STR` and `RAW` are treated the same as unqualified `STR` and > `RAW` . > > - Raw