Re: suggested patch for review - issue 7158 - corrections

2018-09-26 Thread Zach Villers
Thanks again for the coaching and feedback! On 9/26/18 9:52 PM, Kevin Fenzi wrote: > On 09/24/2018 07:49 AM, Zach Villers wrote: >> Happy Monday all. Here's an updated set of patches for issue 7158, with >> some of Kevin's comments on my previous attempt for context; > Looks good to me. :) I've

Re: suggested patch for review - issue 7158 - corrections

2018-09-26 Thread Kevin Fenzi
On 09/24/2018 07:49 AM, Zach Villers wrote: > Happy Monday all. Here's an updated set of patches for issue 7158, with > some of Kevin's comments on my previous attempt for context; Looks good to me. :) I've committed it and am doing an ansible run now. I had to make some very small tweaks that

suggested patch for review - issue 7158 - corrections

2018-09-24 Thread Zach Villers
Happy Monday all. Here's an updated set of patches for issue 7158, with some of Kevin's comments on my previous attempt for context; On 9/18/18 5:44 PM, Kevin Fenzi wrote: > > Confusingly, we have a 'certbot' rule, but thats old and we should nuke > it. The new one is the 'letencrypt' role. It