[Intel-gfx] ✓ Ro.CI.BAT: success for series starting with [1/5] drm/i915: Make IS_GENx macros work on a mask

2016-05-10 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Make IS_GENx macros work on a mask URL : https://patchwork.freedesktop.org/series/6960/ State : success == Summary == Series 6960v1 Series without cover letter

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Use major_minor version for filename

2016-05-10 Thread Antoine, Peter
Reviewed-by: peter.anto...@intel.com -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Nick Hoath Sent: Friday, May 6, 2016 11:43 AM To: intel-gfx@lists.freedesktop.org Cc: O'Rourke, Tom Subject: [Intel-gfx] [PATCH

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Add Broxton GuC firmware loading support

2016-05-10 Thread Antoine, Peter
Reviewed-by: peter.anto...@intel.com -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Nick Hoath Sent: Friday, May 6, 2016 11:43 AM To: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Add Broxton GuC firmware

Re: [Intel-gfx] [PATCH v3] drm/i915: resize the GuC WOPCM for rc6

2016-05-10 Thread Antoine, Peter
Hi Bob, It was tested on a BXT-T RVP and LeafHill A and worked fine. The patch has been in the Android tree for at least a couple of months (probably more) and has seemed to be stable. But, not sure Android was run on the BXT CRB. It could be the GuC firmware crashing, there are some fixes in

Re: [Intel-gfx] [PATCH i-g-t v4 4/5] kms_vblank: Switch from using crtc0 statically to explicitly setting mode.

2016-05-10 Thread Ville Syrjälä
On Tue, May 10, 2016 at 08:19:50PM +0300, Ville Syrjälä wrote: > On Tue, May 10, 2016 at 08:03:47PM +0300, Marius Vlad wrote: > > Robert Foss improved test/kms_vblank and in the same time extended it on > > all outputs and all pipes. The following seems to happen on pipe B (on > > pipe A the test

Re: [Intel-gfx] [PATCH i-g-t v4 5/5] lib/igt_kms: Added pipe_id_to_vbl_flag() to igt_kms.

2016-05-10 Thread Ville Syrjälä
On Tue, Apr 26, 2016 at 11:54:22AM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > Added function pipe_id_to_vbl_flag() to igt_kms. > This function formats a pipe_id into the format > expected by DRM while processing DRM_IOCTL_WAIT_VBLANK. > >

Re: [Intel-gfx] [PATCH i-g-t v4 4/5] kms_vblank: Switch from using crtc0 statically to explicitly setting mode.

2016-05-10 Thread Chris Wilson
On Tue, May 10, 2016 at 08:19:50PM +0300, Ville Syrjälä wrote: > > [46796.049127] [drm:drm_update_vblank_count] updating vblank count on crtc > > 1: current=72, diff=1, hw=72 hw_last=71 > > [46796.049129] [drm:drm_handle_vblank_events] vblank event on 73, current 73 > > Either we had a stale

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Fix modeset handling during gpu reset, v3.

2016-05-10 Thread Maarten Lankhorst
Op 10-05-16 om 09:48 schreef Daniel Vetter: > On Mon, May 09, 2016 at 03:54:15PM +0300, Ville Syrjälä wrote: >> On Mon, May 09, 2016 at 01:04:21PM +0200, Maarten Lankhorst wrote: >>> This function would call drm_modeset_lock_all, while the suspend/resume >>> functions already have their own

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Step away from symbolic links

2016-05-10 Thread Jani Nikula
On Tue, 10 May 2016, Patrik Jakobsson wrote: > On Tue, May 10, 2016 at 03:52:02PM +0300, Mika Kuoppala wrote: >> Patrik Jakobsson writes: >> >> > [ text/plain ] >> > Load specific firmware versions for the DMC instead of using

Re: [Intel-gfx] driver crashes if I try to het 2560 x 1440 @ 50Hz CVT-RB running under Linux... Ideas?

2016-05-10 Thread Marius Vlad
Hi, If this still happens, and you can compile and use drm-intel-nightly (from https://cgit.freedesktop.org/drm-intel/, a build guide is available at [2]) please submit a bug at [1]. [1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI=DRM/Intel [2]

Re: [Intel-gfx] [PATCH v3] drm/i915: resize the GuC WOPCM for rc6

2016-05-10 Thread Bob Paauwe
On Tue, 26 Apr 2016 10:11:41 +0100 Peter Antoine wrote: > This patch resizes the GuC WOPCM to so that the GuC and the RC6 memory > spaces do not overlap. Hi Peter, With this patch applied to our IOTG kernel tree, I see a regression with the RC6 residency values. The

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add optional Werror.

2016-05-10 Thread Damien Lespiau
On Tue, May 10, 2016 at 05:32:15PM +0300, Marius Vlad wrote: > v2: Initially added Werror by default. Make it optional so it doesn't > break android build and (potential) distros maintaing the package > (Hinted by Damien Lespiau). > > --enable-werror will enable -Werror compiler flag. > >

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_flip: Adjust tolerance when counting frames

2016-05-10 Thread Jani Nikula
On Tue, 10 May 2016, Gabriel Feceoru wrote: > If count == 100 and expected == 99 this condition fails (99*101/100 = 99.99). > > (v2): Increased the tolerance range, as suggested by Jani. > > Cc: Jani Nikula > Cc: Daniel Vetter

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Step away from symbolic links

2016-05-10 Thread Patrik Jakobsson
On Tue, May 10, 2016 at 03:52:02PM +0300, Mika Kuoppala wrote: > Patrik Jakobsson writes: > > > [ text/plain ] > > Load specific firmware versions for the DMC instead of using symbolic > > links. The currently recommended versions are: SKL 1.26, KBL 1.01 and > >

Re: [Intel-gfx] [PATCH v3 5/6] drm/i915/guc: rework guc_add_workqueue_item()

2016-05-10 Thread Tvrtko Ursulin
On 06/05/16 20:31, Dave Gordon wrote: Mostly little optimisations and future-proofing against code breakage. For instance, if the driver is correctly following the submission protocol, the "out of space" condition is impossible, so the previous runtime WARN_ON() is promoted to a GEM_BUG_ON()

Re: [Intel-gfx] [PATCH v3 6/6] drm/i915/guc: change default to using GuC submission if possible

2016-05-10 Thread Tvrtko Ursulin
On 06/05/16 20:31, Dave Gordon wrote: This patch simply changes the default value of "enable_guc_submission" from 0 (never) to -1 (auto). This means that GuC submission will be used if the platform has a GuC, the GuC supports the request submission protocol, and any required GuC firmwware was

[Intel-gfx] ✗ Ro.CI.BAT: failure for drm: use seqlock for vblank time/count

2016-05-10 Thread Patchwork
== Series Details == Series: drm: use seqlock for vblank time/count URL : https://patchwork.freedesktop.org/series/6981/ State : failure == Summary == Series 6981v1 drm: use seqlock for vblank time/count http://patchwork.freedesktop.org/api/1.0/series/6981/revisions/1/mbox Test

Re: [Intel-gfx] [PATCH v3 3/6] drm/i915/guc: pass request (not client) to i915_guc_{wq_check_space, submit}()

2016-05-10 Thread Tvrtko Ursulin
On 06/05/16 20:31, Dave Gordon wrote: The knowledge of how to derive the relevant client from the request should be localised within i915_guc_submission.c; the LRC code shouldn't have to know about the internal details of the GuC submission process. And all the information the GuC code needs

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/guc: don't spinwait if the GuC's workqueue is full

2016-05-10 Thread Tvrtko Ursulin
On 06/05/16 16:17, Dave Gordon wrote: On 29/04/16 16:45, Tvrtko Ursulin wrote: One late comment: On 27/04/16 19:03, Dave Gordon wrote: Rather than wait to see whether more space becomes available in the GuC submission workqueue, we can just return -EAGAIN and let the caller try again in a

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915/guc: add enable_guc_loading parameter

2016-05-10 Thread Tvrtko Ursulin
On 06/05/16 17:39, Dave Gordon wrote: On 29/04/16 16:03, Tvrtko Ursulin wrote: [snip] +goto fail; +if (fw_path == NULL) +goto fail; +if (*fw_path == '\0') { +DRM_ERROR("No GuC firmware known for this platform\n"); It is not an error unless

[Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add optional Werror.

2016-05-10 Thread Marius Vlad
v2: Initially added Werror by default. Make it optional so it doesn't break android build and (potential) distros maintaing the package (Hinted by Damien Lespiau). --enable-werror will enable -Werror compiler flag. Signed-off-by: Marius Vlad --- benchmarks/Makefile.am

[Intel-gfx] [PATCH i-g-t v2] tests/kms_flip: Adjust tolerance when counting frames

2016-05-10 Thread Gabriel Feceoru
If count == 100 and expected == 99 this condition fails (99*101/100 = 99.99). (v2): Increased the tolerance range, as suggested by Jani. Cc: Jani Nikula Cc: Daniel Vetter Signed-off-by: Gabriel Feceoru ---

[Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915: Use bitmask for IS_REVID checking (rev2)

2016-05-10 Thread Patchwork
== Series Details == Series: drm/i915: Use bitmask for IS_REVID checking (rev2) URL : https://patchwork.freedesktop.org/series/6972/ State : failure == Summary == Series 6972v2 drm/i915: Use bitmask for IS_REVID checking http://patchwork.freedesktop.org/api/1.0/series/6972/revisions/2/mbox

[Intel-gfx] [PATCH] drm: use seqlock for vblank time/count

2016-05-10 Thread Matthew Auld
This patch aims to replace the roll-your-own seqlock implementation with full-blown seqlock'. We also remove the timestamp ring-buffer in favour of single timestamp/count pair protected by a seqlock. In turn this means we can now increment the vblank freely without the need for clamping. v2: -

Re: [Intel-gfx] [PATCH v3 1/6] drm/i915/guc: distinguish HAS_GUC() from HAS_GUC_UCODE/HAS_GUC_SCHED

2016-05-10 Thread Tvrtko Ursulin
On 06/05/16 20:31, Dave Gordon wrote: For now, anything with a GuC requires uCode loading, and then supports command submission once loaded. But these are logically distinct from simply "having a GuC", so we need a separate macro for the latter. Then, the test in intel_guc_reset() should depend

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_flip: Adjust tolerance when counting frames

2016-05-10 Thread Gabriel Feceoru
On 10.05.2016 16:52, Jani Nikula wrote: On Tue, 10 May 2016, Gabriel Feceoru wrote: Comparing 2 numbers with 1% accuracy depends on which one is the reference. If count == 100 and expected == 99 this condition fails, although it should pass. Well, the expectation

Re: [Intel-gfx] [PATCH v2] drm/i915: Use bitmask for IS_REVID checking

2016-05-10 Thread Tvrtko Ursulin
On 10/05/16 14:53, Tvrtko Ursulin wrote: From: Tvrtko Ursulin With this scheme all call sites of IS_SKL_REVID and IS_BXT_REVID result in a maximum of one conditional jump instruction (was three before) and overall reduction in code size. v2: Simplified, now saves

Re: [Intel-gfx] [PATCH] drm/i915: Use bitmask for IS_REVID checking

2016-05-10 Thread Tvrtko Ursulin
Hi, On 10/05/16 14:33, Jani Nikula wrote: On Tue, 10 May 2016, Tvrtko Ursulin wrote: From: Tvrtko Ursulin With this scheme all call sites of IS_SKL_REVID and IS_BXT_REVID result in a maximum of one conditional jump instruction (was

[Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915: Use drm_i915_private as the native pointer for intel_uncore.c (rev3)

2016-05-10 Thread Patchwork
== Series Details == Series: drm/i915: Use drm_i915_private as the native pointer for intel_uncore.c (rev3) URL : https://patchwork.freedesktop.org/series/6915/ State : failure == Summary == Series 6915v3 drm/i915: Use drm_i915_private as the native pointer for intel_uncore.c

[Intel-gfx] [PATCH v2] drm/i915: Use bitmask for IS_REVID checking

2016-05-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin With this scheme all call sites of IS_SKL_REVID and IS_BXT_REVID result in a maximum of one conditional jump instruction (was three before) and overall reduction in code size. v2: Simplified, now saves ~880 bytes of text. Signed-off-by: Tvrtko

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_flip: Adjust tolerance when counting frames

2016-05-10 Thread Jani Nikula
On Tue, 10 May 2016, Gabriel Feceoru wrote: > Comparing 2 numbers with 1% accuracy depends on which one is the > reference. If count == 100 and expected == 99 this condition fails, > although it should pass. Well, the expectation should be the reference. If you expect

[Intel-gfx] ✗ Ro.CI.BAT: warning for drm/i915: Use bitmask for IS_REVID checking

2016-05-10 Thread Patchwork
== Series Details == Series: drm/i915: Use bitmask for IS_REVID checking URL : https://patchwork.freedesktop.org/series/6972/ State : warning == Summary == Series 6972v1 drm/i915: Use bitmask for IS_REVID checking http://patchwork.freedesktop.org/api/1.0/series/6972/revisions/1/mbox Test

Re: [Intel-gfx] [PATCH] drm/i915: Use bitmask for IS_REVID checking

2016-05-10 Thread Jani Nikula
On Tue, 10 May 2016, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > With this scheme all call sites of IS_SKL_REVID and IS_BXT_REVID > result in a maximum of one conditional jump instruction (was > three before) and overall reduction in

[Intel-gfx] ✗ Ro.CI.BAT: warning for drm/i915: Use bitmask for IS_REVID checking

2016-05-10 Thread Patchwork
== Series Details == Series: drm/i915: Use bitmask for IS_REVID checking URL : https://patchwork.freedesktop.org/series/6972/ State : warning == Summary == Series 6972v1 drm/i915: Use bitmask for IS_REVID checking http://patchwork.freedesktop.org/api/1.0/series/6972/revisions/1/mbox Test

Re: [Intel-gfx] [PATCH 27/35] drm/tegra: Use lockless gem BO free callback

2016-05-10 Thread Thierry Reding
On Tue, Apr 26, 2016 at 07:30:00PM +0200, Daniel Vetter wrote: > No dev->struct_mutex anywhere to be seen. > > Cc: Thierry Reding > Cc: Terje Bergström > Cc: linux-te...@vger.kernel.org > Signed-off-by: Daniel Vetter >

[Intel-gfx] [PATCH i-g-t] tests/kms_flip: Adjust tolerance when counting frames

2016-05-10 Thread Gabriel Feceoru
Comparing 2 numbers with 1% accuracy depends on which one is the reference. If count == 100 and expected == 99 this condition fails, although it should pass. Signed-off-by: Gabriel Feceoru --- tests/kms_flip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[Intel-gfx] [CI] drm/i915: Use drm_i915_private as the native pointer for intel_uncore.c

2016-05-10 Thread Chris Wilson
Pass drm_i915_private to the uncore init/fini routines and their subservients as it is their native type. textdata bss dec hex filename 6309978 3578778 696320 10585076 a183f4 vmlinux 6309530 3578778 696320 10584628 a18234 vmlinux a modest 400 bytes of saving,

[Intel-gfx] [PATCH] drm/i915: Use bitmask for IS_REVID checking

2016-05-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin With this scheme all call sites of IS_SKL_REVID and IS_BXT_REVID result in a maximum of one conditional jump instruction (was three before) and overall reduction in code size. Signed-off-by: Tvrtko Ursulin Cc: Chris

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Step away from symbolic links

2016-05-10 Thread Mika Kuoppala
Patrik Jakobsson writes: > [ text/plain ] > Load specific firmware versions for the DMC instead of using symbolic > links. The currently recommended versions are: SKL 1.26, KBL 1.01 and > BXT 1.07. > We should augment the commit message to answer the 'why'

[Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915/dmc: Step away from symbolic links

2016-05-10 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Step away from symbolic links URL : https://patchwork.freedesktop.org/series/6966/ State : failure == Summary == Series 6966v1 drm/i915/dmc: Step away from symbolic links http://patchwork.freedesktop.org/api/1.0/series/6966/revisions/1/mbox Test

Re: [Intel-gfx] [PATCH 06/19] Revert "drm/i915: Avoid stalling on pending flips for legacy cursor updates"

2016-05-10 Thread Patrik Jakobsson
On Tue, Apr 19, 2016 at 09:52:26AM +0200, Maarten Lankhorst wrote: > This reverts commit acf4e84d6167317ff21be5c03e1ea76ea5783701. > Unfortunately this breaks the next commit with a use-after-free, so > temporarily revert until we can apply a solution. > > Signed-off-by: Maarten Lankhorst

Re: [Intel-gfx] [PATCH 04/19] drm/i915: Add support for detecting vblanks when hw frame counter is unavailable.

2016-05-10 Thread Patrik Jakobsson
On Wed, Apr 27, 2016 at 05:23:06PM +0300, Ville Syrjälä wrote: > On Wed, Apr 27, 2016 at 04:06:16PM +0200, Patrik Jakobsson wrote: > > On Tue, Apr 19, 2016 at 09:52:24AM +0200, Maarten Lankhorst wrote: > > > This uses the newly created drm_accurate_vblank_count_and_time to > > > accurately > > >

[Intel-gfx] [PATCH] sna/video sprite patch: support for multiple xv ports (exposes minimum Xv ports)

2016-05-10 Thread Michael Hadley
The current driver exposes a single adaptor port so that only one Xv video can be played using a single sprite at a given time. This change will allow available hardware sprites to be used. Exposes the minimum Xv sprite ports to be compatible with older X11. v2: function sna_video_num_sprites()

[Intel-gfx] [PATCH] drm/i915/dmc: Step away from symbolic links

2016-05-10 Thread Patrik Jakobsson
Load specific firmware versions for the DMC instead of using symbolic links. The currently recommended versions are: SKL 1.26, KBL 1.01 and BXT 1.07. Cc: Rodrigo Vivi Cc: Imre Deak Cc: Mika Kuoppala Signed-off-by:

[Intel-gfx] [PATCH 4/5] drm/i915: Do not use a bitfield for INTEL_INFO->num_pipes

2016-05-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It just makes more work for the compiler and generates more code. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h | 2 +- 1 file changed, 1

[Intel-gfx] [PATCH 1/5] drm/i915: Make IS_GENx macros work on a mask

2016-05-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If instead of numerical comparison me make these test a bitmask, we enable the compiler to optimize all instances of IS_GENx || IS_GENy. v2: Make bit zero of gen mask mean gen 1. Signed-off-by: Tvrtko Ursulin

[Intel-gfx] [PATCH 3/5] drm/i915: Replace "INTEL_INFO->gen == x" checks with IS_GENx

2016-05-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This way optimization from a previous patch works even better. v2: Rebase. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Reviewed-by: Jani Nikula ---

[Intel-gfx] [PATCH 2/5] drm/i915: Promote IS_BROADWELL to a simple macro

2016-05-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If we allow it a dedicated flag in dev_priv we enable the compiler to nicely optimize conditions like IS_HASSWELL || IS_BROADWELL. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson ---

[Intel-gfx] [PATCH 5/5] drm/i915: Introduce IS_GEN macro

2016-05-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To be used for more efficient Gen range checking. v2: Remove spurious chunk. (Chris Wilson) v3: Rebase. v4: Renamed from INTEL_GEN_RANGE and added GEN_FOREVER. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Check pixel rate for DP to VGA dongle

2016-05-10 Thread Ville Syrjälä
On Tue, May 10, 2016 at 12:44:22PM +0300, Mika Kahola wrote: > On Tue, 2016-05-03 at 16:28 +0200, Daniel Vetter wrote: > > On Tue, May 03, 2016 at 04:23:34PM +0300, Ville Syrjälä wrote: > > > On Tue, May 03, 2016 at 02:46:36PM +0300, Mika Kahola wrote: > > > > Prep work to improve DP branch device

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Check pixel rate for DP to VGA dongle

2016-05-10 Thread Mika Kahola
On Tue, 2016-05-03 at 16:28 +0200, Daniel Vetter wrote: > On Tue, May 03, 2016 at 04:23:34PM +0300, Ville Syrjälä wrote: > > On Tue, May 03, 2016 at 02:46:36PM +0300, Mika Kahola wrote: > > > Prep work to improve DP branch device handling. > > > > > > Filter out a mode that exceeds the max pixel

Re: [Intel-gfx] [PATCH] drm/i915: Re-enable GGTT earlier during resume on pre-gen6 platforms

2016-05-10 Thread Ville Syrjälä
On Tue, May 10, 2016 at 10:14:19AM +0100, Chris Wilson wrote: > On Fri, May 06, 2016 at 09:35:55PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Move the intel_enable_gtt() call to happen before we touch the GTT > > during resume.

Re: [Intel-gfx] [PATCH maintainer-tools v4] dim: Resist committing patches that modify files outside of i915

2016-05-10 Thread Joonas Lahtinen
On ti, 2016-05-10 at 12:22 +0300, Jani Nikula wrote: > Acked-by: Jani Nikula Pushed to maintainer-tools. -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH] drm/i915: Fixed compilation error

2016-05-10 Thread Jani Nikula
On Tue, 10 May 2016, Ville Syrjälä wrote: > On Tue, May 10, 2016 at 11:34:39AM +0300, Gabriel Feceoru wrote: >> Signed-off-by: Gabriel Feceoru >> --- >> drivers/gpu/drm/i915/intel_hdmi.c | 2 +- >> 1 file changed, 1 insertion(+), 1

Re: [Intel-gfx] [PATCH maintainer-tools v4] dim: Resist committing patches that modify files outside of i915

2016-05-10 Thread Jani Nikula
On Tue, 10 May 2016, Joonas Lahtinen wrote: > If committing to drm-intel-next-queued branch, require the committer > to be aware that they are committing outside of drm/i915 maintenance > scope. > > v2: > - Do not use warn_or_fail (Jani) > - Only apply to

Re: [Intel-gfx] [PATCH] drm/i915: Re-enable GGTT earlier during resume on pre-gen6 platforms

2016-05-10 Thread Chris Wilson
On Fri, May 06, 2016 at 09:35:55PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Move the intel_enable_gtt() call to happen before we touch the GTT > during resume. Right now it's done way too late. Before > commit ebb7c78d358b

[Intel-gfx] [drm-intel:drm-intel-nightly 12/22] drivers/gpu/drm/i915/intel_drv.h:36:41: fatal error: drm/drm_dp_dual_mode_helper.h: No such file or directory

2016-05-10 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-nightly head: 0ab3c45d270cc4dce75993a749dc11d12f8746cb commit: 2f428da8a77487d943ab9c255518832fdd3953cc [12/22] drm/i915: Respect DP++ adaptor TMDS clock limit config: i386-defconfig (attached as .config) compiler: gcc-6 (Debian 6.1.1-1)

Re: [Intel-gfx] [PATCH] drm/i915: Fixed compilation error

2016-05-10 Thread Ville Syrjälä
On Tue, May 10, 2016 at 11:34:39AM +0300, Gabriel Feceoru wrote: > Signed-off-by: Gabriel Feceoru > --- > drivers/gpu/drm/i915/intel_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c >

Re: [Intel-gfx] [PATCH maintainer-tools v3] dim: Resist committing patches that modify files outside of i915

2016-05-10 Thread Joonas Lahtinen
Disregard this v3. On ti, 2016-05-10 at 11:50 +0300, Joonas Lahtinen wrote: > If committing to drm-intel-next-queued branch, require the committer > to be aware that they are committing outside of drm/i915 maintenance > scope. > > v2: > - Do not use warn_or_fail (Jani) > - Only apply to

[Intel-gfx] [PATCH maintainer-tools v4] dim: Resist committing patches that modify files outside of i915

2016-05-10 Thread Joonas Lahtinen
If committing to drm-intel-next-queued branch, require the committer to be aware that they are committing outside of drm/i915 maintenance scope. v2: - Do not use warn_or_fail (Jani) - Only apply to drm-intel-next-queued branch (Daniel) v3: - Do not use HEAD but $commit (Jani) Cc: Daniel Vetter

[Intel-gfx] [PATCH maintainer-tools v3] dim: Resist committing patches that modify files outside of i915

2016-05-10 Thread Joonas Lahtinen
If committing to drm-intel-next-queued branch, require the committer to be aware that they are committing outside of drm/i915 maintenance scope. v2: - Do not use warn_or_fail (Jani) - Only apply to drm-intel-next-queued branch (Daniel) v3: - Do not use HEAD but $commit (Jani) Cc: Daniel Vetter

Re: [Intel-gfx] [PATCH maintainer-tools v2] dim: Resist committing patches that modify files outside of i915

2016-05-10 Thread Jani Nikula
On Tue, 10 May 2016, Joonas Lahtinen wrote: > If committing to drm-intel-next-queued branch, require the committer > to be aware that they are committing outside of drm/i915 maintenance > scope. > > v2: > - Do not use warn_or_fail (Jani) > - Only apply to

[Intel-gfx] [PATCH] drm/i915: Fixed compilation error

2016-05-10 Thread Gabriel Feceoru
Signed-off-by: Gabriel Feceoru --- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index 4d65f69..bedb9ef 100644 ---

[Intel-gfx] [PATCH maintainer-tools v2] dim: Resist committing patches that modify files outside of i915

2016-05-10 Thread Joonas Lahtinen
If committing to drm-intel-next-queued branch, require the committer to be aware that they are committing outside of drm/i915 maintenance scope. v2: - Do not use warn_or_fail (Jani) - Only apply to drm-intel-next-queued branch (Daniel) Cc: Daniel Vetter Cc: Jani Nikula

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Introduce INTEL_GEN_RANGE macro

2016-05-10 Thread Jani Nikula
On Mon, 09 May 2016, Chris Wilson wrote: > IS_GEN(p, start, end) using inclusive ranges is fine. > > This is a small patch that generates a remarkable amount of object code > reduction. Ok. I guess 0 is okay for start, but how about a "GEN_FOREVER" style macro for

Re: [Intel-gfx] [PATCH v2] drm/i915/execlists: Refactor common engine setup

2016-05-10 Thread Chris Wilson
On Tue, May 10, 2016 at 09:46:05AM +0200, Daniel Vetter wrote: > On Mon, May 09, 2016 at 11:41:41AM +0100, Chris Wilson wrote: > > On Mon, May 09, 2016 at 09:58:20AM +0200, Daniel Vetter wrote: > > > On Mon, May 09, 2016 at 08:45:16AM +0100, Chris Wilson wrote: > > > > This is sanitize. We do

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Fix modeset handling during gpu reset, v3.

2016-05-10 Thread Daniel Vetter
On Mon, May 09, 2016 at 03:54:15PM +0300, Ville Syrjälä wrote: > On Mon, May 09, 2016 at 01:04:21PM +0200, Maarten Lankhorst wrote: > > This function would call drm_modeset_lock_all, while the suspend/resume > > functions already have their own locking. Fix this by factoring out > >

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Replace "INTEL_INFO->gen == x" checks with IS_GENx

2016-05-10 Thread Jani Nikula
On Fri, 06 May 2016, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > This way optimization from a previous patch works even better. > > Signed-off-by: Tvrtko Ursulin Reviewed-by: Jani Nikula

Re: [Intel-gfx] [PATCH v2] drm/i915/execlists: Refactor common engine setup

2016-05-10 Thread Daniel Vetter
On Mon, May 09, 2016 at 11:41:41AM +0100, Chris Wilson wrote: > On Mon, May 09, 2016 at 09:58:20AM +0200, Daniel Vetter wrote: > > On Mon, May 09, 2016 at 08:45:16AM +0100, Chris Wilson wrote: > > > This is sanitize. We do enable it in engine->init_hw(), but the point > > > raised by Ville earlier

Re: [Intel-gfx] [PATCH i-g-t v4 5/5] lib/igt_kms: Added pipe_id_to_vbl_flag() to igt_kms.

2016-05-10 Thread Daniel Vetter
On Tue, Apr 26, 2016 at 11:54:22AM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > Added function pipe_id_to_vbl_flag() to igt_kms. > This function formats a pipe_id into the format > expected by DRM while processing DRM_IOCTL_WAIT_VBLANK. > >

[Intel-gfx] [CI] drm/i915: Use drm_i915_private as the native pointer for intel_uncore.c

2016-05-10 Thread Chris Wilson
Pass drm_i915_private to the uncore init/fini routines and their subservients as it is their native type. textdata bss dec hex filename 6309978 3578778 696320 10585076 a183f4 vmlinux 6309530 3578778 696320 10584628 a18234 vmlinux a modest 400 bytes of saving,

[Intel-gfx] ✗ Fi.CI.BAT: failure for IS_GENx and related code shrinkage (rev3)

2016-05-10 Thread Patchwork
== Series Details == Series: IS_GENx and related code shrinkage (rev3) URL : https://patchwork.freedesktop.org/series/6841/ State : failure == Summary == CC [M] drivers/net/ethernet/intel/e1000e/nvm.o CC [M] drivers/net/ethernet/intel/e1000e/phy.o LD drivers/usb/core/usbcore.o

Re: [Intel-gfx] [PATCH 17/35] drm/exynos: Use lockless gem BO free callback

2016-05-10 Thread Inki Dae
2016년 04월 27일 02:29에 Daniel Vetter 이(가) 쓴 글: > No dev->struct_mutex anywhere to be seen. Acked-by: Inki Dae Thanks, Inki Dae > > Cc: Inki Dae > Signed-off-by: Daniel Vetter > --- >

Re: [Intel-gfx] [PATCH 2/3] drm/exynos: Nuke dummy fb->dirty callback

2016-05-10 Thread Inki Dae
Hi Daniel, 2016년 04월 27일 20:38에 Daniel Vetter 이(가) 쓴 글: > It's an optional hook. Might be needed for frontbuffer rendering on > manual upload displays, but a simple TODO doesn't explain at all what > needs to be done or why. We have a plan for partial update support but not now yet. Picked it

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/atomic: Add a way to call remove_fb atomically, v2.

2016-05-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/atomic: Add a way to call remove_fb atomically, v2. URL : https://patchwork.freedesktop.org/series/6906/ State : failure == Summary == Series 6906v1 Series without cover letter

Re: [Intel-gfx] [PATCH v2] x86: Silence 32bit compiler warning in intel_graphics_stolen()

2016-05-10 Thread Joonas Lahtinen
On ma, 2016-05-09 at 17:39 +0100, Chris Wilson wrote: > arch/x86/kernel/early-quirks.c: In function ‘intel_graphics_stolen’: > arch/x86/kernel/early-quirks.c:539:9: warning: format ‘%llx’ expects > argument of type ‘long long unsigned int’, but argument 2 has type > ‘phys_addr_t’ [-Wformat=] >