== Series Details ==
Series: series starting with [1/5] drm/i915: Make IS_GENx macros work on a mask
URL : https://patchwork.freedesktop.org/series/6960/
State : success
== Summary ==
Series 6960v1 Series without cover letter
Reviewed-by: peter.anto...@intel.com
-Original Message-
From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of
Nick Hoath
Sent: Friday, May 6, 2016 11:43 AM
To: intel-gfx@lists.freedesktop.org
Cc: O'Rourke, Tom
Subject: [Intel-gfx] [PATCH
Reviewed-by: peter.anto...@intel.com
-Original Message-
From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of
Nick Hoath
Sent: Friday, May 6, 2016 11:43 AM
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Add Broxton GuC firmware
Hi Bob,
It was tested on a BXT-T RVP and LeafHill A and worked fine. The patch has been
in the Android tree for at least a couple of months (probably more) and has
seemed to be stable. But, not sure Android was run on the BXT CRB.
It could be the GuC firmware crashing, there are some fixes in
On Tue, May 10, 2016 at 08:19:50PM +0300, Ville Syrjälä wrote:
> On Tue, May 10, 2016 at 08:03:47PM +0300, Marius Vlad wrote:
> > Robert Foss improved test/kms_vblank and in the same time extended it on
> > all outputs and all pipes. The following seems to happen on pipe B (on
> > pipe A the test
On Tue, Apr 26, 2016 at 11:54:22AM -0400, robert.f...@collabora.com wrote:
> From: Robert Foss
>
> Added function pipe_id_to_vbl_flag() to igt_kms.
> This function formats a pipe_id into the format
> expected by DRM while processing DRM_IOCTL_WAIT_VBLANK.
>
>
On Tue, May 10, 2016 at 08:19:50PM +0300, Ville Syrjälä wrote:
> > [46796.049127] [drm:drm_update_vblank_count] updating vblank count on crtc
> > 1: current=72, diff=1, hw=72 hw_last=71
> > [46796.049129] [drm:drm_handle_vblank_events] vblank event on 73, current 73
>
> Either we had a stale
Op 10-05-16 om 09:48 schreef Daniel Vetter:
> On Mon, May 09, 2016 at 03:54:15PM +0300, Ville Syrjälä wrote:
>> On Mon, May 09, 2016 at 01:04:21PM +0200, Maarten Lankhorst wrote:
>>> This function would call drm_modeset_lock_all, while the suspend/resume
>>> functions already have their own
On Tue, 10 May 2016, Patrik Jakobsson wrote:
> On Tue, May 10, 2016 at 03:52:02PM +0300, Mika Kuoppala wrote:
>> Patrik Jakobsson writes:
>>
>> > [ text/plain ]
>> > Load specific firmware versions for the DMC instead of using
Hi,
If this still happens, and you can compile and use
drm-intel-nightly (from https://cgit.freedesktop.org/drm-intel/,
a build guide is available at [2]) please submit a bug at [1].
[1]
https://bugs.freedesktop.org/enter_bug.cgi?product=DRI=DRM/Intel
[2]
On Tue, 26 Apr 2016 10:11:41 +0100
Peter Antoine wrote:
> This patch resizes the GuC WOPCM to so that the GuC and the RC6 memory
> spaces do not overlap.
Hi Peter,
With this patch applied to our IOTG kernel tree, I see a regression
with the RC6 residency values. The
On Tue, May 10, 2016 at 05:32:15PM +0300, Marius Vlad wrote:
> v2: Initially added Werror by default. Make it optional so it doesn't
> break android build and (potential) distros maintaing the package
> (Hinted by Damien Lespiau).
>
> --enable-werror will enable -Werror compiler flag.
>
>
On Tue, 10 May 2016, Gabriel Feceoru wrote:
> If count == 100 and expected == 99 this condition fails (99*101/100 = 99.99).
>
> (v2): Increased the tolerance range, as suggested by Jani.
>
> Cc: Jani Nikula
> Cc: Daniel Vetter
On Tue, May 10, 2016 at 03:52:02PM +0300, Mika Kuoppala wrote:
> Patrik Jakobsson writes:
>
> > [ text/plain ]
> > Load specific firmware versions for the DMC instead of using symbolic
> > links. The currently recommended versions are: SKL 1.26, KBL 1.01 and
> >
On 06/05/16 20:31, Dave Gordon wrote:
Mostly little optimisations and future-proofing against code breakage.
For instance, if the driver is correctly following the submission
protocol, the "out of space" condition is impossible, so the previous
runtime WARN_ON() is promoted to a GEM_BUG_ON()
On 06/05/16 20:31, Dave Gordon wrote:
This patch simply changes the default value of "enable_guc_submission"
from 0 (never) to -1 (auto). This means that GuC submission will be
used if the platform has a GuC, the GuC supports the request submission
protocol, and any required GuC firmwware was
== Series Details ==
Series: drm: use seqlock for vblank time/count
URL : https://patchwork.freedesktop.org/series/6981/
State : failure
== Summary ==
Series 6981v1 drm: use seqlock for vblank time/count
http://patchwork.freedesktop.org/api/1.0/series/6981/revisions/1/mbox
Test
On 06/05/16 20:31, Dave Gordon wrote:
The knowledge of how to derive the relevant client from the request
should be localised within i915_guc_submission.c; the LRC code shouldn't
have to know about the internal details of the GuC submission process.
And all the information the GuC code needs
On 06/05/16 16:17, Dave Gordon wrote:
On 29/04/16 16:45, Tvrtko Ursulin wrote:
One late comment:
On 27/04/16 19:03, Dave Gordon wrote:
Rather than wait to see whether more space becomes available in the GuC
submission workqueue, we can just return -EAGAIN and let the caller try
again in a
On 06/05/16 17:39, Dave Gordon wrote:
On 29/04/16 16:03, Tvrtko Ursulin wrote:
[snip]
+goto fail;
+if (fw_path == NULL)
+goto fail;
+if (*fw_path == '\0') {
+DRM_ERROR("No GuC firmware known for this platform\n");
It is not an error unless
v2: Initially added Werror by default. Make it optional so it doesn't
break android build and (potential) distros maintaing the package
(Hinted by Damien Lespiau).
--enable-werror will enable -Werror compiler flag.
Signed-off-by: Marius Vlad
---
benchmarks/Makefile.am
If count == 100 and expected == 99 this condition fails (99*101/100 = 99.99).
(v2): Increased the tolerance range, as suggested by Jani.
Cc: Jani Nikula
Cc: Daniel Vetter
Signed-off-by: Gabriel Feceoru
---
== Series Details ==
Series: drm/i915: Use bitmask for IS_REVID checking (rev2)
URL : https://patchwork.freedesktop.org/series/6972/
State : failure
== Summary ==
Series 6972v2 drm/i915: Use bitmask for IS_REVID checking
http://patchwork.freedesktop.org/api/1.0/series/6972/revisions/2/mbox
This patch aims to replace the roll-your-own seqlock implementation with
full-blown seqlock'. We also remove the timestamp ring-buffer in favour
of single timestamp/count pair protected by a seqlock. In turn this
means we can now increment the vblank freely without the need for
clamping.
v2:
-
On 06/05/16 20:31, Dave Gordon wrote:
For now, anything with a GuC requires uCode loading, and then supports
command submission once loaded. But these are logically distinct from
simply "having a GuC", so we need a separate macro for the latter. Then,
the test in intel_guc_reset() should depend
On 10.05.2016 16:52, Jani Nikula wrote:
On Tue, 10 May 2016, Gabriel Feceoru wrote:
Comparing 2 numbers with 1% accuracy depends on which one is the
reference. If count == 100 and expected == 99 this condition fails,
although it should pass.
Well, the expectation
On 10/05/16 14:53, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
With this scheme all call sites of IS_SKL_REVID and IS_BXT_REVID
result in a maximum of one conditional jump instruction (was
three before) and overall reduction in code size.
v2: Simplified, now saves
Hi,
On 10/05/16 14:33, Jani Nikula wrote:
On Tue, 10 May 2016, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
With this scheme all call sites of IS_SKL_REVID and IS_BXT_REVID
result in a maximum of one conditional jump instruction (was
== Series Details ==
Series: drm/i915: Use drm_i915_private as the native pointer for intel_uncore.c
(rev3)
URL : https://patchwork.freedesktop.org/series/6915/
State : failure
== Summary ==
Series 6915v3 drm/i915: Use drm_i915_private as the native pointer for
intel_uncore.c
From: Tvrtko Ursulin
With this scheme all call sites of IS_SKL_REVID and IS_BXT_REVID
result in a maximum of one conditional jump instruction (was
three before) and overall reduction in code size.
v2: Simplified, now saves ~880 bytes of text.
Signed-off-by: Tvrtko
On Tue, 10 May 2016, Gabriel Feceoru wrote:
> Comparing 2 numbers with 1% accuracy depends on which one is the
> reference. If count == 100 and expected == 99 this condition fails,
> although it should pass.
Well, the expectation should be the reference. If you expect
== Series Details ==
Series: drm/i915: Use bitmask for IS_REVID checking
URL : https://patchwork.freedesktop.org/series/6972/
State : warning
== Summary ==
Series 6972v1 drm/i915: Use bitmask for IS_REVID checking
http://patchwork.freedesktop.org/api/1.0/series/6972/revisions/1/mbox
Test
On Tue, 10 May 2016, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> With this scheme all call sites of IS_SKL_REVID and IS_BXT_REVID
> result in a maximum of one conditional jump instruction (was
> three before) and overall reduction in
== Series Details ==
Series: drm/i915: Use bitmask for IS_REVID checking
URL : https://patchwork.freedesktop.org/series/6972/
State : warning
== Summary ==
Series 6972v1 drm/i915: Use bitmask for IS_REVID checking
http://patchwork.freedesktop.org/api/1.0/series/6972/revisions/1/mbox
Test
On Tue, Apr 26, 2016 at 07:30:00PM +0200, Daniel Vetter wrote:
> No dev->struct_mutex anywhere to be seen.
>
> Cc: Thierry Reding
> Cc: Terje Bergström
> Cc: linux-te...@vger.kernel.org
> Signed-off-by: Daniel Vetter
>
Comparing 2 numbers with 1% accuracy depends on which one is the
reference. If count == 100 and expected == 99 this condition fails,
although it should pass.
Signed-off-by: Gabriel Feceoru
---
tests/kms_flip.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Pass drm_i915_private to the uncore init/fini routines and their
subservients as it is their native type.
textdata bss dec hex filename
6309978 3578778 696320 10585076 a183f4 vmlinux
6309530 3578778 696320 10584628 a18234 vmlinux
a modest 400 bytes of saving,
From: Tvrtko Ursulin
With this scheme all call sites of IS_SKL_REVID and IS_BXT_REVID
result in a maximum of one conditional jump instruction (was
three before) and overall reduction in code size.
Signed-off-by: Tvrtko Ursulin
Cc: Chris
Patrik Jakobsson writes:
> [ text/plain ]
> Load specific firmware versions for the DMC instead of using symbolic
> links. The currently recommended versions are: SKL 1.26, KBL 1.01 and
> BXT 1.07.
>
We should augment the commit message to answer the 'why'
== Series Details ==
Series: drm/i915/dmc: Step away from symbolic links
URL : https://patchwork.freedesktop.org/series/6966/
State : failure
== Summary ==
Series 6966v1 drm/i915/dmc: Step away from symbolic links
http://patchwork.freedesktop.org/api/1.0/series/6966/revisions/1/mbox
Test
On Tue, Apr 19, 2016 at 09:52:26AM +0200, Maarten Lankhorst wrote:
> This reverts commit acf4e84d6167317ff21be5c03e1ea76ea5783701.
> Unfortunately this breaks the next commit with a use-after-free, so
> temporarily revert until we can apply a solution.
>
> Signed-off-by: Maarten Lankhorst
On Wed, Apr 27, 2016 at 05:23:06PM +0300, Ville Syrjälä wrote:
> On Wed, Apr 27, 2016 at 04:06:16PM +0200, Patrik Jakobsson wrote:
> > On Tue, Apr 19, 2016 at 09:52:24AM +0200, Maarten Lankhorst wrote:
> > > This uses the newly created drm_accurate_vblank_count_and_time to
> > > accurately
> > >
The current driver exposes a single adaptor port so that only one Xv video
can be played using a single sprite at a given time. This change will allow
available hardware sprites to be used. Exposes the minimum Xv sprite ports
to be compatible with older X11.
v2: function sna_video_num_sprites()
Load specific firmware versions for the DMC instead of using symbolic
links. The currently recommended versions are: SKL 1.26, KBL 1.01 and
BXT 1.07.
Cc: Rodrigo Vivi
Cc: Imre Deak
Cc: Mika Kuoppala
Signed-off-by:
From: Tvrtko Ursulin
It just makes more work for the compiler and generates more code.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.h | 2 +-
1 file changed, 1
From: Tvrtko Ursulin
If instead of numerical comparison me make these test a
bitmask, we enable the compiler to optimize all instances
of IS_GENx || IS_GENy.
v2: Make bit zero of gen mask mean gen 1.
Signed-off-by: Tvrtko Ursulin
From: Tvrtko Ursulin
This way optimization from a previous patch works even better.
v2: Rebase.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
Reviewed-by: Jani Nikula
---
From: Tvrtko Ursulin
If we allow it a dedicated flag in dev_priv we enable the
compiler to nicely optimize conditions like IS_HASSWELL ||
IS_BROADWELL.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
---
From: Tvrtko Ursulin
To be used for more efficient Gen range checking.
v2: Remove spurious chunk. (Chris Wilson)
v3: Rebase.
v4: Renamed from INTEL_GEN_RANGE and added GEN_FOREVER.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
On Tue, May 10, 2016 at 12:44:22PM +0300, Mika Kahola wrote:
> On Tue, 2016-05-03 at 16:28 +0200, Daniel Vetter wrote:
> > On Tue, May 03, 2016 at 04:23:34PM +0300, Ville Syrjälä wrote:
> > > On Tue, May 03, 2016 at 02:46:36PM +0300, Mika Kahola wrote:
> > > > Prep work to improve DP branch device
On Tue, 2016-05-03 at 16:28 +0200, Daniel Vetter wrote:
> On Tue, May 03, 2016 at 04:23:34PM +0300, Ville Syrjälä wrote:
> > On Tue, May 03, 2016 at 02:46:36PM +0300, Mika Kahola wrote:
> > > Prep work to improve DP branch device handling.
> > >
> > > Filter out a mode that exceeds the max pixel
On Tue, May 10, 2016 at 10:14:19AM +0100, Chris Wilson wrote:
> On Fri, May 06, 2016 at 09:35:55PM +0300, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > Move the intel_enable_gtt() call to happen before we touch the GTT
> > during resume.
On ti, 2016-05-10 at 12:22 +0300, Jani Nikula wrote:
> Acked-by: Jani Nikula
Pushed to maintainer-tools.
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
On Tue, 10 May 2016, Ville Syrjälä wrote:
> On Tue, May 10, 2016 at 11:34:39AM +0300, Gabriel Feceoru wrote:
>> Signed-off-by: Gabriel Feceoru
>> ---
>> drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1
On Tue, 10 May 2016, Joonas Lahtinen wrote:
> If committing to drm-intel-next-queued branch, require the committer
> to be aware that they are committing outside of drm/i915 maintenance
> scope.
>
> v2:
> - Do not use warn_or_fail (Jani)
> - Only apply to
On Fri, May 06, 2016 at 09:35:55PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Move the intel_enable_gtt() call to happen before we touch the GTT
> during resume. Right now it's done way too late. Before
> commit ebb7c78d358b
tree: git://anongit.freedesktop.org/drm-intel drm-intel-nightly
head: 0ab3c45d270cc4dce75993a749dc11d12f8746cb
commit: 2f428da8a77487d943ab9c255518832fdd3953cc [12/22] drm/i915: Respect DP++
adaptor TMDS clock limit
config: i386-defconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1)
On Tue, May 10, 2016 at 11:34:39AM +0300, Gabriel Feceoru wrote:
> Signed-off-by: Gabriel Feceoru
> ---
> drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
>
Disregard this v3.
On ti, 2016-05-10 at 11:50 +0300, Joonas Lahtinen wrote:
> If committing to drm-intel-next-queued branch, require the committer
> to be aware that they are committing outside of drm/i915 maintenance
> scope.
>
> v2:
> - Do not use warn_or_fail (Jani)
> - Only apply to
If committing to drm-intel-next-queued branch, require the committer
to be aware that they are committing outside of drm/i915 maintenance
scope.
v2:
- Do not use warn_or_fail (Jani)
- Only apply to drm-intel-next-queued branch (Daniel)
v3:
- Do not use HEAD but $commit (Jani)
Cc: Daniel Vetter
If committing to drm-intel-next-queued branch, require the committer
to be aware that they are committing outside of drm/i915 maintenance
scope.
v2:
- Do not use warn_or_fail (Jani)
- Only apply to drm-intel-next-queued branch (Daniel)
v3:
- Do not use HEAD but $commit (Jani)
Cc: Daniel Vetter
On Tue, 10 May 2016, Joonas Lahtinen wrote:
> If committing to drm-intel-next-queued branch, require the committer
> to be aware that they are committing outside of drm/i915 maintenance
> scope.
>
> v2:
> - Do not use warn_or_fail (Jani)
> - Only apply to
Signed-off-by: Gabriel Feceoru
---
drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
b/drivers/gpu/drm/i915/intel_hdmi.c
index 4d65f69..bedb9ef 100644
---
If committing to drm-intel-next-queued branch, require the committer
to be aware that they are committing outside of drm/i915 maintenance
scope.
v2:
- Do not use warn_or_fail (Jani)
- Only apply to drm-intel-next-queued branch (Daniel)
Cc: Daniel Vetter
Cc: Jani Nikula
On Mon, 09 May 2016, Chris Wilson wrote:
> IS_GEN(p, start, end) using inclusive ranges is fine.
>
> This is a small patch that generates a remarkable amount of object code
> reduction.
Ok.
I guess 0 is okay for start, but how about a "GEN_FOREVER" style macro
for
On Tue, May 10, 2016 at 09:46:05AM +0200, Daniel Vetter wrote:
> On Mon, May 09, 2016 at 11:41:41AM +0100, Chris Wilson wrote:
> > On Mon, May 09, 2016 at 09:58:20AM +0200, Daniel Vetter wrote:
> > > On Mon, May 09, 2016 at 08:45:16AM +0100, Chris Wilson wrote:
> > > > This is sanitize. We do
On Mon, May 09, 2016 at 03:54:15PM +0300, Ville Syrjälä wrote:
> On Mon, May 09, 2016 at 01:04:21PM +0200, Maarten Lankhorst wrote:
> > This function would call drm_modeset_lock_all, while the suspend/resume
> > functions already have their own locking. Fix this by factoring out
> >
On Fri, 06 May 2016, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> This way optimization from a previous patch works even better.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by: Jani Nikula
On Mon, May 09, 2016 at 11:41:41AM +0100, Chris Wilson wrote:
> On Mon, May 09, 2016 at 09:58:20AM +0200, Daniel Vetter wrote:
> > On Mon, May 09, 2016 at 08:45:16AM +0100, Chris Wilson wrote:
> > > This is sanitize. We do enable it in engine->init_hw(), but the point
> > > raised by Ville earlier
On Tue, Apr 26, 2016 at 11:54:22AM -0400, robert.f...@collabora.com wrote:
> From: Robert Foss
>
> Added function pipe_id_to_vbl_flag() to igt_kms.
> This function formats a pipe_id into the format
> expected by DRM while processing DRM_IOCTL_WAIT_VBLANK.
>
>
Pass drm_i915_private to the uncore init/fini routines and their
subservients as it is their native type.
textdata bss dec hex filename
6309978 3578778 696320 10585076 a183f4 vmlinux
6309530 3578778 696320 10584628 a18234 vmlinux
a modest 400 bytes of saving,
== Series Details ==
Series: IS_GENx and related code shrinkage (rev3)
URL : https://patchwork.freedesktop.org/series/6841/
State : failure
== Summary ==
CC [M] drivers/net/ethernet/intel/e1000e/nvm.o
CC [M] drivers/net/ethernet/intel/e1000e/phy.o
LD drivers/usb/core/usbcore.o
2016년 04월 27일 02:29에 Daniel Vetter 이(가) 쓴 글:
> No dev->struct_mutex anywhere to be seen.
Acked-by: Inki Dae
Thanks,
Inki Dae
>
> Cc: Inki Dae
> Signed-off-by: Daniel Vetter
> ---
>
Hi Daniel,
2016년 04월 27일 20:38에 Daniel Vetter 이(가) 쓴 글:
> It's an optional hook. Might be needed for frontbuffer rendering on
> manual upload displays, but a simple TODO doesn't explain at all what
> needs to be done or why.
We have a plan for partial update support but not now yet. Picked it
== Series Details ==
Series: series starting with [1/2] drm/atomic: Add a way to call remove_fb
atomically, v2.
URL : https://patchwork.freedesktop.org/series/6906/
State : failure
== Summary ==
Series 6906v1 Series without cover letter
On ma, 2016-05-09 at 17:39 +0100, Chris Wilson wrote:
> arch/x86/kernel/early-quirks.c: In function ‘intel_graphics_stolen’:
> arch/x86/kernel/early-quirks.c:539:9: warning: format ‘%llx’ expects
> argument of type ‘long long unsigned int’, but argument 2 has type
> ‘phys_addr_t’ [-Wformat=]
>
76 matches
Mail list logo