Re: [Intel-gfx] [Heads up to maintainers] Re: [PATCH v8 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-29 Thread Jani Nikula
On Thu, 29 Apr 2021, Lyude Paul wrote: > JFYI Jani and Ben: I will be pushing this patch to drm-misc-next sometime > today if there's no objections Thanks for the heads-up, I think this breaks i915. See my review comments elsewhere in the thread. BR, Jani. > > On Wed, 2021-04-28 at 19:43

Re: [Intel-gfx] [PATCH v8 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-29 Thread Jani Nikula
On Wed, 28 Apr 2021, Nikola Cornij wrote: > [why] > DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is > set, Extended Base Receiver Capability DPCD space must be used. Without > doing that, the three DPCD values that differ will be wrong, leading to > incorrect or limited

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-29 Thread Matthew Brost
On Thu, Apr 29, 2021 at 02:14:19PM +0200, Daniel Vetter wrote: > On Wed, Apr 28, 2021 at 01:17:27PM -0500, Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 1:02 PM Matthew Brost > > wrote: > > > > > > On Wed, Apr 28, 2021 at 12:46:07PM -0500, Jason Ekstrand wrote: > > > > On Wed, Apr 28, 2021

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/drm_mst: Use Extended Base Receiver Capability (rev8)

2021-04-29 Thread Patchwork
== Series Details == Series: drm/drm_mst: Use Extended Base Receiver Capability (rev8) URL : https://patchwork.freedesktop.org/series/89590/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10029_full -> Patchwork_20042_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: ioctl clean-ups (rev3)

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915/gem: ioctl clean-ups (rev3) URL : https://patchwork.freedesktop.org/series/89443/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10028_full -> Patchwork_20040_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/drm_mst: Use Extended Base Receiver Capability (rev8)

2021-04-29 Thread Patchwork
== Series Details == Series: drm/drm_mst: Use Extended Base Receiver Capability (rev8) URL : https://patchwork.freedesktop.org/series/89590/ State : success == Summary == CI Bug Log - changes from CI_DRM_10029 -> Patchwork_20042 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix wrong name announced on FB driver switching

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Fix wrong name announced on FB driver switching URL : https://patchwork.freedesktop.org/series/89663/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10027_full -> Patchwork_20039_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/drm_mst: Use Extended Base Receiver Capability (rev8)

2021-04-29 Thread Patchwork
== Series Details == Series: drm/drm_mst: Use Extended Base Receiver Capability (rev8) URL : https://patchwork.freedesktop.org/series/89590/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9065f2549c27 drm/drm_mst: Use Extended Base Receiver Capability DPCD space -:22:

Re: [Intel-gfx] linux-next: manual merge of the drm-intel tree with the drm tree

2021-04-29 Thread Stephen Rothwell
Hi all, On Thu, 18 Mar 2021 12:52:41 +1100 Stephen Rothwell wrote: > > On Wed, 17 Mar 2021 14:08:24 +1100 Stephen Rothwell > wrote: > > > > Today's linux-next merge of the drm-intel tree got a conflict in: > > > > drivers/gpu/drm/i915/display/intel_sprite.c > > > > between commit: > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/drm_mst: Use Extended Base Receiver Capability (rev7)

2021-04-29 Thread Patchwork
== Series Details == Series: drm/drm_mst: Use Extended Base Receiver Capability (rev7) URL : https://patchwork.freedesktop.org/series/89590/ State : success == Summary == CI Bug Log - changes from CI_DRM_10028 -> Patchwork_20041 Summary

[Intel-gfx] [PATCH v10 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-29 Thread Nikola Cornij
[why] DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is set, Extended Base Receiver Capability DPCD space must be used. Without doing that, the three DPCD values that differ will be wrong, leading to incorrect or limited functionality. MST link rate, for example, could have a

[Intel-gfx] [PATCH v10 0/1] drm/drm_mst: Use Extended Base Receiver Capability

2021-04-29 Thread Nikola Cornij
Change history: v10: - Removed mistakenly added temporary file v9: - Actually send the changes under v8 below (missed to commit before sending v8) v8: - Chaged link lanes and rate parameters to u8 v7: - Fixed formatting - Fixed 'unused variable' compile warning - Fixed comment format

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove erroneous i915_is_ggtt check for I915_GEM_OBJECT_UNBIND_VM_TRYLOCK

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Remove erroneous i915_is_ggtt check for I915_GEM_OBJECT_UNBIND_VM_TRYLOCK URL : https://patchwork.freedesktop.org/series/89655/ State : success == Summary == CI Bug Log - changes from CI_DRM_10027_full -> Patchwork_20037_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/drm_mst: Use Extended Base Receiver Capability (rev7)

2021-04-29 Thread Patchwork
== Series Details == Series: drm/drm_mst: Use Extended Base Receiver Capability (rev7) URL : https://patchwork.freedesktop.org/series/89590/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4f516e9a3f90 drm/drm_mst: Use Extended Base Receiver Capability DPCD space -:22:

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 2:07 PM Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 02:01:16PM -0500, Jason Ekstrand wrote: > > On Thu, Apr 29, 2021 at 1:56 PM Daniel Vetter wrote: > > > On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jason Ekstrand wrote: > > > > On Thu, Apr 29, 2021 at 10:51 AM Daniel

[Intel-gfx] [PATCH v9 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-29 Thread Nikola Cornij
[why] DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is set, Extended Base Receiver Capability DPCD space must be used. Without doing that, the three DPCD values that differ will be wrong, leading to incorrect or limited functionality. MST link rate, for example, could have a

[Intel-gfx] [PATCH v9 0/1] drm/drm_mst: Use Extended Base Receiver Capability

2021-04-29 Thread Nikola Cornij
Change history: v9: - Actually send the changes under v8 below (missed to commit before sending v8) v8: - Chaged link lanes and rate parameters to u8 v7: - Fixed formatting - Fixed 'unused variable' compile warning - Fixed comment format v6: - Submited from (hopefully) the correct

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Use might_alloc() (rev2)

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Use might_alloc() (rev2) URL : https://patchwork.freedesktop.org/series/89653/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10027_full -> Patchwork_20036_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: ioctl clean-ups (rev3)

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915/gem: ioctl clean-ups (rev3) URL : https://patchwork.freedesktop.org/series/89443/ State : success == Summary == CI Bug Log - changes from CI_DRM_10028 -> Patchwork_20040 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gem: ioctl clean-ups (rev3)

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915/gem: ioctl clean-ups (rev3) URL : https://patchwork.freedesktop.org/series/89443/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: ioctl clean-ups (rev3)

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915/gem: ioctl clean-ups (rev3) URL : https://patchwork.freedesktop.org/series/89443/ State : warning == Summary == $ dim checkpatch origin/drm-tip d568c0fd97a3 drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE -:176: WARNING:FILE_PATH_CHANGES: added, moved or

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: Move struct drm_device.pdev to legacy (rev8)

2021-04-29 Thread Patchwork
== Series Details == Series: drm: Move struct drm_device.pdev to legacy (rev8) URL : https://patchwork.freedesktop.org/series/84205/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10027_full -> Patchwork_20035_full Summary

Re: [Intel-gfx] [PATCH 000/190] Revertion of all of the umn.edu commits

2021-04-29 Thread Pavel Machek
Hi! > > Revert "drm/radeon: Fix reference count leaks caused by > > pm_runtime_get_sync" > > Revert "drm/radeon: fix multiple reference count leak" > > Revert "drm/amdkfd: Fix reference count leaks." > > I didn't review these carefully, but from a quick look they all seem > rather

Re: [Intel-gfx] [PATCH 7/8] drm/stm: Don't set allow_fb_modifiers explicitly

2021-04-29 Thread Philippe CORNU - foss
Hi Daniel, Many thanks for your patch, Acked-by: Philippe Cornu Philippe :-) De : Daniel Vetter Envoyé : mardi 27 avril 2021 11:20 À : DRI Development Cc : Intel Graphics Development; Daniel Vetter; Daniel Vetter; Yannick FERTRE - foss; Philippe CORNU -

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/9] drm/doc/rfc: i915 DG1 uAPI URL : https://patchwork.freedesktop.org/series/89648/ State : success == Summary == CI Bug Log - changes from CI_DRM_10027_full -> Patchwork_20034_full

Re: [Intel-gfx] [PATCH v8 1/5] drm/ast: Remove reference to struct drm_device.pdev

2021-04-29 Thread Thomas Zimmermann
Hi Am 29.04.21 um 18:04 schrieb Ruhl, Michael J: -Original Message- From: dri-devel On Behalf Of Thomas Zimmermann Sent: Thursday, April 29, 2021 6:51 AM To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo ; airl...@linux.ie; dan...@ffwll.ch; chris@chris-

Re: [Intel-gfx] [PATCH 09/21] drm/i915/gem: Disallow creating contexts with too many engines

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 3:01 AM Tvrtko Ursulin wrote: > > > On 28/04/2021 18:09, Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 9:26 AM Tvrtko Ursulin > > wrote: > >> On 28/04/2021 15:02, Daniel Vetter wrote: > >>> On Wed, Apr 28, 2021 at 11:42:31AM +0100, Tvrtko Ursulin wrote: > >

Re: [Intel-gfx] [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 02:33:17PM +0200, Hans de Goede wrote: > Hi, > > On 4/29/21 2:04 PM, Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 01:54:46PM +0200, Greg Kroah-Hartman wrote: > >> On Thu, Apr 29, 2021 at 01:40:28PM +0200, Daniel Vetter wrote: > >>> On Wed, Apr 28, 2021 at 11:52:49PM

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix wrong name announced on FB driver switching

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Fix wrong name announced on FB driver switching URL : https://patchwork.freedesktop.org/series/89663/ State : success == Summary == CI Bug Log - changes from CI_DRM_10027 -> Patchwork_20039 Summary

Re: [Intel-gfx] [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy

2021-04-29 Thread Jason Ekstrand
On Wed, Apr 28, 2021 at 7:34 PM Umesh Nerlige Ramappa wrote: > > Perf measurements rely on CPU and engine timestamps to correlate > events of interest across these time domains. Current mechanisms get > these timestamps separately and the calculated delta between these > timestamps lack enough

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 02:01:16PM -0500, Jason Ekstrand wrote: > On Thu, Apr 29, 2021 at 1:56 PM Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jason Ekstrand wrote: > > > On Thu, Apr 29, 2021 at 10:51 AM Daniel Vetter wrote: > > > > > + ret =

[Intel-gfx] [PATCH 24/25] i915/gem/selftests: Assign the VM at context creation in igt_shared_ctx_exec

2021-04-29 Thread Jason Ekstrand
We want to delete __assign_ppgtt and, generally, stop setting the VM after context creation. This is the one place I could find in the selftests where we set a VM after the fact. Signed-off-by: Jason Ekstrand --- drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 6 +- 1 file changed,

[Intel-gfx] [PATCH 25/25] drm/i915/gem: Roll all of context creation together

2021-04-29 Thread Jason Ekstrand
Now that we have the whole engine set and VM at context creation time, we can just assign those fields instead of creating first and handling the VM and engines later. This lets us avoid creating useless VMs and engine sets and lets us git rid of the complex VM setting code. Signed-off-by: Jason

[Intel-gfx] [PATCH 22/25] drm/i915/gem: Don't allow changing the engine set on running contexts

2021-04-29 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 302 1 file changed, 302 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index a80d36c2a2663..dd066b5009fe7 100644 ---

[Intel-gfx] [PATCH 21/25] drm/i915/gem: Don't allow changing the VM on running contexts

2021-04-29 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 267 -- .../gpu/drm/i915/gem/i915_gem_context_types.h | 2 +- .../drm/i915/gem/selftests/i915_gem_context.c | 119 .../drm/i915/selftests/i915_mock_selftests.h | 1 - 4 files changed,

[Intel-gfx] [PATCH 19/25] drm/i915/gt: Drop i915_address_space::file (v2)

2021-04-29 Thread Jason Ekstrand
There's a big comment saying how useful it is but no one is using this for anything anymore. It was added in 2bfa996e031b ("drm/i915: Store owning file on the i915_address_space") and used for debugfs at the time as well as telling the difference between the global GTT and a PPGTT. In

[Intel-gfx] [PATCH 20/25] drm/i915/gem: Delay context creation

2021-04-29 Thread Jason Ekstrand
The current context uAPI allows for two methods of setting context parameters: SET_CONTEXT_PARAM and CONTEXT_CREATE_EXT_SETPARAM. The former is allowed to be called at any time while the later happens as part of GEM_CONTEXT_CREATE. Currently, everything settable via one is settable via the

[Intel-gfx] [PATCH 23/25] drm/i915/selftests: Take a VM in kernel_context()

2021-04-29 Thread Jason Ekstrand
This better models where we want to go with contexts in general where things like the VM and engine set are create parameters instead of being set after the fact. Signed-off-by: Jason Ekstrand --- .../drm/i915/gem/selftests/i915_gem_context.c | 4 ++--

[Intel-gfx] [PATCH 18/25] drm/i915/gem: Return an error ptr from context_lookup

2021-04-29 Thread Jason Ekstrand
We're about to start doing lazy context creation which means contexts get created in i915_gem_context_lookup and we may start having more errors than -ENOENT. Signed-off-by: Jason Ekstrand Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i915_gem_context.c| 12 ++--

[Intel-gfx] [PATCH 16/25] drm/i915/gem: Add an intermediate proto_context struct

2021-04-29 Thread Jason Ekstrand
The current context uAPI allows for two methods of setting context parameters: SET_CONTEXT_PARAM and CONTEXT_CREATE_EXT_SETPARAM. The former is allowed to be called at any time while the later happens as part of GEM_CONTEXT_CREATE. Currently, everything settable via one is settable via the

[Intel-gfx] [PATCH 17/25] drm/i915/gem: Use the proto-context to handle create parameters

2021-04-29 Thread Jason Ekstrand
This means that the proto-context needs to grow support for engine configuration information as well as setparam logic. Fortunately, we'll be deleting a lot of setparam logic on the primary context shortly so it will hopefully balance out. Signed-off-by: Jason Ekstrand ---

[Intel-gfx] [PATCH 15/25] drm/i915: Add gem/i915_gem_context.h to the docs

2021-04-29 Thread Jason Ekstrand
In order to prevent kernel doc warnings, also fill out docs for any missing fields and fix those that forgot the "@". Signed-off-by: Jason Ekstrand --- Documentation/gpu/i915.rst| 2 + .../gpu/drm/i915/gem/i915_gem_context_types.h | 43 --- 2 files changed,

[Intel-gfx] [PATCH 10/25] drm/i915/gem: Remove engine auto-magic with FENCE_SUBMIT

2021-04-29 Thread Jason Ekstrand
Even though FENCE_SUBMIT is only documented to wait until the request in the in-fence starts instead of waiting until it completes, it has a bit more magic than that. If FENCE_SUBMIT is used to submit something to a balanced engine, we would wait to assign engines until the primary request was

[Intel-gfx] [PATCH 11/25] drm/i915/request: Remove the hook from await_execution

2021-04-29 Thread Jason Ekstrand
This was only ever used for FENCE_SUBMIT automatic engine selection which was removed in the previous commit. Signed-off-by: Jason Ekstrand --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 3 +- drivers/gpu/drm/i915/i915_request.c | 42 ---

[Intel-gfx] [PATCH 14/25] drm/i915/gem: Add a separate validate_priority helper

2021-04-29 Thread Jason Ekstrand
With the proto-context stuff added later in this series, we end up having to duplicate set_priority. This lets us avoid duplicating the validation logic. Signed-off-by: Jason Ekstrand Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 42 + 1 file

[Intel-gfx] [PATCH 13/25] drm/i915: Stop manually RCU banging in reset_stats_ioctl (v2)

2021-04-29 Thread Jason Ekstrand
As far as I can tell, the only real reason for this is to avoid taking a reference to the i915_gem_context. The cost of those two atomics probably pales in comparison to the cost of the ioctl itself so we're really not buying ourselves anything here. We're about to make context lookup a tiny bit

[Intel-gfx] [PATCH 04/25] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem (v2)

2021-04-29 Thread Jason Ekstrand
Instead of handling it like a context param, unconditionally set it when intel_contexts are created. For years we've had the idea of a watchdog uAPI floating about. The aim was for media, so that they could set very tight deadlines for their transcodes jobs, so that if you have a corrupt

[Intel-gfx] [PATCH 09/25] drm/i915/gem: Disallow bonding of virtual engines (v3)

2021-04-29 Thread Jason Ekstrand
This adds a bunch of complexity which the media driver has never actually used. The media driver does technically bond a balanced engine to another engine but the balanced engine only has one engine in the sibling set. This doesn't actually result in a virtual engine. This functionality was

[Intel-gfx] [PATCH 07/25] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v4)

2021-04-29 Thread Jason Ekstrand
This API is entirely unnecessary and I'd love to get rid of it. If userspace wants a single timeline across multiple contexts, they can either use implicit synchronization or a syncobj, both of which existed at the time this feature landed. The justification given at the time was that it would

[Intel-gfx] [PATCH 12/25] drm/i915/gem: Disallow creating contexts with too many engines

2021-04-29 Thread Jason Ekstrand
There's no sense in allowing userspace to create more engines than it can possibly access via execbuf. Signed-off-by: Jason Ekstrand Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH 03/25] drm/i915: Drop I915_CONTEXT_PARAM_NO_ZEROMAP

2021-04-29 Thread Jason Ekstrand
The idea behind this param is to support OpenCL drivers with relocations because OpenCL reserves 0x0 for NULL and, if we placed memory there, it would confuse CL kernels. It was originally sent out as part of a patch series including libdrm [1] and Beignet [2] support. However, the libdrm and

[Intel-gfx] [PATCH 01/25] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE

2021-04-29 Thread Jason Ekstrand
This reverts commit 88be76cdafc7 ("drm/i915: Allow userspace to specify ringsize on construction"). This API was originally added for OpenCL but the compute-runtime PR has sat open for a year without action so we can still pull it out if we want. I argue we should drop it for three reasons: 1.

[Intel-gfx] [PATCH 08/25] drm/i915: Drop getparam support for I915_CONTEXT_PARAM_ENGINES

2021-04-29 Thread Jason Ekstrand
This has never been used by any userspace except IGT and provides no real functionality beyond parroting back parameters userspace passed in as part of context creation or via setparam. If the context is in legacy mode (where you use I915_EXEC_RENDER and friends), it returns success with zero

[Intel-gfx] [PATCH 06/25] drm/i915: Drop the CONTEXT_CLONE API

2021-04-29 Thread Jason Ekstrand
This API allows one context to grab bits out of another context upon creation. It can be used as a short-cut for setparam(getparam()) for things like I915_CONTEXT_PARAM_VM. However, it's never been used by any real userspace. It's used by a few IGT tests and that's it. Since it doesn't add any

[Intel-gfx] [PATCH 05/25] drm/i915/gem: Return void from context_apply_all

2021-04-29 Thread Jason Ekstrand
None of the callbacks we use with it return an error code anymore; they all return 0 unconditionally. Signed-off-by: Jason Ekstrand Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 26 +++-- 1 file changed, 8 insertions(+), 18 deletions(-) diff

[Intel-gfx] [PATCH 02/25] drm/i915: Stop storing the ring size in the ring pointer

2021-04-29 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 3 +-- drivers/gpu/drm/i915/gt/intel_context.c | 3 ++- drivers/gpu/drm/i915/gt/intel_context.h | 5 - drivers/gpu/drm/i915/gt/intel_context_types.h | 1 + drivers/gpu/drm/i915/gt/intel_lrc.c

[Intel-gfx] [PATCH 00/25] drm/i915/gem: ioctl clean-ups (v4)

2021-04-29 Thread Jason Ekstrand
Overview: - This patch series attempts to clean up some of the IOCTL mess we've created over the last few years. The most egregious bit being context mutability. In summary, this series: 1. Drops two never-used context params: RINGSIZE and NO_ZEROMAP 2. Drops the entire CONTEXT_CLONE

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 1:56 PM Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jason Ekstrand wrote: > > On Thu, Apr 29, 2021 at 10:51 AM Daniel Vetter wrote: > > > > + ret = set_proto_ctx_param(file_priv, pc, args); > > > > > > I think we should have a FIXME here of not

[Intel-gfx] [Heads up to maintainers] Re: [PATCH v8 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-29 Thread Lyude Paul
JFYI Jani and Ben: I will be pushing this patch to drm-misc-next sometime today if there's no objections On Wed, 2021-04-28 at 19:43 -0400, Nikola Cornij wrote: > [why] > DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is > set, Extended Base Receiver Capability DPCD space

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jason Ekstrand wrote: > On Thu, Apr 29, 2021 at 10:51 AM Daniel Vetter wrote: > > > + ret = set_proto_ctx_param(file_priv, pc, args); > > > > I think we should have a FIXME here of not allowing this on some future > > platforms because just use

Re: [Intel-gfx] [PATCH 03/21] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 12:13 PM Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 07:12:05PM +0200, Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 09:54:15AM -0500, Jason Ekstrand wrote: > > > On Thu, Apr 29, 2021 at 3:04 AM Tvrtko Ursulin > > > wrote: > > > > > > > > > > > > On 28/04/2021

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Be more gentle with exiting non-persistent context

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Be more gentle with exiting non-persistent context URL : https://patchwork.freedesktop.org/series/89644/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10027_full -> Patchwork_20032_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove erroneous i915_is_ggtt check for I915_GEM_OBJECT_UNBIND_VM_TRYLOCK

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Remove erroneous i915_is_ggtt check for I915_GEM_OBJECT_UNBIND_VM_TRYLOCK URL : https://patchwork.freedesktop.org/series/89655/ State : success == Summary == CI Bug Log - changes from CI_DRM_10027 -> Patchwork_20037

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/display Try YCbCr420 color when RGB fails (rev2)

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915/display Try YCbCr420 color when RGB fails (rev2) URL : https://patchwork.freedesktop.org/series/89596/ State : failure == Summary == Applying: drm/i915/display Try YCbCr420 color when RGB fails error: unrecognized input error: could not build fake

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 10:51 AM Daniel Vetter wrote: > > Yeah this needs some text to explain what/why you're doing this, and maybe > some rough sketch of the locking design. Yup. Will add. > > On Fri, Apr 23, 2021 at 05:31:26PM -0500, Jason Ekstrand wrote: > > Signed-off-by: Jason Ekstrand

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use might_alloc() (rev2)

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Use might_alloc() (rev2) URL : https://patchwork.freedesktop.org/series/89653/ State : success == Summary == CI Bug Log - changes from CI_DRM_10027 -> Patchwork_20036 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH] drm/i915: Include intel_de_{read, write}_fw() in i915_reg_rw traces

2021-04-29 Thread Jani Nikula
On Thu, 29 Apr 2021, Ville Syrjälä wrote: > On Thu, Apr 29, 2021 at 11:11:25AM +0300, Jani Nikula wrote: >> On Thu, 29 Apr 2021, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > We lost the i915_reg_rw tracepoint for a lot of display registers >> > when we switched from the heavyweight

[Intel-gfx] ✗ Fi.CI.IGT: failure for Workaround building improvements

2021-04-29 Thread Patchwork
== Series Details == Series: Workaround building improvements URL : https://patchwork.freedesktop.org/series/89641/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10027_full -> Patchwork_20031_full Summary ---

Re: [Intel-gfx] [PATCH 1/2] drm/i915/overlay: Fix active retire callback alignment

2021-04-29 Thread Tvrtko Ursulin
On 29/04/2021 17:31, Ville Syrjälä wrote: On Thu, Apr 29, 2021 at 09:35:29AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin __i915_active_call annotation is required on the retire callback to ensure correct function alignment. Signed-off-by: Tvrtko Ursulin Fixes: a21ce8ad12d2

Re: [Intel-gfx] [PATCH 1/2] drm/i915/overlay: Fix active retire callback alignment

2021-04-29 Thread Ville Syrjälä
On Thu, Apr 29, 2021 at 07:31:43PM +0300, Ville Syrjälä wrote: > On Thu, Apr 29, 2021 at 09:35:29AM +0100, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > __i915_active_call annotation is required on the retire callback to ensure > > correct function alignment. > > > > Signed-off-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Move struct drm_device.pdev to legacy (rev8)

2021-04-29 Thread Patchwork
== Series Details == Series: drm: Move struct drm_device.pdev to legacy (rev8) URL : https://patchwork.freedesktop.org/series/84205/ State : success == Summary == CI Bug Log - changes from CI_DRM_10027 -> Patchwork_20035 Summary ---

Re: [Intel-gfx] [PATCH 21/21] drm/i915/gem: Roll all of context creation together

2021-04-29 Thread Daniel Vetter
On Fri, Apr 23, 2021 at 05:31:31PM -0500, Jason Ekstrand wrote: > Now that we have the whole engine set and VM at context creation time, > we can just assign those fields instead of creating first and handling > the VM and engines later. This lets us avoid creating useless VMs and > engine sets

Re: [Intel-gfx] [PATCH 18/21] drm/i915/gem: Don't allow changing the engine set on running contexts

2021-04-29 Thread Daniel Vetter
On Fri, Apr 23, 2021 at 05:31:28PM -0500, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand I think with the additions move in here and commit message explaining a bit what's going on this looks all reasonable. I think minimally you should explain the audit you've done here and which

Re: [Intel-gfx] [PATCH 20/21] i915/gem/selftests: Assign the VM at context creation in igt_shared_ctx_exec

2021-04-29 Thread Daniel Vetter
On Fri, Apr 23, 2021 at 05:31:30PM -0500, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand Maybe spend a few words on explaining why in these two selftest patches instead of letting me guess :-) -Daniel > --- > drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 6 +- > 1 file

Re: [Intel-gfx] [PATCH 14/21] drm/i915/gem: Return an error ptr from context_lookup

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 10:29:51AM -0500, Jason Ekstrand wrote: > On Thu, Apr 29, 2021 at 8:27 AM Daniel Vetter wrote: > > > > On Fri, Apr 23, 2021 at 05:31:24PM -0500, Jason Ekstrand wrote: > > > We're about to start doing lazy context creation which means contexts > > > get created in

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 11:02:27AM -0500, Jason Ekstrand wrote: > On Thu, Apr 29, 2021 at 7:16 AM Daniel Vetter wrote: > > > > On Wed, Apr 28, 2021 at 01:58:17PM -0500, Jason Ekstrand wrote: > > > On Wed, Apr 28, 2021 at 12:18 PM Jason Ekstrand > > > wrote: > > > > > > > > On Wed, Apr 28, 2021

Re: [Intel-gfx] [PATCH 03/21] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 07:12:05PM +0200, Daniel Vetter wrote: > On Thu, Apr 29, 2021 at 09:54:15AM -0500, Jason Ekstrand wrote: > > On Thu, Apr 29, 2021 at 3:04 AM Tvrtko Ursulin > > wrote: > > > > > > > > > On 28/04/2021 18:24, Jason Ekstrand wrote: > > > > On Wed, Apr 28, 2021 at 10:55 AM

Re: [Intel-gfx] [PATCH 03/21] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 09:54:15AM -0500, Jason Ekstrand wrote: > On Thu, Apr 29, 2021 at 3:04 AM Tvrtko Ursulin > wrote: > > > > > > On 28/04/2021 18:24, Jason Ekstrand wrote: > > > On Wed, Apr 28, 2021 at 10:55 AM Tvrtko Ursulin > > > wrote: > > >> On 23/04/2021 23:31, Jason Ekstrand wrote: >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Move struct drm_device.pdev to legacy (rev8)

2021-04-29 Thread Patchwork
== Series Details == Series: drm: Move struct drm_device.pdev to legacy (rev8) URL : https://patchwork.freedesktop.org/series/84205/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Use correct downstream caps for check Src-Ctl mode for PCON

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Use correct downstream caps for check Src-Ctl mode for PCON URL : https://patchwork.freedesktop.org/series/89639/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10027_full -> Patchwork_20030_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/9] drm/doc/rfc: i915 DG1 uAPI URL : https://patchwork.freedesktop.org/series/89648/ State : success == Summary == CI Bug Log - changes from CI_DRM_10027 -> Patchwork_20034 Summary

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add relocation exceptions for two other platforms

2021-04-29 Thread Ville Syrjälä
On Thu, Apr 29, 2021 at 10:16:31AM +0200, Zbigniew Kempczyński wrote: > On Wed, Apr 28, 2021 at 07:43:42PM +, Patchwork wrote: > >Patch Details > > > >Series: drm/i915: Add relocation exceptions for two other platforms > > > >URL:

Re: [Intel-gfx] [PATCH 13/21] drm/i915/gem: Add an intermediate proto_context struct

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 8:02 AM Daniel Vetter wrote: > > The commit introducing a new data structure really should have a solid > intro in the commit message about. Please cover > > - that ctx really should be immutable, safe for exceptions like priority > > - that unfortunately we butchered the

Re: [Intel-gfx] [PATCH 1/2] drm/i915/overlay: Fix active retire callback alignment

2021-04-29 Thread Ville Syrjälä
On Thu, Apr 29, 2021 at 09:35:29AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > __i915_active_call annotation is required on the retire callback to ensure > correct function alignment. > > Signed-off-by: Tvrtko Ursulin > Fixes: a21ce8ad12d2 ("drm/i915/overlay: Switch to using

Re: [Intel-gfx] [PATCH] drm/i915: Use might_alloc()

2021-04-29 Thread kernel test robot
Hi Bernard, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.12 next-20210429] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/9] drm/doc/rfc: i915 DG1 uAPI URL : https://patchwork.freedesktop.org/series/89648/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/9] drm/doc/rfc: i915 DG1 uAPI URL : https://patchwork.freedesktop.org/series/89648/ State : warning == Summary == $ dim checkpatch origin/drm-tip 04da5ac951fc drm/doc/rfc: i915 DG1 uAPI -:63: WARNING:FILE_PATH_CHANGES: added, moved or

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Propagate ww parameter to get_pages().

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Propagate ww parameter to get_pages(). URL : https://patchwork.freedesktop.org/series/89646/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10027 -> Patchwork_20033 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/backlight: use unique backlight device names (rev2)

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915/backlight: use unique backlight device names (rev2) URL : https://patchwork.freedesktop.org/series/89578/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10027_full -> Patchwork_20028_full

Re: [Intel-gfx] BUG in i915/i915_pci.c, commit fe0f1e3

2021-04-29 Thread Imre Deak
On Thu, Apr 29, 2021 at 06:48:39PM +0300, Ville Syrjälä wrote: > On Thu, Apr 29, 2021 at 11:13:53AM +0300, Jani Nikula wrote: > > On Wed, 28 Apr 2021, Mario Hüttel wrote: > > > Hi, > > > > > > yes. The bug is still present with a recent kernel. > > > I got the tip from Imre Deak to try out > > >

Re: [Intel-gfx] [PATCH v8 1/5] drm/ast: Remove reference to struct drm_device.pdev

2021-04-29 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Thomas Zimmermann >Sent: Thursday, April 29, 2021 6:51 AM >To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo >; airl...@linux.ie; dan...@ffwll.ch; chris@chris- >wilson.co.uk >Cc: lkp ;

Re: [Intel-gfx] [PATCH v8 3/5] drm/i915: Remove reference to struct drm_device.pdev

2021-04-29 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Thomas Zimmermann >Sent: Thursday, April 29, 2021 6:51 AM >To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo >; airl...@linux.ie; dan...@ffwll.ch; chris@chris- >wilson.co.uk >Cc:

Re: [Intel-gfx] [PATCH v8 2/5] drm/i915/gt: Remove reference to struct drm_device.pdev

2021-04-29 Thread Ruhl, Michael J
>-Original Message- >From: Intel-gfx On Behalf Of >Thomas Zimmermann >Sent: Thursday, April 29, 2021 6:51 AM >To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo >; airl...@linux.ie; dan...@ffwll.ch; chris@chris- >wilson.co.uk >Cc: Winiarski, Michal ; Nikula,

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 7:16 AM Daniel Vetter wrote: > > On Wed, Apr 28, 2021 at 01:58:17PM -0500, Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 12:18 PM Jason Ekstrand > > wrote: > > > > > > On Wed, Apr 28, 2021 at 5:13 AM Daniel Vetter wrote: > > > > > > > > On Tue, Apr 27, 2021 at

Re: [Intel-gfx] [PATCH] drm/i915: Include intel_de_{read, write}_fw() in i915_reg_rw traces

2021-04-29 Thread Ville Syrjälä
On Thu, Apr 29, 2021 at 07:34:00AM +, Gupta, Anshuman wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf Of Ville > > Syrjala > > Sent: Thursday, April 29, 2021 8:06 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: Chiou, Cooper > > Subject: [Intel-gfx] [PATCH]

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Daniel Vetter
Yeah this needs some text to explain what/why you're doing this, and maybe some rough sketch of the locking design. On Fri, Apr 23, 2021 at 05:31:26PM -0500, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- > drivers/gpu/drm/i915/gem/i915_gem_context.c | 657 -- >

Re: [Intel-gfx] BUG in i915/i915_pci.c, commit fe0f1e3

2021-04-29 Thread Ville Syrjälä
On Thu, Apr 29, 2021 at 11:13:53AM +0300, Jani Nikula wrote: > On Wed, 28 Apr 2021, Mario Hüttel wrote: > > Hi, > > > > yes. The bug is still present with a recent kernel. > > I got the tip from Imre Deak to try out > > > > 7962893ecb853 ("drm/i915: Disable runtime power management during > >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Propagate ww parameter to get_pages().

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Propagate ww parameter to get_pages(). URL : https://patchwork.freedesktop.org/series/89646/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5b47c2a18575 drm/i915: Add ww parameter to get_pages() callback d88153c9c5d0 drm/i915: Add ww

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Be more gentle with exiting non-persistent context

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Be more gentle with exiting non-persistent context URL : https://patchwork.freedesktop.org/series/89644/ State : success == Summary == CI Bug Log - changes from CI_DRM_10027 -> Patchwork_20032 Summary

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 7:54 AM Tvrtko Ursulin wrote: > > > On 29/04/2021 13:24, Daniel Vetter wrote: > > On Wed, Apr 28, 2021 at 04:51:19PM +0100, Tvrtko Ursulin wrote: > >> > >> On 23/04/2021 23:31, Jason Ekstrand wrote: > >>> This adds a bunch of complexity which the media driver has never >

  1   2   >