[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/gtt: flush the scratch page

2021-10-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gtt: flush the scratch page URL : https://patchwork.freedesktop.org/series/96198/ State : success == Summary == CI Bug Log - changes from CI_DRM_10781_full -> Patchwork_21426_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: split out audio private from dev_priv

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915: split out audio private from dev_priv URL : https://patchwork.freedesktop.org/series/96195/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10781_full -> Patchwork_21425_full Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: split out i915_driver.[ch]

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915: split out i915_driver.[ch] URL : https://patchwork.freedesktop.org/series/96194/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10781_full -> Patchwork_21424_full Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for Do error capture async, flush G2H processing on reset

2021-10-22 Thread Patchwork
== Series Details == Series: Do error capture async, flush G2H processing on reset URL : https://patchwork.freedesktop.org/series/96209/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10782 -> Patchwork_21428 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Small optimization to intel_dp_mst_atomic_master_trans_check

2021-10-22 Thread Patchwork
== Series Details == Series: drm: Small optimization to intel_dp_mst_atomic_master_trans_check URL : https://patchwork.freedesktop.org/series/96190/ State : success == Summary == CI Bug Log - changes from CI_DRM_10780_full -> Patchwork_21423_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Do error capture async, flush G2H processing on reset

2021-10-22 Thread Patchwork
== Series Details == Series: Do error capture async, flush G2H processing on reset URL : https://patchwork.freedesktop.org/series/96209/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] [PATCH 0/3] Do error capture async, flush G2H processing on reset

2021-10-22 Thread Matthew Brost
Rather allocating an error capture in nowait context to break a lockdep splat [1], do the error capture async compared to the G2H processing. v2: Fix Docs warning v3: Rebase, resend for CI v4: Resend for CI Signed-off-by: Matthew Brost [1]

[Intel-gfx] [PATCH 1/3] drm/i915/guc: Do error capture asynchronously

2021-10-22 Thread Matthew Brost
An error capture allocates memory, memory allocations depend on resets, and resets need to flush the G2H handlers to seal several races. If the error capture is done from the G2H handler this creates a circular dependency. To work around this, do a error capture in a work queue asynchronously from

[Intel-gfx] [PATCH 3/3] drm/i915/guc: Refcount context during error capture

2021-10-22 Thread Matthew Brost
From: John Harrison When i915 receives a context reset notification from GuC, it triggers an error capture before resetting any outstanding requsts of that context. Unfortunately, the error capture is not a time bound operation. In certain situations it can take a long time, particularly when

[Intel-gfx] [PATCH 2/3] drm/i915/guc: Flush G2H work queue during reset

2021-10-22 Thread Matthew Brost
It isn't safe to scrub for missing G2H or continue with the reset until all G2H processing is complete. Flush the G2H work queue during reset to ensure it is done running. No need to call the IRQ handler directly either as the scrubbing code can deal with any missing G2H. Signed-off-by: Matthew

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: fix inconsistent IS_ERR and PTR_ERR (rev3)

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix inconsistent IS_ERR and PTR_ERR (rev3) URL : https://patchwork.freedesktop.org/series/38366/ State : success == Summary == CI Bug Log - changes from CI_DRM_10780_full -> Patchwork_21422_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix bigjoiner state readout (rev2)

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix bigjoiner state readout (rev2) URL : https://patchwork.freedesktop.org/series/94609/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10780_full -> Patchwork_21421_full Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i195: Remove some dead struct fwd decl from i915_drv.h

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i195: Remove some dead struct fwd decl from i915_drv.h URL : https://patchwork.freedesktop.org/series/96176/ State : success == Summary == CI Bug Log - changes from CI_DRM_10780_full -> Patchwork_21419_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: abstraction for iosf to compile on all archs (rev2)

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915: abstraction for iosf to compile on all archs (rev2) URL : https://patchwork.freedesktop.org/series/96149/ State : success == Summary == CI Bug Log - changes from CI_DRM_10781 -> Patchwork_21427

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: abstraction for iosf to compile on all archs (rev2)

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915: abstraction for iosf to compile on all archs (rev2) URL : https://patchwork.freedesktop.org/series/96149/ State : warning == Summary == $ dim checkpatch origin/drm-tip 996dde957f9e drm/i915: abstraction for iosf to compile on all archs -:27:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gtt: flush the scratch page

2021-10-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gtt: flush the scratch page URL : https://patchwork.freedesktop.org/series/96198/ State : success == Summary == CI Bug Log - changes from CI_DRM_10781 -> Patchwork_21426

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add struct to hold IP version

2021-10-22 Thread Yokoyama, Caz
On Wed, 2021-10-20 at 19:19 +, Souza, Jose wrote: > On Wed, 2021-10-20 at 15:00 +, Yokoyama, Caz wrote: > > On Tue, 2021-10-19 at 17:23 -0700, José Roberto de Souza wrote: > > > Adding a structure to standardize access to IP versioning as > > > future > > > platforms will have this

Re: [Intel-gfx] [Freedreno] [PATCH v3 04/14] drm/hdcp: Expand HDCP helper library for enable/disable/check

2021-10-22 Thread abhinavk
On 2021-10-01 08:11, Sean Paul wrote: From: Sean Paul This patch expands upon the HDCP helper library to manage HDCP enable, disable, and check. Previous to this patch, the majority of the state management and sink interaction is tucked inside the Intel driver with the understanding that once

Re: [Intel-gfx] [Freedreno] [PATCH v3 09/14] drm/msm/dpu: Remove useless checks in dpu_encoder

2021-10-22 Thread abhinavk
On 2021-10-01 08:11, Sean Paul wrote: From: Sean Paul A couple more useless checks to remove in dpu_encoder. Reviewed-by: Stephen Boyd Signed-off-by: Sean Paul Reviewed-by: Abhinav Kumar Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-10-s...@poorly.run #v1 Link:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: split out audio private from dev_priv

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915: split out audio private from dev_priv URL : https://patchwork.freedesktop.org/series/96195/ State : success == Summary == CI Bug Log - changes from CI_DRM_10781 -> Patchwork_21425 Summary ---

Re: [Intel-gfx] [Freedreno] [PATCH v3 03/14] drm/hdcp: Update property value on content type and user changes

2021-10-22 Thread abhinavk
On 2021-10-01 08:11, Sean Paul wrote: From: Sean Paul This patch updates the connector's property value in 2 cases which were previously missed: 1- Content type changes. The value should revert back to DESIRED from ENABLED in case the driver must re-authenticate the link due to the new

Re: [Intel-gfx] [Freedreno] [PATCH v3 01/14] drm/hdcp: Add drm_hdcp_atomic_check()

2021-10-22 Thread abhinavk
On 2021-10-01 08:11, Sean Paul wrote: From: Sean Paul This patch moves the hdcp atomic check from i915 to drm_hdcp so other drivers can use it. No functional changes, just cleaned up some of the code when moving it over. Acked-by: Jani Nikula Signed-off-by: Sean Paul For the drm/hdcp

Re: [Intel-gfx] [PATCH v3 10/14] drm/msm/dpu: Remove encoder->enable() hack

2021-10-22 Thread abhinavk
On 2021-10-01 08:11, Sean Paul wrote: From: Sean Paul encoder->commit() was being misused because there were some global resources which needed to be tweaked in encoder->enable() which were not accessible in dpu_encoder.c. That is no longer true and the redirect serves no purpose any longer.

Re: [Intel-gfx] [PATCH] i915/display/dmc: Add Support for PipeC and PipeD DMC

2021-10-22 Thread Imre Deak
On Wed, Oct 06, 2021 at 01:45:47PM -0700, Anusha Srivatsa wrote: > So far we had support for main, PipeA and PipeB > DMC. If we find a binary from PipeA-D, lets load it. > > Cc: Imre Deak > Signed-off-by: Anusha Srivatsa Reviewed-by: Imre Deak > --- >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: split out audio private from dev_priv

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915: split out audio private from dev_priv URL : https://patchwork.freedesktop.org/series/96195/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4d684e513941 drm/i915/audio: group audio under anonymous struct in drm_i915_private 7dde34aa454e

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: split out i915_driver.[ch]

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915: split out i915_driver.[ch] URL : https://patchwork.freedesktop.org/series/96194/ State : success == Summary == CI Bug Log - changes from CI_DRM_10781 -> Patchwork_21424 Summary --- **SUCCESS**

Re: [Intel-gfx] linux-next: Tree for Oct 22 (drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c)

2021-10-22 Thread Randy Dunlap
On 10/22/21 2:15 AM, Stephen Rothwell wrote: Hi all, Changes since 20211021: on x86_64: ../drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c: In function ‘i915_gem_object_get_pages_dmabuf’: ../drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c:248:3: error: implicit declaration of function

Re: [Intel-gfx] [V2 3/4] drm/i915/dsi/xelpd: Disable DC states in Video mode

2021-10-22 Thread Imre Deak
On Tue, Oct 19, 2021 at 08:44:34PM +0530, Vandita Kulkarni wrote: > MIPI DSI transcoder cannot be in video mode to support any of the > display C states. > > Bspec: 49195 (For DC*co DSI transcoders cannot be in video mode) > Bspec: 49193 (Hardware does not support DC5 or DC6 with MIPI DSI

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add struct to hold IP version

2021-10-22 Thread Lucas De Marchi
On Thu, Oct 21, 2021 at 04:11:26PM +0300, Jani Nikula wrote: On Wed, 20 Oct 2021, "Souza, Jose" wrote: On Wed, 2021-10-20 at 12:47 +0300, Jani Nikula wrote: On Tue, 19 Oct 2021, José Roberto de Souza wrote: > The constant platform display version is not using this new struct but > the

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: split out i915_driver.[ch]

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915: split out i915_driver.[ch] URL : https://patchwork.freedesktop.org/series/96194/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: split out i915_driver.[ch]

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915: split out i915_driver.[ch] URL : https://patchwork.freedesktop.org/series/96194/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1dcd9a363633 drm/i915/driver: rename i915_drv.c to i915_driver.c -:27: WARNING:FILE_PATH_CHANGES: added, moved

Re: [Intel-gfx] [PATCH v3] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-10-22 Thread Navare, Manasi
Hi Ville, Could you take a look at this, this addresses teh review comments from prev version Manasi On Mon, Oct 04, 2021 at 04:59:13AM -0700, Manasi Navare wrote: > In case of a modeset where a mode gets split across mutiple CRTCs > in the driver specific implementation (bigjoiner in i915)

[Intel-gfx] [PATCH] drm/i915: abstraction for iosf to compile on all archs

2021-10-22 Thread Mullati Siva
From: "Mullati, Siva" The asm/iosf_mbi.h header is x86-only. Let's make IOSF_MBI kconfig selection conditional to x86 and provide a header with stubs for other architectures. This helps getting i915 available for other architectures in future. Signed-off-by: Mullati, Siva ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Small optimization to intel_dp_mst_atomic_master_trans_check

2021-10-22 Thread Patchwork
== Series Details == Series: drm: Small optimization to intel_dp_mst_atomic_master_trans_check URL : https://patchwork.freedesktop.org/series/96190/ State : success == Summary == CI Bug Log - changes from CI_DRM_10780 -> Patchwork_21423

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: fix inconsistent IS_ERR and PTR_ERR (rev3)

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix inconsistent IS_ERR and PTR_ERR (rev3) URL : https://patchwork.freedesktop.org/series/38366/ State : success == Summary == CI Bug Log - changes from CI_DRM_10780 -> Patchwork_21422

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Allow engine reset failure to do a GT reset in hangcheck selftest

2021-10-22 Thread John Harrison
On 10/22/2021 10:03, Matthew Brost wrote: On Fri, Oct 22, 2021 at 08:23:55AM +0200, Thomas Hellström wrote: On 10/21/21 22:37, Matthew Brost wrote: On Thu, Oct 21, 2021 at 08:15:49AM +0200, Thomas Hellström wrote: Hi, Matthew, On Mon, 2021-10-11 at 16:47 -0700, Matthew Brost wrote: The

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix bigjoiner state readout (rev2)

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix bigjoiner state readout (rev2) URL : https://patchwork.freedesktop.org/series/94609/ State : success == Summary == CI Bug Log - changes from CI_DRM_10780 -> Patchwork_21421 Summary ---

Re: [Intel-gfx] [PATCH 0/4] drm/i915: split out audio private from dev_priv

2021-10-22 Thread Lucas De Marchi
On Fri, Oct 22, 2021 at 07:27:54PM +0300, Jani Nikula wrote: I'll first make the argument that drm_i915_private should not have a single member that is not a named sub-struct defined separately. It's just too big to have individual members like, say, framestart_delay. All of these need context

Re: [Intel-gfx] [PATCH 1/4] drm/i915/audio: group audio under anonymous struct in drm_i915_private

2021-10-22 Thread Lucas De Marchi
On Fri, Oct 22, 2021 at 07:27:55PM +0300, Jani Nikula wrote: With an anonymous struct, this can be pure hierarchical organization without code changes. start reading from patch 1 left me confused. A sentence here that next patches will add the sub-struct name would be good. Lucas De Marchi

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix bigjoiner state readout (rev2)

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix bigjoiner state readout (rev2) URL : https://patchwork.freedesktop.org/series/94609/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9b834bd6bbea drm/i915/psr: Disable PSR before modesets turn off all planes 4a710bf77f9e Revert

Re: [Intel-gfx] [PATCH 4/4] drm/amd/display: Add DP 2.0 MST DM Support

2021-10-22 Thread Lin, Wayne
[AMD Official Use Only] Hi Bhawan, Just a nitpick below. With that fixed, feel free to add: Reviewed-by: Wayne Lin Thanks! Regards, Wayne > -Original Message- > From: Bhawanpreet Lakha > Sent: Thursday, October 21, 2021 3:47 AM > To: Zuo, Jerry ; dri-de...@lists.freedesktop.org; >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/pxp: run CI with PXP and MEI_PXP enabled.

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915/pxp: run CI with PXP and MEI_PXP enabled. URL : https://patchwork.freedesktop.org/series/96181/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10780 -> Patchwork_21420 Summary ---

Re: [Intel-gfx] [PATCH 3/4] drm/amd/display: Add DP 2.0 MST DC Support

2021-10-22 Thread Lin, Wayne
[Public] Hi Bhawan, It looks good to me. Thanks! Reviewed-by: Wayne Lin Regards, Wayne > -Original Message- > From: Bhawanpreet Lakha > Sent: Thursday, October 21, 2021 11:16 PM > To: Zuo, Jerry ; dri-de...@lists.freedesktop.org; > ly...@redhat.com > Cc:

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Allow engine reset failure to do a GT reset in hangcheck selftest

2021-10-22 Thread Matthew Brost
On Fri, Oct 22, 2021 at 08:23:55AM +0200, Thomas Hellström wrote: > > On 10/21/21 22:37, Matthew Brost wrote: > > On Thu, Oct 21, 2021 at 08:15:49AM +0200, Thomas Hellström wrote: > > > Hi, Matthew, > > > > > > On Mon, 2021-10-11 at 16:47 -0700, Matthew Brost wrote: > > > > The hangcheck

Re: [Intel-gfx] [PATCH 3/4] drm/i915/audio: define the audio struct separately from drm_i915_private

2021-10-22 Thread Jani Nikula
On Fri, 22 Oct 2021, Ville Syrjälä wrote: > On Fri, Oct 22, 2021 at 07:27:57PM +0300, Jani Nikula wrote: >> Add a standalone definition of struct intel_audio_private, and note that >> all of it is private to intel_audio.c. >> >> Cc: Dave Airlie >> Signed-off-by: Jani Nikula >> --- >>

Re: [Intel-gfx] [PATCH v2 06/17] drm/i915/xehpsdv: support 64K GTT pages

2021-10-22 Thread Matthew Auld
On 21/10/2021 15:26, Ramalingam C wrote: From: Matthew Auld XEHPSDV optimises 64K GTT pages for local-memory, since everything should be allocated at 64K granularity. We say goodbye to sparse entries, and instead get a compact 256B page-table for 64K pages, which should be more cache friendly.

Re: [Intel-gfx] [PATCH 2/4] drm/i915/audio: name the audio sub-struct in drm_i915_private

2021-10-22 Thread Jani Nikula
On Fri, 22 Oct 2021, Ville Syrjälä wrote: > On Fri, Oct 22, 2021 at 07:27:56PM +0300, Jani Nikula wrote: >> Add name to the audio sub-struct in drm_i915_private, and remove the >> tautologies and other inconsistencies in the member names. >> >> Cc: Dave Airlie >> Signed-off-by: Jani Nikula >>

Re: [Intel-gfx] [PATCH v2 07/17] drm/i915: Add vm min alignment support

2021-10-22 Thread Matthew Auld
On 21/10/2021 15:26, Ramalingam C wrote: From: Bommu Krishnaiah Replace the hard coded 4K alignment value with vm->min_alignment. Cc: Wilson Chris P Signed-off-by: Bommu Krishnaiah Signed-off-by: Ramalingam C Reviewed-by: Matthew Auld Although likely want to squash patch patches 3, 7

[Intel-gfx] [PATCH 2/2] drm/i915/gtt: stop caching the scratch page

2021-10-22 Thread Matthew Auld
Normal users shouldn't be hitting this, likely this would indicate a userspace bug. So don't bother caching, which should be safe now that we manually flush the page. Suggested-by: Chris Wilson Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Chris Wilson Cc: Ramalingam C ---

[Intel-gfx] [PATCH 1/2] drm/i915/gtt: flush the scratch page

2021-10-22 Thread Matthew Auld
The scratch page is directly visible in the users address space, and while this is forced as CACHE_LLC, by the kernel, we still have to contend with things like "Bypass-LLC" MOCS. So just flush no matter what. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Chris Wilson Cc: Ramalingam C

Re: [Intel-gfx] [PATCH 4/4] drm/i915/audio: move intel_audio_funcs internal to intel_audio.c

2021-10-22 Thread Ville Syrjälä
On Fri, Oct 22, 2021 at 07:27:58PM +0300, Jani Nikula wrote: > It's all internal to intel_audio.c. > > Cc: Dave Airlie > Signed-off-by: Jani Nikula I've toyed around with similar stuff myself before (moving bunch of .av_foo/.audio_foo to .audio.foo) just never bothered sending it out. So very

Re: [Intel-gfx] [PATCH 00/47] GuC submission support

2021-10-22 Thread Matthew Brost
On Fri, Oct 22, 2021 at 12:35:04PM +0300, Joonas Lahtinen wrote: > Hi Matt & John, > > Can you please queue patches with the right Fixes: references to convert > all the GuC tracepoints to be protected by the LOW_LEVEL_TRACEPOINTS > protection for now. Please do so before next Wednesday so we get

Re: [Intel-gfx] [PATCH 3/4] drm/i915/audio: define the audio struct separately from drm_i915_private

2021-10-22 Thread Ville Syrjälä
On Fri, Oct 22, 2021 at 07:27:57PM +0300, Jani Nikula wrote: > Add a standalone definition of struct intel_audio_private, and note that > all of it is private to intel_audio.c. > > Cc: Dave Airlie > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.h | 45

Re: [Intel-gfx] [PATCH 2/4] drm/i915/audio: name the audio sub-struct in drm_i915_private

2021-10-22 Thread Ville Syrjälä
On Fri, Oct 22, 2021 at 07:27:56PM +0300, Jani Nikula wrote: > Add name to the audio sub-struct in drm_i915_private, and remove the > tautologies and other inconsistencies in the member names. > > Cc: Dave Airlie > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_audio.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i195: Remove some dead struct fwd decl from i915_drv.h

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i195: Remove some dead struct fwd decl from i915_drv.h URL : https://patchwork.freedesktop.org/series/96176/ State : success == Summary == CI Bug Log - changes from CI_DRM_10780 -> Patchwork_21419 Summary

[Intel-gfx] [PATCH 4/4] drm/i915/audio: move intel_audio_funcs internal to intel_audio.c

2021-10-22 Thread Jani Nikula
It's all internal to intel_audio.c. Cc: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_audio.c | 9 + drivers/gpu/drm/i915/i915_drv.h| 10 +- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git

[Intel-gfx] [PATCH 3/4] drm/i915/audio: define the audio struct separately from drm_i915_private

2021-10-22 Thread Jani Nikula
Add a standalone definition of struct intel_audio_private, and note that all of it is private to intel_audio.c. Cc: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 45 ++--- 1 file changed, 24 insertions(+), 21 deletions(-) diff --git

[Intel-gfx] [PATCH 2/4] drm/i915/audio: name the audio sub-struct in drm_i915_private

2021-10-22 Thread Jani Nikula
Add name to the audio sub-struct in drm_i915_private, and remove the tautologies and other inconsistencies in the member names. Cc: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_audio.c| 90 +-- .../gpu/drm/i915/display/intel_lpe_audio.c|

[Intel-gfx] [PATCH 1/4] drm/i915/audio: group audio under anonymous struct in drm_i915_private

2021-10-22 Thread Jani Nikula
With an anonymous struct, this can be pure hierarchical organization without code changes. Cc: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 43 + 1 file changed, 22 insertions(+), 21 deletions(-) diff --git

[Intel-gfx] [PATCH 0/4] drm/i915: split out audio private from dev_priv

2021-10-22 Thread Jani Nikula
I'll first make the argument that drm_i915_private should not have a single member that is not a named sub-struct defined separately. It's just too big to have individual members like, say, framestart_delay. All of these need context that is created using C constructs, not comments. Ideas have

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i195: Remove some dead struct fwd decl from i915_drv.h

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i195: Remove some dead struct fwd decl from i915_drv.h URL : https://patchwork.freedesktop.org/series/96176/ State : warning == Summary == $ dim checkpatch origin/drm-tip 75d76795a743 drm/i195: Remove some dead struct fwd decl from i915_drv.h -:6:

[Intel-gfx] ✓ Fi.CI.IGT: success for Selective fetch support for biplanar formats

2021-10-22 Thread Patchwork
== Series Details == Series: Selective fetch support for biplanar formats URL : https://patchwork.freedesktop.org/series/96113/ State : success == Summary == CI Bug Log - changes from CI_DRM_10768_full -> Patchwork_21401_full Summary

[Intel-gfx] [PATCH 2/2] drm/i915/driver: rename driver to i915_drm_driver

2021-10-22 Thread Jani Nikula
As a name, "driver" is too generic and short to be easily located in a file this size. Rename it to i915_drm_driver. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_driver.c

[Intel-gfx] [PATCH 1/2] drm/i915/driver: rename i915_drv.c to i915_driver.c

2021-10-22 Thread Jani Nikula
This is more about trimming i915_drv.h than the renamed i915_driver.[ch]. Split out i915_driver.[ch] out of i915_drv.h as a feasible thing to do. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 2 +- .../drm/i915/{i915_drv.c => i915_driver.c}| 5 ++--

[Intel-gfx] [PATCH 0/2] drm/i915: split out i915_driver.[ch]

2021-10-22 Thread Jani Nikula
i915_drv.h is mostly not about i915_drv.c, so make the distinction clear by renaming i915_drv.c to i915_driver.c and splitting out i915_driver.h from i915_drv.h. Jani Nikula (2): drm/i915/driver: rename i915_drv.c to i915_driver.c drm/i915/driver: rename driver to i915_drm_driver

Re: [Intel-gfx] [PATCH 19/30] drm/i915: Add an i915_gem_vm_lookup helper

2021-10-22 Thread Jani Nikula
On Thu, 08 Jul 2021, Jason Ekstrand wrote: > This is the VM equivalent of i915_gem_context_lookup. It's only used > once in this patch but future patches will need to duplicate this lookup > code so it's better to have it in a helper. > > Signed-off-by: Jason Ekstrand > Reviewed-by: Daniel

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915/psr: Disable PSR before modesets turn off all planes

2021-10-22 Thread Ville Syrjälä
On Fri, Oct 22, 2021 at 02:29:01PM +, Hogander, Jouni wrote: > On Fri, 2021-10-22 at 13:32 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > PSR2 apparently requires some planes to be enabled for some > > silly reason, and so we are now trying to turn PSR off before > > planes go

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915/psr: Disable PSR before modesets turn off all planes

2021-10-22 Thread Hogander, Jouni
On Fri, 2021-10-22 at 13:32 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > PSR2 apparently requires some planes to be enabled for some > silly reason, and so we are now trying to turn PSR off before > planes go off. Except during a full modeset that is handled > less clearly through

Re: [Intel-gfx] [PATCH v7] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9

2021-10-22 Thread Tvrtko Ursulin
On 22/10/2021 05:14, Cooper Chiou wrote: WaProgramMgsrForCorrectSliceSpecificMmioReads applies for Gen9 to resolve VP8 hardware encoding system hang up on GT1 sku for ChromiumOS projects. This system hang issue can be reproduced on Khronos OpenCL conformance tests by test_basic as well, and

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/28] drm/i915: Fix i915_request fence wait semantics

2021-10-22 Thread Maarten Lankhorst
Op 22-10-2021 om 13:24 schreef Matthew Auld: > On Thu, 21 Oct 2021 at 13:57, Patchwork > wrote: > > *Patch Details* > *Series:* series starting with [01/28] drm/i915: Fix i915_request > fence wait semantics > *URL:*

[Intel-gfx] [PATCH -next] drm: Small optimization to intel_dp_mst_atomic_master_trans_check

2021-10-22 Thread He Ying
If we want to return from for_each_intel_connector_iter(), one way is calling drm_connector_list_iter_end() before returning to avoid memleak. The other way is just breaking from the bracket and then returning after the outside drm_connector_list_iter_end(). Obviously, the second way makes code

[Intel-gfx] [PATCH] drm/i915/selftests: Fix inconsistent IS_ERR and PTR_ERR

2021-10-22 Thread Kai Song
Fix inconsistent IS_ERR and PTR_ERR in i915_gem_dmabuf.c Signed-off-by: Kai Song --- drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c

Re: [Intel-gfx] [PATCH v3 04/10] vfio/ccw: Convert to use vfio_register_emulated_iommu_dev()

2021-10-22 Thread Eric Farman
On Fri, 2021-10-01 at 14:52 -0300, Jason Gunthorpe wrote: > This is a more complicated conversion because vfio_ccw is sharing the > vfio_device between both the mdev_device, its vfio_device and the > css_driver. > > The mdev is a singleton, and the reason for this sharing is so the > extra >

Re: [Intel-gfx] [PATCH v3 13/13] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-22 Thread Ville Syrjälä
On Fri, Oct 22, 2021 at 03:01:52PM +0300, Ville Syrjälä wrote: > On Fri, Oct 22, 2021 at 12:25:33PM +0200, Claudio Suarez wrote: > > On Thu, Oct 21, 2021 at 04:49:59PM +0300, Ville Syrjälä wrote: > > > On Wed, Oct 20, 2021 at 12:51:21AM +0200, Claudio Suarez wrote: > > > > drm_get_edid()

Re: [Intel-gfx] [PATCH v3 13/13] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-22 Thread Ville Syrjälä
On Fri, Oct 22, 2021 at 12:25:33PM +0200, Claudio Suarez wrote: > On Thu, Oct 21, 2021 at 04:49:59PM +0300, Ville Syrjälä wrote: > > On Wed, Oct 20, 2021 at 12:51:21AM +0200, Claudio Suarez wrote: > > > drm_get_edid() internally calls to drm_connector_update_edid_property() > > > and then

Re: [Intel-gfx] [PATCH v3 13/13] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-22 Thread Claudio Suarez
On Thu, Oct 21, 2021 at 04:49:59PM +0300, Ville Syrjälä wrote: > On Wed, Oct 20, 2021 at 12:51:21AM +0200, Claudio Suarez wrote: > > drm_get_edid() internally calls to drm_connector_update_edid_property() > > and then drm_add_display_info(), which parses the EDID. > > This happens in the function

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/28] drm/i915: Fix i915_request fence wait semantics

2021-10-22 Thread Matthew Auld
On Thu, 21 Oct 2021 at 13:57, Patchwork wrote: > *Patch Details* > *Series:* series starting with [01/28] drm/i915: Fix i915_request fence > wait semantics > *URL:* https://patchwork.freedesktop.org/series/96115/ > *State:* failure > *Details:* >

Re: [Intel-gfx] [PATCH 25/28] drm/i915: Require object lock when freeing pages during destruction

2021-10-22 Thread Matthew Auld
On Thu, 21 Oct 2021 at 11:37, Maarten Lankhorst wrote: > > TTM already requires this, and we require it for delayed destroy. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH 10/28] drm/i915: Change shrink ordering to use locking around unbinding.

2021-10-22 Thread Maarten Lankhorst
Op 21-10-2021 om 18:12 schreef Matthew Auld: > On Thu, 21 Oct 2021 at 11:37, Maarten Lankhorst > wrote: >> Call drop_pages with the gem object lock held, instead of the other >> way around. This will allow us to drop the vma bindings with the >> gem object lock held. >> >> We plan to require the

Re: [Intel-gfx] [PATCH 08/28] drm/i915: Create a full object for mock_ring, v2.

2021-10-22 Thread Maarten Lankhorst
Op 21-10-2021 om 17:57 schreef Matthew Auld: > On Thu, 21 Oct 2021 at 11:36, Maarten Lankhorst > wrote: >> This allows us to finally get rid of all the assumptions that vma->obj is >> NULL. >> >> Changes since v1: >> - Ensure the mock_ring vma is pinned to prevent a fault. >> - Pin it high to

Re: [Intel-gfx] [PATCH 13/28] drm/i915: Remove pages_mutex and intel_gtt->vma_ops.set/clear_pages members

2021-10-22 Thread Matthew Auld
On Thu, 21 Oct 2021 at 18:30, Matthew Auld wrote: > > On Thu, 21 Oct 2021 at 11:36, Maarten Lankhorst > wrote: > > > > Big delta, but boils down to moving set_pages to i915_vma.c, and removing > > the special handling, all callers use the defaults anyway. We only remap > > in ggtt, so default

[Intel-gfx] [PATCH v2 9/9] drm/i915: Nuke PIPE_CONFIG_QUIRK_BIGJOINER_SLAVE

2021-10-22 Thread Ville Syrjala
From: Ville Syrjälä Now that the bigjoiner state readout/computation has been made to do the right thing nuke the related state checker quirk. Reviewed-by: Manasi Navare Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 105 --

[Intel-gfx] [PATCH v2 8/9] drm/i915: Reduce bigjoiner special casing

2021-10-22 Thread Ville Syrjala
From: Ville Syrjälä Try to make bigjoiner pipes less special. The main things here are that each pipe now does full clock computation/readout with its own shared_dpll reference. Also every pipe's cpu_transcoder always points correctly at the master transcoder. Due to the above changes state

[Intel-gfx] [PATCH v2 6/9] drm/i915: Split PPS write from DSC enable

2021-10-22 Thread Ville Syrjala
From: Ville Syrjälä The PPS SDP is fed into the transcoder whereas the DSC block is (or at least can be) per pipe. Let's split these into two distinct operations in an effort to untagle the bigjoiner mess where we have two pipes feeding a single transcoder. Reviewed-by: Manasi Navare

[Intel-gfx] [PATCH v2 7/9] drm/i915: Perform correct cpu_transcoder readout for bigjoiner

2021-10-22 Thread Ville Syrjala
From: Ville Syrjälä Read out cpu_transcoder correctly for the bigjoiner slave pipes. Reviewed-by: Manasi Navare Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 66 1 file changed, 66 insertions(+) diff --git

[Intel-gfx] [PATCH v2 5/9] drm/i915: Simplify intel_crtc_copy_uapi_to_hw_state_nomodeset()

2021-10-22 Thread Ville Syrjala
From: Ville Syrjälä Rewrite intel_crtc_copy_uapi_to_hw_state_nomodeset() in a slightly more straightforward manner. Reviewed-by: Manasi Navare Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 17 +++-- 1 file changed, 7 insertions(+), 10

[Intel-gfx] [PATCH v2 4/9] drm/i915: Introduce intel_master_crtc()

2021-10-22 Thread Ville Syrjala
From: Ville Syrjälä Add a helper to determine the master crtc for bigjoiner usage. Also name the variables consistently. Reviewed-by: Manasi Navare Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 6 +-- drivers/gpu/drm/i915/display/intel_display.c | 57

[Intel-gfx] [PATCH v2 3/9] drm/i915: Disable all planes before modesetting any pipes

2021-10-22 Thread Ville Syrjala
From: Ville Syrjälä Let's disable planes on all pipes affected by the modeset before we start doing the actual modeset. This means we have less random planes enabled during the modeset, and it also mirrors what we already do when enabling pipes on skl+ since we enable planes on all pipes as the

[Intel-gfx] [PATCH v2 1/9] drm/i915/psr: Disable PSR before modesets turn off all planes

2021-10-22 Thread Ville Syrjala
From: Ville Syrjälä PSR2 apparently requires some planes to be enabled for some silly reason, and so we are now trying to turn PSR off before planes go off. Except during a full modeset that is handled less clearly through reorganization of the modeset sequence. That is not great as it makes the

[Intel-gfx] [PATCH v2 2/9] Revert "drm/i915/display: Disable audio, DRRS and PSR before planes"

2021-10-22 Thread Ville Syrjala
From: Ville Syrjälä Disabling planes in the middle of the modeset seuqnece does not make sense since userspace can anyway disable planes before the modeset even starts. So when the modeset seuqence starts the set of enabled planes is entirely arbitrary. Trying to sprinkle the plane disabling

[Intel-gfx] [PATCH v2 0/9] drm/i915: Fix bigjoiner state readout

2021-10-22 Thread Ville Syrjala
From: Ville Syrjälä New version of the bigjoiner cleanup. Bunch of stuff already merged, and the bigjoiner specific stuff is all reviewed now. So all we're left to contend is the PSR related stuff at the start. I slapped a new patch at the start which hopefully sorts out the planes vs. PSR

[Intel-gfx] [PATCH] drm/i915/pxp: run CI with PXP and MEI_PXP enabled.

2021-10-22 Thread Tejas Upadhyay
By default it will be off in normal builds. Signed-off-by: Tejas Upadhyay --- drivers/gpu/drm/i915/Kconfig.debug | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug index e7fd3e76f8a2..fa181693184b 100644 ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dmabuf: drop the flush on discrete

2021-10-22 Thread Matthew Auld
On 22/10/2021 10:26, Thomas Hellström wrote: Hi, Matt On 10/21/21 14:53, Matthew Auld wrote: We were overzealous here; even though discrete is non-LLC, it should still be always coherent. Signed-off-by: Matthew Auld Cc: Thomas Hellström ---   drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 3

Re: [Intel-gfx] [PATCH 00/47] GuC submission support

2021-10-22 Thread Joonas Lahtinen
Hi Matt & John, Can you please queue patches with the right Fixes: references to convert all the GuC tracepoints to be protected by the LOW_LEVEL_TRACEPOINTS protection for now. Please do so before next Wednesday so we get it queued in drm-intel-next-fixes. There's the orthogonal track to

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dmabuf: drop the flush on discrete

2021-10-22 Thread Thomas Hellström
Hi, Matt On 10/21/21 14:53, Matthew Auld wrote: We were overzealous here; even though discrete is non-LLC, it should still be always coherent. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Properly reset mock object propers for each test

2021-10-22 Thread Daniel Vetter
On Thu, Oct 21, 2021 at 10:20:48PM +0200, Daniel Vetter wrote: > I forgot to do this properly in > > commit 6f11f37459d8f9f74ff1c299c0bedd50b458057a > Author: Daniel Vetter > Date: Fri Jul 23 10:34:55 2021 +0200 > > drm/plane: remove drm_helper_get_plane_damage_clips > > intel-gfx CI

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev9)

2021-10-22 Thread Patchwork
== Series Details == Series: drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev9) URL : https://patchwork.freedesktop.org/series/81764/ State : success == Summary == CI Bug Log - changes from CI_DRM_10773_full -> Patchwork_21418_full

Re: [Intel-gfx] [PATCH] drm/i915: remove CNL leftover

2021-10-22 Thread Ville Syrjälä
On Thu, Oct 21, 2021 at 02:32:13PM -0700, Lucas De Marchi wrote: > On Thu, Oct 21, 2021 at 10:05:40PM +0300, Ville Syrjälä wrote: > >On Thu, Oct 21, 2021 at 11:18:47AM -0700, Lucas De Marchi wrote: > >> We left the definition IS_CANNONLAKE() macro while removing it from the > >> tree due to having

Re: [Intel-gfx] [PATCH 19/28] drm/i915: Pass trylock context to callers

2021-10-22 Thread Maarten Lankhorst
Op 21-10-2021 om 20:03 schreef Matthew Auld: > On Thu, 21 Oct 2021 at 11:37, Maarten Lankhorst > wrote: >> Signed-off-by: Maarten Lankhorst > Needs a proper commit message. What about this? drm/i915: Pass trylock context to callers We are moving away from short term pinning, and need a way to

Re: [Intel-gfx] [PATCH 03/28] drm/i915: Remove dma_resv_prune

2021-10-22 Thread Maarten Lankhorst
Op 21-10-2021 om 16:43 schreef Matthew Auld: > On Thu, 21 Oct 2021 at 11:36, Maarten Lankhorst > wrote: >> The signaled bit is already used for quick testing if a fence is signaled. > Why do we need this change? Can you add some more details to the commit > please? It's a terrible abuse of

  1   2   >