Re: [Intel-gfx] [v3 0/3] Enable pipe color support on D13 platform

2021-12-06 Thread Shankar, Uma
> -Original Message- > From: Shankar, Uma > Sent: Tuesday, December 7, 2021 12:42 PM > To: intel-gfx@lists.freedesktop.org > Cc: ville.syrj...@linux.intel.com; Modem, Bhanuprakash > ; Shankar, Uma > Subject: [v3 0/3] Enable pipe color support on D13 platform > > Enable pipe color

[Intel-gfx] [v3 3/3] drm/i915/xelpd: Add Pipe Color Lut caps to platform config

2021-12-06 Thread Uma Shankar
XE_LPD has 128 Lut entries for Degamma, with additional 3 entries for extended range. It has 511 entries for gamma with additional 2 entries for extended range. v2: Updated lut size for 10bit gamma, added lut_tests (Ville) v3: Dropped the gamma lut tests fields (Ville) Signed-off-by: Uma

[Intel-gfx] [v3 2/3] drm/i915/xelpd: Enable Pipe Degamma

2021-12-06 Thread Uma Shankar
Enable Pipe Degamma for XE_LPD. Extend the legacy implementation to incorparate the extended lut size for XE_LPD. v2: Added a helper for degamma lut size (Ville) Signed-off-by: Uma Shankar Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 14 +++--- 1 file

[Intel-gfx] [v3 1/3] drm/i915/xelpd: Enable Pipe color support for D13 platform

2021-12-06 Thread Uma Shankar
Enable pipe color support for Display 13 platforms. Currently limit to just 10bit gamma and later extend it for logarithmic gamma, once the new UAPI is agreed by community and implemented by a userspace consumer. v2: Updated dev_priv to i915 (Ville) Signed-off-by: Uma Shankar Reviewed-by: Ville

[Intel-gfx] [v3 0/3] Enable pipe color support on D13 platform

2021-12-06 Thread Uma Shankar
Enable pipe color support for Display 13 platform. This series enables just the 10bit gamma mode. More advanced logarithmic gamma mode will be enable with the new enhanced UAPI. It will be extended once the UAPI is agreed in community. This series just adds the basic support in the interim. v2:

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Don't go bang in GuC log if no GuC

2021-12-06 Thread Lucas De Marchi
On Fri, Dec 03, 2021 at 12:00:59PM -0800, Daniele Ceraolo Spurio wrote: On 12/2/2021 4:33 PM, Lucas De Marchi wrote: On Thu, Dec 02, 2021 at 04:06:23PM -0800, john.c.harri...@intel.com wrote: From: John Harrison If the GuC has failed to load for any reason and then the user pokes the

Re: [Intel-gfx] [PATCH v6 1/1] drm/i915: Introduce new macros for i915 PTE

2021-12-06 Thread Lucas De Marchi
On Mon, Dec 06, 2021 at 07:36:39PM -0800, Lucas De Marchi wrote: On Mon, Dec 06, 2021 at 01:52:45PM -0800, Michael Cheng wrote: Certain functions within i915 uses macros that are defined for specific architectures by the mmu, such as _PAGE_RW and _PAGE_PRESENT (Some architectures don't even

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/xelpd: Add Pipe Color Lut caps to platform config

2021-12-06 Thread Shankar, Uma
> -Original Message- > From: Ville Syrjälä > Sent: Tuesday, November 30, 2021 3:33 PM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org; Modem, Bhanuprakash > > Subject: Re: [PATCH v2 3/3] drm/i915/xelpd: Add Pipe Color Lut caps to > platform > config > > On Fri, Nov 26,

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/xelpd: Enable Pipe Degamma

2021-12-06 Thread Shankar, Uma
> -Original Message- > From: Jani Nikula > Sent: Tuesday, November 30, 2021 3:36 PM > To: Ville Syrjälä > Cc: Shankar, Uma ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/xelpd: Enable Pipe Degamma > > On Tue, 30 Nov 2021, Ville Syrjälä wrote: > >

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Change DMC FW size on ADL-P

2021-12-06 Thread Lucas De Marchi
On Mon, Dec 06, 2021 at 06:37:18PM -0800, Madhumitha Tolakanahalli Pradeep wrote: Increase the size of DMC on ADL-P to account for support of new features in the current/upcoming DMC versions. I was trying to find anything related on Bspec 49193 and 49194, but didn't find anything related to

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dmc: Change DMC FW size on ADL-P

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Change DMC FW size on ADL-P URL : https://patchwork.freedesktop.org/series/97638/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10965_full -> Patchwork_21770_full Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pmu: Fix wakeref leak in PMU busyness during reset (rev2)

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Fix wakeref leak in PMU busyness during reset (rev2) URL : https://patchwork.freedesktop.org/series/97635/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10965_full -> Patchwork_21769_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pmu: Fix wakeref leak in PMU busyness during reset

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Fix wakeref leak in PMU busyness during reset URL : https://patchwork.freedesktop.org/series/97635/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10965_full -> Patchwork_21768_full

Re: [Intel-gfx] [PATCH v6 1/1] drm/i915: Introduce new macros for i915 PTE

2021-12-06 Thread Lucas De Marchi
On Mon, Dec 06, 2021 at 01:52:45PM -0800, Michael Cheng wrote: Certain functions within i915 uses macros that are defined for specific architectures by the mmu, such as _PAGE_RW and _PAGE_PRESENT (Some architectures don't even have these macros defined, like ARM64). Instead of re-using bits

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Change DMC FW size on ADL-P

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Change DMC FW size on ADL-P URL : https://patchwork.freedesktop.org/series/97638/ State : success == Summary == CI Bug Log - changes from CI_DRM_10965 -> Patchwork_21770 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Follow up on increase timeout in i915_gem_contexts selftests (rev2)

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Follow up on increase timeout in i915_gem_contexts selftests (rev2) URL : https://patchwork.freedesktop.org/series/97577/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10965_full -> Patchwork_21767_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Fix wakeref leak in PMU busyness during reset (rev2)

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Fix wakeref leak in PMU busyness during reset (rev2) URL : https://patchwork.freedesktop.org/series/97635/ State : success == Summary == CI Bug Log - changes from CI_DRM_10965 -> Patchwork_21769

[Intel-gfx] [PATCH] drm/i915/dmc: Change DMC FW size on ADL-P

2021-12-06 Thread Madhumitha Tolakanahalli Pradeep
Increase the size of DMC on ADL-P to account for support of new features in the current/upcoming DMC versions. Signed-off-by: Madhumitha Tolakanahalli Pradeep --- drivers/gpu/drm/i915/display/intel_dmc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Fix wakeref leak in PMU busyness during reset

2021-12-06 Thread Umesh Nerlige Ramappa
On Mon, Dec 06, 2021 at 05:30:43PM -0800, Dixit, Ashutosh wrote: On Mon, 06 Dec 2021 16:45:42 -0800, Umesh Nerlige Ramappa wrote: GuC PMU busyness gets gt wakeref if awake, but fails to release the wakeref if a reset is in progress. Release the wakeref if it was acquried successfully.

[Intel-gfx] [PATCH] drm/i915/pmu: Fix wakeref leak in PMU busyness during reset

2021-12-06 Thread Umesh Nerlige Ramappa
GuC PMU busyness gets gt wakeref if awake, but fails to release the wakeref if a reset is in progress. Release the wakeref if it was acquried successfully. v2: Simplify the fix (Ashutosh) Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +- 1 file

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Fix wakeref leak in PMU busyness during reset

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Fix wakeref leak in PMU busyness during reset URL : https://patchwork.freedesktop.org/series/97635/ State : success == Summary == CI Bug Log - changes from CI_DRM_10965 -> Patchwork_21768 Summary

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Fix wakeref leak in PMU busyness during reset

2021-12-06 Thread Dixit, Ashutosh
On Mon, 06 Dec 2021 16:45:42 -0800, Umesh Nerlige Ramappa wrote: > > GuC PMU busyness gets gt wakeref if awake, but fails to release the > wakeref if a reset is in progress. Release the wakeref if it was > acquried successfully. > > Signed-off-by: Umesh Nerlige Ramappa > --- >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Follow up on increase timeout in i915_gem_contexts selftests (rev2)

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Follow up on increase timeout in i915_gem_contexts selftests (rev2) URL : https://patchwork.freedesktop.org/series/97577/ State : success == Summary == CI Bug Log - changes from CI_DRM_10965 -> Patchwork_21767

[Intel-gfx] [PATCH] drm/i915/pmu: Fix wakeref leak in PMU busyness during reset

2021-12-06 Thread Umesh Nerlige Ramappa
GuC PMU busyness gets gt wakeref if awake, but fails to release the wakeref if a reset is in progress. Release the wakeref if it was acquried successfully. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[Intel-gfx] [PATCH] drm/i915/selftests: Follow up on increase timeout in i915_gem_contexts selftests

2021-12-06 Thread Bruce Chang
Follow up on commit 5e076529e265 ("drm/i915/selftests: Increase timeout in i915_gem_contexts selftests") So we went from 200 msec to 1sec in that commit, and now we are going to 10sec as timeout. Signed-off-by: Bruce Chang Reviewed-by: Matthew Brost Cc: John Harrison ---

[Intel-gfx] ✓ Fi.CI.IGT: success for Introduce new i915 macros for checking PTEs (rev7)

2021-12-06 Thread Patchwork
== Series Details == Series: Introduce new i915 macros for checking PTEs (rev7) URL : https://patchwork.freedesktop.org/series/96679/ State : success == Summary == CI Bug Log - changes from CI_DRM_10965_full -> Patchwork_21766_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for Introduce new i915 macros for checking PTEs (rev7)

2021-12-06 Thread Patchwork
== Series Details == Series: Introduce new i915 macros for checking PTEs (rev7) URL : https://patchwork.freedesktop.org/series/96679/ State : success == Summary == CI Bug Log - changes from CI_DRM_10965 -> Patchwork_21766 Summary ---

Re: [Intel-gfx] ✗ Fi.CI.DOCS: warning for Update to GuC version 69.0.0

2021-12-06 Thread Michal Wajdeczko
On 06.12.2021 20:29, John Harrison wrote: > Michal, do you know what this is complaining about? broken links definitions, fix below Michal diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h index d09d6a5bb63b..6aa3cf7172f7 100644 ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Introduce new i915 macros for checking PTEs (rev7)

2021-12-06 Thread Patchwork
== Series Details == Series: Introduce new i915 macros for checking PTEs (rev7) URL : https://patchwork.freedesktop.org/series/96679/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 1/5] drm/i915/uc: Allow platforms to have GuC but not HuC

2021-12-06 Thread Daniele Ceraolo Spurio
On 12/3/2021 10:33 AM, john.c.harri...@intel.com wrote: From: John Harrison It is possible for platforms to require GuC but not HuC firmware. Also, the firmware versions for GuC and HuC advance independently. So split the macros up to allow the lists to be maintained separately.

[Intel-gfx] [PATCH v6 0/1] Introduce new i915 macros for checking PTEs

2021-12-06 Thread Michael Cheng
This series is to introduce new macros generic to i915 for checking 0 and 1 bits, instead on relying on whats defined by the mmu, since it could be different or non-exisitent between different platforms. v2: Corrected sender's email. v3: Corrected spelling error. v4: Clean up a few other macros

[Intel-gfx] [PATCH v6 1/1] drm/i915: Introduce new macros for i915 PTE

2021-12-06 Thread Michael Cheng
Certain functions within i915 uses macros that are defined for specific architectures by the mmu, such as _PAGE_RW and _PAGE_PRESENT (Some architectures don't even have these macros defined, like ARM64). Instead of re-using bits defined for the CPU, we should use bits defined for i915. This patch

[Intel-gfx] ✗ Fi.CI.IGT: failure for Introduce new i915 macros for checking PTEs (rev6)

2021-12-06 Thread Patchwork
== Series Details == Series: Introduce new i915 macros for checking PTEs (rev6) URL : https://patchwork.freedesktop.org/series/96679/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10965_full -> Patchwork_21765_full Summary

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Weak parallel submission support for execlists

2021-12-06 Thread John Harrison
On 11/11/2021 13:20, Matthew Brost wrote: A weak implementation of parallel submission (multi-bb execbuf IOCTL) for execlists. Doing as little as possible to support this interface for execlists - basically just passing submit fences between each request generated and virtual engines are not

Re: [Intel-gfx] ✗ Fi.CI.DOCS: warning for Update to GuC version 69.0.0

2021-12-06 Thread John Harrison
Michal, do you know what this is complaining about? John. On 12/3/2021 14:27, Patchwork wrote: == Series Details == Series: Update to GuC version 69.0.0 URL : https://patchwork.freedesktop.org/series/97564/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915

Re: [Intel-gfx] [PATCH 07/14] drm/i915: Clean up pre-skl primary plane registers

2021-12-06 Thread kernel test robot
Hi Ville, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [cannot apply to drm-tip/drm-tip v5.16-rc4 next-20211206] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

[Intel-gfx] ✓ Fi.CI.BAT: success for Introduce new i915 macros for checking PTEs (rev6)

2021-12-06 Thread Patchwork
== Series Details == Series: Introduce new i915 macros for checking PTEs (rev6) URL : https://patchwork.freedesktop.org/series/96679/ State : success == Summary == CI Bug Log - changes from CI_DRM_10965 -> Patchwork_21765 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Introduce new i915 macros for checking PTEs (rev6)

2021-12-06 Thread Patchwork
== Series Details == Series: Introduce new i915 macros for checking PTEs (rev6) URL : https://patchwork.freedesktop.org/series/96679/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v2 03/16] drm/i915: Remove pages_mutex and intel_gtt->vma_ops.set/clear_pages members, v2.

2021-12-06 Thread Matthew Auld
On Mon, 29 Nov 2021 at 13:57, Maarten Lankhorst wrote: > > Big delta, but boils down to moving set_pages to i915_vma.c, and removing > the special handling, all callers use the defaults anyway. We only remap > in ggtt, so default case will fall through. > > Because we still don't require locking

Re: [Intel-gfx] [PATCH v2 03/16] drm/i915: Remove pages_mutex and intel_gtt->vma_ops.set/clear_pages members, v2.

2021-12-06 Thread Matthew Auld
On Mon, 6 Dec 2021 at 15:18, Maarten Lankhorst wrote: > > On 06-12-2021 14:13, Matthew Auld wrote: > > On Mon, 29 Nov 2021 at 13:57, Maarten Lankhorst > > wrote: > >> Big delta, but boils down to moving set_pages to i915_vma.c, and removing > >> the special handling, all callers use the defaults

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915/migrate: don't check the scratch page

2021-12-06 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/migrate: don't check the scratch page URL : https://patchwork.freedesktop.org/series/97610/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10965_full -> Patchwork_21762_full

Re: [Intel-gfx] [PATCH 06/14] drm/i915: Use REG_BIT() & co. for universal plane bits

2021-12-06 Thread kernel test robot
Hi Ville, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [cannot apply to drm-tip/drm-tip v5.16-rc4 next-20211206] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Use hw_engine_masks as reset_domains (rev2)

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: Use hw_engine_masks as reset_domains (rev2) URL : https://patchwork.freedesktop.org/series/97543/ State : success == Summary == CI Bug Log - changes from CI_DRM_10965_full -> Patchwork_21761_full

Re: [Intel-gfx] [PATCH v2 03/16] drm/i915: Remove pages_mutex and intel_gtt->vma_ops.set/clear_pages members, v2.

2021-12-06 Thread Maarten Lankhorst
On 06-12-2021 14:13, Matthew Auld wrote: > On Mon, 29 Nov 2021 at 13:57, Maarten Lankhorst > wrote: >> Big delta, but boils down to moving set_pages to i915_vma.c, and removing >> the special handling, all callers use the defaults anyway. We only remap >> in ggtt, so default case will fall

Re: [Intel-gfx] [PATCH v3 0/8] DG2 accelerated migration/clearing support

2021-12-06 Thread Matthew Auld
On 06/12/2021 14:49, Daniel Stone wrote: Hi Matthew, On Mon, 6 Dec 2021 at 13:32, Matthew Auld wrote: Enable accelerated moves and clearing on DG2. On such HW we have minimum page size restrictions when accessing LMEM from the GTT, where we now have to use 64K GTT pages or larger. With the

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Use GEM_BUG_ON for obj ptr NULL check

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915: Use GEM_BUG_ON for obj ptr NULL check URL : https://patchwork.freedesktop.org/series/97605/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10965_full -> Patchwork_21760_full Summary

Re: [Intel-gfx] [PATCH v3 0/8] DG2 accelerated migration/clearing support

2021-12-06 Thread Daniel Stone
Hi Matthew, On Mon, 6 Dec 2021 at 13:32, Matthew Auld wrote: > Enable accelerated moves and clearing on DG2. On such HW we have minimum page > size restrictions when accessing LMEM from the GTT, where we now have to use > 64K > GTT pages or larger. With the ppGTT the page-table also has a

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: Constify static structs

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Constify static structs URL : https://patchwork.freedesktop.org/series/97616/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10965 -> Patchwork_21763 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.BUILD: failure for DG2 accelerated migration/clearing support (rev2)

2021-12-06 Thread Patchwork
== Series Details == Series: DG2 accelerated migration/clearing support (rev2) URL : https://patchwork.freedesktop.org/series/97544/ State : failure == Summary == Applying: drm/i915/migrate: don't check the scratch page Applying: drm/i915/migrate: fix offset calculation Applying:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/migrate: don't check the scratch page

2021-12-06 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/migrate: don't check the scratch page URL : https://patchwork.freedesktop.org/series/97610/ State : success == Summary == CI Bug Log - changes from CI_DRM_10965 -> Patchwork_21762

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: Constify static structs

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Constify static structs URL : https://patchwork.freedesktop.org/series/97616/ State : warning == Summary == $ dim checkpatch origin/drm-tip ad6d0d2d2854 drm/i915/gvt: Constify intel_gvt_gtt_pte_ops 9f75a74af3af drm/i915/gvt: Constify

[Intel-gfx] [PATCH v3 8/8] drm/i915/migrate: turn on acceleration for DG2

2021-12-06 Thread Matthew Auld
Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c index fb658ae70a8d..0fb83d0bec91 100644 ---

[Intel-gfx] [PATCH v3 6/8] drm/i915/gtt: add xehpsdv_ppgtt_insert_entry

2021-12-06 Thread Matthew Auld
If this is LMEM then we get a 32 entry PT, with each PTE pointing to some 64K block of memory, otherwise it's just the usual 512 entry PT. This very much assumes the caller knows what they are doing. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C Reviewed-by: Ramalingam C

[Intel-gfx] [PATCH v3 7/8] drm/i915/migrate: add acceleration support for DG2

2021-12-06 Thread Matthew Auld
This is all kinds of awkward since we now have to contend with using 64K GTT pages when mapping anything in LMEM(including the page-tables themselves). Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 189 +++-

[Intel-gfx] [PATCH v3 5/8] drm/i915/gtt: allow overriding the pt alignment

2021-12-06 Thread Matthew Auld
On some platforms we have alignment restrictions when accessing LMEM from the GTT. In the next patch few patches we need to be able to modify the page-tables directly via the GTT itself. Suggested-by: Ramalingam C Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C ---

[Intel-gfx] [PATCH v3 4/8] drm/i915/selftests: handle object rounding

2021-12-06 Thread Matthew Auld
Ensure we account for any object rounding due to min_page_size restrictions. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C Reviewed-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Intel-gfx] [PATCH v3 3/8] drm/i915/migrate: fix length calculation

2021-12-06 Thread Matthew Auld
No need to insert PTEs for the PTE window itself, also foreach expects a length not an end offset, which could be gigantic here with a second engine. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C Reviewed-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-

[Intel-gfx] [PATCH v3 2/8] drm/i915/migrate: fix offset calculation

2021-12-06 Thread Matthew Auld
Ensure we add the engine base only after we calculate the qword offset into the PTE window. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C Reviewed-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Intel-gfx] [PATCH v3 1/8] drm/i915/migrate: don't check the scratch page

2021-12-06 Thread Matthew Auld
The scratch page might not be allocated in LMEM(like on DG2), so instead of using that as the deciding factor for where the paging structures live, let's just query the pt before mapping it. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C Reviewed-by: Ramalingam C ---

[Intel-gfx] [PATCH v3 0/8] DG2 accelerated migration/clearing support

2021-12-06 Thread Matthew Auld
Enable accelerated moves and clearing on DG2. On such HW we have minimum page size restrictions when accessing LMEM from the GTT, where we now have to use 64K GTT pages or larger. With the ppGTT the page-table also has a slightly different layout from past generations when using the 64K GTT

[Intel-gfx] [PATCH 7/9] drm/i915/gvt: Constify formats

2021-12-06 Thread Rikard Falkeborn
These are never modified, so make them const to allow the compiler to put them in read-only memory. WHile at it, make the description const char* since it is never modified. Signed-off-by: Rikard Falkeborn --- drivers/gpu/drm/i915/gvt/fb_decoder.c | 24 1 file changed,

[Intel-gfx] [PATCH 2/9] drm/i915/gvt: Constify intel_gvt_gtt_pte_ops

2021-12-06 Thread Rikard Falkeborn
These are never modified, so make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/gpu/drm/i915/gvt/gtt.c | 62 +- drivers/gpu/drm/i915/gvt/gtt.h | 2 +- 2 files changed, 32 insertions(+), 32

[Intel-gfx] [PATCH 5/9] drm/i915/gvt: Constify gvt_mmio_block

2021-12-06 Thread Rikard Falkeborn
These are never modified, so make them const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/gpu/drm/i915/gvt/gvt.h | 2 +- drivers/gpu/drm/i915/gvt/handlers.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git

[Intel-gfx] [PATCH 9/9] drm/i915/gvt: Constify vgpu_types

2021-12-06 Thread Rikard Falkeborn
It is never modified, so make it const to allow the compiler to put it in read-only memory. While at it, make name a const char*. Signed-off-by: Rikard Falkeborn --- drivers/gpu/drm/i915/gvt/vgpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 4/9] drm/i915/gvt: Constify intel_gvt_sched_policy_ops

2021-12-06 Thread Rikard Falkeborn
These are never modified, so make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/gpu/drm/i915/gvt/sched_policy.c | 2 +- drivers/gpu/drm/i915/gvt/scheduler.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 6/9] drm/i915/gvt: Constify cmd_interrupt_events

2021-12-06 Thread Rikard Falkeborn
It is never modified, so make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c

[Intel-gfx] [PATCH 1/9] drm/i915/gvt: Constify intel_gvt_gtt_pte_ops

2021-12-06 Thread Rikard Falkeborn
These are never modified, so make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/gpu/drm/i915/gvt/gtt.c | 4 ++-- drivers/gpu/drm/i915/gvt/gtt.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH 0/9] drm/i915/gvt: Constify static structs

2021-12-06 Thread Rikard Falkeborn
Constify a number of static structs that are never modified to allow the compiler to put them in read-only memory. In order to do this, constify a number of local variables and pointers in structs. This is most important for structs that contain function pointers, and the patches for those

[Intel-gfx] [PATCH 8/9] drm/i915/gvt: Constify gtt_type_table_entry

2021-12-06 Thread Rikard Falkeborn
It is never modified, so make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/gpu/drm/i915/gvt/gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c

Re: [Intel-gfx] [PATCH v2 04/16] drm/i915: Take object lock in i915_ggtt_pin if ww is not set

2021-12-06 Thread Matthew Auld
On Mon, 29 Nov 2021 at 13:58, Maarten Lankhorst wrote: > > i915_vma_wait_for_bind needs the vma lock held, fix the caller. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Matthew Auld

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Use hw_engine_masks as reset_domains (rev2)

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: Use hw_engine_masks as reset_domains (rev2) URL : https://patchwork.freedesktop.org/series/97543/ State : success == Summary == CI Bug Log - changes from CI_DRM_10965 -> Patchwork_21761 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: Use hw_engine_masks as reset_domains (rev2)

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: Use hw_engine_masks as reset_domains (rev2) URL : https://patchwork.freedesktop.org/series/97543/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use GEM_BUG_ON for obj ptr NULL check

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915: Use GEM_BUG_ON for obj ptr NULL check URL : https://patchwork.freedesktop.org/series/97605/ State : success == Summary == CI Bug Log - changes from CI_DRM_10965 -> Patchwork_21760 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for More preparation for multi gt patches (rev5)

2021-12-06 Thread Patchwork
== Series Details == Series: More preparation for multi gt patches (rev5) URL : https://patchwork.freedesktop.org/series/97020/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10965 -> Patchwork_21759 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for More preparation for multi gt patches (rev5)

2021-12-06 Thread Patchwork
== Series Details == Series: More preparation for multi gt patches (rev5) URL : https://patchwork.freedesktop.org/series/97020/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More preparation for multi gt patches (rev5)

2021-12-06 Thread Patchwork
== Series Details == Series: More preparation for multi gt patches (rev5) URL : https://patchwork.freedesktop.org/series/97020/ State : warning == Summary == $ dim checkpatch origin/drm-tip 664bf127629d drm/i915: Store backpointer to GT in uncore 6126245f7f9b drm/i915: Introduce to_gt()

[Intel-gfx] [PATCH 1/4] drm/i915/migrate: don't check the scratch page

2021-12-06 Thread Matthew Auld
The scratch page might not be allocated in LMEM(like on DG2), so instead of using that as the deciding factor for where the paging structures live, let's just query the pt before mapping it. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C Reviewed-by: Ramalingam C ---

[Intel-gfx] [PATCH 4/4] drm/i915/selftests: handle object rounding

2021-12-06 Thread Matthew Auld
Ensure we account for any object rounding due to min_page_size restrictions. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C Reviewed-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Intel-gfx] [PATCH 2/4] drm/i915/migrate: fix offset calculation

2021-12-06 Thread Matthew Auld
Ensure we add the engine base only after we calculate the qword offset into the PTE window. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C Reviewed-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Intel-gfx] [PATCH 3/4] drm/i915/migrate: fix length calculation

2021-12-06 Thread Matthew Auld
No need to insert PTEs for the PTE window itself, also foreach expects a length not an end offset, which could be gigantic here with a second engine. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C Reviewed-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-

[Intel-gfx] [PATCH V2] drm/i915/gt: Use hw_engine_masks as reset_domains

2021-12-06 Thread Tejas Upadhyay
We need a way to reset engines by their reset domains. This change sets up way to fetch reset domains of each engine globally. Changes since V1: - Use static reset domain array - Ville and Tvrtko - Use BUG_ON at appropriate place - Tvrtko Signed-off-by: Tejas Upadhyay ---

[Intel-gfx] [PATCH v2] drm/i915: Use GEM_BUG_ON for obj ptr NULL check

2021-12-06 Thread Pallavi Mishra
add GEM_BUG_ON to check for NULL ptr dereferences with obj ptr, this will help catch exceptions in CI tests. v2 change commit text Signed-off-by: Pallavi Mishra --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 +++ drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 3 ++- 2 files changed, 5

[Intel-gfx] [PATCH v5 10/11] drm/i915: Use to_gt() helper for GGTT accesses

2021-12-06 Thread Andi Shyti
From: Michał Winiarski GGTT is currently available both through i915->ggtt and gt->ggtt, and we eventually want to get rid of the i915->ggtt one. Use to_gt() for all i915->ggtt accesses to help with the future refactoring. Signed-off-by: Michał Winiarski Cc: Michal Wajdeczko Signed-off-by:

Re: [Intel-gfx] [PATCH i-g-t] intel-gpu-top: Add support for per client stats

2021-12-06 Thread Tvrtko Ursulin
On 04/12/2021 01:38, Dixit, Ashutosh wrote: On Fri, 03 Dec 2021 07:54:56 -0800, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use the i915 exported data in /proc//fdinfo to show GPU utilization per DRM client. Didn't we just remove it? Adding it back now? Sorry for the probably dumb

[Intel-gfx] [PATCH v5 11/11] drm/i915: Rename i915->gt to i915->gt0

2021-12-06 Thread Andi Shyti
In preparation of the multitile support, highlight the root GT by calling it gt0 inside the drm i915 private data. Signed-off-by: Andi Shyti Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Lucas De Marchi Cc: Rodrigo Vivi Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- 1 file

[Intel-gfx] [PATCH v5 08/11] drm/i915/pxp: Use to_gt() helper

2021-12-06 Thread Andi Shyti
Use to_gt() helper consistently throughout the codebase. Pure mechanical s/i915->gt/to_gt(i915). No functional changes. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH v5 00/11] More preparation for multi gt patches

2021-12-06 Thread Andi Shyti
Hi, the first patch concludes the first stage of refactoring which makes the use of intel_gt on the different subsystem. It's taken from Matt's series and it has alread been reviewed. The patch has just been replaced before any multitile patches and I think it can be already pushed. Patch 2-10

[Intel-gfx] [PATCH v5 04/11] drm/i915/gt: Use to_gt() helper

2021-12-06 Thread Andi Shyti
From: Michał Winiarski Use to_gt() helper consistently throughout the codebase. Pure mechanical s/i915->gt/to_gt(i915). No functional changes. Signed-off-by: Michał Winiarski Singed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_engine_user.c | 2 +-

[Intel-gfx] [PATCH v5 01/11] drm/i915: Store backpointer to GT in uncore

2021-12-06 Thread Andi Shyti
From: Michał Winiarski We now support a per-gt uncore, yet we're not able to infer which GT we're operating upon. Let's store a backpointer for now. Signed-off-by: Michał Winiarski Signed-off-by: Matt Roper Reviewed-by: Andi Shyti Signed-off-by: Andi Shyti ---

[Intel-gfx] [PATCH v5 05/11] drm/i915/gem: Use to_gt() helper

2021-12-06 Thread Andi Shyti
From: Michał Winiarski Use to_gt() helper consistently throughout the codebase. Pure mechanical s/i915->gt/to_gt(i915). No functional changes. Signed-off-by: Michał Winiarski Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 22

[Intel-gfx] [PATCH v5 07/11] drm/i915/selftests: Use to_gt() helper

2021-12-06 Thread Andi Shyti
Use to_gt() helper consistently throughout the codebase. Pure mechanical s/i915->gt/to_gt(i915). No functional changes. Signed-off-by: Andi Shyti Cc: Michał Winiarski --- drivers/gpu/drm/i915/selftests/i915_active.c | 2 +- drivers/gpu/drm/i915/selftests/i915_gem.c | 2 +-

[Intel-gfx] [PATCH v5 02/11] drm/i915: Introduce to_gt() helper

2021-12-06 Thread Andi Shyti
From: Michał Winiarski To allow further refactoring and abstract away the fact that GT is stored inside i915 private. No functional changes. Signed-off-by: Michał Winiarski Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 7 +--

[Intel-gfx] [PATCH v5 06/11] drm/i915/gvt: Use to_gt() helper

2021-12-06 Thread Andi Shyti
From: Michał Winiarski Use to_gt() helper consistently throughout the codebase. Pure mechanical s/i915->gt/to_gt(i915). No functional changes. Signed-off-by: Michał Winiarski Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gvt/gvt.c | 2 +- drivers/gpu/drm/i915/gvt/scheduler.c | 2

[Intel-gfx] [PATCH v5 09/11] drm/i915: Use to_gt() helper

2021-12-06 Thread Andi Shyti
From: Michał Winiarski Use to_gt() helper consistently throughout the codebase. Pure mechanical s/i915->gt/to_gt(i915). No functional changes. Signed-off-by: Michał Winiarski Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/i915_debugfs.c| 38 +++

[Intel-gfx] [PATCH v5 03/11] drm/i915/display: Use to_gt() helper

2021-12-06 Thread Andi Shyti
From: Michał Winiarski Use to_gt() helper consistently throughout the codebase. Pure mechanical s/i915->gt/to_gt(i915). No functional changes. Signed-off-by: Michał Winiarski Signed-off-by: Andi Shyti --- .../gpu/drm/i915/display/intel_atomic_plane.c | 4 ++--

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Rollback seqno when request creation fails (rev2)

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915: Rollback seqno when request creation fails (rev2) URL : https://patchwork.freedesktop.org/series/97562/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10963_full -> Patchwork_21756_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Use local pointer ttm for __i915_ttm_move

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/gem: Use local pointer ttm for __i915_ttm_move URL : https://patchwork.freedesktop.org/series/97572/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10963_full -> Patchwork_21754_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Follow up on increase timeout in i915_gem_contexts selftests

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Follow up on increase timeout in i915_gem_contexts selftests URL : https://patchwork.freedesktop.org/series/97577/ State : success == Summary == CI Bug Log - changes from CI_DRM_10963_full -> Patchwork_21755_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Use local pointer for __i915_ttm_move

2021-12-06 Thread Patchwork
== Series Details == Series: drm/i915/gem: Use local pointer for __i915_ttm_move URL : https://patchwork.freedesktop.org/series/97571/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10963_full -> Patchwork_21753_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for Update to GuC version 69.0.0

2021-12-06 Thread Patchwork
== Series Details == Series: Update to GuC version 69.0.0 URL : https://patchwork.freedesktop.org/series/97564/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10963_full -> Patchwork_21752_full Summary ---

  1   2   >