Re: [Intel-gfx] [PATCH] drm/i915: delete shadow "ret" variable

2022-01-27 Thread Dan Carpenter
On Fri, Jan 28, 2022 at 07:20:02AM +0100, Thomas Hellström wrote: > On Thu, 2022-01-27 at 17:26 -0500, Rodrigo Vivi wrote: > > On Thu, Jan 27, 2022 at 11:51:15AM +0300, Dan Carpenter wrote: > > > This "ret" declaration shadows an existing "ret" variable at the > > > top of > > > the function. 

Re: [Intel-gfx] [PATCH] drm/i915: delete shadow "ret" variable

2022-01-27 Thread Thomas Hellström
On Thu, 2022-01-27 at 17:26 -0500, Rodrigo Vivi wrote: > On Thu, Jan 27, 2022 at 11:51:15AM +0300, Dan Carpenter wrote: > > This "ret" declaration shadows an existing "ret" variable at the > > top of > > the function.  Delete it. > > > > Signed-off-by: Dan Carpenter > > Reviewed-by: Rodrigo

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix a race between vma / object destruction and unbinding

2022-01-27 Thread Thomas Hellström
On Thu, 2022-01-27 at 18:02 +, Patchwork wrote: > Patch Details > Series:drm/i915: Fix a race between vma / object destruction and > unbindingURL: > https://patchwork.freedesktop.org/series/99418/State:failure > Details:https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22125/index.html > CI

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: fix some error codes in __cancel_reset() (rev2)

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix some error codes in __cancel_reset() (rev2) URL : https://patchwork.freedesktop.org/series/99407/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11153_full -> Patchwork_22131_full

Re: [Intel-gfx] [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread kernel test robot
Hi Zhi, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on next-20220127] [cannot apply to drm-intel/for-linux-next hch-configfs/for-next v5.17-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note

[Intel-gfx] [RFC PATCH] i915/gvt: intel_gvt_match_device() can be static

2022-01-27 Thread kernel test robot
drivers/gpu/drm/i915/gvt/handlers.c:45:6: warning: symbol 'intel_gvt_match_device' was not declared. Should it be static? Reported-by: kernel test robot Signed-off-by: kernel test robot --- handlers.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] ✓ Fi.CI.BAT: success for Second round of i915_reg.h splitting (rev3)

2022-01-27 Thread Patchwork
== Series Details == Series: Second round of i915_reg.h splitting (rev3) URL : https://patchwork.freedesktop.org/series/99079/ State : success == Summary == CI Bug Log - changes from CI_DRM_11154 -> Patchwork_22133 Summary ---

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/uapi: Add query for hwconfig table

2022-01-27 Thread Jordan Justen
John Harrison writes: > On 1/27/2022 16:48, Jordan Justen wrote: >> john.c.harri...@intel.com writes: >> >>> From: Rodrigo Vivi >>> >>> GuC contains a consolidated table with a bunch of information about the >>> current device. >>> >>> Previously, this information was spread and hardcoded to

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dg2: Add Wa_14015227452

2022-01-27 Thread Matt Roper
On Fri, Jan 28, 2022 at 01:41:57AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dg2: Add Wa_14015227452 > URL : https://patchwork.freedesktop.org/series/99446/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11152_full -> Patchwork_22130_full >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Second round of i915_reg.h splitting (rev3)

2022-01-27 Thread Patchwork
== Series Details == Series: Second round of i915_reg.h splitting (rev3) URL : https://patchwork.freedesktop.org/series/99079/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Second round of i915_reg.h splitting (rev3)

2022-01-27 Thread Patchwork
== Series Details == Series: Second round of i915_reg.h splitting (rev3) URL : https://patchwork.freedesktop.org/series/99079/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4b63057fdde4 drm/i915/perf: Move OA regs to their own header -:40: WARNING:FILE_PATH_CHANGES: added,

[Intel-gfx] ✗ Fi.CI.BAT: failure for Use drm_clflush* instead of clflush

2022-01-27 Thread Patchwork
== Series Details == Series: Use drm_clflush* instead of clflush URL : https://patchwork.freedesktop.org/series/99450/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11154 -> Patchwork_22132 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dg2: Add Wa_14015227452

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_14015227452 URL : https://patchwork.freedesktop.org/series/99446/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11152_full -> Patchwork_22130_full Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Use drm_clflush* instead of clflush

2022-01-27 Thread Patchwork
== Series Details == Series: Use drm_clflush* instead of clflush URL : https://patchwork.freedesktop.org/series/99450/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/uapi: Add query for hwconfig table

2022-01-27 Thread John Harrison
On 1/27/2022 16:48, Jordan Justen wrote: john.c.harri...@intel.com writes: From: Rodrigo Vivi GuC contains a consolidated table with a bunch of information about the current device. Previously, this information was spread and hardcoded to all the components including GuC, i915 and various

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/uapi: Add query for hwconfig table

2022-01-27 Thread Jordan Justen
john.c.harri...@intel.com writes: > From: Rodrigo Vivi > > GuC contains a consolidated table with a bunch of information about the > current device. > > Previously, this information was spread and hardcoded to all the components > including GuC, i915 and various UMDs. The goal here is to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: fix some error codes in __cancel_reset() (rev2)

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix some error codes in __cancel_reset() (rev2) URL : https://patchwork.freedesktop.org/series/99407/ State : success == Summary == CI Bug Log - changes from CI_DRM_11153 -> Patchwork_22131

[Intel-gfx] [CI v3 4/6] drm/i915: Parameterize MI_PREDICATE registers

2022-01-27 Thread Matt Roper
The various MI_PREDICATE registers have per-engine instances. Today we only utilize the RCS0 instance of each, but that will likely change in the future; switch to parameterized register definitions to make these easier to work with going forward. Of special note is MI_PREDICATE_RESULT_2; we

[Intel-gfx] [CI v3 3/6] drm/i915: Parameterize R_PWR_CLK_STATE register definition

2022-01-27 Thread Matt Roper
At the moment we only use R_PWR_CLK_STATE in the context of the RCS engine, but upcoming support for compute engines will start using instances relative to the CCS engine base offsets. Let's parameterize the register and move it to the engine reg header. Cc: Jani Nikula Signed-off-by: Matt

[Intel-gfx] [CI v3 6/6] drm/i915: Only include i915_reg.h from .c files

2022-01-27 Thread Matt Roper
Several of our i915 header files, have been including i915_reg.h. This means that any change to i915_reg.h will trigger a full rebuild of pretty much every file of the driver, even those that don't have any kind of register access. Let's delete the i915_reg.h include from all headers and add an

[Intel-gfx] [CI v3 2/6] drm/i915/perf: Express OA register ranges with i915_range

2022-01-27 Thread Matt Roper
Let's use 'struct i915_range' to express sets of b-counter and mux registers in the perf code. This makes the code more similar to how we handle things like multicast register ranges, forcewake tables, shadow tables, etc. and also lets us avoid needing symbolic register name definitions for the

[Intel-gfx] [CI v3 1/6] drm/i915/perf: Move OA regs to their own header

2022-01-27 Thread Matt Roper
The OA unit registers are only used by the perf code; move them to their own header file. Cc: Jani Nikula Cc: Umesh Nerlige Ramappa Cc: Lionel Landwerlin Signed-off-by: Matt Roper Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/gvt/scheduler.c | 1 +

[Intel-gfx] [CI v3 0/6] Second round of i915_reg.h splitting

2022-01-27 Thread Matt Roper
Let's continue to split our giant i915_reg.h file into more logical domain-specific headers. In addition to a bunch of register definition segregation, the final patch of this series ensures that i915_reg.h is only #include'd from .c files that truly need its definitions (and removes all of the

[Intel-gfx] [PATCH 0/2] Use drm_clflush* instead of clflush

2022-01-27 Thread Michael Cheng
This patch series re-work a few i915 functions to use drm_clflush_virt_range instead of calling clflush directly. This will prevent errors when building for non-x86 architectures. Michael Cheng (2): drm/i915/gt: Re-work intel_write_status_page drm/i915/gt: Re-work invalidate_csb_entries

[Intel-gfx] [PATCH 2/2] drm/i915/gt: Re-work invalidate_csb_entries

2022-01-27 Thread Michael Cheng
Re-work invalidate_csb_entries to use drm_clflush_virt_range. This will prevent compiler errors when building for non-x86 architectures. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 1/2] drm/i915/gt: Re-work intel_write_status_page

2022-01-27 Thread Michael Cheng
Re-work intel_write_status_page to use drm_clflush_virt_range. This will prevent compiler errors when building for non-x86 architectures. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gt/intel_engine.h | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git

Re: [Intel-gfx] [PATCH] drm/i915: delete shadow "ret" variable

2022-01-27 Thread Rodrigo Vivi
On Thu, Jan 27, 2022 at 11:51:15AM +0300, Dan Carpenter wrote: > This "ret" declaration shadows an existing "ret" variable at the top of > the function. Delete it. > > Signed-off-by: Dan Carpenter Reviewed-by: Rodrigo Vivi and pushing right now > --- > drivers/gpu/drm/i915/i915_vma.c | 2

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v11,1/5] drm: improve drm_buddy_alloc function

2022-01-27 Thread Patchwork
== Series Details == Series: series starting with [v11,1/5] drm: improve drm_buddy_alloc function URL : https://patchwork.freedesktop.org/series/99430/ State : success == Summary == CI Bug Log - changes from CI_DRM_11151_full -> Patchwork_22128_full

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/perf: Express OA register ranges with i915_range

2022-01-27 Thread Umesh Nerlige Ramappa
On Mon, Jan 24, 2022 at 06:08:22PM -0800, Matt Roper wrote: Let's use 'struct i915_range' to express sets of b-counter and mux registers in the perf code. This makes the code more similar to how we handle things like multicast register ranges, forcewake tables, shadow tables, etc. and also lets

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread Patchwork
== Series Details == Series: series starting with [1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API URL : https://patchwork.freedesktop.org/series/99420/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11151_full -> Patchwork_22127_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg2: Add Wa_14015227452

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_14015227452 URL : https://patchwork.freedesktop.org/series/99446/ State : success == Summary == CI Bug Log - changes from CI_DRM_11152 -> Patchwork_22130 Summary --- **WARNING**

Re: [Intel-gfx] [PATCH v2] drm/i915/display/vrr: Reset VRR capable property on a long hpd

2022-01-27 Thread Navare, Manasi
Hi Jani, I have addressed your review comments, could you take a look at this patch, this is needed by one of our customers. Manasi On Wed, Jan 26, 2022 at 11:53:04AM -0800, Manasi Navare wrote: > With some VRR panels, user can turn VRR ON/OFF on the fly from the panel > settings. > When VRR

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dg2: Add Wa_14015227452

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_14015227452 URL : https://patchwork.freedesktop.org/series/99446/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: M/N cleanup (rev2)

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915: M/N cleanup (rev2) URL : https://patchwork.freedesktop.org/series/99409/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11151_full -> Patchwork_22126_full Summary ---

[Intel-gfx] [PATCH] drm/i915/dg2: Add Wa_14015227452

2022-01-27 Thread Matt Roper
Note that the bspec doesn't list the bit we're programming here (bit 11) as being present on DG2, but we've confirmed with the hardware team that this is a documentation mistake and the bit does indeed exist on all Xe_HP-based platforms. Signed-off-by: Matt Roper ---

Re: [Intel-gfx] [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread kernel test robot
Hi Zhi, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on next-20220127] [cannot apply to drm-intel/for-linux-next v5.17-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: [Intel-gfx] [PATCH 1/3] drm: add writeback pointers to drm_connector

2022-01-27 Thread Abhinav Kumar
Hi Suraj Thanks for the response. I was not too worried about the intel driver as I am sure you must have validated this change with that :) My question was more for the other vendor writeback drivers. Thanks for looking into the others and providing the snippets. After looking at those,

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix a race between vma / object destruction and unbinding

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915: Fix a race between vma / object destruction and unbinding URL : https://patchwork.freedesktop.org/series/99418/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11150_full -> Patchwork_22125_full

Re: [Intel-gfx] [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread kernel test robot
Hi Zhi, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on next-20220127] [cannot apply to drm-intel/for-linux-next hch-configfs/for-next v5.17-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Clean up M/N register defines

2022-01-27 Thread kernel test robot
Hi Ville, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip v5.17-rc1 next-20220127] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [Intel-gfx] [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread kernel test robot
Hi Zhi, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on next-20220127] [cannot apply to drm-intel/for-linux-next v5.17-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

[Intel-gfx] ✗ Fi.CI.BAT: failure for Initial support for small BAR recovery (rev2)

2022-01-27 Thread Patchwork
== Series Details == Series: Initial support for small BAR recovery (rev2) URL : https://patchwork.freedesktop.org/series/99370/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11151 -> Patchwork_22129 Summary ---

Re: [Intel-gfx] [PATCH 01/19] dma-buf-map: Add read/write helpers

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 03:26:43PM +0100, Thomas Zimmermann wrote: Hi Am 26.01.22 um 21:36 schrieb Lucas De Marchi: In certain situations it's useful to be able to read or write to an offset that is calculated by having the memory layout given by a struct declaration. Usually we are going to

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Initial support for small BAR recovery (rev2)

2022-01-27 Thread Patchwork
== Series Details == Series: Initial support for small BAR recovery (rev2) URL : https://patchwork.freedesktop.org/series/99370/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Initial support for small BAR recovery (rev2)

2022-01-27 Thread Patchwork
== Series Details == Series: Initial support for small BAR recovery (rev2) URL : https://patchwork.freedesktop.org/series/99370/ State : warning == Summary == $ dim checkpatch origin/drm-tip 79d8983444bd drm: improve drm_buddy_alloc function -:399: WARNING:AVOID_BUG: Avoid crashing the kernel

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v11,1/5] drm: improve drm_buddy_alloc function

2022-01-27 Thread Patchwork
== Series Details == Series: series starting with [v11,1/5] drm: improve drm_buddy_alloc function URL : https://patchwork.freedesktop.org/series/99430/ State : success == Summary == CI Bug Log - changes from CI_DRM_11151 -> Patchwork_22128

Re: [Intel-gfx] [Linaro-mm-sig] Re: [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 12:44:21PM +0100, Christian König wrote: Am 27.01.22 um 12:16 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 11:21:20AM +0100, Christian König wrote: Am 27.01.22 um 11:00 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: On Thu,

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 11:21:20AM +0100, Christian König wrote: Am 27.01.22 um 11:00 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 03:33:12PM +0100, Thomas Zimmermann wrote: Am 26.01.22 um 21:36 schrieb Lucas De Marchi: When dma_buf_map struct is passed around, it's useful to be able to initialize a second map that takes care of reading/writing to an offset of the original map. Add a helper that

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v11,1/5] drm: improve drm_buddy_alloc function

2022-01-27 Thread Patchwork
== Series Details == Series: series starting with [v11,1/5] drm: improve drm_buddy_alloc function URL : https://patchwork.freedesktop.org/series/99430/ State : warning == Summary == $ dim checkpatch origin/drm-tip 00470383ca08 drm: improve drm_buddy_alloc function -:386: WARNING:AVOID_BUG:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread Patchwork
== Series Details == Series: series starting with [1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API URL : https://patchwork.freedesktop.org/series/99420/ State : success == Summary == CI Bug Log - changes from CI_DRM_11151 -> Patchwork_22127

Re: [Intel-gfx] [PATCH 09/19] dma-buf-map: Add wrapper over memset

2022-01-27 Thread Thomas Zimmermann
Am 27.01.22 um 16:38 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 03:54:21PM +0100, Thomas Zimmermann wrote: Hi Am 26.01.22 um 21:36 schrieb Lucas De Marchi: Just like memcpy_toio(), there is also need to write a direct value to a memory block. Add dma_buf_map_memset() to abstract

Re: [Intel-gfx] [PATCH 09/19] dma-buf-map: Add wrapper over memset

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 03:54:21PM +0100, Thomas Zimmermann wrote: Hi Am 26.01.22 um 21:36 schrieb Lucas De Marchi: Just like memcpy_toio(), there is also need to write a direct value to a memory block. Add dma_buf_map_memset() to abstract memset() vs memset_io() Cc: Matt Roper Cc: Sumit

Re: [Intel-gfx] [RFC PATCH] drm/i915: Remove all frontbuffer tracking calls from the gem code

2022-01-27 Thread Ville Syrjälä
On Thu, Jan 27, 2022 at 09:20:14AM +0100, Maarten Lankhorst wrote: > Op 26-01-2022 om 14:09 schreef Jouni Högander: > > We should now rely on userspace doing dirtyfb. There is no > > need to have separate frontbuffer tracking hooks in gem code. > > > > This patch is removing all frontbuffer

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/adl-n: Add PCH Support for Alder Lake N

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915/adl-n: Add PCH Support for Alder Lake N URL : https://patchwork.freedesktop.org/series/99413/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11149_full -> Patchwork_22123_full Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread Patchwork
== Series Details == Series: series starting with [1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API URL : https://patchwork.freedesktop.org/series/99420/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread Patchwork
== Series Details == Series: series starting with [1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API URL : https://patchwork.freedesktop.org/series/99420/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1d24765d58ce i915/gvt: Introduce the mmio_table.c to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: M/N cleanup (rev2)

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915: M/N cleanup (rev2) URL : https://patchwork.freedesktop.org/series/99409/ State : success == Summary == CI Bug Log - changes from CI_DRM_11151 -> Patchwork_22126 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH 09/19] dma-buf-map: Add wrapper over memset

2022-01-27 Thread Thomas Zimmermann
Hi Am 26.01.22 um 21:36 schrieb Lucas De Marchi: Just like memcpy_toio(), there is also need to write a direct value to a memory block. Add dma_buf_map_memset() to abstract memset() vs memset_io() Cc: Matt Roper Cc: Sumit Semwal Cc: Christian König Cc: linux-me...@vger.kernel.org Cc:

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Thomas Zimmermann
Hi Am 27.01.22 um 11:21 schrieb Christian König: Am 27.01.22 um 11:00 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am

Re: [Intel-gfx] [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread Christoph Hellwig
What tree is this series against? It doesn't seem to apply to Linus' current tree or 5.17-rc1.

Re: [Intel-gfx] [RFC PATCH] drm/i915: Remove all frontbuffer tracking calls from the gem code

2022-01-27 Thread Rodrigo Vivi
On Thu, Jan 27, 2022 at 09:20:14AM +0100, Maarten Lankhorst wrote: > Op 26-01-2022 om 14:09 schreef Jouni Högander: > > We should now rely on userspace doing dirtyfb. There is no > > need to have separate frontbuffer tracking hooks in gem code. > > > > This patch is removing all frontbuffer

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: M/N cleanup (rev2)

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915: M/N cleanup (rev2) URL : https://patchwork.freedesktop.org/series/99409/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Thomas Zimmermann
Am 26.01.22 um 21:36 schrieb Lucas De Marchi: When dma_buf_map struct is passed around, it's useful to be able to initialize a second map that takes care of reading/writing to an offset of the original map. Add a helper that copies the struct and add the offset to the proper address. Cc:

Re: [Intel-gfx] [PATCH 01/19] dma-buf-map: Add read/write helpers

2022-01-27 Thread Thomas Zimmermann
Hi Am 26.01.22 um 21:36 schrieb Lucas De Marchi: In certain situations it's useful to be able to read or write to an offset that is calculated by having the memory layout given by a struct declaration. Usually we are going to read/write a u8, u16, u32 or u64. Add a pair of macros

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: delete shadow "ret" variable

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915: delete shadow "ret" variable URL : https://patchwork.freedesktop.org/series/99408/ State : success == Summary == CI Bug Log - changes from CI_DRM_11149_full -> Patchwork_22121_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix a race between vma / object destruction and unbinding

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915: Fix a race between vma / object destruction and unbinding URL : https://patchwork.freedesktop.org/series/99418/ State : success == Summary == CI Bug Log - changes from CI_DRM_11150 -> Patchwork_22125

Re: [Intel-gfx] [Linaro-mm-sig] Re: [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Christian König
Am 27.01.22 um 12:16 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 11:21:20AM +0100, Christian König wrote: Am 27.01.22 um 11:00 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: On Thu, Jan

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Thomas Hellström
On 1/27/22 13:38, Maarten Lankhorst wrote: Op 27-01-2022 om 13:09 schreef Thomas Hellström: On 1/27/22 13:05, Thomas Hellström wrote: The bug on vm_close is a separate bug, and would probably best be fixed in a separate patch. Could I get a r-b on this? It should fix some issues, even if

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Maarten Lankhorst
Op 27-01-2022 om 13:09 schreef Thomas Hellström: > > On 1/27/22 13:05, Thomas Hellström wrote: >> >>> The bug on vm_close is a separate bug, and would probably best be >>> fixed in a separate patch. >>> >>> Could I get a r-b on this? It should fix some issues, even if the >>> unbind there is a

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Thomas Hellström
On 1/27/22 13:05, Thomas Hellström wrote: The bug on vm_close is a separate bug, and would probably best be fixed in a separate patch. Could I get a r-b on this? It should fix some issues, even if the unbind there is a separate bug. ~Maarten Recognizing that it doesn't fix the vm_close

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Thomas Hellström
On Thu, 2022-01-27 at 13:02 +0100, Maarten Lankhorst wrote: > Op 26-01-2022 om 13:55 schreef Gwan-gyeong Mun: > > > > > > On 1/26/22 9:37 AM, Maarten Lankhorst wrote: > > > set_cache_level may unbind the object, which will result in the > > > below > > > lockdep splat: > > > <6> [184.578145]

[Intel-gfx] [PATCH 3/3] i915/gvt: Use the initial HW state snapshot saved in i915

2022-01-27 Thread Zhi Wang
The code of saving initial HW state snapshot has been moved into i915. Let the GVT-g core logic use that snapshot. Cc: Christoph Hellwig Cc: Jason Gunthorpe Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Vivi Rodrigo Cc: Zhenyu Wang Cc: Zhi Wang Signed-off-by: Zhi Wang ---

[Intel-gfx] [PATCH 2/3] i915/gvt: save the initial HW state snapshot in i915.

2022-01-27 Thread Zhi Wang
Save the inital HW state snapshot in i915 so that the rest code of GVT-g can be moved into a dedicated module while it can still get a clean initial HW state saved at the correct time during the initialization of i915. The futhrer vGPU created by GVT-g will use this HW state as the initial HW

[Intel-gfx] [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread Zhi Wang
From: Zhi Wang To support the new mdev interfaces and the re-factor patches from Christoph, which moves the GVT-g code into a dedicated module, the GVT-g initialization path has to be separated into two phases: a) Early initialization. The early initialization of GVT requires to be done when

[Intel-gfx] [PATCH v2 02/14] drm/i915: Clean up M/N register defines

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä Use REG_GENMASK() & co. for the M/N register values. There are also a lot of weird unused defines (eg. *_OFFSET) we can just throw out. Also let's mask out the unused bits during readout for good measure. Previously we only masked out the TU_SIZE from one of the registers,

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Maarten Lankhorst
Op 26-01-2022 om 13:55 schreef Gwan-gyeong Mun: > > > On 1/26/22 9:37 AM, Maarten Lankhorst wrote: >> set_cache_level may unbind the object, which will result in the below >> lockdep splat: >> <6> [184.578145] [IGT] kms_addfb_basic: starting subtest >> addfb25-framebuffer-vs-set-tiling >> <4>

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915/pmu: Fix KMD and GuC race on accessing busyness

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] drm/i915/pmu: Fix KMD and GuC race on > accessing busyness > URL : https://patchwork.freedesktop.org/series/99386/ > State : failure > > == Summary == > > CALLscripts/checksyscalls.sh >

[Intel-gfx] [PULL] drm-misc-next

2022-01-27 Thread Maarten Lankhorst
Hi Dave & Daniel, First pull for v5.18 drm-misc-next-2022-01-27: drm-misc-next for v5.18: UAPI Changes: - Fix invalid IN_FORMATS blob when plane->format_mod_supported is NULL. Cross-subsystem Changes: - Assorted dt bindings updates. - Fix vga16fb vga checking on x86. - Fix extra semicolon in

Re: [Intel-gfx] [PATCH] drm/i915: Fix a race between vma / object destruction and unbinding

2022-01-27 Thread Maarten Lankhorst
Op 27-01-2022 om 12:56 schreef Thomas Hellström: > The vma destruction code was using an unlocked advisory check for > drm_mm_node_allocated() to avoid racing with eviction code unbinding > the vma. > > This is very fragile and prohibits the dereference of non-refcounted > pointers of dying vmas

Re: [Intel-gfx] [Linaro-mm-sig] Re: [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 12:44:21PM +0100, Christian König wrote: > Am 27.01.22 um 12:16 schrieb Daniel Vetter: > > On Thu, Jan 27, 2022 at 11:21:20AM +0100, Christian König wrote: > > > Am 27.01.22 um 11:00 schrieb Daniel Vetter: > > > > On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi

[Intel-gfx] [PATCH] drm/i915: Fix a race between vma / object destruction and unbinding

2022-01-27 Thread Thomas Hellström
The vma destruction code was using an unlocked advisory check for drm_mm_node_allocated() to avoid racing with eviction code unbinding the vma. This is very fragile and prohibits the dereference of non-refcounted pointers of dying vmas after a call to __i915_vma_unbind(). It also prohibits the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/adl-n: Add PCH Support for Alder Lake N

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915/adl-n: Add PCH Support for Alder Lake N URL : https://patchwork.freedesktop.org/series/99413/ State : success == Summary == CI Bug Log - changes from CI_DRM_11149 -> Patchwork_22123 Summary ---

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Move drrs hardware bit frobbing to small helpers

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, Ville Syrjälä wrote: > On Thu, Jan 27, 2022 at 01:24:05PM +0200, Jani Nikula wrote: >> On Thu, 27 Jan 2022, Jani Nikula wrote: >> > On Thu, 27 Jan 2022, Ville Syrjala wrote: >> >> From: Ville Syrjälä >> >> >> >> Split the drrs code that actually changes the refresh rate >>

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Clean up M/N register defines

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, Ville Syrjälä wrote: > On Thu, Jan 27, 2022 at 01:17:21PM +0200, Jani Nikula wrote: >> On Thu, 27 Jan 2022, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > Use REG_GENMASK() & co. for the M/N register values. There are >> > also a lot of weird unused defines (eg.

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Add driver for GSC controller (rev4)

2022-01-27 Thread Patchwork
== Series Details == Series: Add driver for GSC controller (rev4) URL : https://patchwork.freedesktop.org/series/98066/ State : failure == Summary == Applying: drm/i915/gsc: add gsc as a mei auxiliary device Using index info to reconstruct a base tree... M MAINTAINERS M

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Move drrs hardware bit frobbing to small helpers

2022-01-27 Thread Ville Syrjälä
On Thu, Jan 27, 2022 at 01:24:05PM +0200, Jani Nikula wrote: > On Thu, 27 Jan 2022, Jani Nikula wrote: > > On Thu, 27 Jan 2022, Ville Syrjala wrote: > >> From: Ville Syrjälä > >> > >> Split the drrs code that actually changes the refresh rate > >> (via PIPECONF or M/N values) to small helper

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Clean up M/N register defines

2022-01-27 Thread Ville Syrjälä
On Thu, Jan 27, 2022 at 01:17:21PM +0200, Jani Nikula wrote: > On Thu, 27 Jan 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Use REG_GENMASK() & co. for the M/N register values. There are > > also a lot of weird unused defines (eg. *_OFFSET) we can just > > throw out. > > > >

Re: [Intel-gfx] [PATCH v4 0/5] Add driver for GSC controller

2022-01-27 Thread Greg Kroah-Hartman
On Thu, Jan 27, 2022 at 12:31:07PM +0100, Greg Kroah-Hartman wrote: > On Thu, Jan 27, 2022 at 01:20:58PM +0200, Alexander Usyskin wrote: > > GSC is a graphics system controller, it provides > > a chassis controller for graphics discrete cards. > > > > There are two MEI interfaces in GSC: HECI1

Re: [Intel-gfx] [PATCH v4 0/5] Add driver for GSC controller

2022-01-27 Thread Greg Kroah-Hartman
On Thu, Jan 27, 2022 at 01:20:58PM +0200, Alexander Usyskin wrote: > GSC is a graphics system controller, it provides > a chassis controller for graphics discrete cards. > > There are two MEI interfaces in GSC: HECI1 and HECI2. > > This series includes instantiation of the auxiliary devices for

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Move drrs hardware bit frobbing to small helpers

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, Jani Nikula wrote: > On Thu, 27 Jan 2022, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> Split the drrs code that actually changes the refresh rate >> (via PIPECONF or M/N values) to small helper functions that >> only deal with the hardware details an nothing else.

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Move drrs hardware bit frobbing to small helpers

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Split the drrs code that actually changes the refresh rate > (via PIPECONF or M/N values) to small helper functions that > only deal with the hardware details an nothing else. We'll > soon have a third way of doing this, and

[Intel-gfx] [PATCH v4 5/5] mei: gsc: retrieve the firmware version

2022-01-27 Thread Alexander Usyskin
Add a hook to retrieve the firmware version of the GSC devices to bus-fixup. GSC has a different MKHI clients GUIDs but the same message structure to retrieve the firmware version as MEI so mei_fwver() can be reused. CC: Ashutosh Dixit Signed-off-by: Alexander Usyskin Signed-off-by: Tomas

[Intel-gfx] [PATCH v4 4/5] mei: gsc: add runtime pm handlers

2022-01-27 Thread Alexander Usyskin
From: Tomas Winkler Implement runtime handlers for mei-gsc, to track idle state of the device properly. CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- V4: drop debug prints --- drivers/misc/mei/gsc-me.c | 67 ++- 1 file

[Intel-gfx] [PATCH v4 3/5] mei: gsc: setup char driver alive in spite of firmware handshake failure

2022-01-27 Thread Alexander Usyskin
Setup char device in spite of firmware handshake failure. In order to provide host access to the firmware status registers and other information required for the manufacturing process. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/gsc-me.c | 11 ++-

[Intel-gfx] [PATCH v4 2/5] mei: add support for graphics system controller (gsc) devices

2022-01-27 Thread Alexander Usyskin
From: Tomas Winkler GSC is a graphics system controller, based on CSE, it provides a chassis controller for graphics discrete cards, as well as it supports media protection on selected devices. mei_gsc binds to a auxiliary devices exposed by Intel discrete driver i915. Signed-off-by: Alexander

[Intel-gfx] [PATCH v4 1/5] drm/i915/gsc: add gsc as a mei auxiliary device

2022-01-27 Thread Alexander Usyskin
From: Tomas Winkler GSC is a graphics system controller, it provides a chassis controller for graphics discrete cards. There are two MEI interfaces in GSC: HECI1 and HECI2. Both interfaces are on the BAR0 at offsets 0x00258000 and 0x00259000. GSC is a GT Engine (class 4: instance 6). HECI1

[Intel-gfx] [PATCH v4 0/5] Add driver for GSC controller

2022-01-27 Thread Alexander Usyskin
GSC is a graphics system controller, it provides a chassis controller for graphics discrete cards. There are two MEI interfaces in GSC: HECI1 and HECI2. This series includes instantiation of the auxiliary devices for HECI2 and mei-gsc auxiliary device driver that binds to the auxiliary device.

Re: [Intel-gfx] [PATCH 03/14] drm/i915: s/gmch_{m,n}/data_{m,n}/

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Rename the gmch_* M/N members to data_* to match the register > definitions and thus make life a little less confusing. Yes, please! Reviewed-by: Jani Nikula > > Signed-off-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Clean up M/N register defines

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Use REG_GENMASK() & co. for the M/N register values. There are > also a lot of weird unused defines (eg. *_OFFSET) we can just > throw out. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_display.c

  1   2   >