Re: [Intel-gfx] [PATCH v3] uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

2022-05-13 Thread Jordan Justen
On 2022-05-13 05:31:00, Lionel Landwerlin wrote: > On 02/05/2022 17:15, Ramalingam C wrote: > > Capture the impact of memory region preference list of the objects, on > > their memory residency and Flat-CCS capability. > > > > v2: > >Fix the Flat-CCS capability of an obj with {lmem, smem}

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: disable HPD workers before display driver unregister (rev6)

2022-05-13 Thread Patchwork
== Series Details == Series: drm/i915/display: disable HPD workers before display driver unregister (rev6) URL : https://patchwork.freedesktop.org/series/103811/ State : success == Summary == CI Bug Log - changes from CI_DRM_11651_full -> Patchwork_103811v6_full

Re: [Intel-gfx] [PATCH i-g-t] tests/core_hotunplug: Check sysfs reads after hotunplug

2022-05-13 Thread Dixit, Ashutosh
On Fri, 13 May 2022 02:31:28 -0700, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Leave some sysfs files open and attempt to read from them after hotunplug. A few minor comments below but otherwise LGTM: Reviewed-by: Ashutosh Dixit > Signed-off-by: Tvrtko Ursulin > Cc: Ashutosh Dixit >

Re: [Intel-gfx] [PATCH v3] drm/i915: Enable Tile4 tiling mode

2022-05-13 Thread Matt Roper
On Fri, May 13, 2022 at 10:47:54AM +0200, Nirmoy Das wrote: > From: Bommu Krishnaiah > > Enable Tile4 tiling mode on platform that supports > Tile4 but no TileY like DG2. Drive-by comment: the patch description doesn't match what the code is actually doing. Tile4 is already enabled on these

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: disable HPD workers before display driver unregister (rev6)

2022-05-13 Thread Patchwork
== Series Details == Series: drm/i915/display: disable HPD workers before display driver unregister (rev6) URL : https://patchwork.freedesktop.org/series/103811/ State : success == Summary == CI Bug Log - changes from CI_DRM_11651 -> Patchwork_103811v6

[Intel-gfx] ✓ Fi.CI.IGT: success for Fixes for selective fetch area calculation (rev5)

2022-05-13 Thread Patchwork
== Series Details == Series: Fixes for selective fetch area calculation (rev5) URL : https://patchwork.freedesktop.org/series/103659/ State : success == Summary == CI Bug Log - changes from CI_DRM_11649_full -> Patchwork_103659v5_full

Re: [Intel-gfx] [PATCH] drm/i915/guc/rc: Use i915_probe_error instead of drm_error

2022-05-13 Thread Teres Alexis, Alan Previn
Nit: not sure why we use ERR_PTR for int when calling func was also returning an int. Anyway, that was how the original code was, so: Reviewed-by: Alan Previn On Thu, 2022-05-05 at 22:41 -0700, Vinay Belgaumkar wrote: > To avoid false positives in error injection cases. > > Signed-off-by:

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes (rev6)

2022-05-13 Thread Vudum, Lakshminarayana
I have reopened the https://gitlab.freedesktop.org/drm/intel/-/issues/4440 igt@prime_self_import@reimport-vs-gem_close-race - fail - Failed assertion: obj_count == 0,error: -2 != 0 "{igt@i915_pm_freq_mult@media-freq@gt0" is not yet in CI bug log. Thanks, Lakshmi. -Original Message-

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/d12+: Disable DMC firmware flip queue handlers (rev3)

2022-05-13 Thread Patchwork
== Series Details == Series: drm/i915/d12+: Disable DMC firmware flip queue handlers (rev3) URL : https://patchwork.freedesktop.org/series/103888/ State : success == Summary == CI Bug Log - changes from CI_DRM_11649_full -> Patchwork_103888v3_full

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915/psr: Use full update In case of area calculation fails

2022-05-13 Thread Souza, Jose
On Fri, 2022-05-13 at 17:28 +0300, Jouni Högander wrote: > Currently we have some corner cases where area calculation fails. For > these sel fetch area calculation ends up having update area as y1 = 0, > y2 = 4. Instead of these values safer option is full update. > > One of such for example is

[Intel-gfx] [PATCH v6] drm/i915/display: disable HPD workers before display driver unregister

2022-05-13 Thread Andrzej Hajda
Handling HPD during driver removal is pointless, and can cause different use-after-free/concurrency issues: 1. Setup of deferred fbdev after fbdev unregistration. 2. Access to DP-AUX after DP-AUX removal. Below stacktraces of both cases observed on CI: [272.634530] general protection fault,

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes for selective fetch area calculation (rev5)

2022-05-13 Thread Patchwork
== Series Details == Series: Fixes for selective fetch area calculation (rev5) URL : https://patchwork.freedesktop.org/series/103659/ State : success == Summary == CI Bug Log - changes from CI_DRM_11649 -> Patchwork_103659v5 Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: individualize fences before adding

2022-05-13 Thread Patchwork
== Series Details == Series: drm/i915: individualize fences before adding URL : https://patchwork.freedesktop.org/series/103981/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11649 -> Patchwork_103981v1 Summary ---

[Intel-gfx] [PATCH v5 2/2] drm/i915: Ensure damage clip area is within pipe area

2022-05-13 Thread Jouni Högander
Current update area calculation is not handling situation where e.g. cursor plane is fully or partially outside pipe area. Fix this by checking damage area against pipe_src area using drm_rect_intersect. v2: Set x1 and x2 in damaged_area initialization v3: Move drm_rect_intersect into

[Intel-gfx] [PATCH v5 1/2] drm/i915/psr: Use full update In case of area calculation fails

2022-05-13 Thread Jouni Högander
Currently we have some corner cases where area calculation fails. For these sel fetch area calculation ends up having update area as y1 = 0, y2 = 4. Instead of these values safer option is full update. One of such for example is big fb with offset. We don't have usable offset in

[Intel-gfx] [PATCH v5 0/2] Fixes for selective fetch area calculation

2022-05-13 Thread Jouni Högander
Currently selective fetch area calculation ends up as bogus area in at least following cases: 1. Updated plane is partially or fully outside pipe area 2. Big fb with only part of memory area used for plane These end up as y1 = 0, y2 = 4 or y2 being outside pipe area. This patch set addresses

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/d12+: Disable DMC firmware flip queue handlers (rev3)

2022-05-13 Thread Patchwork
== Series Details == Series: drm/i915/d12+: Disable DMC firmware flip queue handlers (rev3) URL : https://patchwork.freedesktop.org/series/103888/ State : success == Summary == CI Bug Log - changes from CI_DRM_11649 -> Patchwork_103888v3

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/d12+: Disable DMC firmware flip queue handlers (rev3)

2022-05-13 Thread Patchwork
== Series Details == Series: drm/i915/d12+: Disable DMC firmware flip queue handlers (rev3) URL : https://patchwork.freedesktop.org/series/103888/ State : warning == Summary == Error: dim checkpatch failed 50de1ff7239e drm/i915/d12+: Disable DMC firmware flip queue handlers -:164:

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Ensure damage clip area is within pipe area

2022-05-13 Thread Souza, Jose
On Fri, 2022-05-13 at 15:30 +0300, Jouni Högander wrote: > Current update area calculation is not handling situation where > e.g. cursor plane is fully or partially outside pipe area. > > Fix this by checking damage area against pipe_src area using > drm_rect_intersect. > > v2: Set x1 and x2 in

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915/psr: Use full update In case of area calculation fails

2022-05-13 Thread Souza, Jose
On Fri, 2022-05-13 at 15:30 +0300, Jouni Högander wrote: > Currently we have some corner cases where area calculation fails. For > these sel fetch area calculation ends up having update area as y1 = 0, > y2 = 4. Instead of these values safer option is full update. > > One of such for example is

Re: [Intel-gfx] [PATCH v3] uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

2022-05-13 Thread Lionel Landwerlin
On 02/05/2022 17:15, Ramalingam C wrote: Capture the impact of memory region preference list of the objects, on their memory residency and Flat-CCS capability. v2: Fix the Flat-CCS capability of an obj with {lmem, smem} preference list [Thomas] v3: Reworded the doc [Matt]

[Intel-gfx] [PATCH v4 2/2] drm/i915: Ensure damage clip area is within pipe area

2022-05-13 Thread Jouni Högander
Current update area calculation is not handling situation where e.g. cursor plane is fully or partially outside pipe area. Fix this by checking damage area against pipe_src area using drm_rect_intersect. v2: Set x1 and x2 in damaged_area initialization v3: Move drm_rect_intersect into

[Intel-gfx] [PATCH v4 0/2] Fixes for selective fetch area calculation

2022-05-13 Thread Jouni Högander
Currently selective fetch area calculation ends up as bogus area in at least following cases: 1. Updated plane is partially or fully outside pipe area 2. Big fb with only part of memory area used for plane These end up as y1 = 0, y2 = 4 or y2 being outside pipe area. This patch set addresses

[Intel-gfx] [PATCH v4 1/2] drm/i915/psr: Use full update In case of area calculation fails

2022-05-13 Thread Jouni Högander
Currently we have some corner cases where area calculation fails. For these sel fetch area calculation ends up having update area as y1 = 0, y2 = 4. Instead of these values safer option is full update. One of such for example is big fb with offset. We don't have usable offset in

Re: [Intel-gfx] [PATCH] drm/i915/audio: fix audio code enable/disable pipe logging

2022-05-13 Thread Jani Nikula
On Thu, 12 May 2022, Ville Syrjälä wrote: > On Thu, May 12, 2022 at 07:16:38PM +0300, Jani Nikula wrote: >> Need to use pipe_name(pipe) instead of pipe directly. >> >> Fixes: 1f31e35f2e88 ("drm/i915/audio: unify audio codec enable/disable debug >> logging") >> Cc: Ville Syrjälä >>

[Intel-gfx] [PATCH] drm/i915: individualize fences before adding

2022-05-13 Thread Nirmoy Das
_i915_vma_move_to_active() can receive > 1 fence for multiple batch buffer submission so make sure to individualize fences before adding to dma_resv obj Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5614 Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/i915_vma.c | 17

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Enable Tile4 tiling mode (rev3)

2022-05-13 Thread Das, Nirmoy
On 5/13/2022 1:01 PM, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* drm/i915: Enable Tile4 tiling mode (rev3) *URL:* https://patchwork.freedesktop.org/series/103881/ *State:*failure *Details:*

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Enable Tile4 tiling mode (rev3)

2022-05-13 Thread Patchwork
== Series Details == Series: drm/i915: Enable Tile4 tiling mode (rev3) URL : https://patchwork.freedesktop.org/series/103881/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11646_full -> Patchwork_103881v3_full Summary

Re: [Intel-gfx] [PATCH] drm/i915: Fix CFI violation with show_dynamic_id()

2022-05-13 Thread Tvrtko Ursulin
On 12/05/2022 22:17, Nathan Chancellor wrote: When an attribute group is created with sysfs_create_group(), the ->sysfs_ops() callback is set to kobj_sysfs_ops, which sets the ->show() callback to kobj_attr_show(). kobj_attr_show() uses container_of() to get the ->show() callback from the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix CFI violation with show_dynamic_id()

2022-05-13 Thread Patchwork
== Series Details == Series: drm/i915: Fix CFI violation with show_dynamic_id() URL : https://patchwork.freedesktop.org/series/103968/ State : success == Summary == CI Bug Log - changes from CI_DRM_11646_full -> Patchwork_103968v1_full

[Intel-gfx] [PATCH v3] drm/i915/d12+: Disable DMC firmware flip queue handlers

2022-05-13 Thread Imre Deak
Based on a bspec update the DMC firmware's flip queue handling events need to be disabled before enabling DC5/6. i915 doesn't use the flip queue feature atm, so disable it already after loading the firmware. This removes some overhead of the event handler which runs at a 1 kHz frequency. Bspec:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable Tile4 tiling mode (rev3)

2022-05-13 Thread Patchwork
== Series Details == Series: drm/i915: Enable Tile4 tiling mode (rev3) URL : https://patchwork.freedesktop.org/series/103881/ State : success == Summary == CI Bug Log - changes from CI_DRM_11646 -> Patchwork_103881v3 Summary ---

[Intel-gfx] [PATCH i-g-t] tests/core_hotunplug: Check sysfs reads after hotunplug

2022-05-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Leave some sysfs files open and attempt to read from them after hotunplug. Signed-off-by: Tvrtko Ursulin Cc: Ashutosh Dixit --- tests/core_hotunplug.c | 62 ++ 1 file changed, 62 insertions(+) diff --git a/tests/core_hotunplug.c

Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-05-13 Thread Tvrtko Ursulin
On 13/05/2022 06:05, Dixit, Ashutosh wrote: On Thu, 12 May 2022 00:48:08 -0700, Tvrtko Ursulin wrote: Hi Tvrtko, On 12/05/2022 00:15, Dixit, Ashutosh wrote: On Tue, 10 May 2022 03:41:57 -0700, Andrzej Hajda wrote: On 10.05.2022 11:48, Tvrtko Ursulin wrote: On 10/05/2022 10:39, Andrzej

[Intel-gfx] [PATCH v3] drm/i915: Enable Tile4 tiling mode

2022-05-13 Thread Nirmoy Das
From: Bommu Krishnaiah Enable Tile4 tiling mode on platform that supports Tile4 but no TileY like DG2. v3: add a function to find X-tile availability for a platform. v2: disable X-tile for iGPU in fastblit fix checkpath --strict warnings Signed-off-by: Bommu Krishnaiah Co-developed-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix CFI violation with show_dynamic_id()

2022-05-13 Thread Patchwork
== Series Details == Series: drm/i915: Fix CFI violation with show_dynamic_id() URL : https://patchwork.freedesktop.org/series/103968/ State : success == Summary == CI Bug Log - changes from CI_DRM_11646 -> Patchwork_103968v1 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix CFI violation with show_dynamic_id()

2022-05-13 Thread Patchwork
== Series Details == Series: drm/i915: Fix CFI violation with show_dynamic_id() URL : https://patchwork.freedesktop.org/series/103968/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [5.18 regression] drm/i915 BYT rendering broken due to "Remove short-term pins from execbuf, v6" #forregzbot

2022-05-13 Thread Thorsten Leemhuis
TWIMC: this mail is primarily send for documentation purposes and for regzbot, my Linux kernel regression tracking bot. These mails usually contain '#forregzbot' in the subject, to make them easy to spot and filter. On 09.05.22 09:01, Thorsten Leemhuis wrote: > [TLDR: I'm adding this regression

Re: [Intel-gfx] [PATCH v2] drm/i915/d12+: Disable DMC firmware flip queue handlers

2022-05-13 Thread Imre Deak
On Thu, May 12, 2022 at 03:37:14PM -0700, Lucas De Marchi wrote: > On Thu, May 12, 2022 at 10:47:46PM +0300, Imre Deak wrote: > > On Thu, May 12, 2022 at 10:56:11AM -0700, Lucas De Marchi wrote: > > > On Thu, May 12, 2022 at 12:37:05PM +0300, Imre Deak wrote: > > > > Based on a bspec update the

[Intel-gfx] [CI] drm/i915: Fix CFI violation with show_dynamic_id()

2022-05-13 Thread Tvrtko Ursulin
From: Nathan Chancellor When an attribute group is created with sysfs_create_group(), the ->sysfs_ops() callback is set to kobj_sysfs_ops, which sets the ->show() callback to kobj_attr_show(). kobj_attr_show() uses container_of() to get the ->show() callback from the attribute it was passed,

Re: [Intel-gfx] [PATCH] drm/i915: Enable Tile4 tiling mode

2022-05-13 Thread Das, Nirmoy
On 5/13/2022 7:47 AM, Zbigniew Kempczyński wrote: On Thu, May 12, 2022 at 03:26:00PM +0200, Nirmoy Das wrote: From: Bommu Krishnaiah Enable Tile4 tiling mode on platform that supports Tile4 but no TileY like DG2. v2: disable X-tile for iGPU in fastblit fix checkpath --strict warnings

[Intel-gfx] [PULL] drm-misc-fixes

2022-05-13 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week drm-misc-fixes. drm-misc-next-fixes is empty at the moment, so there won't be a PR for it this week. Thanks! Maxime drm-misc-fixes-2022-05-13: Multiple fixes to fbdev to address a regression at unregistration, an iommu detection improvement for nouveau, a

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes (rev6)

2022-05-13 Thread Dixit, Ashutosh
On Thu, 12 May 2022 23:58:55 -0700, Patchwork wrote: > > Patch Details > > Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev6) > URL: https://patchwork.freedesktop.org/series/102665/ > State: failure > Details: >