[Intel-gfx] ✓ Fi.CI.IGT: success for Don't use stolen memory or BAR mappings for ring buffers (rev2)

2023-02-16 Thread Patchwork
== Series Details == Series: Don't use stolen memory or BAR mappings for ring buffers (rev2) URL : https://patchwork.freedesktop.org/series/114080/ State : success == Summary == CI Bug Log - changes from CI_DRM_12751_full -> Patchwork_114080v2_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()

2023-02-16 Thread Patchwork
== Series Details == Series: drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini() URL : https://patchwork.freedesktop.org/series/114106/ State : success == Summary == CI Bug Log - changes from CI_DRM_12751_full -> Patchwork_114106v1_full

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Pimp encoder ddc_pin/aux_ch debug messages

2023-02-16 Thread Nautiyal, Ankit K
On 2/17/2023 4:43 AM, Ville Syrjala wrote: From: Ville Syrjälä Use encoer->name rather than port_name() in the debug messages typo : encoder LGTM. encoder->name has sufficient information. Reviewed-by: Ankit Nautiyal so that they actually make more sense. Signed-off-by: Ville Syrjälä

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Split map_aux_ch() into per-platform arrays

2023-02-16 Thread Ville Syrjälä
On Fri, Feb 17, 2023 at 01:13:12AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > The big switch+if statement mess in map_aux_ch() is > illegible. Split up into cleaner per-platform arrays > like we already have for the gmbus pins. > > To save space in the arrays we shift away the lower

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Restructure intel_bios_port_aux_ch()

2023-02-16 Thread Nautiyal, Ankit K
Patch looks good to me. There are a few nitpicks, typos mentioned inline. On 2/17/2023 4:43 AM, Ville Syrjala wrote: From: Ville Syrjälä Restructure intel_bios_port_aux_ch() to resemble the ddc_pin counterpart, where the intel_bios.c stuff only deals with the child device definition, and the

Re: [Intel-gfx] [PATCH v3 05/15] kvm/vfio: Accept vfio device file from userspace

2023-02-16 Thread Liu, Yi L
> From: Liu, Yi L > Sent: Friday, February 17, 2023 1:34 PM > > > From: Jason Gunthorpe > > Sent: Wednesday, February 15, 2023 8:18 AM > > > > On Tue, Feb 14, 2023 at 04:42:35PM -0700, Alex Williamson wrote: > > > > > A device file opened through a group could be passed through this > > >

Re: [Intel-gfx] [PATCH v3 05/15] kvm/vfio: Accept vfio device file from userspace

2023-02-16 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Wednesday, February 15, 2023 8:18 AM > > On Tue, Feb 14, 2023 at 04:42:35PM -0700, Alex Williamson wrote: > > > A device file opened through a group could be passed through this > > interface though, right? > > Yes, I think so > > > Do we just chalk that up to

[Intel-gfx] ✗ Fi.CI.BAT: failure for More error capture improvements (rev2)

2023-02-16 Thread Patchwork
== Series Details == Series: More error capture improvements (rev2) URL : https://patchwork.freedesktop.org/series/113628/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12754 -> Patchwork_113628v2 Summary ---

Re: [Intel-gfx] [PATCH v5 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-02-16 Thread Teres Alexis, Alan Previn
On Tue, 2023-02-14 at 13:38 -0800, Teres Alexis, Alan Previn wrote: > Add MTL's function for ARB session creation using PXP firmware > version 4.3 ABI structure format. > > Also add MTL's function for ARB session invalidation but this > reuses PXP firmware version 4.2 ABI structure format. > >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More error capture improvements (rev2)

2023-02-16 Thread Patchwork
== Series Details == Series: More error capture improvements (rev2) URL : https://patchwork.freedesktop.org/series/113628/ State : warning == Summary == Error: dim checkpatch failed ee9d337e5e7f drm/i915/guc: Fix missing ecodes -:15: WARNING:REPEATED_WORD: Possible repeated word: 'if' #15:

[Intel-gfx] [PATCH v2 2/3] drm/i915/guc: Clean up of register capture search

2023-02-16 Thread John . C . Harrison
From: John Harrison The comparison in the search for a matching register capture node was not the most readable. It was also assuming that a zero GuC id means invalid, which it does not. So remove one invalid term, one redundant term and re-format to keep each term on a single line, and only one

[Intel-gfx] [PATCH v2 3/3] drm/i915: Include timeline seqno in error capture

2023-02-16 Thread John . C . Harrison
From: John Harrison The seqno value actually written out to memory is no longer in the regular HWSP. Instead, it is now in its own private timeline buffer. Thus, it is no longer visible in an error capture. So, explicitly read the value and include that in the capture. Signed-off-by: John

[Intel-gfx] [PATCH v2 1/3] drm/i915/guc: Fix missing ecodes

2023-02-16 Thread John . C . Harrison
From: John Harrison Error captures are tagged with an 'ecode'. This is a pseduo-unique magic number that is meant to distinguish similar seeming bugs with different underlying signatures. It is a combination of two ring state registers. Unfortunately, the register state being used is only valid

[Intel-gfx] [PATCH v2 0/3] More error capture improvements

2023-02-16 Thread John . C . Harrison
From: John Harrison Ecodes got lost with the switch to GuC based register lists. Put them back. Seqno values got lost with the switch to per context timelines. Put those back too. v2: Rework the timeline patch to just read the single seqno value rather than copying the entire object.

Re: [Intel-gfx] [PATCH v2 5/9] drm/i915/perf: Fail modprobe if i915_perf_init fails on OOM

2023-02-16 Thread Dixit, Ashutosh
On Thu, 16 Feb 2023 16:58:46 -0800, Umesh Nerlige Ramappa wrote: > > i915_perf_init can fail due to OOM. Fail driver init if i915_perf_init > fails. > > v2: (Jani) > - Reorder patch in the series Jani seemed ok with this: that a drm_err will get lost in the dmesg deluge on OOM so it's better to

[Intel-gfx] ✓ Fi.CI.BAT: success for Add OAM support for MTL (rev2)

2023-02-16 Thread Patchwork
== Series Details == Series: Add OAM support for MTL (rev2) URL : https://patchwork.freedesktop.org/series/114033/ State : success == Summary == CI Bug Log - changes from CI_DRM_12754 -> Patchwork_114033v2 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation

2023-02-16 Thread Zhenyu Wang
On 2023.02.14 20:45:33 -0800, Randy Dunlap wrote: > Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT) > into a list of other symbols that do have a dependency (on DRM_I915) > breaks the driver menu presentation in 'make *config'. > I'm not sure what's the actual failure in

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add OAM support for MTL (rev2)

2023-02-16 Thread Patchwork
== Series Details == Series: Add OAM support for MTL (rev2) URL : https://patchwork.freedesktop.org/series/114033/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/atomic-helpers: remove legacy_cursor_update hacks (rev3)

2023-02-16 Thread Patchwork
== Series Details == Series: drm/atomic-helpers: remove legacy_cursor_update hacks (rev3) URL : https://patchwork.freedesktop.org/series/102028/ State : success == Summary == CI Bug Log - changes from CI_DRM_12748_full -> Patchwork_102028v3_full

Re: [Intel-gfx] [PATCH v2 3/9] drm/i915/perf: Validate OA sseu config outside switch

2023-02-16 Thread Dixit, Ashutosh
On Thu, 16 Feb 2023 16:58:44 -0800, Umesh Nerlige Ramappa wrote: > > Once OA supports media engine class:instance, the engine can only be > validated outside the switch since class and instance parameters are > separate entities. Since OA sseu config depends on engine > class:instance, validate OA

[Intel-gfx] [PATCH v2 9/9] drm/i915/perf: Add support for OA media units

2023-02-16 Thread Umesh Nerlige Ramappa
MTL introduces additional OA units dedicated to media use cases. Add support for programming these OA units by passing the media engine class and instance parameters. UMD specific changes for GPUvis support: https://patchwork.freedesktop.org/patch/522827/?series=114023

[Intel-gfx] [PATCH v2 8/9] drm/i915/perf: Add engine class instance parameters to perf

2023-02-16 Thread Umesh Nerlige Ramappa
Current implementation of perf defaults to render and configures the default OAG unit. Since there are more OA units on newer hardware, allow user to pass engine class and instance to program specific OA units. UMD specific changes for GPUvis support:

[Intel-gfx] [PATCH v2 2/9] drm/i915/perf: Add helper to check supported OA engines

2023-02-16 Thread Umesh Nerlige Ramappa
With an intention to add more engines that are supported by OA, add helper to check for supported OA engines. v2: (Ashutosh) - Update commit message - Drop virtual engine check since we support only one render engine Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Ashutosh Dixit ---

[Intel-gfx] [PATCH v2 5/9] drm/i915/perf: Fail modprobe if i915_perf_init fails on OOM

2023-02-16 Thread Umesh Nerlige Ramappa
i915_perf_init can fail due to OOM. Fail driver init if i915_perf_init fails. v2: (Jani) - Reorder patch in the series Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_driver.c | 4 +++- drivers/gpu/drm/i915/i915_perf.c | 8 ++-- drivers/gpu/drm/i915/i915_perf.h | 2

[Intel-gfx] [PATCH v2 6/9] drm/i915/perf: Parse 64bit report header formats correctly

2023-02-16 Thread Umesh Nerlige Ramappa
Now that OA formats come in flavor of 64 bit reports, the report header has 64 bit report-id, timestamp, context-id and gpu-ticks fields. When filtering these reports, use the right width for these fields. Note that upper dword of context id is reserved, so squash lower dword only.

[Intel-gfx] [PATCH v2 7/9] drm/i915/perf: Handle non-power-of-2 reports

2023-02-16 Thread Umesh Nerlige Ramappa
Some of the newer OA formats are not powers of 2. For those formats, adjust the hw_tail accordingly when checking for new reports. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_perf.c | 50 ++-- 1 file changed, 28 insertions(+), 22 deletions(-)

[Intel-gfx] [PATCH v2 1/9] drm/i915/perf: Drop wakeref on GuC RC error

2023-02-16 Thread Umesh Nerlige Ramappa
From: Chris Wilson If we fail to adjust the GuC run-control on opening the perf stream, make sure we unwind the wakeref just taken. v2: Retain old goto label names (Ashutosh) Fixes: 01e742746785 ("drm/i915/guc: Support OA when Wa_16011777198 is enabled") Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH v2 0/9] Add OAM support for MTL

2023-02-16 Thread Umesh Nerlige Ramappa
The OAM unit captures OA reports specific to the media engines. Add support to program the OAM unit on media tile on MTL. The OAM unit is selected by passing the class:instance of a media engine to perf parameters. Corresponding UMD changes are posted to the igt-dev repo as part of supporting the

[Intel-gfx] [PATCH v2 3/9] drm/i915/perf: Validate OA sseu config outside switch

2023-02-16 Thread Umesh Nerlige Ramappa
Once OA supports media engine class:instance, the engine can only be validated outside the switch since class and instance parameters are separate entities. Since OA sseu config depends on engine class:instance, validate OA sseu config outside the switch. v2: (Ashutosh) - Clarify commit message -

[Intel-gfx] [PATCH v2 4/9] drm/i915/perf: Group engines into respective OA groups

2023-02-16 Thread Umesh Nerlige Ramappa
Now that we may have multiple OA units in a single GT as well as on separate GTs, create an engine group that maps to a single OA unit. v2: (Jani) - Drop warning on ENOMEM - Reorder patch in the series Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/intel_engine_types.h | 4

Re: [Intel-gfx] [PATCH 2/9] drm/i915/perf: Add helper to check supported OA engines

2023-02-16 Thread Umesh Nerlige Ramappa
On Thu, Feb 16, 2023 at 09:30:57AM -0800, Umesh Nerlige Ramappa wrote: On Wed, Feb 15, 2023 at 07:58:02PM -0800, Dixit, Ashutosh wrote: On Tue, 14 Feb 2023 16:54:12 -0800, Umesh Nerlige Ramappa wrote: Add helper to check for supported OA engines. Signed-off-by: Umesh Nerlige Ramappa ---

[Intel-gfx] ✓ Fi.CI.IGT: success for Waitboost drm syncobj waits (rev3)

2023-02-16 Thread Patchwork
== Series Details == Series: Waitboost drm syncobj waits (rev3) URL : https://patchwork.freedesktop.org/series/113846/ State : success == Summary == CI Bug Log - changes from CI_DRM_12748_full -> Patchwork_113846v3_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Restructure intel_bios_port_aux_ch()

2023-02-16 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Restructure intel_bios_port_aux_ch() URL : https://patchwork.freedesktop.org/series/114120/ State : success == Summary == CI Bug Log - changes from CI_DRM_12753 -> Patchwork_114120v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915: Restructure intel_bios_port_aux_ch()

2023-02-16 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Restructure intel_bios_port_aux_ch() URL : https://patchwork.freedesktop.org/series/114120/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Consolidate TLB invalidation flow (rev4)

2023-02-16 Thread Patchwork
== Series Details == Series: drm/i915: Consolidate TLB invalidation flow (rev4) URL : https://patchwork.freedesktop.org/series/113563/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12748_full -> Patchwork_113563v4_full

Re: [Intel-gfx] [PATCH 5/9] drm/i915/perf: Group engines into respective OA groups

2023-02-16 Thread Umesh Nerlige Ramappa
On Thu, Feb 16, 2023 at 12:55:59PM -0800, Umesh Nerlige Ramappa wrote: On Thu, Feb 16, 2023 at 08:10:29PM +0200, Jani Nikula wrote: On Thu, 16 Feb 2023, "Dixit, Ashutosh" wrote: On Thu, 16 Feb 2023 02:51:34 -0800, Jani Nikula wrote: +static int oa_init_gt(struct intel_gt *gt) +{ +

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/displayid: use primary use case to figure out non-desktop

2023-02-16 Thread Patchwork
== Series Details == Series: drm/displayid: use primary use case to figure out non-desktop URL : https://patchwork.freedesktop.org/series/114116/ State : success == Summary == CI Bug Log - changes from CI_DRM_12753 -> Patchwork_114116v1

Re: [Intel-gfx] [PATCH 5/9] drm/i915/perf: Group engines into respective OA groups

2023-02-16 Thread Umesh Nerlige Ramappa
On Thu, Feb 16, 2023 at 12:51:34PM +0200, Jani Nikula wrote: On Tue, 14 Feb 2023, Umesh Nerlige Ramappa wrote: Now that we may have multiple OA units in a single GT as well as on separate GTs, create an engine group that maps to a single OA unit. Signed-off-by: Umesh Nerlige Ramappa ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/displayid: use primary use case to figure out non-desktop

2023-02-16 Thread Patchwork
== Series Details == Series: drm/displayid: use primary use case to figure out non-desktop URL : https://patchwork.freedesktop.org/series/114116/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH 4/4] drm/i915: Split map_aux_ch() into per-platform arrays

2023-02-16 Thread Ville Syrjala
From: Ville Syrjälä The big switch+if statement mess in map_aux_ch() is illegible. Split up into cleaner per-platform arrays like we already have for the gmbus pins. To save space in the arrays we shift away the lower nibble of the VBT AUX CH byte since it's always zero anyway. Extra care must

[Intel-gfx] [PATCH 3/4] drm/i915: Fix platform default aux ch for skl

2023-02-16 Thread Ville Syrjala
From: Ville Syrjälä SKL/derivatives have DDI E but no AUX E, so we need to pick another aux ch as the platform default. DDI E is more or less the other half of DDI A, so we pick AUX A. In all other cases we should have a corresponding aux ch for each DDI. Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH 2/4] drm/i915: Pimp encoder ddc_pin/aux_ch debug messages

2023-02-16 Thread Ville Syrjala
From: Ville Syrjälä Use encoer->name rather than port_name() in the debug messages so that they actually make more sense. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 10 ++ drivers/gpu/drm/i915/display/intel_hdmi.c | 10 ++ 2 files changed,

[Intel-gfx] [PATCH 1/4] drm/i915: Restructure intel_bios_port_aux_ch()

2023-02-16 Thread Ville Syrjala
From: Ville Syrjälä Restructure intel_bios_port_aux_ch() to resemble the ddc_pin counterpart, where the intel_bios.c stuff only deals with the child device definition, and the platform default will come from elsewhere. This requires the introduction if AUX_CH_NONE as the value 0 is already

Re: [Intel-gfx] [PATCH 3/9] drm/i915/perf: Validate OA sseu config outside switch

2023-02-16 Thread Umesh Nerlige Ramappa
On Wed, Feb 15, 2023 at 09:36:50PM -0800, Dixit, Ashutosh wrote: On Wed, 15 Feb 2023 21:08:43 -0800, Dixit, Ashutosh wrote: On Tue, 14 Feb 2023 16:54:13 -0800, Umesh Nerlige Ramappa wrote: > > Validate the OA sseu config after all params are parsed. Commit messages for all patches need to

Re: [Intel-gfx] [PATCH 0/2] PL1 power limit fixes for ATSM

2023-02-16 Thread Rodrigo Vivi
On Thu, Feb 16, 2023 at 08:49:42AM -0800, Ashutosh Dixit wrote: > Previous PL1 power limit implementation assumed that the PL1 limit is > always enabled in HW. However we now find this not to be the case on ATSM > where the PL1 limit is disabled at power up. This requires changes in the > previous

Re: [Intel-gfx] [PATCH 9/9] drm/i915/perf: Add support for OA media units

2023-02-16 Thread Dixit, Ashutosh
On Thu, 16 Feb 2023 13:07:25 -0800, Umesh Nerlige Ramappa wrote: > > On Thu, Feb 16, 2023 at 09:27:47AM -0800, Dixit, Ashutosh wrote: > > On Tue, 14 Feb 2023 16:54:19 -0800, Umesh Nerlige Ramappa wrote: > >> > >> MTL introduces additional OA units dedicated to media use cases. Add > >> support for

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make kobj_type structures constant (rev2)

2023-02-16 Thread Patchwork
== Series Details == Series: drm/i915: Make kobj_type structures constant (rev2) URL : https://patchwork.freedesktop.org/series/114101/ State : success == Summary == CI Bug Log - changes from CI_DRM_12751 -> Patchwork_114101v2 Summary

Re: [Intel-gfx] [PATCH 9/9] drm/i915/perf: Add support for OA media units

2023-02-16 Thread Umesh Nerlige Ramappa
On Thu, Feb 16, 2023 at 09:27:47AM -0800, Dixit, Ashutosh wrote: On Tue, 14 Feb 2023 16:54:19 -0800, Umesh Nerlige Ramappa wrote: MTL introduces additional OA units dedicated to media use cases. Add support for programming these OA units. This patch is several patches squashed into a single

Re: [Intel-gfx] [PATCH 5/9] drm/i915/perf: Group engines into respective OA groups

2023-02-16 Thread Umesh Nerlige Ramappa
On Thu, Feb 16, 2023 at 08:10:29PM +0200, Jani Nikula wrote: On Thu, 16 Feb 2023, "Dixit, Ashutosh" wrote: On Thu, 16 Feb 2023 02:51:34 -0800, Jani Nikula wrote: > +static int oa_init_gt(struct intel_gt *gt) > +{ > + u32 num_groups = __num_perf_groups_per_gt(gt); > + struct intel_engine_cs

[Intel-gfx] ✓ Fi.CI.BAT: success for PL1 power limit fixes for ATSM (rev2)

2023-02-16 Thread Patchwork
== Series Details == Series: PL1 power limit fixes for ATSM (rev2) URL : https://patchwork.freedesktop.org/series/113984/ State : success == Summary == CI Bug Log - changes from CI_DRM_12751 -> Patchwork_113984v2 Summary ---

[Intel-gfx] [PATCH 4/4] drm/edid: update non-desktop use also from DisplayID

2023-02-16 Thread Jani Nikula
Use the DisplayID 2.0 primary use case information to deduce whether this is a head-mounted display, and should not be used for desktop. Cc: Iaroslav Boliukin Cc: Dmitry Osipenko Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 25 + 1 file changed, 25

[Intel-gfx] [PATCH 3/4] drm/displayid: provide access to DisplayID version and primary use case

2023-02-16 Thread Jani Nikula
The DisplayID structure version and primary use case are stored in the DisplayID Base Section. We should be checking them in a number of places when parsing the DisplayID blocks. Currently, we completely ignore the primary use case, and just look at the block tags without cross-checking against

[Intel-gfx] [PATCH 2/4] drm/displayid: return struct displayid_header from validate_displayid()

2023-02-16 Thread Jani Nikula
Avoid figuring out the header pointer multiple times. Cc: Iaroslav Boliukin Cc: Dmitry Osipenko Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_displayid.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_displayid.c

[Intel-gfx] [PATCH 1/4] drm/displayid: add displayid_get_header() and check bounds better

2023-02-16 Thread Jani Nikula
Add a helper to get a pointer to struct displayid_header. To be pedantic, add buffer overflow checks to not touch the base if that itself would overflow. Cc: Iaroslav Boliukin Cc: Dmitry Osipenko Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_displayid.c | 17 - 1 file

[Intel-gfx] [PATCH 0/4] drm/displayid: use primary use case to figure out non-desktop

2023-02-16 Thread Jani Nikula
Mostly this is prep work and plumbing for easier use of displayid structure version and primary use case for parsing the displayid blocks, but it can be nicely used for figuring out non-desktop too. Completely untested. :) BR, Jani. Cc: Iaroslav Boliukin Cc: Dmitry Osipenko Jani Nikula (4):

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/3] drm/i915/power: move dc state members to struct i915_power_domains

2023-02-16 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915/power: move dc state members to struct i915_power_domains URL : https://patchwork.freedesktop.org/series/114112/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12751 -> Patchwork_114112v1

Re: [Intel-gfx] [PATCH 0/1] drm: Add a gpu page-table walker

2023-02-16 Thread Daniel Vetter
On Thu, Feb 16, 2023 at 05:27:28PM +0100, Thomas Hellström wrote: > A slightly unusual cover letter for a single patch. > > The page table walker is currently used by the xe driver only, > but the code is generic so we can be good citizens and add it to drm > as a helper, for possible use by

Re: [Intel-gfx] [PATCH 3/3] drm/i915/hwmon: Expose power1_max_enable

2023-02-16 Thread Rodrigo Vivi
On Thu, Feb 16, 2023 at 11:25:50AM -0800, Guenter Roeck wrote: > On 2/16/23 10:57, Rodrigo Vivi wrote: > > On Tue, Feb 14, 2023 at 07:11:16PM -0800, Dixit, Ashutosh wrote: > > > On Mon, 13 Feb 2023 22:16:44 -0800, Guenter Roeck wrote: > > > > > > > > > > Hi Guenter, > > > > > > > On 2/13/23

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/dmc: allocate dmc structure dynamically

2023-02-16 Thread Imre Deak
On Thu, Feb 16, 2023 at 06:17:39PM +0200, Jani Nikula wrote: > sizeof(struct intel_dmc) > 1024 bytes, allocated on all platforms as > part of struct drm_i915_private, whether they have DMC or not. > > Allocate struct intel_dmc dynamically, and hide all the dmc details > behind an opaque pointer

Re: [Intel-gfx] [PATCH] drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()

2023-02-16 Thread Daniel Vetter
On Thu, Feb 16, 2023 at 03:06:20PM +0100, Thomas Zimmermann wrote: > Move drm_fb_helper_unprepare() from drm_fb_helper_fini() into the > calling fbdev implementation. Avoids a possible stale mutex with > generic fbdev code. > > As indicated by its name, drm_fb_helper_prepare() prepares struct >

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-16 Thread Rob Clark
On Thu, Feb 16, 2023 at 10:20 AM Rodrigo Vivi wrote: > > On Tue, Feb 14, 2023 at 11:14:00AM -0800, Rob Clark wrote: > > On Fri, Feb 10, 2023 at 5:07 AM Tvrtko Ursulin > > wrote: > > > > > > From: Tvrtko Ursulin > > > > > > In i915 we have this concept of "wait boosting" where we give a priority

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/i915/power: move dc state members to struct i915_power_domains

2023-02-16 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915/power: move dc state members to struct i915_power_domains URL : https://patchwork.freedesktop.org/series/114112/ State : warning == Summary == Error: dim checkpatch failed 8986ed2489ba drm/i915/power: move dc state members

Re: [Intel-gfx] [PATCH i-g-t v4] tests: Exercise remote request vs barrier handling race

2023-02-16 Thread Kamil Konieczny
Hi Janusz, On 2023-02-15 at 10:19:52 +0100, Janusz Krzysztofik wrote: > Users reported oopses on list corruptions when using i915 perf with a > number of concurrently running graphics applications. That indicates we > are currently missing some important tests for such scenarios. Cover > that

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Add a gpu page-table walker

2023-02-16 Thread Patchwork
== Series Details == Series: drm: Add a gpu page-table walker URL : https://patchwork.freedesktop.org/series/114109/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12751 -> Patchwork_114109v1 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH 3/3] drm/i915/hwmon: Expose power1_max_enable

2023-02-16 Thread Guenter Roeck
On 2/16/23 10:57, Rodrigo Vivi wrote: On Tue, Feb 14, 2023 at 07:11:16PM -0800, Dixit, Ashutosh wrote: On Mon, 13 Feb 2023 22:16:44 -0800, Guenter Roeck wrote: Hi Guenter, On 2/13/23 21:33, Ashutosh Dixit wrote: On ATSM the PL1 power limit is disabled at power up. The previous uapi

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Add a gpu page-table walker

2023-02-16 Thread Patchwork
== Series Details == Series: drm: Add a gpu page-table walker URL : https://patchwork.freedesktop.org/series/114109/ State : warning == Summary == Error: dim checkpatch failed 8e7a3eb796b4 drm: Add a gpu page-table walker helper Traceback (most recent call last): File

[Intel-gfx] ✓ Fi.CI.BAT: success for Don't use stolen memory or BAR mappings for ring buffers (rev2)

2023-02-16 Thread Patchwork
== Series Details == Series: Don't use stolen memory or BAR mappings for ring buffers (rev2) URL : https://patchwork.freedesktop.org/series/114080/ State : success == Summary == CI Bug Log - changes from CI_DRM_12751 -> Patchwork_114080v2

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/3] drm/i915: Use encoder->devdata more (rev2)

2023-02-16 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Use encoder->devdata more (rev2) URL : https://patchwork.freedesktop.org/series/114029/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12746_full -> Patchwork_114029v2_full

Re: [Intel-gfx] [PATCH 3/3] drm/i915/hwmon: Expose power1_max_enable

2023-02-16 Thread Rodrigo Vivi
On Tue, Feb 14, 2023 at 07:11:16PM -0800, Dixit, Ashutosh wrote: > On Mon, 13 Feb 2023 22:16:44 -0800, Guenter Roeck wrote: > > > > Hi Guenter, > > > On 2/13/23 21:33, Ashutosh Dixit wrote: > > > On ATSM the PL1 power limit is disabled at power up. The previous uapi > > > assumed that the PL1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()

2023-02-16 Thread Patchwork
== Series Details == Series: drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini() URL : https://patchwork.freedesktop.org/series/114106/ State : success == Summary == CI Bug Log - changes from CI_DRM_12751 -> Patchwork_114106v1

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-16 Thread Rodrigo Vivi
On Tue, Feb 14, 2023 at 11:14:00AM -0800, Rob Clark wrote: > On Fri, Feb 10, 2023 at 5:07 AM Tvrtko Ursulin > wrote: > > > > From: Tvrtko Ursulin > > > > In i915 we have this concept of "wait boosting" where we give a priority > > boost > > for instance to fences which are actively waited upon

Re: [Intel-gfx] [PATCH 5/9] drm/i915/perf: Group engines into respective OA groups

2023-02-16 Thread Jani Nikula
On Thu, 16 Feb 2023, "Dixit, Ashutosh" wrote: > On Thu, 16 Feb 2023 02:51:34 -0800, Jani Nikula wrote: >> >> > +static int oa_init_gt(struct intel_gt *gt) >> > +{ >> > + u32 num_groups = __num_perf_groups_per_gt(gt); >> > + struct intel_engine_cs *engine; >> > + struct i915_perf_group *g; >> >

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Don't leak the DPT if drm_framebuffer_init() fails

2023-02-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Don't leak the DPT if drm_framebuffer_init() fails URL : https://patchwork.freedesktop.org/series/114069/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12745_full -> Patchwork_114069v1_full

Re: [Intel-gfx] [PATCH 5/9] drm/i915/perf: Group engines into respective OA groups

2023-02-16 Thread Dixit, Ashutosh
On Thu, 16 Feb 2023 02:51:34 -0800, Jani Nikula wrote: > > > +static int oa_init_gt(struct intel_gt *gt) > > +{ > > + u32 num_groups = __num_perf_groups_per_gt(gt); > > + struct intel_engine_cs *engine; > > + struct i915_perf_group *g; > > + intel_engine_mask_t tmp; > > + > > + g =

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/power: move dc state members to struct i915_power_domains

2023-02-16 Thread Imre Deak
On Thu, Feb 16, 2023 at 06:17:37PM +0200, Jani Nikula wrote: > There's only one reference to the struct intel_dmc members dc_state, > target_dc_state, and allowed_dc_mask within intel_dmc.c, begging the > question why they are under struct intel_dmc to begin with. > > Moreover, the only

Re: [Intel-gfx] [PATCH v2 20/20] jump_label: RFC - tolerate toggled state

2023-02-16 Thread Jason Baron
On 1/17/23 6:57 AM, Peter Zijlstra wrote: On Fri, Jan 13, 2023 at 12:30:16PM -0700, Jim Cromie wrote: __jump_label_patch currently will "crash the box" if it finds a jump_entry not as expected. ISTM this overly harsh; it doesn't distinguish between "alternate/opposite" state, and truly

Re: [Intel-gfx] [PATCH 3/9] drm/i915/perf: Validate OA sseu config outside switch

2023-02-16 Thread Umesh Nerlige Ramappa
On Thu, Feb 16, 2023 at 08:31:21AM -0800, Dixit, Ashutosh wrote: On Wed, 15 Feb 2023 21:36:50 -0800, Dixit, Ashutosh wrote: On Wed, 15 Feb 2023 21:08:43 -0800, Dixit, Ashutosh wrote: > > On Tue, 14 Feb 2023 16:54:13 -0800, Umesh Nerlige Ramappa wrote: > > > > Validate the OA sseu config after

Re: [Intel-gfx] [PATCH 2/9] drm/i915/perf: Add helper to check supported OA engines

2023-02-16 Thread Umesh Nerlige Ramappa
On Wed, Feb 15, 2023 at 07:58:02PM -0800, Dixit, Ashutosh wrote: On Tue, 14 Feb 2023 16:54:12 -0800, Umesh Nerlige Ramappa wrote: Add helper to check for supported OA engines. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_perf.c | 19 --- 1 file changed,

Re: [Intel-gfx] [PATCH 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

2023-02-16 Thread Ira Weiny
Zhao Liu wrote: > On Tue, Feb 14, 2023 at 08:25:08PM -0800, Ira Weiny wrote: > > Date: Tue, 14 Feb 2023 20:25:08 -0800 > > From: Ira Weiny > > Subject: Re: [PATCH 0/9] drm/i915: Replace kmap_atomic() with > > kmap_local_page() > > > > Zhao Liu wrote: > > > From: Zhao Liu > > > > > > The use

Re: [Intel-gfx] [PATCH 9/9] drm/i915/perf: Add support for OA media units

2023-02-16 Thread Dixit, Ashutosh
On Tue, 14 Feb 2023 16:54:19 -0800, Umesh Nerlige Ramappa wrote: > > MTL introduces additional OA units dedicated to media use cases. Add > support for programming these OA units. This patch is several patches squashed into a single patch. Sorry for creating addition work but can we please split

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Make kobj_type structures constant

2023-02-16 Thread Patchwork
== Series Details == Series: drm/i915: Make kobj_type structures constant URL : https://patchwork.freedesktop.org/series/114101/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12750 -> Patchwork_114101v1 Summary ---

[Intel-gfx] [PATCH 2/2] drm/i915/hwmon: Enable PL1 limit when writing limit value to HW

2023-02-16 Thread Ashutosh Dixit
Previous documentation suggested that the PL1 power limit is always enabled in HW. However we now find this not to be the case on some platforms (such as ATSM). Therefore enable the PL1 power limit (by setting the enable bit) when writing the PL1 limit value to HW. Bspec: 51864 Signed-off-by:

[Intel-gfx] [PATCH 1/2] drm/i915/hwmon: Replace hwm_field_scale_and_write with hwm_power_max_write

2023-02-16 Thread Ashutosh Dixit
hwm_field_scale_and_write has a single caller hwm_power_write and is specific to hwm_power_write but makes it appear that it is a general function which can have multiple callers. Replace the function with hwm_power_max_write which is specific to hwm_power_write and use that in future patches

[Intel-gfx] [PATCH 0/2] PL1 power limit fixes for ATSM

2023-02-16 Thread Ashutosh Dixit
Previous PL1 power limit implementation assumed that the PL1 limit is always enabled in HW. However we now find this not to be the case on ATSM where the PL1 limit is disabled at power up. This requires changes in the previous PL1 limit implementation. v2: Dropping Patch 3 (since it is NAK'd by

[Intel-gfx] [linux-next:master] BUILD REGRESSION 509583475828c4fd86897113f78315c1431edcc3

2023-02-16 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 509583475828c4fd86897113f78315c1431edcc3 Add linux-next specific files for 20230216 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202302061911.c7xvhx9v-...@intel.com https

Re: [Intel-gfx] [PATCH] drm/i915/quirks: Add inverted backlight quirk for HP 14-r206nv

2023-02-16 Thread Jani Nikula
On Wed, 01 Feb 2023, Jani Nikula wrote: > On Wed, 01 Feb 2023, Mavroudis Chatzilaridis wrote: >> This laptop uses inverted backlight PWM. Thus, without this quirk, >> backlight brightness decreases as the brightness value increases and >> vice versa. >> >> Signed-off-by: Mavroudis Chatzilaridis

Re: [Intel-gfx] [PATCH 3/9] drm/i915/perf: Validate OA sseu config outside switch

2023-02-16 Thread Dixit, Ashutosh
On Wed, 15 Feb 2023 21:36:50 -0800, Dixit, Ashutosh wrote: > > On Wed, 15 Feb 2023 21:08:43 -0800, Dixit, Ashutosh wrote: > > > > On Tue, 14 Feb 2023 16:54:13 -0800, Umesh Nerlige Ramappa wrote: > > > > > > Validate the OA sseu config after all params are parsed. > > > > Commit messages for all

[Intel-gfx] [PATCH v2 3/3] drm/i915/dmc: allocate dmc structure dynamically

2023-02-16 Thread Jani Nikula
sizeof(struct intel_dmc) > 1024 bytes, allocated on all platforms as part of struct drm_i915_private, whether they have DMC or not. Allocate struct intel_dmc dynamically, and hide all the dmc details behind an opaque pointer in intel_dmc.c. Care must be taken to take into account all cases: DMC

[Intel-gfx] [PATCH v2 2/3] drm/i915/dmc: add i915_to_dmc() and dmc->i915 and use them

2023-02-16 Thread Jani Nikula
Start preparing for dynamically allocated struct intel_dmc by adding i915_to_dmc() and dmc->i915, and using them. Cc: Imre Deak Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dmc.c | 90 ++-- drivers/gpu/drm/i915/display/intel_dmc.h | 1 + 2 files

[Intel-gfx] [PATCH v2 1/3] drm/i915/power: move dc state members to struct i915_power_domains

2023-02-16 Thread Jani Nikula
There's only one reference to the struct intel_dmc members dc_state, target_dc_state, and allowed_dc_mask within intel_dmc.c, begging the question why they are under struct intel_dmc to begin with. Moreover, the only references to i915->display.dmc outside of intel_dmc.c are to these members.

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915/display/power: use intel_de_rmw if possible

2023-02-16 Thread Jani Nikula
On Thu, 05 Jan 2023, Rodrigo Vivi wrote: > On Thu, Jan 05, 2023 at 02:10:39PM +0100, Andrzej Hajda wrote: >> The helper makes the code more compact and readable. >> >> Signed-off-by: Andrzej Hajda >> --- >> .../drm/i915/display/intel_display_power.c| 49 --- >>

[Intel-gfx] [PATCH 1/1] drm: Add a gpu page-table walker helper

2023-02-16 Thread Thomas Hellström
Add a gpu page table walker similar in functionality to the cpu page-table walker in mm/pagewalk.c. This is made a drm helper in the hope that it might prove useful to other drivers, but we could of course make it single-driver only and rename the functions initially. Also if remaining a DRM

[Intel-gfx] [PATCH 0/1] drm: Add a gpu page-table walker

2023-02-16 Thread Thomas Hellström
A slightly unusual cover letter for a single patch. The page table walker is currently used by the xe driver only, but the code is generic so we can be good citizens and add it to drm as a helper, for possible use by other drivers, If so we can merge the commit when we merge the xe driver. The

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-16 Thread Rob Clark
On Thu, Feb 16, 2023 at 3:19 AM Tvrtko Ursulin wrote: > > > On 14/02/2023 19:14, Rob Clark wrote: > > On Fri, Feb 10, 2023 at 5:07 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> In i915 we have this concept of "wait boosting" where we give a priority > >> boost > >> for

Re: [Intel-gfx] [PATCH v5] drm/i915: Consolidate TLB invalidation flow

2023-02-16 Thread Matt Roper
On Thu, Feb 16, 2023 at 09:21:23AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > As the logic for selecting the register and corresponsing values grew, the > code become a bit unsightly. Consolidate by storing the required values at > engine init time in the engine itself, and by doing

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add a TTM shrinker

2023-02-16 Thread Patchwork
== Series Details == Series: Add a TTM shrinker URL : https://patchwork.freedesktop.org/series/114060/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12744_full -> Patchwork_114060v1_full Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH v3 2/5] drm/i915/wm: warn about ilk_wm_sanitize() on display ver 9+

2023-02-16 Thread Jani Nikula
On Wed, 15 Feb 2023, Ville Syrjälä wrote: > On Wed, Feb 15, 2023 at 04:19:07PM +0200, Jani Nikula wrote: >> The sanitization should be limited to PCH split platforms up to display >> version 8. Warn and bail out otherwise. >> >> Signed-off-by: Jani Nikula >> --- >>

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/atomic-helpers: remove legacy_cursor_update hacks (rev3)

2023-02-16 Thread Patchwork
== Series Details == Series: drm/atomic-helpers: remove legacy_cursor_update hacks (rev3) URL : https://patchwork.freedesktop.org/series/102028/ State : success == Summary == CI Bug Log - changes from CI_DRM_12748 -> Patchwork_102028v3

[Intel-gfx] ✓ Fi.CI.BAT: success for Waitboost drm syncobj waits (rev3)

2023-02-16 Thread Patchwork
== Series Details == Series: Waitboost drm syncobj waits (rev3) URL : https://patchwork.freedesktop.org/series/113846/ State : success == Summary == CI Bug Log - changes from CI_DRM_12748 -> Patchwork_113846v3 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Reduce ELD hex dumps a bit (rev2)

2023-02-16 Thread Patchwork
== Series Details == Series: drm/i915: Reduce ELD hex dumps a bit (rev2) URL : https://patchwork.freedesktop.org/series/114051/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12744_full -> Patchwork_114051v2_full Summary

  1   2   >