Re: [Intel-gfx] [PATCH v3 2/4] mei: gsc_proxy: add gsc proxy driver

2023-05-03 Thread Teres Alexis, Alan Previn
We only had nits before and all sorted now, so.. Reviewed-by: Alan Previn On Tue, 2023-05-02 at 09:38 -0700, Ceraolo Spurio, Daniele wrote: > From: Alexander Usyskin > > Add GSC proxy driver. It to allows messaging between GSC component > on Intel graphics card and CSE device. > > Cc: Alan

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915/mtl: Define GSC Proxy component interface

2023-05-03 Thread Teres Alexis, Alan Previn
LGTM Reviewed-by: Alan Previn On Tue, 2023-05-02 at 09:38 -0700, Ceraolo Spurio, Daniele wrote: > From: Alexander Usyskin > > GSC Proxy component is used for communication between the > Intel graphics driver and MEI driver. > > Cc: Alan Previn > Signed-off-by: Alexander Usyskin >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/hdcp: add intel_atomic_state argument to hdcp_enable function

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: add intel_atomic_state argument to hdcp_enable function URL : https://patchwork.freedesktop.org/series/117261/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13105_full -> Patchwork_117261v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: add intel_atomic_state argument to hdcp_enable function

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: add intel_atomic_state argument to hdcp_enable function URL : https://patchwork.freedesktop.org/series/117261/ State : success == Summary == CI Bug Log - changes from CI_DRM_13105 -> Patchwork_117261v1

[Intel-gfx] [PATCH] drm/i915/hdcp: add intel_atomic_state argument to hdcp_enable function

2023-05-03 Thread Suraj Kandpal
Since topology state is being added to drm_atomic_state now all drm_modeset_lock required are being taken from core this raises an issue when we try to loop over connector and assign vcpi id to our streams as we did not have atomic state to derive acquire_ctx from hence we fill in stream info if

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tc: Add a workaround for an IOM/TCSS firmware hang issue (rev2)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915/tc: Add a workaround for an IOM/TCSS firmware hang issue (rev2) URL : https://patchwork.freedesktop.org/series/117004/ State : success == Summary == CI Bug Log - changes from CI_DRM_13105_full -> Patchwork_117004v2_full

Re: [Intel-gfx] [PATCH v2 25/27] KVM: x86/mmu: Drop @slot param from exported/external page-track APIs

2023-05-03 Thread Yan Zhao
On Wed, May 03, 2023 at 04:16:10PM -0700, Sean Christopherson wrote: > Finally getting back to this series... > > On Thu, Mar 23, 2023, Yan Zhao wrote: > > On Fri, Mar 17, 2023 at 04:28:56PM +0800, Yan Zhao wrote: > > > On Fri, Mar 10, 2023 at 04:22:56PM -0800, Sean Christopherson wrote: > > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Allow user to set cache at BO creation (rev5)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: Allow user to set cache at BO creation (rev5) URL : https://patchwork.freedesktop.org/series/116870/ State : success == Summary == CI Bug Log - changes from CI_DRM_13105_full -> Patchwork_116870v5_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: use pat_index instead of cache_level (rev3)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: use pat_index instead of cache_level (rev3) URL : https://patchwork.freedesktop.org/series/117082/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13105_full -> Patchwork_117082v3_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tc: Add a workaround for an IOM/TCSS firmware hang issue (rev2)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915/tc: Add a workaround for an IOM/TCSS firmware hang issue (rev2) URL : https://patchwork.freedesktop.org/series/117004/ State : success == Summary == CI Bug Log - changes from CI_DRM_13105 -> Patchwork_117004v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/tc: Add a workaround for an IOM/TCSS firmware hang issue (rev2)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915/tc: Add a workaround for an IOM/TCSS firmware hang issue (rev2) URL : https://patchwork.freedesktop.org/series/117004/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tc: Add a workaround for an IOM/TCSS firmware hang issue (rev2)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915/tc: Add a workaround for an IOM/TCSS firmware hang issue (rev2) URL : https://patchwork.freedesktop.org/series/117004/ State : warning == Summary == Error: dim checkpatch failed c0e23e703186 drm/i915: Fix PIPEDMC disabling for a bigjoiner configuration

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Allow user to set cache at BO creation (rev5)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: Allow user to set cache at BO creation (rev5) URL : https://patchwork.freedesktop.org/series/116870/ State : success == Summary == CI Bug Log - changes from CI_DRM_13105 -> Patchwork_116870v5 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Allow user to set cache at BO creation (rev5)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: Allow user to set cache at BO creation (rev5) URL : https://patchwork.freedesktop.org/series/116870/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Allow user to set cache at BO creation (rev5)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: Allow user to set cache at BO creation (rev5) URL : https://patchwork.freedesktop.org/series/116870/ State : warning == Summary == Error: dim checkpatch failed 8d4bca57da62 drm/i915: preparation for using PAT index 632ff256c617 drm/i915: use pat_index

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: use pat_index instead of cache_level (rev3)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: use pat_index instead of cache_level (rev3) URL : https://patchwork.freedesktop.org/series/117082/ State : success == Summary == CI Bug Log - changes from CI_DRM_13105 -> Patchwork_117082v3 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: use pat_index instead of cache_level (rev3)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: use pat_index instead of cache_level (rev3) URL : https://patchwork.freedesktop.org/series/117082/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: use pat_index instead of cache_level (rev3)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: use pat_index instead of cache_level (rev3) URL : https://patchwork.freedesktop.org/series/117082/ State : warning == Summary == Error: dim checkpatch failed e0adba081465 drm/i915: preparation for using PAT index 7b0702fb0a64 drm/i915: use pat_index

Re: [Intel-gfx] [PATCH v2 25/27] KVM: x86/mmu: Drop @slot param from exported/external page-track APIs

2023-05-03 Thread Sean Christopherson
Finally getting back to this series... On Thu, Mar 23, 2023, Yan Zhao wrote: > On Fri, Mar 17, 2023 at 04:28:56PM +0800, Yan Zhao wrote: > > On Fri, Mar 10, 2023 at 04:22:56PM -0800, Sean Christopherson wrote: > > ... > > > +int kvm_write_track_add_gfn(struct kvm *kvm, gfn_t gfn) > > > +{ > > > +

[Intel-gfx] [PATCH v2 12/12] drm/i915/tc: Reset TypeC PHYs left enabled in DP-alt mode after the sink disconnects

2023-05-03 Thread Imre Deak
If the output on a DP-alt link with its sink disconnected is kept enabled for too long (about 20 sec), then some IOM/TCSS firmware timeout will cause havoc on the PCI bus, at least for other GFX devices on it which will stop powering up. Since user space is not guaranteed to do a disabling modeset

[Intel-gfx] [PATCH v2 11/12] drm/i915: Factor out a helper for handling atomic modeset locks/state

2023-05-03 Thread Imre Deak
This patch simplifying the handling of modeset locks and atomic state for an atomic commit is based on https://lore.kernel.org/all/20210715184954.7794-2-ville.syrj...@linux.intel.com/ adding the helper to i915. I find this approach preferrable than open-coding the corresponding steps (fixed for

[Intel-gfx] [PATCH v2 10/12] drm/i915/dp: Factor out intel_dp_get_active_pipes()

2023-05-03 Thread Imre Deak
Factor out a helper used by a follow up patch to reset an active DP link. No functional changes. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_dp.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[Intel-gfx] [PATCH v2 09/12] drm/i915/dp: Prevent link training fallback on disconnected port

2023-05-03 Thread Imre Deak
Prevent downgrading the link training maximum lane count/rate if the sink is disconnected - and so the link training failure is expected. In such cases modeset failures due to the reduced max link params would be just confusing for user space (instead of which the correct thing it should act on is

[Intel-gfx] [PATCH v2 07/12] drm/i915/dp: Add link training debug and error printing helpers

2023-05-03 Thread Imre Deak
Add functions for printing link training debug and error messages, both to prepare for the next patch, which downgrades an error to a debug message if the sink is disconnected and to remove some code duplication. v2: (Ville) - Always print the connector prefix. - Preserve the drm_dbg_kms() debug

[Intel-gfx] [PATCH v2 08/12] drm/i915/dp: Convert link training error to debug message on disconnected sink

2023-05-03 Thread Imre Deak
If a sink is disconnected it's expected that link training actions will fail on it, so downgrade the error messages about such actions to be a debug message. Such - expected - link training failures are more frequent after a follow up patch, after which an active TypeC link is reset after the sink

[Intel-gfx] [PATCH v2 05/12] drm/i915: Factor out set_encoder_for_connector()

2023-05-03 Thread Imre Deak
Factor out a function setting the encoder and CRTC in the connector atomic state, required by a follow up patch. No functional changes. Signed-off-by: Imre Deak --- .../drm/i915/display/intel_modeset_setup.c| 28 +-- 1 file changed, 19 insertions(+), 9 deletions(-) diff

[Intel-gfx] [PATCH v2 06/12] drm/i915: Add support for disabling any CRTCs during HW readout/sanitization

2023-05-03 Thread Imre Deak
During HW readout/sanitization CRTCs can be disabled only if they don't have an attached encoder (and so the encoder disable hooks don't need to be called). An upcoming patch will need to disable CRTCs also with an attached an encoder, so add support for this. For bigjoiner configs the encoder

[Intel-gfx] [PATCH v2 04/12] drm/i915: Separate intel_crtc_disable_noatomic_begin/complete()

2023-05-03 Thread Imre Deak
Split calling the CRTC/encoder disabling hooks and updating the CRTC and DPLL object states from updating the CRTC and atomic state and other global state (BW, CDCLK, DBUF) into separate functions. When disabling a bigjoiner configuration the latter step can be done only after all the linked pipes

[Intel-gfx] [PATCH v2 03/12] drm/i915: Update connector atomic state before crtc sanitize-disabling

2023-05-03 Thread Imre Deak
During HW state readout/sanitization an up-to-date connector atomic state will be required by a follow-up patch, which can disable CRTCs with an encoder (and calling the correct encoder hooks happens via the connector atomic state encoder pointer). So update the connector state already before the

[Intel-gfx] [PATCH v2 02/12] drm/i915: Make the CRTC state consistent during sanitize-disabling

2023-05-03 Thread Imre Deak
Make sure that the CRTC state is reset correctly, as expected after disabling the CRTC. In particular this change will: - Zero all the CSC blob pointers after intel_crtc_free_hw_state() has freed them. - Zero the shared DPLL and port PLL pointers and clear the corresponding active flags in

[Intel-gfx] [PATCH v2 01/12] drm/i915: Fix PIPEDMC disabling for a bigjoiner configuration

2023-05-03 Thread Imre Deak
For a bigjoiner configuration display->crtc_disable() will be called first for the slave CRTCs and then for the master CRTC. However slave CRTCs will be actually disabled only after the master CRTC is disabled (from the encoder disable hooks called with the master CRTC state). Hence the slave

[Intel-gfx] [PATCH v2 00/12] drm/i915/tc: Add a workaround for an IOM/TCSS firmware hang issue

2023-05-03 Thread Imre Deak
This is v2 of [1] addressing the review comments from Ville. It also includes a few fixes I noticed during further testing, and a workaround for the firmware blocking the HPD state update of an active/disconnected port (stuck in the connected state) until another active/disconnected port gets

[Intel-gfx] [PATCH v5 2/5] drm/i915: use pat_index instead of cache_level

2023-05-03 Thread fei . yang
From: Fei Yang Currently the KMD is using enum i915_cache_level to set caching policy for buffer objects. This is flaky because the PAT index which really controls the caching behavior in PTE has far more levels than what's defined in the enum. In addition, the PAT index is platform dependent,

[Intel-gfx] [PATCH v5 5/5] drm/i915: Allow user to set cache at BO creation

2023-05-03 Thread fei . yang
From: Fei Yang To comply with the design that buffer objects shall have immutable cache setting through out their life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at object creation time. The current code applies a

[Intel-gfx] [PATCH v5 3/5] drm/i915: make sure correct pte encode is used

2023-05-03 Thread fei . yang
From: Fei Yang PTE encode is platform dependent. After replacing cache_level with pat_index, the newly introduced mtl_pte_encode is actually generic for all gen12 platforms, thus rename it to gen12_pte_encode and apply it to all gen12 platforms. Cc: Chris Wilson Cc: Matt Roper Signed-off-by:

[Intel-gfx] [PATCH v5 4/5] drm/i915/mtl: end support for set caching ioctl

2023-05-03 Thread fei . yang
From: Fei Yang The design is to keep Buffer Object's caching policy immutable through out its life cycle. This patch ends the support for set caching ioctl from MTL onward. While doing that we also set BO's to be 1-way coherent at creation time because GPU is no longer automatically snooping CPU

[Intel-gfx] [PATCH v5 0/5] drm/i915: Allow user to set cache at BO creation

2023-05-03 Thread fei . yang
From: Fei Yang The first three patches in this series are taken from https://patchwork.freedesktop.org/series/116868/ These patches are included here because the last patch has dependency on the pat_index refactor. This series is focusing on uAPI changes, 1. end support for set caching ioctl

[Intel-gfx] [PATCH v5 1/5] drm/i915: preparation for using PAT index

2023-05-03 Thread fei . yang
From: Fei Yang This patch is a preparation for replacing enum i915_cache_level with PAT index. Caching policy for buffer objects is set through the PAT index in PTE, the old i915_cache_level is not sufficient to represent all caching modes supported by the hardware. Preparing the transition by

[Intel-gfx] [PATCH v5 3/3] drm/i915: make sure correct pte encode is used

2023-05-03 Thread fei . yang
From: Fei Yang PTE encode is platform dependent. After replacing cache_level with pat_index, the newly introduced mtl_pte_encode is actually generic for all gen12 platforms, thus rename it to gen12_pte_encode and apply it to all gen12 platforms. Cc: Chris Wilson Cc: Matt Roper Signed-off-by:

[Intel-gfx] [PATCH v5 0/3] drm/i915: use pat_index instead of cache_level

2023-05-03 Thread fei . yang
From: Fei Yang This patch set was posted at https://patchwork.freedesktop.org/series/116868/ Change title since the PTE patch was merged separately. These patches are extracted from series https://patchwork.freedesktop.org/series/115980/ This series refactor the cache policy programming so

[Intel-gfx] [PATCH v5 1/3] drm/i915: preparation for using PAT index

2023-05-03 Thread fei . yang
From: Fei Yang This patch is a preparation for replacing enum i915_cache_level with PAT index. Caching policy for buffer objects is set through the PAT index in PTE, the old i915_cache_level is not sufficient to represent all caching modes supported by the hardware. Preparing the transition by

[Intel-gfx] [PATCH v5 2/3] drm/i915: use pat_index instead of cache_level

2023-05-03 Thread fei . yang
From: Fei Yang Currently the KMD is using enum i915_cache_level to set caching policy for buffer objects. This is flaky because the PAT index which really controls the caching behavior in PTE has far more levels than what's defined in the enum. In addition, the PAT index is platform dependent,

Re: [Intel-gfx] [PATCH v4 2/9] vfio-iommufd: Create iommufd_access for noiommu devices

2023-05-03 Thread Alex Williamson
On Wed, 3 May 2023 16:41:52 -0300 Jason Gunthorpe wrote: > > > My general idea to complete the no-iommu feature is to add a new IOCTL > > > to VFIO that is 'pin iova and return dma addr' that no-iommu userspace > > > would call instead of trying to abuse mlock and /proc/ to do it. That > > >

Re: [Intel-gfx] [PATCH v4 2/3] drm/i915: use pat_index instead of cache_level

2023-05-03 Thread Yang, Fei
[...] >> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c >> b/drivers/gpu/drm/i915/gem/i915_gem_object.c >> index 8c70a0ec7d2f..27c948350b5b 100644 >> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c >> @@ -54,6 +54,25 @@ unsigned int

Re: [Intel-gfx] [PATCH 01/11] drm/dp_mst: Fix fractional DSC bpp handling

2023-05-03 Thread Lyude Paul
Reviewed-by: Lyude Paul Thanks! On Tue, 2023-05-02 at 17:38 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The current code does '(bpp << 4) / 16' in the MST PBN > calculation, but that is just the same as 'bpp' so the > DSC codepath achieves absolutely nothing. Fix it up so that > the

Re: [Intel-gfx] [PATCH v4 2/9] vfio-iommufd: Create iommufd_access for noiommu devices

2023-05-03 Thread Jason Gunthorpe
On Wed, May 03, 2023 at 09:48:36AM +, Liu, Yi L wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, May 3, 2023 2:12 AM > > > > On Sat, Apr 29, 2023 at 12:07:24AM +0800, Yi Liu wrote: > > > > The emulated stuff is for mdev only, it should not be confused with > > > > no-iommu > > > > > >

Re: [Intel-gfx] [PATCH v4 2/9] vfio-iommufd: Create iommufd_access for noiommu devices

2023-05-03 Thread Jason Gunthorpe
> > My general idea to complete the no-iommu feature is to add a new IOCTL > > to VFIO that is 'pin iova and return dma addr' that no-iommu userspace > > would call instead of trying to abuse mlock and /proc/ to do it. That > > ioctl would use the IOAS attached to the access just like a mdev would

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Improvements to GuC error capture

2023-05-03 Thread John Harrison
On 4/28/2023 23:49, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* Improvements to GuC error capture *URL:* https://patchwork.freedesktop.org/series/117120/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/index.html

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/guc: Capture list naming clean up

2023-05-03 Thread Teres Alexis, Alan Previn
LGTM: Reviewed-by: Alan Previn On Fri, 2023-04-28 at 11:56 -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > Don't use 'xe_lp*' prefixes for register lists that are common with > Gen8. > > Don't add Xe only GSC registers to pre-Xe devices that don't > even have a GSC engine. >

Re: [Intel-gfx] [PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEM_CREATE_EXTENSIONS query item

2023-05-03 Thread Jordan Justen
On 2023-05-02 22:41:09, Joonas Lahtinen wrote: > Hi Jordan, > > This approach was specifically NACKed in the PAT index thread so please > at least mark any such series as RFC if they are intended to facilitate > further dialog on the topic. There was a preference expressed to not do anything

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: MST+DSC nukage and state stuff (rev3)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: MST+DSC nukage and state stuff (rev3) URL : https://patchwork.freedesktop.org/series/117201/ State : success == Summary == CI Bug Log - changes from CI_DRM_13103_full -> Patchwork_117201v3_full

[Intel-gfx] PR for new GuC v70.6.6 for MTL

2023-05-03 Thread John . C . Harrison
The following changes since commit 312c61f5a6c9c6a313383a8f0c2b02711ec15262: amdgpu: update DCN 3.1.6 DMCUB firmware (2023-05-03 09:11:02 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware mtl_guc_70.6.6 for you to fetch changes up to

Re: [Intel-gfx] [RFC PATCH 2/4] drm/cgroup: Add memory accounting to DRM cgroup

2023-05-03 Thread Maarten Lankhorst
On 2023-05-03 17:31, Tvrtko Ursulin wrote: On 03/05/2023 09:34, Maarten Lankhorst wrote: Based roughly on the rdma and misc cgroup controllers, with a lot of the accounting code borrowed from rdma. The interface is simple: - populate drmcgroup_device->regions[..] name and size for each

Re: [Intel-gfx] [RFC PATCH 2/4] drm/cgroup: Add memory accounting to DRM cgroup

2023-05-03 Thread Tvrtko Ursulin
On 03/05/2023 09:34, Maarten Lankhorst wrote: Based roughly on the rdma and misc cgroup controllers, with a lot of the accounting code borrowed from rdma. The interface is simple: - populate drmcgroup_device->regions[..] name and size for each active region. - Call

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdcp: Check if media_gt exists (rev3)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Check if media_gt exists (rev3) URL : https://patchwork.freedesktop.org/series/117189/ State : success == Summary == CI Bug Log - changes from CI_DRM_13102_full -> Patchwork_117189v3_full Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: avoid flush_scheduled_work() usage (rev3)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: avoid flush_scheduled_work() usage (rev3) URL : https://patchwork.freedesktop.org/series/114608/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13103 -> Patchwork_114608v3 Summary

Re: [Intel-gfx] [PATCH 24/24] drm/i915: use kernel-doc -Werror when CONFIG_DRM_I915_WERROR=y

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:41PM +0300, Jani Nikula wrote: > With CONFIG_DRM_I915_WERROR=y, we enable kernel-doc check for both > objects and headers. Now that the kernel-doc warnings have been fixed, > also enable kernel-doc -Werror to fail the build on kernel-doc warnings. > > Signed-off-by:

Re: [Intel-gfx] [PATCH 23/24] drm/i915/scatterlist: fix kernel-doc parameter documentation

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:40PM +0300, Jani Nikula wrote: > drivers/gpu/drm/i915/i915_scatterlist.h:164: warning: Function parameter or > member 'release' not described in 'i915_refct_sgt_ops' > drivers/gpu/drm/i915/i915_scatterlist.h:187: warning: Function parameter or > member 'rsgt' not

Re: [Intel-gfx] [PATCH 21/24] drm/i915/pxp: fix kernel-doc for member dev_link

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:38PM +0300, Jani Nikula wrote: > Add /** to make it a kernel-doc. > > drivers/gpu/drm/i915/pxp/intel_pxp_types.h:96: warning: Function parameter or > member 'dev_link' not described in 'intel_pxp' > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- >

Re: [Intel-gfx] [PATCH 20/24] drm/i915/pmu: drop kernel-doc

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:37PM +0300, Jani Nikula wrote: > The comments are closer to not being kernel-doc. > > drivers/gpu/drm/i915/i915_pmu.h:21: warning: cannot understand function > prototype: 'enum i915_pmu_tracked_events ' > drivers/gpu/drm/i915/i915_pmu.h:32: warning: cannot

Re: [Intel-gfx] [PATCH 19/24] drm/i915/active: fix kernel-doc for function parameters

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:36PM +0300, Jani Nikula wrote: > drivers/gpu/drm/i915/i915_active.h:66: warning: Function parameter or member > 'active' not described in '__i915_active_fence_init' > drivers/gpu/drm/i915/i915_active.h:66: warning: Function parameter or member > 'fence' not

Re: [Intel-gfx] [PATCH 18/24] drm/i915/guc: add intel_guc_state_capture member docs for ads_null_cache and max_mmio_per_node

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:35PM +0300, Jani Nikula wrote: > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:216: warning: Function > parameter or member 'ads_null_cache' not described in > 'intel_guc_state_capture' > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:216: warning: Function >

Re: [Intel-gfx] [PATCH 17/24] drm/i915/guc: drop lots of kernel-doc markers

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:34PM +0300, Jani Nikula wrote: > The documentation is closer to not being kernel-doc, so just drop the > kernel-doc markers. > > drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter > or member 'size' not described in

Re: [Intel-gfx] [PATCH 16/24] drm/i915/guc: add dbgfs_node member kernel-doc

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:33PM +0300, Jani Nikula wrote: > drivers/gpu/drm/i915/gt/uc/intel_guc.h:274: warning: Function parameter or > member 'dbgfs_node' not described in 'intel_guc' > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- >

Re: [Intel-gfx] [PATCH 15/24] drm/i915/engine: hide preempt_hang selftest member from kernel-doc

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:32PM +0300, Jani Nikula wrote: > drivers/gpu/drm/i915/gt/intel_engine_types.h:293: warning: Function parameter > or member 'preempt_hang' not described in 'intel_engine_execlists' > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: avoid flush_scheduled_work() usage (rev3)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: avoid flush_scheduled_work() usage (rev3) URL : https://patchwork.freedesktop.org/series/114608/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 14/24] drm/i915/gtt: fix i915_vm_resv_put() kernel-doc parameter name

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:31PM +0300, Jani Nikula wrote: > drivers/gpu/drm/i915/gt/intel_gtt.h:515: warning: Function parameter or > member 'vm' not described in 'i915_vm_resv_put' > drivers/gpu/drm/i915/gt/intel_gtt.h:515: warning: Excess function parameter > 'resv' description in

Re: [Intel-gfx] [PATCH 13/24] drm/i915/context: fix kernel-doc parameter descriptions

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:30PM +0300, Jani Nikula wrote: > drivers/gpu/drm/i915/gt/intel_context.h:108: warning: Function parameter or > member 'ce' not described in 'intel_context_lock_pinned' > drivers/gpu/drm/i915/gt/intel_context.h:123: warning: Function parameter or > member 'ce' not

Re: [Intel-gfx] [PATCH 12/24] drm/i915/engine: fix kernel-doc function name for intel_engine_cleanup_common()

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:29PM +0300, Jani Nikula wrote: > drivers/gpu/drm/i915/gt/intel_engine_cs.c:1525: warning: expecting prototype > for intel_engines_cleanup_common(). Prototype was for > intel_engine_cleanup_common() instead > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi

Re: [Intel-gfx] [PATCH 11/24] drm/i915/ttm: fix i915_ttm_to_gem() kernel-doc

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:28PM +0300, Jani Nikula wrote: > drivers/gpu/drm/i915/gem/i915_gem_ttm.h:50: warning: Function parameter or > member 'bo' not described in 'i915_ttm_to_gem' > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/gem/i915_gem_ttm.h | 1 + > 1 file changed, 1

Re: [Intel-gfx] [PATCH 10/24] drm/i915/gem: fix function pointer member kernel-doc

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:27PM +0300, Jani Nikula wrote: > You can't document function pointer member as functions. > > drivers/gpu/drm/i915/gem/i915_gem_region.h:25: warning: Incorrect use of > kernel-doc format: * process_obj - Process the current object >

Re: [Intel-gfx] [PATCH 09/24] drm/i915/gem: fix i915_gem_object_lookup_rcu() kernel-doc parameter name

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:26PM +0300, Jani Nikula wrote: > drivers/gpu/drm/i915/gem/i915_gem_object.h:94: warning: Function parameter or > member 'file' not described in 'i915_gem_object_lookup_rcu' > drivers/gpu/drm/i915/gem/i915_gem_object.h:94: warning: Excess function > parameter 'filp'

Re: [Intel-gfx] [PATCH 08/24] drm/i915/request: drop kernel-doc

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:25PM +0300, Jani Nikula wrote: > The documentation is closer to not being kernel-doc. Just drop the > kernel-doc /** indicators. > > drivers/gpu/drm/i915/i915_request.h:176: warning: This comment starts with > '/**', but isn't a kernel-doc comment. Refer >

Re: [Intel-gfx] [PATCH 04/24] drm/i915/vma: document struct i915_vma_resource wakeref member

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:21PM +0300, Jani Nikula wrote: > drivers/gpu/drm/i915/i915_vma_resource.h:129: warning: Function parameter or > member 'wakeref' not described in 'i915_vma_resource' > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_vma_resource.h | 1 + > 1 file

Re: [Intel-gfx] [PATCH 07/24] drm/i915/error: fix i915_capture_error_state() kernel-doc

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:24PM +0300, Jani Nikula wrote: > drivers/gpu/drm/i915/i915_gpu_error.c:2174: warning: Function parameter or > member 'dump_flags' not described in 'i915_capture_error_state' > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- >

Re: [Intel-gfx] [PATCH 06/24] drm/i915/perf: fix i915_perf_ioctl_version() kernel-doc

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:23PM +0300, Jani Nikula wrote: > drivers/gpu/drm/i915/i915_perf.c:5307: warning: Function parameter or member > 'i915' not described in 'i915_perf_ioctl_version' > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_perf.c

Re: [Intel-gfx] [PATCH 05/24] drm/i915/vma: fix struct i915_vma_bindinfo kernel-doc

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:22PM +0300, Jani Nikula wrote: > You can't document both a sub-struct type and a struct member at the > same time. Separate them. another way would be to kill the 'i915_vma_bindinfo' name entirely and document only as '@bi:' and then move the individual

Re: [Intel-gfx] [PATCH 03/24] drm/i915/utils: drop kernel-doc from __wait_for()

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:20PM +0300, Jani Nikula wrote: > The parameters aren't documented, and the file isn't included in Sphinx > build anyway, so demote the kernel-doc to a regular comment. > > drivers/gpu/drm/i915/i915_utils.h:284: warning: Function parameter or member > 'OP' not

Re: [Intel-gfx] [PATCH 02/24] drm/i915/vma: fix kernel-doc function name for i915_vma_size()

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:19PM +0300, Jani Nikula wrote: > drivers/gpu/drm/i915/i915_vma.h:145: warning: expecting prototype for > i915_vma_offset(). Prototype was for i915_vma_size() instead > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- >

Re: [Intel-gfx] [PATCH 01/24] drm/i915/gvt: fix intel_vgpu_alloc_resource() kernel-doc parameter

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:18PM +0300, Jani Nikula wrote: > drivers/gpu/drm/i915/gvt/aperture_gm.c:344: warning: Function parameter or > member 'conf' not described in 'intel_vgpu_alloc_resource' > drivers/gpu/drm/i915/gvt/aperture_gm.c:344: warning: Excess function > parameter 'param'

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: taint kernel when force probing unsupported devices

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: taint kernel when force probing unsupported devices URL : https://patchwork.freedesktop.org/series/117231/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13102_full -> Patchwork_117231v1_full

[Intel-gfx] [PATCH v3] drm/i915: avoid flush_scheduled_work() usage

2023-05-03 Thread Tetsuo Handa
Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a macro") says, flush_scheduled_work() is dangerous and will be forbidden. i915 became the last flush_scheduled_work() user, but developers cannot find time for auditing which work items does this flush_scheduled_work() need

Re: [Intel-gfx] [PATCH] drm/i915: taint kernel when force probing unsupported devices

2023-05-03 Thread Rodrigo Vivi
On Wed, May 03, 2023 at 12:48:26PM +0300, Jani Nikula wrote: > For development and testing purposes, the i915.force_probe module > parameter and DRM_I915_FORCE_PROBE kconfig option allow probing of > devices that aren't supported by the driver. > > The i915.force_probe module parameter is

Re: [Intel-gfx] [PATCH v4 2/3] drm/i915: use pat_index instead of cache_level

2023-05-03 Thread Tvrtko Ursulin
On 02/05/2023 05:11, fei.y...@intel.com wrote: From: Fei Yang Currently the KMD is using enum i915_cache_level to set caching policy for buffer objects. This is flaky because the PAT index which really controls the caching behavior in PTE has far more levels than what's defined in the enum.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: MST+DSC nukage and state stuff (rev3)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: MST+DSC nukage and state stuff (rev3) URL : https://patchwork.freedesktop.org/series/117201/ State : success == Summary == CI Bug Log - changes from CI_DRM_13103 -> Patchwork_117201v3 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: HuC loading and authentication for MTL (rev4)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading and authentication for MTL (rev4) URL : https://patchwork.freedesktop.org/series/117080/ State : success == Summary == CI Bug Log - changes from CI_DRM_13102_full -> Patchwork_117080v4_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: MST+DSC nukage and state stuff (rev3)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: MST+DSC nukage and state stuff (rev3) URL : https://patchwork.freedesktop.org/series/117201/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: MST+DSC nukage and state stuff (rev3)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: MST+DSC nukage and state stuff (rev3) URL : https://patchwork.freedesktop.org/series/117201/ State : warning == Summary == Error: dim checkpatch failed be284779422a drm/dp_mst: Fix fractional DSC bpp handling af5f8eb69814 drm/i915/mst: Remove broken MST

Re: [Intel-gfx] [PATCH] drm/i915: taint kernel when force probing unsupported devices

2023-05-03 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-i915-taint-kernel-when-force-probing-unsupported-devices/20230503-175009 base: git://anongit.freedesktop.org/drm

Re: [Intel-gfx] [PATCH 02/11] drm/i915/mst: Remove broken MST DSC support

2023-05-03 Thread Lisovskiy, Stanislav
On Wed, May 03, 2023 at 02:07:04PM +0300, Ville Syrjälä wrote: > On Wed, May 03, 2023 at 10:36:42AM +0300, Lisovskiy, Stanislav wrote: > > On Tue, May 02, 2023 at 05:38:57PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > The MST DSC code has a myriad of issues: > > > -

Re: [Intel-gfx] [PATCH] drm/i915/display: Communicate display power demands to pcode

2023-05-03 Thread Govindapillai, Vinod
Hi Stan On Tue, 2023-04-25 at 11:13 +0300, Stanislav Lisovskiy wrote: > Display to communicate display pipe count/CDCLK/voltage configuration > to Pcode for more accurate power accounting for DG2. > Existing sequence is only sending the voltage value to the Pcode. > Adding new sequence with

[Intel-gfx] [PATCH v2 08/11] drm/i915: Introduce crtc_state->enhanced_framing

2023-05-03 Thread Ville Syrjala
From: Ville Syrjälä Track DP enhanced framing properly in the crtc state instead of relying just on the cached DPCD everywhere, and hook it up into the state check and dump. v2: Actually set enhanced_framing in .compute_config() Signed-off-by: Ville Syrjälä ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: Check if media_gt exists (rev3)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Check if media_gt exists (rev3) URL : https://patchwork.freedesktop.org/series/117189/ State : success == Summary == CI Bug Log - changes from CI_DRM_13102 -> Patchwork_117189v3 Summary ---

Re: [Intel-gfx] [PATCH 02/11] drm/i915/mst: Remove broken MST DSC support

2023-05-03 Thread Ville Syrjälä
On Wed, May 03, 2023 at 10:36:42AM +0300, Lisovskiy, Stanislav wrote: > On Tue, May 02, 2023 at 05:38:57PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The MST DSC code has a myriad of issues: > > - Platform checks are wrong (MST+DSC is TGL+ only IIRC) > > - Return values of

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: taint kernel when force probing unsupported devices

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: taint kernel when force probing unsupported devices URL : https://patchwork.freedesktop.org/series/117231/ State : success == Summary == CI Bug Log - changes from CI_DRM_13102 -> Patchwork_117231v1

Re: [Intel-gfx] [PATCH] drm/i915: taint kernel when force probing unsupported devices

2023-05-03 Thread Daniel Vetter
On Wed, 3 May 2023 at 11:48, Jani Nikula wrote: > > For development and testing purposes, the i915.force_probe module > parameter and DRM_I915_FORCE_PROBE kconfig option allow probing of > devices that aren't supported by the driver. > > The i915.force_probe module parameter is "unsafe" and

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: HuC loading and authentication for MTL (rev4)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading and authentication for MTL (rev4) URL : https://patchwork.freedesktop.org/series/117080/ State : success == Summary == CI Bug Log - changes from CI_DRM_13102 -> Patchwork_117080v4 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: HuC loading and authentication for MTL (rev4)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading and authentication for MTL (rev4) URL : https://patchwork.freedesktop.org/series/117080/ State : warning == Summary == Error: dim checkpatch failed bd26d999612e DO NOT REVIEW: drm/i915: Add support for MTL GSC SW Proxy Traceback (most recent

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: HuC loading and authentication for MTL (rev4)

2023-05-03 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading and authentication for MTL (rev4) URL : https://patchwork.freedesktop.org/series/117080/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH] drm/i915/hdcp: Check if media_gt exists

2023-05-03 Thread Suraj Kandpal
Check if media_gt exists if we are using gsc cs --v2 -correct typo [Ankit] -assign gsc variable if gt exists [Ankit] --v3 -declare gsc and gt variables in if block [Ankit] Cc: Ankit Nautiyal Signed-off-by: Suraj Kandpal Reviewed-by: Gustavo Sousa ---

  1   2   >