[Intel-gfx] [PATCH 2/2] drm/i915/dp: Add TPS4 PHY test pattern support

2023-06-08 Thread Khaled Almahallawy
Adding support for TPS4 (CP2520 Pattern 3) PHY pattern source tests. Bspec: 50482, 50484 CC: Jani Nikula Cc: Imre Deak Cc: Lee Shawn C Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/i915/display/intel_dp.c | 11 +++ drivers/gpu/drm/i915/i915_reg.h | 4 2 files

[Intel-gfx] [PATCH 1/2] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names

2023-06-08 Thread Khaled Almahallawy
Starting from DP2.0 specs, DPCD 248h is renamed LINK_QUAL_PATTERN_SELECT and it has the same values of registers DPCD 10Bh-10Eh. Use the PHY pattern names defined for DPCD 10Bh-10Eh in order to add CP2520 Pattern 3 (TPS4) phy pattern support in the next patch of this series and DP2.1 PHY patterns

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Track buffer objects belonging to clients

2023-06-08 Thread Iddamsetty, Aravind
On 08-06-2023 20:21, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In order to show per client memory usage lets start tracking which > objects belong to which clients. > > We start with objects explicitly created by object creation UAPI and > track it on a new per client lists, protected

Re: [Intel-gfx] [PATCH v3 4/4] PCI/VGA: introduce is_boot_device function callback to vga_client_register

2023-06-08 Thread Sui Jingfeng
Hi, On 2023/6/9 03:19, Bjorn Helgaas wrote: On Thu, Jun 08, 2023 at 07:43:22PM +0800, Sui Jingfeng wrote: From: Sui Jingfeng The vga_is_firmware_default() function is arch-dependent, which doesn't sound right. At least, it also works on the Mips and LoongArch platforms. Tested with the

Re: [Intel-gfx] [PATCH v3 3/4] PCI/VGA: only deal with VGA class devices

2023-06-08 Thread Sui Jingfeng
Hi, On 2023/6/9 03:12, Bjorn Helgaas wrote: Start with verb and capitalize to match ("Deal only with ...") On Thu, Jun 08, 2023 at 07:43:21PM +0800, Sui Jingfeng wrote: From: Sui Jingfeng vgaarb only deal with the VGA devcie(pdev->class == 0x0300), so replace the pci_get_subsys() function

Re: [Intel-gfx] [PATCH v3 1/4] PCI/VGA: tidy up the code and comment format

2023-06-08 Thread Sui Jingfeng
Hi, On 2023/6/9 03:07, Bjorn Helgaas wrote: Capitalize subject to match ("Tidy ...") On Thu, Jun 08, 2023 at 07:43:19PM +0800, Sui Jingfeng wrote: From: Sui Jingfeng This patch replaces the leading space with a tab and removes the double blank line, no functional change. Can you move this

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/i915_pm_freq_api: Add a suspend subtest

2023-06-08 Thread Dixit, Ashutosh
On Wed, 07 Jun 2023 16:40:53 -0700, Belgaumkar, Vinay wrote: > > On 6/7/2023 4:11 PM, Belgaumkar, Vinay wrote: > > > > On 6/7/2023 3:56 PM, Dixit, Ashutosh wrote: > >> On Wed, 07 Jun 2023 15:31:33 -0700, Belgaumkar, Vinay wrote: > >>> On 6/7/2023 2:12 PM, Dixit, Ashutosh wrote: > On Tue, 06

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Add new vswing table for C20 phy to support DP 1.4 (rev4)

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add new vswing table for C20 phy to support DP 1.4 (rev4) URL : https://patchwork.freedesktop.org/series/118925/ State : success == Summary == CI Bug Log - changes from CI_DRM_13253 -> Patchwork_118925v4

[Intel-gfx] [v4] drm/i915/mtl: Add new vswing table for C20 phy to support DP 1.4

2023-06-08 Thread Lee Shawn C
Add vswing table to support DP 1.4 for C20 phy. v2: rename mtl_c10_trans v3: add default_entry for mtl_c20_trans_dp14 v4: rename mtl_cx0_trans_dp14 Bspec: 74104 Signed-off-by: Lee Shawn C Cc: Mika Kahola Cc: Clint Taylor Cc: Radhakrishna Sripada Cc: Uma Shankar Reviewed-by: Mika Kahola

Re: [Intel-gfx] [PATCH v7 9/9] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-06-08 Thread Liu, Yi L
> From: Alex Williamson > Sent: Friday, June 9, 2023 6:30 AM > > On Fri, 2 Jun 2023 05:15:15 -0700 > Yi Liu wrote: > > > This is the way user to invoke hot-reset for the devices opened by cdev > > interface. User should check the flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID_OWNED > > in the output of

Re: [Intel-gfx] [PATCH v7 8/9] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-06-08 Thread Liu, Yi L
> From: Alex Williamson > Sent: Friday, June 9, 2023 6:27 AM > > On Fri, 2 Jun 2023 05:15:14 -0700 > Yi Liu wrote: > > > This allows VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl use the iommufd_ctx > > of the cdev device to check the ownership of the other affected devices. > > > > When

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gsc: take a wakeref for the proxy-init-completion check (rev2)

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915/gsc: take a wakeref for the proxy-init-completion check (rev2) URL : https://patchwork.freedesktop.org/series/119092/ State : success == Summary == CI Bug Log - changes from CI_DRM_13253 -> Patchwork_119092v2

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: fix a memory leak in struct intel_vbt_panel_data

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915/dp: fix a memory leak in struct intel_vbt_panel_data URL : https://patchwork.freedesktop.org/series/119046/ State : success == Summary == CI Bug Log - changes from CI_DRM_13246_full -> Patchwork_119046v1_full

Re: [Intel-gfx] [PATCH v7 4/9] iommufd: Add iommufd_ctx_has_group()

2023-06-08 Thread Liu, Yi L
> From: Alex Williamson > Sent: Friday, June 9, 2023 5:41 AM > > On Fri, 2 Jun 2023 05:15:10 -0700 > Yi Liu wrote: > > > This adds the helper to check if any device within the given iommu_group > > has been bound with the iommufd_ctx. This is helpful for the checking on > > device ownership

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/mtl/gsc: query the GSC FW for its compatibility version

2023-06-08 Thread Teres Alexis, Alan Previn
On Mon, 2023-06-05 at 19:24 -0700, Ceraolo Spurio, Daniele wrote: > The compatibility version is queried via an MKHI command. Right now, the > only existing interface is 1.0 > This is basically the interface version for the GSC FW, so the plan is > to use it as the main tracked version, including

[Intel-gfx] [PATCH v2] drm/i915/gsc: take a wakeref for the proxy-init-completion check

2023-06-08 Thread Alan Previn
Ensure intel_gsc_uc_fw_init_done and intel_gsc_uc_fw_proxy_init takes a wakeref before reading GSC Shim registers. NOTE: another patch in review also adds a call from selftest to this same function. (https://patchwork.freedesktop.org/series/117713/) which is why i am adding the wakeref inside the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tc: Use standard ternary operator instead of GCC extension

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915/tc: Use standard ternary operator instead of GCC extension URL : https://patchwork.freedesktop.org/series/119098/ State : success == Summary == CI Bug Log - changes from CI_DRM_13253 -> Patchwork_119098v1

Re: [Intel-gfx] [PATCH v1] drm/i915/gsc: take a wakeref for the proxy-init-completion check

2023-06-08 Thread Teres Alexis, Alan Previn
On Thu, 2023-06-08 at 11:19 -0700, Ceraolo Spurio, Daniele wrote: > On 6/8/2023 11:04 AM, Alan Previn wrote: > > Ensure intel_gsc_uc_fw_init_done and intel_gsc_uc_fw_proxy_init > > takes a wakeref before reading GSC Shim registers. alan:snip > > > bool intel_gsc_uc_fw_proxy_init_done(struct

Re: [Intel-gfx] [PATCH v7 9/9] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-06-08 Thread Alex Williamson
On Fri, 2 Jun 2023 05:15:15 -0700 Yi Liu wrote: > This is the way user to invoke hot-reset for the devices opened by cdev > interface. User should check the flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID_OWNED > in the output of VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl before doing > hot-reset for cdev

Re: [Intel-gfx] [PATCH v7 8/9] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-06-08 Thread Alex Williamson
On Fri, 2 Jun 2023 05:15:14 -0700 Yi Liu wrote: > This allows VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl use the iommufd_ctx > of the cdev device to check the ownership of the other affected devices. > > When VFIO_DEVICE_GET_PCI_HOT_RESET_INFO is called on an IOMMUFD managed > device, the new

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix a VMA UAF for multi-gt platform (rev7)

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915: Fix a VMA UAF for multi-gt platform (rev7) URL : https://patchwork.freedesktop.org/series/118887/ State : success == Summary == CI Bug Log - changes from CI_DRM_13253 -> Patchwork_118887v7 Summary

Re: [Intel-gfx] [PATCH 4/4] drm/i915: make device info a const pointer to rodata

2023-06-08 Thread Matt Roper
On Thu, Jun 08, 2023 at 06:09:05PM +0300, Jani Nikula wrote: > Finally we can get rid of the pseudo-const write-once device info, and > convert it into a const pointer to device info in rodata. > > Cc: Matt Roper > Cc: Lucas De Marchi > Signed-off-by: Jani Nikula Reviewed-by: Matt Roper >

Re: [Intel-gfx] [PATCH 3/4] drm/i915: move display device and runtime info to struct intel_display

2023-06-08 Thread Matt Roper
On Thu, Jun 08, 2023 at 06:09:04PM +0300, Jani Nikula wrote: > Continue moving all things display further into display files and > structures. > > Cc: Matt Roper > Cc: Lucas De Marchi > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display_core.h | 9 + >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev2)

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev2) URL : https://patchwork.freedesktop.org/series/118898/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13246_full -> Patchwork_118898v2_full

[Intel-gfx] [PATCH] drm/i915/tc: Use standard ternary operator instead of GCC extension

2023-06-08 Thread Gil Dekel
The ternary expression: x ? : y is a GCC extension and is not a part of C/C++ standard. Use the canonical form instead to reduce dependency over GCC extension. Signed-off-by: Gil Dekel --- drivers/gpu/drm/i915/display/intel_display_power_well.c | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [Intel-gfx] [PATCH 2/4] drm/i915: fix display info usage

2023-06-08 Thread Matt Roper
On Thu, Jun 08, 2023 at 06:09:03PM +0300, Jani Nikula wrote: > Prefer DISPLAY_INFO() over INTEL_INFO()->display. > > Cc: Matt Roper > Cc: Lucas De Marchi > Signed-off-by: Jani Nikula Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_display.h | 2 +- > 1 file changed, 1

Re: [Intel-gfx] [PATCH 1/4] drm/i915: separate display info printing from the rest

2023-06-08 Thread Matt Roper
On Thu, Jun 08, 2023 at 06:09:02PM +0300, Jani Nikula wrote: > Add new function intel_display_device_info_print() and print the display > device info there instead of intel_device_info_print(). This also fixes > the display runtime info printing to use the actual runtime info instead > of the

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915/mtl/gsc: extract release and security versions from the gsc binary

2023-06-08 Thread Teres Alexis, Alan Previn
Everything looks good to me, so Reviewed-by: Alan Previn On Mon, 2023-06-05 at 19:23 -0700, Ceraolo Spurio, Daniele wrote: > The release and security versions of the GSC binary are not used at > runtime to decide interface compatibility (there is a separate version > for that), but they're still

Re: [Intel-gfx] [PATCH v7 4/9] iommufd: Add iommufd_ctx_has_group()

2023-06-08 Thread Alex Williamson
On Fri, 2 Jun 2023 05:15:10 -0700 Yi Liu wrote: > This adds the helper to check if any device within the given iommu_group > has been bound with the iommufd_ctx. This is helpful for the checking on > device ownership for the devices which have not been bound but cannot be > bound to any other

Re: [Intel-gfx] [PATCH] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-06-08 Thread Dong, Zhanjun
John mentioned 2 options: 1. “add the sync/async flag to _submission_disable()” Consider to be a small change 1. add an 'are busyness stats enabled' boolean to the guc structure Seems effected area among the flow and is much more than option 1. I would like to discuss a bit more before

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: ICL+ DSI modeset sequence fixes (rev2)

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915/dsi: ICL+ DSI modeset sequence fixes (rev2) URL : https://patchwork.freedesktop.org/series/116926/ State : success == Summary == CI Bug Log - changes from CI_DRM_13253 -> Patchwork_116926v2 Summary

Re: [Intel-gfx] [PATCH] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-06-08 Thread Dong, Zhanjun
Hi Andi, Thanks for comments. Info would be updated on next revision, which is on the way. Regards, Zhanjun Dong On 2023-06-07 8:19 p.m., Andi Shyti wrote: Hi Dong, On Wed, Jun 07, 2023 at 12:03:50PM -0700, Zhanjun Dong wrote: This attempts to avoid circular locking dependency between

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dsi: ICL+ DSI modeset sequence fixes (rev2)

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915/dsi: ICL+ DSI modeset sequence fixes (rev2) URL : https://patchwork.freedesktop.org/series/116926/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH V2] PCI: Move VMD ASPM/LTR fix to PCI quirk

2023-06-08 Thread Bjorn Helgaas
On Tue, Apr 11, 2023 at 02:33:23PM -0700, David E. Box wrote: > In commit f492edb40b54 ("PCI: vmd: Add quirk to configure PCIe ASPM and > LTR") the VMD driver calls pci_enabled_link_state as a callback from > pci_bus_walk. Both will acquire the pci_bus_sem lock leading to a lockdep > warning.

[Intel-gfx] [PATCH v2 13/13] drm/i915/dsi: Remove weird has_pch_encoder asserts

2023-06-08 Thread Ville Syrjala
From: Ville Syrjälä No idea why the DSI code is feeling the need to assert that has_pch_encoder must not be set. PCH encoders aren't even a thing on any platform that has DSI. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 2 --

[Intel-gfx] [PATCH v2 11/13] drm/i915/dsi: Move panel reset+power off to be the last thing

2023-06-08 Thread Ville Syrjala
From: Ville Syrjälä Follow what Windows does and do the DSI panel reset+power off after everything else. v2: s/intel_dsi_msleep/msleep/ Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 14 -- 1 file changed, 8 insertions(+), 6

[Intel-gfx] [PATCH v2 12/13] drm/i915/dsi: Grab the crtc from the customary place

2023-06-08 Thread Ville Syrjala
From: Ville Syrjälä The encoder hooks already get passed the crtc state so just grab the crtc from there instead of from the connector state. This is generally what everyone else does, so no reason for icl_dsi.c to be different. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v2 10/13] drm/i915/dsi: Respect power_off_delay on icl+

2023-06-08 Thread Ville Syrjala
From: Ville Syrjälä icl+ DSI isn't respecting the panel power_off_delay. Remedy that. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c

[Intel-gfx] [PATCH v2 09/13] drm/i915/dsi: Do DSC/scaler disable earlier on icl+

2023-06-08 Thread Ville Syrjala
From: Ville Syrjälä Do the scaler disable in the spot where bspec has specfied it for TGL+. And also move the DSC disable to match what intel_ddi.c does. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 7 +++ 1 file changed, 3

[Intel-gfx] [PATCH v2 08/13] drm/i915/dsi: Move most things from .disable() into .post_disable() on icl+

2023-06-08 Thread Ville Syrjala
From: Ville Syrjälä encoder->disable() is supposed to happen before the pipe/transcoder gets disabled. The icl+ DSI code screwed that up and put most things (including the transcoder disable itself) into encoder->disable(). Follow the common rules and hoist most things into the

[Intel-gfx] [PATCH v2 07/13] drm/i915/dsi: Implement encoder->shutdown() for icl+

2023-06-08 Thread Ville Syrjala
From: Ville Syrjälä Plug in the encoder->shutdown() hook for icl+ DSI so that we are guaranteed to respect the power cycle delay during reboots and whatnot. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 1 +

[Intel-gfx] [PATCH v2 06/13] drm/i915/dsi: Respect power cycle delay on icl+

2023-06-08 Thread Ville Syrjala
From: Ville Syrjälä Handle the DSI panel power cycle delay on icl+. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 6 ++ drivers/gpu/drm/i915/display/intel_dsi.c | 13 + drivers/gpu/drm/i915/display/intel_dsi.h | 1 +

[Intel-gfx] [PATCH v2 04/13] drm/i915/dsi: Split icl+ D-PHY vs. DSI timing steps

2023-06-08 Thread Ville Syrjala
From: Ville Syrjälä The programming of the DPHY vs. DSI _TIMING registers are two separate steps in the TGL+ bspec sequence, with some other stuff in between. Implement the same split. Windows also seems follow the bspec TGL+ sequence, even on ICL/JSL. Reviewed-by: Jani Nikula Signed-off-by:

[Intel-gfx] [PATCH v2 05/13] drm/i915/dsi: Gate DSI clocks earlier

2023-06-08 Thread Ville Syrjala
From: Ville Syrjälä The clock gating step is in the wrong spot compared to the TGL+ bspec sequence. Move it the right place. Windows also seems to use the TGL+ order here always. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 5 ++--- 1

[Intel-gfx] [PATCH v2 03/13] drm/i915/dsi: Print the VBT MIPI sequence delay duration

2023-06-08 Thread Ville Syrjala
From: Ville Syrjälä Help out debugging things by printing out how long the VBT delay sequence is supposed to wait. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH v2 02/13] drm/i915/dsi: Do display on sequence later on icl+

2023-06-08 Thread Ville Syrjala
From: Ville Syrjälä Doing the init OTP and display on DSI sequences back to back doesn't really make any sense (a single sequence would suffice then). Move the display on sequence to be done just before backlight on, which is also what Windows does. Reviewed-by: Jani Nikula Signed-off-by:

[Intel-gfx] [PATCH v2 01/13] drm/i915/dsi: Do panel power on + reset deassert earlier on icl+

2023-06-08 Thread Ville Syrjala
From: Ville Syrjälä Looks like we're trying to talk to the DSI panel even before turning it on, on icl+. Bspec doesn't actually specify when these should be done, but certainly we need to turn the panel on at least before talking to it. So let's move the power on + reset deassert steps to be the

[Intel-gfx] [PATCH v2 00/13] drm/i915/dsi: ICL+ DSI modeset sequence fixes

2023-06-08 Thread Ville Syrjala
From: Ville Syrjälä Rebase of the ICL+ DSI modeset sequence stuff. Ville Syrjälä (13): drm/i915/dsi: Do panel power on + reset deassert earlier on icl+ drm/i915/dsi: Do display on sequence later on icl+ drm/i915/dsi: Print the VBT MIPI sequence delay duration drm/i915/dsi: Split icl+

Re: [Intel-gfx] [PATCH v2 7/7] drm/i915: Convert HSW/BDW to use port_mask for DDI probe

2023-06-08 Thread Ville Syrjälä
On Fri, Jun 02, 2023 at 05:51:19PM +0300, Jani Nikula wrote: > On Wed, 31 May 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Make HSW/BDW use port_mask for output probing as well. > > To achieve that the strap checks are moved into > > intel_ddi_init() itself. Or should we move them

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gsc: take a wakeref for the proxy-init-completion check

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915/gsc: take a wakeref for the proxy-init-completion check URL : https://patchwork.freedesktop.org/series/119092/ State : success == Summary == CI Bug Log - changes from CI_DRM_13253 -> Patchwork_119092v1

Re: [Intel-gfx] [PATCH v2 6/7] drm/i915: Init DDI outputs based on port_mask on skl+

2023-06-08 Thread Ville Syrjälä
On Fri, Jun 02, 2023 at 05:41:50PM +0300, Jani Nikula wrote: > On Wed, 31 May 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Instead of listing every platform's possible DDI outputs > > in intel_setup_outputs() just loop over the new port_mask > > to achieve the same thing. > > For

Re: [Intel-gfx] [PATCH v2 2/7] drm/i915: Introduce device info port_mask

2023-06-08 Thread Ville Syrjälä
On Fri, Jun 02, 2023 at 05:11:45PM +0300, Jani Nikula wrote: > On Wed, 31 May 2023, Ville Syrjala wrote: > > @@ -556,6 +590,16 @@ static const struct intel_display_device_info > > gen11_display = { > > > > static const struct intel_display_device_info tgl_display = { > > XE_D_DISPLAY, > >

Re: [Intel-gfx] [PATCH v3 4/4] PCI/VGA: introduce is_boot_device function callback to vga_client_register

2023-06-08 Thread Bjorn Helgaas
On Thu, Jun 08, 2023 at 07:43:22PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > The vga_is_firmware_default() function is arch-dependent, which doesn't > sound right. At least, it also works on the Mips and LoongArch platforms. > Tested with the drm/amdgpu and drm/radeon drivers. However,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: further device info cleanups

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915: further device info cleanups URL : https://patchwork.freedesktop.org/series/119086/ State : success == Summary == CI Bug Log - changes from CI_DRM_13253 -> Patchwork_119086v1 Summary ---

Re: [Intel-gfx] [PATCH v3 3/4] PCI/VGA: only deal with VGA class devices

2023-06-08 Thread Bjorn Helgaas
Start with verb and capitalize to match ("Deal only with ...") On Thu, Jun 08, 2023 at 07:43:21PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > vgaarb only deal with the VGA devcie(pdev->class == 0x0300), so replace the > pci_get_subsys() function with pci_get_class(). Filter the non pci

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: further device info cleanups

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915: further device info cleanups URL : https://patchwork.freedesktop.org/series/119086/ State : warning == Summary == Error: dim checkpatch failed 4151efbd9a55 drm/i915: separate display info printing from the rest -:36: CHECK:MACRO_ARG_PRECEDENCE: Macro

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: further device info cleanups

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915: further device info cleanups URL : https://patchwork.freedesktop.org/series/119086/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v3 1/4] PCI/VGA: tidy up the code and comment format

2023-06-08 Thread Bjorn Helgaas
Capitalize subject to match ("Tidy ...") On Thu, Jun 08, 2023 at 07:43:19PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > This patch replaces the leading space with a tab and removes the double > blank line, no functional change. Can you move this to the end of the series? The

Re: [Intel-gfx] [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-06-08 Thread Dong, Zhanjun
> -Original Message- > From: Teres Alexis, Alan Previn > Sent: June 8, 2023 2:31 PM > To: Dong, Zhanjun ; intel- > g...@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org > Subject: Re: [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes > before selftests > > On Thu,

Re: [Intel-gfx] [PATCH] drm/i915/gsc: Fix error code in intel_gsc_uc_heci_cmd_submit_nonpriv()

2023-06-08 Thread Teres Alexis, Alan Previn
On Thu, 2023-06-08 at 11:37 +0300, Dan Carpenter wrote: > On Wed, Jun 07, 2023 at 06:44:54PM +, Teres Alexis, Alan Previn wrote: > > On Tue, 2023-06-06 at 21:32 +0300, Dan Carpenter wrote: > > > On Tue, Jun 06, 2023 at 06:07:19PM +, Teres Alexis, Alan Previn wrote: > > > > That was my bad,

[Intel-gfx] ✗ Fi.CI.BUILD: failure for fdinfo memory stats

2023-06-08 Thread Patchwork
== Series Details == Series: fdinfo memory stats URL : https://patchwork.freedesktop.org/series/119082/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M] drivers/gpu/drm/i915/gem/i915_gem_context.o In

Re: [Intel-gfx] [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-06-08 Thread Teres Alexis, Alan Previn
On Thu, 2023-06-08 at 18:14 +, Dong, Zhanjun wrote: > See my comments below. > > > -Original Message- > > From: Alan Previn alan:snip > > +static int > > +__wait_gsc_proxy_completed(struct drm_i915_private *i915, > > + unsigned long timeout_ms) > > +{ > > +

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: implement internal workqueues (rev4)

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915: implement internal workqueues (rev4) URL : https://patchwork.freedesktop.org/series/118947/ State : success == Summary == CI Bug Log - changes from CI_DRM_13252 -> Patchwork_118947v4 Summary ---

Re: [Intel-gfx] [PATCH v1] drm/i915/gsc: take a wakeref for the proxy-init-completion check

2023-06-08 Thread Ceraolo Spurio, Daniele
On 6/8/2023 11:04 AM, Alan Previn wrote: Ensure intel_gsc_uc_fw_init_done and intel_gsc_uc_fw_proxy_init takes a wakeref before reading GSC Shim registers. NOTE: another patch in review also adds a call from selftest to this same function. (https://patchwork.freedesktop.org/series/117713/)

Re: [Intel-gfx] [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-06-08 Thread Dong, Zhanjun
See my comments below. > -Original Message- > From: Alan Previn > Sent: May 30, 2023 1:01 PM > To: intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org; Alan Previn > > Subject: [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before > selftests > > On MTL,

[Intel-gfx] [PATCH v1] drm/i915/gsc: take a wakeref for the proxy-init-completion check

2023-06-08 Thread Alan Previn
Ensure intel_gsc_uc_fw_init_done and intel_gsc_uc_fw_proxy_init takes a wakeref before reading GSC Shim registers. NOTE: another patch in review also adds a call from selftest to this same function. (https://patchwork.freedesktop.org/series/117713/) which is why i am adding the wakeref inside the

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: implement internal workqueues (rev4)

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915: implement internal workqueues (rev4) URL : https://patchwork.freedesktop.org/series/118947/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement internal workqueues (rev4)

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915: implement internal workqueues (rev4) URL : https://patchwork.freedesktop.org/series/118947/ State : warning == Summary == Error: dim checkpatch failed 4fef60b7a41e drm/i915: use pointer to i915 instead of rpm in wakeref a5ce4ea23a6e drm/i915: add a

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Record which clients own a VM

2023-06-08 Thread kernel test robot
Hi Tvrtko, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Tvrtko-Ursulin/drm-i915-Track-buffer-objects-belonging-to-clients/20230608-225344 base: git://anongit.freedesktop.org/drm/drm-tip

[Intel-gfx] ✓ Fi.CI.IGT: success for x86/mm: Fix PAT bit missing from page protection modify mask (rev2)

2023-06-08 Thread Patchwork
== Series Details == Series: x86/mm: Fix PAT bit missing from page protection modify mask (rev2) URL : https://patchwork.freedesktop.org/series/116883/ State : success == Summary == CI Bug Log - changes from CI_DRM_13245_full -> Patchwork_116883v2_full

Re: [Intel-gfx] [v3] drm/i915/mtl: Add new vswing table for C20 phy to support DP 1.4

2023-06-08 Thread Sripada, Radhakrishna
> -Original Message- > From: Lee, Shawn C > Sent: Wednesday, June 7, 2023 11:02 PM > To: intel-gfx@lists.freedesktop.org > Cc: Lee, Shawn C ; Kahola, Mika > ; Taylor, Clinton A ; > Sripada, Radhakrishna ; Shankar, Uma > > Subject: [v3] drm/i915/mtl: Add new vswing table for C20 phy to

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Include of display limits doesn't need 'display/'

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915/display: Include of display limits doesn't need 'display/' URL : https://patchwork.freedesktop.org/series/119018/ State : success == Summary == CI Bug Log - changes from CI_DRM_13245_full -> Patchwork_119018v1_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for PCI/VGA: introduce is_boot_device function callback to vga_client_register

2023-06-08 Thread Patchwork
== Series Details == Series: PCI/VGA: introduce is_boot_device function callback to vga_client_register URL : https://patchwork.freedesktop.org/series/119068/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13250 -> Patchwork_119068v1

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mst: Make sure all resources are freed for MST topology manager before destroy

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915/mst: Make sure all resources are freed for MST topology manager before destroy URL : https://patchwork.freedesktop.org/series/119010/ State : success == Summary == CI Bug Log - changes from CI_DRM_13245_full -> Patchwork_119010v1_full

[Intel-gfx] [PULL] drm-intel-gt-next

2023-06-08 Thread Tvrtko Ursulin
Hi Dave, Daniel, Here goes the final pull request for 6.5. A few improvements to robustness of dealing with GuC communication issues, compute applications, small BAR systems perf/OA monitoring. Then a little bit more of Meteorlake enablement which this time round includes the HuC loading code,

[Intel-gfx] [PATCH 3/4] drm/i915: move display device and runtime info to struct intel_display

2023-06-08 Thread Jani Nikula
Continue moving all things display further into display files and structures. Cc: Matt Roper Cc: Lucas De Marchi Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_core.h | 9 + drivers/gpu/drm/i915/i915_drv.h | 5 ++---

[Intel-gfx] [PATCH 4/4] drm/i915: make device info a const pointer to rodata

2023-06-08 Thread Jani Nikula
Finally we can get rid of the pseudo-const write-once device info, and convert it into a const pointer to device info in rodata. Cc: Matt Roper Cc: Lucas De Marchi Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- drivers/gpu/drm/i915/intel_device_info.c | 17

[Intel-gfx] [PATCH 2/4] drm/i915: fix display info usage

2023-06-08 Thread Jani Nikula
Prefer DISPLAY_INFO() over INTEL_INFO()->display. Cc: Matt Roper Cc: Lucas De Marchi Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.h

[Intel-gfx] [PATCH 1/4] drm/i915: separate display info printing from the rest

2023-06-08 Thread Jani Nikula
Add new function intel_display_device_info_print() and print the display device info there instead of intel_device_info_print(). This also fixes the display runtime info printing to use the actual runtime info instead of the static defaults. Cc: Matt Roper Cc: Lucas De Marchi Signed-off-by:

[Intel-gfx] [PATCH 0/4] drm/i915: further device info cleanups

2023-06-08 Thread Jani Nikula
Building on Matt's display info separation, we can finally trivially make device info a const pointer to rodata. BR, Jani. Cc: Matt Roper Cc: Lucas De Marchi Jani Nikula (4): drm/i915: separate display info printing from the rest drm/i915: fix display info usage drm/i915: move display

[Intel-gfx] [PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-06-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver specific fdinfo output. To collect the stats we walk the per memory regions object lists and accumulate object size into the respective drm_memory_stats categories.

[Intel-gfx] [PATCH 2/5] drm/i915: Record which clients own a VM

2023-06-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To enable accounting of indirect client memory usage (such as page tables) in the following patch, lets start recording the creator of each PPGTT. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11 ---

[Intel-gfx] [PATCH 4/5] drm/i915: Account ring buffer and context state storage

2023-06-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account ring buffers and logical context space against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 ++ drivers/gpu/drm/i915/i915_drm_client.c | 10 ++

[Intel-gfx] [PATCH v2 0/5] fdinfo memory stats

2023-06-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Second try, this time actually per client! :) I added tracking of most classes of objects which contribute to clients memory footprint and accouting along the similar lines as in Rob's msm code. Then printing it out to fdinfo using the drm helper Rob added. Example fdinfo

[Intel-gfx] [PATCH 3/5] drm/i915: Track page table backing store usage

2023-06-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account page table backing store against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gtt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c

[Intel-gfx] [PATCH 1/5] drm/i915: Track buffer objects belonging to clients

2023-06-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In order to show per client memory usage lets start tracking which objects belong to which clients. We start with objects explicitly created by object creation UAPI and track it on a new per client lists, protected by a new per client lock. In order for delayed destruction

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: copy-paste the extra warnings from scripts/Makefile.extrawarn

2023-06-08 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: copy-paste the extra warnings from scripts/Makefile.extrawarn URL : https://patchwork.freedesktop.org/series/119067/ State : success == Summary == CI Bug Log - changes from CI_DRM_13250 -> Patchwork_119067v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915: copy-paste the extra warnings from scripts/Makefile.extrawarn

2023-06-08 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: copy-paste the extra warnings from scripts/Makefile.extrawarn URL : https://patchwork.freedesktop.org/series/119067/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit

Re: [Intel-gfx] [RFC 02/10] drm: Update file owner during use

2023-06-08 Thread Tvrtko Ursulin
On 21/04/2023 13:13, Emil Velikov wrote: Greetings everyone, Above all - hell yeah. Thank you Tvrtko, this has been annoying the hell out of me for ages. Yay! On Tue, 14 Mar 2023 at 14:19, Tvrtko Ursulin wrote: From: Tvrtko Ursulin With the typical model where the display server

Re: [Intel-gfx] [PATCH v6 2/3] drm/i915: add a dedicated workqueue inside drm_i915_private

2023-06-08 Thread Tetsuo Handa
On 2023/06/08 22:35, Jani Nikula wrote: > From: Luca Coelho > > In order to avoid flush_scheduled_work() usage, add a dedicated > workqueue in the drm_i915_private structure. In this way, we don't > need to use the system queue anymore. > > This change is mostly mechanical and based on

Re: [Intel-gfx] [PATCH v6 2/3] drm/i915: add a dedicated workqueue inside drm_i915_private

2023-06-08 Thread Tvrtko Ursulin
On 08/06/2023 14:35, Jani Nikula wrote: From: Luca Coelho In order to avoid flush_scheduled_work() usage, add a dedicated workqueue in the drm_i915_private structure. In this way, we don't need to use the system queue anymore. This change is mostly mechanical and based on Tetsuo's original

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix a VMA UAF for multi-gt platform (rev6)

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915: Fix a VMA UAF for multi-gt platform (rev6) URL : https://patchwork.freedesktop.org/series/118887/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13250 -> Patchwork_118887v6 Summary

[Intel-gfx] [PATCH v6 2/3] drm/i915: add a dedicated workqueue inside drm_i915_private

2023-06-08 Thread Jani Nikula
From: Luca Coelho In order to avoid flush_scheduled_work() usage, add a dedicated workqueue in the drm_i915_private structure. In this way, we don't need to use the system queue anymore. This change is mostly mechanical and based on Tetsuo's original patch[1]. v6 by Jani: - Also create

[Intel-gfx] [PATCH v6 0/3] drm/i915: implement internal workqueues

2023-06-08 Thread Jani Nikula
This is v6 of [1], creating i915->unordered_wq also for mock devices. BR, Jani. [1] https://patchwork.freedesktop.org/series/118947/ Luca Coelho (3): drm/i915: use pointer to i915 instead of rpm in wakeref drm/i915: add a dedicated workqueue inside drm_i915_private drm/i915/selftests:

[Intel-gfx] [PATCH v6 1/3] drm/i915: use pointer to i915 instead of rpm in wakeref

2023-06-08 Thread Jani Nikula
From: Luca Coelho Currently a pointer to an intel_runtime_pm structure is stored in the wake reference structures so the runtime data can be accessed. We can save the entire device information (drm_i915_private) instead, since we'll need to reference the new workqueue we'll add in subsequent

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915/selftests: add local workqueue for SW fence selftest

2023-06-08 Thread Tetsuo Handa
On 2023/06/08 22:35, Jani Nikula wrote: > From: Luca Coelho > > Instead of using a global workqueue for the SW fence selftest, > allocate a separate one temporarily only while running the test. > > Cc: Tetsuo Handa > Cc: Jani Nikula > Cc: Ville Syrjälä > Reviewed-by: Tvrtko Ursulin >

[Intel-gfx] [PATCH v6 3/3] drm/i915/selftests: add local workqueue for SW fence selftest

2023-06-08 Thread Jani Nikula
From: Luca Coelho Instead of using a global workqueue for the SW fence selftest, allocate a separate one temporarily only while running the test. Cc: Tetsuo Handa Cc: Jani Nikula Cc: Ville Syrjälä Reviewed-by: Tvrtko Ursulin Signed-off-by: Luca Coelho Signed-off-by: Jani Nikula ---

Re: [Intel-gfx] [PATCH v2] x86/mm: Fix PAT bit missing from page protection modify mask

2023-06-08 Thread Janusz Krzysztofik
On Thursday, 8 June 2023 00:47:36 CEST Edgecombe, Rick P wrote: > On Wed, 2023-06-07 at 23:33 +0200, Janusz Krzysztofik wrote: > > > So since _PAGE_PSE is actually the same value as _PAGE_PAT, you > > > don't > > > actually need to have _PAGE_PSE in _HPAGE_CHG_MASK in order to get > > > functional

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Fix spelling mistake "initate" -> "initiate"

2023-06-08 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Fix spelling mistake "initate" -> "initiate" URL : https://patchwork.freedesktop.org/series/119063/ State : success == Summary == CI Bug Log - changes from CI_DRM_13249 -> Patchwork_119063v1

[Intel-gfx] ✓ Fi.CI.BAT: success for fbcon: Reschedule cursor worker if try lock fails

2023-06-08 Thread Patchwork
== Series Details == Series: fbcon: Reschedule cursor worker if try lock fails URL : https://patchwork.freedesktop.org/series/119060/ State : success == Summary == CI Bug Log - changes from CI_DRM_13249 -> Patchwork_119060v1 Summary

  1   2   >