Re: [Intel-gfx] [PATCH 2/2] drm/i915/hdcp: Use correct aux for capability check scenario

2023-08-30 Thread Shankar, Uma
> -Original Message- > From: Kandpal, Suraj > Sent: Wednesday, August 30, 2023 1:05 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nautiyal, Ankit K ; Shankar, Uma > ; Murthy, Arun R ; Kandpal, > Suraj > Subject: [PATCH 2/2] drm/i915/hdcp: Use correct aux for capability check >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Use intel_connector as argument for hdcp_2_2_capable

2023-08-30 Thread Shankar, Uma
> -Original Message- > From: Kandpal, Suraj > Sent: Wednesday, August 30, 2023 1:05 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nautiyal, Ankit K ; Shankar, Uma > ; Murthy, Arun R ; Kandpal, > Suraj > Subject: [PATCH 1/2] drm/i915/hdcp: Use intel_connector as argument for >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: add minimal i915_gem_object_frontbuffer.h (rev2)

2023-08-30 Thread Patchwork
== Series Details == Series: drm/i915: add minimal i915_gem_object_frontbuffer.h (rev2) URL : https://patchwork.freedesktop.org/series/123057/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13577_full -> Patchwork_123057v2_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/dp: Drop redundant AUX power get/put in intel_dp_force()

2023-08-30 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp: Drop redundant AUX power get/put in intel_dp_force() URL : https://patchwork.freedesktop.org/series/123067/ State : success == Summary == CI Bug Log - changes from CI_DRM_13577_full -> Patchwork_123067v1_full

[Intel-gfx] [PATCH i-g-t] tests/i915_pm_freq_api: Test s2idle instead of S3

2023-08-30 Thread Vinay Belgaumkar
Test skips whenever S3 is not supported, use s2idle instead, which is widely enabled. Cc: Anshuman Gupta Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/i915/i915_pm_freq_api.c

Re: [Intel-gfx] [PATCH] drm/i915: Add Wa_14015150844

2023-08-30 Thread Matt Roper
On Wed, Aug 30, 2023 at 09:30:01PM +0530, Shekhar Chauhan wrote: > Disables Atomic-chaining of Typed Writes. > > BSpec: 54040 > Signed-off-by: Shekhar Chauhan > --- > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 ++ > drivers/gpu/drm/i915/gt/intel_workarounds.c | 10 ++ > 2 files

Re: [Intel-gfx] [PATCH v4 0/6] drm/i915/dp_link_training: Define a final failure state when link training fails

2023-08-30 Thread Lyude Paul
Other then the name typo (s/Pual/Paul): Signed-off-by: Lyude Paul (just since I co-authored things~) Reviewed-by: Lyude Paul I think we definitely want to make sure we get intel's opinions on this though, especially regarding the usage of link-status. I think we're close enough to

Re: [Intel-gfx] [PATCH v4 3/6] drm/dp_mst: Add drm_dp_set_mst_topology_link_status()

2023-08-30 Thread Lyude Paul
On Thu, 2023-08-24 at 16:50 -0400, Gil Dekel wrote: > Unlike SST, MST can support multiple displays connected to a single > connector. However, this also means that if the DisplayPort link to the > top-level MST branch device becomes unstable, then every single branch > device has an unstable

Re: [Intel-gfx] [PATCH 2/2] drm/i915/mtl: Add TC port lockdep assert to AUX power well enabling

2023-08-30 Thread Rodrigo Vivi
On Wed, Aug 30, 2023 at 05:04:21PM +0300, Imre Deak wrote: > Similarly to earlier platforms, assert in the MTL AUX power well > enabling handler for TC AUX CH power wells that the TC port using the > AUX CH is locked. > > Signed-off-by: Imre Deak Reviewed-by: Rodrigo Vivi > --- >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp: Drop redundant AUX power get/put in intel_dp_force()

2023-08-30 Thread Rodrigo Vivi
On Wed, Aug 30, 2023 at 05:04:20PM +0300, Imre Deak wrote: > intel_dp_force() takes the AUX power reference as required by the DP AUX > transactions in intel_dp_set_edid(). However the low level AUX handler you mean intel_dp_aux_xfer right? > takes this reference already so the get/put in

Re: [Intel-gfx] [PATCH v2 09/22] drm/dp_mst: Fix fractional bpp scaling in drm_dp_calc_pbn_mode()

2023-08-30 Thread Lyude Paul
Amazing! This work looks awesome Imre, sorry it took me a little bit to get back to this :). For all of the DP MST helper patches: Reviewed-by: Lyude Paul On Thu, 2023-08-24 at 11:05 +0300, Imre Deak wrote: > For fractional bpp values passed to the function in a .4 fixed point > format, the

Re: [Intel-gfx] [RFC 00/33] Add Support for Plane Color Pipeline

2023-08-30 Thread Sebastian Wick
On Wed, Aug 30, 2023 at 08:47:37AM +, Shankar, Uma wrote: > > > > -Original Message- > > From: Harry Wentland > > Sent: Wednesday, August 30, 2023 12:56 AM > > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; > > dri- > > de...@lists.freedesktop.org > > Cc:

Re: [Intel-gfx] [PATCH v4 16/29] KVM: x86: Reject memslot MOVE operations if KVMGT is attached

2023-08-30 Thread Sean Christopherson
On Wed, Aug 30, 2023, Like Xu wrote: > On 2023/7/29 09:35, Sean Christopherson wrote: > > Disallow moving memslots if the VM has external page-track users, i.e. if > > KVMGT is being used to expose a virtual GPU to the guest, as KVMGT doesn't > > correctly handle moving memory regions. > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: add minimal i915_gem_object_frontbuffer.h (rev2)

2023-08-30 Thread Patchwork
== Series Details == Series: drm/i915: add minimal i915_gem_object_frontbuffer.h (rev2) URL : https://patchwork.freedesktop.org/series/123057/ State : success == Summary == CI Bug Log - changes from CI_DRM_13577 -> Patchwork_123057v2

Re: [Intel-gfx] WQ_UNBOUND warning since recent workqueue refactoring

2023-08-30 Thread Imre Deak
On Wed, Aug 30, 2023 at 07:51:13AM -1000, Tejun Heo wrote: Hi, > Hello, > > (cc'ing i915 folks) > > On Wed, Aug 30, 2023 at 04:57:42PM +0200, Heiner Kallweit wrote: > > Recently I started to see the following warning on linux-next and presumably > > this may be related to the refactoring of the

Re: [Intel-gfx] [PATCH] drm/i915: Add Wa_14015150844

2023-08-30 Thread kernel test robot
Hi Shekhar, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Shekhar-Chauhan/drm-i915-Add-Wa_14015150844/20230831-000233 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link:

Re: [Intel-gfx] [PATCH] drm/i915: Add Wa_14015150844

2023-08-30 Thread kernel test robot
Hi Shekhar, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Shekhar-Chauhan/drm-i915-Add-Wa_14015150844/20230831-000233 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/dp: Drop redundant AUX power get/put in intel_dp_force()

2023-08-30 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp: Drop redundant AUX power get/put in intel_dp_force() URL : https://patchwork.freedesktop.org/series/123067/ State : success == Summary == CI Bug Log - changes from CI_DRM_13577 -> Patchwork_123067v1

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Add Wa_14015150844

2023-08-30 Thread Patchwork
== Series Details == Series: drm/i915: Add Wa_14015150844 URL : https://patchwork.freedesktop.org/series/123074/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M]

Re: [Intel-gfx] WQ_UNBOUND warning since recent workqueue refactoring

2023-08-30 Thread Tejun Heo
Hello, (cc'ing i915 folks) On Wed, Aug 30, 2023 at 04:57:42PM +0200, Heiner Kallweit wrote: > Recently I started to see the following warning on linux-next and presumably > this may be related to the refactoring of the workqueue core code. > > [ 56.900223] workqueue: output_poll_execute

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/dp: Drop redundant AUX power get/put in intel_dp_force()

2023-08-30 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp: Drop redundant AUX power get/put in intel_dp_force() URL : https://patchwork.freedesktop.org/series/123067/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✗ Fi.CI.IGT: failure for Handle dma fences in dirtyfb ioctl (rev5)

2023-08-30 Thread Patchwork
== Series Details == Series: Handle dma fences in dirtyfb ioctl (rev5) URL : https://patchwork.freedesktop.org/series/116620/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13575_full -> Patchwork_116620v5_full Summary

Re: [Intel-gfx] [PATCH v6 0/4] drm: Use full allocated minor range for DRM

2023-08-30 Thread James Zhu
PATCH 1 and 3 are Tested-by:JamesZhu Best Regards! James Zhu On 2023-07-24 17:14, Michał Winiarski wrote: 64 DRM device nodes is not enough for everyone. Upgrade it to ~512K (which definitely is more than enough). To allow testing userspace support for >64 devices, add additional DRM

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: add minimal i915_gem_object_frontbuffer.h

2023-08-30 Thread Patchwork
== Series Details == Series: drm/i915: add minimal i915_gem_object_frontbuffer.h URL : https://patchwork.freedesktop.org/series/123057/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13575_full -> Patchwork_123057v1_full

[Intel-gfx] [PATCH] drm/i915: Add Wa_14015150844

2023-08-30 Thread Shekhar Chauhan
Disables Atomic-chaining of Typed Writes. BSpec: 54040 Signed-off-by: Shekhar Chauhan --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 ++ drivers/gpu/drm/i915/gt/intel_workarounds.c | 10 ++ 2 files changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add DSC PPS readout (rev12)

2023-08-30 Thread Patchwork
== Series Details == Series: Add DSC PPS readout (rev12) URL : https://patchwork.freedesktop.org/series/120456/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13569_full -> Patchwork_120456v12_full Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for kunit: Fix test log size limit too low for some tests

2023-08-30 Thread Patchwork
== Series Details == Series: kunit: Fix test log size limit too low for some tests URL : https://patchwork.freedesktop.org/series/123055/ State : success == Summary == CI Bug Log - changes from CI_DRM_13575_full -> Patchwork_123055v1_full

[Intel-gfx] [PATCH 2/2] drm/i915/mtl: Add TC port lockdep assert to AUX power well enabling

2023-08-30 Thread Imre Deak
Similarly to earlier platforms, assert in the MTL AUX power well enabling handler for TC AUX CH power wells that the TC port using the AUX CH is locked. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_display_power_well.c | 5 + 1 file changed, 5 insertions(+) diff --git

[Intel-gfx] [PATCH 1/2] drm/i915/dp: Drop redundant AUX power get/put in intel_dp_force()

2023-08-30 Thread Imre Deak
intel_dp_force() takes the AUX power reference as required by the DP AUX transactions in intel_dp_set_edid(). However the low level AUX handler takes this reference already so the get/put in intel_dp_force() can be dropped. This also fixes a problem where the TC port mode changed while the AUX

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/cx0: Check and increase msgbus timeout threshold (rev2)

2023-08-30 Thread Patchwork
== Series Details == Series: drm/i915/cx0: Check and increase msgbus timeout threshold (rev2) URL : https://patchwork.freedesktop.org/series/122982/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13576 -> Patchwork_122982v2

Re: [Intel-gfx] [PATCH] drm/i915: mark requests for GuC virtual engines to avoid use-after-free

2023-08-30 Thread Andi Shyti
Hi Andrzej, On Mon, Aug 21, 2023 at 05:30:35PM +0200, Andrzej Hajda wrote: > References to i915_requests may be trapped by userspace inside a > sync_file or dmabuf (dma-resv) and held indefinitely across different > proceses. To counter-act the memory leaks, we try to not to keep > references

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/cx0: Check and increase msgbus timeout threshold (rev2)

2023-08-30 Thread Patchwork
== Series Details == Series: drm/i915/cx0: Check and increase msgbus timeout threshold (rev2) URL : https://patchwork.freedesktop.org/series/122982/ State : warning == Summary == Error: dim checkpatch failed cf32144e3989 drm/i915/cx0: Check and increase msgbus timeout threshold -:109:

[Intel-gfx] ✓ Fi.CI.IGT: success for Fix HDCP2 capability check

2023-08-30 Thread Patchwork
== Series Details == Series: Fix HDCP2 capability check URL : https://patchwork.freedesktop.org/series/123053/ State : success == Summary == CI Bug Log - changes from CI_DRM_13575_full -> Patchwork_123053v1_full Summary ---

Re: [Intel-gfx] [RFC 02/33] drm: Add color operation structure

2023-08-30 Thread Pekka Paalanen
On Tue, 29 Aug 2023 21:33:51 +0530 Uma Shankar wrote: > From: Chaitanya Kumar Borah > > Each Color Hardware block will be represented uniquely > in the color pipeline. Define the structure to represent > the same. > > These color operations will form the building blocks of > a color pipeline

Re: [Intel-gfx] [RFC 01/33] drm/doc/rfc: Add RFC document for proposed Plane Color Pipeline

2023-08-30 Thread Pekka Paalanen
On Wed, 30 Aug 2023 08:59:36 + "Shankar, Uma" wrote: > > -Original Message- > > From: Harry Wentland > > Sent: Wednesday, August 30, 2023 1:10 AM > > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; > > dri- > > de...@lists.freedesktop.org > > Cc: Borah, Chaitanya Kumar ;

Re: [Intel-gfx] [PATCH] drm/i915/cx0: Check and increase msgbus timeout threshold

2023-08-30 Thread Gustavo Sousa
Quoting Gustavo Sousa (2023-08-29 08:45:41-03:00) >Quoting Kahola, Mika (2023-08-29 06:35:17-03:00) >>> -Original Message- >>> From: Intel-gfx On Behalf Of >>> Sripada, Radhakrishna >>> Sent: Tuesday, August 29, 2023 1:54 AM >>> To: Sousa, Gustavo ; >>> intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH] drm/i915/cx0: Check and increase msgbus timeout threshold

2023-08-30 Thread Gustavo Sousa
Quoting Jani Nikula (2023-08-29 12:12:19-03:00) >On Mon, 28 Aug 2023, Gustavo Sousa wrote: +#define INTEL_CX0_MSGBUS_TIMER_VAL_MAX0x200 > >Either make this 0x200U (for unsigned)... > + bool intel_is_c10phy(struct drm_i915_private *i915, enum phy phy) {

[Intel-gfx] [PATCH v2] drm/i915/cx0: Check and increase msgbus timeout threshold

2023-08-30 Thread Gustavo Sousa
We have experienced timeout issues when going through the sequence to access C20 SRAM registers. Experimentation showed that bumping the message bus timer threshold helped on getting display Type-C connection on the C20 PHY to work. While the timeout is still under investigation with the HW team,

Re: [Intel-gfx] [PATCH 12/12] drm/i915/sdvo: Constify mapping structs

2023-08-30 Thread Jani Nikula
On Tue, 29 Aug 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > We aren't intending to mutate the SDVO device mapping structs, > so make them const. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_sdvo.c | 6 +++--- > 1 file changed,

Re: [Intel-gfx] [PATCH 09/12] drm/i915/hdmi: Use connector->ddc everwhere

2023-08-30 Thread Jani Nikula
On Tue, 29 Aug 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > We already populate connector->ddc for HDMI ports, but > so far we've not taken full advantage of it. Do that by > eliminating a bunch of intel_gmbus_get_adapter() lookups. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani

Re: [Intel-gfx] [PATCH 08/12] drm/i915/mst: Populate connector->ddc

2023-08-30 Thread Jani Nikula
On Tue, 29 Aug 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Populate connector->ddc, and thus create the "ddc" symlink > in sysfs for DP MST connectors. > > TODO: test that this actually works :) Seems legit, Reviewed-by: Jani Nikula > > References:

Re: [Intel-gfx] [PATCH 07/12] drm/i915/dp: Populate connector->ddc

2023-08-30 Thread Jani Nikula
On Tue, 29 Aug 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Populate connector->ddc, and thus create the "ddc" symlink > in sysfs for analog DP SST connectors. > > Let's also reorder intel_dp_aux_init() vs. drm_connector_init_with_ddc() > a bit to make sure the i2c aux ch is at least

Re: [Intel-gfx] [PATCH 06/12] drm/i915/dvo: Populate connector->ddc

2023-08-30 Thread Jani Nikula
On Tue, 29 Aug 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Populate connector->ddc, and thus create the "ddc" symlink > in sysfs for DVO connectors. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_dvo.c | 11 +-- > 1 file

Re: [Intel-gfx] [PATCH 05/12] drm/i915/crt: Populate connector->ddc

2023-08-30 Thread Jani Nikula
On Tue, 29 Aug 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Populate connector->ddc, and thus create the "ddc" symlink > in sysfs for analog VGA connectors. > > As a bonus we can replace a bunch of intel_gmbus_get_adapter() > lookups with just the connector->ddc pointer. Sadly one extra

Re: [Intel-gfx] [PATCH 04/12] drm/i915/lvds: Populate connector->ddc

2023-08-30 Thread Jani Nikula
On Tue, 29 Aug 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Populate connector->ddc, and thus create the "ddc" symlink > in sysfs for the LVDS port. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_lvds.c | 23

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Call the DDC bus i2c adapter "ddc"

2023-08-30 Thread Jani Nikula
On Wed, 30 Aug 2023, Jani Nikula wrote: > On Tue, 29 Aug 2023, Ville Syrjala wrote: >> From: Ville Syrjälä >> @@ -2452,24 +2447,24 @@ intel_hdmi_set_edid(struct drm_connector *connector) >> { >> struct drm_i915_private *dev_priv = to_i915(connector->dev); >> struct intel_hdmi

Re: [Intel-gfx] [PATCH 2/2] drivers/drm/i915: Honor limits->max_bpp while computing DSC max input bpp

2023-08-30 Thread Jani Nikula
On Thu, 24 Aug 2023, Ankit Nautiyal wrote: > Edid specific BPC constraints are stored in limits->max_bpp. Honor these > limits while computing the input bpp for DSC. > > v2: Use int instead of u8 for computations. (Jani) > Add closes tag. (Ankit) > > Closes:

Re: [Intel-gfx] [1/2] drm/display/dp: Assume 8 bpc support when DSC is supported

2023-08-30 Thread Jani Nikula
On Wed, 30 Aug 2023, "Lisovskiy, Stanislav" wrote: > On Thu, Aug 24, 2023 at 06:21:20PM +0530, Ankit Nautiyal wrote: >> As per DP v1.4, a DP DSC Sink device shall support 8bpc in DPCD 6Ah. >> Apparently some panels that do support DSC, are not setting the bit for >> 8bpc. >> >> So always assume

Re: [Intel-gfx] [PATCH 02/12] drm/sysfs: Register "ddc" symlink later

2023-08-30 Thread Jani Nikula
On Tue, 29 Aug 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently drm_sysfs_connector_add() attempts to register > the "ddc" symlink (based one connector->ddc) before the > driver's .early_register() hook has been called. That is > too early for i915 which only fully registers the

Re: [Intel-gfx] [PATCH 01/12] drm: Reorder drm_sysfs_connector_remove() vs. drm_debugfs_connector_remove()

2023-08-30 Thread Jani Nikula
On Tue, 29 Aug 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Use the standard onion peeling approach and call > drm_debugfs_connector_remove() and > drm_sysfs_connector_remove() in the reverse order in > drm_connector_unregister() than what we called their > add counterpartse in

Re: [Intel-gfx] [RFC PATCH] kunit: Fix test log size limit too low for some tests

2023-08-30 Thread Janusz Krzysztofik
On Wednesday, 30 August 2023 11:23:43 CEST David Gow wrote: > On Wed, 30 Aug 2023 at 15:55, Janusz Krzysztofik > wrote: > > > > Now we have memory space available to a kunit test case log exposed via > > debugfs limited to 2048 bytes, while some parametrized test cases, e.g., > >

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Call the DDC bus i2c adapter "ddc"

2023-08-30 Thread Jani Nikula
On Tue, 29 Aug 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Rename the various names we've used for the DDC bus > i2c adapter ("i2c", "adapter", etc.) to just "ddc". > This differentiates it from the various other i2c > busses we might have (DSI panel stuff, DVO control bus, etc.). > >

[Intel-gfx] ✓ Fi.CI.BAT: success for Handle dma fences in dirtyfb ioctl (rev5)

2023-08-30 Thread Patchwork
== Series Details == Series: Handle dma fences in dirtyfb ioctl (rev5) URL : https://patchwork.freedesktop.org/series/116620/ State : success == Summary == CI Bug Log - changes from CI_DRM_13575 -> Patchwork_116620v5 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Handle dma fences in dirtyfb ioctl (rev5)

2023-08-30 Thread Patchwork
== Series Details == Series: Handle dma fences in dirtyfb ioctl (rev5) URL : https://patchwork.freedesktop.org/series/116620/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid

2023-08-30 Thread Jani Nikula
On Wed, 30 Aug 2023, Hans Verkuil wrote: > On 24/08/2023 15:46, Jani Nikula wrote: >> Connectors have source physical address available in display >> info. There's no need to parse the EDID again for this. Add >> drm_dp_cec_attach() to do this. >> >> Seems like the set_edid/unset_edid naming is

Re: [Intel-gfx] [PATCH] drm/i915: add minimal i915_gem_object_frontbuffer.h

2023-08-30 Thread Hogander, Jouni
On Wed, 2023-08-30 at 11:51 +0300, Jani Nikula wrote: > Split out frontbuffer related declarations and static inlines from > gem/i915_gem_object.h into new gem/i915_gem_object_frontbuffer.h. > > The main goal is to reduce header interdependencies. With > gem/i915_gem_object.h including

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: add minimal i915_gem_object_frontbuffer.h

2023-08-30 Thread Patchwork
== Series Details == Series: drm/i915: add minimal i915_gem_object_frontbuffer.h URL : https://patchwork.freedesktop.org/series/123057/ State : success == Summary == CI Bug Log - changes from CI_DRM_13575 -> Patchwork_123057v1 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dg2: Add support for new DG2-G12 revid 0x1

2023-08-30 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add support for new DG2-G12 revid 0x1 URL : https://patchwork.freedesktop.org/series/123014/ State : success == Summary == CI Bug Log - changes from CI_DRM_13573_full -> Patchwork_123014v1_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: add minimal i915_gem_object_frontbuffer.h

2023-08-30 Thread Patchwork
== Series Details == Series: drm/i915: add minimal i915_gem_object_frontbuffer.h URL : https://patchwork.freedesktop.org/series/123057/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add minimal i915_gem_object_frontbuffer.h

2023-08-30 Thread Patchwork
== Series Details == Series: drm/i915: add minimal i915_gem_object_frontbuffer.h URL : https://patchwork.freedesktop.org/series/123057/ State : warning == Summary == Error: dim checkpatch failed 5ce75abe73af drm/i915: add minimal i915_gem_object_frontbuffer.h Traceback (most recent call

[Intel-gfx] ✓ Fi.CI.BAT: success for Add DSC PPS readout (rev12)

2023-08-30 Thread Patchwork
== Series Details == Series: Add DSC PPS readout (rev12) URL : https://patchwork.freedesktop.org/series/120456/ State : success == Summary == CI Bug Log - changes from CI_DRM_13569 -> Patchwork_120456v12 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-30 Thread Daniel Vetter
On Wed, Aug 30, 2023 at 10:29:46AM +0300, Jani Nikula wrote: > Upstream code should be reviewed in public. Yup -Sima -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

[Intel-gfx] ✗ Fi.CI.BAT: failure for Handle dma fences in dirtyfb ioctl (rev4)

2023-08-30 Thread Patchwork
== Series Details == Series: Handle dma fences in dirtyfb ioctl (rev4) URL : https://patchwork.freedesktop.org/series/116620/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13575 -> Patchwork_116620v4 Summary ---

Re: [Intel-gfx] [RFC PATCH] kunit: Fix test log size limit too low for some tests

2023-08-30 Thread David Gow
On Wed, 30 Aug 2023 at 15:55, Janusz Krzysztofik wrote: > > Now we have memory space available to a kunit test case log exposed via > debugfs limited to 2048 bytes, while some parametrized test cases, e.g., > drm_framebuffer.drm_test_framebuffer_create, need more. For this reason, > debugfs

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Handle dma fences in dirtyfb ioctl (rev4)

2023-08-30 Thread Patchwork
== Series Details == Series: Handle dma fences in dirtyfb ioctl (rev4) URL : https://patchwork.freedesktop.org/series/116620/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for kunit: Fix test log size limit too low for some tests

2023-08-30 Thread Patchwork
== Series Details == Series: kunit: Fix test log size limit too low for some tests URL : https://patchwork.freedesktop.org/series/123055/ State : success == Summary == CI Bug Log - changes from CI_DRM_13575 -> Patchwork_123055v1 Summary

Re: [Intel-gfx] [RFC 01/33] drm/doc/rfc: Add RFC document for proposed Plane Color Pipeline

2023-08-30 Thread Shankar, Uma
> -Original Message- > From: Harry Wentland > Sent: Wednesday, August 30, 2023 1:10 AM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; > dri- > de...@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar ; wayland- > de...@lists.freedesktop.org > Subject: Re: [RFC 01/33]

[Intel-gfx] [PATCH] drm/i915: add minimal i915_gem_object_frontbuffer.h

2023-08-30 Thread Jani Nikula
Split out frontbuffer related declarations and static inlines from gem/i915_gem_object.h into new gem/i915_gem_object_frontbuffer.h. The main goal is to reduce header interdependencies. With gem/i915_gem_object.h including display/intel_frontbuffer.h, modification of the latter causes a whopping

Re: [Intel-gfx] [RFC 00/33] Add Support for Plane Color Pipeline

2023-08-30 Thread Shankar, Uma
> -Original Message- > From: Harry Wentland > Sent: Wednesday, August 30, 2023 12:56 AM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; > dri- > de...@lists.freedesktop.org > Cc: wayland-de...@lists.freedesktop.org; Ville Syrjala > ; Pekka Paalanen > ; > Simon Ser ; Melissa Wen

[Intel-gfx] ✓ Fi.CI.BAT: success for Fix HDCP2 capability check

2023-08-30 Thread Patchwork
== Series Details == Series: Fix HDCP2 capability check URL : https://patchwork.freedesktop.org/series/123053/ State : success == Summary == CI Bug Log - changes from CI_DRM_13575 -> Patchwork_123053v1 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fix HDCP2 capability check

2023-08-30 Thread Patchwork
== Series Details == Series: Fix HDCP2 capability check URL : https://patchwork.freedesktop.org/series/123053/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1:

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: Handle dma fences in dirtyfb callback

2023-08-30 Thread Hogander, Jouni
On Tue, 2023-08-29 at 12:30 +0300, Ville Syrjälä wrote: > On Thu, Jul 27, 2023 at 08:35:18AM +0300, Jouni Högander wrote: > > Take into account dma fences in dirtyfb callback. If there is no > > unsignaled dma fences perform flush immediately. If there are > > unsignaled dma fences perform

[Intel-gfx] [PATCH v3 2/4] drm/i915/psr: Clear frontbuffer busy bits on flip

2023-08-30 Thread Jouni Högander
We are planning to move flush performed from work queue. This means it is possible to have invalidate -> flip -> flush sequence. Handle this by clearing possible busy bits on flip. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 6 ++ 1 file changed, 6

[Intel-gfx] [PATCH v3 1/4] drm/i915/fbc: Clear frontbuffer busy bits on flip

2023-08-30 Thread Jouni Högander
We are planning to move flush performed from work queue. This means it is possible to have invalidate -> flip -> flush sequence. Handle this by clearing possible busy bits on flip. Signed-off-by: Ville Syrjälä Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_fbc.c | 6

[Intel-gfx] [PATCH v3 3/4] drm/i915: Add new frontbuffer tracking interface to queue flush

2023-08-30 Thread Jouni Högander
We want to wait dma fences in dirtyfb ioctl. As we don't want to make dirtyfb ioctl as blocking call we need to use dma_fence_add_callback. Callback used for dma_fence_add_callback is called from atomic context. Due to this we need to add a new frontbuffer tracking interface to queue flush. v3:

[Intel-gfx] [PATCH v3 0/4] Handle dma fences in dirtyfb ioctl

2023-08-30 Thread Jouni Högander
Currently i915 dirtyfb ioctl is not taking dma fences into account. This works with features like FBC, PSR, DRRS because our gem code is triggering flush again when rendering completes. We are targeting in getting rid of frontbuffer tracking code: Flusing hook from gem code will be removed as

[Intel-gfx] [PATCH v3 4/4] drm/i915: Handle dma fences in dirtyfb callback

2023-08-30 Thread Jouni Högander
Take into account dma fences in dirtyfb callback. If there is no unsignaled dma fences perform flush immediately. If there are unsignaled dma fences perform invalidate and add callback which will queue flush when the fence gets signaled. v3: - Check frontbuffer bits before adding any fence fb -

[Intel-gfx] [RFC PATCH] kunit: Fix test log size limit too low for some tests

2023-08-30 Thread Janusz Krzysztofik
Now we have memory space available to a kunit test case log exposed via debugfs limited to 2048 bytes, while some parametrized test cases, e.g., drm_framebuffer.drm_test_framebuffer_create, need more. For this reason, debugfs results from affected test cases get truncated silently, and external

Re: [Intel-gfx] [1/2] drm/display/dp: Assume 8 bpc support when DSC is supported

2023-08-30 Thread Lisovskiy, Stanislav
On Thu, Aug 24, 2023 at 06:21:20PM +0530, Ankit Nautiyal wrote: > As per DP v1.4, a DP DSC Sink device shall support 8bpc in DPCD 6Ah. > Apparently some panels that do support DSC, are not setting the bit for > 8bpc. > > So always assume 8bpc support by DSC decoder, when DSC is claimed to be >

[Intel-gfx] [PATCH 2/2] drm/i915/hdcp: Use correct aux for capability check scenario

2023-08-30 Thread Suraj Kandpal
Send the correct aux rather than the one derived from intel_digital_port so that the HDCP version of both monitors are fetched rather than just the primary one's Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 6 -- 1 file changed, 4 insertions(+), 2

[Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Use intel_connector as argument for hdcp_2_2_capable

2023-08-30 Thread Suraj Kandpal
Use intel_connector as argument instead of intel_digital_port in hdcp_2_2_capable function and dig_port can be later derived from connector. This will help with getting the correct hdcp version of particular monitor in a MST setup. Signed-off-by: Suraj Kandpal ---

[Intel-gfx] [PATCH 0/2] Fix HDCP2 capability check

2023-08-30 Thread Suraj Kandpal
In DP MST scenarios we derive the connector and in turn the aux from intel_digital_port which always gave the primary monitors aux, this caused the capability of the primary monitor to be checked twice rather than enumerating the different HDCP capabilities for each monitor because of this we saw

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Adjust seamless_m_n flag behaviour

2023-08-30 Thread Golani, Mitulkumar Ajitkumar
Hi Ville, > -Original Message- > From: Ville Syrjälä > Sent: 30 August 2023 12:29 > To: Golani, Mitulkumar Ajitkumar > > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 5/6] drm/i915: Adjust seamless_m_n flag > behaviour > > On Wed, Aug 30, 2023 at 06:51:25AM

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-30 Thread Jani Nikula
On Tue, 29 Aug 2023, Alex Hung wrote: > On 2023-08-29 11:03, Jani Nikula wrote: >> On Tue, 29 Aug 2023, Jani Nikula wrote: >>> On Tue, 29 Aug 2023, Alex Deucher wrote: On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula wrote: > > On Wed, 23 Aug 2023, Jani Nikula wrote: >> On Tue, 22

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Adjust seamless_m_n flag behaviour

2023-08-30 Thread Ville Syrjälä
On Wed, Aug 30, 2023 at 06:51:25AM +, Golani, Mitulkumar Ajitkumar wrote: > Hi Ville, > > > -Original Message- > > From: Ville Syrjälä > > Sent: 30 August 2023 10:47 > > To: Golani, Mitulkumar Ajitkumar > > > > Cc: intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Adjust seamless_m_n flag behaviour

2023-08-30 Thread Golani, Mitulkumar Ajitkumar
Hi Ville, > -Original Message- > From: Ville Syrjälä > Sent: 30 August 2023 10:47 > To: Golani, Mitulkumar Ajitkumar > > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 5/6] drm/i915: Adjust seamless_m_n flag > behaviour > > On Tue, Aug 29, 2023 at 01:48:18PM

Re: [Intel-gfx] [Intel-xe] [PATCH 3/4] drm/i915/lnl: support FBC on any plane

2023-08-30 Thread Ville Syrjälä
On Tue, Aug 29, 2023 at 09:04:28AM -0700, Matt Roper wrote: > On Tue, Aug 29, 2023 at 06:50:02AM -0700, Govindapillai, Vinod wrote: > > On Mon, 2023-08-28 at 17:16 -0700, Matt Roper wrote: > > > On Mon, Aug 28, 2023 at 09:20:34AM +0300, Vinod Govindapillai wrote: > > > > In LNL onwards, FBC can be