[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: Enable WA 14018913170

2023-10-05 Thread Patchwork
== Series Details == Series: drm/i915/guc: Enable WA 14018913170 URL : https://patchwork.freedesktop.org/series/124694/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13719 -> Patchwork_124694v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/guc: Enable WA 14018913170

2023-10-05 Thread Patchwork
== Series Details == Series: drm/i915/guc: Enable WA 14018913170 URL : https://patchwork.freedesktop.org/series/124694/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v7 1/5] drm/i915: Add GuC TLB Invalidation device info flags

2023-10-05 Thread John Harrison
On 10/5/2023 12:35, Jonathan Cavitt wrote: Add device info flags for if GuC TLB Invalidation is enabled. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_device_info.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)

Re: [Intel-gfx] [PATCH v7 2/5] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-05 Thread John Harrison
On 10/5/2023 12:35, Jonathan Cavitt wrote: From: Prathap Kumar Valsan The GuC firmware had defined the interface for Translation Look-Aside Buffer (TLB) invalidation. We should use this interface when invalidating the engine and GuC TLBs. Add additional functionality to

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: Create the guc_to_i915() wrapper

2023-10-05 Thread Patchwork
== Series Details == Series: drm/i915/guc: Create the guc_to_i915() wrapper URL : https://patchwork.freedesktop.org/series/124686/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13719 -> Patchwork_124686v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/guc: Create the guc_to_i915() wrapper

2023-10-05 Thread Patchwork
== Series Details == Series: drm/i915/guc: Create the guc_to_i915() wrapper URL : https://patchwork.freedesktop.org/series/124686/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] linux-next: manual merge of the drm-msm-lumag tree with the drm-misc tree

2023-10-05 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-msm-lumag tree got a conflict in: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h between commit: 8f5d3daad715 ("drm/msm/dpu: Annotate struct dpu_hw_intr with __counted_by") from the drm-misc tree and commits: eb7af0e86349 ("drm/msm/dpu:

[Intel-gfx] ✗ Fi.CI.BAT: failure for Subject: [PATCH dii-client v6 0/4] drm/i915: Define and use GuC and CTB TLB invalidation routines (rev2)

2023-10-05 Thread Patchwork
== Series Details == Series: Subject: [PATCH dii-client v6 0/4] drm/i915: Define and use GuC and CTB TLB invalidation routines (rev2) URL : https://patchwork.freedesktop.org/series/124641/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13719 -> Patchwork_124641v2

[Intel-gfx] [PATCH] drm/i915/guc: Enable WA 14018913170

2023-10-05 Thread John . C . Harrison
From: Daniele Ceraolo Spurio The GuC handles the WA, the KMD just needs to set the flag to enable it on the appropriate platforms. Signed-off-by: John Harrison Signed-off-by: Daniele Ceraolo Spurio Reviewed-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 6 ++

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Subject: [PATCH dii-client v6 0/4] drm/i915: Define and use GuC and CTB TLB invalidation routines (rev2)

2023-10-05 Thread Patchwork
== Series Details == Series: Subject: [PATCH dii-client v6 0/4] drm/i915: Define and use GuC and CTB TLB invalidation routines (rev2) URL : https://patchwork.freedesktop.org/series/124641/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Subject: [PATCH dii-client v6 0/4] drm/i915: Define and use GuC and CTB TLB invalidation routines (rev2)

2023-10-05 Thread Patchwork
== Series Details == Series: Subject: [PATCH dii-client v6 0/4] drm/i915: Define and use GuC and CTB TLB invalidation routines (rev2) URL : https://patchwork.freedesktop.org/series/124641/ State : warning == Summary == Error: dim checkpatch failed 518c58298cf5 drm/i915: Add GuC TLB

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove the module parameter 'fastboot' (rev3)

2023-10-05 Thread Patchwork
== Series Details == Series: drm/i915: Remove the module parameter 'fastboot' (rev3) URL : https://patchwork.freedesktop.org/series/124255/ State : success == Summary == CI Bug Log - changes from CI_DRM_13719 -> Patchwork_124255v3 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Remove the module parameter 'fastboot' (rev3)

2023-10-05 Thread Patchwork
== Series Details == Series: drm/i915: Remove the module parameter 'fastboot' (rev3) URL : https://patchwork.freedesktop.org/series/124255/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Enable WA 14018913170

2023-10-05 Thread Belgaumkar, Vinay
On 9/14/2023 3:28 PM, john.c.harri...@intel.com wrote: From: Daniele Ceraolo Spurio The GuC handles the WA, the KMD just needs to set the flag to enable it on the appropriate platforms. Signed-off-by: John Harrison Signed-off-by: Daniele Ceraolo Spurio ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/atomic-helper: relax unregistered connector check

2023-10-05 Thread Patchwork
== Series Details == Series: drm/atomic-helper: relax unregistered connector check URL : https://patchwork.freedesktop.org/series/124664/ State : success == Summary == CI Bug Log - changes from CI_DRM_13719 -> Patchwork_124664v1 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/atomic-helper: relax unregistered connector check

2023-10-05 Thread Patchwork
== Series Details == Series: drm/atomic-helper: relax unregistered connector check URL : https://patchwork.freedesktop.org/series/124664/ State : warning == Summary == Error: dim checkpatch failed 7f14ea949b98 drm/atomic-helper: relax unregistered connector check -:68: WARNING:LONG_LINE: line

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Display state checker cleanup (rev3)

2023-10-05 Thread Patchwork
== Series Details == Series: drm/i915: Display state checker cleanup (rev3) URL : https://patchwork.freedesktop.org/series/124616/ State : success == Summary == CI Bug Log - changes from CI_DRM_13719 -> Patchwork_124616v3 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Display state checker cleanup (rev3)

2023-10-05 Thread Patchwork
== Series Details == Series: drm/i915: Display state checker cleanup (rev3) URL : https://patchwork.freedesktop.org/series/124616/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Display state checker cleanup (rev3)

2023-10-05 Thread Patchwork
== Series Details == Series: drm/i915: Display state checker cleanup (rev3) URL : https://patchwork.freedesktop.org/series/124616/ State : warning == Summary == Error: dim checkpatch failed 2e9294527e33 drm/i915/psr: Unify PSR pre/post plane update hooks 1bb2e1ff46ca drm/i915: Stop clobbering

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ddi: Fix i2c_adapter assignment (rev2)

2023-10-05 Thread Patchwork
== Series Details == Series: drm/i915/ddi: Fix i2c_adapter assignment (rev2) URL : https://patchwork.freedesktop.org/series/124646/ State : success == Summary == CI Bug Log - changes from CI_DRM_13719 -> Patchwork_124646v2 Summary ---

Re: [Intel-gfx] [PATCH i-g-t 8/9] lib/kunit: Fetch a list of test cases in advance

2023-10-05 Thread Kamil Konieczny
Hi Janusz, On 2023-10-03 at 11:10:53 +0200, Janusz Krzysztofik wrote: > Recent improvements to the kernel kunit framework allow us to obtain a > list of test cases provided by a kunit test module without actually > running them. Use that feature to get a list of expected test cases > before we

[Intel-gfx] [PATCH] drm/i915/guc: Create the guc_to_i915() wrapper

2023-10-05 Thread Andi Shyti
Given a reference to "guc", the guc_to_i915() returns the pointer to "i915" private data. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_gt.h| 5 + drivers/gpu/drm/i915/gt/uc/intel_guc.c| 2 +- drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c| 2

Re: [Intel-gfx] [PATCH i-g-t 6/9] tests/kms_selftest: Let subtest names match suite names

2023-10-05 Thread Kamil Konieczny
Hi Janusz, On 2023-10-03 at 11:10:51 +0200, Janusz Krzysztofik wrote: > There is a rule specified in Kunit Test Style and Nomenclature guidelines > [1] that states modules should be named after the test suite, followed by > _test. Of course, that rule applies only to modules that provide one test

Re: [Intel-gfx] [PATCH i-g-t 3/9] lib/kunit: Fix misplaced igt_kunit() doc

2023-10-05 Thread Kamil Konieczny
Hi Janusz, On 2023-10-03 at 11:10:48 +0200, Janusz Krzysztofik wrote: > When igt_kunit() was converted to a helper and wrapped with a new function > promoted to take the name and role of the library API, related > documentation was left unchanged and still placed in front the demoted > function.

Re: [Intel-gfx] [PATCH i-g-t 2/9] lib/kunit: Be more verbose on errors

2023-10-05 Thread Kamil Konieczny
Hi Janusz, On 2023-10-03 at 11:10:47 +0200, Janusz Krzysztofik wrote: > Use a more verbose variant of igt_fail() when failing a dynamic sub- > subtest on kernel taint. Also, print a debug message on string > duplication failure. > > Signed-off-by: Janusz Krzysztofik Reviewed-by: Kamil

Re: [Intel-gfx] [PATCH i-g-t 1/9] lib/kunit: Fix handling of potential errors from F_GETFL

2023-10-05 Thread Kamil Konieczny
Hi Janusz, On 2023-10-03 at 11:10:46 +0200, Janusz Krzysztofik wrote: > Function fcntl(..., F_GETFL, ...) that returns file status flags may also > return a negative error code. Handle that error instead of blindly using > the returned value as flags. > > Signed-off-by: Janusz Krzysztofik

[Intel-gfx] [PATCH v7 1/5] drm/i915: Add GuC TLB Invalidation device info flags

2023-10-05 Thread Jonathan Cavitt
Add device info flags for if GuC TLB Invalidation is enabled. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_device_info.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH v7 5/5] drm/i915: Enable GuC TLB invalidations for MTL

2023-10-05 Thread Jonathan Cavitt
Enable GuC TLB invalidations for MTL. Though more platforms than just MTL support GuC TLB invalidations, MTL is presently the only platform that requires it for any purpose, so only enable it there for now to minimize cross-platform impact. Signed-off-by: Jonathan Cavitt ---

[Intel-gfx] [PATCH v7 2/5] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-05 Thread Jonathan Cavitt
From: Prathap Kumar Valsan The GuC firmware had defined the interface for Translation Look-Aside Buffer (TLB) invalidation. We should use this interface when invalidating the engine and GuC TLBs. Add additional functionality to intel_gt_invalidate_tlb, invalidating the GuC TLBs and falling back

[Intel-gfx] [PATCH v7 4/5] drm/i915/gt: Increase sleep in gt_tlb selftest sanitycheck

2023-10-05 Thread Jonathan Cavitt
For the gt_tlb live selftest, increase the timeout from 10 ms to 200 ms. 200 ms should be more than enough time, and 10 ms was too aggressive. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/gt/selftest_tlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH v7 3/5] drm/i915: No TLB invalidation on wedged or suspended GT

2023-10-05 Thread Jonathan Cavitt
In case of GT is suspended or wedged, don't allow submission of new TLB invalidation request and cancel all pending requests. The TLB entries will be invalidated either during GuC reload or on system resume. Signed-off-by: Fei Yang Signed-off-by: Jonathan Cavitt CC: John Harrison ---

[Intel-gfx] [PATCH v7 0/5] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-05 Thread Jonathan Cavitt
The GuC firmware had defined the interface for Translation Look-Aside Buffer (TLB) invalidation. We should use this interface when invalidating the engine and GuC TLBs. Add additional functionality to intel_gt_invalidate_tlb, invalidating the GuC TLBs and falling back to GT invalidation when the

[Intel-gfx] [PATCH dii-client v6 0/5] Subject: [PATCH dii-client v6 0/4] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-05 Thread Jonathan Cavitt
The GuC firmware had defined the interface for Translation Look-Aside Buffer (TLB) invalidation. We should use this interface when invalidating the engine and GuC TLBs. Add additional functionality to intel_gt_invalidate_tlb, invalidating the GuC TLBs and falling back to GT invalidation when the

[Intel-gfx] [linux-next:master] BUILD REGRESSION 7d730f1bf6f39ece2d9f3ae682f12e5b593d534d

2023-10-05 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 7d730f1bf6f39ece2d9f3ae682f12e5b593d534d Add linux-next specific files for 20231005 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202309122047.cri9yjrq-...@intel.com https

Re: [Intel-gfx] [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-05 Thread Kees Cook
On Thu, Oct 05, 2023 at 11:42:38AM +0200, Christian König wrote: > Am 02.10.23 um 20:22 schrieb Kees Cook: > > On Mon, Oct 02, 2023 at 08:11:41PM +0200, Christian König wrote: > > > Am 02.10.23 um 20:08 schrieb Kees Cook: > > > > On Mon, Oct 02, 2023 at 08:01:57PM +0200, Christian König wrote: > >

Re: [Intel-gfx] [PATCH] drm/i915/display: Reset message bus after each read/write operation

2023-10-05 Thread Rodrigo Vivi
On Thu, Oct 05, 2023 at 12:40:35PM -0300, Gustavo Sousa wrote: > Quoting Rodrigo Vivi (2023-10-05 12:13:34-03:00) > >On Thu, Oct 05, 2023 at 03:05:31AM -0400, Kahola, Mika wrote: > >> > -Original Message- > >> > From: Vivi, Rodrigo > >> > Sent: Wednesday, October 4, 2023 3:56 PM > >> >

[Intel-gfx] Regression in linux-next

2023-10-05 Thread Borah, Chaitanya Kumar
Hello Rafael, Hope you are doing well. I am Chaitanya from the linux graphics team in Intel. This mail is regarding a regression we are seeing in our CI runs[1] on linux-next repository. On next-20231003 [2], we are seeing the following error

Re: [Intel-gfx] [PATCH] drm/i915/display: Reset message bus after each read/write operation

2023-10-05 Thread Gustavo Sousa
Quoting Rodrigo Vivi (2023-10-05 12:13:34-03:00) >On Thu, Oct 05, 2023 at 03:05:31AM -0400, Kahola, Mika wrote: >> > -Original Message- >> > From: Vivi, Rodrigo >> > Sent: Wednesday, October 4, 2023 3:56 PM >> > To: Kahola, Mika >> > Cc: intel-gfx@lists.freedesktop.org >> > Subject: Re:

Re: [Intel-gfx] [PATCH] drm/i915/display: Reset message bus after each read/write operation

2023-10-05 Thread Rodrigo Vivi
On Thu, Oct 05, 2023 at 03:05:31AM -0400, Kahola, Mika wrote: > > -Original Message- > > From: Vivi, Rodrigo > > Sent: Wednesday, October 4, 2023 3:56 PM > > To: Kahola, Mika > > Cc: intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Reset message bus

Re: [Intel-gfx] [PATCH v5 2/4] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-05 Thread Cavitt, Jonathan
-Original Message- From: Tvrtko Ursulin Sent: Thursday, October 5, 2023 1:55 AM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Dutt, Sudeep ; Chang, Yu bruce ; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind ; Yang, Fei ; Shyti, Andi ; Harrison, John C ; Das, Nirmoy

Re: [Intel-gfx] linux-next: manual merge of the drm-intel tree with the drm tree

2023-10-05 Thread Jani Nikula
On Tue, 03 Oct 2023, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the drm-intel tree got a conflict in: > > drivers/gpu/drm/i915/i915_drv.h > > between commits: > > c9517783060a ("drm/i915/dg2: Drop Wa_16011777198") > 5a213086a025 ("drm/i915: Eliminate

[Intel-gfx] [PATCH] drm/atomic-helper: relax unregistered connector check

2023-10-05 Thread Simon Ser
The driver might pull connectors which weren't submitted by user-space into the atomic state. For instance, intel_dp_mst_atomic_master_trans_check() pulls in connectors sharing the same DP-MST stream. However, if the connector is unregistered, this later fails with: [ 559.425658] i915

Re: [Intel-gfx] [PATCH] drm/dp: switch drm_dp_downstream_*() helpers to struct drm_edid

2023-10-05 Thread Jani Nikula
On Wed, 04 Oct 2023, Ville Syrjälä wrote: > On Wed, Oct 04, 2023 at 07:21:49PM +0300, Jani Nikula wrote: >> Prefer struct drm_edid where possible. With limited users for the >> drm_dp_downstream_*() helpers, this is fairly straightforward. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Ville

[Intel-gfx] [PULL] drm-intel-fixes

2023-10-05 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2023-10-05: - Fix for OpenGL CTS regression on Compute Shaders (Nirmoy) - Fix for default engines initialization (Mathias) - Fix TLB invalidation for Multi-GT devices (Chris) Thanks, Rodrigo. The following changes since commit

Re: [Intel-gfx] [PATCH dii-client v6 2/5] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-05 Thread Andi Shyti
Hi Jonathan, > - if (intel_uc_wants_guc(>vm.gt->uc)) > + if (intel_uc_wants_guc_submission(>vm.gt->uc)) I think the failures we see in CI come from here. I think you had it right the first time, this should have both the checks: if (intel_uc_wants_guc(>vm.gt->uc) &&

Re: [Intel-gfx] [RFC PATCH 0/4] Framework for display parameters

2023-10-05 Thread Tvrtko Ursulin
On 05/10/2023 13:52, Jani Nikula wrote: On Thu, 05 Oct 2023, Jouni Högander wrote: Currently all module parameters are handled by i915_param.c/h. This is a problem for display parameters when Xe driver is used. This patch set adds a mechanism to add parameters specific to the display. This

Re: [Intel-gfx] [PATCH] drm/i915/cx0: Only clear/set the Pipe Reset bit of the PHY Lanes Owned

2023-10-05 Thread Jani Nikula
On Thu, 05 Oct 2023, Gustavo Sousa wrote: > Quoting Khaled Almahallawy (2023-10-04 21:13:10-03:00) >>Currently, with MFD/pin assignment D, the driver clears the pipe reset bit >>of lane 1 which is not owned by display. This causes the display >>to block S0iX. >> >>By not clearing this bit for

Re: [Intel-gfx] [PATCH dii-client v6 1/5] drm/i915: Add GuC TLB Invalidation pci flags

2023-10-05 Thread Jani Nikula
On Thu, 05 Oct 2023, Michal Wajdeczko wrote: > On 05.10.2023 00:07, Jonathan Cavitt wrote: >> Add pci (device info) flags for if GuC TLB Invalidation is enabled. > > nit: maybe avoid using "PCI flag" term here (and in the title) as this > could be little misleading - better stick to "device info

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Check lane count when determining FEC support

2023-10-05 Thread Imre Deak
On Wed, Sep 13, 2023 at 06:03:55PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > ICL doesn't support FEC with a x1 DP link. Make sure > we don't try to enable FEC in such cases. > > Requires a bit of reordering to make sure we've computed lane_count > before checking it. > > Cc: Luca

Re: [Intel-gfx] [PATCH v2 06/12] drm/i915: Simplify watermark state checker calling convention

2023-10-05 Thread Jani Nikula
On Thu, 05 Oct 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > There is never any reason to pass in both the crtc and its state > as one can always dig out the crtc from its state. But for more > consistency across the whole state checker let's just pass the > overall atomic state+crtc here

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Subject: [PATCH dii-client v6 0/4] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-05 Thread Andi Shyti
Hi, > > CI changes > > > > Possible regressions > > > > • boot: > > □ bat-dg1-5: PASS -> FAIL > > > > IGT changes > > > > Possible regressions > > > > • igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling: > > > > □ bat-adlm-1: PASS -> INCOMPLETE > > •

Re: [Intel-gfx] [RFC PATCH 1/4] drm/i915/display: Add framework to add parameters specific to display

2023-10-05 Thread Jani Nikula
On Thu, 05 Oct 2023, Jouni Högander wrote: > Currently all module parameters are handled by i915_param.c/h. This > is a problem for display parameters when Xe driver is used. Add > a mechanism to add parameters specific to the display. This is mainly > copied from i915_[debugfs]_params.[ch].

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Subject: [PATCH dii-client v6 0/4] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-05 Thread Andi Shyti
Hi Jonathan, > CI changes > > Possible regressions > > • boot: > □ bat-dg1-5: PASS -> FAIL > > IGT changes > > Possible regressions > > • igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling: > > □ bat-adlm-1: PASS -> INCOMPLETE > • igt@kms_busy@basic@flip: > > □

Re: [Intel-gfx] [RFC PATCH 0/4] Framework for display parameters

2023-10-05 Thread Jani Nikula
On Thu, 05 Oct 2023, Jouni Högander wrote: > Currently all module parameters are handled by i915_param.c/h. This > is a problem for display parameters when Xe driver is used. > > This patch set adds a mechanism to add parameters specific to the > display. This is mainly copied from existing i915

Re: [Intel-gfx] [PATCH] drm/i915/cx0: Only clear/set the Pipe Reset bit of the PHY Lanes Owned

2023-10-05 Thread Gustavo Sousa
Quoting Khaled Almahallawy (2023-10-04 21:13:10-03:00) >Currently, with MFD/pin assignment D, the driver clears the pipe reset bit >of lane 1 which is not owned by display. This causes the display >to block S0iX. > >By not clearing this bit for lane 1 and keeping whatever default, S0ix >started to

[Intel-gfx] [PATCH v2 06/12] drm/i915: Simplify watermark state checker calling convention

2023-10-05 Thread Ville Syrjala
From: Ville Syrjälä There is never any reason to pass in both the crtc and its state as one can always dig out the crtc from its state. But for more consistency across the whole state checker let's just pass the overall atomic state+crtc here as well. v2: Also pass state+crtc here (Jani)

Re: [Intel-gfx] [PATCH] drm/i915/ddi: Remove redundant intel_connector NULL check

2023-10-05 Thread Andi Shyti
Hi, On Thu, Oct 05, 2023 at 04:40:41PM +0530, Suraj Kandpal wrote: > Remove redundant intel_connector NULL check. Having it here just > creates further confusion and also the variable already gets > dereferenced before the aforementioned NULL check > > Fixes: dba14b27dd3c ("drm/i915:

[Intel-gfx] ✗ Fi.CI.IGT: failure for powercap: intel_rapl: Don't warn about BIOS locked limits during resume

2023-10-05 Thread Patchwork
== Series Details == Series: powercap: intel_rapl: Don't warn about BIOS locked limits during resume URL : https://patchwork.freedesktop.org/series/124635/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13712_full -> Patchwork_124635v1_full

[Intel-gfx] [PATCH] drm/i915/ddi: Remove redundant intel_connector NULL check

2023-10-05 Thread Suraj Kandpal
Remove redundant intel_connector NULL check. Having it here just creates further confusion and also the variable already gets dereferenced before the aforementioned NULL check Fixes: dba14b27dd3c ("drm/i915: Reinitialize sink scrambling/TMDS clock ratio on HPD") Signed-off-by: Suraj Kandpal ---

Re: [Intel-gfx] [PATCH] drm/i915/ddi: Fix i2c_adapter assignment

2023-10-05 Thread Kandpal, Suraj
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/ddi: Fix i2c_adapter assignment > > On Thu, 05 Oct 2023, Ville Syrjälä wrote: > > On Thu, Oct 05, 2023 at 12:12:58PM +0530, Suraj Kandpal wrote: > >> i2c_adapter is being assigned using intel_connector even before the > >> NULL check occurs and even

Re: [Intel-gfx] [PATCH] drm/i915/ddi: Fix i2c_adapter assignment

2023-10-05 Thread Jani Nikula
On Thu, 05 Oct 2023, Ville Syrjälä wrote: > On Thu, Oct 05, 2023 at 12:12:58PM +0530, Suraj Kandpal wrote: >> i2c_adapter is being assigned using intel_connector even before the >> NULL check occurs and even though it shouldn't be a problem >> lets just clean this up as logically it does not make

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Use local64_try_cmpxchg in i915_pmu_event_read

2023-10-05 Thread Jani Nikula
On Mon, 03 Jul 2023, Uros Bizjak wrote: > Use local64_try_cmpxchg instead of local64_cmpxchg (*ptr, old, new) == old > in i915_pmu_event_read. x86 CMPXCHG instruction returns success in ZF flag, > so this change saves a compare after cmpxchg (and related move instruction > in front of cmpxchg).

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/dp: switch drm_dp_downstream_*() helpers to struct drm_edid

2023-10-05 Thread Patchwork
== Series Details == Series: drm/dp: switch drm_dp_downstream_*() helpers to struct drm_edid URL : https://patchwork.freedesktop.org/series/124622/ State : success == Summary == CI Bug Log - changes from CI_DRM_13712_full -> Patchwork_124622v1_full

Re: [Intel-gfx] [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-05 Thread Christian König
Am 02.10.23 um 20:22 schrieb Kees Cook: On Mon, Oct 02, 2023 at 08:11:41PM +0200, Christian König wrote: Am 02.10.23 um 20:08 schrieb Kees Cook: On Mon, Oct 02, 2023 at 08:01:57PM +0200, Christian König wrote: Am 02.10.23 um 18:53 schrieb Kees Cook: On Mon, Oct 02, 2023 at 11:06:19AM -0400,

Re: [Intel-gfx] [PATCH] drm/i915/ddi: Fix i2c_adapter assignment

2023-10-05 Thread Ville Syrjälä
On Thu, Oct 05, 2023 at 12:12:58PM +0530, Suraj Kandpal wrote: > i2c_adapter is being assigned using intel_connector even before the > NULL check occurs and even though it shouldn't be a problem > lets just clean this up as logically it does not make sense to check > the connector for NULL but

Re: [Intel-gfx] [PATCH] drm/i915/ddi: Fix i2c_adapter assignment

2023-10-05 Thread Kandpal, Suraj
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/ddi: Fix i2c_adapter assignment > > Hi Suraj, > > On Thu, Oct 05, 2023 at 12:12:58PM +0530, Suraj Kandpal wrote: > > i2c_adapter is being assigned using intel_connector even before the > > NULL check occurs and even though it shouldn't be a problem

[Intel-gfx] [PULL] drm-misc-fixes

2023-10-05 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the weekly PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2023-10-05: Short summary of fixes pull: * test: Fix kunit release * panel-orientation: Add quirk for One Mix 25 * nouveau: * Report IB limit via getparams * Replace some magic numbers with

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Check lane count when determining FEC support (rev2)

2023-10-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Check lane count when determining FEC support (rev2) URL : https://patchwork.freedesktop.org/series/123643/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13712_full -> Patchwork_123643v2_full

Re: [Intel-gfx] [PATCH] drm/i915/ddi: Fix i2c_adapter assignment

2023-10-05 Thread Andi Shyti
Hi Suraj, On Thu, Oct 05, 2023 at 12:12:58PM +0530, Suraj Kandpal wrote: > i2c_adapter is being assigned using intel_connector even before the > NULL check occurs and even though it shouldn't be a problem > lets just clean this up as logically it does not make sense to check > the connector for

Re: [Intel-gfx] [PATCH v5 2/4] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-05 Thread Tvrtko Ursulin
On 04/10/2023 19:36, Jonathan Cavitt wrote: From: Prathap Kumar Valsan The GuC firmware had defined the interface for Translation Look-Aside Buffer (TLB) invalidation. We should use this interface when invalidating the engine and GuC TLBs. Add additional functionality to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ddi: Fix i2c_adapter assignment

2023-10-05 Thread Patchwork
== Series Details == Series: drm/i915/ddi: Fix i2c_adapter assignment URL : https://patchwork.freedesktop.org/series/124646/ State : success == Summary == CI Bug Log - changes from CI_DRM_13713 -> Patchwork_124646v1 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/6] drm/i915/fbc: Remove ancient 16k plane stride limit (rev2)

2023-10-05 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915/fbc: Remove ancient 16k plane stride limit (rev2) URL : https://patchwork.freedesktop.org/series/124568/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13712_full -> Patchwork_124568v2_full

Re: [Intel-gfx] [v4] drm/i915/display: Created exclusive version of vga decode setup

2023-10-05 Thread Shankar, Uma
> -Original Message- > From: Murthy, Arun R > Sent: Wednesday, October 4, 2023 12:13 PM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: RE: [Intel-gfx] [v4] drm/i915/display: Created exclusive version of > vga > decode setup > > > > -Original

Re: [Intel-gfx] [PATCH] drm/i915/display: Reset message bus after each read/write operation

2023-10-05 Thread Kahola, Mika
> -Original Message- > From: Vivi, Rodrigo > Sent: Wednesday, October 4, 2023 3:56 PM > To: Kahola, Mika > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Reset message bus after > each read/write operation > > On Wed, Oct 04, 2023 at 01:25:04PM

[Intel-gfx] [PATCH] drm/i915/ddi: Fix i2c_adapter assignment

2023-10-05 Thread Suraj Kandpal
i2c_adapter is being assigned using intel_connector even before the NULL check occurs and even though it shouldn't be a problem lets just clean this up as logically it does not make sense to check the connector for NULL but dereference it before that. Fixes: e046d1562491 ("drm/i915/hdmi: Use

[Intel-gfx] ✓ Fi.CI.BAT: success for Framework for display parameters

2023-10-05 Thread Patchwork
== Series Details == Series: Framework for display parameters URL : https://patchwork.freedesktop.org/series/124645/ State : success == Summary == CI Bug Log - changes from CI_DRM_13713 -> Patchwork_124645v1 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Framework for display parameters

2023-10-05 Thread Patchwork
== Series Details == Series: Framework for display parameters URL : https://patchwork.freedesktop.org/series/124645/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Framework for display parameters

2023-10-05 Thread Patchwork
== Series Details == Series: Framework for display parameters URL : https://patchwork.freedesktop.org/series/124645/ State : warning == Summary == Error: dim checkpatch failed 1f8018f8b9a9 drm/i915/display: Add framework to add parameters specific to display Traceback (most recent call