Re: [Intel-gfx] [PATCH 3/3] drm/i915/hdcp: Add more conditions to enable hdcp

2023-10-26 Thread Nautiyal, Ankit K
On 10/26/2023 5:41 PM, Suraj Kandpal wrote: When we dock a monitor we end up with a enable and disable connector cycle but if hdcp content is running we get the userspace in I was wondering if there should have been a uevent sent when driver changes the state from enabled to undesired,

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/lnl: Assign correct phys (rev3)

2023-10-26 Thread Patchwork
== Series Details == Series: drm/i915/lnl: Assign correct phys (rev3) URL : https://patchwork.freedesktop.org/series/125322/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for Apply Wa_16018031267 / Wa_16018063123

2023-10-26 Thread Patchwork
== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 URL : https://patchwork.freedesktop.org/series/125650/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13799 -> Patchwork_125650v1 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/gem: Allow users to disable waitboost

2023-10-26 Thread kernel test robot
Hello, kernel test robot noticed "assertion_failure" on: commit: 54fef7ea35dadd66193b98805b0bc42ef2b279db ("[PATCH] drm/i915/gem: Allow users to disable waitboost") url:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Apply Wa_16018031267 / Wa_16018063123

2023-10-26 Thread Patchwork
== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 URL : https://patchwork.freedesktop.org/series/125650/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Apply Wa_16018031267 / Wa_16018063123

2023-10-26 Thread Patchwork
== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 URL : https://patchwork.freedesktop.org/series/125650/ State : warning == Summary == Error: dim checkpatch failed c7c9a792cec0 drm/i915: Reserve some kernel space per vm 02f4f3cc637c drm/i915: Add WABB blit for Wa_16018031267

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Remove assignment from if condition

2023-10-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Remove assignment from if condition URL : https://patchwork.freedesktop.org/series/125637/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13799 -> Patchwork_125637v1 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tc: Fix -Wformat-truncation in intel_tc_port_init (rev4)

2023-10-26 Thread Patchwork
== Series Details == Series: drm/i915/tc: Fix -Wformat-truncation in intel_tc_port_init (rev4) URL : https://patchwork.freedesktop.org/series/125576/ State : success == Summary == CI Bug Log - changes from CI_DRM_13799 -> Patchwork_125576v4

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: Additional conditions to enable hdcp (rev4)

2023-10-26 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Additional conditions to enable hdcp (rev4) URL : https://patchwork.freedesktop.org/series/125550/ State : success == Summary == CI Bug Log - changes from CI_DRM_13799 -> Patchwork_125550v4

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/hdcp: Additional conditions to enable hdcp (rev4)

2023-10-26 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Additional conditions to enable hdcp (rev4) URL : https://patchwork.freedesktop.org/series/125550/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Include drm_drv.h in intel_display_params.c

2023-10-26 Thread Patchwork
== Series Details == Series: drm/i915/display: Include drm_drv.h in intel_display_params.c URL : https://patchwork.freedesktop.org/series/125630/ State : success == Summary == CI Bug Log - changes from CI_DRM_13797 -> Patchwork_125630v1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Remove unncessary {} from if-else

2023-10-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Remove unncessary {} from if-else URL : https://patchwork.freedesktop.org/series/125629/ State : success == Summary == CI Bug Log - changes from CI_DRM_13797 -> Patchwork_125629v1 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/pmu: add pmu_to_i915() helper (rev3)

2023-10-26 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/pmu: add pmu_to_i915() helper (rev3) URL : https://patchwork.freedesktop.org/series/125464/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13797 -> Patchwork_125464v3

[Intel-gfx] [PATCH] drm/i915: Skip pxp init if gt is wedged

2023-10-26 Thread Zhanjun Dong
gt wedged is fatal error, skip the pxp init on this situation. Signed-off-by: Zhanjun Dong --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/gpu/drm/i915/pxp/intel_pxp.c index

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: fix Makefile sort and indent

2023-10-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: fix Makefile sort and indent URL : https://patchwork.freedesktop.org/series/125626/ State : success == Summary == CI Bug Log - changes from CI_DRM_13795 -> Patchwork_125626v1

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/mtl: Apply notify_guc to all GTs (rev2)

2023-10-26 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Apply notify_guc to all GTs (rev2) URL : https://patchwork.freedesktop.org/series/125560/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13792 -> Patchwork_125560v2 Summary ---

[Intel-gfx] [PATCH v2 2/2] drm/i915/lnl: Fix check for TC phy

2023-10-26 Thread Lucas De Marchi
With MTL adding PICA between the port and the real phy, the path add for DG2 stopped being followed and newer platforms are simply using the older path for TC phys. LNL is no different than MTL in this aspect, so just add it to the mess. In future the phy and port designation and deciding if it's

[Intel-gfx] [PATCH v2 0/2] drm/i915/lnl: Assign correct phys

2023-10-26 Thread Lucas De Marchi
For this series to work, we still need a separate patch on the xe side so it defines the LNL platform macro to be used by display. One thing missing for LNL during the previous patches was the port <-> phy assignment. With the bspec now clarified, this is the minimum changes needed for LNL. As

[Intel-gfx] [PATCH v2 1/2] drm/i915/lnl: Extend C10/C20 phy

2023-10-26 Thread Lucas De Marchi
For Lunar Lake, DDI-A is connected to C10 PHY, while TC1-TC3 are connected to C20 phy, like in Meteor Lake. Update the check in intel_is_c10phy() accordingly. This reverts the change in commit e388ae97e225 ("drm/i915/display: Eliminate IS_METEORLAKE checks") that turned that into a display engine

[Intel-gfx] [PATCH v6 4/4] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123

2023-10-26 Thread Andrzej Hajda
From: Jonathan Cavitt Set copy engine arbitration into round robin mode for part of Wa_16018031267 / Wa_16018063123 mitigation. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3

[Intel-gfx] [PATCH v6 3/4] drm/i915/gt: add selftest to exercise WABB

2023-10-26 Thread Andrzej Hajda
Test re-uses logic form indirect ctx BB selftest. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 65 -- 1 file changed, 47 insertions(+), 18

[Intel-gfx] [PATCH v6 2/4] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123

2023-10-26 Thread Andrzej Hajda
Apply WABB blit for Wa_16018031267 / Wa_16018063123. v3: drop unused enum definition v4: move selftest to separate patch, use wa only on BCS0. v5: fixed selftest caller to context_wabb Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Signed-off-by: Andrzej Hajda Reviewed-by: Andi

[Intel-gfx] [PATCH v6 1/4] drm/i915: Reserve some kernel space per vm

2023-10-26 Thread Andrzej Hajda
Reserve one page in each vm for kernel space to use for things such as workarounds. v2: use real memory, do not decrease vm.total v4: reserve only one page and explain flag v5: remove allocated object on ppgtt cleanup v6: decrease vm->total by reservation size Suggested-by: Chris Wilson

[Intel-gfx] [PATCH v6 0/4] Apply Wa_16018031267 / Wa_16018063123

2023-10-26 Thread Andrzej Hajda
drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_pci.c | 2 + drivers/gpu/drm/i915/intel_device_info.h | 1 + 12 files changed, 215 insertions(+), 21 deletions(-) Test-with: 20231026-gtt_size_fix-v1-2-882d0e002...@intel.com --- - Link to v3: ht

Re: [Intel-gfx] [PATCH 2/2] drm/i915/lnl: Fix check for TC phy

2023-10-26 Thread Gustavo Sousa
Quoting Lucas De Marchi (2023-10-25 12:44:09-03:00) >On Mon, Oct 23, 2023 at 12:28:46PM -0300, Gustavo Sousa wrote: >>Quoting Lucas De Marchi (2023-10-20 13:04:48-03:00) >>>On Thu, Oct 19, 2023 at 01:04:40PM -0300, Gustavo Sousa wrote: Quoting Lucas De Marchi (2023-10-18 19:24:41-03:00)

Re: [Intel-gfx] [PATCH] MAINTAINERS: drm/ci: add entries for xfail files

2023-10-26 Thread Maxime Ripard
On Tue, 19 Sep 2023 15:22:49 -0300, Helen Koike wrote: > DRM CI keeps track of which tests are failing, flaking or being skipped > by the ci in the expectations files. Add entries for those files to the > corresponding driver maintainer, so they can be notified when they > change. > > Applied

[Intel-gfx] [PULL] drm-intel-fixes

2023-10-26 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2023-10-26: - Determine context valid in OA reports (Umesh) - Hold GT forcewake during steering operations (Matt Roper) - Check if PMU is closed before stopping event (Umesh) Thanks, Rodrigo. The following changes since commit

Re: [Intel-gfx] [PATCH 1/7] drm: Do not round to megabytes for greater than 1MiB sizes in fdinfo stats

2023-10-26 Thread Tvrtko Ursulin
On 28/09/2023 13:47, Tvrtko Ursulin wrote: On 27/09/2023 14:48, Steven Price wrote: On 27/09/2023 14:38, Tvrtko Ursulin wrote: From: Tvrtko Ursulin It is better not to lose precision and not revert to 1 MiB size granularity for every size greater than 1 MiB. Sizes in KiB should not be so

Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove assignment from if condition

2023-10-26 Thread Tvrtko Ursulin
On 26/10/2023 14:58, Gilbert Adikankwu wrote: Initialize variable "entry" during declaration. Remove assignment from if condition. Fix checkpatch.pl error: ERROR: do not use assignment in if condition Signed-off-by: Gilbert Adikankwu ---

Re: [Intel-gfx] [PATCH v3] drm/i915/dsb: DSB code refactoring

2023-10-26 Thread Ville Syrjälä
On Sun, Oct 08, 2023 at 03:42:06PM +0530, Animesh Manna wrote: > Refactor DSB implementation to be compatible with Xe driver. > > v1: RFC version. > v2: Make intel_dsb structure opaque from external usage. [Jani] > v3: Rebased on latest. > > Cc: Jani Nikula > Signed-off-by: Animesh Manna > ---

Re: [Intel-gfx] [PATCH v3] drm/i915/dsb: DSB code refactoring

2023-10-26 Thread Manna, Animesh
> -Original Message- > From: Luca Coelho > Sent: Thursday, October 26, 2023 1:08 PM > To: Manna, Animesh ; intel- > g...@lists.freedesktop.org > Cc: Nikula, Jani > Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/dsb: DSB code refactoring > > On Sun, 2023-10-08 at 15:42 +0530, Animesh

[Intel-gfx] [PATCH] drm/i915/gt: Remove assignment from if condition

2023-10-26 Thread Gilbert Adikankwu
Initialize variable "entry" during declaration. Remove assignment from if condition. Fix checkpatch.pl error: ERROR: do not use assignment in if condition Signed-off-by: Gilbert Adikankwu --- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: remove display device info from i915 capabilities

2023-10-26 Thread Jani Nikula
On Thu, 19 Oct 2023, "Borah, Chaitanya Kumar" wrote: >> -Original Message- >> From: Govindapillai, Vinod >> Sent: Wednesday, October 18, 2023 3:57 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: Govindapillai, Vinod ; Sharma, Swati2 >> ; Borah, Chaitanya Kumar >> >> Subject: [PATCH v4

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence

2023-10-26 Thread Hogander, Jouni
On Thu, 2023-10-26 at 15:46 +0300, Ville Syrjälä wrote: > On Thu, Oct 26, 2023 at 09:40:23AM +, Hogander, Jouni wrote: > > On Wed, 2023-10-25 at 17:18 +0300, Ville Syrjälä wrote: > > > On Fri, Oct 20, 2023 at 12:41:03PM +0300, Jouni Högander wrote: > > > > We are preparing for Xe driver. Xe

[Intel-gfx] [PATCH v3] drm/i915/tc: Fix -Wformat-truncation in intel_tc_port_init

2023-10-26 Thread Nirmoy Das
Fix below compiler warning: intel_tc.c:1879:11: error: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size 3 [-Werror=format-truncation=] "%c/TC#%d", port_name(port), tc_port + 1); ^~ intel_tc.c:1878:2: note: ‘snprintf’ output between 7 and 17

Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove unncessary {} from if-else

2023-10-26 Thread Andi Shyti
Hi Gilbert, On Thu, Oct 26, 2023 at 11:56:23AM +0100, Gilbert Adikankwu wrote: > Fix checkpatch.pl error: > > WARNING: braces {} are not necessary for any arm of this statement > > Signed-off-by: Gilbert Adikankwu Reviewed-by: Andi Shyti Andi

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence

2023-10-26 Thread Ville Syrjälä
On Thu, Oct 26, 2023 at 09:40:23AM +, Hogander, Jouni wrote: > On Wed, 2023-10-25 at 17:18 +0300, Ville Syrjälä wrote: > > On Fri, Oct 20, 2023 at 12:41:03PM +0300, Jouni Högander wrote: > > > We are preparing for Xe driver. Xe driver doesn't have > > > i915_sw_fence > > > implementation. Lets

Re: [Intel-gfx] [topic/core-for-CI][PATCH 0/2] Drop some unnecessary patches

2023-10-26 Thread Ville Syrjälä
On Wed, Oct 25, 2023 at 02:41:50PM +0300, Jani Nikula wrote: > On Tue, 24 Oct 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Try to drop a few seemingly unnecessary patches from core-for-CI. > > Yay, ack! Didn't spot any regressions in the CI results, so force pushed

Re: [Intel-gfx] [PATCH] file, i915: fix file reference for mmap_singleton()

2023-10-26 Thread Jann Horn
On Wed, Oct 25, 2023 at 2:01 PM Christian Brauner wrote: > Today we got a report at [1] for rcu stalls on the i915 testsuite in [2] > due to the conversion of files to SLAB_TYPSSAFE_BY_RCU. Afaict, > get_file_rcu() goes into an infinite loop trying to carefully verify > that

Re: [Intel-gfx] [PATCH 2/3] drm/i915/hdcp: Convert intel_hdcp_enable to a blanket function

2023-10-26 Thread Jani Nikula
On Thu, 26 Oct 2023, Suraj Kandpal wrote: > Let's convert intel_hdcp_enable to a blanket function > which just has some conditions which needs to be checked > before connectors enable hdcp. > This cleans up code and avoids code duplication. > > --v3 > -Keep function name as intel_hdcp_enable()

Re: [Intel-gfx] [PATCH 1/3] drm/i915/hdcp: Rename HCDP 1.4 enablement function

2023-10-26 Thread Jani Nikula
On Thu, 26 Oct 2023, Suraj Kandpal wrote: > Rename hdcp 1.4 enablement function from _intel_hdcp_enable to > intel_hdcp1_enable to better represent what version of hdcp is > being enabled > > Signed-off-by: Suraj Kandpal Reviewed-by: Jani Nikula -- Jani Nikula, Intel

Re: [Intel-gfx] [PATCH 4/4] drm/i915/dp: Limit max_requested_bpc based on src DSC bpc limits

2023-10-26 Thread Ville Syrjälä
On Thu, Oct 26, 2023 at 11:24:38AM +0530, Nautiyal, Ankit K wrote: > > On 10/25/2023 6:20 PM, Ville Syrjälä wrote: > > On Wed, Oct 25, 2023 at 05:43:18PM +0530, Ankit Nautiyal wrote: > >> At the moment the max requested bpc is limited to 6 to 10/12. > >> For platforms that support DSC, min and

Re: [Intel-gfx] [PATCH] drm/i915/mtl: avoid stringop-overflow warning

2023-10-26 Thread Jani Nikula
On Mon, 23 Oct 2023, Jani Nikula wrote: > On Mon, 16 Oct 2023, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> The newly added memset() causes a warning for some reason I could not figure >> out: >> >> In file included from arch/x86/include/asm/string.h:3, >> from

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Improve BW management on MST links (rev5)

2023-10-26 Thread Patchwork
== Series Details == Series: drm/i915: Improve BW management on MST links (rev5) URL : https://patchwork.freedesktop.org/series/125490/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13782_full -> Patchwork_125490v5_full

Re: [Intel-gfx] Regression on linux-next (next-20231013)

2023-10-26 Thread Christian Brauner
On Thu, Oct 26, 2023 at 10:14:23AM +, Borah, Chaitanya Kumar wrote: > Hello Christian, > > > -Original Message- > > From: Borah, Chaitanya Kumar > > Sent: Wednesday, October 25, 2023 7:15 PM > > To: Christian Brauner > > Cc: intel-gfx@lists.freedesktop.org; Kurmi, Suresh Kumar > > ;

[Intel-gfx] [PATCH 3/3] drm/i915/hdcp: Add more conditions to enable hdcp

2023-10-26 Thread Suraj Kandpal
When we dock a monitor we end up with a enable and disable connector cycle but if hdcp content is running we get the userspace in enabled state and driver maintaining a undesired state which causes the content to stop playing and we only enabe hdcp if the userspace state in desired. This patch

[Intel-gfx] [PATCH 2/3] drm/i915/hdcp: Convert intel_hdcp_enable to a blanket function

2023-10-26 Thread Suraj Kandpal
Let's convert intel_hdcp_enable to a blanket function which just has some conditions which needs to be checked before connectors enable hdcp. This cleans up code and avoids code duplication. --v3 -Keep function name as intel_hdcp_enable() [Jani] Signed-off-by: Suraj Kandpal ---

[Intel-gfx] [PATCH 0/3] drm/i915/hdcp: Additional conditions to enable hdcp

2023-10-26 Thread Suraj Kandpal
We are seeing a issue when we close the lid of a laptop or dock a monitor hdcp content is not being reenabled automatically this is because when we dock a monitor we end up with a enable and disable connector cycle but if hdcp content is running we get the userspace in enabled state and driver

[Intel-gfx] [PATCH 1/3] drm/i915/hdcp: Rename HCDP 1.4 enablement function

2023-10-26 Thread Suraj Kandpal
Rename hdcp 1.4 enablement function from _intel_hdcp_enable to intel_hdcp1_enable to better represent what version of hdcp is being enabled Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Intel-gfx] [PATCH 2/3] drm/i915/hdcp: Create a blanket hdcp enable function

2023-10-26 Thread Kandpal, Suraj
> -Original Message- > From: Jani Nikula > Sent: Thursday, October 26, 2023 3:34 PM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Cc: Shankar, Uma ; Nautiyal, Ankit K > ; Kandpal, Suraj > Subject: Re: [PATCH 2/3] drm/i915/hdcp: Create a blanket hdcp enable function > > On

Re: [Intel-gfx] [PATCH] drm/i915/display: Include drm_drv.h in intel_display_params.c

2023-10-26 Thread Jani Nikula
On Thu, 26 Oct 2023, Jouni Högander wrote: > intel_display_params.c is accessing drm_drv->name. Due to this include > drm_drv.h to avoid build problem with Xe. > > Signed-off-by: Jouni Högander Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display_params.c | 2 ++ > 1

[Intel-gfx] [PATCH] drm/i915/display: Include drm_drv.h in intel_display_params.c

2023-10-26 Thread Jouni Högander
intel_display_params.c is accessing drm_drv->name. Due to this include drm_drv.h to avoid build problem with Xe. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_display_params.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Intel-gfx] [PULL] drm-misc-fixes

2023-10-26 Thread Thomas Zimmermann
Hi, this is the week's PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2023-10-26: Short summary of fixes pull: amdgpu: - ignore duplicated BOs in CS parser - remove redundant call to amdgpu_ctx_priority_is_valid() amdkfd: - reserve fence slot while locking BO dp_mst: - Fix NULL

Re: [Intel-gfx] [PATCH 2/3] drm/i915/pmu: add event_to_pmu() helper

2023-10-26 Thread Andi Shyti
On Thu, Oct 26, 2023 at 11:51:02AM +0100, Tvrtko Ursulin wrote: > On 26/10/2023 11:36, Andi Shyti wrote: > > > On 26/10/2023 11:22, Jani Nikula wrote: > > > > On Wed, 25 Oct 2023, Andi Shyti wrote: > > > > > On Wed, Oct 25, 2023 at 11:20:25AM +0100, Tvrtko Ursulin wrote: > > > > > > > > > > > >

[Intel-gfx] [PATCH] drm/i915/gt: Remove unncessary {} from if-else

2023-10-26 Thread Gilbert Adikankwu
Fix checkpatch.pl error: WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Gilbert Adikankwu --- drivers/gpu/drm/i915/gt/intel_sseu.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_sseu.c

Re: [Intel-gfx] [PATCH 2/3] drm/i915/pmu: add event_to_pmu() helper

2023-10-26 Thread Tvrtko Ursulin
On 26/10/2023 11:36, Andi Shyti wrote: Hi, On 26/10/2023 11:22, Jani Nikula wrote: On Wed, 25 Oct 2023, Andi Shyti wrote: On Wed, Oct 25, 2023 at 11:20:25AM +0100, Tvrtko Ursulin wrote: On 24/10/2023 13:42, Jani Nikula wrote: On Tue, 24 Oct 2023, Andi Shyti wrote: Hi Jani, On Mon,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Support HBR3 rate with C10 phy and eDP in MTL (rev2)

2023-10-26 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Support HBR3 rate with C10 phy and eDP in MTL (rev2) URL : https://patchwork.freedesktop.org/series/125293/ State : success == Summary == CI Bug Log - changes from CI_DRM_13783 -> Patchwork_125293v2

Re: [Intel-gfx] [PATCH] drm/i915/display: Support PSR entry VSC packet to be transmitted one frame earlier

2023-10-26 Thread Kahola, Mika
> -Original Message- > From: Hogander, Jouni > Sent: Wednesday, October 25, 2023 4:05 PM > To: Kahola, Mika ; intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/i915/display: Support PSR entry VSC packet to be > transmitted one frame earlier > > On Wed, 2023-10-25 at 12:46

Re: [Intel-gfx] [PATCH 2/3] drm/i915/pmu: add event_to_pmu() helper

2023-10-26 Thread Andi Shyti
Hi, > On 26/10/2023 11:22, Jani Nikula wrote: > > On Wed, 25 Oct 2023, Andi Shyti wrote: > > > On Wed, Oct 25, 2023 at 11:20:25AM +0100, Tvrtko Ursulin wrote: > > > > > > > > On 24/10/2023 13:42, Jani Nikula wrote: > > > > > On Tue, 24 Oct 2023, Andi Shyti wrote: > > > > > > Hi Jani, > > > > >

Re: [Intel-gfx] [PATCH 2/3] drm/i915/pmu: add event_to_pmu() helper

2023-10-26 Thread Tvrtko Ursulin
On 26/10/2023 11:22, Jani Nikula wrote: On Wed, 25 Oct 2023, Andi Shyti wrote: On Wed, Oct 25, 2023 at 11:20:25AM +0100, Tvrtko Ursulin wrote: On 24/10/2023 13:42, Jani Nikula wrote: On Tue, 24 Oct 2023, Andi Shyti wrote: Hi Jani, On Mon, Oct 23, 2023 at 06:02:55PM +0300, Jani Nikula

Re: [Intel-gfx] [PATCH 2/3] drm/i915/pmu: add event_to_pmu() helper

2023-10-26 Thread Jani Nikula
On Wed, 25 Oct 2023, Andi Shyti wrote: > On Wed, Oct 25, 2023 at 11:20:25AM +0100, Tvrtko Ursulin wrote: >> >> On 24/10/2023 13:42, Jani Nikula wrote: >> > On Tue, 24 Oct 2023, Andi Shyti wrote: >> > > Hi Jani, >> > > >> > > On Mon, Oct 23, 2023 at 06:02:55PM +0300, Jani Nikula wrote: >> > > >

Re: [Intel-gfx] [PATCH v2] drm/i915/tc: Fix -Wformat-truncation in intel_tc_port_init

2023-10-26 Thread Nirmoy Das
On 10/26/2023 12:11 PM, Imre Deak wrote: On Thu, Oct 26, 2023 at 12:05:13PM +0300, Imre Deak wrote: On Wed, Oct 25, 2023 at 07:08:34PM +0200, Nirmoy Das wrote: Fix below compiler warning: intel_tc.c:1879:11: error: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a

Re: [Intel-gfx] Regression on linux-next (next-20231013)

2023-10-26 Thread Borah, Chaitanya Kumar
Hello Christian, > -Original Message- > From: Borah, Chaitanya Kumar > Sent: Wednesday, October 25, 2023 7:15 PM > To: Christian Brauner > Cc: intel-gfx@lists.freedesktop.org; Kurmi, Suresh Kumar > ; Saarinen, Jani > Subject: RE: Regression on linux-next (next-20231013) > > Hello

[Intel-gfx] [CI 2/2] drm/i915: move Makefile display debugfs files next to display

2023-10-26 Thread Jani Nikula
Keep the display build lists together. v2: Rebase Reviewed-by: Nirmoy Das Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index

[Intel-gfx] [CI 1/2] drm/i915: fix Makefile sort and indent

2023-10-26 Thread Jani Nikula
Unify the line continuations and indents, and sort the build lists. Reviewed-by: Nirmoy Das Signed-off-by: Jani Nikula --- Note: This is easiest to review by applying and looking at 'git show -w' --- drivers/gpu/drm/i915/Makefile | 169 ++ 1 file changed, 89

Re: [Intel-gfx] [PATCH v2] drm/i915/tc: Fix -Wformat-truncation in intel_tc_port_init

2023-10-26 Thread Imre Deak
On Thu, Oct 26, 2023 at 12:05:13PM +0300, Imre Deak wrote: > On Wed, Oct 25, 2023 at 07:08:34PM +0200, Nirmoy Das wrote: > > Fix below compiler warning: > > > > intel_tc.c:1879:11: error: ‘%d’ directive output may be truncated > > writing between 1 and 11 bytes into a region of size 3 > >

Re: [Intel-gfx] [PATCH 2/3] drm/i915/hdcp: Create a blanket hdcp enable function

2023-10-26 Thread Jani Nikula
On Thu, 26 Oct 2023, Suraj Kandpal wrote: > Let's create a blanket function which just has some conditions > which need to be checked before connectors enable hdcp. > This cleans up code and avoids code duplication. This series has two 2/3 patches... confused me, probably going to confuse CI

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence

2023-10-26 Thread Hogander, Jouni
On Wed, 2023-10-25 at 17:18 +0300, Ville Syrjälä wrote: > On Fri, Oct 20, 2023 at 12:41:03PM +0300, Jouni Högander wrote: > > We are preparing for Xe driver. Xe driver doesn't have > > i915_sw_fence > > implementation. Lets drop i915_sw_fence usage from display code and > > use dma_fence

[Intel-gfx] [PATCH 3/3] drm/i915/hdcp: Add more conditions to enable hdcp

2023-10-26 Thread Suraj Kandpal
When we dock a monitor we end up with a enable and disable connector cycle but if hdcp content is running we get the userspace in enabled state and driver maintaining a undesired state which causes the content to stop playing and we only enabe hdcp if the userspace state in desired. This patch

[Intel-gfx] [PATCH 2/3] drm/i915/hdcp: Create a blanket hdcp enable function

2023-10-26 Thread Suraj Kandpal
Let's create a blanket function which just has some conditions which need to be checked before connectors enable hdcp. This cleans up code and avoids code duplication. --v3 -Keep function name as intel_hdcp_enable() [Jani] Signed-off-by: Suraj Kandpal ---

[Intel-gfx] [PATCH 1/3] drm/i915/hdcp: Rename HCDP 1.4 enablement function

2023-10-26 Thread Suraj Kandpal
Rename hdcp 1.4 enablement function from _intel_hdcp_enable to intel_hdcp1_enable to better represent what version of hdcp is being enabled Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH 0/3] drm/i915/hdcp: Additional conditions to enable hdcp

2023-10-26 Thread Suraj Kandpal
We are seeing a issue when we close the lid of a laptop or dock a monitor hdcp content is not being reenabled automatically this is because when we dock a monitor we end up with a enable and disable connector cycle but if hdcp content is running we get the userspace in enabled state and driver

[Intel-gfx] [PATCH 2/3] drm/i915/hdcp: Convert intel_hdcp_enable to a blanket function

2023-10-26 Thread Suraj Kandpal
Let's convert intel_hdcp_enable to a blanket function which just has some conditions which needs to be checked before connectors enable hdcp. This cleans up code and avoids code duplication. --v3 -Keep function name as intel_hdcp_enable() [Jani] Signed-off-by: Suraj Kandpal ---

Re: [Intel-gfx] [PATCH] file, i915: fix file reference for mmap_singleton()

2023-10-26 Thread Tvrtko Ursulin
On 25/10/2023 16:23, Jann Horn wrote: On Wed, Oct 25, 2023 at 2:01 PM Christian Brauner wrote: Today we got a report at [1] for rcu stalls on the i915 testsuite in [2] due to the conversion of files to SLAB_TYPSSAFE_BY_RCU. Afaict, get_file_rcu() goes into an infinite loop trying to

Re: [Intel-gfx] [PATCH v4 00/23] Framework for display parameters

2023-10-26 Thread Hogander, Jouni
On Tue, 2023-10-24 at 15:40 +0300, Jouni Högander wrote: > Currently all module parameters are handled by i915_param.c/h. This > is a problem for display parameters when Xe driver is used. > > This patch set adds a mechanism to add parameters specific to the > display. This is mainly copied from

Re: [Intel-gfx] [PATCH v2] drm/i915/tc: Fix -Wformat-truncation in intel_tc_port_init

2023-10-26 Thread Imre Deak
On Wed, Oct 25, 2023 at 07:08:34PM +0200, Nirmoy Das wrote: > Fix below compiler warning: > > intel_tc.c:1879:11: error: ‘%d’ directive output may be truncated > writing between 1 and 11 bytes into a region of size 3 > [-Werror=format-truncation=] > "%c/TC#%d", port_name(port), tc_port + 1); >

Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove {} from if-else

2023-10-26 Thread Andi Shyti
Hi Soumya, On Wed, Oct 25, 2023 at 09:43:08PM -0700, Soumya Negi wrote: > In accordance to Linux coding style(Documentation/process/4.Coding.rst), > remove unneeded braces from if-else block as all arms of this block > contain single statements. > > Suggested-by: Andi Shyti > Signed-off-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: Additional conditions to enable hdcp (rev2)

2023-10-26 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Additional conditions to enable hdcp (rev2) URL : https://patchwork.freedesktop.org/series/125550/ State : success == Summary == CI Bug Log - changes from CI_DRM_13787 -> Patchwork_125550v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/hdcp: Additional conditions to enable hdcp (rev2)

2023-10-26 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Additional conditions to enable hdcp (rev2) URL : https://patchwork.freedesktop.org/series/125550/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove {} from if-else

2023-10-26 Thread Karolina Stolarek
On 26.10.2023 06:43, Soumya Negi wrote: In accordance to Linux coding style(Documentation/process/4.Coding.rst), remove unneeded braces from if-else block as all arms of this block contain single statements. I'd just keep the description simple, and say that braces are not needed for single

Re: [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Create a blanket hdcp enable function

2023-10-26 Thread Jani Nikula
On Thu, 26 Oct 2023, "Kandpal, Suraj" wrote: >> -Original Message- >> From: Jani Nikula >> Sent: Thursday, October 26, 2023 1:02 PM >> To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org >> Cc: Shankar, Uma ; Nautiyal, Ankit K >> ; Kandpal, Suraj >> Subject: Re: [PATCH 1/2]

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Remove {} from if-else

2023-10-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Remove {} from if-else URL : https://patchwork.freedesktop.org/series/125614/ State : success == Summary == CI Bug Log - changes from CI_DRM_13787 -> Patchwork_125614v1 Summary ---

Re: [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Create a blanket hdcp enable function

2023-10-26 Thread Kandpal, Suraj
> -Original Message- > From: Jani Nikula > Sent: Thursday, October 26, 2023 1:02 PM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Cc: Shankar, Uma ; Nautiyal, Ankit K > ; Kandpal, Suraj > Subject: Re: [PATCH 1/2] drm/i915/hdcp: Create a blanket hdcp enable function > > On

Re: [Intel-gfx] [PATCH v3] drm/i915/dsb: DSB code refactoring

2023-10-26 Thread Luca Coelho
On Sun, 2023-10-08 at 15:42 +0530, Animesh Manna wrote: > Refactor DSB implementation to be compatible with Xe driver. > > v1: RFC version. > v2: Make intel_dsb structure opaque from external usage. [Jani] > v3: Rebased on latest. > > Cc: Jani Nikula > Signed-off-by: Animesh Manna > --- Looks

Re: [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Create a blanket hdcp enable function

2023-10-26 Thread Jani Nikula
On Thu, 26 Oct 2023, Suraj Kandpal wrote: > Let's create a blanket function which just has some conditions > which need to be checked before connectors enable hdcp. > This cleans up code and avoids code duplication. Let's call that function intel_hdcp_enable(), and hide all the details inside

[Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Create a blanket hdcp enable function

2023-10-26 Thread Suraj Kandpal
Let's create a blanket function which just has some conditions which need to be checked before connectors enable hdcp. This cleans up code and avoids code duplication. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_ddi.c| 5 +

[Intel-gfx] [PATCH 2/2] drm/i915/hdcp: Add more conditions to enable hdcp

2023-10-26 Thread Suraj Kandpal
When we dock a monitor we end up with a enable and disable connector cycle but if hdcp content is running we get the userspace in enabled state and driver maintaining a undesired state which causes the content to stop playing and we only enabe hdcp if the userspace state in desired. This patch

[Intel-gfx] [PATCH 0/2] drm/i915/hdcp: Additional conditions to enable hdcp

2023-10-26 Thread Suraj Kandpal
We are seeing a issue when we close the lid of a laptop or dock a monitor hdcp content is not being reenabled automatically this is because when we dock a monitor we end up with a enable and disable connector cycle but if hdcp content is running we get the userspace in enabled state and driver