[PATCH 21/21] drm/i915: remove intel_memory_region_ops::flags

2024-02-15 Thread Jiri Slaby (SUSE)
intel_memory_region_ops::flags was never used since its addition in commit 232a6ebae419 (drm/i915: introduce intel_memory_region). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko

[PATCH 20/21] drm/i915: remove i915_vma::obj_hash

2024-02-15 Thread Jiri Slaby (SUSE)
i915_vma::obj_hash was never used since its addition in commit 4ff4b44cbb70 (drm/i915: Store a direct lookup from object handle to vma). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc:

[PATCH 19/21] drm/i915: remove execute_cb::signal

2024-02-15 Thread Jiri Slaby (SUSE)
execute_cb::signal is not used since commit 5ac545b8b014 (drm/i915/request: Remove the hook from await_execution). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc:

[PATCH 18/21] drm/i915: remove intel_gvt_irq::pending_events

2024-02-15 Thread Jiri Slaby (SUSE)
intel_gvt_irq::pending_events was never used since its addition in commit c8fe6a6811a7 (drm/i915/gvt: vGPU interrupt virtualization.). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko

[PATCH 17/21] drm/i915: remove intel_gvt_event_info::policy

2024-02-15 Thread Jiri Slaby (SUSE)
intel_gvt_event_info::policy was never used since its addition in commit c8fe6a6811a7 (drm/i915/gvt: vGPU interrupt virtualization.). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko

[PATCH 16/21] drm/i915: remove intel_gvt_irq_info::warned

2024-02-15 Thread Jiri Slaby (SUSE)
intel_gvt_irq_info::warned was never used since its addition in commit c8fe6a6811a7 (drm/i915/gvt: vGPU interrupt virtualization.). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko

[PATCH 15/21] drm/i915: remove gvt_mmio_block::device

2024-02-15 Thread Jiri Slaby (SUSE)
gvt_mmio_block::device is not used since commit e0f74ed4634d (i915/gvt: Separate the MMIO tracking table from GVT-g). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc:

[PATCH 14/21] drm/i915: remove intel_vgpu::intx_trigger

2024-02-15 Thread Jiri Slaby (SUSE)
intel_vgpu::intx_trigger was never used since its addition in commit f30437c5e7bf (drm/i915/gvt: add KVMGT support). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc:

[PATCH 13/21] drm/i915: remove intel_vgpu_opregion::mapped

2024-02-15 Thread Jiri Slaby (SUSE)
intel_vgpu_opregion::mapped is not used since commit 367748066eeb (drm/i915/gvt: remove enum hypervisor_type). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc:

[PATCH 12/21] drm/i915: remove intel_vgpu_fence::base

2024-02-15 Thread Jiri Slaby (SUSE)
intel_vgpu_fence::base was never used since its addition in commit 28a60dee2ce6 (drm/i915/gvt: vGPU HW resource management). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin

[PATCH 11/21] drm/i915: remove intel_vgpu_gtt::active_ppgtt_mm_bitmap

2024-02-15 Thread Jiri Slaby (SUSE)
intel_vgpu_gtt::active_ppgtt_mm_bitmap was never used since its addition in commit 2707e4446688 (drm/i915/gvt: vGPU graphics memory virtualization). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo

[PATCH 10/21] drm/i915: remove i915_perf_stream::size_exponent

2024-02-15 Thread Jiri Slaby (SUSE)
i915_perf_stream::size_exponent was never used since its addition in commit a37f08a882b0 (drm/i915/perf: Refactor oa object to better manage resources). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc:

[PATCH 09/21] drm/i915: remove i915_drm_client::id

2024-02-15 Thread Jiri Slaby (SUSE)
i915_drm_client::id is not used since commit e894b724c316 (drm/i915: Use the fdinfo helper). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc:

[PATCH 07/21] drm/i915: remove intel_vbt_panel_data::edp::initialized

2024-02-15 Thread Jiri Slaby (SUSE)
intel_vbt_panel_data::edp::initialized is not used since commit 9f0e7ff4b366 (drm/i915: fetch eDP configuration data from the VBT). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko

[PATCH 08/21] drm/i915: remove intel_guc::ads_engine_usage_size

2024-02-15 Thread Jiri Slaby (SUSE)
intel_guc::ads_engine_usage_size was never used since its addition in commit 77cdd054dd2c (drm/i915/pmu: Connect engine busyness stats from GuC to pmu). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc:

[PATCH 06/21] drm/i915: remove intel_vgpu_workload::{ring_context, restore_inhibit}

2024-02-15 Thread Jiri Slaby (SUSE)
intel_vgpu_workload::ring_context was never used since its addition in commit 28c4c6ca7f79 (drm/i915/gvt: vGPU workload submission) and ::restore_inhibit since its addition in commit e473405783c0 (drm/i915/gvt: vGPU workload scheduler). Drop them. Found by

[PATCH 05/21] drm/i915: remove intel_gvt_mmio_info::{device, addr_range}

2024-02-15 Thread Jiri Slaby (SUSE)
intel_gvt_mmio_info::device is not used since commit e0f74ed4634d (i915/gvt: Separate the MMIO tracking table from GVT-g) and ::addr_range was never used since its addition in commit 12d14cc43b34 (drm/i915/gvt: Introduce a framework for tracking HW registers.). Drop them. Found by

[PATCH 04/21] drm/i915: remove intel_gvt_gtt::{mm_alloc_page_table, mm_free_page_table}

2024-02-15 Thread Jiri Slaby (SUSE)
intel_gvt_gtt::{mm_alloc_page_table,mm_free_page_table} are not used since commit ede9d0cfcb78 (drm/i915/gvt: Rework shadow graphic memory management code). Drop them. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc:

[PATCH 00/21] drm/i915: remove unused structure members

2024-02-15 Thread Jiri Slaby (SUSE)
Hi, this series removes unused i915 structure members as found by clang-struct (and manually checked by me). Cc: intel-gfx@lists.freedesktop.org Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Jiri Slaby (SUSE) (21): drm/i915: remove unused intel_dvo_dev_ops hooks

[PATCH 02/21] drm/i915: remove structs intel_vgpu_pipe_format and intel_vgpu_fb_format

2024-02-15 Thread Jiri Slaby (SUSE)
Both struct intel_vgpu_pipe_format and intel_vgpu_fb_format were never used since its addition in commit 9f31d1063b43 (drm/i915/gvt: Add framebuffer decoder support). Drop them. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas

[PATCH 01/21] drm/i915: remove unused intel_dvo_dev_ops hooks

2024-02-15 Thread Jiri Slaby (SUSE)
struct intel_dvo_dev_ops's ::create_resources(), ::prepare(), ::commit::, and get_modes() are all unused since their addition in 79e539453b34 (DRM: i915: add mode setting support). Drop all of them. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani

[PATCH 03/21] drm/i915: remove intel_dsi::{port_bits,hs}

2024-02-15 Thread Jiri Slaby (SUSE)
intel_dsi::port_bits is unused since commit 369602d370fa (drm/i915: Add support for port enable/disable for dual link configuration) and ::hs is unused likely since commit 063c86f60ad4 (drm/i915/dsi: remove intel_dsi_cmd.c and the unused functions therein). Drop them. Found by

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-15 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240215] [If your patch is applied to the wrong git tree, kindly drop us

RE: [RFC 0/5] Introduce drm sharpening property

2024-02-15 Thread Garg, Nemesa
It is not intel specific and the goal is to have a generic API for configuring Sharpness, accessible to various vendors. Intel currently offers sharpness support through the Display Engine, while other vendors seem to support Sharpness through the GPU using GL shaders (Vulcan/Open GL based).

Re: [PATCH 11/13] drm/i915/hdcp: Don't enable HDCP1.4 directly from check_link

2024-02-15 Thread Nautiyal, Ankit K
On 2/15/2024 4:29 PM, Suraj Kandpal wrote: Whenever LIC fails instead of moving from ENABLED to DESIRED CP property we directly enable HDCP1.4 without informing the userspace of this failure in link integrity check. Now we will just update the value to DESIRED send the event to userspace and

Re: [PATCH 10/13] drm/i915/hdcp: Don't enable HDCP2.2 directly from check_link

2024-02-15 Thread Nautiyal, Ankit K
On 2/15/2024 4:29 PM, Suraj Kandpal wrote: Whenever LIC fails instead of moving from ENABLED to DESIRED CP property we directly enable HDCP2.2 without informing the userspace of this failure in link integrity check. Now we will just update the value to DESIRED send the event to userspace and

Re: [PATCH 12/13] drm/i915/hdcp: Allocate stream id after HDCP AKE stage

2024-02-15 Thread Nautiyal, Ankit K
On 2/15/2024 4:29 PM, Suraj Kandpal wrote: Allocate stream id after HDCP AKE stage and not before so that it can also be done during link integrity check. Right now for MST scenarios LIC fails after hdcp enablement for this reason. --v2 -no need for else block in prepare_streams function

Re: [PULL] drm-intel-gt-next

2024-02-15 Thread Dave Airlie
On Thu, 15 Feb 2024 at 20:06, Tvrtko Ursulin wrote: > > Hi Dave, Daniel, > > First pull request for 6.9 with probably one more coming in one to two > weeks. > > Nothing to interesting in this one, mostly a sprinkle of small fixes in > GuC, HuC, Perf/OA, a tiny bit of prep work for future

Re: [PATCH 4/6] drm/i915/psr: Silence period and lfps half cycle

2024-02-15 Thread kernel test robot
Hi Jouni, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip next-20240215] [cannot apply to drm-intel/for-linux-next-fixes drm/drm-next linus/master v6.8-rc4] [If your patch is applied

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-15 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240215] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-15 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240215] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-15 Thread John Harrison
On 2/15/2024 14:34, Andi Shyti wrote: Hi John, On Thu, Feb 15, 2024 at 01:23:24PM -0800, John Harrison wrote: On 2/15/2024 05:59, Andi Shyti wrote: Since CCS automatic load balancing is disabled, we will impose a fixed balancing policy that involves setting all the CCS engines to work

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-15 Thread Andi Shyti
Hi John, On Thu, Feb 15, 2024 at 01:23:24PM -0800, John Harrison wrote: > On 2/15/2024 05:59, Andi Shyti wrote: > > Since CCS automatic load balancing is disabled, we will impose a > > fixed balancing policy that involves setting all the CCS engines > > to work together on the same load. > > > >

Re: [PATCH 2/2] i915/pmu: Cleanup pending events on unbind

2024-02-15 Thread kernel test robot
Hi Umesh, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240215] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-15 Thread John Harrison
On 2/15/2024 05:59, Andi Shyti wrote: Since CCS automatic load balancing is disabled, we will impose a fixed balancing policy that involves setting all the CCS engines to work together on the same load. Simultaneously, the user will see only 1 CCS rather than the actual number. As of now, this

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-15 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240215] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-15 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240215] [If your patch is applied to the wrong git tree, kindly drop us a note

[PATCH v5] drm/dp: add an API to indicate if sink supports VSC SDP

2024-02-15 Thread Abhinav Kumar
From: Paloma Arellano YUV420 format is supported only in the VSC SDP packet and not through MSA. Hence add an API which indicates the sink support which can be used by the rest of the DP programming. changes in v5: - rebased on top of drm-tip changes in v4: - bail out early if

[PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-15 Thread Abhinav Kumar
intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. Lets move this to drm_dp_helper to achieve this. changes in v2: - rebased on top of drm-tip Acked-by: Dmitry Baryshkov Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/display/drm_dp_helper.c | 78

Re: [PATCH v6 3/5] drm: Add support to get EDID from ACPI

2024-02-15 Thread Mario Limonciello
On 2/15/2024 12:47, Ville Syrjälä wrote: On Thu, Feb 15, 2024 at 12:20:56PM -0600, Mario Limonciello wrote: On 2/14/2024 17:13, Ville Syrjälä wrote: On Wed, Feb 14, 2024 at 03:57:54PM -0600, Mario Limonciello wrote: Some manufacturers have intentionally put an EDID that differs from the EDID

Re: [PATCH v6 3/5] drm: Add support to get EDID from ACPI

2024-02-15 Thread Ville Syrjälä
On Thu, Feb 15, 2024 at 12:20:56PM -0600, Mario Limonciello wrote: > On 2/14/2024 17:13, Ville Syrjälä wrote: > > On Wed, Feb 14, 2024 at 03:57:54PM -0600, Mario Limonciello wrote: > >> Some manufacturers have intentionally put an EDID that differs from > >> the EDID on the internal panel on

Re: [PATCH v6 3/5] drm: Add support to get EDID from ACPI

2024-02-15 Thread Mario Limonciello
On 2/14/2024 17:13, Ville Syrjälä wrote: On Wed, Feb 14, 2024 at 03:57:54PM -0600, Mario Limonciello wrote: Some manufacturers have intentionally put an EDID that differs from the EDID on the internal panel on laptops. Drivers that prefer to fetch this EDID can set a bit on the drm_connector

Re: [PATCH 1/2] drm/i915/gt: Disable HW load balancing for CCS

2024-02-15 Thread Matt Roper
On Thu, Feb 15, 2024 at 02:59:23PM +0100, Andi Shyti wrote: > The hardware should not dynamically balance the load between CCS > engines. Wa_16016805146 recommends disabling it across all Is this the right workaround number? When I check the database, this workaround was rejected on both DG2-G10

Re: [RFC 0/5] Introduce drm sharpening property

2024-02-15 Thread Ville Syrjälä
On Thu, Feb 15, 2024 at 11:37:54AM -0500, Harry Wentland wrote: > Adding a couple of compositor devs as they might be interested in this. > > On 2024-02-14 06:24, Nemesa Garg wrote: > > Many a times images are blurred or upscaled content is also not as > > crisp as original rendered image.

Re: Re: [PULL] drm-misc-fixes

2024-02-15 Thread Geert Uytterhoeven
> > > Please drop this one. > > > > nore...@ellerman.id.au reported a build failure on m68k (and presumably > > other 32-bit platforms) in next-20240215: > > > > ERROR: modpost: "__umoddi3" [drivers/gpu/drm/tests/drm_buddy_test.ko] > >

[PATCH 12/12] drm/i915: Create the printer only once in intel_pipe_config_compare()

2024-02-15 Thread Ville Syrjala
From: Ville Syrjälä Create the drm_printer at the start of intel_pipe_config_compare() and pass it on to all the mismatch() functions. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 101 +-- 1 file changed, 46 insertions(+), 55 deletions(-)

[PATCH 11/12] drm/i915: Reuse pipe_config_mismatch() more

2024-02-15 Thread Ville Syrjala
From: Ville Syrjälä Just call pipe_config_mismatch() from all the more specialized mismatch() functions instead of hand rolling the same printfs all over. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 45 +--- 1 file changed, 10 insertions(+),

[PATCH 10/12] drm/i915: Relocate pipe_config_mismatch()

2024-02-15 Thread Ville Syrjala
From: Ville Syrjälä Hoist pipe_config_mismatch() upwards a bit so that it can get reused by the other mismatch() functions. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 46 ++-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git

[PATCH 09/12] drm/i915: Skip intel_crtc_state_dump() if debugs aren't enabled

2024-02-15 Thread Ville Syrjala
From: Ville Syrjälä intel_crtc_state_dump() does a whole boatload of string formatting which is all wasted energy if the debugs aren't even enabled. Skip the whole thing in that case. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 3 +++ 1 file

[PATCH 08/12] drm/i915: Convert the remaining state dump to drm_printer

2024-02-15 Thread Ville Syrjala
From: Ville Syrjälä Plumb the drm_printer to all the little helpers called by intel_crtc_state_dump() and use it there as well. The exceptions are the ELD and infoframe stuff as they call helpers outside of the drm and thus can't use drm_printer. Signed-off-by: Ville Syrjälä ---

[PATCH 07/12] drm/i915: Use drm_printer more extensively in intel_crtc_state_dump()

2024-02-15 Thread Ville Syrjala
From: Ville Syrjälä Convert all the direct drm_dbg_kms() stuff in intel_crtc_state_dump() over to drm_printf() since we now have the drm_printer around. Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_crtc_state_dump.c | 185 -- 1 file changed, 87 insertions(+),

[PATCH 06/12] drm/i915: Convert intel_dpll_dump_hw_state() to drm_printer

2024-02-15 Thread Ville Syrjala
From: Ville Syrjälä Utilize drm_printer in pipe_config_pll_mismatch() to avoid a bit of code duplication. To achieve this we need to plumb the printer all way to the dpll_mgr .dump_hw_state() functions. Those are also used by intel_crtc_state_dump() which needs to be adjusted as well.

[PATCH 05/12] drm/i915: Convert pipe_config_buffer_mismatch() to drm_printer

2024-02-15 Thread Ville Syrjala
From: Ville Syrjälä Utilize drm_printer in pipe_config_infoframe_mismatch() to avoid a bit of code duplication. print_hex_dump() doesn't know anything about the printer so it still needs the DRM_UT_KMS check and special handling for the loglevel. But at least we end up with a bit less

[PATCH 04/12] drm/i915: Convert pipe_config_infoframe_mismatch() to drm_printer

2024-02-15 Thread Ville Syrjala
From: Ville Syrjälä Utilize drm_printer in pipe_config_infoframe_mismatch() to avoid a bit of code duplication. hdmi_infoframe_log() can't use the printer of course, but for that we can just figure out which loglevel to use. And we do need to keep the explicit drm_debug_enabled(DRM_UT_KMS)

[PATCH 03/12] drm/i915: Include CRTC info in VSC SDP mismatch prints

2024-02-15 Thread Ville Syrjala
From: Ville Syrjälä Most crtc state mismatches include the CRTC id+name in the prints. Also include it in the VSC SDP mismatches. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git

[PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-15 Thread Ville Syrjala
From: Ville Syrjälä intel_crtc_check_fastset() is done per-pipe, so it would be nice to know which pipe it was that failed its checkup. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 02/12] drm/i915: Include CRTC info in infoframe mismatch prints

2024-02-15 Thread Ville Syrjala
From: Ville Syrjälä Most crtc state mismatches include the CRTC id+name in the prints. Also include it in the infoframe mismatches. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

[PATCH 00/12] drm/i915: Use drm_printer more

2024-02-15 Thread Ville Syrjala
From: Ville Syrjälä Convert the entire state dumper and state checker to use drm_printer. One can perhaps consider this as the first step towards hooking into .atomic_print_state(). Unfortunately that stuff is a full blown midlayer currently, so we'd first have to demidlayer it to make it work

Re: [RFC 0/5] Introduce drm sharpening property

2024-02-15 Thread Harry Wentland
Adding a couple of compositor devs as they might be interested in this. On 2024-02-14 06:24, Nemesa Garg wrote: > Many a times images are blurred or upscaled content is also not as > crisp as original rendered image. Traditional sharpening techniques often > apply a uniform level of

Re: Re: [PULL] drm-misc-fixes

2024-02-15 Thread Maxime Ripard
(1): > > drm/tests/drm_buddy: add alloc_contiguous test > > Please drop this one. > > nore...@ellerman.id.au reported a build failure on m68k (and presumably > other 32-bit platforms) in next-20240215: > > ERROR: modpost: "__umoddi3" [drivers/gpu/drm/test

2024 X.Org Board of Directors Elections Nomination period is NOW

2024-02-15 Thread Christopher Michael
We are seeking nominations for candidates for election to the X.Org Foundation Board of Directors. All X.Org Foundation members are eligible for election to the board. Nominations for the 2024 election are now open and will remain open until 23:59 UTC on 26 February 2024. The Board consists

Re: [PATCH 2/6] drm/i915/psr: Calculate aux less wake time

2024-02-15 Thread Ville Syrjälä
On Thu, Feb 15, 2024 at 12:49:30PM +0200, Jouni Högander wrote: > Calculate aux less wake time and store it into alpm_params struct > > Bspec: 71477 > > Signed-off-by: Jouni Högander > --- > .../drm/i915/display/intel_display_types.h| 1 + > drivers/gpu/drm/i915/display/intel_psr.c |

Re: [PATCH v2 2/6] drm/i915/mst: improve debug logging of DP MST mode detect

2024-02-15 Thread Ville Syrjälä
On Thu, Feb 15, 2024 at 01:46:48PM +0200, Jani Nikula wrote: > On Wed, 14 Feb 2024, Ville Syrjälä wrote: > > On Tue, Feb 13, 2024 at 01:30:57PM +0200, Jani Nikula wrote: > >> Rename intel_dp_can_mst() to intel_dp_mst_detect(), and move all DP MST > >> detect debug logging there. Debug log the

✗ Fi.CI.BAT: failure for Disable automatic load CCS load balancing

2024-02-15 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing URL : https://patchwork.freedesktop.org/series/129951/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14278 -> Patchwork_129951v1 Summary ---

✗ Fi.CI.SPARSE: warning for Disable automatic load CCS load balancing

2024-02-15 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing URL : https://patchwork.freedesktop.org/series/129951/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Disable automatic load CCS load balancing

2024-02-15 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing URL : https://patchwork.freedesktop.org/series/129951/ State : warning == Summary == Error: dim checkpatch failed 36e5f8a455e7 drm/i915/gt: Disable HW load balancing for CCS f1bfa29b3219 drm/i915/gt: Set default CCS mode

Re: [PATCH 0/6 V4] fdinfo shared stats

2024-02-15 Thread Alex Deucher
On Thu, Feb 15, 2024 at 9:18 AM Christian König wrote: > > Am 12.02.24 um 22:04 schrieb Alex Deucher: > > We had a request to add shared buffer stats to fdinfo for amdgpu and > > while implementing that, Christian mentioned that just looking at > > the GEM handle count doesn't take into account

Re: [PATCH v6 3/5] drm: Add support to get EDID from ACPI

2024-02-15 Thread Jani Nikula
On Thu, 15 Feb 2024, Ville Syrjälä wrote: > On Wed, Feb 14, 2024 at 03:57:54PM -0600, Mario Limonciello wrote: >> +static int >> +drm_do_probe_acpi_edid(void *data, u8 *buf, unsigned int block, size_t len) >> +{ >> +struct drm_connector *connector = data; >> +struct drm_device *ddev =

Re: [PATCH 0/6 V4] fdinfo shared stats

2024-02-15 Thread Christian König
Am 12.02.24 um 22:04 schrieb Alex Deucher: We had a request to add shared buffer stats to fdinfo for amdgpu and while implementing that, Christian mentioned that just looking at the GEM handle count doesn't take into account buffers shared with other subsystems like V4L or RDMA. Those

Re: [PATCH v6 3/5] drm: Add support to get EDID from ACPI

2024-02-15 Thread Jani Nikula
On Wed, 14 Feb 2024, Mario Limonciello wrote: > Some manufacturers have intentionally put an EDID that differs from > the EDID on the internal panel on laptops. Drivers that prefer to > fetch this EDID can set a bit on the drm_connector to indicate that > the DRM EDID helpers should try to fetch

[PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-15 Thread Andi Shyti
Since CCS automatic load balancing is disabled, we will impose a fixed balancing policy that involves setting all the CCS engines to work together on the same load. Simultaneously, the user will see only 1 CCS rather than the actual number. As of now, this change affects only DG2. Fixes:

[PATCH 1/2] drm/i915/gt: Disable HW load balancing for CCS

2024-02-15 Thread Andi Shyti
The hardware should not dynamically balance the load between CCS engines. Wa_16016805146 recommends disabling it across all platforms. Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement") Signed-off-by: Andi Shyti Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Matt Roper Cc: # v6.2+

[PATCH 0/2] Disable automatic load CCS load balancing

2024-02-15 Thread Andi Shyti
Hi, this series does basically two things: 1. Disables automatic load balancing as adviced by the hardware workaround. 2. Forces the sharing of the load submitted to CCS among all the CCS available (as of now only DG2 has more than one CCS). This way the user, when sending a query,

[PULL] drm-misc-next

2024-02-15 Thread Thomas Zimmermann
Hi Dave, Sima, here's the drm-misc-next PR for this week. The majority of changes comes from Jani's update of the internal EDID callbacks, which the bridge code now uses. There are also stability fixes for lima, improvements to print helpers, correct parent devices for firmware framebuffers, and

Re: [PULL] drm-misc-fixes

2024-02-15 Thread Geert Uytterhoeven
this one. nore...@ellerman.id.au reported a build failure on m68k (and presumably other 32-bit platforms) in next-20240215: ERROR: modpost: "__umoddi3" [drivers/gpu/drm/tests/drm_buddy_test.ko] undefined! ERROR: modpost: "__moddi3" [drivers/gpu/drm/tests/drm_buddy_test.ko] u

[PULL] drm-xe-fixes

2024-02-15 Thread Thomas Hellstrom
Hi Dave, Sima! The xe fixes pull request for -rc5. drm-xe-fixes-2024-02-15: Driver Changes: - Fix an out-of-bounds shift. - Fix the display code thinking xe uses shmem - Fix a warning about index out-of-bound - Fix a clang-16 compilation warning Thanks, Thomas The following changes since commit

✓ Fi.CI.BAT: success for HDCP MST Type1 fixes (rev2)

2024-02-15 Thread Patchwork
== Series Details == Series: HDCP MST Type1 fixes (rev2) URL : https://patchwork.freedesktop.org/series/129925/ State : success == Summary == CI Bug Log - changes from CI_DRM_14277 -> Patchwork_129925v2 Summary --- **SUCCESS** No

✗ Fi.CI.SPARSE: warning for HDCP MST Type1 fixes (rev2)

2024-02-15 Thread Patchwork
== Series Details == Series: HDCP MST Type1 fixes (rev2) URL : https://patchwork.freedesktop.org/series/129925/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1:

✓ Fi.CI.BAT: success for ALPM AUX-Less

2024-02-15 Thread Patchwork
== Series Details == Series: ALPM AUX-Less URL : https://patchwork.freedesktop.org/series/129938/ State : success == Summary == CI Bug Log - changes from CI_DRM_14277 -> Patchwork_129938v1 Summary --- **SUCCESS** No regressions

[PULL] drm-intel-fixes

2024-02-15 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes drm-intel-fixes towards v6.8-rc5. Two fixes. Fix for #10172 (blank screen on JSL Chromebooks) and limiting SST link rate within supported range. Best Regards, Joonas *** drm-intel-fixes-2024-02-15: Fix for #10172: Blank screen on JSL Chromebooks. Stable fix to limit

Re: [PATCH v2 2/6] drm/i915/mst: improve debug logging of DP MST mode detect

2024-02-15 Thread Jani Nikula
On Wed, 14 Feb 2024, Ville Syrjälä wrote: > On Tue, Feb 13, 2024 at 01:30:57PM +0200, Jani Nikula wrote: >> Rename intel_dp_can_mst() to intel_dp_mst_detect(), and move all DP MST >> detect debug logging there. Debug log the sink's MST capability, >> including single-stream sideband messaging

✗ Fi.CI.SPARSE: warning for ALPM AUX-Less

2024-02-15 Thread Patchwork
== Series Details == Series: ALPM AUX-Less URL : https://patchwork.freedesktop.org/series/129938/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for ALPM AUX-Less

2024-02-15 Thread Patchwork
== Series Details == Series: ALPM AUX-Less URL : https://patchwork.freedesktop.org/series/129938/ State : warning == Summary == Error: dim checkpatch failed eb5c1bef7e0e drm/display: Add missing aux less alpm wake related bits cc91271b2064 drm/i915/psr: Calculate aux less wake time

[PATCH 13/13] drm/i915/hdcp: Read Rxcaps for robustibility

2024-02-15 Thread Suraj Kandpal
We see some monitors and docks report incorrect hdcp version and capability in first few reads so we read rx_caps three times before we conclude the monitor's or docks HDCP capability --v2 -Add comment to justify the 3 time read loop for hdcp capability[Ankit] Signed-off-by: Suraj Kandpal

[PATCH 12/13] drm/i915/hdcp: Allocate stream id after HDCP AKE stage

2024-02-15 Thread Suraj Kandpal
Allocate stream id after HDCP AKE stage and not before so that it can also be done during link integrity check. Right now for MST scenarios LIC fails after hdcp enablement for this reason. --v2 -no need for else block in prepare_streams function [Ankit] Signed-off-by: Suraj Kandpal ---

[PATCH 11/13] drm/i915/hdcp: Don't enable HDCP1.4 directly from check_link

2024-02-15 Thread Suraj Kandpal
Whenever LIC fails instead of moving from ENABLED to DESIRED CP property we directly enable HDCP1.4 without informing the userspace of this failure in link integrity check. Now we will just update the value to DESIRED send the event to userspace and then continue with the normal flow of HDCP

[PATCH 09/13] drm/i915/hdcp: Extract hdcp structure from correct connector

2024-02-15 Thread Suraj Kandpal
Currently intel_hdcp is not being extracted from primary connector this patch fixes that. Fixes: 524240b231ea ("drm/i915/hdcp: Propagate aux info in DP HDCP functions") Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 7 +-- 1 file

[PATCH 10/13] drm/i915/hdcp: Don't enable HDCP2.2 directly from check_link

2024-02-15 Thread Suraj Kandpal
Whenever LIC fails instead of moving from ENABLED to DESIRED CP property we directly enable HDCP2.2 without informing the userspace of this failure in link integrity check. Now we will just update the value to DESIRED send the event to userspace and then continue with the normal flow of HDCP

[PATCH 08/13] drm/i915/hdcp: Remove additional timing for reading mst hdcp message

2024-02-15 Thread Suraj Kandpal
Now that we have moved back to direct reads the additional timing is not required hence this can be removed. --v2 -Add Fixes tag [Ankit] Fixes: 3974f9c17bb9 ("drm/i915/hdcp: Adjust timeout for read in DPMST Scenario") Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal ---

[PATCH 06/13] drm/i915/hdcp: Add new remote capability check shim function

2024-02-15 Thread Suraj Kandpal
Create a remote HDCP capability shim function which can read the remote monitor HDCP capability when in MST configuration. --v2 -Add an assertion to make sure only mst encoder call this remote_cap function [Ankit] --v3 -rename remote_hdcp_cap to remote_hdcp_capability [Jani] Signed-off-by:

[PATCH 07/13] drm/i915/hdcp: HDCP Capability for the downstream device

2024-02-15 Thread Suraj Kandpal
Currently we are only checking capability of remote device and not immediate downstream device but during capability check we need are concerned with only the HDCP capability of downstream device. During i915_display_info reporting we need HDCP Capability for both the monitors and downstream

[PATCH 05/13] drm/i915/hdcp: Rename hdcp capable functions

2024-02-15 Thread Suraj Kandpal
Rename hdcp_capable and hdcp_2_2_capable to hdcp_get_capability and hdcp_2_2_get_capability to properly reflect what these functions are doing. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_display_debugfs.c | 4 ++-- .../drm/i915/display/intel_display_types.h| 8 +++

[PATCH 03/13] drm/i915/hdcp: Refactor intel_dp_hdcp2_capable

2024-02-15 Thread Suraj Kandpal
Break intel_dp_hdcp2_capable so that the common the code can be reused for the remote capability check. Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

[PATCH 04/13] drm/i915/hdcp: Pass drm_dp_aux to read_bcaps function

2024-02-15 Thread Suraj Kandpal
Pass drm_dp_aux to intel_dp_hdcp_read_bcaps function so as to aid in reading the bcaps for the remote monitor later on. Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

[PATCH 02/13] drm/i915/hdcp: Move source hdcp2 checks into its own function

2024-02-15 Thread Suraj Kandpal
Move checks on the source side for HDCP2.2 into its own function so that they can be used in the HDCP remote capability check function. Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 20 +--- 1 file changed, 17

[PATCH 00/13] HDCP MST Type1 fixes

2024-02-15 Thread Suraj Kandpal
We were seeing a blank screen whenever Type1 content was played. This was due to extra timing which was taken as we had moved to remote read and writes previously for MST scenario, which in turn was done as we were not able to do direct read and writes to the immediate downstream device. The

[PATCH 01/13] drm/i915/hdcp: Move to direct reads for HDCP

2024-02-15 Thread Suraj Kandpal
Even for MST scenarios we need to do direct reads only on the immediate downstream device the rest of the authentication is taken care by that device. Remote reads will only be used to check capability of the monitors in MST topology. --v2 -Add fixes tag [Ankit] -Derive aux where needed rather

[PATCH 4/6] drm/i915/psr: Silence period and lfps half cycle

2024-02-15 Thread Jouni Högander
Add get function for silence period and lfps half cycle. Values are taken from the tables in bspec. Bspec: 71632 Signed-off-by: Jouni Högander --- .../drm/i915/display/intel_display_types.h| 2 + drivers/gpu/drm/i915/display/intel_psr.c | 77 ++- 2 files changed, 77

[PATCH 6/6] drm/i915/psr: Enable ALPM for eDP Panel replay

2024-02-15 Thread Jouni Högander
Enable ALPM AUX-Less for Panel Replay eDP. Also write all calculated AUX-Less configuration values accordingly. Bspec: 71477 Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 42 +--- 1 file changed, 38 insertions(+), 4 deletions(-) diff --git

[PATCH 1/6] drm/display: Add missing aux less alpm wake related bits

2024-02-15 Thread Jouni Högander
eDP1.5 adds some more bits into DP_RECEIVER_ALPM_CAP and DP_RECEIVER_ALPM_CONFIG registers. Add definitions for these. Signed-off-by: Jouni Högander --- include/drm/display/drm_dp.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/drm/display/drm_dp.h

  1   2   >