Re: [PATCH] drm/i915/ttm: Fix TTM_PL_FLAG_DESIRED

2024-02-27 Thread Christian König
Am 27.02.24 um 21:26 schrieb Ville Syrjala: From: Ville Syrjälä inlined from ‘i915_ttm_get_pages’ at ../drivers/gpu/drm/i915/gem/i915_gem_ttm.c:847:2: ../drivers/gpu/drm/i915/gem/i915_gem_ttm.c:165:18: warning: ‘places[0].flags’ is used uninitialized [-Wuninitialized] 165 |

✓ Fi.CI.BAT: success for XE HDCP Enablement (rev8)

2024-02-27 Thread Patchwork
== Series Details == Series: XE HDCP Enablement (rev8) URL : https://patchwork.freedesktop.org/series/129456/ State : success == Summary == CI Bug Log - changes from CI_DRM_14353 -> Patchwork_129456v8 Summary --- **SUCCESS** No

✗ Fi.CI.SPARSE: warning for XE HDCP Enablement (rev8)

2024-02-27 Thread Patchwork
== Series Details == Series: XE HDCP Enablement (rev8) URL : https://patchwork.freedesktop.org/series/129456/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./arch/x86/include/asm/bitops.h:116:1:

RE: [PATCH 1/4] drm/i915/hdcp: Move intel_hdcp_gsc_message def away from header file

2024-02-27 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Suraj > Kandpal > Sent: Tuesday, February 27, 2024 12:04 PM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Cc: Kandpal, Suraj > Subject: [PATCH 1/4] drm/i915/hdcp: Move intel_hdcp_gsc_message def away > from

[V2 1/2] drm/i915/drrs: Refactor CPU transcoder DRRS check

2024-02-27 Thread Bhanuprakash Modem
Rename cpu_transcoder_has_drrs() to intel_cpu_transcoder_has_drrs() and make it as non-static, therefore it can be re-used. V2: - Move helpers to intel_drrs.[ch] (Jani) - Fix commit message (Jani) Cc: Jani Nikula Cc: Ankit Nautiyal Cc: Mitul Golani Signed-off-by: Bhanuprakash Modem ---

RE: [PATCH 1/4] drm/i915/hdcp: Move intel_hdcp_gsc_message def away from header file

2024-02-27 Thread Kandpal, Suraj
> Subject: [PATCH 1/4] drm/i915/hdcp: Move intel_hdcp_gsc_message def away > from header file > > Move intel_hdcp_gsc_message definition into intel_hdcp_gsc.h so that > intel_hdcp_gsc_message can be redefined for xe as needed. > > --v2 > -Correct commit message to reflect what patch is

[PATCH 3/4] drm/xe: Use gsc_proxy_init_done to check proxy status

2024-02-27 Thread Suraj Kandpal
Expose gsc_proxy_init_done so that we can check if gsc proxy has been initialized or not. --v2 -Check if GSC FW is enabled before taking forcewake ref [Daniele] --v3 -Directly call forcewake get function inside if condition Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy Reviewed-by:

✓ Fi.CI.BAT: success for drm/i915/guc: Use context hints for GT freq

2024-02-27 Thread Patchwork
== Series Details == Series: drm/i915/guc: Use context hints for GT freq URL : https://patchwork.freedesktop.org/series/130463/ State : success == Summary == CI Bug Log - changes from CI_DRM_14352 -> Patchwork_130463v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm/i915/guc: Use context hints for GT freq

2024-02-27 Thread Patchwork
== Series Details == Series: drm/i915/guc: Use context hints for GT freq URL : https://patchwork.freedesktop.org/series/130463/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH v2] drm/i915/guc: Use context hints for GT freq

2024-02-27 Thread Vinay Belgaumkar
Allow user to provide a low latency context hint. When set, KMD sends a hint to GuC which results in special handling for this context. SLPC will ramp the GT frequency aggressively every time it switches to this context. The down freq threshold will also be lower so GuC will ramp down the GT freq

DisplayPort: handling of HPD events / link training

2024-02-27 Thread Dmitry Baryshkov
Hello, We are currently looking at checking and/or possibly redesigning the way the MSM DRM driver handles the HPD events and link training. After a quick glance at the drivers implementing DP support, I noticed following main approaches: - Perform link training at the atomic_enable time, don't

✗ Fi.CI.BAT: failure for drm/i915/ttm: Fix TTM_PL_FLAG_DESIRED

2024-02-27 Thread Patchwork
== Series Details == Series: drm/i915/ttm: Fix TTM_PL_FLAG_DESIRED URL : https://patchwork.freedesktop.org/series/130457/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14352 -> Patchwork_130457v1 Summary ---

✗ Fi.CI.CHECKPATCH: warning for drm/i915/ttm: Fix TTM_PL_FLAG_DESIRED

2024-02-27 Thread Patchwork
== Series Details == Series: drm/i915/ttm: Fix TTM_PL_FLAG_DESIRED URL : https://patchwork.freedesktop.org/series/130457/ State : warning == Summary == Error: dim checkpatch failed 23d3c3b71c2f drm/i915/ttm: Fix TTM_PL_FLAG_DESIRED -:9: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars

Re: [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2024-02-27 Thread Sebastian Wick
On Tue, Feb 27, 2024 at 09:35:22PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Add a new immutable plane property by which a plane can advertise > a handful of recommended plane sizes. This would be mostly exposed > by cursor planes as a slightly more capable replacement for > the

[PATCH] drm/i915/ttm: Fix TTM_PL_FLAG_DESIRED

2024-02-27 Thread Ville Syrjala
From: Ville Syrjälä inlined from ‘i915_ttm_get_pages’ at ../drivers/gpu/drm/i915/gem/i915_gem_ttm.c:847:2: ../drivers/gpu/drm/i915/gem/i915_gem_ttm.c:165:18: warning: ‘places[0].flags’ is used uninitialized [-Wuninitialized] 165 | places[0].flags |= TTM_PL_FLAG_DESIRED; |

✓ Fi.CI.BAT: success for drm: Add plane SIZE_HINTS property (rev5)

2024-02-27 Thread Patchwork
== Series Details == Series: drm: Add plane SIZE_HINTS property (rev5) URL : https://patchwork.freedesktop.org/series/113758/ State : success == Summary == CI Bug Log - changes from CI_DRM_14352 -> Patchwork_113758v5 Summary ---

✗ Fi.CI.SPARSE: warning for drm: Add plane SIZE_HINTS property (rev5)

2024-02-27 Thread Patchwork
== Series Details == Series: drm: Add plane SIZE_HINTS property (rev5) URL : https://patchwork.freedesktop.org/series/113758/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: GuC issue

2024-02-27 Thread John Harrison
On 2/26/2024 08:30, mak...@wezdecki.pl wrote: Hello, Thank you for your help. Is there a possibility to load GuC, then "unload" it and load it again without cold reset? You need to reset the GuC at least - bit 3 of GDRST. The GuC cannot be reloaded 'live'. It must be put into reset first.

✓ Fi.CI.BAT: success for Enable MST bigjoiner

2024-02-27 Thread Patchwork
== Series Details == Series: Enable MST bigjoiner URL : https://patchwork.freedesktop.org/series/130449/ State : success == Summary == CI Bug Log - changes from CI_DRM_14352 -> Patchwork_130449v1 Summary --- **SUCCESS** No

[PATCH v2 2/2] drm/i915: Add SIZE_HINTS property for cursors

2024-02-27 Thread Ville Syrjala
From: Ville Syrjälä Advertize more suitable cursor sizes via the new SIZE_HINTS plane property. We can't really enumerate all supported cursor sizes on the platforms where the cursor height can vary freely, so for simplicity we'll just expose all square+POT sizes between each platform's min and

[PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2024-02-27 Thread Ville Syrjala
From: Ville Syrjälä Add a new immutable plane property by which a plane can advertise a handful of recommended plane sizes. This would be mostly exposed by cursor planes as a slightly more capable replacement for the DRM_CAP_CURSOR_WIDTH/HEIGHT caps, which can only declare a one size fits all

[PATCH v2 0/2] drm: Add plane SIZE_HINTS property

2024-02-27 Thread Ville Syrjala
From: Ville Syrjälä Final version for a new plane SIZE_HINTS property to essentially replace the cursor size caps, based on recent discussion in this gitlab bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7687 As for userspace, so far I only did a quick modetest blob decoder (mainly to

✗ Fi.CI.BUILD: failure for series starting with [1/3] mei: me: add arrow lake point S DID

2024-02-27 Thread Patchwork
== Series Details == Series: series starting with [1/3] mei: me: add arrow lake point S DID URL : https://patchwork.freedesktop.org/series/130445/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/130445/revisions/1/mbox/ not applied Applying: mei:

✗ Fi.CI.BUILD: failure for Display experiment + GuC Display Metrics

2024-02-27 Thread Patchwork
== Series Details == Series: Display experiment + GuC Display Metrics URL : https://patchwork.freedesktop.org/series/130437/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/130437/revisions/1/mbox/ not applied Applying: drm/i915/display: Introduce

Re: [PATCH] drm/i915/guc: Correct capture of EIR register on hang

2024-02-27 Thread Teres Alexis, Alan Previn
On Fri, 2024-02-23 at 12:32 -0800, john.c.harri...@intel.com wrote: > From: John Harrison alan:snip > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c > @@ -51,6 +51,7 @@ > { RING_ESR(0),  0,  0, "ESR" }, \ >  

RE: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-27 Thread Srinivas, Vidya
> -Original Message- > From: Lisovskiy, Stanislav > Sent: Tuesday, February 27, 2024 2:44 PM > To: Srinivas, Vidya > Cc: Jani Nikula ; > intel-gfx@lists.freedesktop.org; > Saarinen, Jani ; ville.syrj...@linux.intel.com > Subject: Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

RE: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-27 Thread Srinivas, Vidya
> -Original Message- > From: Manasi Navare > Sent: Tuesday, February 27, 2024 11:37 PM > To: Jani Nikula > Cc: Lisovskiy, Stanislav ; intel- > g...@lists.freedesktop.org; Saarinen, Jani ; > ville.syrj...@linux.intel.com; Srinivas, Vidya > Subject: Re: [PATCH 3/3] drm/i915: Fix

[PATCH 2/2] drm/i915: Allow bigjoiner for MST

2024-02-27 Thread Vidya Srinivas
We need bigjoiner support with MST functionality for MST monitor resolutions > 5K to work. Adding support for the same. Signed-off-by: Vidya Srinivas --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git

[PATCH 1/2] Revert "drm/i915/mst: Reject modes that require the bigjoiner"

2024-02-27 Thread Vidya Srinivas
This reverts commit 9c058492b16f90bb772cb0dad567e8acc68e155d. Reverting for adding MST bigjoiner functionality. Signed-off-by: Vidya Srinivas --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c

[PATCH 0/2] Enable MST bigjoiner

2024-02-27 Thread Vidya Srinivas
Series reverts rejection of modes on MST monitors that need bigjoiner and adds MST bigjoiner functionality Vidya Srinivas (2): Revert "drm/i915/mst: Reject modes that require the bigjoiner" drm/i915: Allow bigjoiner for MST drivers/gpu/drm/i915/display/intel_dp_mst.c | 17 +

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-27 Thread Ville Syrjälä
On Tue, Feb 27, 2024 at 10:38:10AM +0100, Rasmus Villemoes wrote: > On 26/02/2024 15.57, Jani Nikula wrote: > > > Personally I suck at remembering even the standard printf conversion > > specifiers, let alone all the kernel extensions. I basically have to > > look them up every time. I'd really

Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-27 Thread Manasi Navare
Thanks Jani for your review. Thanks @Lisovskiy, Stanislav and @vidya.srini...@intel.com for taking this patch forward. @Jani Nikula , @Ville Syrjälä : MST bigjoiner as a feature needs to be enabled upstream and this patch enables that feature. If you agree that bigjoiner refactoring patches 1

RE: Linux 6.7 fails to boot on Core Ultra 155H with "i915 GT1 GSC proxy" error

2024-02-27 Thread Saarinen, Jani
Hi, > -Original Message- > From: Saarinen, Jani > Sent: Tuesday, February 27, 2024 6:58 PM > To: Jani Nikula ; Roman Lozko > ; intel-gfx@lists.freedesktop.org > Subject: RE: Linux 6.7 fails to boot on Core Ultra 155H with "i915 GT1 GSC > proxy" error > > Hi, > > -Original

RE: Linux 6.7 fails to boot on Core Ultra 155H with "i915 GT1 GSC proxy" error

2024-02-27 Thread Saarinen, Jani
Hi, > -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Tuesday, February 27, 2024 6:25 PM > To: Roman Lozko ; intel-gfx@lists.freedesktop.org > Subject: Re: Linux 6.7 fails to boot on Core Ultra 155H with "i915 GT1 GSC > proxy" error > > On Wed, 14 Feb 2024, Roman

[PATCH 2/3] mei: me: add arrow lake point H DID

2024-02-27 Thread Jonathan Cavitt
From: Alexander Usyskin Add Arrow Lake H device id. Cc: Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 1 + drivers/misc/mei/pci-me.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/misc/mei/hw-me-regs.h

[PATCH 1/3] mei: me: add arrow lake point S DID

2024-02-27 Thread Jonathan Cavitt
From: Alexander Usyskin Add Arrow Lake S device id. Cc: Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 1 + drivers/misc/mei/pci-me.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/misc/mei/hw-me-regs.h

[PATCH 3/3] mei: gsc_proxy: match component when GSC is on different bus

2024-02-27 Thread Jonathan Cavitt
From: Alexander Usyskin On Arrow Lake S systems, MEI is no longer strictly connected to bus 0, while graphics remain exclusively on bus 0. Adapt the component matching logic to accommodate this change: Original behavior: Required both MEI and graphics to be on the same bus 0. New behavior:

Re: Linux 6.7 fails to boot on Core Ultra 155H with "i915 GT1 GSC proxy" error

2024-02-27 Thread Jani Nikula
On Wed, 14 Feb 2024, Roman Lozko wrote: > Hi, > I've first filled the bug in openSUSE Tumbleweed bugtracker > (https://bugzilla.opensuse.org/show_bug.cgi?id=1219899) and then found > Intel GFX CI and that it reliably triggers the same error in Arrow > Lake BAT runs. > > Don't know what else to

[PULL] drm-intel-next

2024-02-27 Thread Jani Nikula
Hi Dave & Sima - Final i915 feature pull for v6.9. drm-intel-next-2024-02-27-1: drm/i915 feature pull #2 for v6.9: Features and functionality: - DP tunneling and bandwidth allocation support (Imre) - Add more ADL-N PCI IDs (Gustavo) - Enable fastboot also on older platforms (Ville) -

RE: [PATCH 2/3] Start separating pipe vs transcoder set logic for bigjoiner during modeset

2024-02-27 Thread Srinivas, Vidya
> -Original Message- > From: Lisovskiy, Stanislav > Sent: Tuesday, February 27, 2024 2:41 PM > To: Srinivas, Vidya > Cc: intel-gfx@lists.freedesktop.org; Saarinen, Jani ; > ville.syrj...@linux.intel.com > Subject: Re: [PATCH 2/3] Start separating pipe vs transcoder set logic for >

Re: ✗ Fi.CI.IGT: failure for drm/i915: Add Display Port tunnel BW allocation support (rev6)

2024-02-27 Thread Imre Deak
On Tue, Feb 27, 2024 at 02:21:29PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Add Display Port tunnel BW allocation support (rev6) > URL : https://patchwork.freedesktop.org/series/129082/ > State : failure Thanks for the reviews,acks, patchset is pushed to

✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/display/drrs: Refactor CPU transcoder DRRS check

2024-02-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/drrs: Refactor CPU transcoder DRRS check URL : https://patchwork.freedesktop.org/series/130433/ State : success == Summary == CI Bug Log - changes from CI_DRM_14348 -> Patchwork_130433v1

[PATCH i-g-t v2 1/2] lib/kunit: Execute test cases synchronously

2024-02-27 Thread Janusz Krzysztofik
Up to now we were loading a KUnit test module in test execution mode only once per subtest, in background, and then, in parallel with execution of test cases while the module was loading, we were looking through dmesg for KTAP results from each expected test case. As a consequence, our IGT

[PATCH i-g-t v2 2/2] lib/kunit: Minimize code duplication

2024-02-27 Thread Janusz Krzysztofik
A new helper has been introduced recently, used for fetching KTAP results of a single test case. Since that helper is called for that purpose only after the test module is loaded with all other test cases filtered out, its actual implementation is as simple as collecting all results from a single

[PATCH i-g-t v2 0/2] lib/kunit: Execute test cases synchronously

2024-02-27 Thread Janusz Krzysztofik
Up to now we were loading a KUnit test module in test execution mode only once per subtest, in background, and then, in parallel with execution of test cases while the module was loading, we were looking through dmesg for KTAP results from each expected test case. As a consequence, our IGT

[RFC 3/3] drm/xe: Add GuC SLPC Display Metrics

2024-02-27 Thread Rodrigo Vivi
Let's register with intel_display to receive display metrics that we can then send to GuC SLPC through the shared data and let it to select the optimal frequency. Cc: Jani Nikula Cc: Lucas De Marchi Cc: Vinay Belgaumkar Signed-off-by: Rodrigo Vivi ---

[RFC 2/3] drm/i915: Add experimental GuC SLPC display metrics

2024-02-27 Thread Rodrigo Vivi
On i915 GuC SLPC will only be able to really control the freq if we disable the waitboost. So this is a hacky and experimental only change with the intention to debug the available metrics with i915. Cc: Jani Nikula Cc: Lucas De Marchi Cc: Vinay Belgaumkar Signed-off-by: Rodrigo Vivi ---

[RFC 1/3] drm/i915/display: Introduce intel_display_guc_metrics

2024-02-27 Thread Rodrigo Vivi
This is a generic component part of intel_display that collects display information that could be used with GuC SLPC for a optimal frequency selection. This is also an experimental way to share the code with Xe without a compact-headers, on an attempt to move towards the full detachment of the

[RFC 0/3] Display experiment + GuC Display Metrics

2024-02-27 Thread Rodrigo Vivi
First of all, I'm sorry if this is hitting your inbox twice. I could swear that I had sent this 2 weeks ago, but I couldn't find the lore or patchwork, so let me try again. This series is a double experiment that I would like to get some help. 1. Display - shared display between i915 and xe

✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/display/drrs: Refactor CPU transcoder DRRS check

2024-02-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/drrs: Refactor CPU transcoder DRRS check URL : https://patchwork.freedesktop.org/series/130433/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/display/drrs: Refactor CPU transcoder DRRS check

2024-02-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/drrs: Refactor CPU transcoder DRRS check URL : https://patchwork.freedesktop.org/series/130433/ State : warning == Summary == Error: dim checkpatch failed 4e54fc855aa6 drm/i915/display/drrs: Refactor CPU transcoder DRRS

Re: [PATCH 1/2] drm/i915/display/drrs: Refactor CPU transcoder DRRS check

2024-02-27 Thread Jani Nikula
We don't need to keep adding /display/ in the subject prefix. Just drm/i915/drrs: is fine. On Tue, 27 Feb 2024, Bhanuprakash Modem wrote: > Rename cpu_transcoder_has_drrs() to intel_cpu_transcoder_has_drrs() > and make it as non-static, therefore it can be re-used. > > Cc: Jani Nikula > Cc:

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-27 Thread Andi Shyti
Hi Jani, thanks, there has been a v2 after this and your comments have been addressed somehow. There will be a v3, as well. Thanks, Andi On Tue, Feb 27, 2024 at 02:18:01PM +0200, Jani Nikula wrote: > On Tue, 20 Feb 2024, Andi Shyti wrote: > > Since CCS automatic load balancing is disabled, we

[PATCH 2/2] drm/i915/display/debugfs: Fix duplicate checks in i915_drrs_status

2024-02-27 Thread Bhanuprakash Modem
Remove duplicate checks for debugfs entry "DRRS capable:". Fixes: (20af10845864) drm/i915/display/debugfs: New entry "DRRS capable" to i915_drrs_status Cc: Jani Nikula Cc: Ankit Nautiyal Cc: Mitul Golani Signed-off-by: Bhanuprakash Modem --- drivers/gpu/drm/i915/display/intel_drrs.c | 5

[PATCH 1/2] drm/i915/display/drrs: Refactor CPU transcoder DRRS check

2024-02-27 Thread Bhanuprakash Modem
Rename cpu_transcoder_has_drrs() to intel_cpu_transcoder_has_drrs() and make it as non-static, therefore it can be re-used. Cc: Jani Nikula Cc: Ankit Nautiyal Cc: Mitul Golani Signed-off-by: Bhanuprakash Modem --- drivers/gpu/drm/i915/display/intel_display.c | 9 +

Re: [PATCH v2 4/4] drm/i915: Show bios vbt when read from firmware/spi/oprom

2024-02-27 Thread Jani Nikula
On Tue, 20 Feb 2024, Radhakrishna Sripada wrote: > Make debugfs vbt only shows valid vbt when read from ACPI opregion. > Make it work when read from firmware/spi/pci oprom cases. > > Cc: Jani Nikula > Signed-off-by: Radhakrishna Sripada > --- > drivers/gpu/drm/i915/display/intel_bios.c | 30

Re: [PATCH v2 3/4] drm/i915: Move vbt read from firmware to intel_bios.c

2024-02-27 Thread Jani Nikula
On Tue, 20 Feb 2024, Radhakrishna Sripada wrote: > VBT read from firmware is currently nested within opregion vbt read. > Extract it and place it together with other vbt read mechanisms and > dis-associate vbt-firmware from opregion structure. > > Cc: Jani Nikula > Signed-off-by: Radhakrishna

Re: [PATCH v2 2/4] drm/i915: Pass size to spi_oprom_get_vbt

2024-02-27 Thread Jani Nikula
On Tue, 20 Feb 2024, Radhakrishna Sripada wrote: > spi_oprom_get_vbt will later be used to show the contents of vbt for > which the size of vbt is needed. > > Cc: Jani Nikula > Signed-off-by: Radhakrishna Sripada Yeah, do the same thing in oprom_get_vbt(). Reviewed-by: Jani Nikula > --- >

Re: [PATCH v2 1/4] drm/i915: Pass size to oprom_get_vbt

2024-02-27 Thread Jani Nikula
On Tue, 20 Feb 2024, Radhakrishna Sripada wrote: > oprom_get_vbt will later be used to show the contents of vbt for which > the size of vbt is needed. > > Cc: Jani Nikula > Signed-off-by: Radhakrishna Sripada > --- > drivers/gpu/drm/i915/display/intel_bios.c | 18 ++ > 1 file

Re: [PATCH v2 0/4] VBT read cleanup

2024-02-27 Thread Jani Nikula
On Tue, 20 Feb 2024, Radhakrishna Sripada wrote: > This series is originally based out of [1], and built on top of [2]. > > The primary departure from [1] was that vbt is no longer cached. During vbt > show, based on the source of vbt, it would simply be re-read reducing the > read/cleanup

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-27 Thread Jani Nikula
On Tue, 20 Feb 2024, Andi Shyti wrote: > Since CCS automatic load balancing is disabled, we will impose a > fixed balancing policy that involves setting all the CCS engines > to work together on the same load. > > Simultaneously, the user will see only 1 CCS rather than the > actual number. As of

Re: DRM Migration to Gitlab

2024-02-27 Thread Maxime Ripard
On Tue, Feb 27, 2024 at 10:18:01AM +0100, Maxime Ripard wrote: > Hi Jani, > > On Tue, Feb 27, 2024 at 10:29:01AM +0200, Jani Nikula wrote: > > On Tue, 27 Feb 2024, Maxime Ripard wrote: > > > Hi, > > > > > > Sima, after becoming aware of the drm-misc transition to Gitlab in the > > > next couple

RE: ✗ Fi.CI.BAT: failure for drm/i915: Add Display Port tunnel BW allocation support (rev6)

2024-02-27 Thread Illipilli, TejasreeX
Hi, https://patchwork.freedesktop.org/series/129082/ - Re-reported. Thanks, Tejasree -Original Message- From: I915-ci-infra On Behalf Of Imre Deak Sent: Tuesday, February 27, 2024 4:29 PM To: intel-gfx@lists.freedesktop.org; i915-ci-in...@lists.freedesktop.org Cc: Saarinen, Jani

✓ Fi.CI.BAT: success for drm/i915: Add Display Port tunnel BW allocation support (rev6)

2024-02-27 Thread Patchwork
== Series Details == Series: drm/i915: Add Display Port tunnel BW allocation support (rev6) URL : https://patchwork.freedesktop.org/series/129082/ State : success == Summary == CI Bug Log - changes from CI_DRM_14345 -> Patchwork_129082v6

Re: BUG: sleeping function called from invalid context at drivers/gpu/drm/i915/gem/i915_gem_pages.c:526

2024-02-27 Thread Borislav Petkov
On Tue, Feb 27, 2024 at 12:58:08PM +0200, Jani Nikula wrote: > Let's see what Ville says, but in the end bisection might be the > quickest way to find the regression. Though I understand it can be > tedious for you personally. Ha, I can do it in parallel with the gazillion other things. :-)

✓ Fi.CI.IGT: success for drm/i915/display: Disable AuxCCS framebuffers if built for Xe (rev2)

2024-02-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Disable AuxCCS framebuffers if built for Xe (rev2) URL : https://patchwork.freedesktop.org/series/129166/ State : success == Summary == CI Bug Log - changes from CI_DRM_14345_full -> Patchwork_129166v2_full

Re: ✗ Fi.CI.BAT: failure for drm/i915: Add Display Port tunnel BW allocation support (rev6)

2024-02-27 Thread Imre Deak
On Tue, Feb 27, 2024 at 01:18:36AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Add Display Port tunnel BW allocation support (rev6) > URL : https://patchwork.freedesktop.org/series/129082/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_14345

Re: BUG: sleeping function called from invalid context at drivers/gpu/drm/i915/gem/i915_gem_pages.c:526

2024-02-27 Thread Jani Nikula
On Tue, 27 Feb 2024, Borislav Petkov wrote: > On Tue, Feb 27, 2024 at 12:37:02PM +0200, Jani Nikula wrote: >> Is this a recent regression? > > Yeah, no clue. Hadn't booted that machine since 6.7-rc1... I can bisect > if you want me to. Let's see what Ville says, but in the end bisection might be

Re: BUG: sleeping function called from invalid context at drivers/gpu/drm/i915/gem/i915_gem_pages.c:526

2024-02-27 Thread Borislav Petkov
On Tue, Feb 27, 2024 at 12:37:02PM +0200, Jani Nikula wrote: > Is this a recent regression? Yeah, no clue. Hadn't booted that machine since 6.7-rc1... I can bisect if you want me to. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

Re: BUG: sleeping function called from invalid context at drivers/gpu/drm/i915/gem/i915_gem_pages.c:526

2024-02-27 Thread Jani Nikula
On Tue, 27 Feb 2024, Borislav Petkov wrote: > Hi all, > > this lockdep splat at the end is from an old Atom 32-bit laptop with the > latest Linus + tip lineup: Is this a recent regression? At a glance, I couldn't quite pinpoint the root cause. It depends on cursor_needs_physical == true, which

BUG: sleeping function called from invalid context at drivers/gpu/drm/i915/gem/i915_gem_pages.c:526

2024-02-27 Thread Borislav Petkov
Hi all, this lockdep splat at the end is from an old Atom 32-bit laptop with the latest Linus + tip lineup: [0.00] Linux version 6.8.0-rc6+ (boris@zn) (gcc (Debian 13.2.0-9) 13.2.0, GNU ld (GNU Binutils for Debian) 2.41.50.20231227) #1 SMP PREEMPT_DYNAMIC Tue Feb 27 10:43:15 CET 2024 [

✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Stop doing double audio enable/disable on SDVO and g4x+ DP

2024-02-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Stop doing double audio enable/disable on SDVO and g4x+ DP URL : https://patchwork.freedesktop.org/series/130398/ State : success == Summary == CI Bug Log - changes from CI_DRM_14345_full -> Patchwork_130398v1_full

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-27 Thread Rasmus Villemoes
On 26/02/2024 15.57, Jani Nikula wrote: > Personally I suck at remembering even the standard printf conversion > specifiers, let alone all the kernel extensions. I basically have to > look them up every time. I'd really love some %{name} format for named > pointer things. And indeed preferrably

Re: [PATCH] drm/i915: check before removing mm notifier

2024-02-27 Thread Nirmoy Das
Hi Tvrtko, On 2/27/2024 10:04 AM, Tvrtko Ursulin wrote: On 21/02/2024 11:52, Nirmoy Das wrote: Merged it to drm-intel-gt-next with s/check/Check Shouldn't this have had: Fixes: ed29c2691188 ("drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v7.") Cc: # v5.13+ ?

Re: DRM Migration to Gitlab

2024-02-27 Thread Maxime Ripard
Hi Jani, On Tue, Feb 27, 2024 at 10:29:01AM +0200, Jani Nikula wrote: > On Tue, 27 Feb 2024, Maxime Ripard wrote: > > Hi, > > > > Sima, after becoming aware of the drm-misc transition to Gitlab in the > > next couple of weeks, to do the same for DRM today. > > > > This is now done and all the

Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-27 Thread Jani Nikula
On Tue, 27 Feb 2024, "Lisovskiy, Stanislav" wrote: > On Mon, Feb 26, 2024 at 09:56:10PM +0200, Jani Nikula wrote: >> On Wed, 21 Feb 2024, Stanislav Lisovskiy >> wrote: >> > Patch calculates bigjoiner pipes in mst compute. >> > Patch also passes bigjoiner bool to validate plane >> > max size.

Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-27 Thread Lisovskiy, Stanislav
On Tue, Feb 27, 2024 at 11:06:16AM +0200, Srinivas, Vidya wrote: > > > > -Original Message- > > From: Lisovskiy, Stanislav > > Sent: Tuesday, February 27, 2024 2:34 PM > > To: Jani Nikula > > Cc: intel-gfx@lists.freedesktop.org; Saarinen, Jani > > ; > > ville.syrj...@linux.intel.com;

Re: [PATCH 2/3] Start separating pipe vs transcoder set logic for bigjoiner during modeset

2024-02-27 Thread Lisovskiy, Stanislav
On Tue, Feb 27, 2024 at 06:40:23AM +0200, Srinivas, Vidya wrote: > > > > -Original Message- > > From: Lisovskiy, Stanislav > > Sent: Thursday, February 22, 2024 12:50 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: Lisovskiy, Stanislav ; Saarinen, Jani > > ;

RE: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-27 Thread Srinivas, Vidya
> -Original Message- > From: Lisovskiy, Stanislav > Sent: Tuesday, February 27, 2024 2:34 PM > To: Jani Nikula > Cc: intel-gfx@lists.freedesktop.org; Saarinen, Jani ; > ville.syrj...@linux.intel.com; Srinivas, Vidya > Subject: Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0 >

Re: [PATCH] drm/i915: check before removing mm notifier

2024-02-27 Thread Tvrtko Ursulin
On 21/02/2024 11:52, Nirmoy Das wrote: Merged it to drm-intel-gt-next with s/check/Check Shouldn't this have had: Fixes: ed29c2691188 ("drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v7.") Cc: # v5.13+ ? Regards, Tvrtko On 2/19/2024 1:50 PM, Nirmoy Das wrote:

Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-27 Thread Lisovskiy, Stanislav
On Mon, Feb 26, 2024 at 09:56:10PM +0200, Jani Nikula wrote: > On Wed, 21 Feb 2024, Stanislav Lisovskiy > wrote: > > Patch calculates bigjoiner pipes in mst compute. > > Patch also passes bigjoiner bool to validate plane > > max size. > > Please use the imperative mood in commit messages, e.g.

Re: [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe

2024-02-27 Thread Jani Nikula
On Mon, 26 Feb 2024, Juha-Pekka Heikkila wrote: > AuxCCS framebuffers don't work on Xe driver hence disable them > from plane capabilities until they are fixed. FlatCCS framebuffers > work and they are left enabled. CCS is left untouched for i915 > driver. > > Closes:

Re: [PATCH] drm/i915: Reuse rplu cdclk fns for mtl/lnl

2024-02-27 Thread Jani Nikula
Subject: drm/i915/cdclk: Re-use RPL-U functions for MTL+ On Mon, 26 Feb 2024, Radhakrishna Sripada wrote: > MTL/LNL use the same cdclk functions as rplu albeit with different > tables. Having separate tables not explicit special handling for the > platforms reuse rplu cdclk functions. I'm

Re: [PATCH] drm/i915/display/debugfs: New entry "DRRS capable" to i915_drrs_status

2024-02-27 Thread Jani Nikula
On Tue, 27 Feb 2024, "Modem, Bhanuprakash" wrote: > On 26-02-2024 07:50 pm, Jani Nikula wrote: >> On Mon, 26 Feb 2024, "Nautiyal, Ankit K" wrote: >>> On 2/22/2024 11:27 AM, Golani, Mitulkumar Ajitkumar wrote: > -Original Message- > From: Intel-gfx On Behalf Of >

Re: [PATCH 1/2] drm/ttm: improve idle/busy handling v4

2024-02-27 Thread Christian König
Am 27.02.24 um 09:12 schrieb Matthew Auld: On 26/02/2024 20:21, Thomas Hellström wrote: Hi, Christian On Fri, 2024-02-23 at 15:30 +0100, Christian König wrote: Am 06.02.24 um 13:56 schrieb Christian König: Am 06.02.24 um 13:53 schrieb Thomas Hellström: Hi, Christian, On Fri, 2024-01-26 at

Re: DRM Migration to Gitlab

2024-02-27 Thread Jani Nikula
On Tue, 27 Feb 2024, Maxime Ripard wrote: > Hi, > > Sima, after becoming aware of the drm-misc transition to Gitlab in the > next couple of weeks, to do the same for DRM today. > > This is now done and all the various bits (nightly.conf, MAINTAINERS, > doc, etc.) should be there. > > If all goes

Re: [PATCH 1/2] drm/ttm: improve idle/busy handling v4

2024-02-27 Thread Matthew Auld
On 26/02/2024 20:21, Thomas Hellström wrote: Hi, Christian On Fri, 2024-02-23 at 15:30 +0100, Christian König wrote: Am 06.02.24 um 13:56 schrieb Christian König: Am 06.02.24 um 13:53 schrieb Thomas Hellström: Hi, Christian, On Fri, 2024-01-26 at 15:09 +0100, Christian König wrote: