Re: [PATCH] drm/probe-helper: Call drm_mode_validate_ycbcr420() before connector->mode_valid()

2024-05-21 Thread Daniel Vetter
des in said > hook, which will likely come as a suprise when the driver has > declared no support for such modes (via setting > connector->ycbcr_420_allowed to false). > > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10992 > Signed-off-by: Ville Syrjälä Sounds

Re: [PATCH] MAINTAINERS: Update email address for Tvrtko Ursulin

2024-03-05 Thread Daniel Vetter
ld emails to point to the > main one. > > Signed-off-by: Tvrtko Ursulin > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi Directly applied to drm-fixes as requested on irc. -Sima > --- > .mailmap| 5 + > MAINTA

Re: [PULL] drm-xe-next

2024-02-26 Thread Daniel Vetter
| 33 +- > drivers/gpu/drm/xe/xe_uc.h | 1 + > drivers/gpu/drm/xe/xe_uc_fw.c | 60 +- > drivers/gpu/drm/xe/xe_uc_fw_types.h| 9 +- > drivers/gpu/drm/xe/xe_vm.c | 287 ++- > drivers/gpu/drm/xe/xe_vm.h | 7 +- > drivers/gpu/drm/xe/xe_vm_types.h | 18 +- > drivers/gpu/drm/xe/xe_vram_freq.c | 128 +++ > drivers/gpu/drm/xe/xe_vram_freq.h | 13 + > drivers/gpu/drm/xe/xe_wa.c | 191 + > drivers/gpu/drm/xe/xe_wa_oob.rules | 12 +- > drivers/gpu/drm/xe/xe_wait_user_fence.c| 2 +- > drivers/gpu/drm/xe/xe_wopcm_types.h| 4 +- > include/uapi/drm/xe_drm.h | 34 +- > 141 files changed, 6518 insertions(+), 1187 deletions(-) > create mode 100644 drivers/gpu/drm/xe/abi/gsc_proxy_commands_abi.h > create mode 100644 drivers/gpu/drm/xe/abi/guc_actions_sriov_abi.h > create mode 100644 drivers/gpu/drm/xe/abi/guc_relay_actions_abi.h > create mode 100644 drivers/gpu/drm/xe/abi/guc_relay_communication_abi.h > rename drivers/gpu/drm/xe/{ => display}/xe_display.c (99%) > rename drivers/gpu/drm/xe/{ => display}/xe_display.h (100%) > create mode 100644 drivers/gpu/drm/xe/regs/xe_pcode_regs.h > create mode 100644 drivers/gpu/drm/xe/tests/xe_guc_db_mgr_test.c > create mode 100644 drivers/gpu/drm/xe/tests/xe_guc_relay_test.c > create mode 100644 drivers/gpu/drm/xe/tests/xe_kunit_helpers.c > create mode 100644 drivers/gpu/drm/xe/tests/xe_kunit_helpers.h > create mode 100644 drivers/gpu/drm/xe/tests/xe_test_mod.c > create mode 100644 drivers/gpu/drm/xe/xe_gsc_proxy.c > create mode 100644 drivers/gpu/drm/xe/xe_gsc_proxy.h > create mode 100644 drivers/gpu/drm/xe/xe_gt_sriov_printk.h > create mode 100644 drivers/gpu/drm/xe/xe_guc_db_mgr.c > create mode 100644 drivers/gpu/drm/xe/xe_guc_db_mgr.h > create mode 100644 drivers/gpu/drm/xe/xe_guc_hxg_helpers.h > create mode 100644 drivers/gpu/drm/xe/xe_guc_relay.c > create mode 100644 drivers/gpu/drm/xe/xe_guc_relay.h > create mode 100644 drivers/gpu/drm/xe/xe_guc_relay_types.h > create mode 100644 drivers/gpu/drm/xe/xe_memirq.c > create mode 100644 drivers/gpu/drm/xe/xe_memirq.h > create mode 100644 drivers/gpu/drm/xe/xe_memirq_types.h > create mode 100644 drivers/gpu/drm/xe/xe_vram_freq.c > create mode 100644 drivers/gpu/drm/xe/xe_vram_freq.h -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PULL] drm-misc-next

2024-02-26 Thread Daniel Vetter
ls/msm-sc7180-trogdor-lazor-limozeen-skips.txt > create mode 100644 drivers/gpu/drm/panel/panel-himax-hx83112a.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/Kconfig > create mode 100644 drivers/gpu/drm/renesas/rz-du/Makefile > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.h > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.h > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_encoder.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_encoder.h > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.h > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.h > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Frankenstrasse 146, 90461 Nuernberg, Germany > GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman > HRB 36809 (AG Nuernberg) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-09 Thread Daniel Vetter
On Sat, Feb 10, 2024 at 12:06:58AM +0530, Arunpravin Paneer Selvam wrote: > Hi Daniel, > > On 2/9/2024 11:34 PM, Daniel Vetter wrote: > > On Fri, Feb 09, 2024 at 08:56:24PM +0530, Arunpravin Paneer Selvam wrote: > > > Few users have observed display corruption when the

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-09 Thread Daniel Vetter
__alloc_range(struct drm_buddy *mm, > } while (1); > > list_splice_tail(, blocks); > + > + if (total_allocated < size) { > + err = -ENOSPC; > + goto err_free; > + } > + > return 0; > > err_undo: > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

[PATCH] dma-buf: try to catch swiotlb bounce buffers

2024-02-07 Thread Daniel Vetter
CONFIG_DMA_API_DEBUG is enabled. Signed-off-by: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Cc: Paul Cercueil --- Entirely untested, but since I sent the mail with the idea I figured I might as well type it

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-31 Thread Daniel Vetter
On Wed, Jan 31, 2024 at 12:26:45PM +0200, Dmitry Baryshkov wrote: > On Wed, 31 Jan 2024 at 11:11, Daniel Vetter wrote: > > > > On Wed, Jan 31, 2024 at 05:17:08AM +, Jason-JH Lin (林睿祥) wrote: > > > On Thu, 2024-01-25 at 19:17 +0100, Daniel Vetter wrote: > > >

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-31 Thread Daniel Vetter
On Wed, Jan 31, 2024 at 05:17:08AM +, Jason-JH Lin (林睿祥) wrote: > On Thu, 2024-01-25 at 19:17 +0100, Daniel Vetter wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > On Tue,

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-25 Thread Daniel Vetter
gt; Regards, > Jason-JH.Lin > > On Tue, 2023-03-07 at 15:56 +0100, Maxime Ripard wrote: > > Hi, > > > > On Thu, Feb 16, 2023 at 12:12:13PM +0100, Daniel Vetter wrote: > > > The stuff never really worked, and leads to lots of fun because it > > > out-of

Re: [PATCH 3/7] drm/amd/display: Add handling for new "active color format" property

2024-01-10 Thread Daniel Vetter
On Wed, 10 Jan 2024 at 13:53, Andri Yngvason wrote: > > mið., 10. jan. 2024 kl. 11:10 skrifaði Daniel Vetter : > > > > On Tue, Jan 09, 2024 at 06:11:00PM +, Andri Yngvason wrote: > > > + /* Extract information from crtc to communicate it to userspace as

Re: [PATCH 3/7] drm/amd/display: Add handling for new "active color format" property

2024-01-10 Thread Daniel Vetter
drm_connector_attach_max_bpc_property(connector, 8, 16); > > + connector->active_color_format_property = > master->base.active_color_format_property; > + if (connector->active_color_format_property) > + > drm_connector_attach_active_color_format_property(>base); > + > connector->vrr_capable_property = master->base.vrr_capable_property; > if (connector->vrr_capable_property) > drm_connector_attach_vrr_capable_property(connector); > -- > 2.43.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 2/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

2024-01-10 Thread Daniel Vetter
er the kms ioctl returns (and not somewhen later for non-blocking commits). You probably need a bit of work to be able to handle immutable properties with the atomic state infrastructure, but I think otherwise this should fit all rather neatly. Cheers, Sima > > The way I've implemented thing

Re: [PATCH] drm/i915/guc: Avoid circular locking issue on busyness flush

2024-01-09 Thread Daniel Vetter
ays do the synchronous cancel if not in reset. And add an extra > synchronous cancel to the end of the reset flow to account for when a > reset is occurring at driver shutdown and the cancel is no longer > synchronous but could lead to unallocated memory accesses if the > worker is

Re: [Intel-gfx] [PULL] drm-misc-next

2023-11-23 Thread Daniel Vetter
drivers/gpu/drm/imagination/pvr_rogue_fwif_stream.h > create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_heap_config.h > create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_meta.h > create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_mips.h > create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_mips_check.h > create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_mmu_defs.h > create mode 100644 drivers/gpu/drm/imagination/pvr_stream.c > create mode 100644 drivers/gpu/drm/imagination/pvr_stream.h > create mode 100644 drivers/gpu/drm/imagination/pvr_stream_defs.c > create mode 100644 drivers/gpu/drm/imagination/pvr_stream_defs.h > create mode 100644 drivers/gpu/drm/imagination/pvr_sync.c > create mode 100644 drivers/gpu/drm/imagination/pvr_sync.h > create mode 100644 drivers/gpu/drm/imagination/pvr_vm.c > create mode 100644 drivers/gpu/drm/imagination/pvr_vm.h > create mode 100644 drivers/gpu/drm/imagination/pvr_vm_mips.c > create mode 100644 drivers/gpu/drm/imagination/pvr_vm_mips.h > create mode 100644 include/uapi/drm/pvr_drm.h -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-intel-next

2023-11-23 Thread Daniel Vetter
> drivers/gpu/drm/i915/i915_params.c | 89 --- > drivers/gpu/drm/i915/i915_params.h | 22 - > drivers/gpu/drm/i915/i915_reg.h| 2 - > drivers/gpu/drm/i915/i915_utils.h | 2 +- > drivers/gpu/drm/i915/intel_runtime_pm.h| 2 - > drivers/gpu/drm/i915/selftests/intel_uncore.c | 2 + > drivers/gpu/drm/i915/soc/intel_gmch.c | 27 +- > drivers/gpu/drm/i915/vlv_sideband.c| 29 +- > drivers/gpu/drm/i915/vlv_sideband.h| 9 +- > drivers/gpu/drm/nouveau/dispnv50/disp.c| 9 +- > drivers/gpu/drm/tests/drm_dp_mst_helper_test.c | 166 +- > include/drm/display/drm_dp.h | 25 + > include/drm/display/drm_dp_helper.h| 32 + > include/drm/display/drm_dp_mst_helper.h| 16 +- > include/drm/drm_color_mgmt.h | 19 +- > 118 files changed, 4425 insertions(+), 1969 deletions(-) > create mode 100644 > drivers/gpu/drm/i915/display/intel_display_debugfs_params.c > create mode 100644 > drivers/gpu/drm/i915/display/intel_display_debugfs_params.h > create mode 100644 drivers/gpu/drm/i915/display/intel_display_params.c > create mode 100644 drivers/gpu/drm/i915/display/intel_display_params.h > create mode 100644 drivers/gpu/drm/i915/display/intel_dpt_common.c > create mode 100644 drivers/gpu/drm/i915/display/intel_dpt_common.h > create mode 100644 drivers/gpu/drm/i915/display/intel_dsb_buffer.c > create mode 100644 drivers/gpu/drm/i915/display/intel_dsb_buffer.h > > -- > Jani Nikula, Intel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-misc-next

2023-11-20 Thread Daniel Vetter
| 128 +- > include/drm/drm_edid.h | 148 -- > include/drm/drm_eld.h | 164 ++ > include/drm/drm_flip_work.h| 20 +- > include/drm/drm_format_helper.h| 81 +- > include/drm/drm_ge

Re: [Intel-gfx] [PULL] drm-misc-fixes

2023-11-17 Thread Daniel Vetter
t.h | 4 ++-- > drivers/gpu/drm/nouveau/nouveau_display.c | 5 + > drivers/gpu/drm/nouveau/nvkm/core/event.c | 12 ++-- > drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c| 6 +++--- > 6 files changed, 22 insertions(+), 14 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-16 Thread Daniel Vetter
ia "Any non-linear actions (backmerges, merging topic branches and sending out pull requests) are only done by the official drm-misc maintainers (see MAINTAINERS, or ask #dri-devel), and not by committers. See the examples section in dim for more info" Minor screw-ups like this gives us a great opportunity to improve the tooling, let's use it. Cheers, Sima -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-misc-fixes

2023-11-10 Thread Daniel Vetter
splay.c| 3 +++ > drivers/gpu/drm/vc4/tests/vc4_mock_crtc.c| 2 +- > drivers/gpu/drm/vc4/tests/vc4_mock_output.c | 2 +- > 10 files changed, 28 insertions(+), 21 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-intel-next-fixes

2023-11-10 Thread Daniel Vetter
gpu/drm/i915/display/intel_dp.c | 2 +- > drivers/gpu/drm/i915/display/intel_tc.c | 11 ++--- > drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 + > drivers/gpu/drm/i915/gt/intel_ggtt.c| 35 > - > drivers/gpu/drm/i915/gt/intel_rc6.c | 16 --

Re: [Intel-gfx] [PATCH] drm/i915: Flush WC GGTT only on required platforms

2023-10-13 Thread Daniel Vetter
uncore; > > > /* > > >* Note that as an uncached mmio write, this will flush the > > >* WCB of the writes into the GGTT before it triggers the > > > invalidate. > > > + * > > > + * Only perform this when GGTT is mapped

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-09-06 Thread Daniel Vetter
good enough for anything remotely complex), then you have a _really_ big problem. Yes CI is good at catching accidental changes in locking design, but if you use it for anything more than that you're in deep trouble. Cheers, Sima -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-09-06 Thread Daniel Vetter
On Mon, Aug 28, 2023 at 04:01:38PM -0700, John Harrison wrote: > On 8/23/2023 10:37, John Harrison wrote: > > On 8/23/2023 09:00, Daniel Vetter wrote: > > > On Tue, Aug 22, 2023 at 11:53:24AM -0700, John Harrison wrote: > > > > On 8/11/2023 11:20, Zhanjun Dong

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-09-04 Thread Daniel Vetter
a > Alex > > > > > > > > > > > BR, > > > Jani. > > > > > > > > >> > > >> With the patch. both following git grep commands return nothing in > > >> amd-staging-drm-next. > > >> > > >> $ git grep drm_edid_override_connector_update -- drivers/gpu/drm/amd > > >> $ git grep edid_override -- drivers/gpu/drm/amd > > >> > > >> Best regards, > > >> Alex Hung > > >> > > >>>>> > > >>>>> What is the goal of the reverts? I don't disagree that we may be > > >>>>> using the interfaces wrong, but reverting them will regess > > >>>>> functionality in the driver. > > >>>> > > >>>> The commits are in v6.5-rc1, but not yet in a release. No user depends > > >>>> on them yet. I'd strongly prefer them not reaching v6.5 final and > > >>>> users. > > >>> > > >>> Sorry for confusion here, that's obviously come and gone already. :( > > >>> > > >>>> The firmware EDID, override EDID, connector forcing, the EDID property, > > >>>> etc. have been and somewhat still are a hairy mess that we must keep > > >>>> untangling, and this isn't helping. > > >>>> > > >>>> I've put in crazy amounts of work on this, and I've added kernel-doc > > >>>> comments about stuff that should and should not be done, but they go > > >>>> unread and ignored. > > >>>> > > >>>> I really don't want to end up having to clean this up myself before I > > >>>> can embark on further cleanups and refactoring. > > >>>> > > >>>> And again, if the functionality in the driver depends on conflating two > > >>>> things that should be separate, it's probably not such a hot idea to > > >>>> let > > >>>> it reach users either. Even if it's just debugfs. > > >>>> > > >>>> > > >>>> BR, > > >>>> Jani. > > >>> > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-30 Thread Daniel Vetter
On Wed, Aug 30, 2023 at 10:29:46AM +0300, Jani Nikula wrote: > Upstream code should be reviewed in public. Yup -Sima -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-23 Thread Daniel Vetter
rogress. > > > > Signed-off-by: Zhanjun Dong > > Cc: John Harrison > > Cc: Andi Shyti > > Cc: Daniel Vetter > > --- > > drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 11 ++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > &

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-22 Thread Daniel Vetter
On Tue, Aug 22, 2023 at 02:14:28PM +, Dong, Zhanjun wrote: > > > > -Original Message- > > From: Daniel Vetter > > Sent: August 22, 2023 9:51 AM > > To: Dong, Zhanjun > > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; &

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-22 Thread Daniel Vetter
quire a lock, > which might trigger the possible cirular locking dependency warning. > When intel_gt_reset called, reset_in_progress flag will be set, add code > to check the flag, call async verion if reset is in progress. > > Signed-off-by: Zhanjun Dong > Cc: John Harrison > Cc

Re: [Intel-gfx] [PATCH v4] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-03 Thread Daniel Vetter
rm/i915/gt/uc/intel_uc.c > index 18250fb64bd8..5b76f0d4d2a6 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c > @@ -566,7 +566,7 @@ static int __uc_init_hw(struct intel_uc *uc) > * We've failed to load the firmware :( > */ > err_submission: > - intel_guc_submission_disable(guc); > + intel_guc_submission_disable(guc, true); > err_log_capture: > __uc_capture_load_err_log(uc); > err_rps: > @@ -597,7 +597,7 @@ static void __uc_fini_hw(struct intel_uc *uc) > return; > > if (intel_uc_uses_guc_submission(uc)) > - intel_guc_submission_disable(guc); > + intel_guc_submission_disable(guc, true); > > __uc_sanitize(uc); > } > -- > 2.34.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-misc-next

2023-07-27 Thread Daniel Vetter
ers/gpu/drm/xen/xen_drm_front.c|1 - > drivers/gpu/host1x/bus.c | 29 +- > drivers/gpu/host1x/context.c |2 +- > drivers/gpu/host1x/dev.c |3 +- > drivers/gpu/ipu-v3/ipu-common.c

Re: [Intel-gfx] [PULL] drm-misc-next

2023-07-18 Thread Daniel Vetter
00644 drivers/accel/ivpu/ivpu_fw_log.h > create mode 100644 drivers/gpu/drm/drm_exec.c > create mode 100644 drivers/gpu/drm/loongson/Kconfig > create mode 100644 drivers/gpu/drm/loongson/Makefile > create mode 100644 drivers/gpu/drm/loongson/loongson_device.c > create mode 100644 drivers/gpu/drm/loongson/loongson_module.c > create mode 100644 drivers/gpu/drm/loongson/loongson_module.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_benchmark.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_benchmark.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_crtc.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_debugfs.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_drv.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_drv.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_gem.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_gem.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_gfxpll.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_gfxpll.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_i2c.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_i2c.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_irq.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_irq.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_output.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_output_7a1000.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_output_7a2000.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_pixpll.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_pixpll.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_plane.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_probe.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_probe.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_regs.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_ttm.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_ttm.h > delete mode 100644 drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramga102.c > create mode 100644 drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgp102.c > create mode 100644 drivers/gpu/drm/panel/panel-visionox-r66451.c > create mode 100644 drivers/gpu/drm/tests/drm_exec_test.c > create mode 100644 drivers/video/fbdev/core/fb_backlight.c > create mode 100644 drivers/video/fbdev/core/fb_chrdev.c > create mode 100644 drivers/video/fbdev/core/fb_info.c > create mode 100644 drivers/video/fbdev/core/fb_internal.h > create mode 100644 drivers/video/fbdev/core/fb_procfs.c > create mode 100644 include/drm/drm_exec.h > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Frankenstrasse 146, 90461 Nuernberg, Germany > GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman > HRB 36809 (AG Nuernberg) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH] drm/i915: taint kernel when force probing unsupported devices

2023-05-03 Thread Daniel Vetter
port") > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: Daniel Vetter > Cc: Dave Airlie > Signed-off-by: Jani Nikula Acked-by: Daniel Vetter > --- > drivers/gpu/drm/i915/Kconfig| 13 - > drivers/gpu/drm/i915/i915_pci.c |

Re: [Intel-gfx] IOCTL feature detection (Was: Re: [PATCH 8/8] drm/i915: Allow user to set cache at BO creation)

2023-04-26 Thread Daniel Vetter
ill work, but more a list of extensions that > > conceivably could work. Normally this should just a matter of the > > kernel unconditionally adding the newly implemented extension to the > > list returned in the query call. > > > > If a GET_PARAM can be made for the PXP case, then it seems like a > > query item returning CONTEXT_CREATE extensions could conditionally > > omit that extension just as easily as implementing the proposed new > > GET_PARAM. > > > > -Jordan -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-19 Thread Daniel Vetter
On Wed, Apr 19, 2023 at 09:30:11AM -0700, Nathan Chancellor wrote: > On Wed, Apr 19, 2023 at 06:24:37PM +0200, Daniel Vetter wrote: > > On Tue, Apr 18, 2023 at 07:34:44PM +0100, Mark Brown wrote: > > > On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: &

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-19 Thread Daniel Vetter
On Tue, Apr 18, 2023 at 07:34:44PM +0100, Mark Brown wrote: > On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > > > Note there was a ppc compile fail, which is why we pushed the ttm revert. > > That /should/ be fixed now, but would be good if you can confi

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-16 Thread Daniel Vetter
l, which is why we pushed the ttm revert. That /should/ be fixed now, but would be good if you can confirm? Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH v2] drm/i915: avoid flush_scheduled_work() usage

2023-04-16 Thread Daniel Vetter
This > patch eliminates > interference from work items outside of i915, which is small but an > improvement for i915 users. I think if someone from i915 team triple-checks that i915 really doesn't use any of the drm workers (hotplug handling, atomic commit, ...) then I think we should be

Re: [Intel-gfx] [PULL] drm-misc-fixes

2023-04-13 Thread Daniel Vetter
or > > > Asahi Lina (1): > drm/scheduler: Fix UAF race in drm_sched_entity_push_job() > > Christophe JAILLET (1): > drm/armada: Fix a potential double free in an error handling path > > Daniel Vette

Re: [Intel-gfx] [PULL] drm-intel-next-fixes

2023-04-13 Thread Daniel Vetter
_gt_regs.h | 1 + > drivers/gpu/drm/i915/gt/intel_workarounds.c | 19 +++ > 2 files changed, 20 insertions(+) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-13 Thread Daniel Vetter
On Thu, 13 Apr 2023 at 11:46, Christian König wrote: > > Am 13.04.23 um 10:48 schrieb Daniel Vetter: > > On Wed, 12 Apr 2023 at 16:18, Christian König > > wrote: > >> Am 12.04.23 um 11:08 schrieb Daniel Vetter: > >>> On Tue, 11 Apr 2023 at 15:45, Dani

Re: [Intel-gfx] [PULL] drm-intel-fixes

2023-04-13 Thread Daniel Vetter
+ > > > Jani Nikula (1): > drm/i915/dsi: fix DSS CTL register offsets for TGL+ > > drivers/gpu/drm/i915/display/icl_dsi.c | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) > >

Re: [Intel-gfx] [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-13 Thread Daniel Vetter
On Wed, 12 Apr 2023 at 16:18, Christian König wrote: > > Am 12.04.23 um 11:08 schrieb Daniel Vetter: > > On Tue, 11 Apr 2023 at 15:45, Daniel Vetter wrote: > >> On Tue, Apr 11, 2023 at 02:11:18PM +0200, Christian König wrote: > >>> Am 11.04.23 um 11:51 schrieb

Re: [Intel-gfx] [PATCH v3 4/7] drm/i915: Switch to fdinfo helper

2023-04-12 Thread Daniel Vetter
On Wed, Apr 12, 2023 at 04:12:41PM +0100, Tvrtko Ursulin wrote: > > On 12/04/2023 14:51, Daniel Vetter wrote: > > On Wed, Apr 12, 2023 at 01:32:43PM +0100, Tvrtko Ursulin wrote: > > > > > > On 11/04/2023 23:56, Rob Clark wrote: > > > > From: Rob Clark

Re: [Intel-gfx] [PULL] drm-misc-next

2023-04-12 Thread Daniel Vetter
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.h    |   5 - >  drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c    |  45 +++- >  drivers/gpu/drm/vmwgfx/vmwgfx_msg.c        |  35 +-- >  drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c    |   6 - >  21 files changed, 465 insertions(+), 303 deletions(-) >  create mode 100644 > Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml >  delete mode 100644 > Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH v3 4/7] drm/i915: Switch to fdinfo helper

2023-04-12 Thread Daniel Vetter
lass(p, client, i); > > } > > #endif > > diff --git a/drivers/gpu/drm/i915/i915_drm_client.h > > b/drivers/gpu/drm/i915/i915_drm_client.h > > index 69496af996d9..ef85fef45de5 100644 > > --- a/drivers/gpu/drm/i915/i915_drm_client.h > > +++ b/drivers/gpu/drm/i915/i915_drm_client.h > > @@ -60,7 +60,7 @@ static inline void i915_drm_client_put(struct > > i915_drm_client *client) > > struct i915_drm_client *i915_drm_client_add(struct i915_drm_clients > > *clients); > > #ifdef CONFIG_PROC_FS > > -void i915_drm_client_fdinfo(struct seq_file *m, struct file *f); > > +void i915_drm_client_fdinfo(struct drm_printer *p, struct drm_file *file); > > #endif > > void i915_drm_clients_fini(struct i915_drm_clients *clients); -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-12 Thread Daniel Vetter
On Tue, 11 Apr 2023 at 15:45, Daniel Vetter wrote: > > On Tue, Apr 11, 2023 at 02:11:18PM +0200, Christian König wrote: > > Am 11.04.23 um 11:51 schrieb Daniel Vetter: > > > On Tue, Apr 04, 2023 at 10:06:49PM +0200, Thomas Hellström wrote: > > > > When swappi

Re: [Intel-gfx] [PATCH 0/2] Add support for dumping error captures via kernel logging

2023-04-11 Thread Daniel Vetter
ers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 53 + > > > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h | 6 + > > > drivers/gpu/drm/i915/i915_gpu_error.c | 130 ++ > > > drivers/gpu/drm/i915/i915_gpu_error.h | 8 ++ > > > 4 files changed, 197 insertions(+) > > > > > > -- > > > 2.39.1 > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH] fbmem: Reject FB_ACTIVATE_KD_TEXT from userspace

2023-04-11 Thread Daniel Vetter
On Tue, Apr 11, 2023 at 04:03:24PM +0200, Javier Martinez Canillas wrote: > Daniel Vetter writes: > > > This is an oversight from dc5bdb68b5b3 ("drm/fb-helper: Fix vt > > restore") - I failed to realize that nasty userspace could set this. > > > > I

Re: [Intel-gfx] [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-11 Thread Daniel Vetter
On Tue, Apr 11, 2023 at 02:11:18PM +0200, Christian König wrote: > Am 11.04.23 um 11:51 schrieb Daniel Vetter: > > On Tue, Apr 04, 2023 at 10:06:49PM +0200, Thomas Hellström wrote: > > > When swapping out, we will split multi-order pages both in order to > > >

Re: [Intel-gfx] [PATCH] fbmem: Reject FB_ACTIVATE_KD_TEXT from userspace

2023-04-11 Thread Daniel Vetter
On Tue, Apr 04, 2023 at 09:39:34PM +0200, Daniel Vetter wrote: > This is an oversight from dc5bdb68b5b3 ("drm/fb-helper: Fix vt > restore") - I failed to realize that nasty userspace could set this. > > It's not pretty to mix up kernel-internal and userspace uapi flags

Re: [Intel-gfx] [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-11 Thread Daniel Vetter
for (i = 0; i < TTM_DIM_ORDER; ++i) { > ttm_pool_type_init(_write_combined[i], NULL, > ttm_write_combined, i); > ttm_pool_type_init(_uncached[i], NULL, ttm_uncached, i); > @@ -790,7 +798,7 @@ void ttm_pool_mgr_fini(void) > { > unsigned int i; > > - for (i = 0; i < MAX_ORDER; ++i) { > + for (i = 0; i < TTM_DIM_ORDER; ++i) { > ttm_pool_type_fini(_write_combined[i]); > ttm_pool_type_fini(_uncached[i]); > > -- > 2.39.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-intel-next

2023-04-06 Thread Daniel Vetter
delete mode 100644 drivers/gpu/drm/i915/Kconfig.unstable > create mode 100644 drivers/gpu/drm/i915/display/intel_dp_aux_regs.h > create mode 100644 drivers/gpu/drm/i915/display/intel_dsb_regs.h > create mode 100644 drivers/gpu/drm/i915/display/intel_fdi_regs.h > create mode 100644 drivers/gpu/drm/i915/display/intel_pps_regs.h > create mode 100644 drivers/gpu/drm/i915/display/intel_psr_regs.h > create mode 100644 drivers/gpu/drm/i915/display/intel_tv_regs.h > create mode 100644 drivers/gpu/drm/i915/display/skl_watermark_regs.h > create mode 100644 drivers/gpu/drm/i915/intel_clock_gating.c > create mode 100644 drivers/gpu/drm/i915/intel_clock_gating.h > delete mode 100644 drivers/gpu/drm/i915/intel_pm.c > delete mode 100644 drivers/gpu/drm/i915/intel_pm.h -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-intel-gt-next

2023-04-06 Thread Daniel Vetter
bridge/ti-sn65dsi83, ps8640. > > - Use pci aperture helpers in drm/ast lynxfb, radeonfb. > > - Revert some lima patches, as they required a commit that has been > >reverted upstream. > > - Add AUO NE135FBM-N41 v8.1 eDP panel. > > - Add QAIC accel driver. > > >

Re: [Intel-gfx] [PULL] drm-intel-gt-next

2023-04-06 Thread Daniel Vetter
t; drivers/gpu/drm/i915/i915_pci.c| 1 + > drivers/gpu/drm/i915/i915_perf.c | 570 > ++++- > drivers/gpu/drm/i915/i915_perf.h | 4 +- > drivers/gpu/drm/i915/i915_perf_oa_regs.h | 78 +++ > drivers/gpu/drm/i915/i915_perf_types.h | 75 ++- > drivers/gpu/drm/i915/i915_pmu.c| 10 +- > drivers/gpu/drm/i915/i915_reg.h| 14 +- > drivers/gpu/drm/i915/i915_scatterlist.c| 2 +- > drivers/gpu/drm/i915/i915_vma.c| 3 +- > drivers/gpu/drm/i915/intel_device_info.h | 1 + > drivers/gpu/drm/i915/intel_region_ttm.c| 1 + > drivers/gpu/drm/i915/intel_uncore.c| 47 +- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 356 - > include/uapi/drm/i915_drm.h| 25 +- > 63 files changed, 1241 insertions(+), 637 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-06 Thread Daniel Vetter
On Wed, 5 Apr 2023 at 19:46, Patrik Jakobsson wrote: > > On Wed, Apr 5, 2023 at 7:15 PM Daniel Vetter wrote: > > > > On Wed, 5 Apr 2023 at 18:54, Javier Martinez Canillas > > wrote: > > > > > > Daniel Vetter writes: > > > > > > &

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 06:50:22AM -0700, Rob Clark wrote: > On Wed, Apr 5, 2023 at 6:31 AM Daniel Vetter wrote: > > > > If the crtc is being switched on or off then the semantics of > > computing the timestampe of the next vblank is somewhat ill-defined. > >

Re: [Intel-gfx] [PATCH 3/3] drm/fb-helper: fix input validation gaps in check_var

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 07:42:08PM +0200, Javier Martinez Canillas wrote: > Daniel Vetter writes: > > > On Wed, Apr 05, 2023 at 06:27:17PM +0200, Javier Martinez Canillas wrote: > >> Daniel Vetter writes: > > [...] > > >> > > >> > Th

Re: [Intel-gfx] [PULL] drm-misc-fixes

2023-04-05 Thread Daniel Vetter
rmann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > (HRB 36809, AG Nürnberg) > Geschäftsführer: Felix Imendörffer -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH 3/3] drm/fb-helper: fix input validation gaps in check_var

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 06:27:17PM +0200, Javier Martinez Canillas wrote: > Daniel Vetter writes: > > [...] > > >> > >> but only the 'var->xres > fb->width || var->yres > fb->height' from the > >> conditions checked could be false after

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Daniel Vetter
On Wed, 5 Apr 2023 at 18:54, Javier Martinez Canillas wrote: > > Daniel Vetter writes: > > > On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote: > > [...] > > >> > > >/* > >> > > > * WARNING: App

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote: > Hi > > Am 05.04.23 um 15:18 schrieb Daniel Vetter: > > On Wed, Apr 05, 2023 at 01:16:27PM +0200, Javier Martinez Canillas wrote: > > > Thomas Zimmermann writes: > > > > > > [...]

[Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Daniel Vetter
...@linaro.org/ Fixes: d39e48ca80c0 ("drm/atomic-helper: Set fence deadline for vblank") Cc: Ville Syrjälä Cc: Rob Clark Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Reported-by: Dmitry Baryshkov Tested-by: Dmitry Baryshkov # test patch only Cc: Dmitry

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 03:25:15PM +0300, Ville Syrjälä wrote: > On Wed, Apr 05, 2023 at 10:16:50AM +0200, Daniel Vetter wrote: > > If the crtc is being switched on or off then the semantics of > > computing the timestampe of the next vblank is somewhat ill-defined. > > And in

Re: [Intel-gfx] [PATCH 1/3] drm/fb-helper: set x/yres_virtual in drm_fb_helper_check_var

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 12:21:11PM +0200, Javier Martinez Canillas wrote: > Daniel Vetter writes: > > > Drivers are supposed to fix this up if needed if they don't outright > > reject it. Uncovered by 6c11df58fd1a ("fbmem: Check virtual screen > > sizes in fb_set_

Re: [Intel-gfx] [PATCH 3/3] drm/fb-helper: fix input validation gaps in check_var

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 12:52:12PM +0200, Javier Martinez Canillas wrote: > Daniel Vetter writes: > > > Apparently drivers need to check all this stuff themselves, which for > > most things makes sense I guess. And for everything else we luck out, > > because modern di

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Daniel Vetter
s to be at least a common "nuke a legacy vga device for me pls" function, which shares the implementation with the pci one. But not open-coding just half of it only. > > if (ret) > > return ret; > > > > return 0; > > } > > > > If this is enough I agree that is much more easier code to understand. It's still two calls and more code with more bugs? I'm not seeing the point. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-intel-fixes

2023-04-05 Thread Daniel Vetter
++ > drivers/gpu/drm/i915/gt/uc/intel_huc.h | 7 +-- > drivers/gpu/drm/i915/i915_perf.c | 6 +++--- > 6 files changed, 25 insertions(+), 14 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 11:26:51AM +0200, Thomas Zimmermann wrote: > Hi > > Am 05.04.23 um 10:59 schrieb Daniel Vetter: > > On Wed, Apr 05, 2023 at 10:07:54AM +0200, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 05.04.23 um 09:49 schrieb Thomas

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 10:19:55AM +0200, Thomas Zimmermann wrote: > Hi > > Am 04.04.23 um 22:18 schrieb Daniel Vetter: > > This one nukes all framebuffers, which is a bit much. In reality > > gma500 is igpu and never shipped with anything discrete, so there should >

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 10:07:54AM +0200, Thomas Zimmermann wrote: > Hi > > Am 05.04.23 um 09:49 schrieb Thomas Zimmermann: > > Hi > > > > Am 04.04.23 um 22:18 schrieb Daniel Vetter: > > > This one nukes all framebuffers, which is a bit much. In reality &g

Re: [Intel-gfx] [PATCH 7/8] video/aperture: Only remove sysfb on the default vga pci device

2023-04-05 Thread Daniel Vetter
On Tue, Apr 04, 2023 at 01:59:33PM -0700, Aaron Plattner wrote: > On 4/4/23 1:18 PM, Daniel Vetter wrote: > > Instead of calling aperture_remove_conflicting_devices() to remove the > > conflicting devices, just call to aperture_detach_devices() to detach > > the device that

[Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Daniel Vetter
tomic-helper: Set fence deadline for vblank") Cc: Rob Clark Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Reported-by: Dmitry Baryshkov Tested-by: Dmitry Baryshkov # test patch only Cc: Dmitry Baryshkov Signed-off-by: Daniel Vetter --- drive

Re: [Intel-gfx] [PATCH v10 11/15] drm/atomic-helper: Set fence deadline for vblank

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 12:53:29AM +0300, Dmitry Baryshkov wrote: > On 04/04/2023 22:16, Daniel Vetter wrote: > > On Tue, Apr 04, 2023 at 08:22:05PM +0300, Dmitry Baryshkov wrote: > > > On 08/03/2023 17:53, Rob Clark wrote: > > > > From: Rob Clark > > > &

[Intel-gfx] [PATCH 8/8] fbdev: Simplify fb_is_primary_device for x86

2023-04-04 Thread Daniel Vetter
Signed-off-by: Daniel Vetter Cc: Daniel Vetter Cc: Helge Deller Cc: Daniel Vetter Cc: Javier Martinez Canillas Cc: Thomas Zimmermann Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: x...@kernel.org Cc: "H. Peter Anvin" --- arch/x86/video/fbdev.c | 13 +

[Intel-gfx] [PATCH 4/8] video/aperture: Only kick vgacon when the pdev is decoding vga

2023-04-04 Thread Daniel Vetter
a special case for kicking out the vgacon driver only (Thomas) References: https://bugzilla.kernel.org/show_bug.cgi?id=216303 Signed-off-by: Daniel Vetter Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: Helge Deller Cc: linux-fb...@vger.kernel.org --- drivers/video/aperture.c | 16

[Intel-gfx] [PATCH 7/8] video/aperture: Only remove sysfb on the default vga pci device

2023-04-04 Thread Daniel Vetter
16303#c28 Signed-off-by: Daniel Vetter Cc: Aaron Plattner Cc: Javier Martinez Canillas Cc: Thomas Zimmermann Cc: Helge Deller Cc: Sam Ravnborg Cc: Alex Deucher Cc: # v5.19+ (if someone else does the backport) --- drivers/video/aperture.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[Intel-gfx] [PATCH 6/8] video/aperture: Drop primary argument

2023-04-04 Thread Daniel Vetter
in an actual driver left to touch. Signed-off-by: Daniel Vetter Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: "K. Y. Srinivasan" Cc: Haiyang Zhang Cc: Wei Liu Cc: Dexuan Cui Cc:

[Intel-gfx] [PATCH 5/8] video/aperture: Move vga handling to pci function

2023-04-04 Thread Daniel Vetter
function, and the other in the generic one. v2: Rebase. Signed-off-by: Daniel Vetter Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: Helge Deller Cc: linux-fb...@vger.kernel.org --- drivers/video/aperture.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git

[Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-04 Thread Daniel Vetter
only use non-pci helper, then we don't get the vga handling, and subsequent refactoring to untangle these special cases won't work. It's not pretty, but the simplest fix (since gma500 really is the only quirky pci driver like this we have) is to just have both calls. Signed-off-by: Daniel Vetter

[Intel-gfx] [PATCH 3/8] drm/aperture: Remove primary argument

2023-04-04 Thread Daniel Vetter
: - Reorder to avoid compile fail (Thomas) - Include gma500, which retained it's called to the non-pci version. Signed-off-by: Daniel Vetter Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Deepak Rawat Cc: Neil Armstrong Cc: Kevin Hilman Cc: Jerome

[Intel-gfx] [PATCH 2/8] video/aperture: use generic code to figure out the vga default device

2023-04-04 Thread Daniel Vetter
end commit message trying to summarize various discussions. Signed-off-by: Daniel Vetter Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: Bjorn Helgaas Cc: linux-...@vger.kernel.org --- drivers/video/aperture.c | 6 ++ 1 file changed, 2

[Intel-gfx] [PATCH 3/3] drm/fb-helper: fix input validation gaps in check_var

2023-04-04 Thread Daniel Vetter
. Therefore fixing all this just for drm fbdev emulation is good enough. Note that var->active is not set or validated. This is just control flow for fbmem.c and needs to be validated in there as needed. Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmerm

[Intel-gfx] [PATCH 2/3] drm/fb-helper: drop redundant pixclock check from drm_fb_helper_set_par()

2023-04-04 Thread Daniel Vetter
The fb_check_var hook is supposed to validate all this stuff. Any errors from fb_set_par are considered driver/hw issues and resulting in dmesg warnings. Luckily we do fix up the pixclock already, so this is all fine. Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc

[Intel-gfx] [PATCH 1/3] drm/fb-helper: set x/yres_virtual in drm_fb_helper_check_var

2023-04-04 Thread Daniel Vetter
com/bug?id=c5faf983bfa4a607de530cd3bb00bf06cefc Cc: sta...@vger.kernel.org # v5.4+ Cc: Daniel Vetter Cc: Javier Martinez Canillas Cc: Thomas Zimmermann Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drive

[Intel-gfx] [PATCH] fbmem: Reject FB_ACTIVATE_KD_TEXT from userspace

2023-04-04 Thread Daniel Vetter
. Signed-off-by: Daniel Vetter Fixes: dc5bdb68b5b3 ("drm/fb-helper: Fix vt restore") Cc: Alex Deucher Cc: shl...@fastmail.com Cc: Michel Dänzer Cc: Noralf Trønnes Cc: Thomas Zimmermann Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: David Airlie Cc: Da

Re: [Intel-gfx] [PATCH v10 11/15] drm/atomic-helper: Set fence deadline for vblank

2023-04-04 Thread Daniel Vetter
dline. > > > > v2: Comment typo fix (danvet) > > v3: If there are multiple CRTCs, consider the time of the soonest vblank > > > > Signed-off-by: Rob Clark > > Reviewed-by: Daniel Vetter > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/dr

Re: [Intel-gfx] [PULL] drm-misc-next

2023-04-03 Thread Daniel Vetter
+- > drivers/gpu/drm/panfrost/panfrost_drv.c| 37 + > drivers/gpu/drm/panfrost/panfrost_gpu.c| 8 ++ > drivers/gpu/drm/scheduler/sched_main.c | 2 +- > drivers/gpu/drm/sun4i/sun4i_backend.c | 2 +- > drivers/gpu/drm/sun4i/sun8i_mixer.c| 2 +- > drivers/gpu/drm/tiny/ofdrm.c | 8 +- > drivers/gpu/drm/tiny/simpledrm.c | 2 +- > drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- > 54 files changed, 356 insertions(+), 179 deletions(-) > delete mode 100644 > Documentation/devicetree/bindings/display/panel/innolux,p120zdg-bf1.yaml -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-misc-fixes

2023-03-30 Thread Daniel Vetter
ivers/gpu/drm/drm_buddy.c | 4 +- > drivers/gpu/drm/nouveau/nouveau_backlight.c | 7 +- > drivers/gpu/drm/tests/drm_buddy_test.c | 3 +- > 10 files changed, 90 insertions(+), 93 deletions(-) > > -- > Thomas Zimmermann > Graphics Driver Develop

Re: [Intel-gfx] [PULL] drm-intel-fixes

2023-03-30 Thread Daniel Vetter
drivers/gpu/drm/i915/i915_perf.c | 14 ++-- > drivers/gpu/drm/i915/i915_perf_types.h | 6 ++ > drivers/gpu/drm/i915/i915_pmu.c | 10 +-- > 13 files changed, 177 insertions(+), 42 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-intel-next

2023-03-24 Thread Daniel Vetter
gt; include/drm/display/drm_dp.h | 3 + > include/drm/i915_hdcp_interface.h | 539 + > include/drm/i915_mei_hdcp_interface.h | 184 - > 58 files changed, 3322 insertions(+), 1467 deletions(-) > create mode 100644 drivers/gpu/drm/i915/display/intel_hdcp_gsc.c > create mode 100644 drivers/gpu/drm/i915/display/intel_hdcp_gsc.h > create mode 100644 drivers/gpu/drm/i915/display/intel_sprite_uapi.c > create mode 100644 drivers/gpu/drm/i915/display/intel_sprite_uapi.h > create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c > create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.h > create mode 100644 include/drm/i915_hdcp_interface.h > delete mode 100644 include/drm/i915_mei_hdcp_interface.h -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-misc-next

2023-03-24 Thread Daniel Vetter
s/gpu/drm/lima/lima_gem.c| 12 +- > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c| 1 + > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 11 +- > drivers/gpu/drm/tests/drm_format_helper_test.c | 141 ++--- > drivers/gpu/drm/tiny/bochs.c | 1 - > drivers/gpu/drm/ttm/ttm_bo.c | 3 +- > drivers/gpu/drm/vgem/vgem_drv.h| 11 - > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c| 1 - > include/drm/drm_drv.h | 2 - > include/drm/drm_fb_helper.h| 14 +- > include/drm/drm_mode_config.h | 7 - > 44 files changed, 664 insertions(+), 799 deletions(-) > create mode 100644 drivers/gpu/drm/gma500/fbdev.c -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-intel-fixes

2023-03-24 Thread Daniel Vetter
/intel_guc_rc.c | 13 + > drivers/gpu/drm/i915/i915_active.c | 3 +-- > drivers/gpu/drm/i915/i915_hwmon.c | 5 - > drivers/gpu/drm/i915/i915_reg.h| 17 +--- > 13 files changed, 88 insertions(+), 72 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-misc-fixes

2023-03-24 Thread Daniel Vetter
> -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > (HRB 36809, AG Nürnberg) > Geschäftsführer: Felix Imendörffer -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-03-09 Thread Daniel Vetter
On Thu, 2 Mar 2023 at 00:00, Rodrigo Vivi wrote: > On Fri, Feb 17, 2023 at 09:51:37PM +0100, Daniel Vetter wrote: > > Hi all, > > > > [I thought I've sent this out earlier this week, but alas got stuck, kinda > > bad timing now since I'm out next week but oh wel

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-02-17 Thread Daniel Vetter
include/drm/drm_suballoc.h | 112 ++ > include/drm/gpu_scheduler.h | 41 ++- > sound/hda/hdac_i915.c | 17 +- > sound/pci/hda/hda_intel.c | 56 +-- > sound/soc/intel/avs/core.c| 13 +- > sound/soc/sof/intel/hda.c | 7 +- > 98 files changed, 2076 insertions(+), 1325 deletions(-) > create mode 100644 drivers/gpu/drm/drm_pt_walk.c > create mode 100644 drivers/gpu/drm/drm_suballoc.c > create mode 100644 include/drm/drm_pt_walk.h > create mode 100644 include/drm/drm_suballoc.h > > -- > 2.37.3 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH] drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()

2023-02-17 Thread Daniel Vetter
On Fri, Feb 17, 2023 at 09:18:54AM +0100, Thomas Zimmermann wrote: > Hi > > Am 16.02.23 um 21:11 schrieb Daniel Vetter: > > On Thu, Feb 16, 2023 at 03:06:20PM +0100, Thomas Zimmermann wrote: > > > Move drm_fb_helper_unprepare() from drm_fb_helper_fini() into the > >

Re: [Intel-gfx] [PATCH 0/1] drm: Add a gpu page-table walker

2023-02-16 Thread Daniel Vetter
drivers/gpu/drm/drm_pt_walk.c > create mode 100644 include/drm/drm_pt_walk.h > > -- > 2.34.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH] drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()

2023-02-16 Thread Daniel Vetter
_helper_unprepare()") > Cc: Thomas Zimmermann > Cc: Javier Martinez Canillas > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-de...@lists.freedesktop.org > > Signed-off-by: Thomas Zimmermann This reminds me of a

Re: [Intel-gfx] [RFC v3 0/9] Waitboost drm syncobj waits

2023-02-16 Thread Daniel Vetter
intel_breadcrumbs.c | 22 > drivers/gpu/drm/i915/gt/intel_engine_pm.c | 1 - > drivers/gpu/drm/i915/i915_active.c | 2 +- > drivers/gpu/drm/i915/i915_active.h | 2 +- > drivers/gpu/drm/i915/i915_request.c | 13 +- > drivers/gpu/drm/vmwgfx/vmwgfx_fence.c

  1   2   3   4   5   6   7   8   9   10   >