Re: i915 IVB hangup after resume from s2mem since v6.6.x

[cc += Thomas] On Mon, May 06, 2024 at 08:43:43PM +0200, Johannes Stezenbach wrote: > so, git bisect pointed to: > > commit 701d2054fa317188cd4039c84e72c73254013b23 > Author: Thomas Zimmermann > Date: Tue Jun 13 13:07:13 2023 +0200 > > fbdev: Make support for userspace interfaces

Re: [Intel-gfx] [PATCH 10/13] drm/i915/lvds: switch to drm_edid_read_switcheroo()

t;intel_gmbus_get_adapter(i915, > pin)); No need for curly braces anymore, but regardless: Reviewed-by: Lukas Wunner

Re: [Intel-gfx] [PATCH v2 3/3] drm: Call vga_switcheroo_process_delayed_switch() in drm_lastclose

On Thu, Jan 12, 2023 at 09:11:56PM +0100, Thomas Zimmermann wrote: > Several lastclose helpers call vga_switcheroo_process_delayed_switch(). > It's better to call the helper from drm_lastclose() after the kernel > client's screen has been restored. This way, all drivers can benefit > without

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

On Tue, Aug 16, 2022 at 11:06:18AM +0300, Jani Nikula wrote: > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > dGFX so external monitors are routed to dGFX, and more monitors can be > > supported as result. > > > > To

Re: [Intel-gfx] [PATCH v2 4/4] vgaswitcheroo: do not check for NULL debugfs dentry

g like: Retry creation of the vga_switcheroo debugfs if a previous invocation of debugfs_create_dir() returned an error code. With that addressed, Reviewed-by: Lukas Wunner Thanks, Lukas > Signed-off-by: Nirmoy Das > --- > drivers/gpu/vga/vga_switcheroo.c | 2 +- > 1 file ch

Re: [Intel-gfx] [PATCH 4/4] vgaswitcheroo: do not check for NULL debugfs dentry

On Mon, Oct 11, 2021 at 10:24:29PM +0200, Lukas Wunner wrote: > On Mon, Oct 11, 2021 at 09:06:07PM +0200, Nirmoy Das wrote: > > Debugfs APIs returns encoded error on failure so use > > debugfs_lookup() instead of checking for NULL. > [...] > > --- a/drivers/gpu/vga/vg

Re: [Intel-gfx] [PATCH 4/4] vgaswitcheroo: do not check for NULL debugfs dentry

On Mon, Oct 11, 2021 at 09:06:07PM +0200, Nirmoy Das wrote: > Debugfs APIs returns encoded error on failure so use > debugfs_lookup() instead of checking for NULL. [...] > --- a/drivers/gpu/vga/vga_switcheroo.c > +++ b/drivers/gpu/vga/vga_switcheroo.c > @@ -914,7 +914,7 @@ static void

Re: [Intel-gfx] [PATCH RESEND] drm/i915: register vga switcheroo later, unregister earlier

with a simple > error message. This is done at the same time due to lack of error > propagation from i915_driver_register(). > > Signed-off-by: Jani Nikula Acked-by: Lukas Wunner Seems like a good idea to limp on instead of bailing out if vga_switcheroo registration fails. Tak

Re: [Intel-gfx] [PATCH 30/33] vgaswitcheroo: call fbcon_remap_all directly

void fbcon_remap_all(int idx) That comment needs to be removed as well. Not an expert on fbcon code but this looks sane to me, so in case it helps: Acked-by: Lukas Wunner Thanks, Lukas ___ Intel-gfx mailing list Intel-gfx@lists.

Re: [Intel-gfx] [PATCH] drm/i915: Ensure proper HDA suspend/resume ordering with a device link

On Thu, Oct 18, 2018 at 05:25:58PM +0300, Imre Deak wrote: > In order to ensure that our system suspend and resume callbacks are > called in the correct order wrt. those of the HDA driver add a device > link to the HDA driver during audio component binding time. With i915 as > the supplier and HDA

Re: [Intel-gfx] [PATCH] drm/i915: Tell vga_switcheroo whether runtime PM is used

On Mon, Mar 05, 2018 at 05:37:11PM +0200, Imre Deak wrote: > On Mon, Feb 26, 2018 at 04:57:11PM +0100, Lukas Wunner wrote: > > On Mon, Feb 26, 2018 at 04:41:09PM +0200, Imre Deak wrote: > > > On Sun, Feb 25, 2018 at 12:42:30AM +0100, Lukas Wunner wrote: > > >

Re: [Intel-gfx] [PATCH] drm/i915: Tell vga_switcheroo whether runtime PM is used

On Mon, Feb 26, 2018 at 04:41:09PM +0200, Imre Deak wrote: > On Sun, Feb 25, 2018 at 12:42:30AM +0100, Lukas Wunner wrote: > > DRM drivers need to tell vga_switcheroo whether they use runtime PM. > > If they do use it, vga_switcheroo lets them autosuspend at their own

[Intel-gfx] [PATCH] drm/i915: Tell vga_switcheroo whether runtime PM is used

el.com> Signed-off-by: Lukas Wunner <lu...@wunner.de> --- drivers/gpu/drm/i915/i915_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index aaa861b51024..519a1b9568df 100644 --- a/drivers/gpu/drm/

Re: [Intel-gfx] [Nouveau] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Mon, Feb 19, 2018 at 03:05:53PM +0100, Daniel Vetter wrote: > On Mon, Feb 19, 2018 at 12:58:17PM +0100, Lukas Wunner wrote: > > On Mon, Feb 19, 2018 at 12:34:43PM +0100, Daniel Vetter wrote: > > > Well, userspace expects hotplug events, even when we runtime suspend > &g

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Mon, Feb 19, 2018 at 12:48:04PM +0100, Daniel Vetter wrote: > On Thu, Feb 15, 2018 at 06:38:44AM +0100, Lukas Wunner wrote: > > On Wed, Feb 14, 2018 at 09:58:43AM -0500, Sean Paul wrote: > > > On Wed, Feb 14, 2018 at 03:43:56PM +0100, Michel Dänzer wrote: > > > >

Re: [Intel-gfx] [Nouveau] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Mon, Feb 19, 2018 at 12:34:43PM +0100, Daniel Vetter wrote: > On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: > > Fix a deadlock on hybrid graphics laptops that's been present since 2013: > > > > DRM drivers poll connectors in 10 sec intervals. The poll

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: > workqueue: Allow retrieval of current task's work struct > drm: Allow determining if current task is output poll worker > drm/nouveau: Fix deadlock on runtime suspend > drm/radeon: Fix deadlock on runtime sus

[Intel-gfx] i915 runtime PM (was: Re: [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers)

[trimming cc: a little to avoid spamming folks not directly involved with i915] On Mon, Feb 12, 2018 at 03:04:06PM +0200, Imre Deak wrote: > On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: > > i915, malidp and msm "solved" this issue by not stopping the poll wo

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Wed, Feb 14, 2018 at 09:58:43AM -0500, Sean Paul wrote: > On Wed, Feb 14, 2018 at 03:43:56PM +0100, Michel Dänzer wrote: > > On 2018-02-14 03:08 PM, Sean Paul wrote: > > > On Wed, Feb 14, 2018 at 10:26:35AM +0100, Maarten Lankhorst wrote: > > >> Op 14-02-18

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Tue, Feb 13, 2018 at 03:46:08PM +, Liviu Dudau wrote: > On Tue, Feb 13, 2018 at 12:52:06PM +0100, Lukas Wunner wrote: > > On Tue, Feb 13, 2018 at 10:55:06AM +, Liviu Dudau wrote: > > > On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: > > > &g

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

Dear drm-misc maintainers, On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: > Fix a deadlock on hybrid graphics laptops that's been present since 2013: This series has been reviewed, consent has been expressed by the most interested parties, patch [1/5] which touches files outs

Re: [Intel-gfx] [PATCH 2/5] drm: Allow determining if current task is output poll worker

On Mon, Feb 12, 2018 at 12:46:11PM -0500, Lyude Paul wrote: > On Sun, 2018-02-11 at 10:38 +0100, Lukas Wunner wrote: > > Introduce a helper to determine if the current task is an output poll > > worker. > > > > This allows us to fix a long-standing deadlock in seve

[Intel-gfx] [PATCH v2] drm: Allow determining if current task is output poll worker

ll worker and autosuspend worker as use case. (Lyude) Cc: Dave Airlie <airl...@redhat.com> Cc: Ben Skeggs <bske...@redhat.com> Cc: Alex Deucher <alexander.deuc...@amd.com> Reviewed-by: Lyude Paul <ly...@redhat.com> Signed-off-by: Lukas Wunner <lu...@wunner.de> ---

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Tue, Feb 13, 2018 at 10:55:06AM +, Liviu Dudau wrote: > On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: > > DRM drivers poll connectors in 10 sec intervals. The poll worker is > > stopped on ->runtime_suspend with cancel_delayed_work_sync(). However &

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Mon, Feb 12, 2018 at 01:58:32PM -0500, Alex Deucher wrote: > On Mon, Feb 12, 2018 at 4:45 AM, Lukas Wunner <lu...@wunner.de> wrote: > > On Mon, Feb 12, 2018 at 09:03:26AM +, Mike Lothian wrote: > >> On 12 February 2018 at 03:39, Lukas Wunner <lu...@wunner.de>

Re: [Intel-gfx] [PATCH 2/5] drm: Allow determining if current task is output poll worker

On Mon, Feb 12, 2018 at 05:50:12PM +, Chris Wilson wrote: > Quoting Lyude Paul (2018-02-12 17:46:11) > > On Sun, 2018-02-11 at 10:38 +0100, Lukas Wunner wrote: > > > Introduce a helper to determine if the current task is an output poll > > > worker. > > >

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Mon, Feb 12, 2018 at 09:03:26AM +, Mike Lothian wrote: > On 12 February 2018 at 03:39, Lukas Wunner <lu...@wunner.de> wrote: > > On Mon, Feb 12, 2018 at 12:35:51AM +, Mike Lothian wrote: > > > I've not been able to reproduce the original problem you're trying

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Mon, Feb 12, 2018 at 12:35:51AM +, Mike Lothian wrote: > I've not been able to reproduce the original problem you're trying to > solve on amdgpu thats with or without your patch set and the above > "trigger" too > > Is anything else required to trigger it, I started multiple DRI_PRIME >

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Sun, Feb 11, 2018 at 08:23:14PM +0100, Lukas Wunner wrote: > On Sun, Feb 11, 2018 at 06:58:11PM +, Mike Lothian wrote: > > On 11 February 2018 at 09:38, Lukas Wunner <lu...@wunner.de> wrote: > > > The patches for radeon and amdgpu are compile-tested only, I only

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Sun, Feb 11, 2018 at 06:58:11PM +, Mike Lothian wrote: > On 11 February 2018 at 09:38, Lukas Wunner <lu...@wunner.de> wrote: > > The patches for radeon and amdgpu are compile-tested only, I only have a > > MacBook Pro with an Nvidia GK107 to test. To test the patches,

[Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

l worker on runtime suspend. cc += Archit, Liviu, intel-gfx) Please review. Thanks, Lukas Lukas Wunner (5): workqueue: Allow retrieval of current task's work struct drm: Allow determining if current task is output poll worker drm/nouveau: Fix deadlock on runtime suspend drm/radeon

[Intel-gfx] [PATCH 5/5] drm/amdgpu: Fix deadlock on runtime suspend

driver (v4)") Cc: sta...@vger.kernel.org # v4.2+: 1234567890ab: workqueue: Allow retrieval of current task's work struct Cc: sta...@vger.kernel.org # v4.2+: 1234567890ab: drm: Allow determining if current task is output poll worker Cc: Alex Deucher <alexander.deuc...@amd.com> Sig

[Intel-gfx] [PATCH 2/5] drm: Allow determining if current task is output poll worker

> Cc: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Lukas Wunner <lu...@wunner.de> --- drivers/gpu/drm/drm_probe_helper.c | 14 ++ include/drm/drm_crtc_helper.h | 1 + 2 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/drm_probe_helper.c b/d

[Intel-gfx] [PATCH 4/5] drm/radeon: Fix deadlock on runtime suspend

Airlie <airl...@redhat.com> Signed-off-by: Lukas Wunner <lu...@wunner.de> --- drivers/gpu/drm/radeon/radeon_connectors.c | 74 -- 1 file changed, 49 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm

[Intel-gfx] [PATCH 1/5] workqueue: Allow retrieval of current task's work struct

ve Airlie <airl...@redhat.com> Cc: Ben Skeggs <bske...@redhat.com> Cc: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Lukas Wunner <lu...@wunner.de> --- include/linux/workqueue.h | 1 + kernel/workqueue.c| 16 2 files changed, 17 in

[Intel-gfx] [PATCH 3/5] drm/nouveau: Fix deadlock on runtime suspend

c: Ben Skeggs <bske...@redhat.com> Cc: Dave Airlie <airl...@redhat.com> Signed-off-by: Lukas Wunner <lu...@wunner.de> --- drivers/gpu/drm/nouveau/nouveau_connector.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_c

Re: [Intel-gfx] [PATCH] Revert "drm/i915: mark all device info struct with __initconst"

On Mon, Jan 29, 2018 at 09:27:39AM +, Lionel Landwerlin wrote: > On 29/01/18 09:02, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2018-01-29 08:33:46) > > > This reverts commit 5b54eddd3920e9f6f1a6d972454baf350cbae77e. > > > > > > Conflicts: > > >

Re: [Intel-gfx] [Bug 104805] regression in 4.15 unable to reboot/poweroff, vgaswitcheroo doesn't work, RIP: 0010:i915_pci_probe+0x11/0x70 [i915]

On Sat, Jan 27, 2018 at 10:42:45AM +, bugzilla-dae...@freedesktop.org wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=104805 > > --- Comment #6 from Chris Wilson --- > Sigh. Revert then solve the bloat another way. I think we can move it to a > seperate module

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Serialise early hotplug events with async fbdev config

On Sun, Nov 26, 2017 at 11:58:43AM +, Chris Wilson wrote: > Quoting Lukas Wunner (2017-11-26 11:49:19) > > Hm, the race at hand would be solved by the intel_fbdev_sync() below, > > or am I missing something? Still wondering why it's necessary to > > leave the fbdev ar

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Serialise early hotplug events with async fbdev config

ty until we unload the module. Then we > can use intel_fbdev_sync() to serialise the hotplug event with the > configuration. The serialisation between the two was removed in commit > 934458c2c95d ("Revert "drm/i915: Fix races on fbdev""), but the use > after free

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Serialise early hotplug events with async fbdev config

On Sat, Nov 25, 2017 at 07:41:55PM +, Chris Wilson wrote: > @@ -697,10 +697,8 @@ static void intel_fbdev_initial_config(void *data, > async_cookie_t cookie) > > /* Due to peculiar init order wrt to hpd handling this is separate. */ > if (drm_fb_helper_initial_config(>helper, > -

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Serialise early hotplug events with async fbdev config

On Sat, Nov 25, 2017 at 07:41:55PM +, Chris Wilson wrote: > As both the hotplug event and fbdev configuration run asynchronously, it > is possible for them to run concurrently. If configuration fails, we were > freeing the fbdev causing a use-after-free in the hotplug event. That'll teach me

Re: [Intel-gfx] [PULL] drm-misc-fixes

aving noise in it." (Dave) Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Sean Paul <seanp...@chromium.org> Cc: Dave Airlie <airl...@redhat.com> Signed-off-by: Lukas Wunner <lu...@wunner.de> --- drm-misc.rst | 8

Re: [Intel-gfx] [PULL] drm-misc-fixes

On Thu, May 25, 2017 at 01:44:04PM -0400, Sean Paul wrote: > The pull is noisy because it includes -rc2. Looks like I've caused another fine mess by fast-forwarding -fixes. :-( I followed the docs in drm-misc.rst which say: * Fast-forward (when possible) `-fixes` to each released -rc kernel

Re: [Intel-gfx] [PATCH] dim: Enforce review requirements

On Wed, May 24, 2017 at 11:28:12AM +0200, Daniel Vetter wrote: > We can't check this when applying (since r-b/a-b tags often get added > afterwards), but we can check this when pushing. This only looks at > patches authored by the pusher. BTW, can we also have a rule that large drivers (i.e. with

Re: [Intel-gfx] [PATCH] dim: Enforce review requirements

ght that review requirements hold > especially also for bugfixes. > > Cc: Patrik Jakobsson <patrik.r.jakobs...@gmail.com> > Cc: Lukas Wunner <lu...@wunner.de> > Cc: Alex Deucher <alexander.deuc...@amd.com> > Cc: Christian König <deathsim...@vodafone.de> > C

Re: [Intel-gfx] [PATCH v2 1/2] PCI / PM: Add needs_resume flag to avoid suspend complete optimization

On Tue, Apr 25, 2017 at 11:55:07AM +0300, Imre Deak wrote: > On Tue, Apr 25, 2017 at 08:21:49AM +0200, Lukas Wunner wrote: > > On Mon, Apr 24, 2017 at 10:56:40PM +0200, Rafael J. Wysocki wrote: > > > On Monday, April 24, 2017 10:42:42 PM Lukas Wunner wrote: > > > >

Re: [Intel-gfx] [PATCH v2 1/2] PCI / PM: Add needs_resume flag to avoid suspend complete optimization

On Mon, Apr 24, 2017 at 10:56:40PM +0200, Rafael J. Wysocki wrote: > On Monday, April 24, 2017 10:42:42 PM Lukas Wunner wrote: > > On Mon, Apr 24, 2017 at 10:02:30PM +0200, Lukas Wunner wrote: > > > On Mon, Apr 24, 2017 at 05:27:42PM +0300, Imre Deak wrote: > > > >

Re: [Intel-gfx] [PATCH v2 1/2] PCI / PM: Add needs_resume flag to avoid suspend complete optimization

On Mon, Apr 24, 2017 at 10:02:30PM +0200, Lukas Wunner wrote: > On Mon, Apr 24, 2017 at 05:27:42PM +0300, Imre Deak wrote: > > Some drivers - like i915 - may not support the system suspend direct > > complete optimization due to differences in their runtime and system > >

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Prevent the system suspend complete optimization

ug stayed hidden. No, the reason this hasn't popped up earlier is because direct_complete has only been enabled for DRM devices for a few months now, to be specific since commit d14d2a8453d650bea32a1c5271af1458cd283a0f Author: Lukas Wunner <lu...@wunner.de> Date: Wed Jun 8 12:49:2

Re: [Intel-gfx] [PATCH v2 1/2] PCI / PM: Add needs_resume flag to avoid suspend complete optimization

On Mon, Apr 24, 2017 at 05:27:42PM +0300, Imre Deak wrote: > Some drivers - like i915 - may not support the system suspend direct > complete optimization due to differences in their runtime and system > suspend sequence. Add a flag that when set resumes the device before > calling the driver's

Re: [Intel-gfx] [PATCH v6 1/3] ACPI / bus: Introduce a list of ids for "always present" devices

On Wed, Apr 19, 2017 at 12:28:50PM +0200, Rafael J. Wysocki wrote: > On Wed, Apr 19, 2017 at 10:59 AM, Hans de Goede wrote: > > On 18-04-17 15:34, Rafael J. Wysocki wrote: > >> On Tue, Apr 18, 2017 at 1:54 PM, Hans de Goede wrote: > >>> > >>> Several

Re: [Intel-gfx] [PATCH v3] ACPI / bus: Introduce a list of ids for "always present" devices

On Sun, Apr 09, 2017 at 11:46:41AM +0200, Hans de Goede wrote: > On 09-04-17 09:26, Lukas Wunner wrote: > > On Sat, Apr 08, 2017 at 05:05:11PM +0200, Hans de Goede wrote: > > > + pr_debug("Device [%s] is in always present list setting status > > > [%08x]\n

Re: [Intel-gfx] [PATCH v3] ACPI / bus: Introduce a list of ids for "always present" devices

On Sat, Apr 08, 2017 at 05:05:11PM +0200, Hans de Goede wrote: > Several cherrytrail devices (all of which ship with windows 10) hide the > lpss pwm controller in ACPI, typically the _STA method looks like this: > > Method (_STA, 0, NotSerialized) // _STA: Status > { > If (OSID

[Intel-gfx] [maintainer-tools PATCH] dim: Fix assorted documentation typos

Just a bunch of trivial typos that caught my eye while perusing the documentation. Signed-off-by: Lukas Wunner <lu...@wunner.de> --- dim.rst | 14 +++--- drm-intel.rst | 10 +- drm-misc.rst | 2 +- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/dim

Re: [Intel-gfx] [PATCH v2 08/40] drm: Add a simple prime number generator

On Fri, Dec 16, 2016 at 09:43:54AM +, Chris Wilson wrote: > On Fri, Dec 16, 2016 at 10:31:17AM +0100, Lukas Wunner wrote: > > On Fri, Dec 16, 2016 at 07:46:46AM +, Chris Wilson wrote: > > > Prime numbers are interesting for testing components that use multiplies

Re: [Intel-gfx] [PATCH v2 08/40] drm: Add a simple prime number generator

On Fri, Dec 16, 2016 at 07:46:46AM +, Chris Wilson wrote: > Prime numbers are interesting for testing components that use multiplies > and divides, such as testing struct drm_mm alignment computations. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/Kconfig

Re: [Intel-gfx] S4 resume breakage with i915 driver

On Mon, Aug 29, 2016 at 04:25:25PM +0100, Chris Wilson wrote: > On Mon, Aug 29, 2016 at 05:54:45PM +0300, Imre Deak wrote: > > On ma, 2016-08-29 at 16:24 +0200, Takashi Iwai wrote: > > > Hmm, this always confuses me.  Is the freeze callback called to the > > > loader kernel? > > > > It's called

Re: [Intel-gfx] [PATCH] drm/i915: Shut down displays gracefully on reboot

On Wed, Aug 03, 2016 at 04:36:18PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Dell UP2414Q doesn't like it when we're driving it in MST mode, and then > reboot the machine. After reboot, the monitor is somehow confused and > refuses to do

Re: [Intel-gfx] [PATCH 0197/1285] Replace numeric parameter like 0444 with macro

On Tue, Aug 02, 2016 at 02:37:37PM +0300, Ville Syrjälä wrote: > On Tue, Aug 02, 2016 at 06:48:47PM +0800, Baole Ni wrote: > > I find that the developers often just specified the numeric value > > when calling a macro which is defined with a parameter for access > > permission. > > As we know,

Re: [Intel-gfx] [PATCH] drm/i915: intel_dp_check_link_status should only return status of link

On Fri, Jul 01, 2016 at 03:47:56PM -0700, Manasi Navare wrote: > Intel_dp_check_link_status() function reads the Link status registers > and returns a boolean to indicate link is good or bad. > If the link is bad, it is retrained outside the function based > on the return value. > >

Re: [Intel-gfx] [PATCH 3/3] drm/i915/fbdev: Flush mode configuration before lastclose

On Fri, Jun 17, 2016 at 06:54:49PM +0100, Chris Wilson wrote: > During lastclose, we call intel_fbdev_restore_mode() to switch back to > the fbcon configuration on return to VT. However, if we have not yet > finished the asynchronous fbdev initialisation, the current mode will be > invalid and

Re: [Intel-gfx] [PATCH] drm/i915: Add a module option for disabling use of stolen memory

On Sat, Jun 11, 2016 at 09:21:11AM +0100, Chris Wilson wrote: > One of the first steps in triaging memory corruption on module load is > to disable stolen. (It helps reduce the impact of the BIOS clobbering > our memory since we allocate our ringbuffers and initial objects from > stolen, if they

Re: [Intel-gfx] [PATCH] drm/i915: Don't unregister fbdev twice

On Wed, Jun 08, 2016 at 02:09:40PM +0200, Daniel Vetter wrote: > On Wed, Jun 08, 2016 at 01:15:22PM +0200, Lukas Wunner wrote: > > Calling drm_framebuffer_unregister_private() in intel_fbdev_destroy() is > > superfluous because the framebuffer will subsequently

Re: [Intel-gfx] [Nouveau] [PATCH 9/9] drm: Turn off crtc before tearing down its data structure

On Fri, Jun 03, 2016 at 08:21:50PM +0200, Daniel Vetter wrote: > On Fri, Jun 03, 2016 at 09:30:06AM +0200, Lukas Wunner wrote: > > On Wed, Jun 01, 2016 at 04:40:12PM +0200, Daniel Vetter wrote: > > > On Wed, Jun 01, 2016 at 02:36:41PM +0200, Lukas Wunner wrote: > > > &

[Intel-gfx] [PATCH] drm/i915: Don't unregister fbdev twice

102.504651] [drm:drm_mode_object_unreference] OBJ ID: 45 (2) [ 102.504654] [drm:drm_mode_object_unreference] OBJ ID: 45 (1) Signed-off-by: Lukas Wunner <lu...@wunner.de> --- drivers/gpu/drm/i915/intel_fbdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i9

Re: [Intel-gfx] [Nouveau] [PATCH 9/9] drm: Turn off crtc before tearing down its data structure

On Wed, Jun 01, 2016 at 04:40:12PM +0200, Daniel Vetter wrote: > On Wed, Jun 01, 2016 at 02:36:41PM +0200, Lukas Wunner wrote: > > On Wed, May 25, 2016 at 03:43:42PM +0200, Daniel Vetter wrote: > > > On Wed, May 25, 2016 at 12:51 PM, Lukas Wunner <lu...@wunner.de> wrote

Re: [Intel-gfx] [Nouveau] [PATCH 9/9] drm: Turn off crtc before tearing down its data structure

On Wed, May 25, 2016 at 03:43:42PM +0200, Daniel Vetter wrote: > On Wed, May 25, 2016 at 12:51 PM, Lukas Wunner <lu...@wunner.de> wrote: > > On Tue, May 24, 2016 at 11:30:42PM +0200, Daniel Vetter wrote: > >> On Tue, May 24, 2016 at 06:03:27PM +0200, Lukas Wunner wrote

Re: [Intel-gfx] [PATCH v5] vga_switcheroo: Add helper for deferred probing

On Mon, May 23, 2016 at 09:23:14AM +0200, Daniel Vetter wrote: > On Sat, May 21, 2016 at 03:59:16PM +0100, Lukas Wunner wrote: [snip] > > /** > > + * vga_switcheroo_client_probe_defer() - whether to defer probing a given > > client > > + * @pdev: client pci devic

Re: [Intel-gfx] [Nouveau] [PATCH v4] vga_switcheroo: Add helper for deferred probing

On Mon, May 23, 2016 at 09:40:59AM +0100, Emil Velikov wrote: > On 21 May 2016 at 15:08, Lukas Wunner <lu...@wunner.de> wrote: > > Daniel Vetter explicitly wanted the ability to use the helper in > > vga_switcheroo audio clients, and those shouldn't run the apple-gmux >

[Intel-gfx] [PATCH v6 2/2] vga_switcheroo: Support deferred probing of audio clients

change. (Emil Velikov, Jani Nikula) Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Emil Velikov <emil.l.veli...@gmail.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Signed-off-by: Lukas Wunner <lu...@wunner.de> --- drivers/gpu/vga/vga_switcheroo.c | 19 +++

[Intel-gfx] [PATCH v6 1/2] vga_switcheroo: Add helper for deferred probing

> Cc: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Lukas Wunner <lu...@wunner.de> --- drivers/gpu/drm/i915/i915_drv.c | 10 +- drivers/gpu/drm/nouveau/nouveau_drm.c | 10 +- drivers/gpu/drm/radeon/radeon_drv.c | 10 +- drivers/gpu/vga/vga_s

Re: [Intel-gfx] [Nouveau] [PATCH v4] vga_switcheroo: Add helper for deferred probing

Hi Emil, On Fri, May 20, 2016 at 12:41:04AM +0100, Emil Velikov wrote: > On 19 May 2016 at 15:39, Lukas Wunner <lu...@wunner.de> wrote: > > +bool vga_switcheroo_client_probe_defer(struct pci_dev *pdev) > > +{ > > + if ((pdev->class >> 8) == PCI_CLASS_

[Intel-gfx] [PATCH v5] vga_switcheroo: Add helper for deferred probing

Skeggs <bske...@redhat.com> Cc: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Lukas Wunner <lu...@wunner.de> --- drivers/gpu/drm/i915/i915_drv.c | 10 +- drivers/gpu/drm/nouveau/nouveau_drm.c | 10 +- drivers/gpu/drm/radeon/radeon_drv.c | 10

Re: [Intel-gfx] [PATCH v2] drm/i915/fbdev: Limit the global async-domain synchronization

Hi Chris, On Thu, May 19, 2016 at 09:28:10AM +0100, Chris Wilson wrote: > During cleanup we have to synchronise with the async task we are using > to initialise and register our fbdev. Currently, we are using a full > synchronisation on the global domain, but we can restrict this to just >

[Intel-gfx] [PATCH v4] vga_switcheroo: Add helper for deferred probing

calling this helper. (Daniel Vetter) v4: Rebase on 412c8f7de011 ("drm/radeon: Return -EPROBE_DEFER when amdkfd not loaded") Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Ben Skeggs <bske...@redhat.com> Cc: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Luk

Re: [Intel-gfx] [PATCH] i915 suspend/resume_noirq instead of suspend_late/resume_early

Hi, On Wed, Apr 27, 2016 at 11:46:22AM -0700, Todd Brandt wrote: > I'd like to propose that we push the i915 suspend_late/resume_early code > into suspend_noirq/resume_noirq in order to reduce the total suspend time > by ~15ms. According to the comments, when i915_pm_suspend_late was first >

Re: [Intel-gfx] [PATCH 10/12] drm/i915: Disable use of stolen area by User when Intel RST is present

ad of structures (Lukas) > > Signed-off-by: Ankitprasad Sharma <ankitprasad.r.sha...@intel.com> > Cc: Lukas Wunner <lu...@wunner.de> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > --- > drivers/gpu/drm/i915/i915_drv.h| 11 +++ >

Re: [Intel-gfx] [PATCH v5 00/12] Enable GPU switching on pre-retina?MacBook Pro

Hi Bastien, On Tue, Apr 05, 2016 at 06:59:40PM +0200, Bastien Nocera wrote: > I tested the runtime patches for Radeon on top of 4.6.0-rc2, and > writing DIGD failed. I also saw a number of messages with the > vga_switcheroo core in the kernel trying to switch GPUs but failed > because "client 1"

Re: [Intel-gfx] [REGRESSION] system hang on ILK/SNB/IVB

Hi Tomi, On Thu, Mar 31, 2016 at 10:21:16AM +0300, Tomi Sarvela wrote: > The problem with the results in your link is that there is no HSW, ILK, IVB > or SNB results. This might give the impression that everything is well. > > Most damning is lack of HSW-gt2 and SNB-dellxps: those machines hang

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915: Protect fbdev across slow or failed initialisation

Hi Chris, On Thu, Mar 31, 2016 at 05:13:55PM +0100, Chris Wilson wrote: > On Thu, Mar 31, 2016 at 07:05:21PM +0300, Joonas Lahtinen wrote: > > On to, 2016-03-31 at 14:57 +0100, Chris Wilson wrote: > > >  void intel_fbdev_restore_mode(struct drm_device *dev) > > >  { > > > - int ret; > > > -

Re: [Intel-gfx] [REGRESSION] system hang on ILK/SNB/IVB

Hi Gabriel, On Thu, Mar 31, 2016 at 10:42:37AM +0300, Gabriel Feceoru wrote: > On 31.03.2016 00:35, Lukas Wunner wrote: > >On Wed, Mar 30, 2016 at 08:20:26PM +0300, Gabriel Feceoru wrote: > >>This commit causes a hang while running kms suspend tests > >>(kms_pipe_crc_

[Intel-gfx] [PATCH] drm/i915: Avoid unnecessary full synchronize for fbdev

This should make the code less fragile by synchronizing only up to the relevant cookie. Otherwise we risk deadlocks particularly during suspend and resume. Signed-off-by: Lukas Wunner <lu...@wunner.de> --- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_fbdev.

Re: [Intel-gfx] [REGRESSION] system hang on ILK/SNB/IVB

on older HW. > > > commit a7442b93cf32c1e1ddb721a26cd1f92302e2a222 > Author: Lukas Wunner <lu...@wunner.de> > Date: Wed Mar 9 12:52:53 2016 +0100 > > drm/i915: Fix races on fbdev > > The ->lastclose callback invokes intel_fbdev_restore_m

Re: [Intel-gfx] [PATCH v5 00/12] Enable GPU switching on pre-retina?MacBook Pro

Hi Alex, On Tue, Mar 15, 2016 at 02:33:56PM -0400, Alex Deucher wrote: > On Tue, Mar 15, 2016 at 1:54 PM, Lukas Wunner <lu...@wunner.de> wrote: > > On Sat, Mar 05, 2016 at 01:10:56PM -0500, Alex Deucher wrote: > >> Is there any reason to make use of the mux? > >

Re: [Intel-gfx] [PATCH v5 00/12] Enable GPU switching on pre-retina?MacBook Pro

Hi Alex, On Sat, Mar 05, 2016 at 01:10:56PM -0500, Alex Deucher wrote: > Is there any reason to make use of the mux? Performance (lower latency => no need for framebuffer writes over PCIe), improved battery life (no need to use 2 GPUs simultaneously). Technically you can't just ignore that the

Re: [Intel-gfx] [PATCH v5 00/12] Enable GPU switching on pre-retina?MacBook Pro

Hi Bastien, sorry for the delay. On Sat, Mar 05, 2016 at 05:31:55PM +0100, Bastien Nocera wrote: > We could, on boot, force using the integrated GPU, turning off the > discrete GPU that we're not interested in. Yes, many people "solve" this by having grub write the requisite commands to gmux'

Re: [Intel-gfx] ??? Fi.CI.BAT: failure for drm/i915: Fix races on fbdev (rev2)

On Wed, Mar 09, 2016 at 12:06:24PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix races on fbdev (rev2) > URL : https://patchwork.freedesktop.org/series/4068/ > State : failure > > == Summary == > > Series 4068v2 drm/i915: Fix races on fbdev >

[Intel-gfx] [PATCH v2] drm/i915: Fix races on fbdev

gt; Reported-by: "Li, Weinan Z" <weinan.z...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: sta...@vger.kernel.org Signed-off-by: Lukas Wunner <lu...@wunner.de> --- drivers/gpu/drm/i915/i915_dma.c| 8 +++- drivers/gpu/drm/i915/intel_fbdev.c | 3 +++ 2 fil

Re: [Intel-gfx] [PATCH v5 00/12] Enable GPU switching on pre-retina?MacBook Pro

Hi Bastien, On Fri, Mar 04, 2016 at 04:12:27PM +, Bastien Nocera wrote: > Lukas Wunner wunner.de> writes: > > Enable GPU switching on the pre-retina MacBook Pro (2008 - 2013), v5. > > I've tested your patchset on a MacBookPro8,1, with an integrated Intel and > discr

Re: [Intel-gfx] [PATCH RESEND FOR CI] drm/i915: Fix races on fbdev

6/ Sorry, I give up. Best regards, Lukas On Thu, Mar 03, 2016 at 06:02:53PM +0100, Lukas Wunner wrote: > The ->lastclose callback invokes intel_fbdev_restore_mode() and has > been witnessed to run before intel_fbdev_initial_config_async() > has finished. > > We might likewise

[Intel-gfx] [PATCH RESEND FOR CI] drm/i915: Fix races on fbdev

ous thread to finish. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93580 Reported-by: Gustav Fägerlind <gustav.fagerl...@gmail.com> Reported-by: "Li, Weinan Z" <weinan.z...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: sta...@vger.kernel.org

Re: [Intel-gfx] [PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

Hi, On Thu, Feb 18, 2016 at 10:39:05PM +0100, Daniel Vetter wrote: > On Thu, Feb 18, 2016 at 9:34 PM, Lukas Wunner <lu...@wunner.de> wrote: > > > >> Ok, makes sense. I still think adding the check to the client_register > >> function would be good, just as a saf

Re: [Intel-gfx] [PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

Hi, On Tue, Feb 16, 2016 at 05:08:40PM +0100, Daniel Vetter wrote: > On Tue, Feb 16, 2016 at 04:58:20PM +0100, Lukas Wunner wrote: > > On Sun, Feb 14, 2016 at 01:46:28PM +0100, Daniel Vetter wrote: > > > On Sun, Feb 14, 2016 at 1:10 PM, Lukas Wunner <lu...@wunner.de>

Re: [Intel-gfx] [PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

Hi, On Sun, Feb 14, 2016 at 01:46:28PM +0100, Daniel Vetter wrote: > On Sun, Feb 14, 2016 at 1:10 PM, Lukas Wunner <lu...@wunner.de> wrote: > > /** > > + * vga_switcheroo_client_probe_defer() - whether to defer probing a given > > GPU > > + * @pdev: pci device

[Intel-gfx] [PATCH 0/1] drm/i915: Fix races on fbdev [RESEND FOR CI]

efore the fbdev is fully > initialized.) > > To make it bullet proof we could declare a completion in intel_fbdev.c > and wait for that instead. Opinions? Lukas Wunner (1): drm/i915: Fix races on fbdev drivers/gpu/drm/i915/i915_dma.c| 8 +++- drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH 1/1] drm/i915: Fix races on fbdev

ous thread to finish. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93580 Reported-by: Gustav Fägerlind <gustav.fagerl...@gmail.com> Reported-by: "Li, Weinan Z" <weinan.z...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: sta...@vger.kernel.org

Re: [Intel-gfx] [PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

Hi, On Tue, Feb 09, 2016 at 10:04:01AM +0100, Daniel Vetter wrote: > On Mon, Jan 11, 2016 at 08:09:20PM +0100, Lukas Wunner wrote: [...] > > @@ -967,6 +970,15 @@ static int i915_pci_probe(struct pci_dev *pdev, const > > struct pci_device_id *ent) > > if

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Disable use of stolen area by User when Intel RST is present

Hi Ankitprasad, On Thu, Feb 04, 2016 at 05:43:17PM +0100, Lukas Wunner wrote: > On Thu, Feb 04, 2016 at 04:05:04PM +, Chris Wilson wrote: > > We could #define INTEL_RAPID_START "INT3392" for > > if (IS_ENABLED(CONFIG_SUSPEND) && acpi_dev_present(INTEL_RAPID_ST

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

[cc += Rafael J. Wysocki, linux-acpi] Hi Stephen, On Wed, Feb 10, 2016 at 12:24:51PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > In file included from

  1   2   3   >