Re: [PATCH 07/11] drm/gma500: Use fbdev client helpers

On Tue, May 7, 2024 at 2:04 PM Thomas Zimmermann wrote: > > Implement struct drm_client_funcs with the respective helpers and > remove the custom code from the emulation. The generic helpers are > equivalent in functionality. > > Signed-off-by: Thomas Zimmermann Acked-by

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

On Thu, Apr 6, 2023 at 9:32 AM Daniel Vetter wrote: > > On Wed, 5 Apr 2023 at 19:46, Patrik Jakobsson > wrote: > > > > On Wed, Apr 5, 2023 at 7:15 PM Daniel Vetter wrote: > > > > > > On Wed, 5 Apr 2023 at 18:54, Javier Martinez Canillas > > &g

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

On Wed, Apr 5, 2023 at 7:15 PM Daniel Vetter wrote: > > On Wed, 5 Apr 2023 at 18:54, Javier Martinez Canillas > wrote: > > > > Daniel Vetter writes: > > > > > On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote: > > > > [...] > > > > >> > > >/* > > >> > > > *

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

ngle these special cases won't work. > > > > It's not pretty, but the simplest fix (since gma500 really is the only > > quirky pci driver like this we have) is to just have both calls. > > > > Signed-off-by: Daniel Vetter > > Cc: Patrik Jakobsson > > Cc: T

Re: [Intel-gfx] [PATCH 07/22] drm/gma500: Use drm_mode_copy()

> - memcpy(mode, E, S) > + drm_mode_copy(mode, E) > ) > > @depends on !is_mode_copy@ > struct drm_display_mode mode; > expression E; > @@ > ( > - mode = E > + drm_mode_copy(, ) > | > - memcpy(, E, S) > + drm_mode_copy(, E) > ) > > @@ &

Re: [Intel-gfx] linux-next: manual merge of the drivers-x86 tree with the drm-misc tree

On Fri, Feb 5, 2021 at 12:07 PM Andy Shevchenko wrote: > > On Thu, Feb 4, 2021 at 11:04 AM Andy Shevchenko > wrote: > >> Today's linux-next merge of the drivers-x86 tree got a conflict in: > > > > Thanks. I already asked Patrik yesterday day if DRM missed to pull an > > immutable tag I

Re: [Intel-gfx] [PATCH v1 1/2] drm/gma500: Convert to use new SCU IPC API

On Fri, Jan 22, 2021 at 3:51 PM Andy Shevchenko wrote: > > On Fri, Jan 22, 2021 at 03:16:55PM +0100, Patrik Jakobsson wrote: > > On Fri, Jan 22, 2021 at 12:39 PM Andy Shevchenko > > wrote: > > > > > > Convert the GMA500 driver to use the new SCU IPC

Re: [Intel-gfx] [PATCH v1 1/2] drm/gma500: Convert to use new SCU IPC API

Linus Walleij Both patches look good. Do you want me to take them through drm-misc? Otherwise: Acked-by: Patrik Jakobsson ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v3 06/22] drm/gma500: Convert to CRTC VBLANK callbacks

On Mon, Jan 20, 2020 at 9:23 AM Thomas Zimmermann wrote: > > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Convert gma500 over. > > Signed-off-by: Thomas Zimmermann Looks good. For this patch: Acked-by: P

Re: [Intel-gfx] [PATCH v3 0/5] drm/gma500: drop use of drmP.h

On Sat, May 25, 2019 at 10:43 PM Sam Ravnborg wrote: > > Just a quick (final) probe. If there are no further feedback I will > commit this set sunday. > Added intel-gfx@lists.freedesktop.org just to get a bit more coverage. Hi Sam v2 of this series is already applied to drm-misc-next Thanks

Re: [Intel-gfx] [PATCH 3/3] gpu: drm: drivers: Convert printk(KERN_ to pr_

On Tue, Feb 28, 2017 at 1:55 PM, Joe Perches <j...@perches.com> wrote: > Use a more common logging style. > > Miscellanea: > > o Coalesce formats and realign arguments > o Neaten a few macros now using pr_ > > Signed-off-by: Joe Perches <j...@perches.com> For t

Re: [Intel-gfx] [PATCH 07/15] drm/gma500: Nuke device_is_agp callback

On Wed, Jan 25, 2017 at 7:26 AM, Daniel Vetter <daniel.vet...@ffwll.ch> wrote: > Returning 0 for an on-chip gpu doesn't change anything at all. > > Cc: Patrik Jakobsson <patrik.r.jakobs...@gmail.com> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com&g

Re: [Intel-gfx] [RFC PATCH] drm: define drm_compat_ioctl NULL on CONFIG_COMPAT=n and reduce #ifdefs

On Tue, Nov 1, 2016 at 4:40 PM, Jani Nikula <jani.nik...@intel.com> wrote: > If we define drm_compat_ioctl NULL on CONFIG_COMPAT=n, we don't have to > check for the config everywhere. > > Signed-off-by: Jani Nikula <jani.nik...@intel.com> Looks good and I like the id

Re: [Intel-gfx] [PATCH v4 2/5] drm: Add private data field to trace control block

On Jul 20, 2016 4:50 PM, "Dmitry V. Levin" <l...@altlinux.org> wrote: > > On Mon, Sep 07, 2015 at 08:23:57PM +0200, Patrik Jakobsson wrote: > > On Mon, Sep 7, 2015 at 6:51 PM, Dmitry V. Levin wrote: > > > On Mon, Aug 31, 2015 at 02:37:07PM +0200, Patrik Jakob

Re: [Intel-gfx] [PATCH v2] drm/i915/dmc: Step away from symbolic links

d then merge this one or >> > we >> > release the 1.07 before. >> 1.06 is already blacklisted, it has known problems. > > Oh! So I agree with the first statement. Let's merge this patch ;) That was new info for me as well. I don't

Re: [Intel-gfx] [PATCH v2] drm/i915/dmc: Step away from symbolic links

On Wed, Jun 15, 2016 at 12:11:55AM +, Vivi, Rodrigo wrote: > On Mon, 2016-05-23 at 10:57 +0200, Patrik Jakobsson wrote: > > On Wed, May 18, 2016 at 01:24:12PM +0300, Mika Kuoppala wrote: > > > Patrik Jakobsson <patrik.jakobs...@linux.intel.com> writes: >

Re: [Intel-gfx] [PATCH v2] drm/core: Change declaration for gamma_set.

; Acked-by: Alex Deucher <alexander.deuc...@amd.com> > Cc: Christian König <christian.koe...@amd.com> > Cc: David Airlie <airl...@linux.ie> > Cc: Patrik Jakobsson <patrik.r.jakobs...@gmail.com> > Cc: Ben Skeggs <bske...@redhat.com> > Cc: Eric Anholt <e

Re: [Intel-gfx] [PATCH v2] drm/i915/dmc: Step away from symbolic links

On Wed, May 18, 2016 at 01:24:12PM +0300, Mika Kuoppala wrote: > Patrik Jakobsson <patrik.jakobs...@linux.intel.com> writes: > > > [ text/plain ] > > Load specific firmware versions for the DMC instead of using symbolic > > links. The currently recommended ve

Re: [Intel-gfx] [PATCH v2 00/21] Rework page flip, remove cs flips, async unpin and unified pageflip.

On Tue, May 17, 2016 at 03:07:43PM +0200, Maarten Lankhorst wrote: > Connector lifetime patches forced a rethinking for handling connectors. > Instead of flushing modesets from the connector destroy function this > meant destroying the connector state inside the unpin_work function, > similar to

Re: [Intel-gfx] [PATCH v2 21/21] drm/i915: Allow async update of pageflips.

On Tue, May 17, 2016 at 03:08:04PM +0200, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> We could have had a short note on what the patch does, though reading it is quite straight forward. Either way is fine by me. Reviewed-by: Patrik

Re: [Intel-gfx] [PATCH v2 18/21] drm/i915: Make unpin async.

<maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_atomic.c | 11 ++ > drivers/gpu/drm/i915/intel_display.c | 344 > ++- > drivers/gpu/drm/i915/intel_

Re: [Intel-gfx] [PATCH v2 17/21] drm/i915: Prepare connectors for nonblocking checks.

fy. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_display.c | 53 > ++-- > drivers/gpu/drm/i915/in

Re: [Intel-gfx] [PATCH v2 11/21] drm/i915: Rework intel_crtc_page_flip to be almost atomic, v3.

think this is good enough. Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_debugfs.c | 36 +- > drivers/gpu/drm/i915/intel_display.c | 672 > +-- > drivers/gpu/drm/i915/intel_drv.h | 1

Re: [Intel-gfx] [PATCH v2 20/21] drm/i915: Check for unpin correctness.

is destroyed, so to find > this add some checks when it happens. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_display.c | 9 + >

Re: [Intel-gfx] [PATCH v2 19/21] Reapply "drm/i915: Avoid stalling on pending flips for legacy cursor updates"

On Tue, May 17, 2016 at 03:08:02PM +0200, Maarten Lankhorst wrote: > This reapplies commit acf4e84d6167317ff21be5c03e1ea76ea5783701. > With async unpin this should no longer break. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by

Re: [Intel-gfx] [PATCH v2 16/21] drm/i915: Pass atomic states to fbc update functions.

arten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_display.c | 8 +--- > drivers/gpu/drm/i915/intel_drv.h | 8 ++-- > drivers/gpu/drm/i915/intel_fbc.c | 39 >

Re: [Intel-gfx] [PATCH v2 15/21] drm/i915: Remove reset_counter from intel_crtc.

..@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_display.c | 9 - > drivers/gpu/drm/i915/intel_drv.h | 3 --- > 2 files changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH v2 14/21] drm/i915: Remove queue_flip pointer.

On Tue, May 17, 2016 at 03:07:57PM +0200, Maarten Lankhorst wrote: > With the removal of cs support this is no longer reachable. > Can be revived if needed. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jako

Re: [Intel-gfx] [PATCH v2 13/21] drm/i915: Remove use_mmio_flip kernel parameter.

On Tue, May 17, 2016 at 03:07:56PM +0200, Maarten Lankhorst wrote: > With the removal of cs flips this is always force enabled. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > ---

Re: [Intel-gfx] [PATCH v2 12/21] drm/i915: Remove cs based page flip support.

On Tue, May 17, 2016 at 03:07:55PM +0200, Maarten Lankhorst wrote: > With mmio flips now available on all platforms it's time to remove > support for cs flips. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jako

Re: [Intel-gfx] [PATCH v2 10/21] drm/i915: Add the exclusive fence to plane_state.

st <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_atomic_plane.c | 1 + > drivers/gpu/drm/i915/intel_display.c | 54 > +++ > 2 files changed, 42 insertions(+),

Re: [Intel-gfx] [PATCH v2 09/21] drm/i915: Convert flip_work to a list.

On Tue, May 17, 2016 at 03:07:52PM +0200, Maarten Lankhorst wrote: > This will be required to allow more than 1 update in the future. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>

Re: [Intel-gfx] [PATCH v2 08/21] drm/i915: Allow mmio updates on all platforms, v2.

_plane can be called with a freed > crtc_state. Because of this commit acf4e84d61673 > ("drm/i915: Avoid stalling on pending flips for legacy cursor updates") > is temporarily reverted. > > Changes since v1: > - Split out the flip_work rename. > > Signed-off-by: Maarten

Re: [Intel-gfx] [PATCH v2 07/21] Revert "drm/i915: Avoid stalling on pending flips for legacy cursor updates"

arten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_display.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b

Re: [Intel-gfx] [PATCH v2 06/21] drm/i915: Unify unpin_work and mmio_work into flip_work, v2.

t; Much nicer with the cs / mmio split. Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_debugfs.c | 6 +- > drivers/gpu/drm/i915/i915_irq.c | 20 ++- > drivers/gpu/drm/i915/intel_display.c | 282 > +++--

Re: [Intel-gfx] [PATCH v2 05/21] drm/i915: Add support for detecting vblanks when hw frame counter is unavailable.

On Tue, May 17, 2016 at 03:07:48PM +0200, Maarten Lankhorst wrote: > This uses the newly created drm_accurate_vblank_count_and_time to accurately > get a vblank count when the hw counter is unavailable. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> R

Re: [Intel-gfx] [PATCH v2 04/21] drm/i915: Remove intel_prepare_page_flip, v3.

ending is turned into a bool. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_debugfs.c | 5 +-- > drivers/gpu/drm/i915/i91

Re: [Intel-gfx] [PATCH v2 03/21] drm/i915: Remove intel_finish_page_flip_plane.

tel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_irq.c | 6 +++--- > drivers/gpu/drm/i915/intel_display.c | 18 -- > drivers/gpu/drm/i915/intel_drv.h | 1 - > 3 files changed, 7 insertions(+), 18

Re: [Intel-gfx] [PATCH v2 02/21] drm/i915: Remove stallcheck special handling, v3.

ad() needs a full smp_rmb. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_debugfs.c | 11 +++--- > drivers/gpu/drm/i915/intel_display.c | 71 >

[Intel-gfx] [PATCH v2] drm/i915/dmc: Step away from symbolic links

to provide a tested and known working configuration we must lock down on a specific DMC firmware version. Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Imre Deak <imre.d...@intel.com> Cc: Mika Kuoppala <mika.kuopp...@linux.intel.com> Signed-off-by: Patrik Jakobsson <patrik.jako

Re: [Intel-gfx] [PATCH 15/19] drm/i915: Prepare MST connector removal for async unpin.

On Tue, Apr 19, 2016 at 09:52:35AM +0200, Maarten Lankhorst wrote: > check_connector_state might get called from unpin_work, which means verify_connector_state and not check_connector_state? Otherwise looks good Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> >

Re: [Intel-gfx] [PATCH 14/19] drm/i915: Pass atomic states to fbc update functions.

arten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_display.c | 8 +--- > drivers/gpu/drm/i915/intel_drv.h | 8 ++-- > drivers/gpu/drm/i915/intel_fbc.c | 39 >

Re: [Intel-gfx] [PATCH 13/19] drm/i915: Remove queue_flip pointer.

On Tue, Apr 19, 2016 at 09:52:33AM +0200, Maarten Lankhorst wrote: > With the removal of cs support this is no longer reachable. > Can be revived if needed. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jako

Re: [Intel-gfx] [PATCH 12/19] drm/i915: Remove use_mmio_flip kernel parameter.

On Tue, Apr 19, 2016 at 09:52:32AM +0200, Maarten Lankhorst wrote: > With the removal of cs flips this is always force enabled. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > ---

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Step away from symbolic links

On Tue, May 10, 2016 at 03:52:02PM +0300, Mika Kuoppala wrote: > Patrik Jakobsson <patrik.jakobs...@linux.intel.com> writes: > > > [ text/plain ] > > Load specific firmware versions for the DMC instead of using symbolic > > links. The currently recommended ve

Re: [Intel-gfx] [PATCH 06/19] Revert "drm/i915: Avoid stalling on pending flips for legacy cursor updates"

arten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_display.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b

Re: [Intel-gfx] [PATCH 04/19] drm/i915: Add support for detecting vblanks when hw frame counter is unavailable.

On Wed, Apr 27, 2016 at 05:23:06PM +0300, Ville Syrjälä wrote: > On Wed, Apr 27, 2016 at 04:06:16PM +0200, Patrik Jakobsson wrote: > > On Tue, Apr 19, 2016 at 09:52:24AM +0200, Maarten Lankhorst wrote: > > > This uses the newly created drm_accurate_vblank_count_and_time to

[Intel-gfx] [PATCH] drm/i915/dmc: Step away from symbolic links

com> Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> --- drivers/gpu/drm/i915/intel_csr.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c index 2b3b428..ea04

Re: [Intel-gfx] [PATCH 02/19] drm/i915: Remove stallcheck special handling, v2.

On Thu, Apr 28, 2016 at 12:20:09PM +0200, Maarten Lankhorst wrote: > Op 28-04-16 om 11:54 schreef Patrik Jakobsson: > > On Thu, Apr 28, 2016 at 10:48:55AM +0200, Maarten Lankhorst wrote: > >> Op 27-04-16 om 15:24 schreef Patrik Jakobsson: > >>> On Tue, Apr 19, 201

Re: [Intel-gfx] [PATCH 09/19] drm/i915: Add the exclusive fence to plane_state.

st <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_atomic_plane.c | 1 + > drivers/gpu/drm/i915/intel_display.c | 54 > +++ > 2 files changed, 42 insertions(+),

Re: [Intel-gfx] [PATCH 08/19] drm/i915: Convert flip_work to a list.

On Tue, Apr 19, 2016 at 09:52:28AM +0200, Maarten Lankhorst wrote: > This will be required to allow more than 1 update in the future. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/i915_debugfs.c | 90 +- >

Re: [Intel-gfx] [PATCH 05/19] drm/i915: Unify unpin_work and mmio_work into flip_work.

> Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_debugfs.c | 6 +- > drivers/gpu/drm/i915/intel_display.c | 189 > +++-

Re: [Intel-gfx] [PATCH 02/19] drm/i915: Remove stallcheck special handling, v2.

On Thu, Apr 28, 2016 at 10:48:55AM +0200, Maarten Lankhorst wrote: > Op 27-04-16 om 15:24 schreef Patrik Jakobsson: > > On Tue, Apr 19, 2016 at 09:52:22AM +0200, Maarten Lankhorst wrote: > >> Both intel_unpin_work.pending and intel_unpin_work.enable_stall_check > >> were

Re: [Intel-gfx] [PATCH 04/19] drm/i915: Add support for detecting vblanks when hw frame counter is unavailable.

On Tue, Apr 19, 2016 at 09:52:24AM +0200, Maarten Lankhorst wrote: > This uses the newly created drm_accurate_vblank_count_and_time to accurately > get a vblank count when the hw counter is unavailable. > --- > drivers/gpu/drm/i915/intel_display.c | 10 ++ >

Re: [Intel-gfx] [PATCH 02/19] drm/i915: Remove stallcheck special handling, v2.

On Tue, Apr 19, 2016 at 09:52:22AM +0200, Maarten Lankhorst wrote: > Both intel_unpin_work.pending and intel_unpin_work.enable_stall_check > were used to see if work should be enabled. By only using pending > some special cases are gone, and access to unpin_work can be simplified. > > Use this to

Re: [Intel-gfx] [PATCH] drm/i915/kbl: Introduce the first official DMC for Kabylake.

; required change. > v3: With right CSR_VERSION (Patrik). > > Cc: Christophe Prigent <christophe.prig...@intel.com> > Cc: Patrik Jakobsson <patrik.r.jakobs...@gmail.com> > Reviewed-by: Ben Widawsky <benjamin.widaw...@intel.com> (v1) > Signed-off-by: Rodrigo Vivi &

Re: [Intel-gfx] [PATCH] drm/i915/kbl: Introduce the first official DMC for Kabylake.

required change. > > Cc: Christophe Prigent <christophe.prig...@intel.com> > Cc: Patrik Jakobsson <patrik.r.jakobs...@gmail.com> > Reviewed-by: Ben Widawsky <benjamin.widaw...@intel.com> (v1) > Signed-off-by: Rodrigo Vivi <rodrigo

Re: [Intel-gfx] [PATCH 03/19] drm/i915: Remove intel_prepare_page_flip, v2.

On Tue, Apr 19, 2016 at 09:52:23AM +0200, Maarten Lankhorst wrote: > Instead of calling prepare_flip right before calling finish_page_flip > do everything from prepare_page_flip in finish_page_flip. > > Putting prepare and finish page_flip in a single step removes the need > for

Re: [Intel-gfx] [PATCH] drm/i915: Make RPS EI/thresholds multiple of 25 on SNB

Do we need to test for performance regressions on stuff like this? And if so, who do we ping about this? OTOH impact should be really small and since this fixes a real problem: Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > > These are the original EI/thresholds: >

Re: [Intel-gfx] [PATCH] drm/i915/kbl: Don't WARN for expected secondary MISC IO power well request

DMC is > "expected". Tune down the corresponding WARN to be a debug message. This > was caught by CI suspend tests. > > CC: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > Signed-off-by: Imre Deak <imre.d...@intel.com> Was just about to bug you about t

Re: [Intel-gfx] [PATCH] drm/i915/kbl: Reset secondary power well requests left on by DMC/KVMR

and MISC IO > power well disabling in the latest CI run. > > CC: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > Signed-off-by: Imre Deak <imre.d...@intel.com> Ok, so this seems to affect all DMC firmwares we have so far? Any news on the bug report? R

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Make sure LP1+ watermarks levels are preserved when going from 1 to 2 pipes

t; Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93787 > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_pm.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Replace ILK eDP underrun suppression with something better

> wait on the pipe driving FDI just prior to enabling the eDP PLL. > > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > driver

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Try to shut up more ILK underruns

ns when enabling PCH ports > > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> > Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> (v1) I've not been able to find any additional ILK hardware to test this on but

Re: [Intel-gfx] [PATCH v2 04/16] drm/i915/gen9: Reset secondary power well requests left on by DMC/KVMR

est bits in here either, so > sanitize this register as well. > > v2: > - apply the workaround on SKL as well > > CC: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > Signed-off-by: Imre Deak <imre.d...@intel.com> Hmm, more DMC fun. Reviewed-by: Patrik Jakobs

Re: [Intel-gfx] [PATCH 14/16] drm/i915/gen9: Calculate watermarks during atomic 'check'

On Thu, Mar 31, 2016 at 06:46:36PM -0700, Matt Roper wrote: > Moving watermark calculation into the check phase will allow us to to > reject display configurations for which there are no valid watermark > values before we start trying to program the hardware (although those > tests will come in a

Re: [Intel-gfx] [PATCH 05/16] drm/i915/gen9: Make power well disabling synchronous

On Mon, Apr 04, 2016 at 12:34:30PM +0200, Patrik Jakobsson wrote: > On Fri, Apr 01, 2016 at 04:02:36PM +0300, Imre Deak wrote: > > So far we only power well enabling was synchronous not disabling. Since > > we don't exactly know how the firmware (both DMC and PCU) synchroni

Re: [Intel-gfx] [PATCH v2 08/16] drm/i915/skl: Unexport skl_pw1_misc_io_init

nable vs. disable power well call in > skl_display_core_uninit() (Patrik) > > CC: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > Signed-off-by: Imre Deak <imre.d...@intel.com> > --- > drivers/gpu/drm/i915/intel_drv.h| 2 -- > drivers/gpu/drm/i915/intel_runtime_pm.

Re: [Intel-gfx] [PATCH 08/16] drm/i915/skl: Unexport skl_pw1_misc_io_init

On Fri, Apr 01, 2016 at 04:02:39PM +0300, Imre Deak wrote: > On Broxton we need to enable/disable power well 1 during the init/unit display > sequence similarly to Skylake/Kabylake. The code for this will be added in a > follow-up patch, but to prepare for that unexport skl_pw1_misc_io_init().

Re: [Intel-gfx] [PATCH 07/16] drm/i915/bxt: Suspend power domains during suspend-to-idle

a manual DC9 flow. For this we have to uninitialize the > display following the BSpec display uninit sequence, just as during > S3/S4, so make sure we follow this sequence. > > CC: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > Signed-off-by: Imre Deak <imre.d...@intel

Re: [Intel-gfx] [PATCH 06/16] drm/i915/gen9: Fix DMC/DC state asserts

_can_enable_dc5() is incorrect. There is a more generic and > correct assert for this already in gen9_set_dc_state(), so we can remove > all the other ones. > > At the same time convert WARNs to WARN_ONCE for consistency with the > other DC state asserts. > > CC: Patrik Jakobsson <pat

Re: [Intel-gfx] [PATCH 05/16] drm/i915/gen9: Make power well disabling synchronous

sabling also synchronous. > > CC: Mika Kuoppala <mika.kuopp...@linux.intel.com> > CC: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > Signed-off-by: Imre Deak <imre.d...@intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> >

[Intel-gfx] [PATCH] drm/i915/skl: Remove unused skl_disable_dc6 function

Left behind by DC state rework and is no longer needed. Cc: Imre Deak <imre.d...@intel.com> Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> --- drivers/gpu/drm/i915/intel_drv.h| 1 - drivers/gpu/drm/i915/intel_runtime_pm.c | 7 --- 2 files changed,

Re: [Intel-gfx] [PATCH igt] igt/pm_rpm: Wait for PCI D3

t;, __func__, val & 0x3); > return (val & 0x3) == 0x3; > } > > @@ -1354,11 +1352,9 @@ static void pci_d3_state_subtest(void) > igt_require(has_runtime_pm); > > disable_all_screens_and_wait(_data); > - > - igt_assert(device_in_pci_d3()); > + igt_asse

Re: [Intel-gfx] Fwd: [PATCH] drm/i915: Avoid vblank counter for gen9+

On Wed, Mar 02, 2016 at 07:13:07PM +0200, Imre Deak wrote: > On Fri, 2016-02-26 at 10:02 -0800, Rodrigo Vivi wrote: > > [...] > > Well, I have this tree: > > https://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=rpm-domains-psr-vblank-counter-full > > with mainly: > > 1 - vblank domain on

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/gen9: Disable DC states if power well support is disabled

power wells regardless of the disable_power_well option. > > CC: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > Signed-off-by: Imre Deak <imre.d...@intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/in

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/gen9: Sanitize handling of allowed DC states

he > i915.disable_power_well module option, added in the next patch. > > v2: > - Print a debug message if the requested max DC value was adjusted due > to a platform limit. Also debug print the calculated mask value. (Patrik) > > CC: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>

Re: [Intel-gfx] [PATCH 4/4] drm/i915/gen9: Remove state asserts when disabling DC states

_well option. > > CC: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > Signed-off-by: Imre Deak <imre.d...@intel.com> Nice to see these go. Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_runtime_pm.c |

Re: [Intel-gfx] [PATCH 3/4] drm/i915/gen9: Disable DC states if power well support is disabled

power wells regardless of the disable_power_well option. > > CC: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > Signed-off-by: Imre Deak <imre.d...@intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/in

Re: [Intel-gfx] [PATCH 2/4] drm/i915/gen9: Sanitize handling of allowed DC states

he > i915.disable_power_well module option, added in the next patch. > > CC: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > Signed-off-by: Imre Deak <imre.d...@intel.com> > --- > drivers/gpu/drm/i915/i915_drv.h | 1 + > drivers/gpu/drm/i915/intel_runtime_pm.c | 74

Re: [Intel-gfx] [PATCH 1/4] drm/i915/skl: Fix power domain suspend sequence

m/i915: fix handling of the disable_power_well module > option") > CC: sta...@vger.kernel.org > CC: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > Signed-off-by: Imre Deak <imre.d...@intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Check for DC state mismatch

On Thu, Feb 18, 2016 at 11:22 AM, Patrik Jakobsson <patrik.jakobs...@linux.intel.com> wrote: > On Thu, Feb 18, 2016 at 12:16:40AM +, Vivi, Rodrigo wrote: >> I was going to merge here but I saw on patchwork we got some warnings >> so I'm not sure they are only false positiv

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Check for DC state mismatch

:43 +0200, Mika Kuoppala wrote: > > Patrik Jakobsson <patrik.jakobs...@linux.intel.com> writes: > > > > > The DMC can incorrectly run off and allow DC states on it's own. We > > > don't know the root-cause for this yet but this patch makes it more > >

[Intel-gfx] [PATCH] drm/i915/gen9: Check for DC state mismatch

The DMC can incorrectly run off and allow DC states on it's own. We don't know the root-cause for this yet but this patch makes it more visible. Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel

Re: [Intel-gfx] [PATCH v4] drm/i915: Handle PipeC fused off on IVB/HSW/BDW

l Feceoru <gabriel.fece...@intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_dma.c | 3 +++ > drivers/gpu/drm/i915/i915_reg.h | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i91

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Probe power well 1 status on dc status query

> > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=93768 > > Suggested-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > > Cc: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> > > Cc: Imre Deak <imre.d...@intel.com> > &

[Intel-gfx] [PATCH v3] drm/i915/skl/kbl: Add support for pipe fusing

RAP register for pipe c disabled Cc: Damien Lespiau <damien.lesp...@intel.com> Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> --- drivers/gpu/drm/i915/i915_dma.c | 31 +++ drivers/gpu/drm/i915/i915_reg.h | 3 +++ 2 files changed, 34 inse

Re: [Intel-gfx] [PATCH v3] drm/i915: Handle PipeC fused off on IVB/HSW/BDW

On Wed, Jan 13, 2016 at 06:02:52PM +0200, Gabriel Feceoru wrote: > Some Gen7/8 production parts may have the Display Pipe C fused off. > In this case, the display hardware will prevent the Pipe C register bit > from being set to 1. Please elaborate on what pipe c register bit is prevented from

Re: [Intel-gfx] [PATCH] drm/i915/skl/kbl: Add support for pipe fusing

On Mon, Jan 18, 2016 at 06:01:27PM +0200, Ville Syrjälä wrote: > On Mon, Jan 18, 2016 at 03:11:57PM +0100, Patrik Jakobsson wrote: > > On SKL and KBL we can have pipe A/B/C disabled by fuse settings. The > > pipes must be fused in descending order (e.g. C, B+C, A+B+C). There

[Intel-gfx] [PATCH v2] drm/i915/skl/kbl: Add support for pipe fusing

On SKL and KBL we can have pipe A/B/C disabled by fuse settings. The pipes must be fused in descending order (e.g. C, B+C, A+B+C). We simply decrease info->num_pipes if we find a valid fused out config. v2: Don't store the pipe disabled mask in device info (Damien) Signed-off-by: Pat

[Intel-gfx] [PATCH] drm/i915/skl/kbl: Add support for pipe fusing

come in handy if the rule about the descending order is changed on future platforms. Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> --- drivers/gpu/drm/i915/i915_dma.c | 34 ++ drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/dr

[Intel-gfx] [PATCH] drm/i915/skl: Tune down DC6 already enabled warning

message to not clutter our CI results. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=93697 Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> --- drivers/gpu/drm/i915/intel_runtime_pm.c | 6 -- 1 file changed, 4 inse

Re: [Intel-gfx] [PATCH] drm/i915/skl/kbl: Add support for pipe fusing

On Mon, Jan 18, 2016 at 06:01:27PM +0200, Ville Syrjälä wrote: > On Mon, Jan 18, 2016 at 03:11:57PM +0100, Patrik Jakobsson wrote: > > On SKL and KBL we can have pipe A/B/C disabled by fuse settings. The > > pipes must be fused in descending order (e.g. C, B+C, A+B+C). There

Re: [Intel-gfx] [PATCH 08/22] drm/gma500: Remove empty preclose hook

On Mon, Jan 11, 2016 at 10:41 PM, Daniel Vetter <daniel.vet...@ffwll.ch> wrote: > I'm auditing them all, empty ones just confuse ... > > Cc: Patrik Jakobsson <patrik.r.jakobs...@gmail.com> > Acked-by: Daniel Stone <dani...@collabora.com> > Reviewed-by: Alex D

[Intel-gfx] [PATCH] drm/i915/skl: Use alternate aux power domain for port E

There is no dedicated aux channel for port E on SKL. Instead the VBT describes which of the other aux channels to use. When grabbing an aux power domain for port E we need to take this into account. Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Patrik Jakobsson <patr

Re: [Intel-gfx] [PATCH v4 2/5] drm: Add private data field to trace control block

On Tue, Nov 24, 2015 at 6:46 AM, Dmitry V. Levin <l...@altlinux.org> wrote: > On Mon, Sep 07, 2015 at 08:23:57PM +0200, Patrik Jakobsson wrote: >> On Mon, Sep 7, 2015 at 6:51 PM, Dmitry V. Levin wrote: >> > On Mon, Aug 31, 2015 at 02:37:07PM +0200, Patrik Jakobsson wrote:

Re: [Intel-gfx] [PATCH] drm/i915: Add some more bits to CURSOR_POS_MASK

On Wed, Nov 25, 2015 at 1:54 PM, Robert Fekete <robert.fek...@linux.intel.com> wrote: > On ons, 2015-11-18 at 10:17 +0100, Daniel Vetter wrote: >> On Wed, Nov 04, 2015 at 10:59:28AM +0100, Patrik Jakobsson wrote: >> > On Wed, Nov 04, 2015 at 10:35:19AM +0100, Robert Feke

Re: [Intel-gfx] [PATCH] drm/i915/skl: enable PC9/10 power states during suspend-to-idle

On Thu, Nov 19, 2015 at 04:06:47PM +0200, Imre Deak wrote: > On to, 2015-11-19 at 14:34 +0100, Patrik Jakobsson wrote: > > On Wed, Nov 18, 2015 at 06:44:43PM +0200, Imre Deak wrote: > > > On ke, 2015-11-18 at 17:33 +0100, Daniel Vetter wrote: > > > > On Wed, Nov 18,

Re: [Intel-gfx] [PATCH] drm/i915/skl: re-enable power well support

On Wed, Nov 18, 2015 at 07:53:50PM +0200, Imre Deak wrote: > Now that the known DMC/DC issues are fixed, let's try again and > re-enable the power well support. > > Signed-off-by: Imre Deak <imre.d...@intel.com> Together with the PC9/10 fix this is: Reviewed-by: Patrik Jakobs

Re: [Intel-gfx] [PATCH] drm/i915/skl: enable PC9/10 power states during suspend-to-idle

On Wed, Nov 18, 2015 at 06:44:43PM +0200, Imre Deak wrote: > On ke, 2015-11-18 at 17:33 +0100, Daniel Vetter wrote: > > On Wed, Nov 18, 2015 at 05:32:30PM +0200, Imre Deak wrote: > > > During suspend-to-idle we need to keep the DMC firmware active and DC6 > > > enabled, since otherwise we won't

  1   2   3   >