Re: [Intel-gfx] [PATCH i-g-t 2/6] lib: Extract ssme common fb create+fill methods into helpers

2015-12-21 Thread Thomas Wood
On 18 December 2015 at 17:25, wrote: > From: Ville Syrjälä > > Several tests do one or more of the followin: > * igt_create_fb() + igt_paint_test_pattern() > * igt_create_color_fb() + igt_paint_test_pattern() > * igt_create_fb() +

Re: [Intel-gfx] [PATCH i-g-t 6/6] tests/kms_chv_cursor_fail: Add a test to exercise CHV pipe C cursor fail

2015-12-21 Thread Thomas Wood
On 18 December 2015 at 17:25, wrote: > From: Ville Syrjälä > > The test tries to anger CHV pipe C cursor by walking the edges of the > screen while moving the cursor across the screen edge. > > The actual hw issue only occurs on pipe

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_pm: Lib for power management

2015-12-18 Thread Thomas Wood
On 15 December 2015 at 09:14, David Weinehall wrote: > Move power management related code to a separate library. > Initially this is done only for workarounds that apply to external > components. Modify the users of such workarounds accordingly. > This currently

Re: [Intel-gfx] [PATCH i-g-t v2] tests: update .gitignore and add a Makefile rule to create it

2015-12-15 Thread Thomas Wood
9:07 AM >>To: Wood, Thomas >>Cc: intel-gfx@lists.freedesktop.org >>Subject: Re: [Intel-gfx] [PATCH i-g-t v2] tests: update .gitignore and add a >>Makefile rule to create it >> >>On Mon, Dec 07, 2015 at 03:12:15PM +, Thomas Wood wrote: >>> v2: generate t

[Intel-gfx] [PATCH i-g-t v2] tests: update .gitignore and add a Makefile rule to create it

2015-12-07 Thread Thomas Wood
v2: generate the .gitignore file with the default target Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/.gitignore | 13 +++-- tests/Makefile.am | 4 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/tests/.gitignore b/tests/.gitignore index 6

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib/kms: Turn the based_edid into a template

2015-12-07 Thread Thomas Wood
based_edid should be "base edid"? On 4 December 2015 at 14:08, wrote: > From: Ville Syrjälä > > Signed-off-by: Ville Syrjälä > --- > lib/Makefile.sources| 1 + > lib/igt_edid_template.h | 74

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/drm_lib.sh: Skip when i915 debugfs wasn't found

2015-12-03 Thread Thomas Wood
On 3 December 2015 at 10:46, Morton, Derek J <derek.j.mor...@intel.com> wrote: >> >> >>-Original Message- >>From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >>Thomas Wood >>Sent: Thursday, December 3, 2015 10:08 A

[Intel-gfx] [PATCH i-g-t] tests: update .gitignore and add a Makefile rule to create it

2015-12-03 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/.gitignore | 13 +++-- tests/Makefile.am | 4 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/tests/.gitignore b/tests/.gitignore index ba1becd..9dfc7f3 100644 --- a/tests/.gitignore +++ b/tests/.git

Re: [Intel-gfx] [PATCH i-g-t] tests: add exit value constants for shell script tests

2015-12-03 Thread Thomas Wood
On 3 December 2015 at 12:17, Morton, Derek J <derek.j.mor...@intel.com> wrote: > 1 comment / question inline, otherwise looks ok to me. > > //Derek > >> >> >>-Original Message- >>From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On

[Intel-gfx] [PATCH i-g-t] tests: add exit value constants for shell script tests

2015-12-03 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/check_drm_clients | 2 +- tests/debugfs_emon_crash | 2 +- tests/drm_lib.sh | 22 ++ tests/drv_debugfs_reader | 2 +- tests/drv_missed_irq_hang | 14 +++---

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/drm_lib.sh: Skip when i915 debugfs wasn't found

2015-12-03 Thread Thomas Wood
On 3 December 2015 at 06:45, Daniel Vetter wrote: > Instead of failing. We might want to move this into i915 tests > eventually, but this is good for now. > > Signed-off-by: Daniel Vetter > --- > tests/drm_lib.sh | 7 ++- > 1 file changed, 6

[Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.13

2015-12-02 Thread Thomas Wood
) - New test: core_setmaster_vs_auth checks that drop/setMaster correctly transfer master state (Thomas Hellstrom/Daniel Vetter) - Wildcard characters are now accepted when using the --run-subtest command line option to specify multiple subtests to run. (Thomas Wood) - Add support for Broxton

[Intel-gfx] [PATCH i-g-t 2/2] tests/core_setmaster_vs_auth: add test description macro

2015-12-02 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/core_setmaster_vs_auth.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/core_setmaster_vs_auth.c b/tests/core_setmaster_vs_auth.c index 44ec752..97add9c 100644 --- a/tests/core_setmaster_vs_auth.c +++ b

[Intel-gfx] [PATCH i-g-t 1/2] tests/core_setmaster_vs_auth: use igt_simple_main

2015-12-02 Thread Thomas Wood
This test has no subtests, so should use igt_simple_main. Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/core_setmaster_vs_auth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/core_setmaster_vs_auth.c b/tests/core_setmaster_vs_auth.c index e

[Intel-gfx] [PATCH i-g-t 1/3] lib: add missing documentation for drm open functions

2015-12-01 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- lib/drmtest.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index 16a3638..2896af0 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -225,11 +225,10 @@ int drm_get_car

[Intel-gfx] [PATCH i-g-t 2/3] lib: document intel_pipe_crc_source enum values

2015-12-01 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- lib/igt_debugfs.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/igt_debugfs.h b/lib/igt_debugfs.h index ee9ff40..3d5a811 100644 --- a/lib/igt_debugfs.h +++ b/lib/igt_debugfs.h @@ -77,6 +77,17 @@ typedef

[Intel-gfx] [PATCH i-g-t 3/3] docs: exclude gpgpu_fill.h

2015-12-01 Thread Thomas Wood
gpgpu_fill.h is only used internally by the library. Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- docs/reference/intel-gpu-tools/Makefile.am | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/reference/intel-gpu-tools/Makefile.am b/docs/reference/int

Re: [Intel-gfx] [PATCH i-g-t 1/3] tests/kms_force_connector: Fixes

2015-12-01 Thread Thomas Wood
On 1 December 2015 at 08:08, Daniel Vetter wrote: > Two things: > - Somehow the kernel's mode list changed with our EDID. No idea > whether that's the right thing here since I'm not really an EDID > expert. But then again the testcase wants to check that the >

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests/kms_force_connector: Include in BAT set

2015-12-01 Thread Thomas Wood
On 1 December 2015 at 10:24, Daniel Vetter wrote: > Forcing connector state is a basic piece of our test infrastructure > that we use in all the kms_ tests. It allows us to run tests even if > no outputs are connected. > > They're also really fast, so perfect candidates

[Intel-gfx] [PATCH i-g-t] tests/gem_request_retire: add test description

2015-11-30 Thread Thomas Wood
Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com> Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/gem_request_retire.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/gem_request_retire.c b/tests/gem_request_retire.c index 0c7c45e..545a245 100644

Re: [Intel-gfx] [PATCH i-g-t] scripts: Add support to retest tests wich changed results

2015-11-27 Thread Thomas Wood
On 27 November 2015 at 12:40, Gabriel Feceoru wrote: > This script takes multiple test results and prints the diffs, useful > for detecting noise in subsequent executions. > It gives the option to re-run these tests. This feature might be useful in Piglit itself. It

Re: [Intel-gfx] [PATCH i-g-t] scripts: Add feature list file for piglit 'summary feature'

2015-11-26 Thread Thomas Wood
On 25 November 2015 at 12:12, Gabriel Feceoru wrote: > This is a placeholder for the feature list file. Its content is just > an example. It would be useful if the example applied directly to intel-gpu-tools tests. Perhaps just a single feature to start with? Since

Re: [Intel-gfx] [PATCH] tests/kms_color:Color IGT

2015-11-24 Thread Thomas Wood
Please make sure your patch is tagged with "i-g-t" so it is correctly identified by patchwork, as described in: http://lists.freedesktop.org/archives/intel-gfx/2015-November/079712.html It would also be helpful if the subject line briefly mentions what the patch does. On 20 November 2015 at

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-18 Thread Thomas Wood
On 18 November 2015 at 15:44, Daniel Vetter <dan...@ffwll.ch> wrote: > On Mon, Nov 16, 2015 at 03:22:23PM +0200, Joonas Lahtinen wrote: >> Cc: Thomas Wood <thomas.w...@intel.com> >> Cc: Chris Wilson <ch...@chris-wilson.co.uk> >> Cc: Damien Lespiau &

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-17 Thread Thomas Wood
On 16 November 2015 at 13:22, Joonas Lahtinen <joonas.lahti...@linux.intel.com> wrote: > Cc: Thomas Wood <thomas.w...@intel.com> > Cc: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Damien Lespiau <damien.lesp...@intel.com> > Signed-off-by: Joonas Lahti

Re: [Intel-gfx] [PATCH] igt/igt_kms: Introduce get_first_connected_output (v2)

2015-11-13 Thread Thomas Wood
-November/079712.html This also explains how to manage the version tag in the subject line. > > Suggested-by: Matt Roper > Cc: Thomas Wood <thomas.w...@intel.com> > Signed-off-by: Vivek Kasireddy <vivek.kasire...@intel.com> > --- > lib/igt_kms.h | 12

Re: [Intel-gfx] [PATCH i-g-t] lib: add a environment variable to control output

2015-11-10 Thread Thomas Wood
On 9 November 2015 at 20:58, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > On Mon, Nov 09, 2015 at 05:17:13PM +0000, Thomas Wood wrote: >> Disable output of terminal control characters and progress meters when >> IGT_PLAIN_OUTPUT is set in the environment. >> >&

[Intel-gfx] [PATCH i-g-t 2/2] tests/kms_force_connector: reset connectors and edid on exit

2015-11-10 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/kms_force_connector.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index a79c974..cf918a7 100644 --- a/tests/kms_force_connector.c +++ b

[Intel-gfx] [PATCH i-g-t 1/2] tests/kms_force_connector: clear forced edid in reset

2015-11-10 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/kms_force_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index f34f21a..a79c974 100644 --- a/tests/kms_force_connector.c +++ b

Re: [Intel-gfx] [PATCH i-g-t 8/8] tests/kms_fbc_crc: ensure context is initialized correctly

2015-11-09 Thread Thomas Wood
On 4 November 2015 at 19:36, Zanoni, Paulo R <paulo.r.zan...@intel.com> wrote: > Em Seg, 2015-11-02 às 11:48 +0000, Thomas Wood escreveu: >> Initialization was included in commit a976d7e (tests/kms_fbc_crc: >> refactor context >> handling code), but won't be executed

[Intel-gfx] [PATCH i-g-t] lib: add a environment variable to control output

2015-11-09 Thread Thomas Wood
Disable output of terminal control characters and progress meters when IGT_PLAIN_OUTPUT is set in the environment. Cc: Derek Morton <derek.j.mor...@intel.com> Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- lib/igt_aux.c | 2 +- lib/igt_core.c | 23 ++--

Re: [Intel-gfx] [PATCH] igt/kms_rotation_crc: Add a subtest to validate Y-tiled obj + Y fb modifier (v3)

2015-11-02 Thread Thomas Wood
On 27 October 2015 at 10:37, Tvrtko Ursulin wrote: > > On 23/10/15 12:35, Daniel Vetter wrote: >> >> On Fri, Oct 23, 2015 at 09:51:06AM +0100, Tvrtko Ursulin wrote: >>> >>> >>> Hi, >>> >>> On 23/10/15 02:34, Vivek Kasireddy wrote: The main goal of this

Re: [Intel-gfx] [PATCH i-g-t 1/8] kms_force_connector: use comparison macros to make debug output clearer

2015-11-02 Thread Thomas Wood
On 2 November 2015 at 11:48, Thomas Wood <thomas.w...@intel.com> wrote: > Signed-off-by: Thomas Wood <thomas.w...@intel.com> > --- > tests/kms_force_connector.c | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/tests

[Intel-gfx] [PATCH i-g-t 1/5] tests/kms_force_connector: free the display struct when no longer needed

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/kms_force_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index 7485ca8..f48b187 100644 --- a/tests/kms_force_connector.c +++ b

[Intel-gfx] [PATCH i-g-t 3/5] tests/kms_force_connector: skip if the required connector is connected

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/kms_force_connector.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index f48b187..1e5ec6f 100644 --- a/tests/kms_force_connector.c +++ b/tests/kms_force_conne

[Intel-gfx] [PATCH i-g-t 5/5] tests/kms_force_connector: use comparison macros

2015-11-02 Thread Thomas Wood
Use the comparison macros to make debug output clearer. v2: fix incorrect comparison Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/kms_force_connector.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tests/kms_force_connector.c b

[Intel-gfx] [PATCH i-g-t 4/5] tests/kms_force_connector: add an option to reset connector force states

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/kms_force_connector.c | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index 1e5ec6f..2cb149a 100644 --- a

[Intel-gfx] [PATCH i-g-t 2/5] lib: add documentation for igt_display_init/fini

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- lib/igt_kms.c | 16 1 file changed, 16 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 51d735d..878e1fb 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -962,6 +962,15 @@ static int get_drm_plane_ty

[Intel-gfx] [PATCH i-g-t 7/8] lib: add PIPE_ANY to the pipe enum

2015-11-02 Thread Thomas Wood
This avoids compiler warnings about invalid enum values. Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- lib/igt_kms.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lib/igt_kms.h b/lib/igt_kms.h index 09c08aa..965c47c 100644 --- a/lib/igt_kms.h +++

[Intel-gfx] [PATCH i-g-t 1/8] kms_force_connector: use comparison macros to make debug output clearer

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/kms_force_connector.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index 7485ca8..4ba1e0b 100644 --- a/tests/kms_force_connector.c

[Intel-gfx] [PATCH i-g-t 3/8] Add missing noreturn attribute to various functions

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- debugger/eudb.c | 2 +- lib/igt_core.c | 2 +- tests/gem_madvise.c | 2 +- tests/pm_rpm.c | 2 +- tests/testdisplay.c | 2 +- tools/intel_display_poller.c | 2 +-

[Intel-gfx] [PATCH i-g-t 5/8] tests: remove duplicate struct member initializers

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/kms_frontbuffer_tracking.c | 1 - tests/pm_lpsp.c | 1 - 2 files changed, 2 deletions(-) diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c index 15707b9..13b91ad 100644 --- a

[Intel-gfx] [PATCH i-g-t 4/8] tests: remove unnecessary igt_exit calls

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/gem_render_linear_blits.c | 2 -- tests/gem_render_tiled_blits.c | 2 -- tests/kms_3d.c | 2 -- tests/kms_force_connector.c | 2 -- 4 files changed, 8 deletions(-) diff --git a/tests/gem_render_linear_bli

[Intel-gfx] [PATCH i-g-t 8/8] tests/kms_fbc_crc: ensure context is initialized correctly

2015-11-02 Thread Thomas Wood
-uninitialized] rendercopy(batch, context, ^ kms_fbc_crc.c:271:22: note: ‘context’ was declared here drm_intel_context *context = NULL; ^ Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/kms_fbc_crc.c | 2 +- 1

[Intel-gfx] [PATCH i-g-t 2/8] lib: highlight subtest results on terminals

2015-11-02 Thread Thomas Wood
Make subtest results easier to identify by making them bold when the output is a terminal. Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- lib/igt_core.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 59127ca..7

[Intel-gfx] [PATCH i-g-t 6/8] Fix comparison of unsigned integers

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- benchmarks/gem_exec_reloc.c | 2 -- overlay/gem-interrupts.c| 7 +-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/benchmarks/gem_exec_reloc.c b/benchmarks/gem_exec_reloc.c index 5be482a..2ef6df5

Re: [Intel-gfx] [PATCH] lib/igt_kms: Introduce get_first_connected_output to retrieve a valid output

2015-10-29 Thread Thomas Wood
On 29 October 2015 at 02:09, Vivek Kasireddy wrote: > In some cases, we just need one valid output to perform a test. > This macro can help in these situations by avoiding iterating > over all the outputs. > > Suggested-by: Matt Roper > CC:

Re: [Intel-gfx] [PATCH i-g-t 2/3] Unify handling of slow/combinatorial tests

2015-10-26 Thread Thomas Wood
On 26 October 2015 at 15:28, David Weinehall <david.weineh...@linux.intel.com> wrote: > On Fri, Oct 23, 2015 at 03:55:23PM +0100, Thomas Wood wrote: >> On 23 October 2015 at 12:42, David Weinehall >> <david.weineh...@linux.intel.com> wrote: >> > Some tes

Re: [Intel-gfx] [PATCH i-g-t 2/3] Unify handling of slow/combinatorial tests

2015-10-23 Thread Thomas Wood
On 23 October 2015 at 12:42, David Weinehall wrote: > Some tests should not be run by default, due to their slow, > and sometimes superfluous, nature. > > We still want to be able to run these tests though in some cases. > Until now there's been no unified way of

Re: [Intel-gfx] [PATCH i-g-t 1/3] Rename gem_concurren_all over gem_concurrent_blit

2015-10-23 Thread Thomas Wood
gem_concurrent_all is misspelled in the subject. On 23 October 2015 at 12:42, David Weinehall wrote: > We'll both rename gem_concurrent_all over gem_concurrent_blit > and change gem_concurrent_blit in this changeset. To make > this easier to follow we first do

Re: [Intel-gfx] [PATCH i-g-t] tests: Add gem_exec_nop_concurrent test

2015-10-16 Thread Thomas Wood
On 15 October 2015 at 09:05, Derek Morton wrote: > This test is based on gem_exec_nop but submits nop batch buffers concurrently > from different threads to check for ring hangs and other issues during > concurrent submissions. Is there any reason not to include this as

Re: [Intel-gfx] [PATCH i-g-t v2] tests/core_prop_blob: Fix core_prop_blob for android

2015-10-15 Thread Thomas Wood
pported. > > v2: moved igt_require_propblob() to core_prop_blob.c (Daniel Vetter) > Moved gem_blt.c to a seperate patch (Thomas Wood) > > Signed-off-by: Derek Morton <derek.j.mor...@intel.com> > --- > tests/core_prop_blob.c | 71 > --

Re: [Intel-gfx] [PATCH i-g-t] core_prop_blob ioctl_wrappers: Fix new tests/benchmarks for android

2015-10-14 Thread Thomas Wood
On 13 October 2015 at 16:35, Daniel Vetter wrote: > On Tue, Oct 13, 2015 at 04:16:18PM +0100, Derek Morton wrote: >> Changes since #1b492e311 have broken the Android build. This patch >> fixes the build for Android. >> >> core_prop_blob was using ioctls not in the android kernel.

[Intel-gfx] [PATCH i-g-t] gem_storedw_loop: fix segfault when listing subtests

2015-09-24 Thread Thomas Wood
subtests. Cc: Robert Beckett <robert.beck...@intel.com> Cc: Jesse Barnes <jbar...@virtuousgeek.org> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/gem_storedw_loop.c | 6 -- 1 file changed, 4 insertions(+), 2 deletion

[Intel-gfx] [PATCH i-g-t] lib/tests: explicitly raise SIGSEGV

2015-09-24 Thread Thomas Wood
Dereferencing a NULL pointer is undefined behaviour and may not always result in a segmentation fault. Explicitly raise the SIGSEGV signal to test handling of this signal. Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- lib/tests/igt_segfault.c | 6 +- 1 file changed, 5 inse

[Intel-gfx] [PATCH i-g-t] lib: add igt_debugfs_search

2015-09-23 Thread Thomas Wood
Add igt_debugfs_search to search each line in a debugfs file for a specified substring. Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- lib/igt_debugfs.c | 31 +++ lib/igt_debugfs.h | 1 + tests/gem_ppgtt.c

Re: [Intel-gfx] [PATCH i-g-t] gem_ppgtt: Test VMA leak on context destruction

2015-09-23 Thread Thomas Wood
On 23 September 2015 at 13:36, Tvrtko Ursulin <tvrtko.ursu...@linux.intel.com> wrote: > > Hi, > > On 09/18/2015 12:17 PM, Thomas Wood wrote: >> >> On 11 September 2015 at 15:31, Tvrtko Ursulin >> <tvrtko.ursu...@linux.intel.com> wrote: >>>

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_storedw_loop: Fix use after free for bufmgr

2015-09-23 Thread Thomas Wood
On 23 September 2015 at 17:01, Daniel Vetter wrote: > On Tue, Sep 22, 2015 at 12:08:05PM -0700, Jesse Barnes wrote: >> On 09/22/2015 11:02 AM, robert.beck...@intel.com wrote: >> > From: Robert Beckett >> > >> > Move bufmgr destruction to end of tests.

Re: [Intel-gfx] [PATCH] tests/gem_ctx_param_basic: fix up non-root-set-no-zeromap subtest

2015-09-18 Thread Thomas Wood
It's helpful to include "i-g-t" in the subject line for intel-gpu-tools patches so that they are easily identified. This can be done by using the --subject-prefix "PATCH i-g-t" option when using git format-patch or send-email and can also be set as a local configuration option using the following

Re: [Intel-gfx] [PATCH i-g-t] gem_ppgtt: Test VMA leak on context destruction

2015-09-18 Thread Thomas Wood
On 11 September 2015 at 15:31, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Test that VMAs associated with a context are cleaned up when > contexts are destroyed. > > In practice this emulates the leak seen between fbcon and X server.

Re: [Intel-gfx] [PATCH] tests/gem_ctx_param_basic: fix up non-root-set-no-zeromap subtest

2015-09-18 Thread Thomas Wood
On 18 September 2015 at 17:02, Jesse Barnes <jbar...@virtuousgeek.org> wrote: > On 09/18/2015 03:22 AM, Thomas Wood wrote: >> It's helpful to include "i-g-t" in the subject line for >> intel-gpu-tools patches so that they are easily identified. This can >>

[Intel-gfx] [PATCH i-g-t v2] scripts: add quick-testlist.py

2015-09-17 Thread Thomas Wood
Add a script to take a piglit results file and create a list of tests that ran in under 60 seconds. This list can be used by the --test-list option of piglit. v2: exclude incomplete tests Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- scripts/quick-testlist.p

Re: [Intel-gfx] [PATCH i-g-t v2] scripts: add quick-testlist.py

2015-09-17 Thread Thomas Wood
On 17 September 2015 at 13:09, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > On Thu, Sep 17, 2015 at 12:42:44PM +0100, Thomas Wood wrote: >> Add a script to take a piglit results file and create a list of tests >> that ran in under 60 seconds. This list can be used by the

Re: [Intel-gfx] [PATCH i-g-t v2] scripts: add quick-testlist.py

2015-09-17 Thread Thomas Wood
> Wilson [ch...@chris-wilson.co.uk] > Sent: Thursday, September 17, 2015 3:43 PM > To: Wood, Thomas > Cc: Intel Graphics Development > Subject: Re: [Intel-gfx] [PATCH i-g-t v2] scripts: add quick-testlist.py > > On Thu, Sep 17, 2015 at 01:16:18PM +0100, Thomas Wood wrote: &g

Re: [Intel-gfx] [PATCH i-g-t v2] scripts: add quick-testlist.py

2015-09-17 Thread Thomas Wood
On 17 September 2015 at 13:43, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > On Thu, Sep 17, 2015 at 01:16:18PM +0100, Thomas Wood wrote: >> On 17 September 2015 at 13:09, Chris Wilson <ch...@chris-wilson.co.uk> wrote: >> > On Thu, Sep 17, 2015 at 12:42:44PM +0100

[Intel-gfx] [PATCH i-g-t] lib: allow wildcard matching when specifying subtests

2015-09-16 Thread Thomas Wood
This allows multiple subtests to be specified using standard wildcard characters when using the --run-subtest command line option. Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- lib/igt_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/igt_core.c

[Intel-gfx] [PATCH i-g-t] scripts: add quick-testlist.py

2015-09-15 Thread Thomas Wood
Add a script to take a piglit results file and create a list of tests that ran in under 60 seconds. This list can be used by the --test-list option of piglit. Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- scripts/quick-testlist.py | 44 +

Re: [Intel-gfx] [PATCH v3 0/7] igt: adding parameter to drm_open_any and drm_open_any_master to allow specification of non-intel GPUs

2015-09-11 Thread Thomas Wood
ff-by as discussed. > > > -mf > > > On 09/09/2015 09:54 AM, Thomas Wood wrote: >> >> On 14 August 2015 at 16:22, Micah Fedke <micah.fe...@collabora.co.uk> >> wrote: >>> >>> Changes since last version of patch: >>> >>> Now u

[Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.12

2015-09-11 Thread Thomas Wood
ntbuffer_tracking: print the status when it's not what we expect Thomas Wood (31): NEWS: Post-release bump docs: override section id to avoid '/' in filenames docs: add the annotation glossary docs: fix "no link" warning docs: fix duplicated ID error d

Re: [Intel-gfx] [PATCH i-g-t v3 1/2] tests: Add blob-property test

2015-09-10 Thread Thomas Wood
On 10 September 2015 at 07:06, Daniel Stone wrote: > Hi, > > On 10 September 2015 at 06:57, Daniel Stone wrote: >> Exercises the new blob-creation ioctl, testing lifetimes and behaviour >> of user-created blobs, as well as exercising all the invariant

Re: [Intel-gfx] [PATCH i-g-t v3 1/2] tests: Add blob-property test

2015-09-10 Thread Thomas Wood
On 10 September 2015 at 14:02, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Thomas, > > On 10 September 2015 at 13:31, Thomas Wood <thomas.w...@intel.com> wrote: >> On 10 September 2015 at 07:06, Daniel Stone <dan...@fooishbar.org> wrote: >>> On 10 S

[Intel-gfx] [PATCH i-g-t] lib: don't use igt_warn in signal handlers

2015-09-10 Thread Thomas Wood
igt_wan and other log functions are not async-signal safe, so should not be used in signal handlers. Reported-by: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- lib/igt_aux.c | 11 --- 1 file changed, 8 insertions(+), 3 deleti

Re: [Intel-gfx] [PATCH i-g-t] Add a link training test

2015-09-09 Thread Thomas Wood
On 8 September 2015 at 13:28, Ander Conselvan de Oliveira wrote: > This adds a test that compiles the link training code from i915 into a > separate executable and uses it to train a fake sink device. The test > also uses device information from i915 to

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_ctx_param_basic.c: fix non-root-set-no-zeromap subtest

2015-09-09 Thread Thomas Wood
On 9 September 2015 at 09:46, wrote: > From: Daniele Ceraolo Spurio > > The test expects an ioctl failure when it tries to set > CONTEXT_PARAM_NO_ZEROMAP from a non-root process. However, there is no > requirement in the kernel

Re: [Intel-gfx] [PATCH v3 0/7] igt: adding parameter to drm_open_any and drm_open_any_master to allow specification of non-intel GPUs

2015-09-09 Thread Thomas Wood
On 14 August 2015 at 16:22, Micah Fedke wrote: > Changes since last version of patch: > > Now using the core_* tests as demonstrations rather than drm_read. Apologies for not getting to this sooner, but it no longer applies to master. Can you rebase the series and

Re: [Intel-gfx] [PATCH 1/3] tools/intel_reg: Use pci device from config on write

2015-09-09 Thread Thomas Wood
On 28 August 2015 at 16:16, Jani Nikula wrote: > On Fri, 28 Aug 2015, Mika Kuoppala wrote: >> Use the pre configured pci device from config also >> in write path. >> >> Cc: Jani Nikula >> Signed-off-by: Mika Kuoppala

Re: [Intel-gfx] [PATCH i-g-t] tools/Android.mk: Fix compile error in intel_reg.c

2015-09-09 Thread Thomas Wood
On 9 September 2015 at 14:30, Derek Morton wrote: > The patch "tools: install the register definition files" caused > a build error on android as it added 'PKGDATADIR' which was not > defined in the Android build environment. This patch adds that > define to

Re: [Intel-gfx] [PATCH i-g-t] intel_reg: ensure "intel_reg help" always works

2015-09-09 Thread Thomas Wood
On 9 September 2015 at 13:20, Jani Nikula <jani.nik...@linux.intel.com> wrote: > On Mon, 07 Sep 2015, Thomas Wood <thomas.w...@intel.com> wrote: >> Signed-off-by: Thomas Wood <thomas.w...@intel.com> > > I'm lagging behind with my mails, and I see you already pus

[Intel-gfx] [PATCH i-g-t] tests/gem_pwrite_snooped: disable const cast warning

2015-09-08 Thread Thomas Wood
Disable -Wcast-qual temporarily to allow memchr_inv to return non-const data (similar to memchr), without causing a compiler warning. Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/gem_pwrite_snooped.c | 3 +++ 1 fil

Re: [Intel-gfx] [PATCH 0/3] remove crtc<->pipe mapping code

2015-09-08 Thread Thomas Wood
On 4 September 2015 at 19:22, Micah Fedke wrote: > This patchset removes the code that looks up a pipe number from a crtc ID. > The > pipe number is equivalent to the index of the crtc in the array of crtcs > returned by the kernel for a drmModeGetResources() call.

Re: [Intel-gfx] [PATCH 3/3] overlay: remove crtc<->pipe mapping code from kms-overlay

2015-09-08 Thread Thomas Wood
On 4 September 2015 at 19:22, Micah Fedke wrote: > the crtc id is now always equivalent to its index in the array of crtcs > returned by the kernel > > --- > overlay/Makefile.am | 4 ++-- > overlay/kms/kms-overlay.c | 7 ++- > 2 files changed, 4

[Intel-gfx] [PATCH i-g-t 2/2] null_state_gen: add const to intel_batch_state_copy data

2015-09-08 Thread Thomas Wood
The data is not modified by the function and is often declared const. Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tools/null_state_gen/intel_batchbuffer.c | 6 +++--- tools/null_state_gen/intel_batchbuffer.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a

[Intel-gfx] [PATCH i-g-t 1/2] tools/aubdump: remove void pointer arithmetic

2015-09-08 Thread Thomas Wood
A gcc extension allows void pointer arithmetic by treating the size of void as 1, but this generates a warning when -Wpointer-arith is used. Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tools/aubdump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[Intel-gfx] [PATCH i-g-t 1/2] build: fix unused-result warnings

2015-09-07 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- benchmarks/kms_vblank.c| 7 --- debugger/eudb.c| 4 +++- lib/igt_aux.c | 8 ++-- overlay/gpu-top.c | 4 +++- overlay/overlay.c | 4 ++-- tools/intel_l3_udev_list

[Intel-gfx] [PATCH i-g-t 2/2] tests/gem_pwrite_snooped: fix const cast warning

2015-09-07 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/gem_pwrite_snooped.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/gem_pwrite_snooped.c b/tests/gem_pwrite_snooped.c index d3f6223..29142c3 100644 --- a/tests/gem_pwrite_snooped.c +++ b

[Intel-gfx] [PATCH i-g-t] intel_reg: ensure "intel_reg help" always works

2015-09-07 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tools/intel_reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/intel_reg.c b/tools/intel_reg.c index 95760db..2b3c686 100644 --- a/tools/intel_reg.c +++ b/tools/intel_reg.c @@ -865,7 +865,7 @@ int main(in

[Intel-gfx] [PATCH i-g-t] tests: remove gem_storedw_loop_* tests

2015-09-07 Thread Thomas Wood
These have been replaced by subtests in gem_storedw_loop. Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/.gitignore| 4 -- tests/Makefile.sources | 4 -- tests/gem_storedw_loop_blt.c| 150 ---

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/gem_pwrite_snooped: fix const cast warning

2015-09-07 Thread Thomas Wood
On 7 September 2015 at 13:53, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Mon, Sep 07, 2015 at 12:34:12PM +0100, Thomas Wood wrote: >> Signed-off-by: Thomas Wood <thomas.w...@intel.com> >> --- >> tests/gem_pwrite_snooped.c | 4 ++-- >> 1 fil

[Intel-gfx] [PATCH i-g-t] tools: remove quick_dump

2015-09-04 Thread Thomas Wood
Remove quick_dump as it has been replaced by the intel_reg tool and move the register definition files to tools/registers. Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- README | 13 --- configure.ac

[Intel-gfx] [PATCH i-g-t] tools: install the register definition files

2015-09-04 Thread Thomas Wood
Install the register definition files and use them by default in intel_reg. Suggested-by: Jani Nikula <jani.nik...@linux.intel.com> Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- configure.ac| 5 +++-- tools/Makefile.am | 2 +- tools/intel_reg.c

[Intel-gfx] [PATCH i-g-t v2] tools: install the register definition files

2015-09-04 Thread Thomas Wood
Install the register definition files and use them by default in intel_reg. v2: remove redundant path check Suggested-by: Jani Nikula <jani.nik...@linux.intel.com> Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- configure.ac| 5 +++-- tools/Makefile.am

[Intel-gfx] [PATCH i-g-t 1/2] tests/gem_storedw_loop: skip on gen6 bsd

2015-09-03 Thread Thomas Wood
Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/gem_storedw_loop.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tests/gem_storedw_loop.c b/tests/gem_storedw_loop.c index 2263397..1bb276e 100644 --- a/tests/gem_storedw_loop.c +++ b

[Intel-gfx] [PATCH i-g-t 2/2] tests/gem_storedw_loop: remove redundant ppgtt check

2015-09-03 Thread Thomas Wood
All tests require ppgtt, so checking for it later on has no effect. Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- tests/gem_storedw_loop.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tests/gem_storedw_loop.c b/tests/gem_storedw_loop.c index 1bb276e..0

[Intel-gfx] [PATCH i-g-t] tests/tools: add --as-needed to linker flags

2015-08-28 Thread Thomas Wood
to the execution speed and memory consumption. Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/Makefile.am | 1 + tools/Makefile.am | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index dcac2f3..5aa480b 100644 --- a/tests/Makefile.am +++ b

[Intel-gfx] [PATCH i-g-t] tools/null_state_gen: fix various compiler warnings

2015-08-28 Thread Thomas Wood
Add the debug and warning flags to cflags and fix the resulting issues. Signed-off-by: Thomas Wood thomas.w...@intel.com --- tools/null_state_gen/Makefile.am | 2 ++ tools/null_state_gen/intel_batchbuffer.c | 7 +++--- tools/null_state_gen/intel_batchbuffer.h | 4

Re: [Intel-gfx] [PATCH] intel-gpu-tools: Fixes-compiler-warnings-about-wrong-function-type

2015-08-26 Thread Thomas Wood
On 24 August 2015 at 10:59, Stefan Dirsch sndir...@suse.de wrote: Hi Find a simple buildfix against current intel-gpu-tools git sources attached. I assume the compiler warning is about uninitialised values and unused variables? It looks like the Makefile is not using the debug cflags so these

Re: [Intel-gfx] [PATCH i-g-t] kms_addfb_basic: Require fb modifiers for unused field tests

2015-08-24 Thread Thomas Wood
On 20 August 2015 at 15:43, Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com wrote: The drm core doesn't check unused fields of ADDFB2 for pre-FB_MODIFIERS userspace, so require that and use the local version of the defines. Signed-off-by: Ander Conselvan de Oliveira

[Intel-gfx] [PATCH i-g-t] lib: add a single include header

2015-08-17 Thread Thomas Wood
Add a header that includes all the headers for the library. This allows reorganisation of the library without affecting programs using it and also simplifies the headers that need to be included to use the library. Signed-off-by: Thomas Wood thomas.w...@intel.com --- lib/igt.h

Re: [Intel-gfx] [PATCH i-g-t v2] benckmarks/Android.mk: Fix building benchmarks for Android

2015-08-13 Thread Thomas Wood
On 13 August 2015 at 11:27, Derek Morton derek.j.mor...@intel.com wrote: The commit benchmarks: Do not install to system-wide bin/ changed the benchmark file list from bin_PROGRAMS to benchmarks_PROGRAMS. However Android.mk was not updated, resulting in IGT failing to build for Android. This

Re: [Intel-gfx] [PATCH i-g-t v2] benchmark/: fix gem_exec_nop complie error on android

2015-07-24 Thread Thomas Wood
On 24 July 2015 at 14:43, Chris Wilson ch...@chris-wilson.co.uk wrote: On Fri, Jul 24, 2015 at 02:35:29PM +0100, Derek Morton wrote: There are two versions of gem_exec_nop.c in benchmarks and tests which causes the build system to have two build modules with the same name. This patch renames

  1   2   3   4   5   >