[PATCH i-g-t] tests/intel/xe_gt_freq: Check for RPe freq updates

Pcode can dynamically update RPe frequency. Use the latest value in tests that check it. Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_gt_freq.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c index c12f6c52c..5c6373016 100644

[PATCH v4] drm/i915/guc: Use context hints for GT frequency

-by: Rodrigo Vivi Acked-by: Ivan Briano Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 16 -- .../gpu/drm/i915/gem/i915_gem_context_types.h | 1 + drivers/gpu/drm/i915/gt/intel_context_types.h | 1 + drivers/gpu/drm/i915/gt/intel_rps.c | 4

[PATCH v3] drm/i915/guc: Use context hints for GT frequency

as per review suggestions (Rodrigo, Tvrtko). Also, use flag bits in intel_context as it allows finer control for toggling per engine if needed (Tvrtko). v3: Minor review comments (Tvrtko) Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: Sushma Venkatesh Reddy Acked-by: Rodrigo Vivi Signed-off-by: Vinay

[PATCH v2] drm/i915/guc: Use context hints for GT freq

as per review suggestions (Rodrigo, Tvrtko). Also, use flag bits in intel_context as it allows finer control for toggling per engine if needed (Tvrtko). Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: Sushma Venkatesh Reddy Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gem

[PATCH] drm/i915/guc: Add Compute context hint

Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 8 +++ .../gpu/drm/i915/gem/i915_gem_context_types.h | 1 + drivers/gpu/drm/i915/gt/intel_rps.c | 8 +++ .../drm/i915/gt/uc/abi/guc_actions_slpc_abi.h | 21 +++ drivers/gpu/drm/i915

[PATCH v2] drm/i915/mtl: Wake GT before sending H2G message

an official WA soon so adding a FIXME in the comments. v2: Make the new ranges watertight to address BAT failures and update commit message (Matt R). Reviewed-by: Matt Roper Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/intel_uncore.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH] drm/i915/mtl: Wake GT before sending H2G message

form sleep states and a H2G is triggered. A forcewake ensures those sleep states have been fully exited and further processing occurs as expected. This will have an official WA soon so adding a FIXME in the comments. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/intel_uncore.c | 5 +++

[PATCH i-g-t] tests/perf_pmu: Set defaults before frequency test

subtest at the end expects drm-fd to be closed. Also setup expected frequencies (Kamil) and address other nits (Kamil) Link: https://gitlab.freedesktop.org/drm/intel/-/issues/9432 Cc: Kamil Konieczny Signed-off-by: Vinay Belgaumkar --- tests/intel/perf_pmu.c | 62

[PATCH i-g-t] tests/perf_pmu: Restore sysfs freq in exit handler

Seeing random issues where this test starts with invalid values. Ensure that we restore the frequencies in case test exits early due to some system issues. Link: https://gitlab.freedesktop.org/drm/intel/-/issues/9432 Signed-off-by: Vinay Belgaumkar --- tests/intel/perf_pmu.c | 53

[Intel-gfx] [PATCH] drm/i915: Read a shadowed mmio register for ggtt flush

We read RENDER_HEAD as a part of the flush. If GT is in deeper sleep states, this could lead to read errors since we are not using a forcewake. Safer to read a shadowed register instead. Cc: John Harrison Cc: Daniele Ceraolo Spurio Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH] drm/i915: Initialize residency registers earlier

tions") Suggested-by: Alan Previn Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_rc6.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c index 7090e4be29cb..58dc0dab9

[Intel-gfx] [PATCH v2] drm/i915/mtl: Don't set PIPE_CONTROL_FLUSH_L3

-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c index ba4c2422b340..86a04afff64b 100644 --- a/drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH] drm/i915/mtl: Don't set PIPE_CONTROL_FLUSH_L3

This bit does not cause an explicit L3 flush. We already use PIPE_CONTROL_DC_FLUSH_ENABLE for that purpose. Cc: Nirmoy Das Cc: Mikka Kuoppala Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH] drm/i915/gem: Allow users to disable waitboost

://github.com/XinfengZhang/libva/commit/3d90d18c67609a73121bb71b20ee4776b54b61a7 Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 9 ++--- drivers/gpu/drm/i915/i915_request.c | 3 ++- drivers/gpu/drm/i915/i915_request.h | 1 + include

[Intel-gfx] [PATCH i-g-t] tests/i915_pm_freq_api: Set min/max to expected values

A prior(rps) test leaves the system in a bad state causing failures in the basic test. Set min/max to expected values before running it. Test will restore values at the end. Link: https://gitlab.freedesktop.org/drm/intel/-/issues/8670 Signed-off-by: Vinay Belgaumkar --- tests/intel

[Intel-gfx] [PATCH i-g-t] tests/i915_pm_freq_api: Test s2idle instead of S3

Test skips whenever S3 is not supported, use s2idle instead, which is widely enabled. Cc: Anshuman Gupta Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915

[Intel-gfx] [PATCH v4 i-g-t] tests/i915_pm_freq_api: Ignore zero register value

: https://gitlab.freedesktop.org/drm/intel/issues/8736 Link: https://gitlab.freedesktop.org/drm/intel/issues/8989 Reviewed-by: Riana Tauro Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/tests

[Intel-gfx] [PATCH v3 i-g-t] tests/i915_pm_freq_api: Ignore zero register value

: https://gitlab.freedesktop.org/drm/intel/issues/8989 Reviewed-by: Riana Tauro Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915/i915_pm_freq_api.c

[Intel-gfx] [PATCH v2 i-g-t] tests/i915_pm_freq_api: Ignore zero register value

Register read for requested_freq can return 0 when system is in runtime_pm. Make allowance for this case. v2: Explicit check for runtime_pm status (Riana) Link: https://gitlab.freedesktop.org/drm/intel/issues/8736 Link: https://gitlab.freedesktop.org/drm/intel/issues/8989 Signed-off-by: Vinay

[Intel-gfx] [PATCH i-g-t] tests/i915_pm_freq_api: Ignore zero register value

Register read for requested_freq can return 0 when system is in runtime_pm. Make allowance for this case. Link: https://gitlab.freedesktop.org/drm/intel/issues/8736 Link: https://gitlab.freedesktop.org/drm/intel/issues/8989 Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 18

[Intel-gfx] [PATCH v2] drm/i915/guc/slpc: Restore efficient freq earlier

("drm/i915/guc/slpc: Allow SLPC to use efficient frequency") Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 22 + 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Restore efficient freq earlier

/drm/intel/-/issues/8736 Fixes: 55f9720dbf23 ("drm/i915/guc/slpc: Provide sysfs for efficient freq") Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_s

[Intel-gfx] [PATCH v3 i-g-t] i915_pm_freq_api: Add some debug to tests

Dixit Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915/i915_pm_freq_api.c index 522abee35..a7bbd4896 100644 --- a/tests/i915/i915_pm_freq_api.c +++ b

[Intel-gfx] [PATCH v2 i-g-t] i915_pm_freq_api: Add some debug to tests

Some subtests seem to be failing in CI, use igt_assert_(lt/eq) which print the values being compared and some additional debug as well. v2: Print GT as well (Ashutosh) Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 18 -- 1 file changed, 8 insertions(+), 10

[Intel-gfx] [PATCH i-g-t] i915_pm_freq_api: Add some debug to tests

Some subtests seem to be failing in CI, use igt_assert_(lt/eq) which print the values being compared and some additional debug as well. Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/tests

[Intel-gfx] [PATCH v2] drm/i915/guc: Dump perf_limit_reasons for debug

GuC load takes longer sometimes due to GT frequency not ramping up. Add perf_limit_reasons to the existing warn print to see if frequency is being throttled. v2: Review comments (Ashutosh) Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 8 +--- 1 file

[Intel-gfx] [PATCH] drm/i915/guc: Dump perf_limit_reasons for debug

GuC load takes longer sometimes due to GT frequency not ramping up. Add perf_limit_reasons to the existing warn print to see if frequency is being throttled. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Intel-gfx] [PATCH v2] drm/i915/guc/slpc: Apply min softlimit correctly

ld restore the cached min freq (via H2G) for it to take effect. v2: Clarify commit message (Ashutosh) Fixes: 95ccf312a1e4 ("drm/i915/guc/slpc: Allow SLPC to use efficient frequency") Reviewed-by: Ashutosh Dixit Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_s

[Intel-gfx] [PATCH v3 i-g-t] tests/i915_pm_freq_api: Add a suspend subtest

at init. Also, disable efficient freq before starting the test which allows current freq to be consistent with SLPC min freq. v2: Restore freq in exit handler (Ashutosh) v3: Free the allocated stash arrays Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 92

[Intel-gfx] [PATCH v2 i-g-t] tests/i915_pm_freq_api: Add a suspend subtest

at init. Also, disable efficient freq before starting the test which allows current freq to be consistent with SLPC min freq. v2: Restore freq in exit handler (Ashutosh) Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 89 +++ 1 file changed, 69

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Apply min softlimit correctly

c: Allow SLPC to use efficient frequency") Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c index

[Intel-gfx] [PATCH v2 i-g-t] tests/gem_ctx_persistence: Skip hang subtest with GuC

Hang scenarios are not supported with persistent contexts when GuC submission is enabled. Cc: Kamil Konieczny Reviewed-by: Andrzej Hajda Signed-off-by: Vinay Belgaumkar --- tests/i915/gem_ctx_persistence.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/i915/gem_ctx_persistence.c

[Intel-gfx] [PATCH i-g-t] tests/gem_ctx_persistence: Skip hang subtest with GuC

Hang subtest is not supported with GuC submission enabled. Cc: Kamil Konieczny Signed-off-by: Vinay Belgaumkar --- tests/i915/gem_ctx_persistence.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c index df9b1c491

[Intel-gfx] [PATCH i-g-t] tests/i915_pm_freq_api: Add a suspend subtest

Verify that SLPC API works as expected after a suspend. Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915/i915_pm_freq_api.c index 9005cd220..f35f1f8e0

[Intel-gfx] [PATCH i-g-t] tests/i915/gem_ctx_persistence: Skip some subtests

Hang and heartbeat subtests are not supported with GuC submission enabled. Signed-off-by: Vinay Belgaumkar --- tests/i915/gem_ctx_persistence.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs

://gitlab.freedesktop.org/drm/intel/-/issues/7632 Reviewed-by: Ashutosh Dixit Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 5 - drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs

rps_boost debugfs shows host turbo related info. This is not valid when SLPC is enabled. guc_slpc_info already shows the number of boosts. Add num_waiters there as well and disable rps_boost when SLPC is enabled. Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7632 Signed-off-by: Vinay

[Intel-gfx] [PATCH v6 2/2] drm/i915/selftest: Update the SLPC selftest

Use the new efficient frequency toggling interface. Also create a helper function to restore the frequencies after the test is done. v2: Restore max freq first and then min. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 42 ++--- 1 file

[Intel-gfx] [PATCH v6 1/2] drm/i915/guc/slpc: Provide sysfs for efficient freq

gle efficient freq usage in SLPC selftest and checkpatch fixes v5: Review comments (Andi) and add a separate patch for selftest updates Fixes: 95ccf312a1e4 ("drm/i915/guc/slpc: Allow SLPC to use efficient frequency") Signed-off-by: Vinay Belgaumkar Reviewed-by: Rodrigo Vivi Reviewed-by: A

[Intel-gfx] [PATCH i-g-t 3/4] i915_pm_freq_api: Add some basic SLPC igt tests

SLPC is disabled. Check for enable_guc is not sufficient as kernel config may have it but the platform doesn't actually support it. v5: Use the updated SLPC helper v6: Check for guc enabled as well as slpc debugfs Reviewed-by: Ashutosh Dixit Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar

[Intel-gfx] [PATCH i-g-t 4/4] HAX: tests/i915: Try out the SLPC IGT tests

Trying out for CI. Do not review. Signed-off-by: Vinay Belgaumkar --- tests/intel-ci/fast-feedback.testlist | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index d9fcb62d..653668dd 100644 --- a/tests/intel-ci

[Intel-gfx] [PATCH v7 i-g-t 0/4] tests/slpc: Add basic IGT test

Borrow some subtests from xe_guc_pc. Also add per GT debugfs helpers. v3: Review comments and add HAX patch v4: Modify the condition for skipping the test v5: Update the SLPC helper to per GT v6: Review comments (Ashutosh) Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (4): lib/debugfs

[Intel-gfx] [PATCH i-g-t 1/4] lib/debugfs: Add per GT debugfs helpers

These can be used to open per-gt debugfs files. Reviewed-by: Ashutosh Dixit Signed-off-by: Tvrtko Ursulin Signed-off-by: Vinay Belgaumkar --- lib/igt_debugfs.c | 60 +++ lib/igt_debugfs.h | 4 2 files changed, 64 insertions(+) diff --git

[Intel-gfx] [PATCH i-g-t 2/4] lib: Make SLPC helper function per GT

Use default of 0 where GT id is not being used. Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/8308 v2: Add a helper for GT 0 (Ashutosh) v3: Additional review comments (Ashutosh) v4: Return false if slpc debugfs is not found Signed-off-by: Vinay Belgaumkar Reviewed-by: Ashutosh Dixit

[Intel-gfx] [PATCH i-g-t 3/4] i915_pm_freq_api: Add some basic SLPC igt tests

SLPC is disabled. Check for enable_guc is not sufficient as kernel config may have it but the platform doesn't actually support it. v5: Use the updated SLPC helper Reviewed-by: Ashutosh Dixit Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 152

[Intel-gfx] [PATCH i-g-t 4/4] HAX: tests/i915: Try out the SLPC IGT tests

Trying out for CI. Do not review. Signed-off-by: Vinay Belgaumkar --- tests/intel-ci/fast-feedback.testlist | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index d9fcb62d..653668dd 100644 --- a/tests/intel-ci

[Intel-gfx] [PATCH i-g-t 2/4] lib: Make SLPC helper function per GT

Use default of 0 where GT id is not being used. Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/8308 v2: Add a helper for GT 0 (Ashutosh) v3: Additional review comments (Ashutosh) Signed-off-by: Vinay Belgaumkar Reviewed-by: Ashutosh Dixit --- lib/igt_pm.c | 34

[Intel-gfx] [PATCH i-g-t 1/4] lib/debugfs: Add per GT debugfs helpers

These can be used to open per-gt debugfs files. Reviewed-by: Ashutosh Dixit Signed-off-by: Tvrtko Ursulin Signed-off-by: Vinay Belgaumkar --- lib/igt_debugfs.c | 60 +++ lib/igt_debugfs.h | 4 2 files changed, 64 insertions(+) diff --git

[Intel-gfx] [PATCH v7 i-g-t 0/4] tests/slpc: Add basic IGT test

comments (Ashutosh) Signed-off-by: Vinay Belgaumkar Reviewed-by: Ashutosh Dixit Vinay Belgaumkar (4): lib/debugfs: Add per GT debugfs helpers lib: Make SLPC helper function per GT i915_pm_freq_api: Add some basic SLPC igt tests HAX: tests/i915: Try out the SLPC IGT tests lib/igt_debugfs.c

[Intel-gfx] [PATCH v5 2/2] drm/i915/selftest: Update the SLPC selftest

Use the new efficient frequency toggling interface. Also create a helper function to restore the frequencies after the test is done. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 42 ++--- 1 file changed, 37 insertions(+), 5 deletions(-) diff

[Intel-gfx] [PATCH v5 1/2] drm/i915/guc/slpc: Provide sysfs for efficient freq

gle efficient freq usage in SLPC selftest and checkpatch fixes v5: Review comments (Andi) and add a separate patch for selftest updates Fixes: 95ccf312a1e4 ("drm/i915/guc/slpc: Allow SLPC to use efficient frequency") Signed-off-by: Vinay Belgaumkar Reviewed-by: Rodrigo Vivi Reviewed-by: A

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Provide sysfs for efficient freq

gle efficient freq usage in SLPC selftest and checkpatch fixes Fixes: 95ccf312a1e4 ("drm/i915/guc/slpc: Allow SLPC to use efficient frequency") Signed-off-by: Vinay Belgaumkar Reviewed-by: Rodrigo Vivi Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/gt/intel_gt_sysf

[Intel-gfx] [PATCH v3] drm/i915/guc/slpc: Provide sysfs for efficient freq

c: Allow SLPC to use efficient frequency") Signed-off-by: Vinay Belgaumkar Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 35 +++ drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 43 ++- drivers/gpu/drm/i915/gt/uc/intel_guc_

[Intel-gfx] [PATCH v2] drm/i915/guc/slpc: Provide sysfs for efficient freq

it through this interface. v2: Keep just one interface to toggle sysfs. With this, user will be completely responsible for toggling efficient frequency if need be. There will be no implicit disabling when user sets min < RP1 (Ashutosh) Signed-off-by: Vinay Belgaumkar Fixes: 95ccf312a1e4 ("drm/

[Intel-gfx] [PATCH i-g-t 4/4] HAX: tests/i915: Try out the SLPC IGT tests

Trying out for CI. Do not review. Signed-off-by: Vinay Belgaumkar --- tests/intel-ci/fast-feedback.testlist | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index d9fcb62d..653668dd 100644 --- a/tests/intel-ci

[Intel-gfx] [PATCH i-g-t 3/4] i915_pm_freq_api: Add some basic SLPC igt tests

SLPC is disabled. Check for enable_guc is not sufficient as kernel config may have it but the platform doesn't actually support it. v5: Use the updated SLPC helper Reviewed-by: Ashutosh Dixit Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 152

[Intel-gfx] [PATCH i-g-t 2/4] lib: Make SLPC helper function per GT

Use default of 0 where GT id is not being used. v2: Add a helper for GT 0 (Ashutosh) Signed-off-by: Vinay Belgaumkar --- lib/igt_pm.c | 36 ++-- lib/igt_pm.h | 3 ++- 2 files changed, 28 insertions(+), 11 deletions(-) diff --git a/lib/igt_pm.c b/lib/igt_pm.c

[Intel-gfx] [PATCH i-g-t 1/4] lib/debugfs: Add per GT debugfs helpers

These can be used to open per-gt debugfs files. Reviewed-by: Ashutosh Dixit Signed-off-by: Tvrtko Ursulin Signed-off-by: Vinay Belgaumkar --- lib/igt_debugfs.c | 60 +++ lib/igt_debugfs.h | 4 2 files changed, 64 insertions(+) diff --git

[Intel-gfx] [PATCH v6 i-g-t 0/4] tests/slpc: Add basic IGT test

Borrow some subtests from xe_guc_pc. Also add per GT debugfs helpers. v3: Review comments and add HAX patch v4: Modify the condition for skipping the test v5: Update the SLPC helper to per GT v6: Review comments (Ashutosh) Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (4): lib/debugfs

[Intel-gfx] [PATCH i-g-t 4/4] HAX: tests/i915: Try out the SLPC IGT tests

Trying out for CI. Do not review. Signed-off-by: Vinay Belgaumkar --- tests/intel-ci/fast-feedback.testlist | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index d9fcb62d..653668dd 100644 --- a/tests/intel-ci

[Intel-gfx] [PATCH i-g-t 3/4] i915_pm_freq_api: Add some basic SLPC igt tests

SLPC is disabled. Check for enable_guc is not sufficient as kernel config may have it but the platform doesn't actually support it. v5: Use the updated SLPC helper Reviewed-by: Ashutosh Dixit Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 152

[Intel-gfx] [PATCH i-g-t 2/4] lib: Make SLPC helper function per GT

Use default of 0 where GT id is not being used. Signed-off-by: Vinay Belgaumkar --- lib/igt_pm.c | 20 ++-- lib/igt_pm.h | 2 +- tests/i915/i915_pm_rps.c | 6 +++--- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/lib/igt_pm.c b/lib

[Intel-gfx] [PATCH i-g-t 1/4] lib/debugfs: Add per GT debugfs helpers

These can be used to open per-gt debugfs files. Reviewed-by: Ashutosh Dixit Signed-off-by: Tvrtko Ursulin Signed-off-by: Vinay Belgaumkar --- lib/igt_debugfs.c | 60 +++ lib/igt_debugfs.h | 4 2 files changed, 64 insertions(+) diff --git

[Intel-gfx] [PATCH v5 i-g-t 0/4] tests/slpc: Add basic IGT test

Borrow some subtests from xe_guc_pc. Also add per GT debugfs helpers. v3: Review comments and add HAX patch v4: Modify the condition for skipping the test v5: Update the SLPC helper to per GT Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (4): lib/debugfs: Add per GT debugfs helpers lib

[Intel-gfx] [PATCH i-g-t 3/3] HAX: tests/i915: Try out the SLPC IGT tests

Trying out for CI. Do not review. Signed-off-by: Vinay Belgaumkar --- tests/intel-ci/fast-feedback.testlist | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index d9fcb62d..653668dd 100644 --- a/tests/intel-ci

[Intel-gfx] [PATCH i-g-t 2/3] i915_pm_freq_api: Add some basic SLPC igt tests

SLPC is disabled. Check for enable_guc is not sufficient as kernel config may have it but the platform doesn't actually support it. Reviewed-by: Ashutosh Dixit Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 152 ++ tests

[Intel-gfx] [PATCH i-g-t 1/3] lib/debugfs: Add per GT debugfs helpers

These can be used to open per-gt debugfs files. Reviewed-by: Ashutosh Dixit Signed-off-by: Tvrtko Ursulin Signed-off-by: Vinay Belgaumkar --- lib/igt_debugfs.c | 60 +++ lib/igt_debugfs.h | 4 2 files changed, 64 insertions(+) diff --git

[Intel-gfx] [PATCH v4 i-g-t 0/3] tests/slpc: Add basic IGT test

Borrow some subtests from xe_guc_pc. Also add per GT debugfs helpers. v3: Review comments and add HAX patch v4: Modify the condition for skipping the test Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (3): lib/debugfs: Add per GT debugfs helpers i915_pm_freq_api: Add some basic SLPC

[Intel-gfx] [PATCH i-g-t 3/3] HAX: tests/i915: Try out the SLPC IGT tests

Trying out for CI. Do not review. Signed-off-by: Vinay Belgaumkar --- tests/intel-ci/fast-feedback.testlist | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index d9fcb62d..653668dd 100644 --- a/tests/intel-ci

[Intel-gfx] [PATCH i-g-t 2/3] i915_pm_freq_api: Add some basic SLPC igt tests

-by: Ashutosh Dixit Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 151 ++ tests/meson.build | 1 + 2 files changed, 152 insertions(+) create mode 100644 tests/i915/i915_pm_freq_api.c diff --git a/tests/i915

[Intel-gfx] [PATCH i-g-t 1/3] lib/debugfs: Add per GT debugfs helpers

These can be used to open per-gt debugfs files. Reviewed-by: Ashutosh Dixit Signed-off-by: Tvrtko Ursulin Signed-off-by: Vinay Belgaumkar --- lib/igt_debugfs.c | 60 +++ lib/igt_debugfs.h | 4 2 files changed, 64 insertions(+) diff --git

[Intel-gfx] [PATCH i-g-t v3 0/3] tests/slpc: Add basic IGT test

Borrow some subtests from xe_guc_pc. Also add per GT debugfs helpers. v3: Review comments and add HAX patch Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (3): lib/debugfs: Add per GT debugfs helpers i915_pm_freq_api: Add some basic SLPC igt tests HAX: tests/i915: Try out the SLPC IGT

[Intel-gfx] [PATCH] i915/guc/slpc: Provide sysfs for efficient freq

it through this interface. Another way to disable it is to set min frequency below the efficient level. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 35 + drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 49 ++- drivers/gpu/drm/i915/gt/uc

[Intel-gfx] [PATCH i-g-t 2/2] i915_pm_freq_api: Add some basic SLPC igt tests

Validate basic api for GT freq control. Also test interaction with GT reset. We skip rps tests with SLPC enabled, this will re-introduce some coverage. SLPC selftests are already covering some other workload related scenarios. v2: Rename test (Rodrigo) Cc: Rodrigo Vivi Signed-off-by: Vinay

[Intel-gfx] [PATCH i-g-t 1/2] lib/debugfs: Add per GT debugfs helpers

These can be used to open per-gt debugfs files. Signed-off-by: Tvrtko Ursulin Signed-off-by: Vinay Belgaumkar --- lib/igt_debugfs.c | 60 +++ lib/igt_debugfs.h | 4 2 files changed, 64 insertions(+) diff --git a/lib/igt_debugfs.c b/lib

[Intel-gfx] [PATCH i-g-t 0/2] tests/slpc: Add basic IGT test

Borrow some subtests from xe_guc_pc. Also add per GT debugfs helpers. Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (2): lib/debugfs: Add per GT debugfs helpers i915_pm_freq_api: Add some basic SLPC igt tests lib/igt_debugfs.c | 60 ++ lib/igt_debugfs.h

[Intel-gfx] [PATCH i-g-t] tests/xe_guc_pc: Restore max freq first

When min/max are both at RPn, restoring min back to 300 will not work. Max needs to be increased first. Also, add igt_assert() here, which would have caught the issue. Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- tests/xe/xe_guc_pc.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[Intel-gfx] [PATCH i-g-t 1/2] lib/debugfs: Add per GT debugfs helpers

These can be used to open per-gt debugfs files. Signed-off-by: Tvrtko Ursulin Signed-off-by: Vinay Belgaumkar --- lib/igt_debugfs.c | 60 +++ lib/igt_debugfs.h | 4 2 files changed, 64 insertions(+) diff --git a/lib/igt_debugfs.c b/lib

[Intel-gfx] [PATCH i-g-t 2/2] i915_guc_pc: Add some basic SLPC igt tests

Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_guc_pc.c | 151 +++ tests/meson.build| 1 + 2 files changed, 152 insertions(+) create mode 100644 tests/i915/i915_guc_pc.c diff --git a/tests/i915/i915_guc_pc.c b/tests/i915/i915_guc_pc.c new file

[Intel-gfx] [PATCH i-g-t 0/2] tests/i915/slpc: Add basic IGT test

Borrow some subtests from xe_guc_pc. Also add per GT debugfs helpers. Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (2): lib/debugfs: Add per GT debugfs helpers i915_guc_pc: Add some basic SLPC igt tests lib/igt_debugfs.c| 60 lib/igt_debugfs.h| 4

[Intel-gfx] [PATCH] drm/i915: Fix format for perf_limit_reasons

Use hex format so that it is easier to decode. Fixes: fe5979665f64 ('Add perf_limit_reasons in debugfs') Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH i-g-t] i915_pm_rps: Enable waitboost tests for SLPC

Waitboost is supported with SLPC. Re-enable the tests so we have coverage. Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_rps.c | 8 1 file changed, 8 deletions(-) diff --git a/tests/i915/i915_pm_rps.c b/tests/i915/i915_pm_rps.c index 4865ed1f..d4ee2d58 100644 --- a/tests/i915

[Intel-gfx] [PATCH i-g-t] gem_ctx_freq: Remove reference to non-existent sysfs entry

The entry for gt_idle_freq_mhz does not exist. Fixes: d1ea62b3f759 (igt: Add gem_ctx_freq to exercise requesting freq via sysfs) Cc: Umesh Nerlige Ramappa Signed-off-by: Vinay Belgaumkar --- tests/i915/gem_ctx_freq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH] drm/i915/mtl: Connect root sysfs entries to GT0

like MTL. Fixes: a8a4f0467d70 ("drm/i915: Fix CFI violations in gt_sysfs") Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 47 +++-- 1 file changed, 6 insertions(+), 41 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_sys

[Intel-gfx] [PATCH v4] drm/i915/slpc: Use platform limits for min/max frequency

: Check softlimits instead of platform limits (Riana) v3: More review comments (Ashutosh) v4: No need to use saved_min_freq and other comments (Ashutosh) Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7030 Acked-by: Nirmoy Das Reviewed-by: Riana Tauro Signed-off-by: Vinay Belgaumkar

[Intel-gfx] [PATCH v5] drm/i915/slpc: Optmize waitboost for SLPC

in the worker thread (Tvrtko) v3: Check requested freq in dec_waiters as well v4: Only check min_softlimit against boost_freq. Limit this optimization for server parts for now. v5: min_softlimit can be greater than boost (Ashutosh) Reviewed-by: Ashutosh Dixit Signed-off-by: Vinay Belgaumkar --- drivers

[Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC

in the worker thread (Tvrtko) v3: Check requested freq in dec_waiters as well v4: Only check min_softlimit against boost_freq. Limit this optimization for server parts for now. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_rps.c | 8 +++- 1 file changed, 7 insertions(+), 1

[Intel-gfx] [PATCH v3] drm/i915/slpc: Optmize waitboost for SLPC

thread (Tvrtko) v3: Check requested freq in dec_waiters as well Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_rps.c | 3 +++ drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 14 +++--- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v2] drm/i915/slpc: Optmize waitboost for SLPC

thread (Tvrtko) Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_rps.c | 3 +++ drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 7 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c

[Intel-gfx] [PATCH] drm/i915/slpc: Optmize waitboost for SLPC

Waitboost (when SLPC is enabled) results in a H2G message. This can result in thousands of messages during a stress test and fill up an already full CTB. There is no need to request for RP0 if GuC is already requesting the same. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH v3] drm/i915/slpc: Use platform limits for min/max frequency

: Check softlimits instead of platform limits (Riana) v3: More review comments (Ashutosh) Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7030 Acked-by: Nirmoy Das Reviewed-by: Riana Tauro Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 40

[Intel-gfx] [PATCH v2] drm/i915/slpc: Use platform limits for min/max frequency

: Check softlimits instead of platform limits(Riana) Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7030 Acked-by: Nirmoy Das Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 40 +-- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 29

[Intel-gfx] [PATCH] drm/i915/slpc: Use platform limits for min/max frequency

-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 40 +-- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 29 ++ .../gpu/drm/i915/gt/uc/intel_guc_slpc_types.h | 3 ++ 3 files changed, 60 insertions(+), 12 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH v3 2/2] drm/i915/slpc: Update the frequency debugfs

Read the values stored in the SLPC structures. Remove the fields that are no longer valid (like RPS interrupts) as well. v2: Move all functionality changes to this patch (Jani) v3: Fix compile warning and if condition (Jani) Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH v3 1/2] drm/i915: Add a wrapper for frequency debugfs

Move it to the RPS source file. v2: Separate out code movement and functional changes (Jani) Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 157 + drivers/gpu/drm/i915/gt/intel_rps.c | 163 ++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH v3 0/2] drm/i915/slpc: Update frequency debugfs for SLPC

Remove the RPS related information that is not valid when SLPC is enabled. v2: Add version numbers and address other comments (Jani) v3: Fix compile warning Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (2): drm/i915: Add a wrapper for frequency debugfs drm/i915/slpc: Update

[Intel-gfx] [PATCH v2 2/2] drm/i915/slpc: Update the frequency debugfs

Read the values stored in the SLPC structures. Remove the fields that are no longer valid (like RPS interrupts) as well. v2: Move all functionality changes to this patch (Jani) Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_rps.c | 46 - 1 file

[Intel-gfx] [PATCH v2 1/2] drm/i915: Add a wrapper for frequency debugfs

Move it to the RPS source file. v2: Separate out code movement and functional changes (Jani) Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 157 + drivers/gpu/drm/i915/gt/intel_rps.c | 163 ++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2 0/2] drm/i915/slpc: Update frequency debugfs for SLPC

Remove the RPS related information that is not valid when SLPC is enabled. v2: Add version numbers and address other comments (Jani) Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (2): drm/i915: Add a wrapper for frequency debugfs drm/i915/slpc: Update the frequency debugfs drivers/gpu

[Intel-gfx] [PATCH 2/2] drm/i915/slpc: Update the frequency debugfs

Read the values stored in the SLPC structures. Remove the fields that are no longer valid (like RPS interrupts) as well. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_rps.c | 37 + 1 file changed, 37 insertions(+) diff --git a/drivers/gpu/drm

  1   2   3   >