Re: [Intel-gfx] [CI 1/5] drm/i915: Allow disabling error capture

2016-10-11 Thread Daniel Vetter
On Tue, Oct 11, 2016 at 12:56 PM, Jani Nikula wrote: > Fair enough. Please copy-paste some of the elaboration to the commit > message. Ack from me, but it wouldn't hurt to get an ack from Daniel as > well. Would be nice if we can trade in some of the #ifdefry with a

Re: [Intel-gfx] [CI 1/5] drm/i915: Allow disabling error capture

2016-10-11 Thread Jani Nikula
On Tue, 11 Oct 2016, Chris Wilson wrote: > On Tue, Oct 11, 2016 at 01:16:42PM +0300, Jani Nikula wrote: >> On Tue, 11 Oct 2016, Chris Wilson wrote: >> > On Tue, Oct 11, 2016 at 12:52:00PM +0300, Jani Nikula wrote: >> >> On Tue, 11 Oct 2016,

Re: [Intel-gfx] [CI 1/5] drm/i915: Allow disabling error capture

2016-10-11 Thread Chris Wilson
On Tue, Oct 11, 2016 at 01:16:42PM +0300, Jani Nikula wrote: > On Tue, 11 Oct 2016, Chris Wilson wrote: > > On Tue, Oct 11, 2016 at 12:52:00PM +0300, Jani Nikula wrote: > >> On Tue, 11 Oct 2016, Chris Wilson wrote: > >> > We currently capture

Re: [Intel-gfx] [CI 1/5] drm/i915: Allow disabling error capture

2016-10-11 Thread Jani Nikula
On Tue, 11 Oct 2016, Chris Wilson wrote: > On Tue, Oct 11, 2016 at 12:52:00PM +0300, Jani Nikula wrote: >> On Tue, 11 Oct 2016, Chris Wilson wrote: >> > We currently capture the GPU state after we detect a hang. This is vital >> > for us to

Re: [Intel-gfx] [CI 1/5] drm/i915: Allow disabling error capture

2016-10-11 Thread Chris Wilson
On Tue, Oct 11, 2016 at 12:52:00PM +0300, Jani Nikula wrote: > On Tue, 11 Oct 2016, Chris Wilson wrote: > > We currently capture the GPU state after we detect a hang. This is vital > > for us to both triage and debug hangs in the wild (post-mortem > > debugging).

Re: [Intel-gfx] [CI 1/5] drm/i915: Allow disabling error capture

2016-10-11 Thread Jani Nikula
On Tue, 11 Oct 2016, Chris Wilson wrote: > We currently capture the GPU state after we detect a hang. This is vital > for us to both triage and debug hangs in the wild (post-mortem > debugging). However, it comes at the cost of running some potentially > dangerous code

[Intel-gfx] [CI 1/5] drm/i915: Allow disabling error capture

2016-10-11 Thread Chris Wilson
We currently capture the GPU state after we detect a hang. This is vital for us to both triage and debug hangs in the wild (post-mortem debugging). However, it comes at the cost of running some potentially dangerous code (since it has to make very few assumption about the state of the driver) that