Re: [Intel-gfx] [PATCH] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts

2016-10-13 Thread Chris Wilson
On Thu, Oct 13, 2016 at 04:17:07PM +0200, Daniel Vetter wrote: > On Wed, Oct 12, 2016 at 07:21:44AM +0200, Maarten Lankhorst wrote: > > I don't see a nice way to do this, it probably means we shouldn't do this > > at all.. > > Maybe have a function look at > >

Re: [Intel-gfx] [PATCH] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts

2016-10-13 Thread Daniel Vetter
On Wed, Oct 12, 2016 at 07:21:44AM +0200, Maarten Lankhorst wrote: > Op 11-10-16 om 10:32 schreef Ville Syrjälä: > > On Tue, Oct 11, 2016 at 09:45:45AM +0200, Maarten Lankhorst wrote: > >> Op 11-10-16 om 08:55 schreef Ville Syrjälä: > >>> On Tue, Oct 11, 2016 at 08:17:22AM +0200, Maarten Lankhorst

Re: [Intel-gfx] [PATCH] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts

2016-10-11 Thread Maarten Lankhorst
Op 11-10-16 om 10:32 schreef Ville Syrjälä: > On Tue, Oct 11, 2016 at 09:45:45AM +0200, Maarten Lankhorst wrote: >> Op 11-10-16 om 08:55 schreef Ville Syrjälä: >>> On Tue, Oct 11, 2016 at 08:17:22AM +0200, Maarten Lankhorst wrote: Op 10-10-16 om 13:56 schreef Ville Syrjälä: > On Mon, Oct

Re: [Intel-gfx] [PATCH] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts

2016-10-11 Thread Ville Syrjälä
On Tue, Oct 11, 2016 at 09:45:45AM +0200, Maarten Lankhorst wrote: > Op 11-10-16 om 08:55 schreef Ville Syrjälä: > > On Tue, Oct 11, 2016 at 08:17:22AM +0200, Maarten Lankhorst wrote: > >> Op 10-10-16 om 13:56 schreef Ville Syrjälä: > >>> On Mon, Oct 10, 2016 at 12:46:32PM +0100, Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts

2016-10-11 Thread Maarten Lankhorst
Op 11-10-16 om 08:55 schreef Ville Syrjälä: > On Tue, Oct 11, 2016 at 08:17:22AM +0200, Maarten Lankhorst wrote: >> Op 10-10-16 om 13:56 schreef Ville Syrjälä: >>> On Mon, Oct 10, 2016 at 12:46:32PM +0100, Chris Wilson wrote: On Mon, Oct 10, 2016 at 02:42:01PM +0300, Ville Syrjälä wrote:

Re: [Intel-gfx] [PATCH] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts

2016-10-11 Thread Ville Syrjälä
On Tue, Oct 11, 2016 at 08:17:22AM +0200, Maarten Lankhorst wrote: > Op 10-10-16 om 13:56 schreef Ville Syrjälä: > > On Mon, Oct 10, 2016 at 12:46:32PM +0100, Chris Wilson wrote: > >> On Mon, Oct 10, 2016 at 02:42:01PM +0300, Ville Syrjälä wrote: > >>> On Mon, Oct 10, 2016 at 12:34:54PM +0100,

Re: [Intel-gfx] [PATCH] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts

2016-10-11 Thread Maarten Lankhorst
Op 10-10-16 om 13:56 schreef Ville Syrjälä: > On Mon, Oct 10, 2016 at 12:46:32PM +0100, Chris Wilson wrote: >> On Mon, Oct 10, 2016 at 02:42:01PM +0300, Ville Syrjälä wrote: >>> On Mon, Oct 10, 2016 at 12:34:54PM +0100, Chris Wilson wrote: To enable the vblank itself, we need to have an RPM

Re: [Intel-gfx] [PATCH] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts

2016-10-10 Thread Ville Syrjälä
On Mon, Oct 10, 2016 at 12:46:32PM +0100, Chris Wilson wrote: > On Mon, Oct 10, 2016 at 02:42:01PM +0300, Ville Syrjälä wrote: > > On Mon, Oct 10, 2016 at 12:34:54PM +0100, Chris Wilson wrote: > > > To enable the vblank itself, we need to have an RPM wakeref for the mmio > > > access, and whilst

Re: [Intel-gfx] [PATCH] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts

2016-10-10 Thread Chris Wilson
On Mon, Oct 10, 2016 at 02:42:01PM +0300, Ville Syrjälä wrote: > On Mon, Oct 10, 2016 at 12:34:54PM +0100, Chris Wilson wrote: > > To enable the vblank itself, we need to have an RPM wakeref for the mmio > > access, and whilst generating the vblank interrupts we continue to > > require the rpm

Re: [Intel-gfx] [PATCH] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts

2016-10-10 Thread Ville Syrjälä
On Mon, Oct 10, 2016 at 12:34:54PM +0100, Chris Wilson wrote: > To enable the vblank itself, we need to have an RPM wakeref for the mmio > access, and whilst generating the vblank interrupts we continue to > require the rpm wakeref. The assumption is that the RPM wakeref is held > by the display

[Intel-gfx] [PATCH] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts

2016-10-10 Thread Chris Wilson
To enable the vblank itself, we need to have an RPM wakeref for the mmio access, and whilst generating the vblank interrupts we continue to require the rpm wakeref. The assumption is that the RPM wakeref is held by the display powerwell held by the active pipe. As this chain was not obvious to me

[Intel-gfx] [PATCH] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts

2016-10-10 Thread Chris Wilson
To enable the vblank itself, we need to have an RPM wakeref for the mmio access, and whilst generating the vblank interrupts we continue to require the rpm wakeref. The assumption is that the RPM wakeref is held by the display powerwell held by the active pipe. As this chain was not obvious to me