Re: [Intel-gfx] [PATCH 2/8] drm/i915/vlv/chv: Move resume_prepare() after uncore_early_sanitize()

2015-05-19 Thread Damien Lespiau
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 5cc57f2..5a9399c 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -808,17 +808,17 @@ static int i915_drm_resume_early(struct drm_device *dev)

[Intel-gfx] [PATCH 2/8] drm/i915/vlv/chv: Move resume_prepare() after uncore_early_sanitize()

2015-05-18 Thread Damien Lespiau
It's probably a good idea to run the uncore sanitize function before vlv_resume_prepare() writes registers. At the same time, moving the debug message makes it dispay something if skl_resume_prepare ever returns non 0. Oh, and re-order the if/else ladder to have some semblence of ordering.

Re: [Intel-gfx] [PATCH 2/8] drm/i915/vlv/chv: Move resume_prepare() after uncore_early_sanitize()

2015-05-18 Thread Imre Deak
On Mon, 2015-05-18 at 19:53 +0100, Damien Lespiau wrote: It's probably a good idea to run the uncore sanitize function before vlv_resume_prepare() writes registers. At the same time, moving the debug message makes it dispay something if skl_resume_prepare ever returns non 0. Oh, and re-order