Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact:
shuang...@intel.com)
Task id: 6452
-Summary-
Platform Delta drm-intel-nightly Series Applied
PNV
We need to re-init the display hardware when going out of suspend. This
includes:
- Hooking the PCH to the reset logic
- Restoring CDCDLK
- Enabling the DDB power
Among those, only the CDCDLK one is a bit tricky. There's some
complexity in that:
- DPLL0 (which is the source for CDCLK)
On Thu, May 21, 2015 at 04:37:48PM +0100, Damien Lespiau wrote:
We need to re-init the display hardware when going out of suspend. This
includes:
- Hooking the PCH to the reset logic
- Restoring CDCDLK
- Enabling the DDB power
Among those, only the CDCDLK one is a bit tricky.
On Thu, May 21, 2015 at 06:44:53PM +0300, Ville Syrjälä wrote:
diff --git a/drivers/gpu/drm/i915/intel_ddi.c
b/drivers/gpu/drm/i915/intel_ddi.c
index d602db2..cacb07b 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2510,6 +2510,7 @@ void
On Thu, May 21, 2015 at 04:37:48PM +0100, Damien Lespiau wrote:
We need to re-init the display hardware when going out of suspend. This
includes:
- Hooking the PCH to the reset logic
- Restoring CDCDLK
- Enabling the DDB power
Among those, only the CDCDLK one is a bit tricky.
On Thu, May 21, 2015 at 06:58:48PM +0300, Ville Syrjälä wrote:
Hmm, actually are we not calling the skl_init_cdclk() on boot at all? I
see
it only in the resume path.
Yes that's correct, we always have display intialized by the firmware on
big core as far as I know (which may not
On Thu, May 21, 2015 at 04:49:40PM +0100, Damien Lespiau wrote:
On Thu, May 21, 2015 at 06:44:53PM +0300, Ville Syrjälä wrote:
diff --git a/drivers/gpu/drm/i915/intel_ddi.c
b/drivers/gpu/drm/i915/intel_ddi.c
index d602db2..cacb07b 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++
On Thu, May 21, 2015 at 05:11:57PM +0100, Damien Lespiau wrote:
On Thu, May 21, 2015 at 06:58:48PM +0300, Ville Syrjälä wrote:
Hmm, actually are we not calling the skl_init_cdclk() on boot at all? I
see
it only in the resume path.
Yes that's correct, we always have display
