Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Tear down fbdev if initialization fails

2015-11-19 Thread Lukas Wunner
Hi again, On Thu, Nov 19, 2015 at 05:02:04PM +0100, Daniel Vetter wrote: > On Wed, Nov 18, 2015 at 01:43:20PM +0100, Lukas Wunner wrote: > > --- a/drivers/gpu/drm/i915/intel_dp_mst.c > > +++ b/drivers/gpu/drm/i915/intel_dp_mst.c > > @@ -408,7 +408,10 @@ static void

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Tear down fbdev if initialization fails

2015-11-19 Thread Chris Wilson
On Thu, Nov 19, 2015 at 04:58:44PM +0100, Daniel Vetter wrote: > On Wed, Nov 18, 2015 at 04:29:51PM +0100, Lukas Wunner wrote: > > @@ -727,7 +730,8 @@ void intel_fbdev_fini(struct drm_device *dev) > > > > flush_work(_priv->fbdev_suspend_work); > > > > - async_synchronize_full(); > > +

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Tear down fbdev if initialization fails

2015-11-19 Thread Lukas Wunner
Hi Chris, On Thu, Nov 19, 2015 at 09:46:34PM +, Chris Wilson wrote: > On Thu, Nov 19, 2015 at 04:58:44PM +0100, Daniel Vetter wrote: > > On Wed, Nov 18, 2015 at 04:29:51PM +0100, Lukas Wunner wrote: > > > @@ -727,7 +730,8 @@ void intel_fbdev_fini(struct drm_device *dev) > > > > > >

[Intel-gfx] [PATCH v3 1/2] drm/i915: Tear down fbdev if initialization fails

2015-11-19 Thread Lukas Wunner
Currently if intelfb_create() errors out, it unrefs the bo even though the fb now owns that reference. (Spotted by Ville Syrjälä.) We should unref the fb instead of the bo. However the fb was not necessarily allocated by intelfb_create(), it could be inherited from BIOS (the fb struct was then

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Tear down fbdev if initialization fails

2015-11-19 Thread Daniel Vetter
On Wed, Nov 18, 2015 at 04:29:51PM +0100, Lukas Wunner wrote: > Currently if intelfb_create() errors out, it unrefs the bo even though > the fb now owns that reference. (Spotted by Ville Syrjälä.) We should > unref the fb instead of the bo. > > However the fb was not necessarily allocated by

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Tear down fbdev if initialization fails

2015-11-19 Thread Lukas Wunner
Hi, On Thu, Nov 19, 2015 at 04:58:44PM +0100, Daniel Vetter wrote: > On Wed, Nov 18, 2015 at 04:29:51PM +0100, Lukas Wunner wrote: > > Currently if intelfb_create() errors out, it unrefs the bo even though > > the fb now owns that reference. (Spotted by Ville Syrjälä.) We should > > unref the fb