[PATCHv3] drm/xe/display: use mul_u32_u32 for multiplying operands

2024-04-09 Thread Arun R Murthy
Use mul_u32_u32 to avoid potential overflow in multiplying two u32 and store the u64 result. v2: remove u64 typecast and use mul_u32_u32 (Ville) v3: Reframe the commit message Signed-off-by: Arun R Murthy --- drivers/gpu/drm/xe/display/xe_fb_pin.c | 10 +- 1 file changed, 5

Re: [PATCH] drm/i915: Don't enable hwmon for selftests

2024-04-09 Thread Nilawar, Badal
On 10-04-2024 09:58, Ashutosh Dixit wrote: There are no hwmon selftests so there is no need to enable hwmon for selftests. So enable hwmon only for real driver load. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10366 Signed-off-by: Ashutosh Dixit LGTM. Reviewed-by: Badal

[PATCH v2 3/3] drm/915/lspcon: Reduce dmesg errors during lspcon_init failure

2024-04-09 Thread Ankit Nautiyal
Currently lspcon_resume calls lspcon_init and in case of failure we get error messages from lspcon_init and then again from lspcon_resume. Just have a single error message in lspcon_init. v2: Add the relavant info with each error, and avoid mix of dbg and error messages. (Jani) Signed-off-by:

✗ Fi.CI.CHECKPATCH: warning for drm/xe/display: use mul_u32_u32 for multiplying operands

2024-04-09 Thread Patchwork
== Series Details == Series: drm/xe/display: use mul_u32_u32 for multiplying operands URL : https://patchwork.freedesktop.org/series/132241/ State : warning == Summary == Error: dim checkpatch failed 39c1a67defad drm/xe/display: use mul_u32_u32 for multiplying operands -:23:

Re: [PATCH] drm/i915: Don't enable hwmon for selftests

2024-04-09 Thread Dixit, Ashutosh
On Tue, 09 Apr 2024 21:28:55 -0700, Ashutosh Dixit wrote: > > There are no hwmon selftests so there is no need to enable hwmon for > selftests. So enable hwmon only for real driver load. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10366 This will resolve this CI issue for now

linux-next: manual merge of the drm-xe tree with the drm-intel tree

2024-04-09 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-xe tree got a conflict in: drivers/gpu/drm/xe/xe_device_types.h between commits: ded402c7a044 ("drm/i915: move skl_preferred_vco_freq to display substruct") 8219ab6d6f0d ("drm/i915: move max_dotclk_freq to display substruct") 9aad73290686

✓ Fi.CI.BAT: success for drm/xe/display: use mul_u32_u32 for multiplying operands

2024-04-09 Thread Patchwork
== Series Details == Series: drm/xe/display: use mul_u32_u32 for multiplying operands URL : https://patchwork.freedesktop.org/series/132241/ State : success == Summary == CI Bug Log - changes from CI_DRM_14552 -> Patchwork_132241v1 Summary

✓ Fi.CI.BAT: success for Avoid unwanted lspcon init and probe warnings (rev3)

2024-04-09 Thread Patchwork
== Series Details == Series: Avoid unwanted lspcon init and probe warnings (rev3) URL : https://patchwork.freedesktop.org/series/131491/ State : success == Summary == CI Bug Log - changes from CI_DRM_14552 -> Patchwork_131491v3 Summary

[PATCH] drm/i915: Don't enable hwmon for selftests

2024-04-09 Thread Ashutosh Dixit
There are no hwmon selftests so there is no need to enable hwmon for selftests. So enable hwmon only for real driver load. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10366 Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/i915_driver.c | 16 ++-- 1 file changed,

[PATCH] drm/i915: Don't enable hwmon for selftests

2024-04-09 Thread Ashutosh Dixit
There are no hwmon selftests so there is no need to enable hwmon for selftests. So enable hwmon only for real driver load. v2: Move the logic inside i915_hwmon.c Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10366 Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/i915_hwmon.c

Re: [PATCH] drm/i915: Don't enable hwmon for selftests

2024-04-09 Thread Nilawar, Badal
On 10-04-2024 10:28, Ashutosh Dixit wrote: There are no hwmon selftests so there is no need to enable hwmon for selftests. So enable hwmon only for real driver load. v2: Move the logic inside i915_hwmon.c Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10366 Signed-off-by:

✗ Fi.CI.BAT: failure for drm/i915: Don't enable hwmon for selftests

2024-04-09 Thread Patchwork
== Series Details == Series: drm/i915: Don't enable hwmon for selftests URL : https://patchwork.freedesktop.org/series/132243/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14552 -> Patchwork_132243v1 Summary ---

[PATCH v8 4/6] drm/{i915,xe}: Unregister in-kernel clients

2024-04-09 Thread Thomas Zimmermann
Unregister all in-kernel clients before unloading the i915 driver. For other drivers, drm_dev_unregister() does this automatically. As i915 and xe do not use this helper, they have to perform the call by themselves. Note that there are currently no in-kernel clients in i915 or xe. The patch

[PATCH v8 6/6] drm/{i915, xe}: Implement fbdev emulation as in-kernel client

2024-04-09 Thread Thomas Zimmermann
Replace all code that initializes or releases fbdev emulation throughout the driver. Instead initialize the fbdev client by a single call to intel_fbdev_setup() after i915 has registered its DRM device. Just like similar code in other drivers, i915 fbdev emulation now acts like a regular DRM

[PATCH v8 5/6] drm/{i915,xe}: Implement fbdev client callbacks

2024-04-09 Thread Thomas Zimmermann
Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform

[PATCH v8 2/6] drm/i915: Move fbdev functions

2024-04-09 Thread Thomas Zimmermann
Move functions within intel_fbdev.c to simplify later updates. Minor style fixes to make checkpatch happy, but no functional changes. v5: - style fixes (checkpatch) Signed-off-by: Thomas Zimmermann Reviewed-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_fbdev.c | 154

[PATCH v8 1/6] drm/client: Export drm_client_dev_unregister()

2024-04-09 Thread Thomas Zimmermann
Export drm_client_dev_unregister() for use by the i915 driver. The driver does not use drm_dev_unregister(), so it has to clean up the in-kernel DRM clients by itself. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_client.c | 13 + 1 file changed, 13 insertions(+) diff

[PATCH v8 3/6] drm/i915: Initialize fbdev DRM client with callback functions

2024-04-09 Thread Thomas Zimmermann
Initialize i915's fbdev client by giving an instance of struct drm_client_funcs to drm_client_init(). Also clean up with drm_client_release(). Doing this in i915 prevents fbdev helpers from initializing and releasing the client internally (see drm_fb_helper_init()). No functional change yet; the

[PATCH v8 0/6] drm/{i915,xe}: Convert fbdev to DRM client

2024-04-09 Thread Thomas Zimmermann
(was: drm/i915: Convert fbdev to DRM client) Convert i915's fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. Also update the xe driver accordingly. As with the other drivers' fbdev emulation, fbdev in i915 is now an in-kernel

Re: [PATCH v1 1/1] iommu/vt-d: Fix WARN_ON in iommu probe path

2024-04-09 Thread Govindapillai, Vinod
+Jani On Tue, 2024-04-09 at 12:36 +0300, Vinod Govindapillai wrote: > From: Lu Baolu > > Commit 1a75cc710b95 ("iommu/vt-d: Use rbtree to track iommu probed > devices") adds all devices probed by the iommu driver in a rbtree > indexed by the source ID of each device. It assumes that each device

[PATCH v1 1/1] iommu/vt-d: Fix WARN_ON in iommu probe path

2024-04-09 Thread Vinod Govindapillai
From: Lu Baolu Commit 1a75cc710b95 ("iommu/vt-d: Use rbtree to track iommu probed devices") adds all devices probed by the iommu driver in a rbtree indexed by the source ID of each device. It assumes that each device has a unique source ID. This assumption is incorrect and the VT-d spec doesn't

[PATCH v1 0/1] iommu/vt-d: Fix WARN_ON in iommu probe path

2024-04-09 Thread Vinod Govindapillai
This has already been sent to try bot https://patchwork.freedesktop.org/series/132132/ Lu Baolu (1): iommu/vt-d: Fix WARN_ON in iommu probe path drivers/iommu/intel/iommu.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) -- 2.34.1

Re: [PATCH 2/4] drm/edid: add drm_edid_print_product_id()

2024-04-09 Thread Jani Nikula
On Mon, 08 Apr 2024, Ville Syrjälä wrote: > On Thu, Mar 21, 2024 at 12:05:10PM +0200, Jani Nikula wrote: >> Add a function to print a decoded EDID vendor and product id to a drm >> printer, optinally with the raw data. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/drm_edid.c | 35

✓ Fi.CI.BAT: success for drm/{i915,xe}: Convert fbdev to DRM client

2024-04-09 Thread Patchwork
== Series Details == Series: drm/{i915,xe}: Convert fbdev to DRM client URL : https://patchwork.freedesktop.org/series/132192/ State : success == Summary == CI Bug Log - changes from CI_DRM_14547 -> Patchwork_132192v1 Summary ---

[PATCH v2 0/4] drm/edid & drm/i915: vendor and product id logging improvements

2024-04-09 Thread Jani Nikula
v2 with __be16 manufacturer_name in patch 1 and revamped date printing in patch 2. Jani Nikula (4): drm/edid: add drm_edid_get_product_id() drm/edid: add drm_edid_print_product_id() drm/i915/bios: switch to struct drm_edid and struct drm_edid_product_id drm/i915/bios: return

✗ Fi.CI.SPARSE: warning for series starting with [CI-only,1/4] drm: Add drm_vblank_work_flush_all().

2024-04-09 Thread Patchwork
== Series Details == Series: series starting with [CI-only,1/4] drm: Add drm_vblank_work_flush_all(). URL : https://patchwork.freedesktop.org/series/132196/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH] drm/i915/audio: 'scheduling while atomic' during system resume

2024-04-09 Thread Jani Nikula
On Tue, 09 Apr 2024, Brent Lu wrote: > The i915_audio_component_codec_wake_override() function will be called > during resume process so replace usleep_range() function calls with > udelay() to avoid the 'scheduling while atomic' error. That explanation does not hold water. For example, what

Re: [PATCH] drm/i915: use check_add_overflow() and drop local variants

2024-04-09 Thread Jani Nikula
On Mon, 08 Apr 2024, Rodrigo Vivi wrote: > On Fri, Apr 05, 2024 at 11:26:25PM +0300, Jani Nikula wrote: >> Prefer common check_add_overflow() from overflow.h over the locally >> rolled versions of it. While check_add_overflow() does require a >> variable to assign to, unlike add_overflows_t(),

✗ Fi.CI.CHECKPATCH: warning for series starting with [CI-only,1/4] drm: Add drm_vblank_work_flush_all().

2024-04-09 Thread Patchwork
== Series Details == Series: series starting with [CI-only,1/4] drm: Add drm_vblank_work_flush_all(). URL : https://patchwork.freedesktop.org/series/132196/ State : warning == Summary == Error: dim checkpatch failed a33c1c2e9370 drm: Add drm_vblank_work_flush_all(). -:33:

Re: [PATCH 0/8] drm/i915: drm_i915_private and xe_device cleanups

2024-04-09 Thread Jani Nikula
On Mon, 08 Apr 2024, Lucas De Marchi wrote: > On Tue, Apr 09, 2024 at 12:02:17AM +0300, Jani Nikula wrote: >>On Mon, 08 Apr 2024, Jani Nikula wrote: >>> Continue cleaning up the members from drm_i915_private and xe_device to >>> struct intel_display. >> >>Lucas, there's a bunch of xe changes

[PATCH] drm/i915/psr: Use crtc_state->port_clock instead of intel_dp->link_rate

2024-04-09 Thread Jouni Högander
Intel_dp->link_rate is not yet set at this point. Instead use crtc_state->port_clock. Fixes: 0dd21f836983 ("drm/i915/psr: Silence period and lfps half cycle") Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v2 4/4] drm/i915/bios: return drm_edid_product_id from get_lvds_pnp_id()

2024-04-09 Thread Jani Nikula
Use a more suitable type to avoid the cast. Cc: Ville Syrjälä Acked-by: Melissa Wen Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c

[PATCH v2 2/4] drm/edid: add drm_edid_print_product_id()

2024-04-09 Thread Jani Nikula
Add a function to print a decoded EDID vendor and product id to a drm printer, optionally with the raw data. v2: - refactor date printing - use seq_buf to avoid kasprintf() (Ville) - handle week == 0 (Ville) - use be16_to_cpu() on manufacturer_name Cc: Ville Syrjälä Acked-by: Melissa Wen # v1

[PATCH v2 3/4] drm/i915/bios: switch to struct drm_edid and struct drm_edid_product_id

2024-04-09 Thread Jani Nikula
To avoid accessing and parsing the raw EDID with drm_edid_raw(), switch to the struct drm_edid based function to extract product id, and use the drm printer function to debug log it. The underlying assumption is that struct drm_edid_product_id and struct lvds_pnp_id describe identical data,

[PATCH v2 1/4] drm/edid: add drm_edid_get_product_id()

2024-04-09 Thread Jani Nikula
Add a struct drm_edid based function to get the vendor and product ID from an EDID. Add a separate struct for defining this part of the EDID, with defined byte order for product code and serial number. v2: Define manufacturer_name as __be16 instead of u8[2] (Ville) Cc: Ville Syrjälä Acked-by:

✗ Fi.CI.SPARSE: warning for drm/{i915,xe}: Convert fbdev to DRM client

2024-04-09 Thread Patchwork
== Series Details == Series: drm/{i915,xe}: Convert fbdev to DRM client URL : https://patchwork.freedesktop.org/series/132192/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH 11/12] drm/client: Streamline mode selection debugs

2024-04-09 Thread Thomas Zimmermann
Hi Am 08.04.24 um 19:26 schrieb Ville Syrjälä: On Mon, Apr 08, 2024 at 09:46:44AM +0200, Thomas Zimmermann wrote: Hi Am 05.04.24 um 21:58 schrieb Ville Syrjälä: On Fri, Apr 05, 2024 at 09:57:07AM +0200, Thomas Zimmermann wrote: Hi Am 04.04.24 um 22:33 schrieb Ville Syrjala: From: Ville

[CI-only 4/4] drm/i915: Hack to check use-after-free aggressively, and undo purpose of patches

2024-04-09 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_crtc.c | 2 +- drivers/gpu/drm/i915/display/intel_cursor.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c b/drivers/gpu/drm/i915/display/intel_crtc.c index

[CI-only 3/4] drm/i915: Use the same vblank worker for atomic unpin

2024-04-09 Thread Maarten Lankhorst
In case of legacy cursor update, the cursor VMA needs to be unpinned only after vblank. This exceeds the lifetime of the whole atomic commit. Any trick I attempted to keep the atomic commit alive didn't work, as drm_atomic_helper_setup_commit() force throttles on any old commit that wasn't

[CI-only 1/4] drm: Add drm_vblank_work_flush_all().

2024-04-09 Thread Maarten Lankhorst
In some cases we want to flush all vblank work, right before vblank_off for example. Add a simple function to make this possible. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_vblank_work.c | 22 ++ include/drm/drm_vblank_work.h | 2 ++ 2 files changed, 24

[CI-only 2/4] drm/i915: Use vblank worker to unpin old legacy cursor fb safely

2024-04-09 Thread Maarten Lankhorst
From: Ville Syrjälä The cursor hardware only does sync updates, and thus the hardware will be scanning out from the old fb until the next start of vblank. So in order to make the legacy cursor fastpath actually safe we should not unpin the old fb until we're sure the hardware has ceased

Re: [PATCH 1/4] drm/edid: add drm_edid_get_product_id()

2024-04-09 Thread Jani Nikula
On Mon, 08 Apr 2024, Ville Syrjälä wrote: > On Thu, Mar 21, 2024 at 12:05:09PM +0200, Jani Nikula wrote: >> Add a struct drm_edid based function to get the vendor and product ID >> from an EDID. Add a separate struct for defining this part of the EDID, >> with defined byte order for product code

✓ Fi.CI.BAT: success for drm/i915/audio: 'scheduling while atomic' during system resume

2024-04-09 Thread Patchwork
== Series Details == Series: drm/i915/audio: 'scheduling while atomic' during system resume URL : https://patchwork.freedesktop.org/series/132187/ State : success == Summary == CI Bug Log - changes from CI_DRM_14546 -> Patchwork_132187v1

✗ Fi.CI.CHECKPATCH: warning for drm/i915/audio: 'scheduling while atomic' during system resume

2024-04-09 Thread Patchwork
== Series Details == Series: drm/i915/audio: 'scheduling while atomic' during system resume URL : https://patchwork.freedesktop.org/series/132187/ State : warning == Summary == Error: dim checkpatch failed f51aab733cbc drm/i915/audio: 'scheduling while atomic' during system resume -:41:

✓ Fi.CI.BAT: success for series starting with [CI-only,1/4] drm: Add drm_vblank_work_flush_all().

2024-04-09 Thread Patchwork
== Series Details == Series: series starting with [CI-only,1/4] drm: Add drm_vblank_work_flush_all(). URL : https://patchwork.freedesktop.org/series/132196/ State : success == Summary == CI Bug Log - changes from CI_DRM_14547 -> Patchwork_132196v1

✗ Fi.CI.BAT: failure for drm/i915/psr: Use crtc_state->port_clock instead of intel_dp->link_rate

2024-04-09 Thread Patchwork
== Series Details == Series: drm/i915/psr: Use crtc_state->port_clock instead of intel_dp->link_rate URL : https://patchwork.freedesktop.org/series/132198/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14548 -> Patchwork_132198v1

[PATCH v3 0/7] drm/i915: better high level abstraction for display

2024-04-09 Thread Jani Nikula
v3 of [1], and no longer an RFC. This is just initial plumbing, and not much in terms of usage (apart from patch 7). We could start converting a number of places already, but the main blocker atm is that I haven't figured out a decent solution for the various IS_() check macros. I'm

[PATCH v3 2/7] drm/i915/display: add generic to_intel_display() macro

2024-04-09 Thread Jani Nikula
Convert various pointers to struct intel_display * using _Generic(). Add some macro magic to make adding new conversions easier, and somewhat abstract the need to cast each generic association. The cast is required because all associations needs to compile, regardless of the type and the generic

[PATCH v3 1/7] drm/i915/display: add intel_display -> drm_device backpointer

2024-04-09 Thread Jani Nikula
As a baby step towards making struct intel_display the main data structure for display, add a backpointer to struct drm_device that can be used instead of >drm. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_core.h | 3 +++

✗ Fi.CI.BAT: failure for iommu/vt-d: Fix WARN_ON in iommu probe path

2024-04-09 Thread Patchwork
== Series Details == Series: iommu/vt-d: Fix WARN_ON in iommu probe path URL : https://patchwork.freedesktop.org/series/132199/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14548 -> Patchwork_132199v1 Summary ---

Re: [PATCH 05/10] drm/i915: skip DRM_I915_LOW_LEVEL_TRACEPOINTS with NOTRACE

2024-04-09 Thread Sebastian Andrzej Siewior
On 2024-04-08 13:06:50 [-0400], Steven Rostedt wrote: > On Fri, 5 Apr 2024 16:18:23 +0200 > Sebastian Andrzej Siewior wrote: > > > The order of the header files is important. If this header file is > > included after tracepoint.h was included then the NOTRACE here becomes a > > nop. Currently

[PATCH v3 6/7] drm/i915/de: allow intel_display and drm_i915_private for de functions

2024-04-09 Thread Jani Nikula
It would be too much noise to convert the intel_de_* functions from using struct drm_i915_private to struct intel_display all at once. Add generic wrappers using __to_intel_display() to accept both. Signed-off-by: Jani Nikula --- This was done using a cocci + shell script combo. ---

[PATCH v3 7/7] drm/i915/quirks: convert struct drm_i915_private to struct intel_display

2024-04-09 Thread Jani Nikula
Use struct intel_display instead of struct drm_i915_private for quirks. Also do drive-by conversions in call sites of intel_has_quirk(). Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_backlight.c| 40 ++--- drivers/gpu/drm/i915/display/intel_ddi.c | 6 +-

[PATCH v3 4/7] drm/xe/display: add generic __to_intel_display()

2024-04-09 Thread Jani Nikula
Add generic __to_intel_display() macro that accepts either struct xe_device * or struct intel_display *. This is to be used for transitional stuff that eventually needs to be converted to use struct intel_display *, and therefore is not part of to_intel_display(). Signed-off-by: Jani Nikula ---

[PATCH v3 5/7] drm/i915/display: accept either i915 or display for feature tests

2024-04-09 Thread Jani Nikula
Use the generic __to_intel_display() to allow passing either struct drm_i915_private * or struct intel_display * to the feature test macros. Unfortunately, this requires including i915_drv.h in xe display code. This is still better than polluting the main xe_device.h or xe_device_types.h files

[PATCH v3 3/7] drm/i915: add generic __to_intel_display()

2024-04-09 Thread Jani Nikula
Add generic __to_intel_display() macro that accepts either struct drm_i915_private * or struct intel_display *. This is to be used for transitional stuff that eventually needs to be converted to use struct intel_display *, and therefore is not part of to_intel_display(). Signed-off-by: Jani

✗ Fi.CI.CHECKPATCH: warning for drm: debug logging improvements (rev4)

2024-04-09 Thread Patchwork
== Series Details == Series: drm: debug logging improvements (rev4) URL : https://patchwork.freedesktop.org/series/130881/ State : warning == Summary == Error: dim checkpatch failed abe41cbc12aa drm/probe-helper: switch to drm device based logging 1415ab71126a drm/modes: switch to drm device

✗ Fi.CI.SPARSE: warning for drm: debug logging improvements (rev4)

2024-04-09 Thread Patchwork
== Series Details == Series: drm: debug logging improvements (rev4) URL : https://patchwork.freedesktop.org/series/130881/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: better high level abstraction for display (rev2)

2024-04-09 Thread Patchwork
== Series Details == Series: drm/i915: better high level abstraction for display (rev2) URL : https://patchwork.freedesktop.org/series/130805/ State : warning == Summary == Error: dim checkpatch failed dac86e84fa8c drm/i915/display: add intel_display -> drm_device backpointer 40e8d033ff3c

✗ Fi.CI.SPARSE: warning for drm/i915: better high level abstraction for display (rev2)

2024-04-09 Thread Patchwork
== Series Details == Series: drm/i915: better high level abstraction for display (rev2) URL : https://patchwork.freedesktop.org/series/130805/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for drm/i915: better high level abstraction for display (rev2)

2024-04-09 Thread Patchwork
== Series Details == Series: drm/i915: better high level abstraction for display (rev2) URL : https://patchwork.freedesktop.org/series/130805/ State : success == Summary == CI Bug Log - changes from CI_DRM_14549 -> Patchwork_130805v2

✓ Fi.CI.BAT: success for drm: debug logging improvements (rev4)

2024-04-09 Thread Patchwork
== Series Details == Series: drm: debug logging improvements (rev4) URL : https://patchwork.freedesktop.org/series/130881/ State : success == Summary == CI Bug Log - changes from CI_DRM_14549 -> Patchwork_130881v4 Summary ---

✗ Fi.CI.CHECKPATCH: warning for Add support for partial mapping (rev2)

2024-04-09 Thread Patchwork
== Series Details == Series: Add support for partial mapping (rev2) URL : https://patchwork.freedesktop.org/series/131817/ State : warning == Summary == Error: dim checkpatch failed 74cd74a512ce drm/i915/gem: Increment vma offset when mapping fb objects 8cd734168568 drm/i915/gem: Calculate

Re: [PATCH v2 3/4] drm/i915/bios: switch to struct drm_edid and struct drm_edid_product_id

2024-04-09 Thread Ville Syrjälä
On Tue, Apr 09, 2024 at 12:46:11PM +0300, Jani Nikula wrote: > To avoid accessing and parsing the raw EDID with drm_edid_raw(), switch > to the struct drm_edid based function to extract product id, and use the > drm printer function to debug log it. > > The underlying assumption is that struct

[CI-only 1/3] drm: Add drm_vblank_work_flush_all().

2024-04-09 Thread Maarten Lankhorst
In some cases we want to flush all vblank work, right before vblank_off for example. Add a simple function to make this possible. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_vblank_work.c | 22 ++ include/drm/drm_vblank_work.h | 2 ++ 2 files changed, 24

[CI-only 2/3] drm/i915: Use vblank worker to unpin old legacy cursor fb safely

2024-04-09 Thread Maarten Lankhorst
From: Ville Syrjälä The cursor hardware only does sync updates, and thus the hardware will be scanning out from the old fb until the next start of vblank. So in order to make the legacy cursor fastpath actually safe we should not unpin the old fb until we're sure the hardware has ceased

[CI-only 3/3] drm/i915: Use the same vblank worker for atomic unpin

2024-04-09 Thread Maarten Lankhorst
In case of legacy cursor update, the cursor VMA needs to be unpinned only after vblank. This exceeds the lifetime of the whole atomic commit. Any trick I attempted to keep the atomic commit alive didn't work, as drm_atomic_helper_setup_commit() force throttles on any old commit that wasn't

✗ Fi.CI.SPARSE: warning for drm/edid & drm/i915: vendor and product id logging improvements (rev2)

2024-04-09 Thread Patchwork
== Series Details == Series: drm/edid & drm/i915: vendor and product id logging improvements (rev2) URL : https://patchwork.freedesktop.org/series/131414/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for drm/edid & drm/i915: vendor and product id logging improvements (rev2)

2024-04-09 Thread Patchwork
== Series Details == Series: drm/edid & drm/i915: vendor and product id logging improvements (rev2) URL : https://patchwork.freedesktop.org/series/131414/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14549 -> Patchwork_131414v2

Re: [PATCH 1/5] drm/vblank: Introduce drm_crtc_vblank_crtc()

2024-04-09 Thread Dmitry Baryshkov
On Mon, Apr 08, 2024 at 10:06:07PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Make life easier by providing a function that hands > out the the correct drm_vblank_crtc for a given a drm_crtc. > > Also abstract the lower level internals of the vblank > code in a similar fashion. > >

✗ Fi.CI.BAT: failure for Add support for partial mapping (rev2)

2024-04-09 Thread Patchwork
== Series Details == Series: Add support for partial mapping (rev2) URL : https://patchwork.freedesktop.org/series/131817/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14549 -> Patchwork_131817v2 Summary ---

Re: [PATCH 05/10] drm/i915: skip DRM_I915_LOW_LEVEL_TRACEPOINTS with NOTRACE

2024-04-09 Thread Steven Rostedt
On Tue, 9 Apr 2024 13:06:01 +0200 Sebastian Andrzej Siewior wrote: > among a few other things I was not aware of. > So yes, this patch is not needed since it makes no difference but I still > have trace points I would rather not have. > If you a clue how to deal with this properly, I am all

✗ Fi.CI.SPARSE: warning for series starting with [CI-only,1/3] drm: Add drm_vblank_work_flush_all().

2024-04-09 Thread Patchwork
== Series Details == Series: series starting with [CI-only,1/3] drm: Add drm_vblank_work_flush_all(). URL : https://patchwork.freedesktop.org/series/132221/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for series starting with [CI-only,1/3] drm: Add drm_vblank_work_flush_all().

2024-04-09 Thread Patchwork
== Series Details == Series: series starting with [CI-only,1/3] drm: Add drm_vblank_work_flush_all(). URL : https://patchwork.freedesktop.org/series/132221/ State : warning == Summary == Error: dim checkpatch failed dc20857fd137 drm: Add drm_vblank_work_flush_all(). -:33:

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Bigjoiner modeset sequence redesign and MST support (rev4)

2024-04-09 Thread Patchwork
== Series Details == Series: drm/i915: Bigjoiner modeset sequence redesign and MST support (rev4) URL : https://patchwork.freedesktop.org/series/131797/ State : warning == Summary == Error: dim checkpatch failed 23cbdc3c0fd4 drm/i915: Extract intel_ddi_post_disable_hdmi_or_sst() 05502b938cf4

[PATCH v3 6/6] drm/i915: Allow bigjoiner for MST

2024-04-09 Thread Ville Syrjala
From: Vidya Srinivas We need bigjoiner support with MST functionality for MST monitor resolutions > 5K to work. Adding support for the same. v2: Addressed review comments from Jani. Revert rejection of MST bigjoiner modes and add functionality v3: Fixed pipe_mismatch WARN for

[PATCH v3 5/6] drm/i915/mst: Add bigjoiner handling to MST modeset sequence

2024-04-09 Thread Ville Syrjala
From: Ville Syrjälä Loop over all joined pipes at relevant points in the MST modeset sequence. Carved out from Vidya's earlier big patch, with naming/etc. changed to match the earlier hsw_crtc_enable() stuff. Reviewed-by: Arun R Murthy Co-developed-by: Vidya Srinivas Signed-off-by: Vidya

✓ Fi.CI.BAT: success for series starting with [CI-only,1/3] drm: Add drm_vblank_work_flush_all().

2024-04-09 Thread Patchwork
== Series Details == Series: series starting with [CI-only,1/3] drm: Add drm_vblank_work_flush_all(). URL : https://patchwork.freedesktop.org/series/132221/ State : success == Summary == CI Bug Log - changes from CI_DRM_14550 -> Patchwork_132221v1

[linux-next:master] BUILD REGRESSION a053fd3ca5d1b927a8655f239c84b0d790218fda

2024-04-09 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: a053fd3ca5d1b927a8655f239c84b0d790218fda Add linux-next specific files for 20240409 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202404091516.9h8idamm-...@intel.com https

[PATCH v3 2/6] drm/i915: Utilize intel_crtc_joined_pipe_mask() more

2024-04-09 Thread Ville Syrjala
From: Ville Syrjälä Unify the master vs. slave handling in intel_ddi_post_disable_hdmi_or_sst() by looping over all the pipes in one go. This also lets us move the intel_crtc_vblank_off() calls to happen in a consistent place vs. the transcoder disable. Previously we did the master vs. slaves

[PATCH v3 4/6] drm/i915: Handle joined pipes inside hsw_crtc_enable()

2024-04-09 Thread Ville Syrjala
From: Stanislav Lisovskiy Handle only bigjoiner masters in skl_commit_modeset_enables/disables, slave crtcs should be handled by master hooks. Same for encoders. That way we can also remove a bunch of checks like intel_crtc_is_bigjoiner_slave. v2: - Moved skl_pfit_enable, intel_dsc_enable,

[PATCH v3 0/6] drm/i915: Bigjoiner modeset sequence redesign and MST support

2024-04-09 Thread Ville Syrjala
From: Ville Syrjälä Final pieces of the MST/bigjoiner modedest redesign. Changes in v2: - Reject PSR+bigjoiner combo - Commit pipes in reverse order to avoid issues with slave pipe commits being completed prematurely. Should fix the gamma/DSB problems of v1. - Address review comments - Part

[PATCH v3 1/6] drm/i915: Extract intel_ddi_post_disable_hdmi_or_sst()

2024-04-09 Thread Ville Syrjala
From: Ville Syrjälä Extract the "not-MST" stuff from intel_ddi_post_disable() so that the whole thing isn't so cluttered. The bigjoiner slave handling was outside of the !MST check, but it really should have been inside it as its the counterpart to the master handling inside the check. So we

[PATCH v3 3/6] drm/i915: Handle joined pipes inside hsw_crtc_disable()

2024-04-09 Thread Ville Syrjala
From: Ville Syrjälä Reorganize the crtc disable path to only deal with the master pipes/transcoders in intel_old_crtc_state_disables() and offload the handling of joined pipes to hsw_crtc_disable(). This makes the whole thing much more sensible since we can actually control the order in which we

✗ Fi.CI.SPARSE: warning for drm/i915: Bigjoiner modeset sequence redesign and MST support (rev4)

2024-04-09 Thread Patchwork
== Series Details == Series: drm/i915: Bigjoiner modeset sequence redesign and MST support (rev4) URL : https://patchwork.freedesktop.org/series/131797/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for drm/i915: Bigjoiner modeset sequence redesign and MST support (rev4)

2024-04-09 Thread Patchwork
== Series Details == Series: drm/i915: Bigjoiner modeset sequence redesign and MST support (rev4) URL : https://patchwork.freedesktop.org/series/131797/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14550 -> Patchwork_131797v4