Re: [PATCH v2 03/12] drm/i915: Make I2C terminology more inclusive

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Rodrigo Vivi wrote: > On Fri, May 03, 2024 at 02:04:15PM -0700, Easwar Hariharan wrote: >> On 5/3/2024 12:34 PM, Rodrigo Vivi wrote: >> > On Fri, May 03, 2024 at 06:13:24PM +, Easwar Hariharan wrote: >> >> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced >>

Re: [PATCH 17/19] drm/i915: pass dev_priv explicitly to ALPM_CTL2

2024-05-06 Thread Jani Nikula
On Mon, 06 May 2024, "Hogander, Jouni" wrote: > On Thu, 2024-05-02 at 13:40 +0300, Jani Nikula wrote: >> On Tue, 30 Apr 2024, Rodrigo Vivi wrote: >> > On Tue, Apr 30, 2024 at 01:10:11PM +0300, Jani Nikula wrote: >> > > Avoid the implicit dev_priv local variable use, and pass dev_priv >> > >

Re: [PATCH 03/35] drm/i915/bios: Indicate which VBT structures are based on EDID

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > VBT reuses a bunch of EDID data structures. Flag those as such > for clarity. > > I chose "bdb_edid_" as the namespace for these. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

Re: [PATCH 17/19] drm/i915: pass dev_priv explicitly to ALPM_CTL2

2024-05-06 Thread Hogander, Jouni
On Thu, 2024-05-02 at 13:40 +0300, Jani Nikula wrote: > On Tue, 30 Apr 2024, Rodrigo Vivi wrote: > > On Tue, Apr 30, 2024 at 01:10:11PM +0300, Jani Nikula wrote: > > > Avoid the implicit dev_priv local variable use, and pass dev_priv > > > explicitly to the ALPM_CTL2 register macro. > > > > > >

Re: [PATCH 4/5] refcount: Introduce refcount_long_t and APIs

2024-05-06 Thread kernel test robot
enabled at (263164): release_sock (net/core/sock.c:3560) [ 2.725080][ T1] softirqs last disabled at (263162): release_sock (net/core/sock.c:3549) [2.726210][T1] ---[ end trace ]--- The kernel config and materials to reproduce are available at: https://d

Re: [PATCH 01/35] drm/i915/bios: Define eDP DSC disable bit

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > There's a new "DSC disable" bit in the eDP VBT block. Define it. > > TODO: actually use it? Probably should. > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_vbt_defs.h |

RE: [PATCH] drm/i915/display: Calculate crtc clock rate based on PLL parameters

2024-05-06 Thread Kahola, Mika
> -Original Message- > From: Deak, Imre > Sent: Friday, May 3, 2024 2:00 PM > To: Kahola, Mika > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/i915/display: Calculate crtc clock rate based on PLL > parameters > > On Thu, May 02, 2024 at 04:17:16PM +0300, Mika Kahola

Re: [PATCH 04/35] drm/i915/bios: Get rid of "LVDS" from all LFP data stuff

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > The LFP data applies to all kinds of display interfaces, so > stop calling things by the "LVDS" name. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula However... > @@ -902,11 +902,11 @@ struct lfp_brightness_level

RE: [PATCH] drm/i915/display: Introduce Display Metrics info

2024-05-06 Thread Kumar, Naveen1
>-Original Message- >From: Vivi, Rodrigo >Sent: Saturday, April 6, 2024 3:39 AM >To: intel-gfx@lists.freedesktop.org >Cc: Vivi, Rodrigo ; Shankar, Uma >; Kulkarni, Vandita ; >Kumar, Naveen1 ; Nikula, Jani >; Belgaumkar, Vinay >Subject: [PATCH] drm/i915/display: Introduce Display

Re: [PATCH 1/3] drm/i915: pass dev_priv explicitly to PIPE_CRC_CTL

2024-05-06 Thread Ville Syrjälä
On Mon, May 06, 2024 at 01:09:02PM +0300, Jani Nikula wrote: > Avoid the implicit dev_priv local variable use, and pass dev_priv > explicitly to the PIPE_CRC_CTL register macro. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_pipe_crc.c |

Re: [PATCH 2/3] drm/i915: pass dev_priv explicitly to PIPE_CRC_*

2024-05-06 Thread Ville Syrjälä
On Mon, May 06, 2024 at 01:09:03PM +0300, Jani Nikula wrote: > Avoid the implicit dev_priv local variable use, and pass dev_priv > explicitly to the PIPE_CRC_RES_* register macros. > > Signed-off-by: Jani Nikula > --- > .../gpu/drm/i915/display/intel_display_irq.c | 24 ++- >

Re: [PATCH 3/3] drm/i915: pass dev_priv explicitly to PORT_DFT2_G4X

2024-05-06 Thread Ville Syrjälä
On Mon, May 06, 2024 at 01:09:04PM +0300, Jani Nikula wrote: > Avoid the implicit dev_priv local variable use, and pass dev_priv > explicitly to the PORT_DFT2_G4X register macro. Looks like we only use this on VLV/CHV, so could define a fixed offset _VLV variant. But this works too Reviewed-by:

Re: [PATCH 5/9] drm/i915: Polish types in fb calculations

2024-05-06 Thread Jani Nikula
On Mon, 06 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Be a bit more consistent in our use of integer types in > the fb related calculatiosn. u32 we generally only use > for ggtt offsets and such, and everything else can be regular > (unsigned) ints. > > There's also an

Re: [PATCH v2 03/12] drm/i915: Make I2C terminology more inclusive

2024-05-06 Thread Andi Shyti
Hi, On Fri, May 03, 2024 at 03:34:12PM -0400, Rodrigo Vivi wrote: > On Fri, May 03, 2024 at 06:13:24PM +, Easwar Hariharan wrote: > > I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" > > with more appropriate terms. Inspired by and following on to Wolfram's > >

Re: [PATCH 12/35] drm/i915/bios: Define VBT blocks 6, 7, 8 (register tables) contents

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Define the contents for VBT blocks: > - Block 6 (Extended MMIO Register Table) > - Block 7 (IO Software Flag Table) > - Block 8 (MMIO SWF Register Table) > > All of these use the same basic layout, with two known variants: > -

Re: [PATCH 00/35] drm/i915/bios: Define (almost) all BDB blocks

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > I got curious about what gems (or turds) might be hiding > inside the BDB blocks we aren't parsing. So I undertook the > effort to dig up the definition for pretty much all of them. > > Unfortunately I didn't find anything

✗ Fi.CI.CHECKPATCH: warning for drm/xe: More fb pinning optimizations.

2024-05-06 Thread Patchwork
== Series Details == Series: drm/xe: More fb pinning optimizations. URL : https://patchwork.freedesktop.org/series/133228/ State : warning == Summary == Error: dim checkpatch failed 607761f79c90 drm/xe: Remove safety check from __xe_ttm_stolen_io_mem_reserve_stolen 280e9e445c55

RE: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl

2024-05-06 Thread Murthy, Arun R
> -Original Message- > From: Ville Syrjälä > Sent: Monday, May 6, 2024 5:36 PM > To: Murthy, Arun R > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani > Subject: Re: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl > > On Mon, May 06, 2024 at 02:36:25PM +0530, Arun R Murthy

[PATCH 9/9] drm/i915: Rename the fb pinning functions to indicate the address space

2024-05-06 Thread Ville Syrjala
From: Ville Syrjälä Rename the fb pinning functions such that their name directly informs us what gets pinned into which address space. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dpt.c | 6 +-- drivers/gpu/drm/i915/display/intel_dpt.h | 6 +--

[PATCH 4/9] drm/i915: Extract intel_plane_needs_physical()

2024-05-06 Thread Ville Syrjala
From: Ville Syrjälä Pull the "does this plane need a physical address?" check into a small helper. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 8 drivers/gpu/drm/i915/display/intel_atomic_plane.h | 1 +

[PATCH 5/9] drm/i915: Polish types in fb calculations

2024-05-06 Thread Ville Syrjala
From: Ville Syrjälä Be a bit more consistent in our use of integer types in the fb related calculatiosn. u32 we generally only use for ggtt offsets and such, and everything else can be regular (unsigned) ints. There's also an overabundance of consts for local variables in

[PATCH 6/9] drm/i915: Constify 'fb' in during pinning

2024-05-06 Thread Ville Syrjala
From: Ville Syrjälä Make the 'fb' pointers const in the pinning code. We never want to mutate these. Also nuke a few aliasing fb vs. intel_fb cases by just using the more specific type everywhere in the same function. Signed-off-by: Ville Syrjälä ---

[PATCH 7/9] drm/i915: Change intel_fbdev_fb_alloc() reuturn type

2024-05-06 Thread Ville Syrjala
From: Ville Syrjälä Change intel_fbdev_fb_alloc() to return struct intel_fb instead of struct drm_framebuffer. Let's us eliminate some annoying aliasing variables in the fbdev setup code. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fbdev.c| 10 +-

[PATCH 8/9] drm/i915: Cleanup fbdev fb setup

2024-05-06 Thread Ville Syrjala
From: Ville Syrjälä We use a mix of 'fb' vs. 'ifbdev->fb' in the same function. Both should be pointing at the same thing. Make things less confusing by just getting existing fb from 'ifbdev->fb' at the start and then sticking with the local 'fb' until the very end. And we'll also change

[PATCH 3/9] drm/i915: Drop 'uses_fence' parameter from intel_pin_fb_obj_dpt()

2024-05-06 Thread Ville Syrjala
From: Ville Syrjälä Fence regions are only relevant for GGTT, not DPT. Drop the pointless 'uses_fence' argument from intel_pin_fb_obj_dpt(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fb_pin.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 1/9] drm/i915: Split gen2 vs. gen3 .max_stride()

2024-05-06 Thread Jani Nikula
On Mon, 06 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Plane .max_stride() is alreayd a vfunc so having one made *already > up of two branches based on the display version is silly. > Split i9xx_plane_max_stride() into gen2 vs. gen3 variants > so that we get rid of said check.

✓ Fi.CI.BAT: success for drm/i915/gt: Disarm breadcrumbs if engines are already idle (rev3)

2024-05-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: Disarm breadcrumbs if engines are already idle (rev3) URL : https://patchwork.freedesktop.org/series/132786/ State : success == Summary == CI Bug Log - changes from CI_DRM_14711 -> Patchwork_132786v3

Re: [PATCH v2 12/12] fbdev/viafb: Make I2C terminology more inclusive

2024-05-06 Thread Thomas Zimmermann
Am 03.05.24 um 20:13 schrieb Easwar Hariharan: I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface,

Re: [PATCH v2 11/12] fbdev/smscufx: Make I2C terminology more inclusive

2024-05-06 Thread Thomas Zimmermann
Am 03.05.24 um 20:13 schrieb Easwar Hariharan: I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface,

Re: [PATCH 35/35] drm/i915/bios: Define VBT block 253 (PRD Table) contents

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Define the contents of VBT block 253 (PRD Table). > > Unfortunately the block has two definitions, with the cutoff > supposedly happening on ICL vs. TGL. Also according to some > notes it might be that the VBIOS (if that's still

[v3] drm/i915: Implement Audio WA_14020863754

2024-05-06 Thread Uma Shankar
WA_14020863754: Corner case with Min Hblank Fix can cause audio hang Issue: Previously a fix was made to avoid issues with extremely small hblanks, called the "Min Hblank Fix". However, this can potentially cause an audio hang. Workaround : During "Audio Programming Sequence" Audio Enabling -

Re: [PATCH 04/35] drm/i915/bios: Get rid of "LVDS" from all LFP data stuff

2024-05-06 Thread Ville Syrjälä
On Mon, May 06, 2024 at 12:19:01PM +0300, Jani Nikula wrote: > On Fri, 03 May 2024, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The LFP data applies to all kinds of display interfaces, so > > stop calling things by the "LVDS" name. > > > > Signed-off-by: Ville Syrjälä > > Reviewed-by:

✓ Fi.CI.BAT: success for drm/i915: Plane fb refactoring

2024-05-06 Thread Patchwork
== Series Details == Series: drm/i915: Plane fb refactoring URL : https://patchwork.freedesktop.org/series/133231/ State : success == Summary == CI Bug Log - changes from CI_DRM_14711 -> Patchwork_133231v1 Summary --- **SUCCESS**

Re: [PATCH 4/9] drm/i915: Extract intel_plane_needs_physical()

2024-05-06 Thread Jani Nikula
On Mon, 06 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Pull the "does this plane need a physical address?" check into > a small helper. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_atomic_plane.c | 8 >

[PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl

2024-05-06 Thread Arun R Murthy
UHBR13.5 is not supported in icl+ as well. This has been removed for mtl by the commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 10/35] drm/i915/bios: Define VBT block 4 (Mode Support List) contents

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Define the contents of VBT block 4 (Mode Support List). > > Slightly crazy layout with a variable length list at the start, > followed by the length of said list. > > No real idea what these "Intel mode numbers" really are. What

✓ Fi.CI.BAT: success for drm/i915/display/dp: Remove UHBR13.5 for icl

2024-05-06 Thread Patchwork
== Series Details == Series: drm/i915/display/dp: Remove UHBR13.5 for icl URL : https://patchwork.freedesktop.org/series/133216/ State : success == Summary == CI Bug Log - changes from CI_DRM_14711 -> Patchwork_133216v1 Summary ---

Re: [PATCH 0/4] drm/xe: Add Indirect Ring State support

2024-05-06 Thread Rodrigo Vivi
On Sat, May 04, 2024 at 04:29:48PM -0700, Niranjana Vishwanathapura wrote: please use intel...@lists.freedesktop.org for patches touching only xe. probably a good idea to use some gitconfig identities: [sendemail "i915"] to = intel-gfx@lists.freedesktop.org [sendemail "xe"] to =

[PATCH 0/9] drm/i915: Plane fb refactoring

2024-05-06 Thread Ville Syrjala
From: Ville Syrjälä A bit of cleanup/refactoring around plane fb stuff. This is mainly prep work for a slightly bigger rework of alignment handling. Ville Syrjälä (9): drm/i915: Split gen2 vs. gen3 .max_stride() drm/i915: Clean up skl+ plane stride limits drm/i915: Drop 'uses_fence'

[PATCH 1/9] drm/i915: Split gen2 vs. gen3 .max_stride()

2024-05-06 Thread Ville Syrjala
From: Ville Syrjälä Plane .max_stride() is alreayd a vfunc so having one made up of two branches based on the display version is silly. Split i9xx_plane_max_stride() into gen2 vs. gen3 variants so that we get rid of said check. Signed-off-by: Ville Syrjälä ---

[PATCH 2/9] drm/i915: Clean up skl+ plane stride limits

2024-05-06 Thread Ville Syrjala
From: Ville Syrjälä skl_plane_max_stride() is pretty messy. Streamline it and split it into clear skl+ vs. adl+ variants. TODO: Deal with icl and tgl strude limits properly Signed-off-by: Ville Syrjälä --- .../drm/i915/display/skl_universal_plane.c| 65 +++ 1 file

Re: [PATCH 13/35] drm/i915/bios: Define VBT block 10 (Mode Removal Table) contents

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Define the contents of VBT block 10 (Mode Removal Table). > > There seem to be two variants: > - 8 byte entries for desktop systems > - 10 byte entries for mobile systems, with the extra > panel_flags being a bitmask of LFPs >

Re: [PATCH 14/35] drm/i915/bios: Define VBT block 12 (Driver Persistent Algorithm) contents

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Define the contents of VBT block 12 (Driver Persistent Algorithm). > > Signed-off-by: Ville Syrjälä Baffled. Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 19 +++ > 1 file

Re: [PATCH 21/35] drm/i915/bios: Define VBT block 20 (OEM Customizable Modes) contents

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Define the contents of VBT block 20 (OEM Customizable Modes). > Each entry is either 26 or 28 bytes, depending on the BDB version. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

[PATCH v4 0/4] drm/xe: More fb pinning optimizations.

2024-05-06 Thread Maarten Lankhorst
This reduces the latency of pinning framebuffers by re-using the previous mapping, if available. Additionally, DPT is preallocated when creating the FB, instead of performing a bo allocation on every pin. No changes since v3, just a rebase from conflicts. Maarten Lankhorst (4): drm/xe: Remove

[PATCH v4 1/4] drm/xe: Remove safety check from __xe_ttm_stolen_io_mem_reserve_stolen

2024-05-06 Thread Maarten Lankhorst
This is invalid with display code when reworking DPT pinning. The only reason we added it, was because originally all display allocations also had the bit set. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH v4 2/4] drm/xe/display: Preparations for preallocating dpt bo

2024-05-06 Thread Maarten Lankhorst
The DPT bo should not be allocated when pinning, but in advance when creating the framebuffer. Split allocation from bo pinning and GGTT insertion. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/xe/display/xe_fb_pin.c | 159 +++-- 1 file changed, 123 insertions(+), 36

[PATCH v4 3/4] drm/xe: Use simple xchg to cache DPT

2024-05-06 Thread Maarten Lankhorst
Preallocate a DPT when creating the FB, and store it in i915_address_space. This can be used to prevent an expensive allocation in the pinning path. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/xe/display/xe_fb_pin.c | 33 +++--- 1 file changed, 19 insertions(+), 14

[PATCH v4 4/4] drm/xe/display: Re-use display vmas when possible

2024-05-06 Thread Maarten Lankhorst
i915 has this really nice, infrastructure where everything becomes complicated, GGTT needs eviction, etc.. Lets not do that, and make the dumbest possible interface instead. Try to retrieve the VMA from old_plane_state, or intel_fbdev if kernel fb. Signed-off-by: Maarten Lankhorst ---

✓ Fi.CI.BAT: success for drm/i915: Implement Audio WA_14020863754 (rev3)

2024-05-06 Thread Patchwork
== Series Details == Series: drm/i915: Implement Audio WA_14020863754 (rev3) URL : https://patchwork.freedesktop.org/series/132255/ State : success == Summary == CI Bug Log - changes from CI_DRM_14711 -> Patchwork_132255v3 Summary ---

Re: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl

2024-05-06 Thread Ville Syrjälä
On Mon, May 06, 2024 at 02:36:25PM +0530, Arun R Murthy wrote: > UHBR13.5 is not supported in icl+ as well. This has been removed for mtl > by the commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") icl/tgl/adl don't support UHBR at all. The numbers are there for dg2 presumably,

Re: [PATCH 08/35] drm/i915/bios: Add version notes for some blocks

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Document which VBT blocks were defined in which BDB version, > for the cases where the spec actually states this accurately. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

Re: [PATCH 18/35] drm/i915/bios: Define VBT block 18 (Driver Rotation) contents

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Define the contents of block 18 (Driver Rotation). > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 12 > 1 file changed, 12 insertions(+) > >

Re: [PATCH 26/35] drm/i915/bios: Define VBT block 28 (EFP DTD) contents

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Define the contents of VBT block 28 (EFP DTD). > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git

Re: [PATCH 25/35] drm/i915/bios: Define VBT block 26 (TV Options) contents

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Define the contents of VBT block 26 (TV Options). > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 12 > 1 file changed, 12 insertions(+) > >

Re: [PATCH 31/35] drm/i915/bios: Define VBT block 57 (Vswing PreEmphasis Table) contents

2024-05-06 Thread Ville Syrjälä
On Mon, May 06, 2024 at 12:42:03PM +0300, Jani Nikula wrote: > On Fri, 03 May 2024, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Define the contents of VBT block 57 (Vswing PreEmphasis Table). > > > > The contents is highly platform specific. The columns of the > > table corresponding to

Re: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl

2024-05-06 Thread Ville Syrjälä
On Mon, May 06, 2024 at 12:15:13PM +, Murthy, Arun R wrote: > > > -Original Message- > > From: Ville Syrjälä > > Sent: Monday, May 6, 2024 5:36 PM > > To: Murthy, Arun R > > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani > > Subject: Re: [PATCH] drm/i915/display/dp: Remove

Re: [PATCH 2/9] drm/i915: Clean up skl+ plane stride limits

2024-05-06 Thread Jani Nikula
On Mon, 06 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > skl_plane_max_stride() is pretty messy. Streamline it and > split it into clear skl+ vs. adl+ variants. > > TODO: Deal with icl and tgl strude limits properly > > Signed-off-by: Ville Syrjälä > --- >

Re: [PATCH 3/9] drm/i915: Drop 'uses_fence' parameter from intel_pin_fb_obj_dpt()

2024-05-06 Thread Jani Nikula
On Mon, 06 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Fence regions are only relevant for GGTT, not DPT. Drop the > pointless 'uses_fence' argument from intel_pin_fb_obj_dpt(). > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

Re: [PATCH 6/9] drm/i915: Constify 'fb' in during pinning

2024-05-06 Thread Jani Nikula
On Mon, 06 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Make the 'fb' pointers const in the pinning code. We never > want to mutate these. Also nuke a few aliasing fb vs. intel_fb > cases by just using the more specific type everywhere in the > same function. I was half expecting to

Re: [PATCH 31/35] drm/i915/bios: Define VBT block 57 (Vswing PreEmphasis Table) contents

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Define the contents of VBT block 57 (Vswing PreEmphasis Table). > > The contents is highly platform specific. The columns of the > table corresponding to some set of PHY/etc registers. The rows > corresponding to all legal

[PATCH 1/3] drm/i915: pass dev_priv explicitly to PIPE_CRC_CTL

2024-05-06 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PIPE_CRC_CTL register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_pipe_crc.c | 12 ++-- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 7

[PATCH 2/3] drm/i915: pass dev_priv explicitly to PIPE_CRC_*

2024-05-06 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PIPE_CRC_RES_* register macros. Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_display_irq.c | 24 ++- drivers/gpu/drm/i915/i915_reg.h | 22 - 2

[PATCH 3/3] drm/i915: pass dev_priv explicitly to PORT_DFT2_G4X

2024-05-06 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PORT_DFT2_G4X register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_pipe_crc.c | 8 drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 5 insertions(+), 5

[PATCH 0/3] drm/i915/display: remove implicit dev_priv from pipe crc

2024-05-06 Thread Jani Nikula
Continue removing implicit dev_priv local variable use. Jani Nikula (3): drm/i915: pass dev_priv explicitly to PIPE_CRC_CTL drm/i915: pass dev_priv explicitly to PIPE_CRC_* drm/i915: pass dev_priv explicitly to PORT_DFT2_G4X .../gpu/drm/i915/display/intel_display_irq.c | 24

✓ Fi.CI.BAT: success for drm/i915/display: remove implicit dev_priv from pipe crc

2024-05-06 Thread Patchwork
== Series Details == Series: drm/i915/display: remove implicit dev_priv from pipe crc URL : https://patchwork.freedesktop.org/series/133224/ State : success == Summary == CI Bug Log - changes from CI_DRM_14711 -> Patchwork_133224v1 Summary

✓ Fi.CI.BAT: success for drm/xe: More fb pinning optimizations.

2024-05-06 Thread Patchwork
== Series Details == Series: drm/xe: More fb pinning optimizations. URL : https://patchwork.freedesktop.org/series/133228/ State : success == Summary == CI Bug Log - changes from CI_DRM_14711 -> Patchwork_133228v1 Summary ---

Re: [PATCH 28/35] drm/i915/bios: Define VBT block 46 (Chromaticity For Narrow Gamut Panel) contents

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Define the contents of VBT block 46 (Chromaticity For Narrow Gamut > Panel). One entry per panel. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula but... > --- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 26

Re: [PATCH 29/35] drm/i915/bios: Define VBT block 51 (Fixed Set Mode Table) contents

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Define the contents of VBT block 51 (Fixed Set Mode Table). > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 11 +++ > 1 file changed, 11

Re: [PATCH 30/35] drm/i915/bios: Define VBT block 55 (RGB Palette Table) contents

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Define the contents of VBT block 55 (RGB Palette Table). > > Note that I've not actually seen any real world VBTs with this > block. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

Re: [PATCH 32/35] drm/i915/bios: Define VBT block 50 (MIPI) contents

2024-05-06 Thread Jani Nikula
On Fri, 03 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Define the contents of VBT block 50 (MIPI). > > This was some easly attempt at a MIPI DSI stuff. I'm not sure > this was ever actually used (I certainly don't have any VBTs > with this block), but here's some kind of definition

✗ Fi.CI.SPARSE: warning for drm/i915: Plane fb refactoring

2024-05-06 Thread Patchwork
== Series Details == Series: drm/i915: Plane fb refactoring URL : https://patchwork.freedesktop.org/series/133231/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1:

✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Disarm breadcrumbs if engines are already idle (rev3)

2024-05-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: Disarm breadcrumbs if engines are already idle (rev3) URL : https://patchwork.freedesktop.org/series/132786/ State : warning == Summary == Error: dim checkpatch failed fe6b28d83f8d drm/i915/gt: Disarm breadcrumbs if engines are already idle -:15:

Re: [PATCH 7/9] drm/i915: Change intel_fbdev_fb_alloc() reuturn type

2024-05-06 Thread Jani Nikula
*return in subject On Mon, 06 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Change intel_fbdev_fb_alloc() to return struct intel_fb instead > of struct drm_framebuffer. Let's us eliminate some annoying > aliasing variables in the fbdev setup code. You'll need to enable DRM_XE=m

Re: [PATCH v1 10/12] sfc: falcon: Make I2C terminology more inclusive

2024-05-06 Thread Easwar Hariharan
On 5/3/2024 3:13 PM, Jakub Kicinski wrote: > On Tue, 30 Apr 2024 17:38:09 + Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's >> series to fix drivers/i2c/[1], fix

Re: [5/6] drm/i915/dp: Enable AUX based backlight for HDR

2024-05-06 Thread Sebastian Wick
On Wed, Apr 24, 2024 at 5:59 AM Kandpal, Suraj wrote: > > > > > -Original Message- > > From: Sebastian Wick > > Sent: Wednesday, April 24, 2024 2:51 AM > > To: Kandpal, Suraj > > Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar > > ; Shankar, Uma > > ; Nautiyal, Ankit K ; > >

Re: i915 IVB hangup after resume from s2mem since v6.6.x

2024-05-06 Thread Johannes Stezenbach
Hi, so, git bisect pointed to: commit 701d2054fa317188cd4039c84e72c73254013b23 Author: Thomas Zimmermann Date: Tue Jun 13 13:07:13 2023 +0200 fbdev: Make support for userspace interfaces configurable Add Kconfig option CONFIG_FB_DEVICE and make the virtual fbdev ... I think

Re: [PATCH] Revert "drm/i915: Remove extra multi-gt pm-references"

2024-05-06 Thread Nirmoy Das
On 5/6/2024 8:02 PM, Janusz Krzysztofik wrote: This reverts commit 1f33dc0c1189efb9ae19c6fc22b64dd3e26261fb. There was a patch supposed to fix an issue of illegal attempts to free a still active i915 VMA object when parking a GT believed to be idle, reported by CI on 2-GT Meteor Lake. As a

[PATCH] drm/xe: Nuke xe's copy of intel_fbdev_fb.h

2024-05-06 Thread Ville Syrjala
From: Ville Syrjälä For some reason xe and i915 each have an identical (fortunately) copy of intel_fbdev_fb.h. The xe copy actually only gets included by xe's intel_fbdev_fb.c, and the i915 copy by everyone else, include intel_fbdev.c which is the actual caller of the functions declared in the

Re: [PATCH] drm/i915/display: Introduce Display Metrics info

2024-05-06 Thread Rodrigo Vivi
On Mon, May 06, 2024 at 06:03:17AM -0400, Kumar, Naveen1 wrote: > > > >-Original Message- > >From: Vivi, Rodrigo > >Sent: Saturday, April 6, 2024 3:39 AM > >To: intel-gfx@lists.freedesktop.org > >Cc: Vivi, Rodrigo ; Shankar, Uma > >; Kulkarni, Vandita ; > >Kumar, Naveen1 ; Nikula, Jani

Re: [PATCH v3] drm/i915/vma: Fix UAF on reopen vs destroy race

2024-05-06 Thread Nirmoy Das
Hi Janusz, On 4/16/2024 6:40 PM, Rodrigo Vivi wrote: On Tue, Apr 16, 2024 at 10:09:46AM +0200, Janusz Krzysztofik wrote: Hi Rodrigo, On Tuesday, 16 April 2024 03:16:31 CEST Rodrigo Vivi wrote: On Mon, Apr 15, 2024 at 09:53:09PM +0200, Janusz Krzysztofik wrote: We defer actually closing,

Re: [PATCH 7/9] drm/i915: Change intel_fbdev_fb_alloc() reuturn type

2024-05-06 Thread Ville Syrjälä
On Mon, May 06, 2024 at 05:16:50PM +0300, Jani Nikula wrote: > > *return in subject > > On Mon, 06 May 2024, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Change intel_fbdev_fb_alloc() to return struct intel_fb instead > > of struct drm_framebuffer. Let's us eliminate some annoying > >

[PATCH] Revert "drm/i915: Remove extra multi-gt pm-references"

2024-05-06 Thread Janusz Krzysztofik
This reverts commit 1f33dc0c1189efb9ae19c6fc22b64dd3e26261fb. There was a patch supposed to fix an issue of illegal attempts to free a still active i915 VMA object when parking a GT believed to be idle, reported by CI on 2-GT Meteor Lake. As a solution, an extra wakeref for a Primary GT was

Re: [PATCH 7/9] drm/i915: Change intel_fbdev_fb_alloc() reuturn type

2024-05-06 Thread Ville Syrjälä
On Mon, May 06, 2024 at 07:51:47PM +0300, Ville Syrjälä wrote: > On Mon, May 06, 2024 at 05:16:50PM +0300, Jani Nikula wrote: > > > > *return in subject > > > > On Mon, 06 May 2024, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Change intel_fbdev_fb_alloc() to return struct

[RFC PATCH 3/3] drm/i915/display: allow creation of case I915_FORMAT_MOD_4_TILED_XE2_CCS type framebuffer

2024-05-06 Thread Juha-Pekka Heikkila
Add I915_FORMAT_MOD_4_TILED_XE2_CCS to possible created tiling for new framebuffer on Xe driver. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_fb.c| 10 ++

[RFC PATCH 0/3] Introducing I915_FORMAT_MOD_4_TILED_XE2_CCS Modifier for Xe2

2024-05-06 Thread Juha-Pekka Heikkila
These patches introduce I915_FORMAT_MOD_4_TILED_XE2_CCS modifier, which, from the kernel's perspective, behaves similarly to `I915_FORMAT_MOD_4_TILED`. This new modifier is primarily intended for user space to effectively monitor compression status, especially when dealing with a mix of compressed

[RFC PATCH 1/3] drm/fourcc: define Intel Xe2 related tile4 ccs modifier

2024-05-06 Thread Juha-Pekka Heikkila
Add Tile4 type ccs modifier to indicate presence of compression on Xe2 Signed-off-by: Juha-Pekka Heikkila --- include/uapi/drm/drm_fourcc.h | 12 1 file changed, 12 insertions(+) diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index

[RFC PATCH 2/3] drm/xe/display: allow creation of case I915_FORMAT_MOD_4_TILED_XE2_CCS type framebuffer

2024-05-06 Thread Juha-Pekka Heikkila
Add I915_FORMAT_MOD_4_TILED_XE2_CCS to possible created tiling for new framebuffer on Xe driver. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/xe/display/xe_plane_initial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c

Re: [PATCH 2/9] drm/i915: Clean up skl+ plane stride limits

2024-05-06 Thread Ville Syrjälä
On Mon, May 06, 2024 at 05:03:59PM +0300, Jani Nikula wrote: > On Mon, 06 May 2024, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > skl_plane_max_stride() is pretty messy. Streamline it and > > split it into clear skl+ vs. adl+ variants. > > > > TODO: Deal with icl and tgl strude limits

✗ Fi.CI.CHECKPATCH: warning for Introducing I915_FORMAT_MOD_4_TILED_XE2_CCS Modifier for Xe2

2024-05-06 Thread Patchwork
== Series Details == Series: Introducing I915_FORMAT_MOD_4_TILED_XE2_CCS Modifier for Xe2 URL : https://patchwork.freedesktop.org/series/133253/ State : warning == Summary == Error: dim checkpatch failed e953532ce0c8 drm/fourcc: define Intel Xe2 related tile4 ccs modifier 4ef786f4f7f8

✓ Fi.CI.BAT: success for Introducing I915_FORMAT_MOD_4_TILED_XE2_CCS Modifier for Xe2

2024-05-06 Thread Patchwork
== Series Details == Series: Introducing I915_FORMAT_MOD_4_TILED_XE2_CCS Modifier for Xe2 URL : https://patchwork.freedesktop.org/series/133253/ State : success == Summary == CI Bug Log - changes from CI_DRM_14715 -> Patchwork_133253v1

✓ Fi.CI.BAT: success for drm/xe: Nuke xe's copy of intel_fbdev_fb.h

2024-05-06 Thread Patchwork
== Series Details == Series: drm/xe: Nuke xe's copy of intel_fbdev_fb.h URL : https://patchwork.freedesktop.org/series/133248/ State : success == Summary == CI Bug Log - changes from CI_DRM_14715 -> Patchwork_133248v1 Summary ---

✓ Fi.CI.BAT: success for Revert "drm/i915: Remove extra multi-gt pm-references"

2024-05-06 Thread Patchwork
== Series Details == Series: Revert "drm/i915: Remove extra multi-gt pm-references" URL : https://patchwork.freedesktop.org/series/133245/ State : success == Summary == CI Bug Log - changes from CI_DRM_14715 -> Patchwork_133245v1 Summary

✗ Fi.CI.CHECKPATCH: warning for drm/xe: Nuke xe's copy of intel_fbdev_fb.h

2024-05-06 Thread Patchwork
== Series Details == Series: drm/xe: Nuke xe's copy of intel_fbdev_fb.h URL : https://patchwork.freedesktop.org/series/133248/ State : warning == Summary == Error: dim checkpatch failed 72b807c1045a drm/xe: Nuke xe's copy of intel_fbdev_fb.h -:26: WARNING:FILE_PATH_CHANGES: added, moved or

Re: i915 IVB hangup after resume from s2mem since v6.6.x

2024-05-06 Thread Lukas Wunner
[cc += Thomas] On Mon, May 06, 2024 at 08:43:43PM +0200, Johannes Stezenbach wrote: > so, git bisect pointed to: > > commit 701d2054fa317188cd4039c84e72c73254013b23 > Author: Thomas Zimmermann > Date: Tue Jun 13 13:07:13 2023 +0200 > > fbdev: Make support for userspace interfaces

✗ Fi.CI.CHECKPATCH: warning for Revert "drm/i915: Remove extra multi-gt pm-references"

2024-05-06 Thread Patchwork
== Series Details == Series: Revert "drm/i915: Remove extra multi-gt pm-references" URL : https://patchwork.freedesktop.org/series/133245/ State : warning == Summary == Error: dim checkpatch failed decb51cfa6e8 Revert "drm/i915: Remove extra multi-gt pm-references" -:26:

RE: [PATCH] drm/i915/display: Introduce Display Metrics info

2024-05-06 Thread Kumar, Naveen1
>-Original Message- >From: Vivi, Rodrigo >Sent: Monday, May 6, 2024 10:52 PM >To: Kumar, Naveen1 >Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma ; >Kulkarni, Vandita ; Nikula, Jani >; Belgaumkar, Vinay ; >Borah, Chaitanya Kumar >Subject: Re: [PATCH] drm/i915/display: Introduce

[PATCH 0/7] Enable Aux Based EDP HDR

2024-05-06 Thread Suraj Kandpal
This series enables Aux based EDP HDR and backlight controls. The DPCD written to are intel proprietary and are filled based on the specs that were provided to TCON vendors. Signed-off-by: Suraj Kandpal Suraj Kandpal (7): drm/i915/dp: Make has_gamut_metadata_dip() non static drm/i915/dp:

[PATCH 3/7] drm/i915/dp: Add TCON HDR capability checks

2024-05-06 Thread Suraj Kandpal
Add checks to see the HDR capability of TCON panel. Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_display_types.h| 5 + drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++ 2 files changed, 15 insertions(+) diff --git

[PATCH 4/7] drm/i915/dp: Fix Register bit naming

2024-05-06 Thread Suraj Kandpal
Change INTEL_EDP_HDR_TCON_SDP_COLORIMETRY enable to INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX as this bit tells TCON to ignore DPCD colorimetry values and take the one's sent through SDP. --v2 -Fix typo in commit message [Arun] Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy ---

  1   2   >