Re: [Intel-gfx] [PATCH] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts

Op 11-10-16 om 10:32 schreef Ville Syrjälä: > On Tue, Oct 11, 2016 at 09:45:45AM +0200, Maarten Lankhorst wrote: >> Op 11-10-16 om 08:55 schreef Ville Syrjälä: >>> On Tue, Oct 11, 2016 at 08:17:22AM +0200, Maarten Lankhorst wrote: Op 10-10-16 om 13:56 schreef Ville Syrjälä: > On Mon, Oct

Re: [Intel-gfx] [REGRESSION v4.7] i915 / drm crash when undocking from DP monitors

Certainly, done and done. The bug is filed at: https://bugs.freedesktop.org/show_bug.cgi?id=98211 Thanks! On Tue, Oct 11, 2016 at 6:55 AM, Jani Nikula wrote: > On Sat, 08 Oct 2016, Vadim Lobanov wrote: >> I'm seeing a repeatable crash on my

Re: [Intel-gfx] [PATCH RESEND 9/9] drm/i915: set proper N/M in modeset

> -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Jani Nikula > Sent: Monday, October 10, 2016 11:04 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; libin.y...@linux.intel.com; > Pandiyan,

Re: [Intel-gfx] [PATCH v5 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

On Fri, Oct 7, 2016 at 10:19 AM, Matthew Auld < matthew.william.a...@gmail.com> wrote: > On 14 September 2016 at 15:19, Robert Bragg wrote: > > > diff --git a/drivers/gpu/drm/i915/i915_perf.c > b/drivers/gpu/drm/i915/i915_perf.c > > index 87530f5..5305982 100644 > > ---

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Respect alternate_ddc_pin for all DDI ports

My name does not include the word "show" (Tested-by tag). On Tue, Oct 11, 2016 at 7:52 PM, wrote: > From: Ville Syrjälä > > The VBT provides the platform a way to mix and match the DDI ports vs. > GMBUS pins. Currently we only trust

Re: [Intel-gfx] [PATCH 04/10] drm/i915/gen9: Cleanup skl_pipe_wm_active_state

Em Sex, 2016-10-07 às 20:11 -0400, Lyude escreveu: > This function is a wreck, let's help it get it's life back together > and > cleanup all of the copy pasta here. s/it's/its/ Idea for your next patch series: rename skl_pipe_wm_active_state()'s "i" parameter to something more meaningful.

Re: [Intel-gfx] [PATCH v2 03/10] drm/i915/gen9: Make skl_wm_level per-plane

Em Sex, 2016-10-07 às 20:11 -0400, Lyude escreveu: > Having skl_wm_level contain all of the watermarks for each plane is > annoying since it prevents us from having any sort of object to > represent a single watermark level, something we take advantage of in > the next commit to cut down on all of

Re: [Intel-gfx] [PATCH v2 01/10] drm/i915/skl: Move per-pipe ddb allocations into crtc states

Em Sex, 2016-10-07 às 20:11 -0400, Lyude escreveu: > First part of cleaning up all of the skl watermark code. This moves > the > structures for storing the ddb allocations of each pipe into > intel_crtc_state, along with moving the structures for storing the > current ddb allocations active on

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915/gen9: unconditionally apply the memory bandwidth WA (rev2)

== Series Details == Series: series starting with [1/2] drm/i915/gen9: unconditionally apply the memory bandwidth WA (rev2) URL : https://patchwork.freedesktop.org/series/13548/ State : warning == Summary == Series 13548v2 Series without cover letter

Re: [Intel-gfx] [PATCH] drm/i915: Add i915 perf infrastructure

On Fri, Oct 7, 2016 at 10:10 AM, Matthew Auld < matthew.william.a...@gmail.com> wrote: > On 14 September 2016 at 16:32, Robert Bragg wrote: > > > + > > +int i915_perf_open_ioctl_locked(struct drm_device *dev, > > + struct

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Trust VBT aux/ddc information

== Series Details == Series: drm/i915: Trust VBT aux/ddc information URL : https://patchwork.freedesktop.org/series/13600/ State : warning == Summary == Series 13600v1 drm/i915: Trust VBT aux/ddc information https://patchwork.freedesktop.org/api/1.0/series/13600/revisions/1/mbox/ Test

[Intel-gfx] [PATCH 1/2] drm/i915/gen9: unconditionally apply the memory bandwidth WA

Mahesh Kumar is already working on a proper implementation for the workaround, but while we still don't have it, let's just unconditionally apply the workaround for everybody and we hope we can close all those numerous bugzilla tickets. Also, I'm not sure how easy it will be to backport the final

[Intel-gfx] [PATCH 2/4] drm/i915: Respect alternate_ddc_pin for all DDI ports

From: Ville Syrjälä The VBT provides the platform a way to mix and match the DDI ports vs. GMBUS pins. Currently we only trust the VBT for DDI E, which I suppose has no standard GMBUS pin assignment. However, there are machines out there that use a non-standard

[Intel-gfx] [PATCH 0/4] drm/i915: Trust VBT aux/ddc information

From: Ville Syrjälä So we have a bug or two ([1] at least) about using an incorrect gmbus pin for a HDMI connector. So I cooked up some patches to expand our use of VBT for this information. So far I've kept it limited to DDI platforms, but I think I've seen

[Intel-gfx] [PATCH 4/4] drm/i915: Fix whitespace issues

From: Ville Syrjälä Fix the poorly indented port parameters to the aux ctl and data reg functions. This was fallout from the s/i915_mmio_reg_t/i915_reg_t/ that happened during the review of commit f0f59a00a1c9 ("drm/i915: Type safe register read/write")

[Intel-gfx] [PATCH 3/4] drm/i915: Clean up DDI DDC/AUX CH sanitation

From: Ville Syrjälä Now that we use the AUX and GMBUS assignment from VBT for all ports, let's clean up the sanitization of the port information a bit. Previosuly we only did this for port E, and only complained about a non-standard assignment for the other ports.

[Intel-gfx] [PATCH 1/4] drm/i915: Respect alternate_aux_channel for all DDI ports

From: Ville Syrjälä The VBT provides the platform a way to mix and match the DDI ports vs. AUX channels. Currently we only trust the VBT for DDI E, which has no corresponding AUX channel of its own. However it is possible that some board might use some non-standard

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915: Remove unused "valid" parameter from pte_encode

On Tue, Oct 11, 2016 at 03:26:18PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,1/3] drm/i915: Remove unused "valid" > parameter from pte_encode > URL : https://patchwork.freedesktop.org/series/13586/ > State : failure > > == Summary == > > Series

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915: Remove unused "valid" parameter from pte_encode

== Series Details == Series: series starting with [CI,1/3] drm/i915: Remove unused "valid" parameter from pte_encode URL : https://patchwork.freedesktop.org/series/13586/ State : failure == Summary == Series 13586v1 Series without cover letter

[Intel-gfx] [PATCH 3/3] drm/i915: Remove superfluous locking around userfault_list

Now that we have reduced the access to the list to either (a) under the struct_mutex whilst holding the RPM wakeref (so that concurrent writers to the list are serialised by struct_mutex) and (b) under the atomic runtime suspend (which cannot run concurrently with any other accessor due to the

[Intel-gfx] [PATCH 2/3] drm/i915: Use RPM as the barrier for controlling user mmap access

We can remove the false coupling between RPM and struct mutex by the observation that we can use the RPM wakeref as the barrier around user mmap access. That is as we tear down the user's PTE atomically from within rpm suspend and then to fault in new PTE requires the rpm wakeref, means that no

[Intel-gfx] [PATCH 1/3] drm/i915: Move user fault tracking to a separate list

We want to decouple RPM and struct_mutex, but currently RPM has to walk the list of bound objects and remove userspace mmapping before we suspend (otherwise userspace may continue to access the GTT whilst it is powered down). This currently requires the struct_mutex to walk the bound_list, but if

Re: [Intel-gfx] [PATCH RESEND 8/9] drm/i915/audio: rename N value getter to emphasize it's for hdmi

On Tue, 11 Oct 2016, "Yang, Libin" wrote: > Reviewed-by: Libin Yang Pushed patches 1-8 to drm-intel-next-queued, thanks for the review. BR, Jani. > > Regards, > Libin > > >> -Original Message- >> From: Intel-gfx

[Intel-gfx] [PULL] drm-intel-next-fixes

Hi Dave - A big bunch of i915 fixes for drm-next / v4.9 merge window, with more than half of them also cc: stable. We also continue to have more Fixes: annotations for our fixes, which should help the backporters and archeologists. There's also a fix to your v4.8-rc8 backmerge to drm-next,

[Intel-gfx] [CI 3/3] drm/i915/gtt: Free unused lower-level page tables

Since "Dynamic page table allocations" were introduced, our page tables can grow (being dynamically allocated) with address space range usage. Unfortunately, their lifetime is bound to vm. This is not a huge problem when we're not using softpin - drm_mm is creating an upper bound on used range by

[Intel-gfx] [CI 2/3] drm/i915/gtt: Split gen8_ppgtt_clear_pte_range

Let's use more top-down approach, where each gen8_ppgtt_clear_* function is responsible for clearing the struct passed as an argument and calling relevant clear_range functions on lower-level tables. Doing this rather than operating on PTE ranges makes the implementation of shrinking page tables

[Intel-gfx] [CI 1/3] drm/i915: Remove unused "valid" parameter from pte_encode

We never used any invalid ptes, those were put in place for a possibility of doing gpu faults. However our batchbuffers are not restricted in length, so everything needs to be pointing to something and thus out-of-bounds is pointing to scratch. Remove the valid flag as it is always true. v2:

Re: [Intel-gfx] [REGRESSION v4.7] i915 / drm crash when undocking from DP monitors

On Sat, 08 Oct 2016, Vadim Lobanov wrote: > I'm seeing a repeatable crash on my HP EliteBook 840 G2/2216 when > booting it while in a docking station connected to two external > DisplayPort monitors, undocking, and then either logging out or > shutting down -- regardless

[Intel-gfx] ✗ Fi.CI.BAT: warning for .rodata.str diet

== Series Details == Series: .rodata.str diet URL : https://patchwork.freedesktop.org/series/13583/ State : warning == Summary == Series 13583v1 .rodata.str diet https://patchwork.freedesktop.org/api/1.0/series/13583/revisions/1/mbox/ Test kms_cursor_legacy: Subgroup

[Intel-gfx] [PATCH 2/2] drm/i915: Allow disabling error capture

We currently capture the GPU state after we detect a hang. This is vital for us to both triage and debug hangs in the wild (post-mortem debugging). However, it comes at the cost of running some potentially dangerous code (since it has to make very few assumption about the state of the driver) that

[Intel-gfx] [PATCH 1/2] drm/i915: Move common code out of i915_gpu_error.c

In the next patch, I want to conditionally compile i915_gpu_error.c and that requires moving the functions used by debug out of i915_gpu_error.c! Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.h |

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use RPM as the barrier for controlling user mmap access

On Mon, Oct 10, 2016 at 10:58:40PM +0100, Chris Wilson wrote: > We can remove the false coupling between RPM and struct mutex by the > observation that we can use the RPM wakeref as the barrier around user > mmap access. That is as we tear down the user's PTE atomically from > within rpm suspend

[Intel-gfx] [PATCH 19/19] drm/i915: Make IS_GEN macros only take dev_priv

From: Tvrtko Ursulin Saves 1416 bytes of .rodata strings. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c| 4 +- drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [PATCH 13/19] drm/i915: Make IS_BROXTON only take dev_priv

From: Tvrtko Ursulin Saves 1392 bytes of .rodata strings. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 5

[Intel-gfx] [PATCH 06/19] drm/i915: Make IS_GEN-range macro only take dev_priv

From: Tvrtko Ursulin Saves 944 bytes of .rodata strings. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Intel-gfx] [PATCH 17/19] drm/i915: Make IS_VALLEYVIEW only take dev_priv

From: Tvrtko Ursulin Saves 944 bytes of .rodata strings and 128 bytes of .text. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 2 +-

[Intel-gfx] [PATCH 05/19] drm/i915: Do not use INTEL_INFO(dev_priv)->ring_mask inside WARNs

From: Tvrtko Ursulin Saves 1520 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/intel_engine_cs.c | 7 --- 1 file changed, 4 insertions(+), 3

[Intel-gfx] [PATCH 16/19] drm/i915: Make IS_CHERRYVIEW only take dev_priv

From: Tvrtko Ursulin Saves 864 bytes of .rodata strings and ~100 of .text. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c | 2 +-

[Intel-gfx] [PATCH 12/19] drm/i915: Make IS_SKYLAKE only take dev_priv

From: Tvrtko Ursulin Saves 1016 bytes of .rodata strings and couple hundred of .text. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 2 +-

[Intel-gfx] [PATCH v2 00/19] .rodata.str diet

From: Tvrtko Ursulin Dynamic typing in __I915__ (INTEL_INFO) has and unfortuante consequence that for every time it is called under a WARN it generates a very verbose string placed into the appropriate .rodata section. Each instance of that can can several hundred

[Intel-gfx] [PATCH 11/19] drm/i915: Make IS_KABYLAKE only take dev_priv

From: Tvrtko Ursulin Saves 1320 bytes of .rodata strings. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c | 10 +- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 09/19] drm/i915: Make IS_BROADWELL only take dev_priv

From: Tvrtko Ursulin Saves 1808 bytes of .rodata strings. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c | 6 -- drivers/gpu/drm/i915/i915_drv.h |

[Intel-gfx] [PATCH 10/19] drm/i915: Make IS_HASWELL only take dev_priv

From: Tvrtko Ursulin Saves 2432 bytes of .rodata strings. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gem.c | 2 +-

[Intel-gfx] [PATCH 15/19] drm/i915: Make IS_G4X only take dev_priv

From: Tvrtko Ursulin Saves 472 bytes of .rodata strings. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h| 2 +- drivers/gpu/drm/i915/i915_gem_stolen.c | 5

[Intel-gfx] [PATCH 14/19] drm/i915: Make HAS_L3_DPF only take dev_priv

From: Tvrtko Ursulin Saves 472 bytes of .rodata strings. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_irq.c | 2 +- 2 files changed,

[Intel-gfx] [PATCH 01/19] drm/i915: Make HAS_DDI and HAS_PCH_LPT_LP only take dev_priv

From: Tvrtko Ursulin This saves 3248 bytes of .rodata strings. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 8 +++--- drivers/gpu/drm/i915/intel_crt.c |

[Intel-gfx] [PATCH 03/19] drm/i915: Make HAS_GMCH_DISPLAY only take dev_priv

From: Tvrtko Ursulin More .rodata string saving by avoid __I915__ magic inside WARNs. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h| 2 +-

[Intel-gfx] [PATCH 04/19] drm/i915: Make HAS_RUNTIME_PM only take dev_priv

From: Tvrtko Ursulin Saves 960 bytes of .rodata strings. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 2 +-

[Intel-gfx] [PATCH 08/19] drm/i915: Make IS_IVYBRIDGE only take dev_priv

From: Tvrtko Ursulin Saves 848 bytes of .rodata strings. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c | 19 +++

[Intel-gfx] [PATCH 07/19] drm/i915: Make INTEL_DEVID only take dev_priv

From: Tvrtko Ursulin Saves 4472 bytes of .rodata strings. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c| 14 +++-- drivers/gpu/drm/i915/i915_drv.h|

[Intel-gfx] [PATCH 02/19] drm/i915: Make INTEL_PCH_TYPE & co only take dev_priv

From: Tvrtko Ursulin This saves 1872 bytes of .rodata strings. v2: * Rebase. * Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 16 ++--

[Intel-gfx] [PATCH 18/19] drm/i915: Make INTEL_GEN only take dev_priv

From: Tvrtko Ursulin Saves 968 bytes of .rodata strings. v2: Add parantheses around dev_priv. (Ville Syrjala) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 2 +-

Re: [Intel-gfx] [PATCH 00/22] .rodata diet

On 11/10/2016 13:17, David Weinehall wrote: On Wed, Oct 05, 2016 at 01:33:27PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Dynamic typing in __I915__ (INTEL_INFO) has and unfortuante consequence that for every time it is called under a WARN it generates a very

Re: [Intel-gfx] [maintainer-tools PATCH 6/6] dim: add command to check for dim updates

On Tue, 11 Oct 2016, Daniel Vetter wrote: > On Tue, Oct 11, 2016 at 11:47:32AM +0300, Jani Nikula wrote: >> Add a command to check if the user is running an up-to-date version of >> dim. >> >> Signed-off-by: Jani Nikula >> --- >> dim | 21

Re: [Intel-gfx] [PATCH 00/22] .rodata diet

On Wed, Oct 5, 2016 at 3:01 PM, Jani Nikula wrote: > On Wed, 05 Oct 2016, Tvrtko Ursulin wrote: >> Dynamic typing in __I915__ (INTEL_INFO) has and unfortuante consequence that >> for every time it is called under a WARN it generates a very

Re: [Intel-gfx] [PATCH] drm/i915/guc: Sanitory checks for platform that dont have GuC

Em Ter, 2016-10-11 às 10:36 +0300, Jani Nikula escreveu: > On Tue, 11 Oct 2016, Anusha Srivatsa > wrote: > > > > i915.enable_guc_loading/submission=2 forces the usage of GuC. > > For platforms that do not have a GuC, asking the kernel to > > use a GuC should not result

Re: [Intel-gfx] [maintainer-tools PATCH 6/6] dim: add command to check for dim updates

On Tue, Oct 11, 2016 at 11:47:32AM +0300, Jani Nikula wrote: > Add a command to check if the user is running an up-to-date version of > dim. > > Signed-off-by: Jani Nikula > --- > dim | 21 + > dim.rst | 4 > 2 files changed, 25 insertions(+)

Re: [Intel-gfx] [maintainer-tools PATCH 5/6] dim: add dim sparse subcommand to run sparse on a commit range

On Tue, Oct 11, 2016 at 11:47:31AM +0300, Jani Nikula wrote: > Run sparse only on files that have changed in the range. > > Signed-off-by: Jani Nikula > --- > dim | 9 + > dim.rst | 22 +++--- > 2 files changed, 24 insertions(+), 7

Re: [Intel-gfx] [PATCH 00/22] .rodata diet

On Wed, Oct 05, 2016 at 01:33:27PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Dynamic typing in __I915__ (INTEL_INFO) has and unfortuante consequence that > for every time it is called under a WARN it generates a very verbose string > placed into the

Re: [Intel-gfx] [CI 1/5] drm/i915: Allow disabling error capture

On Tue, Oct 11, 2016 at 12:56 PM, Jani Nikula wrote: > Fair enough. Please copy-paste some of the elaboration to the commit > message. Ack from me, but it wouldn't hurt to get an ack from Daniel as > well. Would be nice if we can trade in some of the #ifdefry with a

Re: [Intel-gfx] [PATCH i-g-t] lib/chipset: Properly skip on non-Intel

On Tue, Oct 11, 2016 at 11:36:08AM +0200, Daniel Vetter wrote: > Random drive-by I noticed while hacking on piglit. > > Signed-off-by: Daniel Vetter > --- > lib/intel_chipset.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

Re: [Intel-gfx] [PATCH 16/42] drm/i915: Refactor object page API

On 07/10/2016 10:46, Chris Wilson wrote: The plan is to make obtaining the backing storage for the object avoid struct_mutex (i.e. use its own locking). The first step is to update the API so that normal users only call pin/unpin whilst working on the backing storage. Signed-off-by: Chris

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [CI,1/5] drm/i915: Allow disabling error capture

== Series Details == Series: series starting with [CI,1/5] drm/i915: Allow disabling error capture URL : https://patchwork.freedesktop.org/series/13576/ State : warning == Summary == Series 13576v1 Series without cover letter

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gen9: unconditionally apply the memory bandwidth WA

On Tue, Oct 11, 2016 at 01:54:09PM +0300, Jani Nikula wrote: > On Tue, 11 Oct 2016, Greg KH wrote: > > On Tue, Oct 11, 2016 at 10:34:14AM +0300, Jani Nikula wrote: > >> On Mon, 10 Oct 2016, Paulo Zanoni wrote: > >> The patch is a bit on the large side

Re: [Intel-gfx] [CI 1/5] drm/i915: Allow disabling error capture

On Tue, 11 Oct 2016, Chris Wilson wrote: > On Tue, Oct 11, 2016 at 01:16:42PM +0300, Jani Nikula wrote: >> On Tue, 11 Oct 2016, Chris Wilson wrote: >> > On Tue, Oct 11, 2016 at 12:52:00PM +0300, Jani Nikula wrote: >> >> On Tue, 11 Oct 2016,

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gen9: unconditionally apply the memory bandwidth WA

On Tue, 11 Oct 2016, Greg KH wrote: > On Tue, Oct 11, 2016 at 10:34:14AM +0300, Jani Nikula wrote: >> On Mon, 10 Oct 2016, Paulo Zanoni wrote: >> The patch is a bit on the large side for stable. 100 lines with context >> is the rule. > > Huh? It's only

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Convert open-coded use of vma_pages()

== Series Details == Series: drm/i915: Convert open-coded use of vma_pages() URL : https://patchwork.freedesktop.org/series/13575/ State : warning == Summary == Series 13575v1 drm/i915: Convert open-coded use of vma_pages()

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gen9: unconditionally apply the memory bandwidth WA

On Tue, Oct 11, 2016 at 10:34:14AM +0300, Jani Nikula wrote: > On Mon, 10 Oct 2016, Paulo Zanoni wrote: > > Mahesh Kumar is already working on a proper implementation for the > > workaround, but while we still don't have it, let's just > > unconditionally apply the

Re: [Intel-gfx] [CI 1/5] drm/i915: Allow disabling error capture

On Tue, Oct 11, 2016 at 01:16:42PM +0300, Jani Nikula wrote: > On Tue, 11 Oct 2016, Chris Wilson wrote: > > On Tue, Oct 11, 2016 at 12:52:00PM +0300, Jani Nikula wrote: > >> On Tue, 11 Oct 2016, Chris Wilson wrote: > >> > We currently capture

Re: [Intel-gfx] [CI 1/5] drm/i915: Allow disabling error capture

On Tue, 11 Oct 2016, Chris Wilson wrote: > On Tue, Oct 11, 2016 at 12:52:00PM +0300, Jani Nikula wrote: >> On Tue, 11 Oct 2016, Chris Wilson wrote: >> > We currently capture the GPU state after we detect a hang. This is vital >> > for us to

Re: [Intel-gfx] [PATCH 14/42] drm/i915: Use a radixtree for random access to the object's backing storage

On 11/10/2016 10:32, Tvrtko Ursulin wrote: On 07/10/2016 10:46, Chris Wilson wrote: A while ago we switched from a contiguous array of pages into an sglist, for that was both more convenient for mapping to hardware and avoided the requirement for a vmalloc array of pages on every object.

Re: [Intel-gfx] [CI 1/5] drm/i915: Allow disabling error capture

On Tue, Oct 11, 2016 at 12:52:00PM +0300, Jani Nikula wrote: > On Tue, 11 Oct 2016, Chris Wilson wrote: > > We currently capture the GPU state after we detect a hang. This is vital > > for us to both triage and debug hangs in the wild (post-mortem > > debugging).

Re: [Intel-gfx] [PATCH 25/42] drm/i915: Use lockless object free

Needs a description? On 07/10/2016 10:46, Chris Wilson wrote: Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 10 +- drivers/gpu/drm/i915/i915_gem.c | 20

Re: [Intel-gfx] [PATCH 24/42] drm/i915: Treat a framebuffer reference as an active reference whilst shrinking

On 07/10/2016 10:46, Chris Wilson wrote: Treat a framebuffer reference with the same priority as an active reference whilst shrinking. Framebuffers are likely to be reused and typically cost more to migrate to and from GPU memory (on LLC architectures we need to clflush), so defer the temptation

Re: [Intel-gfx] [CI 1/5] drm/i915: Allow disabling error capture

On Tue, 11 Oct 2016, Chris Wilson wrote: > We currently capture the GPU state after we detect a hang. This is vital > for us to both triage and debug hangs in the wild (post-mortem > debugging). However, it comes at the cost of running some potentially > dangerous code

Re: [Intel-gfx] [PATCH 23/42] drm/i915: Move object release to a freelist + worker

On 07/10/2016 10:46, Chris Wilson wrote: We want to hide the latency of releasing objects and their backing storage from the submission, so we move the actual free to a worker. This allows us to switch to struct_mutex freeing of the object in the next patch. Furthermore, if we know that the

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use fence_write() from rpm resume

On ma, 2016-10-10 at 22:58 +0100, Chris Wilson wrote: > During rpm resume we restore the fences, but we do not have the > protection of struct_mutex. This rules out updating the activity > tracking on the fences, and requires us to rely on the rpm as the > serialisation barrier instead. > > [  

[Intel-gfx] [REGRESSION v4.7] i915 / drm crash when undocking from DP monitors

Hi folks, I'm seeing a repeatable crash on my HP EliteBook 840 G2/2216 when booting it while in a docking station connected to two external DisplayPort monitors, undocking, and then either logging out or shutting down -- regardless of whether I've redocked it beforehand or not. Both logout and

[Intel-gfx] [PATCH i-g-t] lib/chipset: Properly skip on non-Intel

Random drive-by I noticed while hacking on piglit. Signed-off-by: Daniel Vetter --- lib/intel_chipset.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/intel_chipset.c b/lib/intel_chipset.c index 777dfa73da80..ab35fa70c167 100644 ---

Re: [Intel-gfx] [PATCH 14/42] drm/i915: Use a radixtree for random access to the object's backing storage

On 07/10/2016 10:46, Chris Wilson wrote: A while ago we switched from a contiguous array of pages into an sglist, for that was both more convenient for mapping to hardware and avoided the requirement for a vmalloc array of pages on every object. However, certain GEM API calls (like pwrite,

[Intel-gfx] [CI 5/5] drm/i915: Compress GPU objects in error state

Our error states are quickly growing, pinning kernel memory with them. The majority of the space is taken up by the error objects. These compress well using zlib and without decode are mostly meaningless, so encoding them does not hinder quickly parsing the error state for familiarity. v2: Make

[Intel-gfx] [CI 1/5] drm/i915: Allow disabling error capture

We currently capture the GPU state after we detect a hang. This is vital for us to both triage and debug hangs in the wild (post-mortem debugging). However, it comes at the cost of running some potentially dangerous code (since it has to make very few assumption about the state of the driver) that

[Intel-gfx] [CI 3/5] drm/i915: Always use the GTT for error capture

Since the GTT provides universal access to any GPU page, we can use it to reduce our plethora of read methods to just one. It also has the important characteristic of being exactly what the GPU sees - if there are incoherency problems, seeing the batch as executed (rather than as trapped inside

[Intel-gfx] [CI 2/5] drm/i915: Stop the machine whilst capturing the GPU crash dump

The error state is purposefully racy as we expect it to be called at any time and so have avoided any locking whilst capturing the crash dump. However, with multi-engine GPUs and multiple CPUs, those races can manifest into OOPSes as we attempt to chase dangling pointers freed on other CPUs. Under

Re: [Intel-gfx] [PATCH] drm/i915: Convert open-coded use of vma_pages()

On 11 October 2016 at 10:06, Chris Wilson wrote: > If we want to know how many pages a VMA spans, we can use vma_pages() to > find out. We have one such invocation inside our faulthandler, so > convert it. (We have two other that want the size in bytes rather than >

[Intel-gfx] [CI 4/5] drm/i915: Consolidate error object printing

Leave all the pretty printing to userspace and simplify the error capture to only have a single common object printer. It makes the kernel code more compact, and the refactoring allows us to apply more complex transformations like compressing the output. Signed-off-by: Chris Wilson

Re: [Intel-gfx] [RFC PATCH v2 4/8] drm/i915: Add support for enabling/disabling hdmi audio interrupts

On Sat, Oct 01, 2016 at 05:52:38AM +0530, Jerome Anand wrote: > API definitions for enabling/disabling hdmi audio interrupts in > different hdmi pipes are implemented. > > Signed-off-by: Jerome Anand > --- > drivers/gpu/drm/i915/i915_irq.c | 69 >

Re: [Intel-gfx] [RFC PATCH v2 1/8] drm/i915: setup bridge for HDMI LPE audio driver

On Sat, Oct 01, 2016 at 05:52:35AM +0530, Jerome Anand wrote: > Enable support for HDMI LPE audio mode on Baytrail and > Cherrytrail when HDaudio controller is not detected > > Setup minimum required resources during i915_driver_load: > 1. Create a platform device to share MMIO/IRQ resources > 2.

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [CI,1/2] drm/i915: Remove self-harming shrink_all on get_pages_gtt fail

== Series Details == Series: series starting with [CI,1/2] drm/i915: Remove self-harming shrink_all on get_pages_gtt fail URL : https://patchwork.freedesktop.org/series/13571/ State : warning == Summary == Series 13571v1 Series without cover letter

[Intel-gfx] [PATCH] drm/i915: Convert open-coded use of vma_pages()

If we want to know how many pages a VMA spans, we can use vma_pages() to find out. We have one such invocation inside our faulthandler, so convert it. (We have two other that want the size in bytes rather than pages, food for future thought.) Signed-off-by: Chris Wilson

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [CI,1/2] drm/i915: Remove self-harming shrink_all on get_pages_gtt fail

== Series Details == Series: series starting with [CI,1/2] drm/i915: Remove self-harming shrink_all on get_pages_gtt fail URL : https://patchwork.freedesktop.org/series/13571/ State : warning == Summary == Series 13571v1 Series without cover letter

[Intel-gfx] [maintainer-tools PATCH 6/6] dim: add command to check for dim updates

Add a command to check if the user is running an up-to-date version of dim. Signed-off-by: Jani Nikula --- dim | 21 + dim.rst | 4 2 files changed, 25 insertions(+) diff --git a/dim b/dim index bef7bb6c401b..5fb3a0fee7ff 100755 --- a/dim

[Intel-gfx] [maintainer-tools PATCH 1/6] dim: refer to the script itself by basename without path

Add $dim for the basename of the script and use it. Signed-off-by: Jani Nikula --- dim | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/dim b/dim index 126d79aea624..5b105743cd65 100755 --- a/dim +++ b/dim @@ -87,6 +87,8 @@

[Intel-gfx] [maintainer-tools PATCH 4/6] dim: add DIM_MAKE_OPTIONS configuration

Defaults to -j20. Signed-off-by: Jani Nikula --- dim | 7 +-- dim.rst | 4 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/dim b/dim index 76da7e347a6e..e3ef4365e85f 100755 --- a/dim +++ b/dim @@ -74,6 +74,9 @@

[Intel-gfx] [maintainer-tools PATCH 2/6] dim: columnize usage output if column(1) is available

The usage has become a bit unwieldy with the command list. Signed-off-by: Jani Nikula --- dim | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dim b/dim index 5b105743cd65..79245550b6b2 100755 --- a/dim +++ b/dim @@ -1241,7 +1241,11 @@ function

[Intel-gfx] [maintainer-tools PATCH 3/6] dim: clean up the rm's in dim checker

The -f option does what the doctor orders. Signed-off-by: Jani Nikula --- dim | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dim b/dim index 79245550b6b2..76da7e347a6e 100755 --- a/dim +++ b/dim @@ -730,8 +730,7 @@ function dim_checkpatch

[Intel-gfx] [maintainer-tools PATCH 5/6] dim: add dim sparse subcommand to run sparse on a commit range

Run sparse only on files that have changed in the range. Signed-off-by: Jani Nikula --- dim | 9 + dim.rst | 22 +++--- 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/dim b/dim index e3ef4365e85f..bef7bb6c401b 100755 --- a/dim

Re: [Intel-gfx] [PATCH] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts

On Tue, Oct 11, 2016 at 09:45:45AM +0200, Maarten Lankhorst wrote: > Op 11-10-16 om 08:55 schreef Ville Syrjälä: > > On Tue, Oct 11, 2016 at 08:17:22AM +0200, Maarten Lankhorst wrote: > >> Op 10-10-16 om 13:56 schreef Ville Syrjälä: > >>> On Mon, Oct 10, 2016 at 12:46:32PM +0100, Chris Wilson

[Intel-gfx] [CI 1/2] drm/i915: Remove self-harming shrink_all on get_pages_gtt fail

When we notice the system under memory pressure, we try to evict some driver pages before asking the VM to shrink all caches. As a final step in that process, we tried to evict everything, including active buffers. This is harming ourselves, and we can mix shrinking all caches as well as our

[Intel-gfx] [CI 2/2] drm/i915: Allow compaction upto SWIOTLB max segment size

commit 1625e7e549c5 ("drm/i915: make compact dma scatter lists creation work with SWIOTLB backend") took a heavy handed approach to undo the scatterlist compaction in the face of SWIOTLB. (The compaction hit a bug whereby we tried to pass a segment larger than SWIOTLB could handle.) We can be a

  1   2   >