[Intel-gfx] [DO_NOT_REVIEW PATCH] drm/i915/display/dp: On AUX xfer timeout restart freshly

At the beginning of the aux transfer a check for aux control busy bit is done. Then as per the spec on aux transfer timeout, need to retry freshly for 3 times with a delay which is taken care by the control register. On each of these 3 trials a check for busy has to be done so as to start freshly.

Re: [Intel-gfx] [PATCH v7 6/8] PCI/VGA: Introduce is_boot_device function callback to vga_client_register

Hi, A nouveau developer(Lyude) from redhat send me a R-B, Thanks for the developers of nouveau project. Please allow me add a link[1] here. [1] https://lore.kernel.org/all/0afadc69f99a36bc9d03ecf54ff25859dbc10e28.ca...@redhat.com/ On 2023/6/13 11:01, Sui Jingfeng wrote: From: Sui

Re: [Intel-gfx] [PATCH v6 0/8] PCI/VGA: introduce is_boot_device function callback to vga_client_register

Hi On 2023/6/22 06:11, Lyude Paul wrote: For the nouveau bits: Reviewed-by: Lyude Paul Thanks a lot On Tue, 2023-06-13 at 03:25 +0800, Sui Jingfeng wrote: From: Sui Jingfeng The vga_is_firmware_default() function is arch-dependent, it's probably wrong if we simply remove the arch guard.

Re: [Intel-gfx] [PATCH] drm/i915/display/dp: Remove support for UHBR13.5

> -Original Message- > From: Nikula, Jani > Sent: Wednesday, June 21, 2023 2:27 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: Deak, Imre ; Kahola, Mika > ; Murthy, Arun R > Subject: Re: [PATCH] drm/i915/display/dp: Remove support for UHBR13.5 > > On Tue, 20 Jun

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Handle legacy cursor update as normal update

Hi Maarten, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Maarten-Lankhorst/drm-i915-Handle-legacy-cursor-update-as-normal-update/20230621-195009 base: git://anongit.freedesktop.org/drm

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: remove display raw reg read/write micro-optimizations

== Series Details == Series: drm/i915/display: remove display raw reg read/write micro-optimizations URL : https://patchwork.freedesktop.org/series/119703/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13302 -> Patchwork_119703v1

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Handle legacy cursor update as normal update

Hi Maarten, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Maarten-Lankhorst/drm-i915-Handle-legacy-cursor-update-as-normal-update/20230621-195009 base: git://anongit.freedesktop.org/drm

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Replace kmap() with kmap_local_page() (rev7)

== Series Details == Series: drm/i915: Replace kmap() with kmap_local_page() (rev7) URL : https://patchwork.freedesktop.org/series/107277/ State : success == Summary == CI Bug Log - changes from CI_DRM_13302 -> Patchwork_107277v7 Summary

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Remove pagevecs

== Series Details == Series: Remove pagevecs URL : https://patchwork.freedesktop.org/series/119702/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/119702/revisions/1/mbox/ not applied Applying: afs: Convert pagevec to folio_batch in

Re: [Intel-gfx] [PATCH v6 0/8] PCI/VGA: introduce is_boot_device function callback to vga_client_register

For the nouveau bits: Reviewed-by: Lyude Paul On Tue, 2023-06-13 at 03:25 +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > The vga_is_firmware_default() function is arch-dependent, it's probably > wrong if we simply remove the arch guard. As the VRAM BAR which contains > firmware

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Update workaround 14018778641 (rev2)

== Series Details == Series: drm/i915/mtl: Update workaround 14018778641 (rev2) URL : https://patchwork.freedesktop.org/series/119517/ State : success == Summary == CI Bug Log - changes from CI_DRM_13302 -> Patchwork_119517v2 Summary

Re: [Intel-gfx] [PATCH v13 22/22] docs: vfio: Add vfio device cdev description

On Fri, 16 Jun 2023 02:39:46 -0700 Yi Liu wrote: > This gives notes for userspace applications on device cdev usage. > > Reviewed-by: Kevin Tian > Signed-off-by: Yi Liu > --- > Documentation/driver-api/vfio.rst | 139 ++ > 1 file changed, 139 insertions(+) > >

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/doc: fix duplicate declaration warning

== Series Details == Series: series starting with [1/2] drm/doc: fix duplicate declaration warning URL : https://patchwork.freedesktop.org/series/119677/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13302 -> Patchwork_119677v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/doc: fix duplicate declaration warning

== Series Details == Series: series starting with [1/2] drm/doc: fix duplicate declaration warning URL : https://patchwork.freedesktop.org/series/119677/ State : warning == Summary == Error: dim checkpatch failed 4273cf7c2b46 drm/doc: fix duplicate declaration warning -:8:

Re: [Intel-gfx] [PATCH 11/11] drm/i915/mtl: s/MTL/METEORLAKE for platform/subplatform defines

On Fri, Jun 16, 2023 at 01:05:08PM +0100, Tvrtko Ursulin wrote: > > On 16/06/2023 12:42, Dnyaneshwar Bhadane wrote: > > Follow consistent naming convention. Replace MTL with > > METEORLAKE > > > > Signed-off-by: Dnyaneshwar Bhadane > > --- > > drivers/gpu/drm/i915/display/intel_fbc.c |

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update (rev2)

== Series Details == Series: series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update (rev2) URL : https://patchwork.freedesktop.org/series/119676/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Update file owner during use

== Series Details == Series: drm: Update file owner during use URL : https://patchwork.freedesktop.org/series/119670/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13302 -> Patchwork_119670v1 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Update file owner during use

== Series Details == Series: drm: Update file owner during use URL : https://patchwork.freedesktop.org/series/119670/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PULL] drm-misc-fixes

Hi Dave, Daniel, Midsummer is nearly here! So sending the pull request a bit early. Cheers! ~Maarten drm-misc-fixes-2023-06-21: drm-misc-fixes for v6.4: - Qaic imported dma-buf fix. - Fix null pointer deref when printing a dp-mst message. The following changes since commit

Re: [Intel-gfx] [PATCH v4 2/6] dma-buf/heaps: Don't assert held reservation lock for dma-buf mmapping

On Wed, Jun 21, 2023 at 11:16 AM Dmitry Osipenko wrote: > > Hi, > > On 6/21/23 20:21, T.J. Mercier wrote: > > On Mon, May 29, 2023 at 3:46 PM Dmitry Osipenko > > wrote: > >> > >> Don't assert held dma-buf reservation lock on memory mapping of exported > >> buffer. > >> > >> We're going to change

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Unbind display fb immediately, v2.

== Series Details == Series: drm/i915: Unbind display fb immediately, v2. URL : https://patchwork.freedesktop.org/series/119663/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13301 -> Patchwork_119663v1 Summary ---

Re: [Intel-gfx] [PATCH v4 0/6] Move dma-buf mmap() reservation locking down to exporters

On 5/30/23 01:39, Dmitry Osipenko wrote: > This patchset makes dma-buf exporters responisble for taking care of > the reservation lock. I also included patch that moves drm-shmem to use > reservation lock, to let CI test the whole set. I'm going to take all > the patches via the drm-misc tree,

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Unbind display fb immediately, v2.

== Series Details == Series: drm/i915: Unbind display fb immediately, v2. URL : https://patchwork.freedesktop.org/series/119663/ State : warning == Summary == Error: dim checkpatch failed 3bd907f15af7 drm/i915: Unbind display fb immediately, v2. -:20: WARNING:LINE_SPACING: Missing a blank

Re: [Intel-gfx] [PATCH v2] drm/i915: Replace kmap() with kmap_local_page()

On 6/21/23 18:35, Ira Weiny wrote: Thomas Hellström (Intel) wrote: I think one thing worth mentioning in the context of this patch is that IIRC kmap_local_page() will block offlining of the mapping CPU until kunmap_local(), so while I haven't seen any guidelines around the usage of this api

[Intel-gfx] [PATCH] drm/i915/display: remove display raw reg read/write micro-optimizations

Convert the raw_reg_read() and raw_reg_write() calls in display GU MISC and INT CTL handling to regular intel_uncore_read() and intel_uncore_write(). These were neglible micro-optimizations, and removing them helps the display code reuse in the Xe driver. Signed-off-by: Jani Nikula ---

Re: [Intel-gfx] [PATCH v4 5/6] dma-buf: Change locking policy for mmap()

On 6/21/23 08:42, Christian König wrote: > Am 20.06.23 um 17:58 schrieb Dmitry Osipenko: >> On 5/31/23 22:58, Dmitry Osipenko wrote: >>> On 5/30/23 01:39, Dmitry Osipenko wrote: Change locking policy of mmap() callback, making exporters responsible for handling dma-buf reservation

Re: [Intel-gfx] [PATCH v4 2/6] dma-buf/heaps: Don't assert held reservation lock for dma-buf mmapping

Hi, On 6/21/23 20:21, T.J. Mercier wrote: > On Mon, May 29, 2023 at 3:46 PM Dmitry Osipenko > wrote: >> >> Don't assert held dma-buf reservation lock on memory mapping of exported >> buffer. >> >> We're going to change dma-buf mmap() locking policy such that exporters >> will have to handle the

Re: [Intel-gfx] [PATCH 00/11] Replace acronym with full platform name in defines.

> -Original Message- > From: Jani Nikula > Sent: Tuesday, June 20, 2023 9:31 AM > To: Bhadane, Dnyaneshwar ; intel- > g...@lists.freedesktop.org > Cc: Bhadane, Dnyaneshwar ; Srivatsa, > Anusha ; Tvrtko Ursulin > ; Joonas Lahtinen > > Subject: Re: [Intel-gfx] [PATCH 00/11] Replace

Re: [Intel-gfx] [PATCH v4 2/6] dma-buf/heaps: Don't assert held reservation lock for dma-buf mmapping

On Mon, May 29, 2023 at 3:46 PM Dmitry Osipenko wrote: > > Don't assert held dma-buf reservation lock on memory mapping of exported > buffer. > > We're going to change dma-buf mmap() locking policy such that exporters > will have to handle the lock. The previous locking policy caused deadlock >

Re: [Intel-gfx] [RFC 2/3] drm/i915/display: Configure and initialize HDMI audio capabilities

Hey, On Tue, 20 Jun 2023, Borah, Chaitanya Kumar wrote: > > -Original Message- > > From: Intel-gfx On Behalf Of Kai > > Vehmanen > > On Fri, 9 Jun 2023, Mitul Golani wrote: [...] > > This will hit a problem if we have a case where bandwidth is not enough for > > 5.1 > > at 192kHz, but

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hdcp: Add a debug statment at hcdp2 capability check (rev3)

== Series Details == Series: drm/i915/hdcp: Add a debug statment at hcdp2 capability check (rev3) URL : https://patchwork.freedesktop.org/series/119641/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13300 -> Patchwork_119641v3

[Intel-gfx] [PATCH 10/13] mm: Remove struct pagevec

All users are now converted to use the folio_batch so we can get rid of this data structure. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagevec.h | 63 +++-- mm/swap.c | 18 ++-- 2 files changed, 13 insertions(+), 68

[Intel-gfx] [PATCH 13/13] mm: Remove unnecessary pagevec includes

These files no longer need pagevec.h, mostly due to function declarations being moved out of it. Signed-off-by: Matthew Wilcox (Oracle) --- mm/fadvise.c| 1 - mm/memory_hotplug.c | 1 - mm/migrate.c| 1 - mm/readahead.c | 1 - mm/swap_state.c | 1 - 5 files changed, 5

[Intel-gfx] [PATCH 11/13] mm: Rename invalidate_mapping_pagevec to mapping_try_invalidate

We don't use pagevecs for the LRU cache any more, and we don't know that the failed invalidations were due to the folio being in an LRU cache. So rename it to be more accurate. Signed-off-by: Matthew Wilcox (Oracle) --- mm/fadvise.c | 16 +++- mm/internal.h | 4 ++--

[Intel-gfx] [PATCH 08/13] i915: Convert i915_gpu_error to use a folio_batch

Remove one of the last remaining users of pagevec. Signed-off-by: Matthew Wilcox (Oracle) --- drivers/gpu/drm/i915/i915_gpu_error.c | 50 +-- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c

[Intel-gfx] [PATCH 12/13] mm: Remove references to pagevec

Most of these should just refer to the LRU cache rather than the data structure used to implement the LRU cache. Signed-off-by: Matthew Wilcox (Oracle) --- mm/huge_memory.c| 2 +- mm/khugepaged.c | 6 +++--- mm/ksm.c| 6 +++--- mm/memory.c | 6 +++---

[Intel-gfx] [PATCH 09/13] net: Convert sunrpc from pagevec to folio_batch

Remove the last usage of pagevecs. There is a slight change here; we now free the folio_batch as soon as it fills up instead of freeing the folio_batch when we try to add a page to a full batch. This should have no effect in practice. Signed-off-by: Matthew Wilcox (Oracle) ---

[Intel-gfx] [PATCH 06/13] mm: Remove check_move_unevictable_pages()

All callers have now been converted to call check_move_unevictable_folios(). Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/swap.h | 1 - mm/vmscan.c | 17 - 2 files changed, 18 deletions(-) diff --git a/include/linux/swap.h b/include/linux/swap.h index

[Intel-gfx] [PATCH 04/13] i915: Convert shmem_sg_free_table() to use a folio_batch

Remove a few hidden compound_head() calls by converting the returned page to a folio once and using the folio APIs. We also only increment the refcount on the folio once instead of once for each page. Ideally, we would have a for_each_sgt_folio macro, but until then this will do. Signed-off-by:

[Intel-gfx] [PATCH 02/13] mm: Add __folio_batch_release()

This performs the same role as __pagevec_release(), ie skipping the check for batch length of 0. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagevec.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/linux/pagevec.h b/include/linux/pagevec.h index

[Intel-gfx] [PATCH 00/13] Remove pagevecs

We're almost done with the pagevec -> folio_batch conversion. Finish the job. Matthew Wilcox (Oracle) (13): afs: Convert pagevec to folio_batch in afs_extend_writeback() mm: Add __folio_batch_release() scatterlist: Add sg_set_folio() i915: Convert shmem_sg_free_table() to use a

[Intel-gfx] [PATCH 05/13] drm: Convert drm_gem_put_pages() to use a folio_batch

Remove a few hidden compound_head() calls by converting the returned page to a folio once and using the folio APIs. Signed-off-by: Matthew Wilcox (Oracle) --- drivers/gpu/drm/drm_gem.c | 68 ++- 1 file changed, 39 insertions(+), 29 deletions(-) diff --git

[Intel-gfx] [PATCH 01/13] afs: Convert pagevec to folio_batch in afs_extend_writeback()

Removes a folio->page->folio conversion for each folio that's involved. More importantly, removes one of the last few uses of a pagevec. Signed-off-by: Matthew Wilcox (Oracle) --- fs/afs/write.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/afs/write.c

[Intel-gfx] [PATCH 07/13] pagevec: Rename fbatch_count()

This should always have been called folio_batch_count(). Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagevec.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/pagevec.h b/include/linux/pagevec.h index 42aad53e382e..3a9d29dd28a3 100644 ---

[Intel-gfx] [PATCH 03/13] scatterlist: Add sg_set_folio()

This wrapper for sg_set_page() lets drivers add folios to a scatterlist more easily. We could, perhaps, do better by using a different page in the folio if offset is larger than UINT_MAX, but let's hope we get a better data structure than this before we need to care about such large folios.

Re: [Intel-gfx] [PATCH v2] drm/i915: Replace kmap() with kmap_local_page()

Thomas Hellström (Intel) wrote: > > I think one thing worth mentioning in the context of this patch is that > IIRC kmap_local_page() will block offlining of the mapping CPU until > kunmap_local(), so while I haven't seen any guidelines around the usage > of this api for long-held mappings, I

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Skip using vbt hdmi_level_shifter selection on MTL

On Wed, 21 Jun 2023, "Sripada, Radhakrishna" wrote: >> -Original Message- >> From: Jani Nikula >> Sent: Wednesday, June 21, 2023 12:32 AM >> To: Sripada, Radhakrishna ; Taylor, Clinton A >> ; intel-gfx@lists.freedesktop.org >> Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Skip using

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Skip using vbt hdmi_level_shifter selection on MTL

> -Original Message- > From: Jani Nikula > Sent: Wednesday, June 21, 2023 12:32 AM > To: Sripada, Radhakrishna ; Taylor, Clinton A > ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Skip using vbt > hdmi_level_shifter > selection on MTL > > On Tue,

Re: [Intel-gfx] [PATCH] drm/i915: Remove prototype for intel_cx0_phy_ddi_vswing_sequence()

Hi Gustavo, Looks good, On 6/14/2023 3:16 AM, Gustavo Sousa wrote: That function is not defined anywhere. Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/display/intel_cx0_phy.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.h

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc/slpc: Apply min softlimit correctly (rev2)

== Series Details == Series: drm/i915/guc/slpc: Apply min softlimit correctly (rev2) URL : https://patchwork.freedesktop.org/series/119162/ State : success == Summary == CI Bug Log - changes from CI_DRM_13297_full -> Patchwork_119162v2_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/huc: Fix missing error code in intel_huc_init() (rev2)

== Series Details == Series: drm/i915/huc: Fix missing error code in intel_huc_init() (rev2) URL : https://patchwork.freedesktop.org/series/119350/ State : success == Summary == CI Bug Log - changes from CI_DRM_13297_full -> Patchwork_119350v2_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix missing check for return value of dev_get_platdata()

== Series Details == Series: drm/i915: Fix missing check for return value of dev_get_platdata() URL : https://patchwork.freedesktop.org/series/119626/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13297_full -> Patchwork_119626v1_full

Re: [Intel-gfx] [PATCH v2] drm/i915: Replace kmap() with kmap_local_page()

On mercoledì 21 giugno 2023 11:06:51 CEST Thomas Hellström (Intel) wrote: > > I think one thing worth mentioning in the context of this patch is that > IIRC kmap_local_page() will block offlining of the mapping CPU until > kunmap_local(), Migration is disabled. > so while I haven't seen any

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915: Remove AUX CH sanitation

On Wed, Jun 21, 2023 at 11:00:31AM +0300, Jani Nikula wrote: > On Tue, 20 Jun 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Stop with the VBT AUX CH sanitation, and instead just check > > that the appropriate AUX CH is still available when initializing > > a DP/TC port. > > > > Note

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Call page_address() on page acquired with GFP_KERNEL flag

== Series Details == Series: drm/i915: Call page_address() on page acquired with GFP_KERNEL flag URL : https://patchwork.freedesktop.org/series/119625/ State : success == Summary == CI Bug Log - changes from CI_DRM_13297_full -> Patchwork_119625v1_full

[Intel-gfx] [PATCH 2/2] drm/i915: fix Sphinx indentation warning

Fix Sphinx warning about unexpected indent. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c b/drivers/gpu/drm/i915/gt/uc/intel_huc.c index bb95bdd1c3f9..23aa1b0e0166 100644 ---

[Intel-gfx] [PATCH 1/2] drm/doc: fix duplicate declaration warning

We have duplicate kernel-doc directives for the same struct, leading to: /home/jani/src/linux/Documentation/gpu/driver-uapi.rst:2279: WARNING: Duplicate C declaration, also defined at rfc/i915_scheduler:3. Declaration is '.. c:struct:: i915_context_engines_parallel_submit'. Use the Sphinx C

Re: [Intel-gfx] [PATCH] i915/display/hotplug: use drm_kms_helper_connector_hotplug_event()

On Wed, 21 Jun 2023, Simon Ser wrote: > On Wednesday, June 21st, 2023 at 14:11, Jani Nikula > wrote: > >> On Wed, 21 Jun 2023, Simon Ser cont...@emersion.fr wrote: >> >> > On Wednesday, June 21st, 2023 at 14:05, Jani Nikula jani.nik...@intel.com >> > wrote: >> > >> > > > - if (changed) >> >

Re: [Intel-gfx] [PATCH] i915/display/hotplug: use drm_kms_helper_connector_hotplug_event()

On Wednesday, June 21st, 2023 at 14:11, Jani Nikula wrote: > On Wed, 21 Jun 2023, Simon Ser cont...@emersion.fr wrote: > > > On Wednesday, June 21st, 2023 at 14:05, Jani Nikula jani.nik...@intel.com > > wrote: > > > > > > - if (changed) > > > > + if (hweight32(changed) == 1) > > > > +

Re: [Intel-gfx] [PATCH] i915/display/hotplug: use drm_kms_helper_connector_hotplug_event()

On Wed, 21 Jun 2023, Simon Ser wrote: > On Wednesday, June 21st, 2023 at 14:05, Jani Nikula > wrote: > >> > - if (changed) >> > + if (hweight32(changed) == 1) >> > + drm_kms_helper_connector_hotplug_event(first_changed_connector); >> >> What if more than one connector share the same hpd pin? >

Re: [Intel-gfx] [PATCH] i915/display/hotplug: use drm_kms_helper_connector_hotplug_event()

On Wednesday, June 21st, 2023 at 14:05, Jani Nikula wrote: > > - if (changed) > > + if (hweight32(changed) == 1) > > + drm_kms_helper_connector_hotplug_event(first_changed_connector); > > What if more than one connector share the same hpd pin? Ah, I did not believe this could happen. I'll

Re: [Intel-gfx] [PATCH] i915/display/hotplug: use drm_kms_helper_connector_hotplug_event()

On Tue, 20 Jun 2023, Simon Ser wrote: > This adds more information to the hotplug uevent and lets user-space > know that it's about a particular connector only. > > Signed-off-by: Simon Ser > Cc: Jani Nikula > Cc: Ville Syrjälä > Cc: Rodrigo Vivi > Cc: Gustavo Sousa > Cc: Imre Deak > Cc:

[Intel-gfx] [PATCH] drm/i915: Handle legacy cursor update as normal update

Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_display.c | 15 ++- .../gpu/drm/i915/display/intel_display_types.h| 2 +- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: fix memory leak of panel->vbt.lfp_lvds_vbt_mode

== Series Details == Series: drm/i915/dp: fix memory leak of panel->vbt.lfp_lvds_vbt_mode URL : https://patchwork.freedesktop.org/series/119623/ State : success == Summary == CI Bug Log - changes from CI_DRM_13297_full -> Patchwork_119623v1_full

[Intel-gfx] [PATCH 1/2] drm/i915: Swap ggtt_vma during legacy cursor update

Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_cursor.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c b/drivers/gpu/drm/i915/display/intel_cursor.c index 4962247911d41..6f34098ea314d 100644 ---

[Intel-gfx] [PATCH 2/2] drm/i915: Handle legacy cursor update as normal update

Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_display.c | 15 ++- .../gpu/drm/i915/display/intel_display_types.h| 2 +- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c

Re: [Intel-gfx] [PATCH 00/11] Replace acronym with full platform name in defines.

On Wed, 21 Jun 2023, Tvrtko Ursulin wrote: > Historically we were not avoiding churn if we could sense a real > gain. I tried but failed to say, if we're going to churn, let's at least go through this properly instead of churning, and then churning again, and again. BR, Jani. -- Jani Nikula,

Re: [Intel-gfx] [PATCH] drm/i915/psr: Use hw.adjusted mode when calculating io/fast wake times

On Wed, 2023-06-21 at 06:59 +, Kahola, Mika wrote: > > -Original Message- > > From: Intel-gfx On Behalf > > Of Jouni Högander > > Sent: Tuesday, June 20, 2023 2:18 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [Intel-gfx] [PATCH] drm/i915/psr: Use hw.adjusted mode > > when

Re: [Intel-gfx] [PATCH 00/11] Replace acronym with full platform name in defines.

On 20/06/2023 17:30, Jani Nikula wrote: On Thu, 15 Jun 2023, Dnyaneshwar Bhadane wrote: Replace all occurences of ADL with ALDERLAKE, TGL with TIGERLAKE, MTL with METEORLAKE, RKL with ROCKETLAKE, JSL with JASPERLAKE, KBL with KABYLAKE and SKL with SKYLAKE in platform and subplatform defines.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dp: fix a memory leak in struct intel_vbt_panel_data (rev2)

== Series Details == Series: drm/i915/dp: fix a memory leak in struct intel_vbt_panel_data (rev2) URL : https://patchwork.freedesktop.org/series/119046/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13297_full -> Patchwork_119046v2_full

[Intel-gfx] [PULL] drm-intel-next-fixes

Hi Dave, Daniel, A weekly collection of fixes for the drm-next/6.5 merge window: One fix for incorrect error handling in the frame buffer mmap callback, HuC init error handling fix, missing wakeref during GSC init and a build fix when !CONFIG_PROC_FS. Regards, Tvrtko

[Intel-gfx] [PATCH v2] drm: Update file owner during use

From: Tvrtko Ursulin With the typical model where the display server opens the file descriptor and then hands it over to the client(*), we were showing stale data in debugfs. Fix it by updating the drm_file->pid on ioctl access from a different process. The field is also made RCU protected to

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915/display/hotplug: use drm_kms_helper_connector_hotplug_event()

== Series Details == Series: i915/display/hotplug: use drm_kms_helper_connector_hotplug_event() URL : https://patchwork.freedesktop.org/series/119603/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13297_full -> Patchwork_119603v1_full

Re: [Intel-gfx] [PATCH v13 00/22] Add vfio_device cdev for iommufd support

>-Original Message- >From: Liu, Yi L >Sent: Friday, June 16, 2023 5:39 PM >Subject: [PATCH v13 00/22] Add vfio_device cdev for iommufd support >... Per Yi's suggestion, wrote a selftest app to verify functions of this patchset by referencing https://github.com/awilliam/tests/ Test

Re: [Intel-gfx] [PATCH v2] drm/i915: Replace kmap() with kmap_local_page()

On 6/20/23 20:07, Sumitra Sharma wrote: On Tue, Jun 20, 2023 at 06:23:38AM -0700, Ira Weiny wrote: Sumitra Sharma wrote: On Sun, Jun 18, 2023 at 11:11:08AM -0700, Ira Weiny wrote: Sumitra Sharma wrote: kmap() has been deprecated in favor of the kmap_local_page() due to high cost,

[Intel-gfx] [PATCH] drm/i915: Unbind display fb immediately, v2.

Share the pain with xe to test if it hits the same bugs.. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_fb_pin.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.c b/drivers/gpu/drm/i915/display/intel_fb_pin.c index

Re: [Intel-gfx] [PATCH] drm/i915/display/dp: Remove support for UHBR13.5

On Wed, 21 Jun 2023, "Kandpal, Suraj" wrote: >> As per the DP2.1 Spec support for UHBR13.5 is optional. Hence removing the >> support for UHBR13.5 >> UHBR10 can be used for 6k panels. >> >> Signed-off-by: Arun R Murthy > > Looks Good to me How? There are a *lot* of things that are optional in

Re: [Intel-gfx] [PATCH] drm/i915/display/dp: Remove support for UHBR13.5

On Tue, 20 Jun 2023, Arun R Murthy wrote: > As per the DP2.1 Spec support for UHBR13.5 is optional. Hence removing > the support for UHBR13.5 That's just not a proper rationale. Please explain. BR, Jani. > UHBR10 can be used for 6k panels. > > Signed-off-by: Arun R Murthy > --- >

[Intel-gfx] [PATCH v3] drm/i915/hdcp: Add a debug statement at hdcp2 capability check

Add a debug statement at hdcp2 capability check which indicates if GSC CS is causing hdcp2 incapability --v2 -correcttypo in commit header --v3 -correct the other typo in commit header [Jani] Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 5 - 1 file changed,

Re: [Intel-gfx] [PATCH] drm/i915/display/dp: Remove support for UHBR13.5

> As per the DP2.1 Spec support for UHBR13.5 is optional. Hence removing the > support for UHBR13.5 > UHBR10 can be used for 6k panels. > > Signed-off-by: Arun R Murthy Looks Good to me Reviewed-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/display/intel_dp.c | 2 +- > 1 file changed, 1

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Regression Tracking: Build failure in Linux-next

== Series Details == Series: Regression Tracking: Build failure in Linux-next URL : https://patchwork.freedesktop.org/series/119655/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/119655/revisions/1/mbox/ not applied Applying: Regression

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915: Remove AUX CH sanitation

On Tue, 20 Jun 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Stop with the VBT AUX CH sanitation, and instead just check > that the appropriate AUX CH is still available when initializing > a DP/TC port. > > Note that the old way of sanitizing gave priority to the last > port declared in

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Remove DDC pin sanitation

On Tue, 20 Jun 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Stop with the VBT DDC pin sanitation, and instead just check > that the appropriate DDC pin is still available when initializing > a HDMI connector. Could be more verbose about the why here. > Signed-off-by: Ville Syrjälä >

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: Only populate aux_ch is really needed

On Tue, 20 Jun 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Mixing VBT based AUX CH with platform defaults seems like > a recipe for conflicts. Let's only populate AUX CH if we > absolutely need it, that is only if we are dealing with > a DP output or a TC port (which need it due to some

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/psr: Use hw.adjusted mode when calculating io/fast wake times

Possible regressions here are not related to my patch. BR, Jouni Högander On Tue, 2023-06-20 at 22:48 +, Patchwork wrote: Patch Details Series: drm/i915/psr: Use hw.adjusted mode when calculating io/fast wake times URL:https://patchwork.freedesktop.org/series/119580/ State: failure

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: Only populate aux_ch is really needed

On Wed, 21 Jun 2023, Jani Nikula wrote: > On Tue, 20 Jun 2023, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> Mixing VBT based AUX CH with platform defaults seems like >> a recipe for conflicts. Let's only populate AUX CH if we >> absolutely need it, that is only if we are dealing with >> a

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Initialize dig_port->aux_ch to NONE to be sure

On Tue, 20 Jun 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Make sure dig_port->aux_ch is trustworthy by initializing it > to NONE (-1) at the start. The encoder init will later fill in > the actual value, if appropriate. Smells like we could add intel_dig_port_alloc() and shove this

Re: [Intel-gfx] [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

Hi, On 2023/6/16 22:34, Alex Deucher wrote: On Fri, Jun 16, 2023 at 10:22 AM Sui Jingfeng wrote: On 2023/6/16 21:41, Alex Deucher wrote: On Fri, Jun 16, 2023 at 3:11 AM Sui Jingfeng wrote: Hi, On 2023/6/16 05:11, Alex Deucher wrote: On Wed, Jun 14, 2023 at 6:50 AM Sui Jingfeng wrote:

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Skip using vbt hdmi_level_shifter selection on MTL

On Tue, 20 Jun 2023, "Sripada, Radhakrishna" wrote: > Merged. Thank you for the review. Where are the CI results? Please never merge patches without CI results. BR, Jani. > > --Radhakrishna(RK) Sripada > >> -Original Message- >> From: Taylor, Clinton A >> Sent: Tuesday, June 20,

Re: [Intel-gfx] [PATCH v2] drm/i915/hdcp: Add a debug statment at hdcp2 capability check

On Wed, 21 Jun 2023, Suraj Kandpal wrote: > Add a debug statement at hdcp2 capability check which indicates if > GSC CS is causing hdcp2 incapability > > --v2 > -correcting typo in commit header Maybe fix the other typo as well? ;) BR, Jani. > > Signed-off-by: Suraj Kandpal > --- >

[Intel-gfx] Regression Tracking: Build failure in Linux-next

Hello all, Since version next-20230613[1], we have observed build failures in the linux-next tree [2] We have bisected the issue to the following patch[3]. commit ef104443bffa004f631729dfc924f0b84abbd602 Author: Arnd Bergmann a...@arndb.de Date: Tue May 16 21:57:29 2023 +0200 procfs:

Re: [Intel-gfx] [PATCH] drm/i915/psr: Use hw.adjusted mode when calculating io/fast wake times

> -Original Message- > From: Intel-gfx On Behalf Of Jouni > Högander > Sent: Tuesday, June 20, 2023 2:18 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH] drm/i915/psr: Use hw.adjusted mode when > calculating io/fast wake times > > Encoder compute config is

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Update workaround 14018778641

Hi Tejas, On Mon, Jun 19, 2023 at 02:33:26PM +0530, Tejas Upadhyay wrote: > WA 14018778641 needs an update after recent > performance data on MTL, aligning driver here with > HW WA update. > > Signed-off-by: Tejas Upadhyay Reviewed-by: Andi Shyti Andi