RE: [PATCH] drm/i915/psr: Use crtc_state->port_clock instead of intel_dp->link_rate

2024-04-10 Thread Manna, Animesh
> -Original Message- > From: Hogander, Jouni > Sent: Tuesday, April 9, 2024 2:28 PM > To: intel-gfx@lists.freedesktop.org > Cc: Manna, Animesh ; Hogander, Jouni > > Subject: [PATCH] drm/i915/psr: Use crtc_state->port_clock instead of > intel_dp->link_rate > > Intel_dp->link_rate is

Re: [PATCH] drm/i915: Don't enable hwmon for selftests

2024-04-10 Thread Dixit, Ashutosh
On Wed, 10 Apr 2024 04:42:46 -0700, Ville Syrjälä wrote: > > On Tue, Apr 09, 2024 at 09:28:55PM -0700, Ashutosh Dixit wrote: > > There are no hwmon selftests so there is no need to enable hwmon for > > selftests. So enable hwmon only for real driver load. > > > > Closes:

Re: [PATCH] drm/i915: Don't enable hwmon for selftests

2024-04-10 Thread Dixit, Ashutosh
On Wed, 10 Apr 2024 06:53:15 -0700, Andi Shyti wrote: > Hi Andi, > please use "git format-patch -v 3 ..." which generates subject > [PATCH v3] ...". Otherwise it gets confusing to see the patch > that needs to be reviewed. Sure, sorry! > > On Tue, Apr 09, 2024 at 11:05:49PM -0700, Ashutosh

✗ Fi.CI.BAT: failure for drm/i915/dg2: wait for HuC load completion before running selftests

2024-04-10 Thread Patchwork
== Series Details == Series: drm/i915/dg2: wait for HuC load completion before running selftests URL : https://patchwork.freedesktop.org/series/132300/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14561 -> Patchwork_132300v1

Re: [PATCH i-g-t v2] lib/kunit: Read results from debugfs

2024-04-10 Thread Lucas De Marchi
On Wed, Apr 10, 2024 at 08:28:40PM +0200, Janusz Krzysztofik wrote: Hi Lucas, On Friday, 5 April 2024 19:54:53 CEST Janusz Krzysztofik wrote: KUnit can provide KTAP reports from test modules via debugfs files, one per test suite. Using that source of test results instead of extracting them

Re: [PATCH 00/10] drm: move Intel drm headers to a subdirectory

2024-04-10 Thread Lucas De Marchi
On Wed, Apr 10, 2024 at 01:05:07PM +0300, Jani Nikula wrote: We've accumulated enough Intel specific header files under include/drm that they warrant a subdirectory of their own. Clean up the top drm header directory by moving the Intel files under include/drm/intel. Since i915 is most

✗ Fi.CI.BAT: failure for drm/i915: Don't enable hwmon for selftests (rev4)

2024-04-10 Thread Patchwork
== Series Details == Series: drm/i915: Don't enable hwmon for selftests (rev4) URL : https://patchwork.freedesktop.org/series/132243/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14561 -> Patchwork_132243v4 Summary

[PULL] drm-intel-fixes

2024-04-10 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes drm-intel-fixes-2024-04-10: Display fixes: - Couple CDCLK programming fixes (Ville) - HDCP related fix (Suraj) - 4 Bigjoiner related fixes (Ville) Core fix: - Fix for a circular locking around GuC on reset+wedged case (John) Thanks, Rodrigo. The following changes

✗ Fi.CI.SPARSE: warning for drm/i915: Don't enable hwmon for selftests (rev4)

2024-04-10 Thread Patchwork
== Series Details == Series: drm/i915: Don't enable hwmon for selftests (rev4) URL : https://patchwork.freedesktop.org/series/132243/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for drm/edid: Parse topology block for all DispID structure v1.x

2024-04-10 Thread Patchwork
== Series Details == Series: drm/edid: Parse topology block for all DispID structure v1.x URL : https://patchwork.freedesktop.org/series/132292/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14561 -> Patchwork_132292v1

[PATCH] drm/i915/dg2: wait for HuC load completion before running selftests

2024-04-10 Thread Daniele Ceraolo Spurio
On DG2, submissions to VCS engines tied to a gem context are blocked until the HuC is loaded. Since some selftests do use a gem context, wait for the HuC load to complete before running the tests to avoid contamination. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10564

✗ Fi.CI.BAT: failure for drm/i915/pps: pass display to PPS register macros (rev2)

2024-04-10 Thread Patchwork
== Series Details == Series: drm/i915/pps: pass display to PPS register macros (rev2) URL : https://patchwork.freedesktop.org/series/132286/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14560 -> Patchwork_132286v2 Summary

[PATCH] drm/i915: Don't enable hwmon for selftests

2024-04-10 Thread Ashutosh Dixit
There are no hwmon selftests so there is no need to enable hwmon for selftests. So enable hwmon only for real driver load. v2: Move the logic inside i915_hwmon.c v3: Move is_i915_selftest definition to i915_selftest.h (Badal) v4: s/is_i915_selftest/is_i915_selftest_module/ Closes:

✗ Fi.CI.CHECKPATCH: warning for drm/i915/pps: pass display to PPS register macros (rev2)

2024-04-10 Thread Patchwork
== Series Details == Series: drm/i915/pps: pass display to PPS register macros (rev2) URL : https://patchwork.freedesktop.org/series/132286/ State : warning == Summary == Error: dim checkpatch failed 760f2ae26bc9 drm/i915/pps: pass display to PPS register macros -:57: WARNING:LONG_LINE: line

✓ Fi.CI.BAT: success for drm/i915/dsi: stop relying on implicit dev_priv variable

2024-04-10 Thread Patchwork
== Series Details == Series: drm/i915/dsi: stop relying on implicit dev_priv variable URL : https://patchwork.freedesktop.org/series/132285/ State : success == Summary == CI Bug Log - changes from CI_DRM_14559 -> Patchwork_132285v1 Summary

✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: stop relying on implicit dev_priv variable

2024-04-10 Thread Patchwork
== Series Details == Series: drm/i915/dsi: stop relying on implicit dev_priv variable URL : https://patchwork.freedesktop.org/series/132285/ State : warning == Summary == Error: dim checkpatch failed 02b70fe522db drm/i915/dsi: remove unused _MIPIA_AUTOPWG register definition 1b83a12b11bd

Re: [PATCH i-g-t v2] lib/kunit: Read results from debugfs

2024-04-10 Thread Janusz Krzysztofik
Hi Lucas, On Friday, 5 April 2024 19:54:53 CEST Janusz Krzysztofik wrote: > KUnit can provide KTAP reports from test modules via debugfs files, one > per test suite. Using that source of test results instead of extracting > them from dmesg, where they may be interleaved with other kernel

[PATCH] drm/edid: Parse topology block for all DispID structure v1.x

2024-04-10 Thread Ville Syrjala
From: Ville Syrjälä DisplayID spec v1.3 revision history notes do claim that the toplogy block was added in v1.3 so requiring structure v1.2 would seem correct, but there is at least one EDID in edid.tv with a topology block and structure v1.0. And there are also EDIDs with DisplayID structure

[linux-next:master] BUILD REGRESSION 6ebf211bb11dfc004a2ff73a9de5386fa309c430

2024-04-10 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 6ebf211bb11dfc004a2ff73a9de5386fa309c430 Add linux-next specific files for 20240410 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202404102353.cv1gujk3-...@intel.com Error

Re: [PATCH] drm/i915/pps: pass display to PPS register macros

2024-04-10 Thread Jani Nikula
On Wed, 10 Apr 2024, Jani Nikula wrote: > Pass struct intel_display pointer to PPS register macros intead of > implicitly relying on the dev_priv local variable. > > Signed-off-by: Jani Nikula Whoops, accidentally sent the same patch twice, with slightly different commit messages. -- Jani

[PATCH] drm/i915/pps: pass display to PPS register macros

2024-04-10 Thread Jani Nikula
Pass struct intel_display pointer to PPS register macros intead of implicitly relying on the dev_priv local variable. Signed-off-by: Jani Nikula --- Mostly see how this feels. Might be better to wait for [1] to land so we could more easily pass display pointer everywhere. I don't really want

[PATCH] drm/i915/pps: pass display to PPS register macros

2024-04-10 Thread Jani Nikula
Pass struct intel_display pointer to PPS register macros intead of implicitly relying on the dev_priv local variable. Signed-off-by: Jani Nikula --- Mostly see how this feels. Might be better to wait for [1] to land so we could more easily pass display pointer everywhere. [1]

[PATCH 3/3] drm/i915/dsi: pass i915 to register macros instead of implicit variable

2024-04-10 Thread Jani Nikula
Stop relying on the dev_priv local variable in the DSI register macros. Pass i915 pointer to the macros. Move the MIPI DSI MMIO base selection to a different level, passing it to _MMIO_MIPI() and doing the addition there. Signed-off-by: Jani Nikula --- Tip: Applying the patch and using 'git

[PATCH 2/3] drm/i915/dsi: add VLV_ prefix to VLV only register macros

2024-04-10 Thread Jani Nikula
All the BXT specific macros have BXT_ prefix, do the same for VLV for consistency. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/vlv_dsi.c | 6 +++--- drivers/gpu/drm/i915/display/vlv_dsi_regs.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 1/3] drm/i915/dsi: remove unused _MIPIA_AUTOPWG register definition

2024-04-10 Thread Jani Nikula
There are other unused registers, but this is also unusable and inadequate. Remove. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/vlv_dsi_regs.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/vlv_dsi_regs.h

[PATCH 0/3] drm/i915/dsi: stop relying on implicit dev_priv variable

2024-04-10 Thread Jani Nikula
Rip the band-aid, it's not so bad after all. Well, at least for the somewhat isolated VLV DSI. But it's a start. Jani Nikula (3): drm/i915/dsi: remove unused _MIPIA_AUTOPWG register definition drm/i915/dsi: add VLV_ prefix to VLV only register macros drm/i915/dsi: pass i915 to register

Re: ✓ Fi.CI.BAT: success for drm/i915/dp: Add jitter WAs for MST/FEC/DSC links

2024-04-10 Thread Imre Deak
On Mon, Jan 29, 2024 at 06:42:39PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dp: Add jitter WAs for MST/FEC/DSC links > URL : https://patchwork.freedesktop.org/series/129277/ > State : success Patchset is pushed to drm-intel-next, fixing the WA code comment in patch

Re: [PATCH] drm/dp: correct struct member name in documentation

2024-04-10 Thread Rodrigo Vivi
On Fri, Apr 05, 2024 at 12:21:59PM +0530, Mitul Golani wrote: > Correct struct member name to 'mode' instead of 'operation mode' > in 'drm_dp_as_sdp' structure description. > > Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") Probably good to avoid this 'Fixes:' tag, and only use

✓ Fi.CI.BAT: success for series starting with [1/2] drm/print: drop include debugfs.h and include where needed

2024-04-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/print: drop include debugfs.h and include where needed URL : https://patchwork.freedesktop.org/series/132280/ State : success == Summary == CI Bug Log - changes from CI_DRM_14557 -> Patchwork_132280v1

Re: ✗ Fi.CI.BAT: failure for drm/i915: Bigjoiner modeset sequence redesign and MST support (rev4)

2024-04-10 Thread Ville Syrjälä
On Wed, Apr 10, 2024 at 05:34:13PM +0300, Ville Syrjälä wrote: > On Tue, Apr 09, 2024 at 06:12:09PM -, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915: Bigjoiner modeset sequence redesign and MST support (rev4) > > URL : https://patchwork.freedesktop.org/series/131797/ >

✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/print: drop include debugfs.h and include where needed

2024-04-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/print: drop include debugfs.h and include where needed URL : https://patchwork.freedesktop.org/series/132280/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

✓ Fi.CI.BAT: success for drm/i915: Implement Audio WA_14020863754 (rev2)

2024-04-10 Thread Patchwork
== Series Details == Series: drm/i915: Implement Audio WA_14020863754 (rev2) URL : https://patchwork.freedesktop.org/series/132255/ State : success == Summary == CI Bug Log - changes from CI_DRM_14557 -> Patchwork_132255v2 Summary ---

[PULL] drm-misc-next

2024-04-10 Thread Maarten Lankhorst
Hi Dave, Sima, Still low amount of patches this week! Cheers, ~Maarten drm-misc-next-2024-04-10: drm-misc-next for v6.10: Cross-subsystem Changes: - Add Tomi as Xilinx maintainer. - Add sound bindings to DT. Core Changes: - Make DP helper depend on KMS helper. Driver Changes: - Assorted

Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-10 Thread Andrzej Hajda
On 10.04.2024 16:14, Jani Nikula wrote: Surprisingly many places depend on debugfs.h to be included via drm_print.h. Fix them. Signed-off-by: Jani Nikula --- Reviewed-by: Andrzej Hajda Regards Andrzej Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc:

Re: ✗ Fi.CI.BAT: failure for drm/i915: Bigjoiner modeset sequence redesign and MST support (rev4)

2024-04-10 Thread Ville Syrjälä
On Tue, Apr 09, 2024 at 06:12:09PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Bigjoiner modeset sequence redesign and MST support (rev4) > URL : https://patchwork.freedesktop.org/series/131797/ > State : failure > > == Summary == > > CI Bug Log - changes from

Re: [PATCH 02/10] drm: move intel-gtt.h under include/drm/intel

2024-04-10 Thread Andi Shyti
On Wed, Apr 10, 2024 at 01:05:09PM +0300, Jani Nikula wrote: > Clean up the top level include/drm directory by grouping all the Intel > specific files under a common subdirectory. > > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: Lucas De Marchi > Signed-off-by: Jani Nikula Reviewed-by: Andi

[PATCH 2/2] drm/print: drop include seq_file.h

2024-04-10 Thread Jani Nikula
Never include where a forward declaration will suffice. Signed-off-by: Jani Nikula --- include/drm/drm_print.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h index 561c3b96b6fd..089950ad8681 100644 ---

[PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-10 Thread Jani Nikula
Surprisingly many places depend on debugfs.h to be included via drm_print.h. Fix them. Signed-off-by: Jani Nikula --- Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas

Re: [PATCH 01/10] drm/i915: use system include for drm headers

2024-04-10 Thread Andi Shyti
Hi Jani, On Wed, Apr 10, 2024 at 01:05:08PM +0300, Jani Nikula wrote: > Use <> instead of "" for including headers from include/, even if the > file is in the same directory. > > Signed-off-by: Jani Nikula Reviewed-by: Andi Shyti Thanks, Andi

Re: [PATCH 05/10] drm/i915: skip DRM_I915_LOW_LEVEL_TRACEPOINTS with NOTRACE

2024-04-10 Thread Steven Rostedt
On Wed, 10 Apr 2024 13:08:57 +0200 Sebastian Andrzej Siewior wrote: > On 2024-04-09 11:55:33 [-0400], Steven Rostedt wrote: > > I believe you need to do it in the .c file: > > > > Can you try something like this? > > > … > > ? > > I tried and nothing changed because the lowlevel config

Re: [PATCH] drm/i915: Don't enable hwmon for selftests

2024-04-10 Thread Andi Shyti
Hi Ashutosh, please use "git format-patch -v 3 ..." which generates subject [PATCH v3] ...". Otherwise it gets confusing to see the patch that needs to be reviewed. On Tue, Apr 09, 2024 at 11:05:49PM -0700, Ashutosh Dixit wrote: > There are no hwmon selftests so there is no need to enable hwmon

[v2] drm/i915: Implement Audio WA_14020863754

2024-04-10 Thread Uma Shankar
WA_14020863754: Corner case with Min Hblank Fix can cause audio hang Issue: Previously a fix was made to avoid issues with extremely small hblanks, called the "Min Hblank Fix". However, this can potentially cause an audio hang. Workaround : During "Audio Programming Sequence" Audio Enabling -

RE: [PATCH] drm/i915: Implement Audio WA_14020863754

2024-04-10 Thread Shankar, Uma
> -Original Message- > From: Jani Nikula > Sent: Wednesday, April 10, 2024 3:47 PM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; > intel...@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar ; Shankar, Uma > > Subject: Re: [PATCH] drm/i915: Implement Audio WA_14020863754 > >

Re: [PATCH v4] drm/i915/panelreplay: Panel replay workaround with VRR

2024-04-10 Thread Ville Syrjälä
On Wed, Apr 10, 2024 at 07:41:42AM +, Hogander, Jouni wrote: > On Wed, 2024-04-10 at 07:35 +, Manna, Animesh wrote: > > > > > > > -Original Message- > > > From: Hogander, Jouni > > > Sent: Wednesday, April 10, 2024 12:54 PM > > > To: Manna, Animesh ; intel- > > >

✓ Fi.CI.BAT: success for drm/i915: PREEMPT_RT related fixups. (rev6)

2024-04-10 Thread Patchwork
== Series Details == Series: drm/i915: PREEMPT_RT related fixups. (rev6) URL : https://patchwork.freedesktop.org/series/95463/ State : success == Summary == CI Bug Log - changes from CI_DRM_14554 -> Patchwork_95463v6 Summary ---

Re: [PATCH v2] drm: ensure drm headers are self-contained and pass kernel-doc

2024-04-10 Thread Jani Nikula
On Tue, 02 Apr 2024, Jani Nikula wrote: > Ensure drm headers build, are self-contained, have header guards, and > have no kernel-doc warnings, when CONFIG_DRM_HEADER_TEST=y. > > The mechanism follows similar patters used in i915, xe, and usr/include. > > To cover include/drm, we need to recurse

Re: [PATCH] drm/i915: Don't enable hwmon for selftests

2024-04-10 Thread Ville Syrjälä
On Tue, Apr 09, 2024 at 09:28:55PM -0700, Ashutosh Dixit wrote: > There are no hwmon selftests so there is no need to enable hwmon for > selftests. So enable hwmon only for real driver load. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10366 > Signed-off-by: Ashutosh Dixit Why

Re: [PATCH] drm/i915/pps: move pps debugfs file to intel_pps.c

2024-04-10 Thread Jani Nikula
On Mon, 08 Apr 2024, Ville Syrjälä wrote: > On Mon, Apr 08, 2024 at 12:43:57PM +0300, Jani Nikula wrote: >> Continue with placing debugfs next to the implementation. >> >> Signed-off-by: Jani Nikula >> --- >> .../drm/i915/display/intel_display_debugfs.c | 27 ++-- >>

✗ Fi.CI.SPARSE: warning for drm/i915: PREEMPT_RT related fixups. (rev6)

2024-04-10 Thread Patchwork
== Series Details == Series: drm/i915: PREEMPT_RT related fixups. (rev6) URL : https://patchwork.freedesktop.org/series/95463/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: PREEMPT_RT related fixups. (rev6)

2024-04-10 Thread Patchwork
== Series Details == Series: drm/i915: PREEMPT_RT related fixups. (rev6) URL : https://patchwork.freedesktop.org/series/95463/ State : warning == Summary == Error: dim checkpatch failed dc8b0da9b41f drm/i915: Use preempt_disable/enable_rt() where recommended -:7: WARNING:COMMIT_LOG_LONG_LINE:

✓ Fi.CI.BAT: success for drm: move Intel drm headers to a subdirectory (rev2)

2024-04-10 Thread Patchwork
== Series Details == Series: drm: move Intel drm headers to a subdirectory (rev2) URL : https://patchwork.freedesktop.org/series/132264/ State : success == Summary == CI Bug Log - changes from CI_DRM_14554 -> Patchwork_132264v2 Summary

Re: [PATCH 05/10] drm/i915: skip DRM_I915_LOW_LEVEL_TRACEPOINTS with NOTRACE

2024-04-10 Thread Sebastian Andrzej Siewior
On 2024-04-09 11:55:33 [-0400], Steven Rostedt wrote: > I believe you need to do it in the .c file: > > Can you try something like this? > … > ? I tried and nothing changed because the lowlevel config option isn't the problem. What about I drop this and replace 4/10 from this series with the

✗ Fi.CI.SPARSE: warning for drm: move Intel drm headers to a subdirectory (rev2)

2024-04-10 Thread Patchwork
== Series Details == Series: drm: move Intel drm headers to a subdirectory (rev2) URL : https://patchwork.freedesktop.org/series/132264/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm: move Intel drm headers to a subdirectory (rev2)

2024-04-10 Thread Patchwork
== Series Details == Series: drm: move Intel drm headers to a subdirectory (rev2) URL : https://patchwork.freedesktop.org/series/132264/ State : warning == Summary == Error: dim checkpatch failed 0a89e58276c7 drm/i915: use system include for drm headers 0ef68bf2213b drm: move intel-gtt.h

✓ Fi.CI.BAT: success for drm: move Intel drm headers to a subdirectory

2024-04-10 Thread Patchwork
== Series Details == Series: drm: move Intel drm headers to a subdirectory URL : https://patchwork.freedesktop.org/series/132264/ State : success == Summary == CI Bug Log - changes from CI_DRM_14554 -> Patchwork_132264v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm: move Intel drm headers to a subdirectory

2024-04-10 Thread Patchwork
== Series Details == Series: drm: move Intel drm headers to a subdirectory URL : https://patchwork.freedesktop.org/series/132264/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm: move Intel drm headers to a subdirectory

2024-04-10 Thread Patchwork
== Series Details == Series: drm: move Intel drm headers to a subdirectory URL : https://patchwork.freedesktop.org/series/132264/ State : warning == Summary == Error: dim checkpatch failed 8c970e29f651 drm/i915: use system include for drm headers 81251adf0df4 drm: move intel-gtt.h under

[PATCH v2] drm: move i915_drm.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. v2: Also fix comment in intel_pci_config.h (Ilpo) Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Bjorn Helgaas Cc: Hans de Goede Cc: Ilpo Järvinen Signed-off-by:

Re: [PATCH 06/10] drm: move i915_drm.h under include/drm/intel

2024-04-10 Thread Jani Nikula
On Wed, 10 Apr 2024, Ilpo Järvinen wrote: > Could you please also address the comment in > drivers/gpu/drm/i915/intel_pci_config.h. Ack. -- Jani Nikula, Intel

Re: [PATCH 06/10] drm: move i915_drm.h under include/drm/intel

2024-04-10 Thread Ilpo Järvinen
On Wed, 10 Apr 2024, Jani Nikula wrote: > Clean up the top level include/drm directory by grouping all the Intel > specific files under a common subdirectory. > > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: Lucas De Marchi > Cc: Bjorn Helgaas > Cc: Hans de Goede > Cc: Ilpo Järvinen >

Re: [PATCH] drm/i915: Implement Audio WA_14020863754

2024-04-10 Thread Jani Nikula
On Wed, 10 Apr 2024, Uma Shankar wrote: > WA_14020863754: Corner case with Min Hblank Fix can cause > audio hang > > Issue: Previously a fix was made to avoid issues with extremely > small hblanks, called the "Min Hblank Fix". However, this can > potentially cause an audio hang. > > Workaround :

Re: ✗ Fi.CI.BAT: failure for drm/edid & drm/i915: vendor and product id logging improvements (rev3)

2024-04-10 Thread Jani Nikula
On Wed, 10 Apr 2024, Patchwork wrote: > == Series Details == > > Series: drm/edid & drm/i915: vendor and product id logging improvements (rev3) > URL : https://patchwork.freedesktop.org/series/131414/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_14552 ->

[PATCH 09/10] drm: move xe_pciids.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/xe_pci.c | 2 +- include/drm/{ => intel}/xe_pciids.h | 0 2 files

[PATCH 10/10] drm: move i915_hdcp_interface.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Tomas Winkler Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_types.h| 2 +-

[PATCH 06/10] drm: move i915_drm.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Bjorn Helgaas Cc: Hans de Goede Cc: Ilpo Järvinen Signed-off-by: Jani Nikula --- arch/x86/kernel/early-quirks.c

[PATCH 08/10] drm: move i915_pciids.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Bjorn Helgaas Signed-off-by: Jani Nikula --- arch/x86/kernel/early-quirks.c | 2 +-

[PATCH 07/10] drm: move i915_pxp_tee_interface.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Tomas Winkler Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 2 +-

[PATCH 05/10] drm: move intel_lpe_audio.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Jaroslav Kysela Cc: Takashi Iwai Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-

[PATCH 04/10] drm: move i915_component.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Tomas Winkler Cc: Jaroslav Kysela Cc: Takashi Iwai Signed-off-by: Jani Nikula ---

[PATCH 03/10] drm: move i915_gsc_proxy_mei_interface.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Tomas Winkler Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c | 2 +-

[PATCH 02/10] drm: move intel-gtt.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Signed-off-by: Jani Nikula --- drivers/char/agp/intel-agp.c | 2 +- drivers/char/agp/intel-gtt.c

[PATCH 01/10] drm/i915: use system include for drm headers

2024-04-10 Thread Jani Nikula
Use <> instead of "" for including headers from include/, even if the file is in the same directory. Signed-off-by: Jani Nikula --- include/drm/i915_component.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/i915_component.h b/include/drm/i915_component.h index

[PATCH 00/10] drm: move Intel drm headers to a subdirectory

2024-04-10 Thread Jani Nikula
We've accumulated enough Intel specific header files under include/drm that they warrant a subdirectory of their own. Clean up the top drm header directory by moving the Intel files under include/drm/intel. Since i915 is most impacted, I suggest merging the lot via drm-intel-next. Please ack if

✗ Fi.CI.BAT: failure for drm/i915: Implement Audio WA_14020863754

2024-04-10 Thread Patchwork
== Series Details == Series: drm/i915: Implement Audio WA_14020863754 URL : https://patchwork.freedesktop.org/series/132255/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14552 -> Patchwork_132255v1 Summary ---

[PATCH] drm/i915: Implement Audio WA_14020863754

2024-04-10 Thread Uma Shankar
WA_14020863754: Corner case with Min Hblank Fix can cause audio hang Issue: Previously a fix was made to avoid issues with extremely small hblanks, called the "Min Hblank Fix". However, this can potentially cause an audio hang. Workaround : During "Audio Programming Sequence" Audio Enabling -

✗ Fi.CI.BAT: failure for drm/edid & drm/i915: vendor and product id logging improvements (rev3)

2024-04-10 Thread Patchwork
== Series Details == Series: drm/edid & drm/i915: vendor and product id logging improvements (rev3) URL : https://patchwork.freedesktop.org/series/131414/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14552 -> Patchwork_131414v3

✗ Fi.CI.SPARSE: warning for drm/edid & drm/i915: vendor and product id logging improvements (rev3)

2024-04-10 Thread Patchwork
== Series Details == Series: drm/edid & drm/i915: vendor and product id logging improvements (rev3) URL : https://patchwork.freedesktop.org/series/131414/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH v4] drm/i915/panelreplay: Panel replay workaround with VRR

2024-04-10 Thread Hogander, Jouni
On Wed, 2024-04-10 at 07:35 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Wednesday, April 10, 2024 12:54 PM > > To: Manna, Animesh ; intel- > > g...@lists.freedesktop.org > > Cc: ville.syrj...@linux.intel.com; Murthy, Arun R > > > >

RE: [PATCH v4] drm/i915/panelreplay: Panel replay workaround with VRR

2024-04-10 Thread Manna, Animesh
> -Original Message- > From: Hogander, Jouni > Sent: Wednesday, April 10, 2024 12:54 PM > To: Manna, Animesh ; intel- > g...@lists.freedesktop.org > Cc: ville.syrj...@linux.intel.com; Murthy, Arun R > Subject: Re: [PATCH v4] drm/i915/panelreplay: Panel replay workaround with > VRR > >

Re: [PATCH v4] drm/i915/panelreplay: Panel replay workaround with VRR

2024-04-10 Thread Hogander, Jouni
On Thu, 2024-03-28 at 10:13 +0530, Animesh Manna wrote: > Panel Replay VSC SDP not getting sent when VRR is enabled > and W1 and W2 are 0. So Program Set Context Latency in > TRANS_SET_CONTEXT_LATENCY register to at least a value of 1. > > HSD: 14015406119 > > v1: Initial version. > v2: Update

✗ Fi.CI.BAT: failure for drm/i915: Don't enable hwmon for selftests (rev3)

2024-04-10 Thread Patchwork
== Series Details == Series: drm/i915: Don't enable hwmon for selftests (rev3) URL : https://patchwork.freedesktop.org/series/132243/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14552 -> Patchwork_132243v3 Summary

Re: [PATCH] drm/i915: Don't enable hwmon for selftests

2024-04-10 Thread Nilawar, Badal
On 10-04-2024 11:35, Ashutosh Dixit wrote: There are no hwmon selftests so there is no need to enable hwmon for selftests. So enable hwmon only for real driver load. v2: Move the logic inside i915_hwmon.c v3: Move is_i915_selftest definition to i915_selftest.h (Badal) Closes:

✗ Fi.CI.SPARSE: warning for drm/i915: Don't enable hwmon for selftests (rev3)

2024-04-10 Thread Patchwork
== Series Details == Series: drm/i915: Don't enable hwmon for selftests (rev3) URL : https://patchwork.freedesktop.org/series/132243/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for drm/i915/psr: Use crtc_state->port_clock instead of intel_dp->link_rate (rev2)

2024-04-10 Thread Patchwork
== Series Details == Series: drm/i915/psr: Use crtc_state->port_clock instead of intel_dp->link_rate (rev2) URL : https://patchwork.freedesktop.org/series/132198/ State : success == Summary == CI Bug Log - changes from CI_DRM_14552 -> Patchwork_132198v2

Re: [PATCH] drm/i915: Don't enable hwmon for selftests

2024-04-10 Thread Dixit, Ashutosh
On Tue, 09 Apr 2024 22:17:38 -0700, Nilawar, Badal wrote: > > > +#if IS_ENABLED(CONFIG_DRM_I915_SELFTEST) > > + return i915_selftest.live || i915_selftest.perf || i915_selftest.mock; > > +#else > > + return false; > > +#endif > > +} > I think you moved this function here as this is only used

[PATCH] drm/i915: Don't enable hwmon for selftests

2024-04-10 Thread Ashutosh Dixit
There are no hwmon selftests so there is no need to enable hwmon for selftests. So enable hwmon only for real driver load. v2: Move the logic inside i915_hwmon.c v3: Move is_i915_selftest definition to i915_selftest.h (Badal) Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10366