Re: [Intel-gfx] [PATCH] drm/i915: Eliminate dead code in intel_sanitize_enable_ppgtt()

2017-07-27 Thread Zhenyu Wang
Chris, as we're ready to enable 48bit full ppgtt for guest, so patch like https://patchwork.freedesktop.org/patch/162507/ will change this part too. I'd like you to send this one, so Tina can refresh against this to apply. Thanks On 2017.07.26 15:44:00 +0100, Chris Wilson wrote: > > I was

Re: [Intel-gfx] [PATCH] drm/i915: Eliminate dead code in intel_sanitize_enable_ppgtt()

2017-07-26 Thread Imre Deak
Yep, looks better in the end. If you could send a proper patch I'd review it. On Wed, Jul 26, 2017 at 03:44:00PM +0100, Chris Wilson wrote: > Quoting Imre Deak (2017-07-25 22:12:36) > > From: Damien Lespiau > > > > We exit early if has_aliasing_ppgtt is 0, so towards

Re: [Intel-gfx] [PATCH] drm/i915: Eliminate dead code in intel_sanitize_enable_ppgtt()

2017-07-26 Thread Chris Wilson
Quoting Imre Deak (2017-07-25 22:12:36) > From: Damien Lespiau > > We exit early if has_aliasing_ppgtt is 0, so towards the end of the > function has_aliasing_ppgtt can only be 1. > > Also: > > if (foo) > return 1; > else >

[Intel-gfx] [PATCH] drm/i915: Eliminate dead code in intel_sanitize_enable_ppgtt()

2017-07-25 Thread Imre Deak
From: Damien Lespiau We exit early if has_aliasing_ppgtt is 0, so towards the end of the function has_aliasing_ppgtt can only be 1. Also: if (foo) return 1; else return 0; when foo is already a bool is really just:

Re: [Intel-gfx] [PATCH] drm/i915: Eliminate dead code in intel_sanitize_enable_ppgtt()

2017-07-17 Thread Imre Deak
On Wed, Jun 01, 2016 at 06:04:40PM +0100, Chris Wilson wrote: > On Wed, Jun 01, 2016 at 05:01:13PM +0100, Damien Lespiau wrote: > > We exit early if has_aliasing_ppgtt is 0, so towards the end of the > > function has_aliasing_ppgtt can only be 1. > > > > Also: > > > > if (foo) > >

Re: [Intel-gfx] [PATCH] drm/i915: Eliminate dead code in intel_sanitize_enable_ppgtt()

2016-06-01 Thread Chris Wilson
On Wed, Jun 01, 2016 at 05:01:13PM +0100, Damien Lespiau wrote: > We exit early if has_aliasing_ppgtt is 0, so towards the end of the > function has_aliasing_ppgtt can only be 1. > > Also: > > if (foo) > return 1; > else > return 0; > > when foo is

[Intel-gfx] [PATCH] drm/i915: Eliminate dead code in intel_sanitize_enable_ppgtt()

2016-06-01 Thread Damien Lespiau
We exit early if has_aliasing_ppgtt is 0, so towards the end of the function has_aliasing_ppgtt can only be 1. Also: if (foo) return 1; else return 0; when foo is already a bool is really just: return foo; Signed-off-by: Damien Lespiau