[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10345/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2296/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2091/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10344/ ---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-29 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/3036 LGTM, thanks for the good contributions. ---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3036 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10343/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2295/ ---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3036 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2294/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2090/ ---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3036 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2089/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2088/ ---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3036 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10341/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread xiaohui0318
Github user xiaohui0318 commented on the issue: https://github.com/apache/carbondata/pull/3032 > Be sure to do all of the following checklist to help us incorporate > your contribution quickly and easily: > > * [x] Any interfaces changed? NO > * [x] Any backward

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3036 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2292/ ---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3036 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2087/ ---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-29 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3036 retest this please ---

[GitHub] carbondata issue #2991: [CARBONDATA-3043] Add build script and add test case...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2991 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2291/ ---

[GitHub] carbondata issue #2991: [CARBONDATA-3043] Add build script and add test case...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2991 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10340/ ---

[GitHub] carbondata issue #2991: [CARBONDATA-3043] Add build script and add test case...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2991 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2086/ ---

[GitHub] carbondata pull request #2991: [CARBONDATA-3043] Add build script and add te...

2018-12-29 Thread BJangir
Github user BJangir commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2991#discussion_r244509375 --- Diff: docs/csdk-guide.md --- @@ -29,6 +29,32 @@ code and without CarbonSession. In the carbon jars package, there exist a

[GitHub] carbondata pull request #2991: [CARBONDATA-3043] Add build script and add te...

2018-12-29 Thread BJangir
Github user BJangir commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2991#discussion_r244509021 --- Diff: docs/csdk-guide.md --- @@ -29,6 +29,32 @@ code and without CarbonSession. In the carbon jars package, there exist a

[GitHub] carbondata pull request #2991: [CARBONDATA-3043] Add build script and add te...

2018-12-29 Thread BJangir
Github user BJangir commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2991#discussion_r244508891 --- Diff: docs/csdk-guide.md --- @@ -29,6 +29,32 @@ code and without CarbonSession. In the carbon jars package, there exist a

[GitHub] carbondata pull request #2991: [CARBONDATA-3043] Add build script and add te...

2018-12-29 Thread BJangir
Github user BJangir commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2991#discussion_r244508413 --- Diff: docs/csdk-guide.md --- @@ -29,6 +29,32 @@ code and without CarbonSession. In the carbon jars package, there exist a

[GitHub] carbondata pull request #2991: [CARBONDATA-3043] Add build script and add te...

2018-12-29 Thread BJangir
Github user BJangir commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2991#discussion_r244508238 --- Diff: docs/csdk-guide.md --- @@ -29,6 +29,32 @@ code and without CarbonSession. In the carbon jars package, there exist a

[GitHub] carbondata pull request #2991: [CARBONDATA-3043] Add build script and add te...

2018-12-29 Thread BJangir
Github user BJangir commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2991#discussion_r244507697 --- Diff: docs/csdk-guide.md --- @@ -40,6 +66,7 @@ release the memory and destroy JVM. C++ SDK support read batch row. User can set batch by

[GitHub] carbondata pull request #2991: [CARBONDATA-3043] Add build script and add te...

2018-12-29 Thread BJangir
Github user BJangir commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2991#discussion_r244507596 --- Diff: docs/csdk-guide.md --- @@ -29,6 +29,32 @@ code and without CarbonSession. In the carbon jars package, there exist a

[GitHub] carbondata pull request #2991: [CARBONDATA-3043] Add build script and add te...

2018-12-29 Thread BJangir
Github user BJangir commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2991#discussion_r244507492 --- Diff: store/CSDK/test/main.cpp --- @@ -665,6 +699,208 @@ bool readFromS3(JNIEnv *env, char *path, char *argv[]) { printResult(env,

[GitHub] carbondata issue #3037: [CARBONDATA-3190] Open example module code style che...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3037 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10339/ ---

[GitHub] carbondata issue #3037: [CARBONDATA-3190] Open example module code style che...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3037 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2290/ ---

[GitHub] carbondata issue #3037: [CARBONDATA-3190] Open example module code style che...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3037 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2085/ ---

[GitHub] carbondata issue #3030: [HOTFIX] Optimize the code style in csdk/sdk markdow...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3030 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10337/ ---

[GitHub] carbondata issue #3013: [WIP]Test

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3013 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10338/ ---

[GitHub] carbondata issue #3030: [HOTFIX] Optimize the code style in csdk/sdk markdow...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3030 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2288/ ---

[GitHub] carbondata issue #3013: [WIP]Test

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3013 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2289/ ---

[GitHub] carbondata issue #3013: [WIP]Test

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3013 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2084/ ---

[jira] [Resolved] (CARBONDATA-3176) Optimize quick-start-guide documentation

2018-12-29 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 resolved CARBONDATA-3176. - Resolution: Resolved > Optimize quick-start-guide documentation >

[jira] [Assigned] (CARBONDATA-3176) Optimize quick-start-guide documentation

2018-12-29 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 reassigned CARBONDATA-3176: --- Assignee: lamber-ken > Optimize quick-start-guide documentation >

[jira] [Resolved] (CARBONDATA-3126) There are some spell error in CarbonData

2018-12-29 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 resolved CARBONDATA-3126. - Resolution: Resolved > There are some spell error in CarbonData >

[GitHub] carbondata issue #3030: [HOTFIX] Optimize the code style in csdk/sdk markdow...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3030 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2083/ ---

[GitHub] carbondata pull request #3034: [CARBONDATA-3126] Correct some spell error in...

2018-12-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/3034 ---

[GitHub] carbondata issue #3034: [CARBONDATA-3126] Correct some spell error in Carbon...

2018-12-29 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3034 LGTM,Thank you for working on it. @tisonkong ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2287/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2082/ ---

[GitHub] carbondata pull request #3037: [CARBONDATA-3190] Open example module code st...

2018-12-29 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/3037 [CARBONDATA-3190] Open example module code style check and fix some style errors There are many code style errors in example module when I open the code style check, This PR fixed it.

[GitHub] carbondata pull request #3013: [WIP]Test

2018-12-29 Thread xubo245
Github user xubo245 closed the pull request at: https://github.com/apache/carbondata/pull/3013 ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10336/ ---

[GitHub] carbondata issue #3034: [CARBONDATA-3126] Correct some spell error in Carbon...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3034 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10335/ ---

[GitHub] carbondata issue #3034: [CARBONDATA-3126] Correct some spell error in Carbon...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3034 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2286/ ---

[GitHub] carbondata issue #3030: [HOTFIX] Optimize the code style in csdk/sdk markdow...

2018-12-29 Thread lamber-ken
Github user lamber-ken commented on the issue: https://github.com/apache/carbondata/pull/3030 > There are some other capitalization problems, please check and fix. thanks for detail review. I have update the doc ---

[GitHub] carbondata pull request #3013: [WIP]Test

2018-12-29 Thread xubo245
GitHub user xubo245 reopened a pull request: https://github.com/apache/carbondata/pull/3013 [WIP]Test Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3032 add to whitelist ---

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244496128 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/S3UsingSDkExample.scala --- @@ -20,10 +20,10 @@ import

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244496155 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala --- @@ -24,10 +24,10 @@ import

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244496097 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/S3Example.scala --- @@ -21,8 +21,8 @@ import java.io.File import

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244495974 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/S3UsingSDkExample.scala --- @@ -83,15 +83,15 @@ object S3UsingSDKExample {

[GitHub] carbondata issue #3030: [HOTFIX] Optimize the code style in csdk/sdk markdow...

2018-12-29 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/carbondata/pull/3030 There are some other capitalization problems, please check and fix. ---

[GitHub] carbondata pull request #3030: [HOTFIX] Optimize the code style in csdk/sdk ...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3030#discussion_r244495764 --- Diff: docs/csdk-guide.md --- @@ -172,361 +174,360 @@ release the memory and destroy JVM. ## API List ### CarbonWriter ``` -/**

[GitHub] carbondata pull request #3030: [HOTFIX] Optimize the code style in csdk/sdk ...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3030#discussion_r244495752 --- Diff: docs/csdk-guide.md --- @@ -172,361 +174,360 @@ release the memory and destroy JVM. ## API List ### CarbonWriter ``` -/**

[GitHub] carbondata pull request #3030: [HOTFIX] Optimize the code style in csdk/sdk ...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3030#discussion_r244495697 --- Diff: docs/csdk-guide.md --- @@ -172,361 +174,360 @@ release the memory and destroy JVM. ## API List ### CarbonWriter ``` -/**

[GitHub] carbondata pull request #3030: [HOTFIX] Optimize the code style in csdk/sdk ...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3030#discussion_r244495589 --- Diff: docs/csdk-guide.md --- @@ -43,114 +43,116 @@ C++ SDK support read batch row. User can set batch by using withBatch(int batch) ## API List

[GitHub] carbondata pull request #3030: [HOTFIX] Optimize the code style in csdk/sdk ...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3030#discussion_r244495633 --- Diff: docs/csdk-guide.md --- @@ -172,361 +174,360 @@ release the memory and destroy JVM. ## API List ### CarbonWriter ``` -/**

[GitHub] carbondata pull request #3030: [HOTFIX] Optimize the code style in csdk/sdk ...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3030#discussion_r244495649 --- Diff: docs/csdk-guide.md --- @@ -172,361 +174,360 @@ release the memory and destroy JVM. ## API List ### CarbonWriter ``` -/**

[GitHub] carbondata pull request #3030: [HOTFIX] Optimize the code style in csdk/sdk ...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3030#discussion_r244495612 --- Diff: docs/csdk-guide.md --- @@ -172,361 +174,360 @@ release the memory and destroy JVM. ## API List ### CarbonWriter ``` -/**

[GitHub] carbondata pull request #3030: [HOTFIX] Optimize the code style in csdk/sdk ...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3030#discussion_r244495542 --- Diff: docs/csdk-guide.md --- @@ -43,114 +43,116 @@ C++ SDK support read batch row. User can set batch by using withBatch(int batch) ## API List

[GitHub] carbondata pull request #3030: [HOTFIX] Optimize the code style in csdk/sdk ...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3030#discussion_r244495567 --- Diff: docs/csdk-guide.md --- @@ -43,114 +43,116 @@ C++ SDK support read batch row. User can set batch by using withBatch(int batch) ## API List

[GitHub] carbondata pull request #3030: [HOTFIX] Optimize the code style in csdk/sdk ...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3030#discussion_r244495396 --- Diff: docs/csdk-guide.md --- @@ -43,114 +43,116 @@ C++ SDK support read batch row. User can set batch by using withBatch(int batch) ## API List

[GitHub] carbondata pull request #3030: [HOTFIX] Optimize the code style in csdk/sdk ...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3030#discussion_r244495429 --- Diff: docs/csdk-guide.md --- @@ -43,114 +43,116 @@ C++ SDK support read batch row. User can set batch by using withBatch(int batch) ## API List

[GitHub] carbondata pull request #3030: [HOTFIX] Optimize the code style in csdk/sdk ...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3030#discussion_r244495374 --- Diff: docs/csdk-guide.md --- @@ -43,114 +43,116 @@ C++ SDK support read batch row. User can set batch by using withBatch(int batch) ## API List

[GitHub] carbondata pull request #3030: [HOTFIX] Optimize the code style in csdk/sdk ...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3030#discussion_r244495349 --- Diff: docs/csdk-guide.md --- @@ -43,114 +43,116 @@ C++ SDK support read batch row. User can set batch by using withBatch(int batch) ## API List

[GitHub] carbondata pull request #3030: [HOTFIX] Optimize the code style in csdk/sdk ...

2018-12-29 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3030#discussion_r244495293 --- Diff: docs/csdk-guide.md --- @@ -43,114 +43,116 @@ C++ SDK support read batch row. User can set batch by using withBatch(int batch) ## API List

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3034 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2081/ ---

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

2018-12-29 Thread tisonkong
Github user tisonkong commented on the issue: https://github.com/apache/carbondata/pull/3034 > Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2282/ I found the error reason is "line is longer than 100 characters" in

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

2018-12-29 Thread tisonkong
Github user tisonkong commented on the issue: https://github.com/apache/carbondata/pull/3034 > Please fix the CI error. @tisonkong I found the error reason is "line is longer than 100 characters" in DictionaryBasedVectorResultCollector. I have take a newline to fix this

[GitHub] carbondata issue #3030: [HOTFIX] Optimize the code style in csdk/sdk markdow...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3030 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2285/ ---

[GitHub] carbondata issue #3030: [HOTFIX] Optimize the code style in csdk/sdk markdow...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3030 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10334/ ---

[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3033 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10333/ ---

[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3033 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2284/ ---

[GitHub] carbondata issue #3030: [HOTFIX] Optimize the code style in csdk/sdk markdow...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3030 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2080/ ---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-29 Thread runzhliu
Github user runzhliu commented on the issue: https://github.com/apache/carbondata/pull/3036 @xubo245 Done. ---

[GitHub] carbondata pull request #3030: [HOTFIX] Optimize the code style in csdk/sdk ...

2018-12-29 Thread lamber-ken
Github user lamber-ken commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3030#discussion_r244478288 --- Diff: docs/csdk-guide.md --- @@ -172,361 +174,360 @@ release the memory and destroy JVM. ## API List ### CarbonWriter ``` -

[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3033 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2079/ ---

[GitHub] carbondata pull request #3033: [CARBONDATA-3215] Optimize the documentation

2018-12-29 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3033#discussion_r244475523 --- Diff: docs/datamap-developer-guide.md --- @@ -3,15 +3,15 @@ ### Introduction DataMap is a data structure that can be used to accelerate

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameter from code

2018-12-29 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3036 Please optimize the title, this PR is not only for unused import, also optimize the spell error, so please add it too. @runzhliu ---

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

2018-12-29 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3034 Please fix the CI error. ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3032 Have you validate with S3? ---

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...

2018-12-29 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244473974 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala --- @@ -62,8 +62,7 @@ object CarbonSparkUtil {

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...

2018-12-29 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244473860 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala --- @@ -117,4 +116,29 @@ object CarbonSparkUtil {

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...

2018-12-29 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244473902 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala --- @@ -117,4 +116,29 @@ object CarbonSparkUtil {

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameter from code

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3036 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10332/ ---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameter from code

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3036 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2283/ ---

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] merge getKeyOnPrefix into C...

2018-12-29 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244473663 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala --- @@ -117,4 +116,29 @@ object CarbonSparkUtil {

[GitHub] carbondata issue #3032: [CARBONDATA-3210] merge getKeyOnPrefix into CarbonSp...

2018-12-29 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3032 @xiaohui0318 Please optimize the title, such as change merge to Merge ---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameter from code

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3036 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2078/ ---