Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3064#discussion_r247097474
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -1201,6 +1202,17 @@ abstract
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3064#discussion_r247011216
--- Diff: docs/dml-of-carbondata.md ---
@@ -106,6 +107,13 @@ CarbonData DML statements are documented here,which
includes:
OPTIONS
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3064#discussion_r247010700
--- Diff: docs/dml-of-carbondata.md ---
@@ -49,6 +49,7 @@ CarbonData DML statements are documented here,which
includes:
| [COMMENTCHAR
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3064#discussion_r247010601
--- Diff: docs/configuration-parameters.md ---
@@ -208,6 +208,7 @@ RESET
| carbon.options.date.format | Specifies the data
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3064#discussion_r246780308
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/execution/command/CarbonHiveCommands.scala
---
@@ -127,6 +127,9 @@ object
GitHub user NamanRastogi opened a pull request:
https://github.com/apache/carbondata/pull/3064
[WIP] Updated DOC for No-Sort Compaction and a few Fixes
1. Updated Doc
2. Checking SORT_SCOPE in session property CARBON.TABLE.LOAD.SORT.SCOPE in
CarbonTable.getSortScope()
3
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r246329602
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionUtil.java
---
@@ -400,24 +417,53 @@ private static int
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r246329142
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionExecutor.java
---
@@ -105,10 +105,15 @@ public
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3014#discussion_r246274857
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -191,10 +191,17
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2996#discussion_r245925395
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala
---
@@ -165,15
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3014#discussion_r245896341
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/SessionParams.java ---
@@ -229,6 +229,12 @@ private boolean validateKeyValue(String
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3014#discussion_r245895212
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/commands/SetCommandTestCase.scala
---
@@ -128,6 +128,34 @@ class
Github user NamanRastogi commented on the issue:
https://github.com/apache/carbondata/pull/3014
retest this please
---
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2996#discussion_r245669672
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala
---
@@ -165,15
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3014#discussion_r244947621
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -191,10 +191,17
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244766765
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
---
@@ -156,21 +159,22 @@ public
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244766044
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/StreamHandoffRDD.scala
---
@@ -118,7 +118,7 @@ class
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244766555
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionUtil.java
---
@@ -400,24 +417,53 @@ private static int
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244713711
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/InMemorySortTempChunkHolder.java
---
@@ -0,0 +1,109
Github user NamanRastogi commented on the issue:
https://github.com/apache/carbondata/pull/3029
@qiuchenjian We dont need a parameter to control to control whether to sort
the data or not while compacting. The sole purpose of compaction is to improve
subsequent query performance
GitHub user NamanRastogi opened a pull request:
https://github.com/apache/carbondata/pull/3029
[CARBONDATA-3200] No-Sort compaction
When the data is loaded with SORT_SCOPE as NO_SORT, and done compaction
upon, the data still remains unsorted. This does not affect much in query
GitHub user NamanRastogi opened a pull request:
https://github.com/apache/carbondata/pull/3014
[WIP] Added load level SORT_SCOPE
### Load level SORT_SCOPE
```sql
LOAD DATA INPATH 'path/to/data.csv'
INTO TABLE my_table
OPTIONS (
'sort_scope'='no_sort
GitHub user NamanRastogi opened a pull request:
https://github.com/apache/carbondata/pull/2996
[WIP] Fix Rename-Fail & Datamap-creation-Fail
Fixed negative scenarios:
1. Alter Table Rename Table Fail
2. Create Preagregate-Datamap Fail
### Alter Table Rename T
Github user NamanRastogi commented on the issue:
https://github.com/apache/carbondata/pull/2942
retest this please
---
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2942#discussion_r235901284
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/result/iterator/ChunkRowIterator.java
---
@@ -52,17 +49,11 @@ public
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2942#discussion_r235892844
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/result/iterator/ChunkRowIterator.java
---
@@ -52,17 +49,11 @@ public
GitHub user NamanRastogi opened a pull request:
https://github.com/apache/carbondata/pull/2942
[CARBONDATA-3121] Improvement of CarbonReader build time
CarbonReader builder is taking huge time.
**Reason**
Initialization of ChunkRowIterator is triggring actual I/O
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2921#discussion_r234875057
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDropTableCommand.scala
---
@@ -143,7 +143,6
Github user NamanRastogi commented on the issue:
https://github.com/apache/carbondata/pull/2921
@kunal642 Please review
---
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2850#discussion_r229299196
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -114,6 +117,43 @@ public static CarbonReaderBuilder
Github user NamanRastogi commented on the issue:
https://github.com/apache/carbondata/pull/2850
Please check the split method, it splits the list of `CarbonRecordReader`
into multiple `CarbonReader`s. It does not jumble the order of
`CarbonRecordReader`, it still keeps them
Github user NamanRastogi commented on the issue:
https://github.com/apache/carbondata/pull/2850
Yes, data coming from one file will always be in order. Please check the
`split` method, it splits the list of CarbonRecordReader into multiple
CarbonReader s.
Suppose
Github user NamanRastogi commented on the issue:
https://github.com/apache/carbondata/pull/2850
@xuchuanyin
Using this API the overhead of reading concurrently is on the consumer of
CarbonReader. So yes, what you said what you said is right. But this API was
made to consider
Github user NamanRastogi commented on the issue:
https://github.com/apache/carbondata/pull/2850
@xuchuanyin
Since `CarbonReader` is iterator based, we can only read a line when user
wants. So, even if we keep the parallelism internally before the build method,
it will still
GitHub user NamanRastogi opened a pull request:
https://github.com/apache/carbondata/pull/2850
Added concurrent reading through SDK
Added another API for _CarbonReader.split_ to enable concurrent reading of
carbondata files through SDK.
```java
List multipleReaders
Github user NamanRastogi closed the pull request at:
https://github.com/apache/carbondata/pull/2748
---
GitHub user NamanRastogi opened a pull request:
https://github.com/apache/carbondata/pull/2748
[CARBONDATA-2959] Added validations for TABLE OPTIONS
create table validations are added for table OPTIONS while table is created
using:
```
CREATE TABLE ( )
USING carbon
37 matches
Mail list logo
