Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/3021
Thank you..let's use your pull request and close this...so that we can have
a single.place to comment.
---
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/3021
This commit breaks the cloudera 2.2.0cloudera2
---
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/3021
https://github.com/apache/carbondata/commit/b0733ecbf380d7956dee57a9048dd7537620744e
---
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/3021
We get error from a commit related to altertableschema.. which is not there
in cloudera spark
---
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/2161
@xubo245 yes will do
---
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r244182374
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AlluxioCarbonFile.java
---
@@ -90,21 +97,82 @@ public CarbonFile
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r244182177
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AlluxioCarbonFile.java
---
@@ -90,21 +97,82 @@ public CarbonFile
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/3021
@chenliang613 , I am ok with it..as in the corporate we still need to livw
with it.. we can update the jira and close it.
---
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/2161
@ravipesala , @jackylk can we merge the PR?
---
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/3021
@ravipesala , Yes you can let me know how you want to inherit..I think
defining a interface for the wrapper would be a good fit.. In our local fork we
did it using spark-2.2.0 normal
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/3021
Please try this:
https://repository.cloudera.com/artifactory/cloudera-repos/org/apache/spark/spark-sql_2.11/2.2.0.cloudera2/
---
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/3021
Please check the repo here.
https://www.cloudera.com/documentation/enterprise/release-notes/topics/cdh_vd_cdh5_maven_repo_514x.html#maven_5142
---
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r243806487
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -960,7 +960,7 @@ private
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/3021
@jackylk , @ravipesala Can somebody validate this against the CDH5.14.2 and
could you please create a profile for build validation for CDH Libraries..
Please let me know where to add
GitHub user chandrasaripaka opened a pull request:
https://github.com/apache/carbondata/pull/3021
Cdh support
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ No] Any interfaces changed
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r243773875
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -960,7 +960,7 @@ private
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/2161
I am changing the implementation for the same to read and copy the data
from file system and change the same as suggested by @ravipesala , I get the
similar issue with the previous code
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/2161
> @chandrasaripaka you can put the CarbonFile test with Alluxio Mini
Cluster but make sure it does not go beyond a few seconds to finish the test as
it impacts the build t
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241983388
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/AlluxioFileLock.java ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241983377
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AlluxioCarbonFile.java
---
@@ -94,14 +93,9 @@ public CarbonFile
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/2161
@ravipesala , I want to put a CarbonFile Test based on Alluxio Mini
Cluster, will that be ok ?
---
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241980998
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/AlluxioFileLock.java ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241980433
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
@@ -43,7 +44,7 @@
* LOGGER
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241980383
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AlluxioCarbonFile.java
---
@@ -94,14 +93,9 @@ public CarbonFile
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241980353
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AbstractDFSCarbonFile.java
---
@@ -550,12 +550,10 @@ public
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241939242
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
@@ -432,7 +437,7 @@ public static long
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241290215
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
@@ -111,14 +112,9 @@ public static DataInputStream
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/2161
@xubo245 , so may I know if the PR can be merged or it needs some
rework..we can attach some test logs.
---
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/2161
@xubo245 , please merge the PR, after a review
---
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/2161
> @chandrasaripaka Can you fix the CI error?
@xubo245 , just committed please review and let me know.
---
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r238211698
--- Diff:
core/src/test/java/org/apache/carbondata/core/datastore/filesystem/AlluxioCarbonFileTest.java
---
@@ -108,12 +121,12 @@ public void
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r200066306
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
@@ -365,10 +366,11 @@ public static boolean
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r200064110
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AlluxioCarbonFile.java
---
@@ -105,18 +103,21 @@ public
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/2161
@xubo245 how do we merge this
---
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/2161
@xubo2545 looks like there is a permission issue for locating the file to
build for my I'd. Actually the build is passing.
---
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/2161
I guess the build passed, but at the time of locating the jar , it failed.
Can somebody look into the issue with Spark2.1.0 CI build.
---
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/2161
@CarbonDataQA FileNotFoundException means that the credentials Jenkins is
using is probably wrong. Or the user account does not have write access to the
repo
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/2161
@CarbonDataQA May I know if this has to be fixed from my side..as a part of
the pull request, Kindly advise. @xubo245 Also, I dont have access to resolve
the conflicts and recommit
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/2161
@xubo245 CARBONDATA-2218 , which is the jira I raised before.
---
Github user chandrasaripaka commented on the issue:
https://github.com/apache/carbondata/pull/2161
@chenliang613 This PR is for supporting the Alluxio as a File System for
supporting the CarbonFileFormat. Though there was a AlluxioCarbonFile in the
past, this was failing with Alluxio
GitHub user chandrasaripaka opened a pull request:
https://github.com/apache/carbondata/pull/2161
Adding Alluxio Supporty
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [No ] Any interfaces changed
41 matches
Mail list logo
