GitHub user kumarvishal09 opened a pull request:
https://github.com/apache/carbondata/pull/3068
[HOTFIX] Fixed NPE during query with Local Dictionary
**Problem:**
Query is failing with NPE when some blocklet encoded with local dictionary
and some without local dictionary
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3055
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3029
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3046
@xuchuanyin In near future we are planing to change threshold(currently
based on number) to size based local dictionary. Size based threshold will give
more control.
Current changes
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3056
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3053
@manishgupta88 @xuchuanyin I think if it's really a problem with snappy
then whether any performance impact is there or not we have to merge as its a
functional issue. :)
@akashrn5
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2996
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3014
LGTM
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r245630539
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -1491,6 +1491,27 @@ private void
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3010
LGTM
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r245275753
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -110,22
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r245275437
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -110,22
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r245274310
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -110,22
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r245274147
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -110,22
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r245273039
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -110,22
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r245272931
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -110,22
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3014
retest this please
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3029
retest this please
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3010
retest this please
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3039
LGTM
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244923003
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/DataFileFooterConverterV3.java
---
@@ -73,6 +73,11 @@ public DataFileFooter
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244921991
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala
---
@@ -180,10 +180,10 @@ class
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3031
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3031
@shivamasn Please update the PR details
In Local Dictionary, page size was not getting updated for complex children
columns. So during fallback, new page was being created
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3031#discussion_r244914880
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java
---
@@ -140,6 +140,7 @@ public boolean
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3041
LGTM
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244723649
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java
---
@@ -103,15 +104,22 @@ private void
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244722477
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
---
@@ -156,21 +159,22 @@ public
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244722390
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionUtil.java
---
@@ -400,24 +417,53 @@ private static
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244721944
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionExecutor.java
---
@@ -105,10 +105,15 @@ public
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244721762
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/StreamHandoffRDD.scala
---
@@ -118,7 +118,7 @@ class
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244714375
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionUtil.java
---
@@ -400,24 +417,53 @@ private static
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244713354
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionUtil.java
---
@@ -400,24 +417,53 @@ private static
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244712666
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/InMemorySortTempChunkHolder.java
---
@@ -0,0 +1,109
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r244708667
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/steps/CarbonRowDataWriterProcessorStepImpl.java
---
@@ -128,16
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r244708432
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -1491,6 +1491,16 @@ private void
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r244708172
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -2076,4 +2076,15 @@ private
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r244707751
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -126,6
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3010#discussion_r244679013
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala
---
@@ -626,22 +626,29
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3010#discussion_r244678677
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala
---
@@ -626,22 +626,29
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3010#discussion_r244678587
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1445,16 +1445,10 @@ private
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3014
@NamanRastogi please fix test failure
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3029
@NamanRastogi please resolve conflicts and fix all failure
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3029
@NamanRastogi You can merge HybridSorter into
CompactionResultSortProcessor. For unsorted file it will be same flow, for
sorted file you add one adapter(InMemorySortTempFileChunkHolder
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244332001
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala
---
@@ -166,8 +164,9 @@ class
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3029
@NamanRastogi Please add detail comment for all the changed code
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244331702
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala
---
@@ -207,18 +212,34 @@ class
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2996
@NamanRastogi Please fixed the build failure
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3019#discussion_r244104691
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSourceProvider.java
---
@@ -43,63 +43,78
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3020
LGTM
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3019#discussion_r244090651
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataConnectorFactory.java
---
@@ -17,69 +17,179
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3016
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3003
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3010
@Shubh18s Please fix the test case failures
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3003#discussion_r243530948
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
---
@@ -272,18 +272,44 @@ protected
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2993
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3006
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2993
@manishnalla1994 Please correct the format and add comments
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2993#discussion_r243227160
--- Diff:
streaming/src/main/scala/org/apache/carbondata/streaming/parser/RowStreamParserImp.scala
---
@@ -53,19 +54,21 @@ class
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2985#discussion_r241978586
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/result/BlockletScannedResult.java
---
@@ -663,6 +663,12 @@ public boolean hasNext
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2985
retest this please
---
GitHub user kumarvishal09 opened a pull request:
https://github.com/apache/carbondata/pull/2985
[HOTFIX] Fixed Query performance issue
### Problem
When some pages is giving 0 rows, then also BlockletScanResult is
uncompressing all the pages. When compression is high and one
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2974
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2974
retest this please
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2974
rest this please
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2847
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2974
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2972
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2975
LGTM.. @ravipesala yeah u are right...Based on PR desc I asked for
performance report, now it's okay :)
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2978#discussion_r240159318
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/ColumnarVectorWrapperDirect.java
---
@@ -0,0 +1,321
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2976
retest this please
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2847#discussion_r240100527
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2847#discussion_r240100410
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithCompression.scala
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2847#discussion_r240098824
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2847#discussion_r240098067
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/compression/CompressorFactory.java
---
@@ -35,8 +35,8 @@
private final
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2847#discussion_r240097367
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2974#discussion_r239703828
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonExplainCommand.scala
---
@@ -51,8 +51,13 @@ case
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2975
@dhatchayani can u please update the performance result
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2940
@xubo245 this property was added for internal purpose to restrict user from
directly querying on pre-ggregate data map as it will show aggregated output
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2962
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2957
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2936
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2942
retest this please
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2849
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2937
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2939
LGTM
---
Github user kumarvishal09 closed the pull request at:
https://github.com/apache/carbondata/pull/2880
---
Github user kumarvishal09 closed the pull request at:
https://github.com/apache/carbondata/pull/2938
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2927
LGTM
---
GitHub user kumarvishal09 opened a pull request:
https://github.com/apache/carbondata/pull/2938
[HOTFIX] Updated log message in UnsafeMemoryManager
Updated log message in UnsafeMemoryManager
Be sure to do all of the following checklist to help us incorporate
your
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2872#discussion_r235060261
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/ReusableDataBuffer.java
---
@@ -0,0 +1,33 @@
+/*
+ * Licensed
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2872#discussion_r235060209
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/MeasureColumnChunkReader.java
---
@@ -56,13 +57,14
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2872#discussion_r235059863
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/compression/ZstdCompressor.java
---
@@ -74,4 +74,16 @@ public long
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2872#discussion_r235059766
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveIntegralCodec.java
---
@@ -119,24 +120,34
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2872#discussion_r235059822
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/ReusableDataBuffer.java
---
@@ -0,0 +1,33 @@
+/*
+ * Licensed
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2872
@manishgupta88 this is basic implementation of pool(kind of pool :)) and
currently it only for direct flow(new flow), In future I am planing to replace
reusable buffer with proper byte
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2872
retest this please
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2870
LGTM
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2873
LGTM
---
GitHub user kumarvishal09 opened a pull request:
https://github.com/apache/carbondata/pull/2880
[HOTFIX] Fixed Snappy Offheap compress crash issue and corrected
UnsafeMemoryManager Free method log message
â¦anager log in free method
Be sure to do all of the following
1 - 100 of 698 matches
Mail list logo
