[GitHub] carbondata pull request #3003: [CARBONDATA-3186]Avoid creating empty carbond...

2018-12-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/3003 ---

[GitHub] carbondata pull request #3003: [CARBONDATA-3186]Avoid creating empty carbond...

2018-12-23 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3003#discussion_r243770677 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java --- @@ -272,18 +272,44 @@ protected

[GitHub] carbondata pull request #3003: [CARBONDATA-3186]Avoid creating empty carbond...

2018-12-21 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3003#discussion_r243530948 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java --- @@ -272,18 +272,44 @@ protected