Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/3014
---
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3014#discussion_r246274857
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -191,10 +191,17
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3014#discussion_r245896341
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/SessionParams.java ---
@@ -229,6 +229,12 @@ private boolean validateKeyValue(String
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3014#discussion_r245895212
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/commands/SetCommandTestCase.scala
---
@@ -128,6 +128,34 @@ class
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3014#discussion_r245884441
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/commands/SetCommandTestCase.scala
---
@@ -128,6 +128,34 @@ class
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3014#discussion_r245879143
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/SessionParams.java ---
@@ -229,6 +229,12 @@ private boolean validateKeyValue(String key,
Github user NamanRastogi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3014#discussion_r244947621
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -191,10 +191,17
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3014#discussion_r244092819
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateTableWithSortScope.scala
---
@@
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3014#discussion_r244092650
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -191,10 +191,17 @@
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3014#discussion_r244092283
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -191,10 +191,17 @@
10 matches
Mail list logo