Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/3032
---
Github user xiaohui0318 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r246029848
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala
---
@@ -28,12 +28,13 @@ import
Github user xiaohui0318 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r246029862
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/S3UsingSDkExample.scala
---
@@ -16,28 +16,26 @@
*/
package
Github user xiaohui0318 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r246029819
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/S3Example.scala
---
@@ -18,11 +18,10 @@ package
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r245861536
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/S3Example.scala
---
@@ -18,11 +18,10 @@ package org.apache.carbondata.examples
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r245861501
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala
---
@@ -28,12 +28,13 @@ import
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r245861440
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/S3UsingSDkExample.scala
---
@@ -16,28 +16,26 @@
*/
package
Github user xiaohui0318 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r245852864
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/S3Example.scala
---
@@ -18,52 +18,50 @@ package
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r245553139
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/S3Example.scala
---
@@ -18,52 +18,50 @@ package org.apache.carbondata.examples
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r245324988
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala
---
@@ -108,13 +113,45 @@ object CarbonSparkUtil {
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r245324728
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala
---
@@ -30,6 +31,10 @@ import
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244596104
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala
---
@@ -59,13 +64,13 @@ object CarbonSparkUtil {
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244596094
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala
---
@@ -28,11 +29,15 @@ import
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244596067
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala
---
@@ -28,11 +29,15 @@ import
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244596100
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala
---
@@ -50,7 +55,7 @@ object CarbonSparkUtil {
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244496128
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/S3UsingSDkExample.scala
---
@@ -20,10 +20,10 @@ import
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244496155
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala
---
@@ -24,10 +24,10 @@ import
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244496097
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/S3Example.scala
---
@@ -21,8 +21,8 @@ import java.io.File
import
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244495974
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/S3UsingSDkExample.scala
---
@@ -83,15 +83,15 @@ object S3UsingSDKExample {
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244473974
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala
---
@@ -62,8 +62,7 @@ object CarbonSparkUtil {
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244473860
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala
---
@@ -117,4 +116,29 @@ object CarbonSparkUtil {
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244473902
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala
---
@@ -117,4 +116,29 @@ object CarbonSparkUtil {
22 matches
Mail list logo
