Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r24497
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -2076,4 +2076,15 @@ private
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r245510146
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/DecoderBasedFallbackEncoder.java
---
@@ -57,10 +57,7 @@ public
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r245510098
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -2076,4 +2076,15 @@ private
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r244708667
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/steps/CarbonRowDataWriterProcessorStepImpl.java
---
@@ -128,16
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r244708339
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
---
@@ -205,8 +205,10 @@ public
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r244708432
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -1491,6 +1491,16 @@ private void
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r244708172
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -2076,4 +2076,15 @@ private
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/3046
[WIP] Added check to start fallback based on size
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces
