[jira] [Resolved] (CARBONDATA-3186) NPE when all the records in a file is badrecord with action redirect/ignore
[ https://issues.apache.org/jira/browse/CARBONDATA-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kumar vishal resolved CARBONDATA-3186. -- Resolution: Fixed > NPE when all the records in a file is badrecord with action redirect/ignore > --- > > Key: CARBONDATA-3186 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3186 > Project: CarbonData > Issue Type: Bug >Reporter: Ajantha Bhat >Assignee: Ajantha Bhat >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > *problem:* In the no_sort flow, writer will be open as there is no blocking > sort step. > So, when all the record goes as bad record with redirect in converted step. > writer is closing the empty .carbondata file. > when this empty carbondata file is queried , we get multiple issues including > NPE. > *solution:* When the file size is 0 bytes. do the following > a) If one data and one index file -- delete carbondata file and avoid index > file creation > b) If multiple data and one index file (with few data file is full of bad > recod) -- delete carbondata files, remove them from blockIndexInfoList, so > index file not will not have that info of empty carbon files > c) In case direct write to store path is enable. need to delete data file > from there and avoid writing index file with that carbondata in info. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata pull request #3003: [CARBONDATA-3186]Avoid creating empty carbond...
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/3003 ---
[GitHub] carbondata issue #3003: [CARBONDATA-3186]Avoid creating empty carbondata fil...
Github user kumarvishal09 commented on the issue: https://github.com/apache/carbondata/pull/3003 LGTM ---
[GitHub] carbondata issue #3019: [CARBONDATA-3194] Integrating Carbon with Presto usi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3019 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1924/ ---
[GitHub] carbondata issue #3021: [CARBONDATA-3193] Cdh5.14.2 spark2.2.0 support
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3021 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1923/ ---
[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted INdex...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3020 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1922/ ---
[GitHub] carbondata issue #3019: [CARBONDATA-3194] Integrating Carbon with Presto usi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3019 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10174/ ---
[GitHub] carbondata pull request #3021: Cdh support
GitHub user chandrasaripaka opened a pull request: https://github.com/apache/carbondata/pull/3021 Cdh support Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ No] Any interfaces changed? - [ No] Any backward compatibility impacted? - [ Yes] Document update required? - [ Yes] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ No Large Changes] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. This is just only the way we fix for CDH5.14.2, and the Spark2.2.0, the way how parquet treats the data. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DataHeaps/carbondata cdh-support Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/3021.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3021 commit 746657e7e47fc69a62dbf14b3a7449108b92342c Author: Chandrasekhar Saripaka Date: 2018-07-25T17:10:20Z Merge pull request #1 from apache/master merge back commit 0c4c5f5d43c779c62864ed7ab99cf9ef91b082f2 Author: Chandrasekhar Saripaka Date: 2018-11-23T12:24:19Z Merge pull request #3 from apache/master Merge Carbondata master commit 91d4ee54bfac7bad56dede27059896c766b5f42f Author: Chandrasekhar Saripaka Date: 2018-12-13T07:42:30Z Merge pull request #4 from apache/master Updating the fork master commit 834e702d0e2e8211987c465e36596d78028ea8b2 Author: Chandrasekhar Saripaka Date: 2018-12-14T13:36:26Z Merge pull request #5 from apache/master Merge Master to DataHeaps Master commit 2ebfdf3142ee3f22e7938d735ca5a88c117f0848 Author: Chandrasekhar Saripaka Date: 2018-12-21T08:51:13Z Merge pull request #6 from apache/master Merge Upstream Master commit 0c777259d54d3b99acd9d62b75cddde7e726afc1 Author: ChandraSaripaka Date: 2018-12-24T07:19:30Z CARBONDATA-3193: Build support for CDH 5.14.2 Spark 2.2.0 ---
[GitHub] carbondata pull request #3020: [CARBONDATA-3195]Added validation for Inverte...
GitHub user shardul-cr7 opened a pull request: https://github.com/apache/carbondata/pull/3020 [CARBONDATA-3195]Added validation for Inverted INdex columns and added a test case in case of varchar Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shardul-cr7/carbondata 21dec Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/3020.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3020 commit 6374825a94b055a1a9d196ae151a01e2c9d3805e Author: shardul-cr7 Date: 2018-12-24T07:21:16Z Added validation for Inverted INdex columns and added a test case in case of varchar ---
[jira] [Updated] (CARBONDATA-3193) Support for CDH 5.14.2 Spark 2.2.0
[ https://issues.apache.org/jira/browse/CARBONDATA-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChandraSekhar Saripaka updated CARBONDATA-3193: --- Summary: Support for CDH 5.14.2 Spark 2.2.0 (was: Support for CDH 5.14 Spark 2.2.0) > Support for CDH 5.14.2 Spark 2.2.0 > -- > > Key: CARBONDATA-3193 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3193 > Project: CarbonData > Issue Type: Improvement > Components: spark-integration >Affects Versions: NONE >Reporter: ChandraSekhar Saripaka >Priority: Major > Labels: CDH5 > > Carbondata build support for CDH5.14.2 spark2.2.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata issue #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Issue
Github user kumarvishal09 commented on the issue: https://github.com/apache/carbondata/pull/3010 @Shubh18s Please fix the test case failures ---
[GitHub] carbondata issue #3003: [CARBONDATA-3186]Avoid creating empty carbondata fil...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3003 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2129/ ---
[GitHub] carbondata issue #3003: [CARBONDATA-3186]Avoid creating empty carbondata fil...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3003 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10172/ ---
[GitHub] carbondata issue #3019: [CARBONDATA-3194] Integrating Carbon with Presto usi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3019 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1921/ ---
[jira] [Created] (CARBONDATA-3194) Support Hive Metastore in Presto CarbonData.
Ravindra Pesala created CARBONDATA-3194: --- Summary: Support Hive Metastore in Presto CarbonData. Key: CARBONDATA-3194 URL: https://issues.apache.org/jira/browse/CARBONDATA-3194 Project: CarbonData Issue Type: New Feature Reporter: Ravindra Pesala Current Carbon Presto integration added a new presto connector that takes the carbon store folder and lists the databases and tables from the folders. In this implementation, we have many issues like. 1. DB and table always need to be in specific order and name of the folders should always match the DB name and table name. 2. The table which is created in presto cannot be reflected directly in other execution engines like Spark. 3. DB with location and table with location cannot work. 4. There will not be any access control on tables. 5. There is no interoperability between hive tables like ORC or Parquet with carbon. Like if we want to join some hive table with Carbon Table then it won't be possible. To overcome the above limitations we can support HiveMetastore in Presto Carbon. Basically, instead of creating a new Presto Connector for Carbon, we can extend the HiveConnector and override and add new CarbonPageSourceFactory for reading the data and FileWriterFactory for writing the data. So Carbon Table becomes one of the hive supported format for Presto. So whatever the tables added in spark can be reflected immediately in Carbon and also the limitations mentioned above will be solved with this type of implementation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata issue #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Issue
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3010 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10171/ ---
[GitHub] carbondata issue #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Issue
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3010 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2128/ ---
[GitHub] carbondata issue #3004: [CARBONDATA-3188] Create carbon table as hive unders...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/3004 @SteNicholas This PR does not work directly on the Hive integration as we need to set the right serde, inputformat and output format. We are planning to refactor the current Hive integration code to unify the inpuformat and outputformat with the hadoop modules input/outformats. This PR is basic step for both Hive and Presto integration. ---
[GitHub] carbondata issue #3019: [WIP] Carbon Presto hive metastore
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3019 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1920/ ---
[GitHub] carbondata issue #3003: [CARBONDATA-3186]Avoid creating empty carbondata fil...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3003 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1919/ ---
[GitHub] carbondata issue #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Issue
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3010 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1918/ ---
[GitHub] carbondata issue #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Issue
Github user brijoobopanna commented on the issue: https://github.com/apache/carbondata/pull/3010 add to whitelist ---
[GitHub] carbondata issue #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Issue
Github user brijoobopanna commented on the issue: https://github.com/apache/carbondata/pull/3010 retest this please ---
[GitHub] carbondata issue #3015: [Carbondata-3173] Add the hive /presto documents ind...
Github user BeyondYourself commented on the issue: https://github.com/apache/carbondata/pull/3015 @xubo245 hi ,can you take a time to check this pr? ---
[GitHub] carbondata pull request #3017: [HOTFIX] remove this useless assignment
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3017#discussion_r243781483
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
@@ -112,7 +112,7 @@ public LocalFileLock(String lockFileLocation, String
lockFile) {
status = true;
}
} catch (IOException e) {
- status = false;
+ // status = false;
--- End diff --
it is no need
---
[GitHub] carbondata pull request #3017: [HOTFIX] remove this useless assignment
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3017#discussion_r243780410
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
@@ -112,7 +112,7 @@ public LocalFileLock(String lockFileLocation, String
lockFile) {
status = true;
}
} catch (IOException e) {
- status = false;
+ // status = false;
--- End diff --
Should it print error message for IOException ?
---
[GitHub] carbondata issue #3019: [WIP] Carbon Presto hive metastore
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3019 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2126/ ---
[GitHub] carbondata issue #3019: [WIP] Carbon Presto hive metastore
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3019 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10169/ ---
[GitHub] carbondata issue #2161: [CARBONDATA-2218] AlluxioCarbonFile while trying to ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2161 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2127/ ---
[GitHub] carbondata issue #2991: [CARBONDATA-3043] Add build script and add test case...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2991 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2125/ ---
[GitHub] carbondata issue #2991: [CARBONDATA-3043] Add build script and add test case...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2991 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10168/ ---
[GitHub] carbondata issue #2161: [CARBONDATA-2218] AlluxioCarbonFile while trying to ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2161 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1916/ ---
[GitHub] carbondata issue #3019: [WIP] Carbon Presto hive metastore
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3019 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1915/ ---
[GitHub] carbondata pull request #2161: [CARBONDATA-2218] AlluxioCarbonFile while try...
Github user chandrasaripaka commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r243773875
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -960,7 +960,7 @@ private CarbonCommonConstants() {
* If set to GLOBAL_SORT, the sorting scope is bigger and one index tree
per task will be
* created, thus loading is slower but query is faster.
*/
- public static final String LOAD_SORT_SCOPE_DEFAULT = "LOCAL_SORT";
+ public static final String LOAD_SORT_SCOPE_DEFAULT = "NO_SORT";
--- End diff --
resolved
---
[GitHub] carbondata pull request #3019: [WIP] Carbon Presto hive metastore
GitHub user ravipesala opened a pull request: https://github.com/apache/carbondata/pull/3019 [WIP] Carbon Presto hive metastore Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ravipesala/incubator-carbondata presto-hive-metastore Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/3019.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3019 commit 50f7a330e797bcdd71598fbf3145a71fa5df7215 Author: ravipesala Date: 2018-12-19T16:30:57Z Create carbon table as hive metastore table commit 8621a302ff2f26470b19d31b24a21ff03e4a2831 Author: ravipesala Date: 2018-12-19T15:49:41Z Added Hive Metastore to Carbon Presto ---
[GitHub] carbondata issue #2991: [CARBONDATA-3043] Add build script and add test case...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2991 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1914/ ---
[GitHub] carbondata issue #3003: [CARBONDATA-3186]Avoid creating empty carbondata fil...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3003 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10167/ ---
[GitHub] carbondata issue #3003: [CARBONDATA-3186]Avoid creating empty carbondata fil...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3003 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2124/ ---
[GitHub] carbondata issue #2161: [CARBONDATA-2218] AlluxioCarbonFile while trying to ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2161 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10166/ ---
[GitHub] carbondata issue #2161: [CARBONDATA-2218] AlluxioCarbonFile while trying to ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2161 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2123/ ---
[GitHub] carbondata issue #3003: [CARBONDATA-3186]Avoid creating empty carbondata fil...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3003 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1913/ ---
[GitHub] carbondata issue #3018: [HOTFIX] rename field "thread_pool_size" to match ca...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3018 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2122/ ---
[GitHub] carbondata pull request #3003: [CARBONDATA-3186]Avoid creating empty carbond...
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3003#discussion_r243770677
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
---
@@ -272,18 +272,44 @@ protected void commitCurrentFile(boolean
copyInCurrentThread) {
CarbonUtil.closeStreams(this.fileOutputStream, this.fileChannel);
if (!enableDirectlyWriteDataToStorePath) {
try {
-if (copyInCurrentThread) {
-
CarbonUtil.copyCarbonDataFileToCarbonStorePath(carbonDataFileTempPath,
- model.getCarbonDataDirectoryPath(), fileSizeInBytes);
+if (currentFileSize == 0) {
FileFactory
.deleteFile(carbonDataFileTempPath,
FileFactory.getFileType(carbonDataFileTempPath));
+ if (blockIndexInfoList.size() > 0 &&
blockIndexInfoList.get(blockIndexInfoList.size() - 1)
--- End diff --
not same, paths are different.
Now moved into a method that takes path.
---
[GitHub] carbondata issue #2161: [CARBONDATA-2218] AlluxioCarbonFile while trying to ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2161 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1912/ ---
[GitHub] carbondata issue #3018: [HOTFIX] rename field "thread_pool_size" to match ca...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3018 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10165/ ---
[GitHub] carbondata issue #3017: [HOTFIX] remove this useless assignment
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3017 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2121/ ---
[GitHub] carbondata issue #3017: [HOTFIX] remove this useless assignment
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3017 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10164/ ---
[GitHub] carbondata issue #3018: [HOTFIX] rename field "thread_pool_size" to match ca...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3018 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1911/ ---
[GitHub] carbondata pull request #3018: [HOTFIX] rename field "thread_pool_size" to m...
GitHub user lamber-ken opened a pull request: https://github.com/apache/carbondata/pull/3018 [HOTFIX] rename field "thread_pool_size" to match camel case Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [x] Any interfaces changed? NO - [x] Any backward compatibility impacted? NO - [x] Document update required? NO - [x] Testing done YES Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. OK You can merge this pull request into a Git repository by running: $ git pull https://github.com/BigDataArtisans/carbondata hotfix-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/3018.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3018 commit 842a5006763ef5f5375bdd01a6fda02e6420ebf4 Author: lamber-ken <2217232293@...> Date: 2018-12-23T15:52:15Z [HOTFIX] rename field "thread_pool_size" to match camel case ---
[GitHub] carbondata issue #3017: [HOTFIX] remove this useless assignment
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3017 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1910/ ---
[GitHub] carbondata issue #3017: [HOTFIX] remove this useless assignment
Github user lamber-ken commented on the issue: https://github.com/apache/carbondata/pull/3017 `status` was already assigned value `false` ---
[GitHub] carbondata pull request #3017: [HOTFIX] remove this useless assignment
GitHub user lamber-ken opened a pull request: https://github.com/apache/carbondata/pull/3017 [HOTFIX] remove this useless assignment Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/BigDataArtisans/carbondata hotfix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/3017.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3017 commit 5e4de2c103a6cf2253aa3181eee82c796700fb12 Author: lamber-ken <2217232293@...> Date: 2018-12-23T15:30:31Z [HOTFIX] remove this useless assignment ---
