[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/3029 ---

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user NamanRastogi commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r246329602 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionUtil.java --- @@ -400,24 +417,53 @@ private static int

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user NamanRastogi commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r246329142 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionExecutor.java --- @@ -105,10 +105,15 @@ public

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244959393 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SingleThreadFinalSortFilesMerger.java --- @@ -114,6 +113,31 @@

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244923003 --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataFileFooterConverterV3.java --- @@ -73,6 +73,11 @@ public DataFileFooter

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244921991 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala --- @@ -180,10 +180,10 @@ class

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user NamanRastogi commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244766765 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java --- @@ -156,21 +159,22 @@ public

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user NamanRastogi commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244766044 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/StreamHandoffRDD.scala --- @@ -118,7 +118,7 @@ class

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user NamanRastogi commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244766555 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionUtil.java --- @@ -400,24 +417,53 @@ private static int

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244723649 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java --- @@ -103,15 +104,22 @@ private void

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244722477 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java --- @@ -156,21 +159,22 @@ public

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244722390 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionUtil.java --- @@ -400,24 +417,53 @@ private static

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244721944 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionExecutor.java --- @@ -105,10 +105,15 @@ public

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244721762 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/StreamHandoffRDD.scala --- @@ -118,7 +118,7 @@ class

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244714375 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionUtil.java --- @@ -400,24 +417,53 @@ private static

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user NamanRastogi commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244713711 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/InMemorySortTempChunkHolder.java --- @@ -0,0 +1,109 @@

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244713354 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionUtil.java --- @@ -400,24 +417,53 @@ private static

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244712666 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/InMemorySortTempChunkHolder.java --- @@ -0,0 +1,109 @@

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244332001 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala --- @@ -166,8 +164,9 @@ class

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244331702 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala --- @@ -207,18 +212,34 @@ class

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244319031 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionExecutor.java --- @@ -126,17 +128,24 @@ public

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244252283 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionExecutor.java --- @@ -105,10 +107,10 @@ public

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

GitHub user NamanRastogi opened a pull request: https://github.com/apache/carbondata/pull/3029 [CARBONDATA-3200] No-Sort compaction When the data is loaded with SORT_SCOPE as NO_SORT, and done compaction upon, the data still remains unsorted. This does not affect much in query. The