[jira] [Resolved] (CLI-332) Add optional HelpFormatter Function to document Deprecated options

2024-05-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CLI-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CLI-332. - Fix Version/s: 1.7.1 Resolution: Fixed > Add optional HelpFormatter Function to document

Re: [PR] [CLI-332] Add optional HelpFormatter Function to document Deprecated options [commons-cli]

2024-05-11 Thread via GitHub
garydgregory merged PR #271: URL: https://github.com/apache/commons-cli/pull/271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (CLI-332) Add optional HelpFormatter Function to document Deprecated options

2024-05-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CLI-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated CLI-332: Summary: Add optional HelpFormatter Function to document Deprecated options (was: Deprecated option

Re: [PR] CLI-332: added ability to display deprecation information in help output [commons-cli]

2024-05-11 Thread via GitHub
garydgregory commented on code in PR #271: URL: https://github.com/apache/commons-cli/pull/271#discussion_r1597482434 ## src/main/java/org/apache/commons/cli/HelpFormatter.java: ## @@ -121,6 +121,7 @@ public Builder setShowDeprecated(final boolean useDefaultFormat) {

Re: [PR] CLI-332: added ability to display deprecation information in help output [commons-cli]

2024-05-11 Thread via GitHub
garydgregory commented on code in PR #271: URL: https://github.com/apache/commons-cli/pull/271#discussion_r1597480040 ## src/main/java/org/apache/commons/cli/HelpFormatter.java: ## @@ -121,6 +121,7 @@ public Builder setShowDeprecated(final boolean useDefaultFormat) {

Re: [PR] CLI-332: added ability to display deprecation information in help output [commons-cli]

2024-05-11 Thread via GitHub
garydgregory commented on code in PR #271: URL: https://github.com/apache/commons-cli/pull/271#discussion_r1597465949 ## src/main/java/org/apache/commons/cli/HelpFormatter.java: ## @@ -103,14 +109,23 @@ public Builder setPrintWriter(final PrintWriter printWriter) {

Re: [PR] CLI-332: added ability to display deprecation information in help output [commons-cli]

2024-05-11 Thread via GitHub
garydgregory commented on code in PR #271: URL: https://github.com/apache/commons-cli/pull/271#discussion_r1597465949 ## src/main/java/org/apache/commons/cli/HelpFormatter.java: ## @@ -103,14 +109,23 @@ public Builder setPrintWriter(final PrintWriter printWriter) {

[PR] CLI-332: added ability to display deprecation information in help output [commons-cli]

2024-05-11 Thread via GitHub
Claudenw opened a new pull request, #271: URL: https://github.com/apache/commons-cli/pull/271 Fix for CLI-332. Added a `BiFunction` to the HelpFormatter and its Builder.Also tests for same. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] CLI-313: adding new test to properly handling negative case of invali… [commons-cli]

2024-05-11 Thread via GitHub
garydgregory commented on PR #95: URL: https://github.com/apache/commons-cli/pull/95#issuecomment-2105817275 Closing: No reply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] CLI-313: adding new test to properly handling negative case of invali… [commons-cli]

2024-05-11 Thread via GitHub
garydgregory closed pull request #95: CLI-313: adding new test to properly handling negative case of invali… URL: https://github.com/apache/commons-cli/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [CLI-331] Handle reporting of deprecated options when parameters are not String type. [commons-cli]

2024-05-11 Thread via GitHub
garydgregory commented on PR #270: URL: https://github.com/apache/commons-cli/pull/270#issuecomment-2105776843 TY @Claudenw Merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (CLI-331) Deprecated option usage is not detected if non string keys are used for resolution.

2024-05-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CLI-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CLI-331. - Fix Version/s: 1.7.1 Resolution: Fixed > Deprecated option usage is not detected if non

Re: [PR] [CLI-331] Handle reporting of deprecated options when parameters are not String type. [commons-cli]

2024-05-11 Thread via GitHub
garydgregory merged PR #270: URL: https://github.com/apache/commons-cli/pull/270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (CLI-332) Deprecated option details not specified in HelpFormatter

2024-05-11 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/CLI-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren updated CLI-332: -- Description: Currently the HelpFormatter just prings "[Deprecated]" at the front of the description for 

[jira] [Updated] (CLI-332) Deprecated option details not specified in HelpFormatter

2024-05-11 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/CLI-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren updated CLI-332: -- Assignee: Claude Warren > Deprecated option details not specified in HelpFormatter >

Re: [PR] [CLI-331] Handle reporting of deprecated options when parameters are not String type. [commons-cli]

2024-05-11 Thread via GitHub
garydgregory commented on PR #270: URL: https://github.com/apache/commons-cli/pull/270#issuecomment-2105746044 > `mvn clean install` dies because of the code coverage issue. > […](#) > On Sat, May 11, 2024 at 2:48 PM Gary Gregory ***@***.***> wrote: @garydgregory

[jira] [Created] (CLI-332) Deprecated option details not specified in HelpFormatter

2024-05-11 Thread Claude Warren (Jira)
Claude Warren created CLI-332: - Summary: Deprecated option details not specified in HelpFormatter Key: CLI-332 URL: https://issues.apache.org/jira/browse/CLI-332 Project: Commons CLI Issue Type:

Re: [PR] [CLI-331] Handle reporting of deprecated options when parameters are not String type. [commons-cli]

2024-05-11 Thread via GitHub
Claudenw commented on PR #270: URL: https://github.com/apache/commons-cli/pull/270#issuecomment-2105740319 `mvn clean install` dies because of the code coverage issue. On Sat, May 11, 2024 at 2:48 PM Gary Gregory ***@***.***> wrote: > @garydgregory

Re: [PR] [CLI-331] Handle reporting of deprecated options when parameters are not String type. [commons-cli]

2024-05-11 Thread via GitHub
garydgregory commented on PR #270: URL: https://github.com/apache/commons-cli/pull/270#issuecomment-2105735744 > @garydgregory various reports say the coverage went up or down. I moved the check so that it occurs more frequently (both String and Option tests) so I don't know how there can

Re: [PR] [CLI-331] Handle reporting of deprecated options when parameters are not String type. [commons-cli]

2024-05-11 Thread via GitHub
garydgregory commented on PR #270: URL: https://github.com/apache/commons-cli/pull/270#issuecomment-2105734612 Hi @Claudenw Thank you for the pull request. The code coverage shows not all new branches in this PR are covered, which causes the build to fail. -- This is an automated

Re: [PR] [CLI-331] Handle reporting of deprecated options when parameters are not String type. [commons-cli]

2024-05-11 Thread via GitHub
Claudenw commented on PR #270: URL: https://github.com/apache/commons-cli/pull/270#issuecomment-2105688262 @garydgregory various reports say the coverage went up or down. I moved the check so that it occurs more frequently (both String and Option tests) so I don't know how there can be

[jira] [Updated] (CLI-331) Deprecated option usage is not detected if non string keys are used for resolution.

2024-05-11 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/CLI-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren updated CLI-331: -- Assignee: Claude Warren > Deprecated option usage is not detected if non string keys are used for >

[jira] [Created] (CLI-331) Deprecated option usage is not detected if non string keys are used for resolution.

2024-05-11 Thread Claude Warren (Jira)
Claude Warren created CLI-331: - Summary: Deprecated option usage is not detected if non string keys are used for resolution. Key: CLI-331 URL: https://issues.apache.org/jira/browse/CLI-331 Project:

Re: [PR] COLLECTIONS-853: Change LayerManager to use List and added generics to LayerdedBloomFilter [commons-collections]

2024-05-11 Thread via GitHub
aherbert commented on code in PR #481: URL: https://github.com/apache/commons-collections/pull/481#discussion_r1597373088 ## src/main/java/org/apache/commons/collections4/bloomfilter/LayerManager.java: ## @@ -179,15 +190,15 @@ public static final class ExtendCheck {