[jira] [Closed] (FLINK-7473) Possible Leak in GlobalWindows

2017-08-17 Thread Steve Jerman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Jerman closed FLINK-7473. --- Resolution: Not A Bug Release Note: user error. > Possible Leak in GlobalWindows >

[GitHub] flink issue #4554: [FLINK-7442] Add option for using child-first classloader...

2017-08-17 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4554 The system class loader stuff was leftover from an earlier version, I didn't mean to have that in there. In the first version I copied the `ChildFirstClassLoader` from

[jira] [Commented] (FLINK-7442) Add option for using a child-first classloader for loading user code

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131754#comment-16131754 ] ASF GitHub Bot commented on FLINK-7442: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-7473) Possible Leak in GlobalWindows

2017-08-17 Thread Steve Jerman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131745#comment-16131745 ] Steve Jerman commented on FLINK-7473: - OK. I think I have figured my issue. When setting my timeout I

[GitHub] flink issue #4557: [hotifx][streaming] Simplify state of TwoPhaseCommitSinkF...

2017-08-17 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4557 Ok, I will create JIRA issues for such things in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #4557: [hotifx][streaming] Simplify state of TwoPhaseCommitSinkF...

2017-08-17 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4557 This LGTM, +1. Merging this .. Minor nitpick for the future: I think although this is a small fix, the nature of the fix still deserves a dedicated JIRA ticket for it. Hotfixes, AFAIK,

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

2017-08-17 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4535 @zhuganghuaonnet please also rebase this pull request (there are conflicting classes) and change the pull request title. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

2017-08-17 Thread zhuganghuaonnet
Github user zhuganghuaonnet commented on the issue: https://github.com/apache/flink/pull/4535 @Tzu-Li Tai I have created a jira https://issues.apache.org/jira/browse/FLINK-7474. Pls help to review. Thx. :)

[jira] [Commented] (FLINK-7474) Flink supports consuming data from and sink data to Azure eventhubs

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131685#comment-16131685 ] ASF GitHub Bot commented on FLINK-7474: --- Github user zhuganghuaonnet commented on the issue:

[jira] [Created] (FLINK-7474) Flink supports consuming data from and sink data to Azure eventhubs

2017-08-17 Thread Joe (JIRA)
Joe created FLINK-7474: -- Summary: Flink supports consuming data from and sink data to Azure eventhubs Key: FLINK-7474 URL: https://issues.apache.org/jira/browse/FLINK-7474 Project: Flink Issue Type:

[jira] [Commented] (FLINK-5486) Lack of synchronization in BucketingSink#handleRestoredBucketState()

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131631#comment-16131631 ] ASF GitHub Bot commented on FLINK-5486: --- Github user zhangminglei commented on the issue:

[GitHub] flink issue #4356: [FLINK-5486] Fix lacking of synchronization in BucketingS...

2017-08-17 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4356 Okay. Ted. I will trigger the QA soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Assigned] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-17 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-7446: -- Assignee: Jark Wu > Support to define an existing field as the rowtime field for TableSource >

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-17 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131629#comment-16131629 ] Xingcan Cui commented on FLINK-7446: Now that the rowtime field is an existing one in the stream,

[jira] [Commented] (FLINK-5486) Lack of synchronization in BucketingSink#handleRestoredBucketState()

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131628#comment-16131628 ] ASF GitHub Bot commented on FLINK-5486: --- Github user tedyu commented on the issue:

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131626#comment-16131626 ] ASF GitHub Bot commented on FLINK-4534: --- Github user tedyu commented on the issue:

[GitHub] flink issue #4356: [FLINK-5486] Fix lacking of synchronization in BucketingS...

2017-08-17 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/4356 Run QA again ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #4482: [FLINK-4534] Fix synchronization issue in BucketingSink

2017-08-17 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/4482 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (FLINK-7062) Support the basic functionality of MATCH_RECOGNIZE

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131607#comment-16131607 ] ASF GitHub Bot commented on FLINK-7062: --- Github user dianfu commented on the issue:

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-17 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131616#comment-16131616 ] Jark Wu commented on FLINK-7446: [~fhueske] Great! I will make a pull request in the next days. > Support

[GitHub] flink issue #4502: [FLINK-7062] [table, cep] Support the basic functionality...

2017-08-17 Thread dianfu
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/4502 @fhueske @kl0u @dawidwys @wuchong Any feedback? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request #4560: Flink 7077

2017-08-17 Thread EronWright
GitHub user EronWright opened a pull request: https://github.com/apache/flink/pull/4560 Flink 7077 ## Description _This PR extends #4555 - please disregard commits from Aug 16, 2017._ [FLINK-7077] [mesos] Implement task release to support dynamic scaling

[jira] [Commented] (FLINK-7077) Implement task release to support dynamic scaling

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131597#comment-16131597 ] ASF GitHub Bot commented on FLINK-7077: --- GitHub user EronWright opened a pull request:

[jira] [Commented] (FLINK-7245) Enhance the operators to support holding back watermarks

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131587#comment-16131587 ] ASF GitHub Bot commented on FLINK-7245: --- Github user xccui commented on the issue:

[GitHub] flink issue #4530: [FLINK-7245] [stream] Support holding back watermarks wit...

2017-08-17 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/4530 Thanks for the comments @fhueske. I will pay more attention to the coding style. Actually, there are many ways to implement this feature. At first, I planed to override the

[jira] [Updated] (FLINK-7473) Possible Leak in GlobalWindows

2017-08-17 Thread Steve Jerman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Jerman updated FLINK-7473: Attachment: timerIssue.zip Sample project showing the issue. Look for

[jira] [Created] (FLINK-7473) Possible Leak in GlobalWindows

2017-08-17 Thread Steve Jerman (JIRA)
Steve Jerman created FLINK-7473: --- Summary: Possible Leak in GlobalWindows Key: FLINK-7473 URL: https://issues.apache.org/jira/browse/FLINK-7473 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-7472) Release task managers gracefully

2017-08-17 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eron Wright updated FLINK-7472: Description: When a task manager is no longer needed (e.g. due to idle timeout in slot manager),

[jira] [Commented] (FLINK-7245) Enhance the operators to support holding back watermarks

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131401#comment-16131401 ] ASF GitHub Bot commented on FLINK-7245: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7245) Enhance the operators to support holding back watermarks

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131403#comment-16131403 ] ASF GitHub Bot commented on FLINK-7245: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7245) Enhance the operators to support holding back watermarks

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131402#comment-16131402 ] ASF GitHub Bot commented on FLINK-7245: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7245) Enhance the operators to support holding back watermarks

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131400#comment-16131400 ] ASF GitHub Bot commented on FLINK-7245: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4530: [FLINK-7245] [stream] Support holding back waterma...

2017-08-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4530#discussion_r133843667 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/operators/KeyedCoProcessOperatorWithWatermarkDelayTest.scala --- @@

[GitHub] flink pull request #4530: [FLINK-7245] [stream] Support holding back waterma...

2017-08-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4530#discussion_r133843854 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/operators/KeyedProcessOperatorWithWatermarkDelayTest.scala --- @@ -0,0

[GitHub] flink pull request #4530: [FLINK-7245] [stream] Support holding back waterma...

2017-08-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4530#discussion_r133843436 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/operators/KeyedCoProcessOperatorWithWatermarkDelayTest.scala --- @@

[GitHub] flink pull request #4530: [FLINK-7245] [stream] Support holding back waterma...

2017-08-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4530#discussion_r133842744 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/operators/KeyedCoProcessOperatorWithWatermarkDelay.scala --- @@ -0,0

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-08-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131364#comment-16131364 ] Fabian Hueske commented on FLINK-6233: -- Hi [~xccui], sorry for the late reply. You are right that

[jira] [Created] (FLINK-7472) Release task managers gracefully

2017-08-17 Thread Eron Wright (JIRA)
Eron Wright created FLINK-7472: --- Summary: Release task managers gracefully Key: FLINK-7472 URL: https://issues.apache.org/jira/browse/FLINK-7472 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-7471) Improve bounded OVER support non-retract method AGG

2017-08-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131336#comment-16131336 ] Fabian Hueske commented on FLINK-7471: -- Are you proposing to compute all aggregates for each record

[jira] [Created] (FLINK-7471) Improve bounded OVER support non-retract method AGG

2017-08-17 Thread sunjincheng (JIRA)
sunjincheng created FLINK-7471: -- Summary: Improve bounded OVER support non-retract method AGG Key: FLINK-7471 URL: https://issues.apache.org/jira/browse/FLINK-7471 Project: Flink Issue Type:

[jira] [Commented] (FLINK-7465) Add build-in BloomFilterCount on TableAPI

2017-08-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131296#comment-16131296 ] Fabian Hueske commented on FLINK-7465: -- I think an approximate count distinct would be a very nice

[jira] [Commented] (FLINK-7447) Hope add more committer information to "Community & Project Info" page.

2017-08-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131275#comment-16131275 ] Fabian Hueske commented on FLINK-7447: -- I would be fine with adding time zone information but agree

[jira] [Commented] (FLINK-7358) Add implicitly converts support for User-defined function

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131268#comment-16131268 ] ASF GitHub Bot commented on FLINK-7358: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4534: [FLINK-7358][table]Add implicitly converts support for Us...

2017-08-17 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4534 Hi @sunjincheng121, can you please update the PR description and fill out the PR template? The community decided to extend the PR template and to be more strict about the PR submission

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131261#comment-16131261 ] Fabian Hueske commented on FLINK-7446: -- I think the existing {{DefinedRowtimeAttribute}} interface

[jira] [Created] (FLINK-7470) Acquire RM leadership before registering with Mesos

2017-08-17 Thread Eron Wright (JIRA)
Eron Wright created FLINK-7470: --- Summary: Acquire RM leadership before registering with Mesos Key: FLINK-7470 URL: https://issues.apache.org/jira/browse/FLINK-7470 Project: Flink Issue Type:

[jira] [Updated] (FLINK-7469) Handle slot requests occuring before RM registration completes

2017-08-17 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eron Wright updated FLINK-7469: Description: *Description* Occasionally the TM-to-RM registration ask times out, causing the TM to

[jira] [Commented] (FLINK-5633) ClassCastException: X cannot be cast to X when re-submitting a job.

2017-08-17 Thread Svend Vanderveken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130917#comment-16130917 ] Svend Vanderveken commented on FLINK-5633: -- Hi all, I am hitting exactly the same issue,

[jira] [Updated] (FLINK-7469) Handle slot requests occuring before RM registration completes

2017-08-17 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eron Wright updated FLINK-7469: Attachment: jm.log taskmanager-3.log > Handle slot requests occuring before RM

[jira] [Created] (FLINK-7469) Handle slot requests occuring before RM registration completes

2017-08-17 Thread Eron Wright (JIRA)
Eron Wright created FLINK-7469: --- Summary: Handle slot requests occuring before RM registration completes Key: FLINK-7469 URL: https://issues.apache.org/jira/browse/FLINK-7469 Project: Flink

[jira] [Commented] (FLINK-7442) Add option for using a child-first classloader for loading user code

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130810#comment-16130810 ] ASF GitHub Bot commented on FLINK-7442: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4554: [FLINK-7442] Add option for using child-first classloader...

2017-08-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4554 I took only a very brief look at this, but I am not totally sure whether the `ChildFirstClassLoader` implementation is actually correct. Even if it is, it seems to do redundant work, like

[jira] [Commented] (FLINK-7468) Implement Netty sender backlog logic for credit-based

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130756#comment-16130756 ] ASF GitHub Bot commented on FLINK-7468: --- GitHub user zhijiangW opened a pull request:

[GitHub] flink pull request #4559: [FLINK-7468][network]Implement Netty sender backlo...

2017-08-17 Thread zhijiangW
GitHub user zhijiangW opened a pull request: https://github.com/apache/flink/pull/4559 [FLINK-7468][network]Implement Netty sender backlog logic for credit-based ## What is the purpose of the change This PR is based on #4533 whose commits are also included for passing

[jira] [Created] (FLINK-7468) Implement Netty sender backlog logic for credit-based

2017-08-17 Thread zhijiang (JIRA)
zhijiang created FLINK-7468: --- Summary: Implement Netty sender backlog logic for credit-based Key: FLINK-7468 URL: https://issues.apache.org/jira/browse/FLINK-7468 Project: Flink Issue Type:

[GitHub] flink issue #4380: Time sort with offset/fetch without retraction

2017-08-17 Thread rtudoran
Github user rtudoran commented on the issue: https://github.com/apache/flink/pull/4380 @fhueske I have updated the PR. Based on the previous discussions i have: 1) integrated the support for offset and fetch when time is ascending as you suggested (having a counter within

[jira] [Commented] (FLINK-7466) Add a flink connector for Apache RocketMQ

2017-08-17 Thread yukon (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130375#comment-16130375 ] yukon commented on FLINK-7466: -- Hi [~jark] Many thanks for your reminding. > Add a flink connector for

[jira] [Commented] (FLINK-7466) Add a flink connector for Apache RocketMQ

2017-08-17 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130361#comment-16130361 ] Jark Wu commented on FLINK-7466: Thank you for writing and contributing a RocketMQ connector. New Flink

[GitHub] flink issue #4553: [FLINK-7642] [docs] Add very obvious warning about outdat...

2017-08-17 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4553 @twalthr Thanks for doing the work of merging this to the other branches as well. I've triggered a build for all branches. While 1.2 worked and the warning is now available online

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130295#comment-16130295 ] ASF GitHub Bot commented on FLINK-7057: --- Github user NicoK commented on the issue:

[GitHub] flink issue #4238: [FLINK-7057][blob] move BLOB ref-counting from LibraryCac...

2017-08-17 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4238 ok, rebased again but upon #4558 which adds one small fix that could cause hanging tests. I also addressed the comments you had, thanks. --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130291#comment-16130291 ] ASF GitHub Bot commented on FLINK-7057: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4238: [FLINK-7057][blob] move BLOB ref-counting from Lib...

2017-08-17 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4238#discussion_r133688568 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/testtasks/FailingBlockingInvokable.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to the

[GitHub] flink pull request #4238: [FLINK-7057][blob] move BLOB ref-counting from Lib...

2017-08-17 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4238#discussion_r133688433 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerCleanupITCase.java --- @@ -0,0 +1,298 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130289#comment-16130289 ] ASF GitHub Bot commented on FLINK-7057: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130284#comment-16130284 ] ASF GitHub Bot commented on FLINK-7057: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4238: [FLINK-7057][blob] move BLOB ref-counting from Lib...

2017-08-17 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4238#discussion_r133687826 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobCacheCleanupTest.java --- @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130273#comment-16130273 ] ASF GitHub Bot commented on FLINK-7057: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4238: [FLINK-7057][blob] move BLOB ref-counting from Lib...

2017-08-17 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4238#discussion_r133685671 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -148,7 +149,10 @@ /** Service to contend for and

[jira] [Commented] (FLINK-7056) add API to allow job-related BLOBs to be stored

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130209#comment-16130209 ] ASF GitHub Bot commented on FLINK-7056: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4558: [FLINK-7056][tests][hotfix] make sure the client a...

2017-08-17 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4558#discussion_r133675837 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java --- @@ -139,30 +139,35 @@ private static BlobKey prepareTestFile(File

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130197#comment-16130197 ] ASF GitHub Bot commented on FLINK-7057: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130195#comment-16130195 ] ASF GitHub Bot commented on FLINK-7057: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4238: [FLINK-7057][blob] move BLOB ref-counting from Lib...

2017-08-17 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4238#discussion_r133673650 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerCleanupITCase.java --- @@ -0,0 +1,298 @@ +/* + * Licensed

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130202#comment-16130202 ] ASF GitHub Bot commented on FLINK-7057: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130198#comment-16130198 ] ASF GitHub Bot commented on FLINK-7057: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130196#comment-16130196 ] ASF GitHub Bot commented on FLINK-7057: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7056) add API to allow job-related BLOBs to be stored

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130194#comment-16130194 ] ASF GitHub Bot commented on FLINK-7056: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130200#comment-16130200 ] ASF GitHub Bot commented on FLINK-7057: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130201#comment-16130201 ] ASF GitHub Bot commented on FLINK-7057: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130199#comment-16130199 ] ASF GitHub Bot commented on FLINK-7057: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4238: [FLINK-7057][blob] move BLOB ref-counting from Lib...

2017-08-17 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4238#discussion_r133668912 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobCacheCleanupTest.java --- @@ -0,0 +1,324 @@ +/* + * Licensed to the

[GitHub] flink pull request #4238: [FLINK-7057][blob] move BLOB ref-counting from Lib...

2017-08-17 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4238#discussion_r133670563 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobCacheCleanupTest.java --- @@ -0,0 +1,324 @@ +/* + * Licensed to the

[GitHub] flink pull request #4558: [FLINK-7056][tests][hotfix] make sure the client a...

2017-08-17 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4558#discussion_r133674886 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java --- @@ -139,30 +139,35 @@ private static BlobKey

[GitHub] flink pull request #4238: [FLINK-7057][blob] move BLOB ref-counting from Lib...

2017-08-17 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4238#discussion_r133669690 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobCacheCleanupTest.java --- @@ -0,0 +1,324 @@ +/* + * Licensed to the

[GitHub] flink pull request #4238: [FLINK-7057][blob] move BLOB ref-counting from Lib...

2017-08-17 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4238#discussion_r133670196 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobCacheCleanupTest.java --- @@ -0,0 +1,324 @@ +/* + * Licensed to the

[GitHub] flink pull request #4238: [FLINK-7057][blob] move BLOB ref-counting from Lib...

2017-08-17 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4238#discussion_r133674703 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/testtasks/FailingBlockingInvokable.java --- @@ -0,0 +1,48 @@ +/* + * Licensed

[GitHub] flink pull request #4238: [FLINK-7057][blob] move BLOB ref-counting from Lib...

2017-08-17 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4238#discussion_r133671238 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/execution/librarycache/BlobLibraryCacheManagerTest.java --- @@ -45,6 +42,18 @@

[GitHub] flink pull request #4238: [FLINK-7057][blob] move BLOB ref-counting from Lib...

2017-08-17 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4238#discussion_r133673260 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerCleanupITCase.java --- @@ -0,0 +1,298 @@ +/* + * Licensed

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130190#comment-16130190 ] ASF GitHub Bot commented on FLINK-7057: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #4558: [FLINK-7057][tests][hotfix] make sure the client a...

2017-08-17 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4558 [FLINK-7057][tests][hotfix] make sure the client and a created InputStream are closed ## What is the purpose of the change This fixes some stalling tests in the following cases: if the

[jira] [Created] (FLINK-7467) a slow client on the BlobServer may block writing operations

2017-08-17 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7467: -- Summary: a slow client on the BlobServer may block writing operations Key: FLINK-7467 URL: https://issues.apache.org/jira/browse/FLINK-7467 Project: Flink

[jira] [Commented] (FLINK-7169) Support AFTER MATCH SKIP function in CEP library API

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130168#comment-16130168 ] ASF GitHub Bot commented on FLINK-7169: --- Github user dawidwys commented on a diff in the pull

[jira] [Created] (FLINK-7466) Add a flink connector for Apache RocketMQ

2017-08-17 Thread yukon (JIRA)
yukon created FLINK-7466: Summary: Add a flink connector for Apache RocketMQ Key: FLINK-7466 URL: https://issues.apache.org/jira/browse/FLINK-7466 Project: Flink Issue Type: New Feature

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-17 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r133667042 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -340,6 +362,65 @@ public void resetNFAChanged() {

[jira] [Commented] (FLINK-7461) Remove Backwards compatibility for Flink 1.1 from Flink 1.4

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130146#comment-16130146 ] ASF GitHub Bot commented on FLINK-7461: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #4550: [FLINK-7461] Remove Backwards compatibility with <= Flink...

2017-08-17 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4550 I have pushed an updated version with the changes that @zentol suggested and the additional cleanups suggested by @dawidwys. @dawidwys I removed the code that you mentioned, but it is

[jira] [Commented] (FLINK-7461) Remove Backwards compatibility for Flink 1.1 from Flink 1.4

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130141#comment-16130141 ] ASF GitHub Bot commented on FLINK-7461: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #4550: [FLINK-7461] Remove Backwards compatibility with <...

2017-08-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4550#discussion_r133663601 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java --- @@ -122,6

[jira] [Commented] (FLINK-7461) Remove Backwards compatibility for Flink 1.1 from Flink 1.4

2017-08-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130142#comment-16130142 ] ASF GitHub Bot commented on FLINK-7461: --- Github user StefanRRichter commented on a diff in the pull

  1   2   >