[jira] [Commented] (FLINK-7979) Use Log.*(Object, Throwable) overload to log exceptions

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245575#comment-16245575 ] ASF GitHub Bot commented on FLINK-7979: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4948: [FLINK-7979][minor] Use Log.*(Object, Throwable) overload...

2017-11-09 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4948 Thanks for understanding! ---

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245571#comment-16245571 ] ASF GitHub Bot commented on FLINK-8005: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245569#comment-16245569 ] ASF GitHub Bot commented on FLINK-8005: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245570#comment-16245570 ] ASF GitHub Bot commented on FLINK-8005: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245572#comment-16245572 ] ASF GitHub Bot commented on FLINK-8005: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149947069 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -254,12 +300,10 @@ else if (this.error == null) {

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149947094 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -254,12 +300,10 @@ else if (this.error == null) {

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149949202 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -58,99 +59,144 @@ import org.junit.Before;

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149946930 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/DispatcherThreadFactory.java --- @@ -29,21 +31,41 @@ private final

[jira] [Commented] (FLINK-8008) PojoTypeInfo should sort fields fields based on boolean

2017-11-09 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245513#comment-16245513 ] Fabian Hueske commented on FLINK-8008: -- Except for nested field, {{CsvTableSink}} simply calls

[jira] [Commented] (FLINK-8008) PojoTypeInfo should sort fields fields based on boolean

2017-11-09 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245509#comment-16245509 ] Fabian Hueske commented on FLINK-8008: -- Depends on the TableSink. {{CsvTableSink}} will write the

[jira] [Commented] (FLINK-8008) PojoTypeInfo should sort fields fields based on boolean

2017-11-09 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245504#comment-16245504 ] Aljoscha Krettek commented on FLINK-8008: - [~fhueske] Is there a way of specifying the order of

[jira] [Commented] (FLINK-8009) flink-dist pulls in flink-runtime's transitive avro/jackson dependency

2017-11-09 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245498#comment-16245498 ] Aljoscha Krettek commented on FLINK-8009: - It's a weird situation but if someone looks at the

[jira] [Commented] (FLINK-7977) bump version of compatibility check for Flink 1.4

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245496#comment-16245496 ] ASF GitHub Bot commented on FLINK-7977: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4945: [FLINK-7977][build] bump version of compatibility check f...

2017-11-09 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4945 @greghogan That makes sense, I didn't think about added APIs. ---

[jira] [Commented] (FLINK-7419) Shade jackson dependency in flink-avro

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245495#comment-16245495 ] ASF GitHub Bot commented on FLINK-7419: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4981: [FLINK-7419][build][avro] Relocate jackson in flink-dist

2017-11-09 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4981 Ok, sounds good. 👌 ---

[jira] [Commented] (FLINK-7980) Bump joda-time to 2.9.9

2017-11-09 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245492#comment-16245492 ] Aljoscha Krettek commented on FLINK-7980: - Yep, I think getting rid of it makes sense. > Bump

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245484#comment-16245484 ] ASF GitHub Bot commented on FLINK-8005: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149926517 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -58,99 +59,144 @@ import org.junit.Before;

[jira] [Commented] (FLINK-5633) ClassCastException: X cannot be cast to X when re-submitting a job.

2017-11-09 Thread Erik van Oosten (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245474#comment-16245474 ] Erik van Oosten commented on FLINK-5633: bq. Just curious, why are you creating a new reader for

[GitHub] flink pull request #4982: [FLINK-8024] Let ClusterOverviewHandler directly e...

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4982 ---

[GitHub] flink pull request #4984: [FLINK-8026] Let ClusterConfigHandler directly ext...

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4984 ---

[jira] [Closed] (FLINK-8026) Let ClusterConfigHandler extend from AbstractRestHandler

2017-11-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8026. Resolution: Fixed Fixed via 541fe43663d2a24b1ae66bc2b5228c49dfd43e7b > Let ClusterConfigHandler

[jira] [Commented] (FLINK-8026) Let ClusterConfigHandler extend from AbstractRestHandler

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245444#comment-16245444 ] ASF GitHub Bot commented on FLINK-8026: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-8025) Let DashboardConfigHandler extend from AbstractRestHandler

2017-11-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8025. Resolution: Fixed Fixed via fa967dfc0cddec0a5d0c7d76e564a8307ec3fb35 > Let DashboardConfigHandler

[jira] [Commented] (FLINK-8024) Let ClusterOverviewHandler directly extend from AbstractRestHandler

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245442#comment-16245442 ] ASF GitHub Bot commented on FLINK-8024: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-8000) Sort REST handler URLs in RestServerEndpoint

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245441#comment-16245441 ] ASF GitHub Bot commented on FLINK-8000: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-8025) Let DashboardConfigHandler extend from AbstractRestHandler

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245443#comment-16245443 ] ASF GitHub Bot commented on FLINK-8025: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4983: [FLINK-8025] Let DashboardConfigHandler directly e...

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4983 ---

[GitHub] flink pull request #4958: [FLINK-8000] Sort Rest handler URLS in RestServerE...

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4958 ---

[jira] [Closed] (FLINK-8024) Let ClusterOverviewHandler directly extend from AbstractRestHandler

2017-11-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8024. Resolution: Fixed Fixed via 34fdf569d7defb4393849fb9ecb2763b14532cc6 > Let ClusterOverviewHandler

[jira] [Closed] (FLINK-8000) Sort REST handler URLs in RestServerEndpoint

2017-11-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8000. Resolution: Fixed Fix Version/s: 1.5.0 Fixed via 34fdf569d7defb4393849fb9ecb2763b14532cc6 >

[jira] [Commented] (FLINK-8025) Let DashboardConfigHandler extend from AbstractRestHandler

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245428#comment-16245428 ] ASF GitHub Bot commented on FLINK-8025: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #4984: [FLINK-8026] Let ClusterConfigHandler directly extend Abs...

2017-11-09 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4984 Thanks for your review @zentol. Merging. ---

[jira] [Commented] (FLINK-8026) Let ClusterConfigHandler extend from AbstractRestHandler

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245430#comment-16245430 ] ASF GitHub Bot commented on FLINK-8026: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #4983: [FLINK-8025] Let DashboardConfigHandler directly extend A...

2017-11-09 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4983 Thanks for your review @zentol. Merging. ---

[jira] [Commented] (FLINK-8024) Let ClusterOverviewHandler directly extend from AbstractRestHandler

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245426#comment-16245426 ] ASF GitHub Bot commented on FLINK-8024: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #4982: [FLINK-8024] Let ClusterOverviewHandler directly extend f...

2017-11-09 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4982 Thanks for your review @zentol. Merging. ---

[jira] [Commented] (FLINK-8000) Sort REST handler URLs in RestServerEndpoint

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245425#comment-16245425 ] ASF GitHub Bot commented on FLINK-8000: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #4958: [FLINK-8000] Sort Rest handler URLS in RestServerEndpoint

2017-11-09 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4958 Will remove the comment and then merge the PR. Thanks for your review @zentol. ---

[jira] [Commented] (FLINK-7704) Port JobPlanHandler to new REST endpoint

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245423#comment-16245423 ] ASF GitHub Bot commented on FLINK-7704: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4978: [FLINK-7704][hotfix][flip6] Fix JobPlanInfoTest pa...

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4978 ---

[GitHub] flink issue #4978: [FLINK-7704][hotfix][flip6] Fix JobPlanInfoTest package p...

2017-11-09 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4978 LGTM. Thanks for your contribution @yew1eb. Merging. ---

[jira] [Commented] (FLINK-7704) Port JobPlanHandler to new REST endpoint

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245421#comment-16245421 ] ASF GitHub Bot commented on FLINK-7704: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-8036) Consider using gradle to build Flink

2017-11-09 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245390#comment-16245390 ] Fabian Hueske commented on FLINK-8036: -- I think this will be very hard. Flink's build management

[jira] [Comment Edited] (FLINK-7003) "select * from" in Flink SQL should not flatten all fields in the table by default

2017-11-09 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245361#comment-16245361 ] Shuyi Chen edited comment on FLINK-7003 at 11/9/17 8:28 AM: added [pull

[jira] [Commented] (FLINK-7003) "select * from" in Flink SQL should not flatten all fields in the table by default

2017-11-09 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245361#comment-16245361 ] Shuyi Chen commented on FLINK-7003: --- added [link pull

[jira] [Commented] (FLINK-7517) let NettyBufferPool extend PooledByteBufAllocator

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245348#comment-16245348 ] ASF GitHub Bot commented on FLINK-7517: --- Github user zhijiangW commented on the issue:

[GitHub] flink issue #4594: [FLINK-7517][network] let NettyBufferPool extend PooledBy...

2017-11-09 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4594 This improvement is indeed very clean and reduce many redundant `Override` methods by extending `PooledByteBufAllocator` directly. But I am still confused of one thing. In previous way,

[jira] [Commented] (FLINK-7517) let NettyBufferPool extend PooledByteBufAllocator

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245347#comment-16245347 ] ASF GitHub Bot commented on FLINK-7517: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4989: [Flink 7003] [Table API & SQL] use PEEK_FIELDS_NO_...

2017-11-09 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/4989 [Flink 7003] [Table API & SQL] use PEEK_FIELDS_NO_EXPAND for CompositeRelDataType ## What is the purpose of the change This pull request change CompositeRelDataType to use the newly added

[GitHub] flink pull request #4594: [FLINK-7517][network] let NettyBufferPool extend P...

2017-11-09 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4594#discussion_r149889426 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyBufferPool.java --- @@ -52,51 +48,61 @@ /** Configured chunk

<    1   2