[
https://issues.apache.org/jira/browse/FLINK-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245575#comment-16245575
]
ASF GitHub Bot commented on FLINK-7979:
---
Github user StephanEwen commented on the issue:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4948
Thanks for understanding!
---
[
https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245571#comment-16245571
]
ASF GitHub Bot commented on FLINK-8005:
---
Github user kl0u commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245569#comment-16245569
]
ASF GitHub Bot commented on FLINK-8005:
---
Github user kl0u commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245570#comment-16245570
]
ASF GitHub Bot commented on FLINK-8005:
---
Github user kl0u commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245572#comment-16245572
]
ASF GitHub Bot commented on FLINK-8005:
---
Github user kl0u commented on a diff in the pull request:
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149947069
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -254,12 +300,10 @@ else if (this.error == null) {
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149947094
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -254,12 +300,10 @@ else if (this.error == null) {
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149949202
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -58,99 +59,144 @@
import org.junit.Before;
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149946930
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/DispatcherThreadFactory.java
---
@@ -29,21 +31,41 @@
private final
[
https://issues.apache.org/jira/browse/FLINK-8008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245513#comment-16245513
]
Fabian Hueske commented on FLINK-8008:
--
Except for nested field, {{CsvTableSink}} simply calls
[
https://issues.apache.org/jira/browse/FLINK-8008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245509#comment-16245509
]
Fabian Hueske commented on FLINK-8008:
--
Depends on the TableSink.
{{CsvTableSink}} will write the
[
https://issues.apache.org/jira/browse/FLINK-8008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245504#comment-16245504
]
Aljoscha Krettek commented on FLINK-8008:
-
[~fhueske] Is there a way of specifying the order of
[
https://issues.apache.org/jira/browse/FLINK-8009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245498#comment-16245498
]
Aljoscha Krettek commented on FLINK-8009:
-
It's a weird situation but if someone looks at the
[
https://issues.apache.org/jira/browse/FLINK-7977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245496#comment-16245496
]
ASF GitHub Bot commented on FLINK-7977:
---
Github user aljoscha commented on the issue:
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4945
@greghogan That makes sense, I didn't think about added APIs.
---
[
https://issues.apache.org/jira/browse/FLINK-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245495#comment-16245495
]
ASF GitHub Bot commented on FLINK-7419:
---
Github user aljoscha commented on the issue:
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4981
Ok, sounds good. ð
---
[
https://issues.apache.org/jira/browse/FLINK-7980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245492#comment-16245492
]
Aljoscha Krettek commented on FLINK-7980:
-
Yep, I think getting rid of it makes sense.
> Bump
[
https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245484#comment-16245484
]
ASF GitHub Bot commented on FLINK-8005:
---
Github user aljoscha commented on a diff in the pull
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149926517
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -58,99 +59,144 @@
import org.junit.Before;
[
https://issues.apache.org/jira/browse/FLINK-5633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245474#comment-16245474
]
Erik van Oosten commented on FLINK-5633:
bq. Just curious, why are you creating a new reader for
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4982
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4984
---
[
https://issues.apache.org/jira/browse/FLINK-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-8026.
Resolution: Fixed
Fixed via 541fe43663d2a24b1ae66bc2b5228c49dfd43e7b
> Let ClusterConfigHandler
[
https://issues.apache.org/jira/browse/FLINK-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245444#comment-16245444
]
ASF GitHub Bot commented on FLINK-8026:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-8025.
Resolution: Fixed
Fixed via fa967dfc0cddec0a5d0c7d76e564a8307ec3fb35
> Let DashboardConfigHandler
[
https://issues.apache.org/jira/browse/FLINK-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245442#comment-16245442
]
ASF GitHub Bot commented on FLINK-8024:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245441#comment-16245441
]
ASF GitHub Bot commented on FLINK-8000:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245443#comment-16245443
]
ASF GitHub Bot commented on FLINK-8025:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4983
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4958
---
[
https://issues.apache.org/jira/browse/FLINK-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-8024.
Resolution: Fixed
Fixed via 34fdf569d7defb4393849fb9ecb2763b14532cc6
> Let ClusterOverviewHandler
[
https://issues.apache.org/jira/browse/FLINK-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-8000.
Resolution: Fixed
Fix Version/s: 1.5.0
Fixed via 34fdf569d7defb4393849fb9ecb2763b14532cc6
>
[
https://issues.apache.org/jira/browse/FLINK-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245428#comment-16245428
]
ASF GitHub Bot commented on FLINK-8025:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4984
Thanks for your review @zentol. Merging.
---
[
https://issues.apache.org/jira/browse/FLINK-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245430#comment-16245430
]
ASF GitHub Bot commented on FLINK-8026:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4983
Thanks for your review @zentol. Merging.
---
[
https://issues.apache.org/jira/browse/FLINK-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245426#comment-16245426
]
ASF GitHub Bot commented on FLINK-8024:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4982
Thanks for your review @zentol. Merging.
---
[
https://issues.apache.org/jira/browse/FLINK-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245425#comment-16245425
]
ASF GitHub Bot commented on FLINK-8000:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4958
Will remove the comment and then merge the PR. Thanks for your review
@zentol.
---
[
https://issues.apache.org/jira/browse/FLINK-7704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245423#comment-16245423
]
ASF GitHub Bot commented on FLINK-7704:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4978
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4978
LGTM. Thanks for your contribution @yew1eb. Merging.
---
[
https://issues.apache.org/jira/browse/FLINK-7704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245421#comment-16245421
]
ASF GitHub Bot commented on FLINK-7704:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-8036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245390#comment-16245390
]
Fabian Hueske commented on FLINK-8036:
--
I think this will be very hard.
Flink's build management
[
https://issues.apache.org/jira/browse/FLINK-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245361#comment-16245361
]
Shuyi Chen edited comment on FLINK-7003 at 11/9/17 8:28 AM:
added [pull
[
https://issues.apache.org/jira/browse/FLINK-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245361#comment-16245361
]
Shuyi Chen commented on FLINK-7003:
---
added [link pull
[
https://issues.apache.org/jira/browse/FLINK-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245348#comment-16245348
]
ASF GitHub Bot commented on FLINK-7517:
---
Github user zhijiangW commented on the issue:
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4594
This improvement is indeed very clean and reduce many redundant `Override`
methods by extending `PooledByteBufAllocator` directly.
But I am still confused of one thing. In previous way,
[
https://issues.apache.org/jira/browse/FLINK-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245347#comment-16245347
]
ASF GitHub Bot commented on FLINK-7517:
---
Github user NicoK commented on a diff in the pull request:
GitHub user suez1224 opened a pull request:
https://github.com/apache/flink/pull/4989
[Flink 7003] [Table API & SQL] use PEEK_FIELDS_NO_EXPAND for
CompositeRelDataType
## What is the purpose of the change
This pull request change CompositeRelDataType to use the newly added
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4594#discussion_r149889426
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyBufferPool.java
---
@@ -52,51 +48,61 @@
/** Configured chunk
101 - 154 of 154 matches
Mail list logo