[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623102#comment-16623102 ] ASF GitHub Bot commented on FLINK-10386: TisonKun opened a new pull request #6729: [FLINK-10386]

[jira] [Updated] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10386: --- Labels: pull-request-available (was: ) > Remove legacy class TaskExecutionStateListener >

[GitHub] TisonKun opened a new pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-09-20 Thread GitBox
TisonKun opened a new pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729 ## What is the purpose of the change After a discussion

[jira] [Comment Edited] (FLINK-8851) SQL Client fails if same file is used as default and env configuration

2018-09-20 Thread xuqianjin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623073#comment-16623073 ] xuqianjin edited comment on FLINK-8851 at 9/21/18 5:09 AM: --- [~fhueske]

[jira] [Commented] (FLINK-8851) SQL Client fails if same file is used as default and env configuration

2018-09-20 Thread xuqianjin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623073#comment-16623073 ] xuqianjin commented on FLINK-8851: -- [~fhueske] [~twalthr] Hello, I want to try to recreate and fix this

[jira] [Created] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-09-20 Thread JIRA
陈梓立 created FLINK-10386: --- Summary: Remove legacy class TaskExecutionStateListener Key: FLINK-10386 URL: https://issues.apache.org/jira/browse/FLINK-10386 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-10385) Implement a waitUntilCondition utils

2018-09-20 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-10385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 陈梓立 updated FLINK-10385: Description: Recently when I refine some tests, I notice that it is a common requirement to wait until a

[jira] [Updated] (FLINK-10385) Implement a waitUntilCondition utils

2018-09-20 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-10385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 陈梓立 updated FLINK-10385: Attachment: example.java > Implement a waitUntilCondition utils > > >

[jira] [Created] (FLINK-10385) Implement a waitUntilCondition utils

2018-09-20 Thread JIRA
陈梓立 created FLINK-10385: --- Summary: Implement a waitUntilCondition utils Key: FLINK-10385 URL: https://issues.apache.org/jira/browse/FLINK-10385 Project: Flink Issue Type: Improvement

[GitHub] xccui commented on issue #6576: [FLINK-10145][table] Add replace supported in TableAPI and SQL

2018-09-20 Thread GitBox
xccui commented on issue #6576: [FLINK-10145][table] Add replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6576#issuecomment-423406252 Hi @Guibo-Pan, I wonder if you could rebase your code to resolve these conflicts. Thanks, Xingcan

[jira] [Commented] (FLINK-10145) Add replace supported in TableAPI and SQL

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623034#comment-16623034 ] ASF GitHub Bot commented on FLINK-10145: xccui commented on issue #6576: [FLINK-10145][table]

[jira] [Commented] (FLINK-9990) Add regexp_extract supported in TableAPI and SQL

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623031#comment-16623031 ] ASF GitHub Bot commented on FLINK-9990: --- xccui commented on a change in pull request #6448:

[GitHub] xccui commented on a change in pull request #6448: [FLINK-9990] [table] Add regexp_extract supported in TableAPI and SQL

2018-09-20 Thread GitBox
xccui commented on a change in pull request #6448: [FLINK-9990] [table] Add regexp_extract supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6448#discussion_r219375972 ## File path: docs/dev/table/functions.md ## @@ -2448,6 +2448,18 @@

[jira] [Updated] (FLINK-10384) Add Sinh math function supported in Table API and SQL

2018-09-20 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated FLINK-10384: - Description: like FLINK-10340 for adding Cosh math function (was: like FLINK-10340) > Add Sinh math

[jira] [Created] (FLINK-10384) Add Sinh math function supported in Table API and SQL

2018-09-20 Thread vinoyang (JIRA)
vinoyang created FLINK-10384: Summary: Add Sinh math function supported in Table API and SQL Key: FLINK-10384 URL: https://issues.apache.org/jira/browse/FLINK-10384 Project: Flink Issue Type:

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622968#comment-16622968 ] ASF GitHub Bot commented on FLINK-10247: Clark commented on issue #6676:

[GitHub] Clarkkkkk commented on issue #6676: [FLINK-10247][Metrics] Run MetricQueryService in separate thread pool

2018-09-20 Thread GitBox
Clark commented on issue #6676: [FLINK-10247][Metrics] Run MetricQueryService in separate thread pool URL: https://github.com/apache/flink/pull/6676#issuecomment-423392372 Hi @tillrohrmann, I have investigated on this after you comment on Jira. Thank you for sharing your idea and it

[jira] [Closed] (FLINK-10302) Mark legacy(non-flip 6) code as Deprecated

2018-09-20 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 陈梓立 closed FLINK-10302. --- Resolution: Won't Do > Mark legacy(non-flip 6) code as Deprecated > -- > >

[jira] [Assigned] (FLINK-9854) Allow passing multi-line input to SQL Client CLI

2018-09-20 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-9854: --- Assignee: vinoyang > Allow passing multi-line input to SQL Client CLI >

[jira] [Commented] (FLINK-10302) Mark legacy(non-flip 6) code as Deprecated

2018-09-20 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622966#comment-16622966 ] 陈梓立 commented on FLINK-10302: - So we need not to add such annotations since they are removed within the next

[jira] [Updated] (FLINK-10302) Mark legacy(non-flip 6) code as Deprecated

2018-09-20 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 陈梓立 updated FLINK-10302: Priority: Minor (was: Major) > Mark legacy(non-flip 6) code as Deprecated >

[jira] [Updated] (FLINK-10079) Support external sink table in INSERT INTO statement

2018-09-20 Thread Jun Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Zhang updated FLINK-10079: -- Summary: Support external sink table in INSERT INTO statement (was: Automatically register sink

[jira] [Commented] (FLINK-10379) Can not use Table Functions in Java Table API

2018-09-20 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622933#comment-16622933 ] Hequn Cheng commented on FLINK-10379: - I would like to look into this problem. > Can not use Table

[jira] [Assigned] (FLINK-10379) Can not use Table Functions in Java Table API

2018-09-20 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng reassigned FLINK-10379: --- Assignee: Hequn Cheng > Can not use Table Functions in Java Table API >

[jira] [Commented] (FLINK-7942) NPE when apply FilterJoinRule

2018-09-20 Thread Mayer Crystal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622869#comment-16622869 ] Mayer Crystal commented on FLINK-7942: -- I know that this is marked as resolved, but I'm wondering if

[jira] [Commented] (FLINK-8035) Unable to submit job when HA is enabled

2018-09-20 Thread Jason Kania (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622792#comment-16622792 ] Jason Kania commented on FLINK-8035: I would need to know the specific logs you would like to see and

[jira] [Commented] (FLINK-10256) Port legacy jobmanager test to FILP-6

2018-09-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622760#comment-16622760 ] Till Rohrmann commented on FLINK-10256: --- At the moment the {{JobMaster}} failover is not super

[jira] [Commented] (FLINK-8035) Unable to submit job when HA is enabled

2018-09-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622751#comment-16622751 ] Till Rohrmann commented on FLINK-8035: -- In order to better understand your problem, getting access

[jira] [Commented] (FLINK-10302) Mark legacy(non-flip 6) code as Deprecated

2018-09-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622750#comment-16622750 ] Till Rohrmann commented on FLINK-10302: --- Yes this is the goal for the 1.7.0 release. > Mark

[jira] [Commented] (FLINK-10320) Introduce JobMaster schedule micro-benchmark

2018-09-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622747#comment-16622747 ] Till Rohrmann commented on FLINK-10320: --- I'm also not 100 percent sure that a scheduling benchmark

[jira] [Commented] (FLINK-10358) Flink kinesis connector could throw NPE during getRecords() call

2018-09-20 Thread Ying Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622739#comment-16622739 ] Ying Xu commented on FLINK-10358: - [PR 6708|https://github.com/apache/flink/pull/6708] is merged >

[jira] [Closed] (FLINK-10358) Flink kinesis connector could throw NPE during getRecords() call

2018-09-20 Thread Ying Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ying Xu closed FLINK-10358. --- Resolution: Fixed > Flink kinesis connector could throw NPE during getRecords() call >

[jira] [Updated] (FLINK-10305) flink-conf.yaml grows continuously

2018-09-20 Thread Dimitrije (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitrije updated FLINK-10305: -- Priority: Major (was: Minor) > flink-conf.yaml grows continuously >

[jira] [Commented] (FLINK-10375) ExceptionInChainedStubException hides wrapped exception in cause

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622590#comment-16622590 ] ASF GitHub Bot commented on FLINK-10375: Noctune commented on issue #6719: [FLINK-10375] Add

[GitHub] Noctune commented on issue #6719: [FLINK-10375] Add wrapped exception as cause in ExceptionInChainedStubException

2018-09-20 Thread GitBox
Noctune commented on issue #6719: [FLINK-10375] Add wrapped exception as cause in ExceptionInChainedStubException URL: https://github.com/apache/flink/pull/6719#issuecomment-423306534 Seems like the build fails due to log length, but that is obviously not due to this change as no

[jira] [Commented] (FLINK-10380) Check if key is not nul before assign to group in KeyedStream

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622576#comment-16622576 ] ASF GitHub Bot commented on FLINK-10380: satybald commented on issue #6724: [FLINK-10380] Add

[GitHub] satybald commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method

2018-09-20 Thread GitBox
satybald commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method URL: https://github.com/apache/flink/pull/6724#issuecomment-423304496 @StephanEwen I'm quite new to flink, why would be fine to have precondition check in the same class? Arent' those operators

[jira] [Commented] (FLINK-10311) HA end-to-end/Jepsen tests for standby Dispatchers

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622538#comment-16622538 ] ASF GitHub Bot commented on FLINK-10311: GJL commented on a change in pull request #6712:

[GitHub] GJL commented on a change in pull request #6712: [FLINK-10311][tests] HA end-to-end/Jepsen tests for standby Dispatchers

2018-09-20 Thread GitBox
GJL commented on a change in pull request #6712: [FLINK-10311][tests] HA end-to-end/Jepsen tests for standby Dispatchers URL: https://github.com/apache/flink/pull/6712#discussion_r219282159 ## File path: flink-jepsen/scripts/run-tests.sh ## @@ -36,8 +36,15 @@ do lein

[jira] [Commented] (FLINK-10311) HA end-to-end/Jepsen tests for standby Dispatchers

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622537#comment-16622537 ] ASF GitHub Bot commented on FLINK-10311: GJL commented on a change in pull request #6712:

[GitHub] GJL commented on a change in pull request #6712: [FLINK-10311][tests] HA end-to-end/Jepsen tests for standby Dispatchers

2018-09-20 Thread GitBox
GJL commented on a change in pull request #6712: [FLINK-10311][tests] HA end-to-end/Jepsen tests for standby Dispatchers URL: https://github.com/apache/flink/pull/6712#discussion_r219282159 ## File path: flink-jepsen/scripts/run-tests.sh ## @@ -36,8 +36,15 @@ do lein

[jira] [Commented] (FLINK-10184) HA Failover broken due to JobGraphs not being removed from Zookeeper on cancel

2018-09-20 Thread William Cummings (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622536#comment-16622536 ] William Cummings commented on FLINK-10184: -- >[~Jamalarm] [~wcummings] did you find time to test

[GitHub] asfgit closed pull request #6706: [hotfix][doc] Fix curl example in upload jar example

2018-09-20 Thread GitBox
asfgit closed pull request #6706: [hotfix][doc] Fix curl example in upload jar example URL: https://github.com/apache/flink/pull/6706 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (FLINK-10383) Hadoop configurations on the classpath seep into the S3 file system configs

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622488#comment-16622488 ] ASF GitHub Bot commented on FLINK-10383: StephanEwen opened a new pull request #6728:

[jira] [Updated] (FLINK-10383) Hadoop configurations on the classpath seep into the S3 file system configs

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10383: --- Labels: pull-request-available (was: ) > Hadoop configurations on the classpath seep into

[GitHub] StephanEwen opened a new pull request #6728: [FLINK-10383] [s3] (release-1.6) Prevent Hadoop configs on classpath to interfere with S3 configuration

2018-09-20 Thread GitBox
StephanEwen opened a new pull request #6728: [FLINK-10383] [s3] (release-1.6) Prevent Hadoop configs on classpath to interfere with S3 configuration URL: https://github.com/apache/flink/pull/6728 ## What is the purpose of the change The S3 connectors are based on a self-contained

[jira] [Commented] (FLINK-10377) Remove precondition in TwoPhaseCommitSinkFunction.notifyCheckpointComplete

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622448#comment-16622448 ] ASF GitHub Bot commented on FLINK-10377: StefanRRichter commented on a change in pull request

[GitHub] StefanRRichter commented on a change in pull request #6723: [FLINK-10377] Remove precondition in TwoPhaseCommitSinkFunction.notif…

2018-09-20 Thread GitBox
StefanRRichter commented on a change in pull request #6723: [FLINK-10377] Remove precondition in TwoPhaseCommitSinkFunction.notif… URL: https://github.com/apache/flink/pull/6723#discussion_r219264649 ## File path:

[jira] [Commented] (FLINK-10377) Remove precondition in TwoPhaseCommitSinkFunction.notifyCheckpointComplete

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622442#comment-16622442 ] ASF GitHub Bot commented on FLINK-10377: StefanRRichter commented on a change in pull request

[jira] [Commented] (FLINK-10377) Remove precondition in TwoPhaseCommitSinkFunction.notifyCheckpointComplete

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622440#comment-16622440 ] ASF GitHub Bot commented on FLINK-10377: StefanRRichter commented on a change in pull request

[GitHub] StefanRRichter commented on a change in pull request #6723: [FLINK-10377] Remove precondition in TwoPhaseCommitSinkFunction.notif…

2018-09-20 Thread GitBox
StefanRRichter commented on a change in pull request #6723: [FLINK-10377] Remove precondition in TwoPhaseCommitSinkFunction.notif… URL: https://github.com/apache/flink/pull/6723#discussion_r219263435 ## File path:

[GitHub] StefanRRichter commented on a change in pull request #6723: [FLINK-10377] Remove precondition in TwoPhaseCommitSinkFunction.notif…

2018-09-20 Thread GitBox
StefanRRichter commented on a change in pull request #6723: [FLINK-10377] Remove precondition in TwoPhaseCommitSinkFunction.notif… URL: https://github.com/apache/flink/pull/6723#discussion_r219263435 ## File path:

[jira] [Created] (FLINK-10383) Hadoop configurations on the classpath seep into the S3 file system configs

2018-09-20 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-10383: Summary: Hadoop configurations on the classpath seep into the S3 file system configs Key: FLINK-10383 URL: https://issues.apache.org/jira/browse/FLINK-10383 Project:

[jira] [Commented] (FLINK-10380) Check if key is not nul before assign to group in KeyedStream

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622395#comment-16622395 ] ASF GitHub Bot commented on FLINK-10380: StephanEwen commented on issue #6724: [FLINK-10380] Add

[GitHub] StephanEwen commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method

2018-09-20 Thread GitBox
StephanEwen commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method URL: https://github.com/apache/flink/pull/6724#issuecomment-423270421 This is on the performance critical path. Can we solve this another way that does not involve additional branches?

[jira] [Commented] (FLINK-10205) Batch Job: InputSplit Fault tolerant for DataSourceTask

2018-09-20 Thread JIN SUN (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622387#comment-16622387 ] JIN SUN commented on FLINK-10205: - Hi Stephan, I have the FLIP, and the pull request ready for this

[jira] [Commented] (FLINK-10377) Remove precondition in TwoPhaseCommitSinkFunction.notifyCheckpointComplete

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622362#comment-16622362 ] ASF GitHub Bot commented on FLINK-10377: pnowojski commented on a change in pull request #6723:

[GitHub] pnowojski commented on a change in pull request #6723: [FLINK-10377] Remove precondition in TwoPhaseCommitSinkFunction.notif…

2018-09-20 Thread GitBox
pnowojski commented on a change in pull request #6723: [FLINK-10377] Remove precondition in TwoPhaseCommitSinkFunction.notif… URL: https://github.com/apache/flink/pull/6723#discussion_r219247717 ## File path:

[jira] [Commented] (FLINK-10135) The JobManager doesn't report the cluster-level metrics

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622330#comment-16622330 ] ASF GitHub Bot commented on FLINK-10135: yanghua commented on issue #6702: [FLINK-10135] The

[GitHub] yanghua commented on issue #6702: [FLINK-10135] The JobManager does not report the cluster-level metrics

2018-09-20 Thread GitBox
yanghua commented on issue #6702: [FLINK-10135] The JobManager does not report the cluster-level metrics URL: https://github.com/apache/flink/pull/6702#issuecomment-423254893 @StefanRRichter I have tried to add a test case for reporting job manager metrics, can you review this?

[jira] [Comment Edited] (FLINK-7795) Utilize error-prone to discover common coding mistakes

2018-09-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345955#comment-16345955 ] Ted Yu edited comment on FLINK-7795 at 9/20/18 4:30 PM: error-prone has JDK 8

[jira] [Comment Edited] (FLINK-6105) Properly handle InterruptedException in HadoopInputFormatBase

2018-09-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307281#comment-16307281 ] Ted Yu edited comment on FLINK-6105 at 9/20/18 4:29 PM: In

[jira] [Commented] (FLINK-10378) Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622303#comment-16622303 ] ASF GitHub Bot commented on FLINK-10378: TisonKun commented on issue #6722: [FLINK-10378]

[GitHub] TisonKun commented on issue #6722: [FLINK-10378] [github] Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE

2018-09-20 Thread GitBox
TisonKun commented on issue #6722: [FLINK-10378] [github] Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE URL: https://github.com/apache/flink/pull/6722#issuecomment-423248081 @StephanEwen sure This is an

[jira] [Commented] (FLINK-9713) Support versioned joins in planning phase

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622300#comment-16622300 ] ASF GitHub Bot commented on FLINK-9713: --- pnowojski commented on issue #6299:

[jira] [Commented] (FLINK-9891) Flink cluster is not shutdown in YARN mode when Flink client is stopped

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622298#comment-16622298 ] ASF GitHub Bot commented on FLINK-9891: --- GJL commented on a change in pull request #6718:

[jira] [Commented] (FLINK-9891) Flink cluster is not shutdown in YARN mode when Flink client is stopped

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622296#comment-16622296 ] ASF GitHub Bot commented on FLINK-9891: --- GJL commented on a change in pull request #6718:

[jira] [Commented] (FLINK-10378) Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622295#comment-16622295 ] ASF GitHub Bot commented on FLINK-10378: StephanEwen commented on issue #6722: [FLINK-10378]

[jira] [Commented] (FLINK-9891) Flink cluster is not shutdown in YARN mode when Flink client is stopped

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622299#comment-16622299 ] ASF GitHub Bot commented on FLINK-9891: --- GJL commented on a change in pull request #6718:

[jira] [Commented] (FLINK-9891) Flink cluster is not shutdown in YARN mode when Flink client is stopped

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622297#comment-16622297 ] ASF GitHub Bot commented on FLINK-9891: --- GJL commented on a change in pull request #6718:

[GitHub] GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook to shutdown cluster if a session was created in per-job mode in attached mode

2018-09-20 Thread GitBox
GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook to shutdown cluster if a session was created in per-job mode in attached mode URL: https://github.com/apache/flink/pull/6718#discussion_r219226146 ## File path:

[GitHub] pnowojski commented on issue #6299: [FLINK-9713][table][sql] Support processing time versioned joins

2018-09-20 Thread GitBox
pnowojski commented on issue #6299: [FLINK-9713][table][sql] Support processing time versioned joins URL: https://github.com/apache/flink/pull/6299#issuecomment-423247190 Yes, you were right `TemporalTableReference` was not needed after cleaning up `.rowtime` usages. Applied changes,

[GitHub] GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook to shutdown cluster if a session was created in per-job mode in attached mode

2018-09-20 Thread GitBox
GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook to shutdown cluster if a session was created in per-job mode in attached mode URL: https://github.com/apache/flink/pull/6718#discussion_r219225730 ## File path:

[GitHub] GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook to shutdown cluster if a session was created in per-job mode in attached mode

2018-09-20 Thread GitBox
GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook to shutdown cluster if a session was created in per-job mode in attached mode URL: https://github.com/apache/flink/pull/6718#discussion_r219231030 ## File path: docs/ops/cli.md ## @@ -265,6

[GitHub] GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook to shutdown cluster if a session was created in per-job mode in attached mode

2018-09-20 Thread GitBox
GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook to shutdown cluster if a session was created in per-job mode in attached mode URL: https://github.com/apache/flink/pull/6718#discussion_r219226199 ## File path:

[GitHub] StephanEwen commented on issue #6722: [FLINK-10378] [github] Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE

2018-09-20 Thread GitBox
StephanEwen commented on issue #6722: [FLINK-10378] [github] Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE URL: https://github.com/apache/flink/pull/6722#issuecomment-423247012 Putting a comment across the contents is fine. Can you put the other changes into a

[jira] [Commented] (FLINK-10371) Allow to enable SSL mutual authentication on REST endpoints by configuration

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622292#comment-16622292 ] ASF GitHub Bot commented on FLINK-10371: kleingeist opened a new pull request #6727:

[jira] [Updated] (FLINK-10371) Allow to enable SSL mutual authentication on REST endpoints by configuration

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10371: --- Labels: pull-request-available (was: ) > Allow to enable SSL mutual authentication on REST

[GitHub] kleingeist opened a new pull request #6727: [FLINK-10371] Allow to enable SSL mutual authentication on REST endpoints by configuration

2018-09-20 Thread GitBox
kleingeist opened a new pull request #6727: [FLINK-10371] Allow to enable SSL mutual authentication on REST endpoints by configuration URL: https://github.com/apache/flink/pull/6727 # [[FLINK-10371]: Allow to enable SSL mutual authentication on REST endpoints by

[jira] [Commented] (FLINK-9168) Pulsar Sink Connector

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622290#comment-16622290 ] ASF GitHub Bot commented on FLINK-9168: --- chrismiller commented on a change in pull request #5845:

[GitHub] chrismiller commented on a change in pull request #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector

2018-09-20 Thread GitBox
chrismiller commented on a change in pull request #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector URL: https://github.com/apache/flink/pull/5845#discussion_r219230230 ## File path:

[jira] [Updated] (FLINK-9168) Pulsar Sink Connector

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9168: -- Labels: pull-request-available (was: ) > Pulsar Sink Connector > - > >

[jira] [Commented] (FLINK-9168) Pulsar Sink Connector

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622286#comment-16622286 ] ASF GitHub Bot commented on FLINK-9168: --- chrismiller commented on a change in pull request #5845:

[jira] [Commented] (FLINK-10363) S3 FileSystem factory prints secrets into logs

2018-09-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622284#comment-16622284 ] Stephan Ewen commented on FLINK-10363: -- There was some generic config value printing in 1.6.0 on

[GitHub] chrismiller commented on a change in pull request #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector

2018-09-20 Thread GitBox
chrismiller commented on a change in pull request #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector URL: https://github.com/apache/flink/pull/5845#discussion_r219230230 ## File path:

[jira] [Updated] (FLINK-10263) User-defined function with LITERAL paramters yields CompileException

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10263: --- Labels: pull-request-available (was: ) > User-defined function with LITERAL paramters

[jira] [Commented] (FLINK-10263) User-defined function with LITERAL paramters yields CompileException

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622274#comment-16622274 ] ASF GitHub Bot commented on FLINK-10263: twalthr opened a new pull request #6725: [FLINK-10263]

[jira] [Commented] (FLINK-9061) add entropy to s3 path for better scalability

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622275#comment-16622275 ] ASF GitHub Bot commented on FLINK-9061: --- StephanEwen opened a new pull request #6726: [FLINK-9061]

[GitHub] StephanEwen opened a new pull request #6726: [FLINK-9061] [s3] Add entropy injection to S3 file systems for checkpoints

2018-09-20 Thread GitBox
StephanEwen opened a new pull request #6726: [FLINK-9061] [s3] Add entropy injection to S3 file systems for checkpoints URL: https://github.com/apache/flink/pull/6726 ## What is the purpose of the change This pull request adds hooks to optionally inject entropy to the checkpoint

[GitHub] twalthr opened a new pull request #6725: [FLINK-10263] [sql-client] Fix classloader issues in SQL Client

2018-09-20 Thread GitBox
twalthr opened a new pull request #6725: [FLINK-10263] [sql-client] Fix classloader issues in SQL Client URL: https://github.com/apache/flink/pull/6725 ## What is the purpose of the change Fixes classloading issues when using a UDF with constant parameters. Every optimization

[jira] [Commented] (FLINK-10363) S3 FileSystem factory prints secrets into logs

2018-09-20 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622263#comment-16622263 ] Steve Loughran commented on FLINK-10363: Stephan: we went to a lot of effort to not log AWS

[jira] [Commented] (FLINK-10382) Writer has already been opened while using AvroKeyValueSinkWriter and BucketingSink

2018-09-20 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622246#comment-16622246 ] Stefan Richter commented on FLINK-10382: Thanks for reporting this. [~aljoscha] was this

[jira] [Commented] (FLINK-10157) Allow `null` user values in map state with TTL

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622237#comment-16622237 ] ASF GitHub Bot commented on FLINK-10157: StefanRRichter commented on a change in pull request

[jira] [Created] (FLINK-10382) Writer has already been opened while using AvroKeyValueSinkWriter and BucketingSink

2018-09-20 Thread Chengzhi Zhao (JIRA)
Chengzhi Zhao created FLINK-10382: - Summary: Writer has already been opened while using AvroKeyValueSinkWriter and BucketingSink Key: FLINK-10382 URL: https://issues.apache.org/jira/browse/FLINK-10382

[GitHub] StefanRRichter commented on a change in pull request #6707: [FLINK-10157] [State TTL] Allow `null` user values in map state with TTL

2018-09-20 Thread GitBox
StefanRRichter commented on a change in pull request #6707: [FLINK-10157] [State TTL] Allow `null` user values in map state with TTL URL: https://github.com/apache/flink/pull/6707#discussion_r219214268 ## File path:

[jira] [Commented] (FLINK-10292) Generate JobGraph in StandaloneJobClusterEntrypoint only once

2018-09-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622235#comment-16622235 ] Till Rohrmann commented on FLINK-10292: --- Yes this could be a way to go. This however means that we

[jira] [Commented] (FLINK-10157) Allow `null` user values in map state with TTL

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1669#comment-1669 ] ASF GitHub Bot commented on FLINK-10157: StefanRRichter commented on a change in pull request

[GitHub] StefanRRichter commented on a change in pull request #6707: [FLINK-10157] [State TTL] Allow `null` user values in map state with TTL

2018-09-20 Thread GitBox
StefanRRichter commented on a change in pull request #6707: [FLINK-10157] [State TTL] Allow `null` user values in map state with TTL URL: https://github.com/apache/flink/pull/6707#discussion_r219214268 ## File path:

[jira] [Commented] (FLINK-10157) Allow `null` user values in map state with TTL

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1666#comment-1666 ] ASF GitHub Bot commented on FLINK-10157: StefanRRichter commented on a change in pull request

[jira] [Commented] (FLINK-9713) Support versioned joins in planning phase

2018-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1664#comment-1664 ] ASF GitHub Bot commented on FLINK-9713: --- pnowojski commented on a change in pull request #6299:

  1   2   3   >