Re: [PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-13 Thread via GitHub
hackergin commented on code in PR #24290: URL: https://github.com/apache/flink/pull/24290#discussion_r1488851119 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/harness/GroupAggregateHarnessTest.scala: ## @@ -220,6 +225,63 @@ class

Re: [PR] [FLINK-34427][runtime] Adds state check to requirementsCheck logic [flink]

2024-02-13 Thread via GitHub
zentol commented on code in PR #24309: URL: https://github.com/apache/flink/pull/24309#discussion_r1488733497 ## flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/ManuallyTriggeredScheduledExecutorService.java: ## @@ -318,11 +319,22 @@

Re: [PR] [FLINK-34427][runtime] Adds state check to requirementsCheck logic [flink]

2024-02-13 Thread via GitHub
zentol commented on code in PR #24309: URL: https://github.com/apache/flink/pull/24309#discussion_r1488733497 ## flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/ManuallyTriggeredScheduledExecutorService.java: ## @@ -318,11 +319,22 @@

Re: [PR] [FLINK-34427][runtime] Adds state check to requirementsCheck logic [flink]

2024-02-13 Thread via GitHub
zentol commented on code in PR #24309: URL: https://github.com/apache/flink/pull/24309#discussion_r1488731829 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java: ## @@ -594,18 +597,19 @@ private void

Re: [PR] [FLINK-34386][state] Add RocksDB bloom filter metrics [flink]

2024-02-13 Thread via GitHub
hejufang commented on PR #24274: URL: https://github.com/apache/flink/pull/24274#issuecomment-1942857042 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2024-02-13 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817136#comment-17817136 ] Mason Chen commented on FLINK-33545: Hi [~aeolus811tw], have you had time to review the followup

[jira] [Commented] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-13 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817115#comment-17817115 ] Sai Sharath Dandi commented on FLINK-34403: --- Sorry, I couldn't get back here in time. Thanks

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1488432583 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusTimeSeries.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1488419176 ## prometheus-connector/src/test/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializerTest.java: ## @@ -0,0 +1,108 @@ +/* + *

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1488419176 ## prometheus-connector/src/test/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializerTest.java: ## @@ -0,0 +1,108 @@ +/* + *

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-13 Thread via GitHub
hanyuzheng7 commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1488414914 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/InputTypeStrategiesTest.java: ## @@ -640,6 +640,28 @@ ANY,

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-13 Thread via GitHub
hanyuzheng7 commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1488411926 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY,

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1488409080 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/RequestEntrySizeUtils.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the

[jira] [Updated] (FLINK-34442) Support optimizations for pre-partitioned [external] data sources

2024-02-13 Thread Jeyhun Karimov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeyhun Karimov updated FLINK-34442: --- Description: There are some use-cases in which data sources are pre-partitioned: - Kafka

[jira] [Created] (FLINK-34442) Support optimizations for pre-partitioned [external] data sources

2024-02-13 Thread Jeyhun Karimov (Jira)
Jeyhun Karimov created FLINK-34442: -- Summary: Support optimizations for pre-partitioned [external] data sources Key: FLINK-34442 URL: https://issues.apache.org/jira/browse/FLINK-34442 Project: Flink

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1488374236 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusTimeSeries.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1488349352 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusTimeSeries.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the

Re: [PR] [FLINK-34441] Add guide to submit flink SQL scripts via the operator (using flink-sql-runner-example) [flink-kubernetes-operator]

2024-02-13 Thread via GitHub
prakash-42 commented on PR #776: URL: https://github.com/apache/flink-kubernetes-operator/pull/776#issuecomment-1942031569 @mxm Here is a PR for the discussion we were having at PR #596 . Please let me know if any updates/improvements are needed. Thank you! -- This is an automated

[jira] [Updated] (FLINK-34441) Add Documentation for flink-sql-runner-example in Kubernetes Operator Documentation

2024-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34441: --- Labels: pull-request-available (was: ) > Add Documentation for flink-sql-runner-example in

[PR] [FLINK-34441] Add guide to submit flink SQL scripts via the operator (using flink-sql-runner-example) [flink-kubernetes-operator]

2024-02-13 Thread via GitHub
prakash-42 opened a new pull request, #776: URL: https://github.com/apache/flink-kubernetes-operator/pull/776 ## What is the purpose of the change This pull request adds documentation about flink-sql-runner-example in the Kubernetes operator documentation page. Majority of

[jira] [Commented] (FLINK-34424) BoundedBlockingSubpartitionWriteReadTest#testRead10ConsumersConcurrent times out

2024-02-13 Thread Piotr Nowicki (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817083#comment-17817083 ] Piotr Nowicki commented on FLINK-34424: --- Yes, we did! A week ago was an anniversary of the last

[jira] [Commented] (FLINK-34424) BoundedBlockingSubpartitionWriteReadTest#testRead10ConsumersConcurrent times out

2024-02-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817082#comment-17817082 ] Matthias Pohl commented on FLINK-34424: --- args. Didn't we have this in the past? Sorry again - the

[jira] [Updated] (FLINK-34439) Move chown operations to COPY commands in Dockerfile

2024-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34439: --- Labels: pull-request-available (was: ) > Move chown operations to COPY commands in

[PR] [FLINK-34439] Move chown operations to COPY commands in Dockerfile [flink-kubernetes-operator]

2024-02-13 Thread via GitHub
mateczagany opened a new pull request, #775: URL: https://github.com/apache/flink-kubernetes-operator/pull/775 ## What is the purpose of the change Removed unnecessary `RUN chown ...` commands from Dockerfile to reduce output size image. With this change, the size of the image has

[jira] [Comment Edited] (FLINK-34440) Support Debezium Protobuf Confluent Format

2024-02-13 Thread Kevin Lam (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817076#comment-17817076 ] Kevin Lam edited comment on FLINK-34440 at 2/13/24 5:00 PM: Hello! I just

[jira] [Created] (FLINK-34441) Add Documentation for flink-sql-runner-example in Kubernetes Operator Documentation

2024-02-13 Thread Prakash Tiwari (Jira)
Prakash Tiwari created FLINK-34441: -- Summary: Add Documentation for flink-sql-runner-example in Kubernetes Operator Documentation Key: FLINK-34441 URL: https://issues.apache.org/jira/browse/FLINK-34441

[jira] [Commented] (FLINK-34440) Support Debezium Protobuf Confluent Format

2024-02-13 Thread Kevin Lam (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817076#comment-17817076 ] Kevin Lam commented on FLINK-34440: --- I just added this Jira issue, following the [Contribution

[jira] [Created] (FLINK-34440) Support Debezium Protobuf Confluent Format

2024-02-13 Thread Kevin Lam (Jira)
Kevin Lam created FLINK-34440: - Summary: Support Debezium Protobuf Confluent Format Key: FLINK-34440 URL: https://issues.apache.org/jira/browse/FLINK-34440 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-34424) BoundedBlockingSubpartitionWriteReadTest#testRead10ConsumersConcurrent times out

2024-02-13 Thread Piotr Nowicki (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817073#comment-17817073 ] Piotr Nowicki commented on FLINK-34424: --- [~mapohl] I guess you wanted to mention [~pnowojski] ? :)

[jira] [Commented] (FLINK-34424) BoundedBlockingSubpartitionWriteReadTest#testRead10ConsumersConcurrent times out

2024-02-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817069#comment-17817069 ] Matthias Pohl commented on FLINK-34424: --- [~piotr.nowicki] (because it's networking; feel free to

[jira] [Commented] (FLINK-34424) BoundedBlockingSubpartitionWriteReadTest#testRead10ConsumersConcurrent times out

2024-02-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817063#comment-17817063 ] Matthias Pohl commented on FLINK-34424: --- I'm wondering whether that has anything to do with the

[jira] [Updated] (FLINK-34333) Fix FLINK-34007 LeaderElector bug in 1.18

2024-02-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34333: -- Release Note: Fixes a bug where the leader election wasn't able to pick up leadership again

[jira] [Resolved] (FLINK-34333) Fix FLINK-34007 LeaderElector bug in 1.18

2024-02-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-34333. --- Fix Version/s: 1.18.2 Resolution: Fixed * 1.18 **

Re: [PR] [FLINK-34333][k8s] 1.18 backport of FLINK-34007 [flink]

2024-02-13 Thread via GitHub
XComp merged PR #24245: URL: https://github.com/apache/flink/pull/24245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-31238] Use IngestDB to speed up Rocksdb rescaling recovery (rebased) [flink]

2024-02-13 Thread via GitHub
StefanRRichter merged PR #24031: URL: https://github.com/apache/flink/pull/24031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-13 Thread via GitHub
gyfora commented on PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#issuecomment-194188 There are still some issues while actually running this so I need to track down some problems and add some new tests. -- This is an automated message from the Apache

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-13 Thread via GitHub
mxm commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1488088408 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -264,16 +299,14 @@ private void computeTargetDataRate(

Re: [PR] [FLINK-34437][SQL Client] Fix typo [flink]

2024-02-13 Thread via GitHub
flinkbot commented on PR #24310: URL: https://github.com/apache/flink/pull/24310#issuecomment-1941853000 ## CI report: * 2dbe5769fbe2b7dfec652d1360136901ae227b80 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34437) Typo in SQL Client - `s/succeed/succeeded`

2024-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34437: --- Labels: pull-request-available (was: ) > Typo in SQL Client - `s/succeed/succeeded` >

[PR] [FLINK-34437][SQL Client] Fix typo [flink]

2024-02-13 Thread via GitHub
rmoff opened a new pull request, #24310: URL: https://github.com/apache/flink/pull/24310 ## What is the purpose of the change The SQL Client issues a message when a statement successfully executes. For example: ```sql Flink SQL> CREATE CATALOG c_new WITH

[jira] [Assigned] (FLINK-34439) Move chown operations to COPY commands in Dockerfile

2024-02-13 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-34439: -- Assignee: Mate Czagany > Move chown operations to COPY commands in Dockerfile >

[jira] [Created] (FLINK-34439) Move chown operations to COPY commands in Dockerfile

2024-02-13 Thread Mate Czagany (Jira)
Mate Czagany created FLINK-34439: Summary: Move chown operations to COPY commands in Dockerfile Key: FLINK-34439 URL: https://issues.apache.org/jira/browse/FLINK-34439 Project: Flink Issue

[jira] [Assigned] (FLINK-34438) Kubernetes Operator doesn't wait for TaskManager deletion in native mode

2024-02-13 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-34438: -- Assignee: Mate Czagany > Kubernetes Operator doesn't wait for TaskManager deletion in native

Re: [PR] [FLINK-34427][runtime] Adds state check to requirementsCheck logic [flink]

2024-02-13 Thread via GitHub
flinkbot commented on PR #24309: URL: https://github.com/apache/flink/pull/24309#issuecomment-1941800355 ## CI report: * 755cc0abbf3de6c5d6debc20e8a85e1f7fa220f8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34427) FineGrainedSlotManagerTest fails fatally (exit code 239)

2024-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34427: --- Labels: pull-request-available test-stability (was: test-stability) >

[PR] [FLINK-34427][runtime] Adds state check to requirementsCheck logic [flink]

2024-02-13 Thread via GitHub
XComp opened a new pull request, #24309: URL: https://github.com/apache/flink/pull/24309 ## What is the purpose of the change Quoting @zentol from

[jira] [Created] (FLINK-34438) Kubernetes Operator doesn't wait for TaskManager deletion in native mode

2024-02-13 Thread Mate Czagany (Jira)
Mate Czagany created FLINK-34438: Summary: Kubernetes Operator doesn't wait for TaskManager deletion in native mode Key: FLINK-34438 URL: https://issues.apache.org/jira/browse/FLINK-34438 Project:

[jira] [Updated] (FLINK-34437) Typo in SQL Client - `s/succeed/succeeded`

2024-02-13 Thread Robin Moffatt (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Moffatt updated FLINK-34437: -- Description:   {code:java} Flink SQL> CREATE CATALOG c_new WITH ('type'='generic_in_memory');

[jira] [Created] (FLINK-34437) Typo in SQL Client - `s/succeed/succeeded`

2024-02-13 Thread Robin Moffatt (Jira)
Robin Moffatt created FLINK-34437: - Summary: Typo in SQL Client - `s/succeed/succeeded` Key: FLINK-34437 URL: https://issues.apache.org/jira/browse/FLINK-34437 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-34436) Avro schema evolution and compatibility issues in Pulsar connector

2024-02-13 Thread Jacek Wislicki (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Wislicki updated FLINK-34436: --- Summary: Avro schema evolution and compatibility issues in Pulsar connector (was: Avro

[jira] [Created] (FLINK-34436) Avro schema evolution and compatibility issues

2024-02-13 Thread Jacek Wislicki (Jira)
Jacek Wislicki created FLINK-34436: -- Summary: Avro schema evolution and compatibility issues Key: FLINK-34436 URL: https://issues.apache.org/jira/browse/FLINK-34436 Project: Flink Issue

Re: [PR] Bump org.yaml:snakeyaml from 1.31 to 2.0 in /flink-connector-kafka [flink-connector-kafka]

2024-02-13 Thread via GitHub
MartijnVisser commented on PR #85: URL: https://github.com/apache/flink-connector-kafka/pull/85#issuecomment-1941623489 Re-opening because https://bitbucket.org/snakeyaml/snakeyaml/wiki/Changes indicates that SnakeYAML should still run on Java8 (but requires Java 11 to build) -- This

[jira] [Created] (FLINK-34435) Bump org.yaml:snakeyaml from 1.31 to 2.2 for flink-connector-elasticsearch

2024-02-13 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-34435: -- Summary: Bump org.yaml:snakeyaml from 1.31 to 2.2 for flink-connector-elasticsearch Key: FLINK-34435 URL: https://issues.apache.org/jira/browse/FLINK-34435

Re: [PR] Bump org.yaml:snakeyaml from 1.31 to 2.0 [flink-connector-elasticsearch]

2024-02-13 Thread via GitHub
MartijnVisser commented on PR #90: URL: https://github.com/apache/flink-connector-elasticsearch/pull/90#issuecomment-1941612550 > where did you get this info? Hmmm I would have sworn that was the case, but apparently I was wrong because

Re: [PR] fix: flink account cannot get resource "services" in API group [flink-kubernetes-operator]

2024-02-13 Thread via GitHub
mxm commented on PR #596: URL: https://github.com/apache/flink-kubernetes-operator/pull/596#issuecomment-1941597015 Great! The request is approved  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Comment Edited] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2024-02-13 Thread Nathan Taylor Armstrong Lewis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817008#comment-17817008 ] Nathan Taylor Armstrong Lewis edited comment on FLINK-33817 at 2/13/24 1:56 PM:

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1487904426 ## example-datastream-job/src/main/java/org/apache/flink/connector/prometheus/examples/DataStreamJob.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2024-02-13 Thread Nathan Taylor Armstrong Lewis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817008#comment-17817008 ] Nathan Taylor Armstrong Lewis commented on FLINK-33817: --- I can confirm that this

Re: [PR] Chore: Change metric types, "numSplitsProcessed" in metrics.md [flink]

2024-02-13 Thread via GitHub
flinkbot commented on PR #24308: URL: https://github.com/apache/flink/pull/24308#issuecomment-1941566002 ## CI report: * a1d3ee92d6f82db8f91a767b7c262bed553988e2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] Chore: Change metric types, "numSplitsProcessed" in metrics.md [flink]

2024-02-13 Thread via GitHub
WarbriT opened a new pull request, #24308: URL: https://github.com/apache/flink/pull/24308 ## What is the purpose of the change Typo in metics.md. Modify "numSplitsProcessed" metric type from Gauge to Counter in both english and chinese version. -- This is an automated

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1487883477 ## example-datastream-job/src/main/java/org/apache/flink/connector/prometheus/examples/DataStreamJob.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the

Re: [PR] fix: flink account cannot get resource "services" in API group [flink-kubernetes-operator]

2024-02-13 Thread via GitHub
prakash-42 commented on PR #596: URL: https://github.com/apache/flink-kubernetes-operator/pull/596#issuecomment-1941522672 Hi @mxm ! I have submitted the request for account with username `prakash.tiwari` -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-34386][state] Add RocksDB bloom filter metrics [flink]

2024-02-13 Thread via GitHub
hejufang commented on PR #24274: URL: https://github.com/apache/flink/pull/24274#issuecomment-1941505603 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-29122][core] Improve robustness of FileUtils.expandDirectory() [flink]

2024-02-13 Thread via GitHub
flinkbot commented on PR #24307: URL: https://github.com/apache/flink/pull/24307#issuecomment-1941503032 ## CI report: * 0ab33ce4a51fbfefa0280f1123dee49d37275dcb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29122) Improve robustness of FileUtils.expandDirectory()

2024-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29122: --- Labels: pull-request-available (was: ) > Improve robustness of FileUtils.expandDirectory()

[PR] [FLINK-29122][core] Improve robustness of FileUtils.expandDirectory() [flink]

2024-02-13 Thread via GitHub
anupamaggarwal opened a new pull request, #24307: URL: https://github.com/apache/flink/pull/24307 ## What is the purpose of the change This pull request adds additional checks to improve robustness of FileUtils.expandDirectory() method. ## Brief change log -

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-13 Thread via GitHub
dawidwys commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1487826357 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/InputTypeStrategiesTest.java: ## @@ -640,6 +640,28 @@ ANY,

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-13 Thread via GitHub
dawidwys commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1487823032 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +231,22 @@ ANY,

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-13 Thread via GitHub
dawidwys commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1487819172 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY,

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-13 Thread via GitHub
dawidwys commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1487819172 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY,

[jira] [Updated] (FLINK-34266) Output ratios should be computed over the whole metric window instead of averaged

2024-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34266: --- Labels: pull-request-available (was: ) > Output ratios should be computed over the whole

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-13 Thread via GitHub
gyfora commented on PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#issuecomment-1941448169 cc @mateczagany -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-13 Thread via GitHub
gyfora opened a new pull request, #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774 ## What is the purpose of the change This PR aims to cover both [FLINK-34213](https://issues.apache.org/jira/browse/FLINK-34213) and

Re: [PR] [FLINK-34432] Re-enable forkReuse for flink-table-planner [flink]

2024-02-13 Thread via GitHub
MartijnVisser commented on PR #24305: URL: https://github.com/apache/flink/pull/24305#issuecomment-1941430726 Personal CI Run 3: https://dev.azure.com/martijn0323/Flink/_build/results?buildId=4198=results ⌛ CI Run 3:

[jira] [Assigned] (FLINK-34213) Consider using accumulated busy time instead of busyMsPerSecond

2024-02-13 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-34213: -- Assignee: Gyula Fora > Consider using accumulated busy time instead of busyMsPerSecond >

Re: [PR] fix: flink account cannot get resource "services" in API group [flink-kubernetes-operator]

2024-02-13 Thread via GitHub
mxm commented on PR #596: URL: https://github.com/apache/flink-kubernetes-operator/pull/596#issuecomment-1941400242 @prakash-42 You can request a JIRA account here: https://selfserve.apache.org/jira-account.html Let me know the username once you have requested an account, I can then

[jira] [Comment Edited] (FLINK-34364) Fix release utils mount point to match the release doc and scripts

2024-02-13 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816981#comment-17816981 ] Etienne Chauchot edited comment on FLINK-34364 at 2/13/24 12:21 PM:

[jira] [Commented] (FLINK-34364) Fix release utils mount point to match the release doc and scripts

2024-02-13 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816981#comment-17816981 ] Etienne Chauchot commented on FLINK-34364: -- Notably the source release script was excluding

[PR] [FLINK-34364] Replace incorrect release_utils mount point tools/release/shared by tools/releasing/shared to match the release doc and scripts [flink-connector-shared-utils]

2024-02-13 Thread via GitHub
echauchot opened a new pull request, #36: URL: https://github.com/apache/flink-connector-shared-utils/pull/36 I think I can self merge on that one. FYI: @zentol -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-34364) Fix release utils mount point to match the release doc and scripts

2024-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34364: --- Labels: pull-request-available (was: ) > Fix release utils mount point to match the

[jira] [Updated] (FLINK-34364) Fix release utils mount point to match the release doc and scripts

2024-02-13 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Etienne Chauchot updated FLINK-34364: - Description: parent_pom branch refers to an incorrect mount point

[jira] [Updated] (FLINK-34364) Fix release utils mount point to match the release doc and scripts

2024-02-13 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Etienne Chauchot updated FLINK-34364: - Description: parent_pom branch refers to an incorrect mount point

[jira] (FLINK-34364) Fix release utils mount point to match the release doc and scripts

2024-02-13 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34364 ] Etienne Chauchot deleted comment on FLINK-34364: -- was (Author: echauchot): parent_pom branch refers to an incorrect mount point tools/*release*/shared instead of

[jira] [Comment Edited] (FLINK-34364) Fix release utils mount point to match the release doc and scripts

2024-02-13 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816560#comment-17816560 ] Etienne Chauchot edited comment on FLINK-34364 at 2/13/24 12:11 PM:

[jira] [Assigned] (FLINK-34425) TaskManagerRunnerITCase#testNondeterministicWorkingDirIsDeletedInCaseOfProcessFailure times out

2024-02-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-34425: - Assignee: (was: Matthias Pohl) >

[jira] [Commented] (FLINK-34427) FineGrainedSlotManagerTest fails fatally (exit code 239)

2024-02-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816973#comment-17816973 ] Matthias Pohl commented on FLINK-34427: --- Thanks for the clarification. This is an issue that also

[jira] [Updated] (FLINK-34427) FineGrainedSlotManagerTest fails fatally (exit code 239)

2024-02-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34427: -- Affects Version/s: 1.18.1 > FineGrainedSlotManagerTest fails fatally (exit code 239) >

[jira] [Updated] (FLINK-34425) TaskManagerRunnerITCase#testNondeterministicWorkingDirIsDeletedInCaseOfProcessFailure times out

2024-02-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34425: -- Priority: Major (was: Critical) >

[jira] [Comment Edited] (FLINK-34425) TaskManagerRunnerITCase#testNondeterministicWorkingDirIsDeletedInCaseOfProcessFailure times out

2024-02-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816971#comment-17816971 ] Matthias Pohl edited comment on FLINK-34425 at 2/13/24 11:48 AM: - This

[jira] [Commented] (FLINK-34425) TaskManagerRunnerITCase#testNondeterministicWorkingDirIsDeletedInCaseOfProcessFailure times out

2024-02-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816971#comment-17816971 ] Matthias Pohl commented on FLINK-34425: --- This looks like a test issue. The TaskManager process is

[jira] [Commented] (FLINK-34427) FineGrainedSlotManagerTest fails fatally (exit code 239)

2024-02-13 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816969#comment-17816969 ] Chesnay Schepler commented on FLINK-34427: -- The problem is the use of scheduled executors in

[jira] [Updated] (FLINK-34000) Implement restore tests for IncrementalGroupAggregate node

2024-02-13 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-34000: - Fix Version/s: 1.20.0 (was: 1.19.0) > Implement restore tests

[jira] [Closed] (FLINK-34000) Implement restore tests for IncrementalGroupAggregate node

2024-02-13 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-34000. Resolution: Implemented > Implement restore tests for IncrementalGroupAggregate node >

[jira] [Commented] (FLINK-34000) Implement restore tests for IncrementalGroupAggregate node

2024-02-13 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816966#comment-17816966 ] Dawid Wysakowicz commented on FLINK-34000: -- Merged an improved version in

Re: [PR] [FLINK-34000] Implement restore tests for IncrementalGroupAgg node [flink]

2024-02-13 Thread via GitHub
dawidwys merged PR #24154: URL: https://github.com/apache/flink/pull/24154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-34427) FineGrainedSlotManagerTest fails fatally (exit code 239)

2024-02-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816963#comment-17816963 ] Matthias Pohl commented on FLINK-34427: --- [~chesnay] the upstream future {{requestFuture}} is

[jira] [Commented] (FLINK-34434) DefaultSlotStatusSyncer doesn't complete the returned future

2024-02-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816961#comment-17816961 ] Matthias Pohl commented on FLINK-34434: --- [~guoyangze] can you have a look at this? >

[jira] [Comment Edited] (FLINK-34434) DefaultSlotStatusSyncer doesn't complete the returned future

2024-02-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816961#comment-17816961 ] Matthias Pohl edited comment on FLINK-34434 at 2/13/24 11:11 AM: -

[jira] [Created] (FLINK-34434) DefaultSlotStatusSyncer doesn't complete the returned future

2024-02-13 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34434: - Summary: DefaultSlotStatusSyncer doesn't complete the returned future Key: FLINK-34434 URL: https://issues.apache.org/jira/browse/FLINK-34434 Project: Flink

[jira] [Updated] (FLINK-34427) ResourceManagerTaskExecutorTest fails fatally (exit code 239)

2024-02-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34427: -- Description:

  1   2   >