Re: [PR] [FLINK-35026][runtime][config] Introduce async execution configurations [flink]

2024-04-15 Thread via GitHub
yunfengzhou-hub commented on code in PR #24667: URL: https://github.com/apache/flink/pull/24667#discussion_r1566742123 ## flink-core/src/main/java/org/apache/flink/configuration/ExecutionOptions.java: ## @@ -181,4 +182,73 @@ public class ExecutionOptions {

Re: [PR] [FLINK-35026][runtime][config] Introduce async execution configurations [flink]

2024-04-15 Thread via GitHub
yunfengzhou-hub commented on code in PR #24667: URL: https://github.com/apache/flink/pull/24667#discussion_r1566744878 ## flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java: ## @@ -1085,6 +1085,54 @@ public void setUseSnapshotCompression(boolean

[jira] [Commented] (FLINK-35112) Membership for Row class does not include field names

2024-04-15 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837512#comment-17837512 ] Dian Fu commented on FLINK-35112: - Sounds reasonable for me. [~wzorgdrager] Do you want to submit a PR

[jira] [Updated] (FLINK-35028) Timer firing under async execution model

2024-04-15 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei updated FLINK-35028: --- Summary: Timer firing under async execution model (was: Processing timer firing under async

[jira] [Assigned] (FLINK-34127) Kafka connector repo runs a duplicate of `IntegrationTests` framework tests

2024-04-15 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen reassigned FLINK-34127: -- Assignee: Mason Chen > Kafka connector repo runs a duplicate of `IntegrationTests` framework

[jira] [Assigned] (FLINK-34320) Flink Kafka connector tests time out

2024-04-15 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen reassigned FLINK-34320: -- Assignee: (was: Mason Chen) > Flink Kafka connector tests time out >

[jira] [Assigned] (FLINK-34320) Flink Kafka connector tests time out

2024-04-15 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen reassigned FLINK-34320: -- Assignee: Mason Chen > Flink Kafka connector tests time out >

[jira] [Updated] (FLINK-35119) UPDATE DataChangeEvent deserialized data is incorrect

2024-04-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35119: --- Labels: pull-request-available (was: ) > UPDATE DataChangeEvent deserialized data is

[PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-15 Thread via GitHub
zhongqishang opened a new pull request, #3226: URL: https://github.com/apache/flink-cdc/pull/3226 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-35025][Runtime/State] Abstract stream operators for async state processing [flink]

2024-04-15 Thread via GitHub
Zakelly commented on code in PR #24657: URL: https://github.com/apache/flink/pull/24657#discussion_r1566670603 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordProcessorUtils.java: ## @@ -82,6 +87,10 @@ public static ThrowingConsumer,

[jira] [Created] (FLINK-35119) UPDATE DataChangeEvent deserialized data is incorrect

2024-04-15 Thread Qishang Zhong (Jira)
Qishang Zhong created FLINK-35119: - Summary: UPDATE DataChangeEvent deserialized data is incorrect Key: FLINK-35119 URL: https://issues.apache.org/jira/browse/FLINK-35119 Project: Flink

[jira] [Updated] (FLINK-35119) UPDATE DataChangeEvent deserialized data is incorrect

2024-04-15 Thread Qishang Zhong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qishang Zhong updated FLINK-35119: -- Description: When DebeziumChangelogMode is upsert, the before of DataChangeEvent is null,

Re: [PR] [FLINK-35026][runtime][config] Introduce async execution configurations [flink]

2024-04-15 Thread via GitHub
fredia commented on PR #24667: URL: https://github.com/apache/flink/pull/24667#issuecomment-2058174500 @Zakelly @ljz2051 would you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-35025][Runtime/State] Abstract stream operators for async state processing [flink]

2024-04-15 Thread via GitHub
fredia commented on code in PR #24657: URL: https://github.com/apache/flink/pull/24657#discussion_r155895 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordProcessorUtils.java: ## @@ -82,6 +87,10 @@ public static ThrowingConsumer,

Re: [PR] [FLINK-35025][Runtime/State] Abstract stream operators for async state processing [flink]

2024-04-15 Thread via GitHub
Zakelly commented on code in PR #24657: URL: https://github.com/apache/flink/pull/24657#discussion_r154885 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/multipleinput/input/FirstInputOfTwoInput.java: ## @@ -54,4 +57,17 @@ public

Re: [PR] [FLINK-35025][Runtime/State] Abstract stream operators for async state processing [flink]

2024-04-15 Thread via GitHub
Zakelly commented on code in PR #24657: URL: https://github.com/apache/flink/pull/24657#discussion_r153205 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java: ## @@ -0,0 +1,140 @@ +/* + *

Re: [PR] [FLINK-35025][Runtime/State] Abstract stream operators for async state processing [flink]

2024-04-15 Thread via GitHub
fredia commented on code in PR #24657: URL: https://github.com/apache/flink/pull/24657#discussion_r1566645709 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/multipleinput/input/FirstInputOfTwoInput.java: ## @@ -54,4 +57,17 @@ public

Re: [PR] [FLINK-34936][Checkpointing] Register reused shared state handle to FileMergingSnapshotManager [flink]

2024-04-15 Thread via GitHub
fredia commented on code in PR #24644: URL: https://github.com/apache/flink/pull/24644#discussion_r1566649212 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java: ## @@ -349,6

[jira] [Comment Edited] (FLINK-34508) Migrate S3-related ITCases and e2e tests to Minio

2024-04-15 Thread Muhammet Orazov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837486#comment-17837486 ] Muhammet Orazov edited comment on FLINK-34508 at 4/16/24 2:51 AM: -- Hey

[jira] [Comment Edited] (FLINK-34508) Migrate S3-related ITCases and e2e tests to Minio

2024-04-15 Thread Muhammet Orazov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837486#comment-17837486 ] Muhammet Orazov edited comment on FLINK-34508 at 4/16/24 2:49 AM: -- Hey

[jira] [Commented] (FLINK-34508) Migrate S3-related ITCases and e2e tests to Minio

2024-04-15 Thread Muhammet Orazov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837486#comment-17837486 ] Muhammet Orazov commented on FLINK-34508: - Hey all, I have add changes to remove the

[jira] [Created] (FLINK-35118) StreamingHiveSource cannot track tables that have more than 32,767 partitions

2024-04-15 Thread roland (Jira)
roland created FLINK-35118: -- Summary: StreamingHiveSource cannot track tables that have more than 32,767 partitions Key: FLINK-35118 URL: https://issues.apache.org/jira/browse/FLINK-35118 Project: Flink

[jira] [Commented] (FLINK-35111) Modify the spelling mistakes in the taskmanager html

2024-04-15 Thread JJJJude (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837485#comment-17837485 ] ude commented on FLINK-35111: - [~dannycranmer] Thank you for your reply, but I found that has been

Re: [PR] [FLINK-34936][Checkpointing] Register reused shared state handle to FileMergingSnapshotManager [flink]

2024-04-15 Thread via GitHub
Zakelly commented on PR #24644: URL: https://github.com/apache/flink/pull/24644#issuecomment-2058127691 > Thanks for this pr! Overall, LGTM. I have one question: > > If a subtask completes its checkpoint but the job's overall checkpoint fails, the FileMergingSnapshotManager will

Re: [PR] [FLINK-34936][Checkpointing] Register reused shared state handle to FileMergingSnapshotManager [flink]

2024-04-15 Thread via GitHub
Zakelly commented on code in PR #24644: URL: https://github.com/apache/flink/pull/24644#discussion_r1566633317 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java: ## @@ -349,6

Re: [PR] [FLINK-35045][state] Introduce ForStFlinkFileSystem to support reading and writing with ByteBuffer [flink]

2024-04-15 Thread via GitHub
masteryhx commented on code in PR #24632: URL: https://github.com/apache/flink/pull/24632#discussion_r1566625643 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ForStFlinkFileSystem.java: ## @@ -0,0 +1,153 @@ +/* + * Licensed to

[jira] [Created] (FLINK-35117) AsyncScalarFunction has a dependency issue.

2024-04-15 Thread roland (Jira)
roland created FLINK-35117: -- Summary: AsyncScalarFunction has a dependency issue. Key: FLINK-35117 URL: https://issues.apache.org/jira/browse/FLINK-35117 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-35046][state] Introduce AsyncKeyedStateBackend supporting to create StateExecutor [flink]

2024-04-15 Thread via GitHub
Zakelly commented on code in PR #24663: URL: https://github.com/apache/flink/pull/24663#discussion_r1566625619 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/AsyncKeyedStateBackend.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [hotfix][runtime]Fix the missing methed parameter annotation problem [flink]

2024-04-15 Thread via GitHub
reswqa merged PR #24666: URL: https://github.com/apache/flink/pull/24666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35079] Fallback to timestamp startup mode when resume token has expired [flink-cdc]

2024-04-15 Thread via GitHub
yuxiqian commented on code in PR #3221: URL: https://github.com/apache/flink-cdc/pull/3221#discussion_r1566596993 ##

Re: [PR] [FLINK-35079] Fallback to timestamp startup mode when resume token has expired [flink-cdc]

2024-04-15 Thread via GitHub
yuxiqian commented on code in PR #3221: URL: https://github.com/apache/flink-cdc/pull/3221#discussion_r1566596993 ##

[jira] [Commented] (FLINK-25537) [JUnit5 Migration] Module: flink-core

2024-04-15 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837471#comment-17837471 ] Jiabao Sun commented on FLINK-25537: master: 138f1f9d17b7a58b092ee7d9fc4c20d968a7b33b > [JUnit5

Re: [PR] [FLINK-25537][JUnit5 Migration] Module: flink-core with,Package: Configuration [flink]

2024-04-15 Thread via GitHub
Jiabao-Sun merged PR #24612: URL: https://github.com/apache/flink/pull/24612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-35116) Upgrade JOSDK dependency to 4.8.3

2024-04-15 Thread Jira
Márton Balassi created FLINK-35116: -- Summary: Upgrade JOSDK dependency to 4.8.3 Key: FLINK-35116 URL: https://issues.apache.org/jira/browse/FLINK-35116 Project: Flink Issue Type:

Re: [PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]

2024-04-15 Thread via GitHub
jeyhunkarimov commented on PR #24658: URL: https://github.com/apache/flink/pull/24658#issuecomment-2057338536 Ah no worries at all, there was a misunderstanding in communication. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-33506] Add support for jdk17 for AWS connectors [flink-connector-aws]

2024-04-15 Thread via GitHub
snuyanzin commented on code in PR #115: URL: https://github.com/apache/flink-connector-aws/pull/115#discussion_r1566124545 ## flink-connector-aws/flink-connector-dynamodb/pom.xml: ## @@ -34,6 +34,9 @@ under the License. jar + +

[jira] [Commented] (FLINK-32212) Job restarting indefinitely after an IllegalStateException from BlobLibraryCacheManager

2024-04-15 Thread Ricky Saltzer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837354#comment-17837354 ] Ricky Saltzer commented on FLINK-32212: --- Verified we started hitting this pretty consistently when

[jira] [Commented] (FLINK-35115) Kinesis connector writes wrong Kinesis sequence number at stop with savepoint

2024-04-15 Thread Aleksandr Pilipenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837327#comment-17837327 ] Aleksandr Pilipenko commented on FLINK-35115: - [~dannycranmer] Agree, trying to reproduce it

[jira] [Updated] (FLINK-35094) SinkTestSuiteBase.testScaleDown is hanging for 1.20-SNAPSHOT

2024-04-15 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-35094: Fix Version/s: opensearch-1.2.0 > SinkTestSuiteBase.testScaleDown is hanging for

[jira] [Commented] (FLINK-35094) SinkTestSuiteBase.testScaleDown is hanging for 1.20-SNAPSHOT

2024-04-15 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837324#comment-17837324 ] Sergey Nuyanzin commented on FLINK-35094: - Opensearch connector was fixed within

[jira] [Commented] (FLINK-35094) SinkTestSuiteBase.testScaleDown is hanging for 1.20-SNAPSHOT

2024-04-15 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837323#comment-17837323 ] Sergey Nuyanzin commented on FLINK-35094: - Merged as

[jira] [Assigned] (FLINK-35094) SinkTestSuiteBase.testScaleDown is hanging for 1.20-SNAPSHOT

2024-04-15 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-35094: --- Assignee: Sergey Nuyanzin > SinkTestSuiteBase.testScaleDown is hanging for

[jira] [Resolved] (FLINK-35094) SinkTestSuiteBase.testScaleDown is hanging for 1.20-SNAPSHOT

2024-04-15 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-35094. - Fix Version/s: elasticsearch-3.2.0 Resolution: Fixed >

Re: [PR] [FLINK-34961] Use dedicated CI name for Elasticsearch connector to differentiate it in infra-reports [flink-connector-elasticsearch]

2024-04-15 Thread via GitHub
snuyanzin commented on PR #97: URL: https://github.com/apache/flink-connector-elasticsearch/pull/97#issuecomment-2057107944 Thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-34961] Use dedicated CI name for Elasticsearch connector to differentiate it in infra-reports [flink-connector-elasticsearch]

2024-04-15 Thread via GitHub
snuyanzin merged PR #97: URL: https://github.com/apache/flink-connector-elasticsearch/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-35115) Kinesis connector writes wrong Kinesis sequence number at stop with savepoint

2024-04-15 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837319#comment-17837319 ] Hong Liang Teoh commented on FLINK-35115: - [~dannycranmer]  That is true, unless it is a problem

[jira] [Commented] (FLINK-35115) Kinesis connector writes wrong Kinesis sequence number at stop with savepoint

2024-04-15 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837318#comment-17837318 ] Danny Cranmer commented on FLINK-35115: --- Stop with savepoint checkpointing logic is no different

[jira] [Commented] (FLINK-35115) Kinesis connector writes wrong Kinesis sequence number at stop with savepoint

2024-04-15 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837315#comment-17837315 ] Hong Liang Teoh commented on FLINK-35115: - [~a.pilipenko]  Assigned to you, as you mentioned you

[jira] [Assigned] (FLINK-35115) Kinesis connector writes wrong Kinesis sequence number at stop with savepoint

2024-04-15 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh reassigned FLINK-35115: --- Assignee: Aleksandr Pilipenko > Kinesis connector writes wrong Kinesis sequence

Re: [PR] [DRAFT][FLINK-34440][formats][protobuf-confluent] add support for protobuf-confluent [flink]

2024-04-15 Thread via GitHub
klam-shop commented on code in PR #24482: URL: https://github.com/apache/flink/pull/24482#discussion_r1565935343 ## flink-formats/flink-protobuf-confluent-registry/src/test/java/org/apache/flink/formats/protobuf/registry/confluent/utils/FlinkToProtoSchemaConverterTest.java: ##

Re: [PR] [FLINK-34971]Add the function of History Server cleaning job archives… [flink]

2024-04-15 Thread via GitHub
d20162416 commented on PR #24593: URL: https://github.com/apache/flink/pull/24593#issuecomment-2057057881 @reswqa Excuse me, could you please help me check this PR? I appreciate your support very much. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [hotfix] Drop support for Flink1.16, add support for Flink 1.19, 1.20 [flink-connector-gcp-pubsub]

2024-04-15 Thread via GitHub
boring-cyborg[bot] commented on PR #24: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/24#issuecomment-2057011070 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Updated] (FLINK-35115) Kinesis connector writes wrong Kinesis sequence number at stop with savepoint

2024-04-15 Thread Vadim Vararu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vadim Vararu updated FLINK-35115: - Summary: Kinesis connector writes wrong Kinesis sequence number at stop with savepoint (was:

Re: [PR] [hotfix] Drop support for Flink1.16, add support for Flink 1.19, 1.20 [flink-connector-gcp-pubsub]

2024-04-15 Thread via GitHub
snuyanzin merged PR #24: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix] Drop support for Flink1.16, add support for Flink 1.19, 1.20 [flink-connector-gcp-pubsub]

2024-04-15 Thread via GitHub
snuyanzin commented on PR #24: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/24#issuecomment-2057010314 thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (FLINK-35115) Kinesis connector writes wrong sequence number at stop with savepoint

2024-04-15 Thread Vadim Vararu (Jira)
Vadim Vararu created FLINK-35115: Summary: Kinesis connector writes wrong sequence number at stop with savepoint Key: FLINK-35115 URL: https://issues.apache.org/jira/browse/FLINK-35115 Project: Flink

[jira] [Updated] (FLINK-35115) Kinesis connector writes wrong sequence number at stop with savepoint

2024-04-15 Thread Vadim Vararu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vadim Vararu updated FLINK-35115: - Affects Version/s: 1.18.1 > Kinesis connector writes wrong sequence number at stop with

Re: [PR] [FLINK-34930] Externalize existing code from bahir-flink [flink-connector-kudu]

2024-04-15 Thread via GitHub
ferenc-csaky commented on PR #1: URL: https://github.com/apache/flink-connector-kudu/pull/1#issuecomment-2056968781 Thanks, it passed now! is it okay to merge this change at this point for now? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-04-15 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837271#comment-17837271 ] Ryan Skraba commented on FLINK-31472: - 1.20 Hadoop 3.1.3: Test (module: connect)

[jira] [Commented] (FLINK-35041) IncrementalRemoteKeyedStateHandleTest.testSharedStateReRegistration failed

2024-04-15 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837272#comment-17837272 ] Ryan Skraba commented on FLINK-35041: - * 1.20 Test (module:core)

Re: [PR] [FLINK-34970] Translate architecture documents into Chinese [flink-kubernetes-operator]

2024-04-15 Thread via GitHub
caicancai commented on PR #809: URL: https://github.com/apache/flink-kubernetes-operator/pull/809#issuecomment-2056898849 cc @1996fanrui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-35095) ExecutionEnvironmentImplTest.testFromSource failure on GitHub CI

2024-04-15 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837273#comment-17837273 ] Ryan Skraba commented on FLINK-35095: - 1.20 Java 17: Test (module: misc)

Re: [PR] [FLINK-34980] Translate overview document into Chinese [flink-kubernetes-operator]

2024-04-15 Thread via GitHub
caicancai commented on PR #810: URL: https://github.com/apache/flink-kubernetes-operator/pull/810#issuecomment-2056897700 @RocMarshal PATL,thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-34930] Externalize existing code from bahir-flink [flink-connector-kudu]

2024-04-15 Thread via GitHub
MartijnVisser commented on PR #1: URL: https://github.com/apache/flink-connector-kudu/pull/1#issuecomment-2056886905 > @MartijnVisser can that one case be retriggered? Or of not, I hope another run would be green. Re-triggered all failing jobs! -- This is an automated message

[jira] [Commented] (FLINK-35097) Table API Filesystem connector with 'raw' format repeats last line

2024-04-15 Thread David Perkins (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837268#comment-17837268 ] David Perkins commented on FLINK-35097: --- Great! Thanks for the fast response. > Table API

[jira] [Comment Edited] (FLINK-35073) Deadlock in LocalBufferPool when segments become available in the global pool

2024-04-15 Thread Julien Tournay (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837259#comment-17837259 ] Julien Tournay edited comment on FLINK-35073 at 4/15/24 1:32 PM: -

[jira] [Closed] (FLINK-35073) Deadlock in LocalBufferPool when segments become available in the global pool

2024-04-15 Thread Julien Tournay (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Tournay closed FLINK-35073. -- Resolution: Workaround > Deadlock in LocalBufferPool when segments become available in the

[jira] [Commented] (FLINK-35111) Modify the spelling mistakes in the taskmanager html

2024-04-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837260#comment-17837260 ] Martijn Visser commented on FLINK-35111: Do note that grammar/spelling doesn't need a Jira

Re: [PR] [FLINK-34930] Externalize existing code from bahir-flink [flink-connector-kudu]

2024-04-15 Thread via GitHub
ferenc-csaky commented on PR #1: URL: https://github.com/apache/flink-connector-kudu/pull/1#issuecomment-2056866715 After I took a look at the logs, the error was environmental, it failed to connect to the Dockerized Kudu: ``` ERROR org.apache.kudu.client.Connection [] - [peer

[jira] [Commented] (FLINK-35073) Deadlock in LocalBufferPool when segments become available in the global pool

2024-04-15 Thread Julien Tournay (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837259#comment-17837259 ] Julien Tournay commented on FLINK-35073: Closing this issue because even though I captured a

Re: [PR] Update flink-operations.md correcting spelling errors [flink-web]

2024-04-15 Thread via GitHub
dannycranmer merged PR #661: URL: https://github.com/apache/flink-web/pull/661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-35112) Membership for Row class does not include field names

2024-04-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837257#comment-17837257 ] Martijn Visser commented on FLINK-35112: [~dianfu] [~hxbks2ks] WDYT? > Membership for Row class

Re: [PR] [hotfix][docs] https://flink.apache.org/zh/how-to-contribute/overview/ can't jump to how-to-contribute/contribute-code page [flink-web]

2024-04-15 Thread via GitHub
dannycranmer merged PR #688: URL: https://github.com/apache/flink-web/pull/688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-35114) Remove old Table API implementations

2024-04-15 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Csaky updated FLINK-35114: - Component/s: Connectors / Kudu > Remove old Table API implementations >

[jira] [Updated] (FLINK-34928) FLIP-439: Externalize Kudu Connector from Bahir

2024-04-15 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Csaky updated FLINK-34928: - Component/s: Connectors / Kudu > FLIP-439: Externalize Kudu Connector from Bahir >

[jira] [Created] (FLINK-35114) Remove old Table API implementations

2024-04-15 Thread Ferenc Csaky (Jira)
Ferenc Csaky created FLINK-35114: Summary: Remove old Table API implementations Key: FLINK-35114 URL: https://issues.apache.org/jira/browse/FLINK-35114 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-34931) Update Kudu connector DataStream Sink implementation

2024-04-15 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Csaky updated FLINK-34931: - Summary: Update Kudu connector DataStream Sink implementation (was: Update Kudu connector

[jira] [Commented] (FLINK-35113) Bump org.apache.commons:commons-compress from 1.25.0 to 1.26.1 for Flink AWS connectors

2024-04-15 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837249#comment-17837249 ] Danny Cranmer commented on FLINK-35113: --- Merged commit

[jira] [Resolved] (FLINK-35113) Bump org.apache.commons:commons-compress from 1.25.0 to 1.26.1 for Flink AWS connectors

2024-04-15 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-35113. --- Resolution: Fixed > Bump org.apache.commons:commons-compress from 1.25.0 to 1.26.1 for

Re: [PR] [FLINK-35113][Connectors/AWS] Bump commons-compress and commons-io de… [flink-connector-aws]

2024-04-15 Thread via GitHub
dannycranmer merged PR #137: URL: https://github.com/apache/flink-connector-aws/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix][docs] Change how-to-contribute empty link to overview page [flink-web]

2024-04-15 Thread via GitHub
dannycranmer commented on PR #689: URL: https://github.com/apache/flink-web/pull/689#issuecomment-2056822474 https://github.com/apache/flink-web/commit/eb6412b02e85c9dc7291e5759bb2fb02a259e774 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [hotfix][docs] Change how-to-contribute empty link to overview page [flink-web]

2024-04-15 Thread via GitHub
dannycranmer merged PR #689: URL: https://github.com/apache/flink-web/pull/689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix][docs] Change how-to-contribute empty link to overview page [flink-web]

2024-04-15 Thread via GitHub
dannycranmer commented on PR #689: URL: https://github.com/apache/flink-web/pull/689#issuecomment-2056812919 Since there is no reply here, I will merge this and fix the CN myself -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Make Flink-specific security page more prominent [flink-web]

2024-04-15 Thread via GitHub
dannycranmer merged PR #702: URL: https://github.com/apache/flink-web/pull/702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add missing word [flink-web]

2024-04-15 Thread via GitHub
dannycranmer merged PR #705: URL: https://github.com/apache/flink-web/pull/705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-31472][connectors/base] Remove external timer service reference from AsyncSinkThrottling Test [flink]

2024-04-15 Thread via GitHub
flinkbot commented on PR #24669: URL: https://github.com/apache/flink/pull/24669#issuecomment-2056796289 ## CI report: * fb6710d50b393a083aef0efba435efd67a5191de UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-31472] Remove external timer service reference from AsyncSinkThrottling Test [flink]

2024-04-15 Thread via GitHub
flinkbot commented on PR #24668: URL: https://github.com/apache/flink/pull/24668#issuecomment-2056795896 ## CI report: * d34bf506737492616c683f875215f18f1efe0701 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] update flink architecture url for text [Flinks's Architecture] [flink-web]

2024-04-15 Thread via GitHub
dannycranmer commented on code in PR #724: URL: https://github.com/apache/flink-web/pull/724#discussion_r1565754445 ## docs/content/posts/2020-07-14-application-mode.md: ## @@ -42,7 +42,7 @@ The execution of an application in Flink mainly involves three entities: the *Cl the

Re: [PR] [FLINK-35045][state] Introduce ForStFlinkFileSystem to support reading and writing with ByteBuffer [flink]

2024-04-15 Thread via GitHub
ljz2051 commented on code in PR #24632: URL: https://github.com/apache/flink/pull/24632#discussion_r1565730166 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ByteBufferReadableFSDataInputStream.java: ## @@ -0,0 +1,191 @@ +/* + *

Re: [PR] [FLINK-35025][Runtime/State] Abstract stream operators for async state processing [flink]

2024-04-15 Thread via GitHub
Zakelly commented on PR #24657: URL: https://github.com/apache/flink/pull/24657#issuecomment-2056794596 @fredia @yunfengzhou-hub Thanks a lot for your review. I have made another PR to introduce the element order of processElement as FLIP-425 said. This is strictly internal and not

Re: [PR] [FLINK-35025][Runtime/State] Abstract stream operators for async state processing [flink]

2024-04-15 Thread via GitHub
Zakelly commented on code in PR #24657: URL: https://github.com/apache/flink/pull/24657#discussion_r1565751676 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordProcessorUtils.java: ## @@ -82,6 +87,10 @@ public static ThrowingConsumer,

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-04-15 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837234#comment-17837234 ] Ahmed Hamdy commented on FLINK-31472: - Thanks [~dannycranmer]  I created followups for 1.18, 1.19

Re: [PR] [FLINK-35025][Runtime/State] Abstract stream operators for async state processing [flink]

2024-04-15 Thread via GitHub
Zakelly commented on code in PR #24657: URL: https://github.com/apache/flink/pull/24657#discussion_r1565750669 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperatorTest.java: ## @@ -0,0 +1,98 @@ +/* +

[PR] [FLINK-31472][connectors/base] Remove external timer service reference from AsyncSinkThrottling Test [flink]

2024-04-15 Thread via GitHub
vahmed-hamdy opened a new pull request, #24669: URL: https://github.com/apache/flink/pull/24669 ## What is the purpose of the change Refactor `AsyncSinkWriterThrottlingTest` to flush when reaching batch sizes without changing processing time. The changes of processing time

Re: [PR] Update use-cases.md [flink-web]

2024-04-15 Thread via GitHub
dannycranmer commented on PR #723: URL: https://github.com/apache/flink-web/pull/723#issuecomment-2056787028 Thanks for the contribution @Milunas. However I fixed this as part of https://github.com/apache/flink-web/pull/731 -- This is an automated message from the Apache Git Service. To

Re: [PR] Update use-cases.md [flink-web]

2024-04-15 Thread via GitHub
dannycranmer closed pull request #723: Update use-cases.md URL: https://github.com/apache/flink-web/pull/723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Update use-cases.md [flink-web]

2024-04-15 Thread via GitHub
dannycranmer commented on PR #731: URL: https://github.com/apache/flink-web/pull/731#issuecomment-2056785974 I now see this https://github.com/apache/flink-web/pull/723 臘 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] [FFLINK-31472] Remove external timer service reference from AsyncSinkThrottling Test [flink]

2024-04-15 Thread via GitHub
vahmed-hamdy opened a new pull request, #24668: URL: https://github.com/apache/flink/pull/24668 ## What is the purpose of the change Refactor `AsyncSinkWriterThrottlingTest` to flush when reaching batch sizes without changing processing time. The changes of processing

[jira] [Comment Edited] (FLINK-35056) when initial sqlserver table that's primary key is datetime type, it org.apache.flink.table.api.ValidationException: Timestamp precision must be between 0 and 9

2024-04-15 Thread Thorne (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837232#comment-17837232 ] Thorne edited comment on FLINK-35056 at 4/15/24 12:47 PM: -- Hi,can u give me a

[jira] [Commented] (FLINK-35056) when initial sqlserver table that's primary key is datetime type, it org.apache.flink.table.api.ValidationException: Timestamp precision must be between 0 and 9 (both

2024-04-15 Thread Thorne (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837232#comment-17837232 ] Thorne commented on FLINK-35056: Hi,can u give me a example and let me to recurrent it。 > when initial

  1   2   3   >