Re: [PR] [FLINK-34980] Translate overview document into Chinese [flink-kubernetes-operator]

2024-04-16 Thread via GitHub
RocMarshal commented on code in PR #810: URL: https://github.com/apache/flink-kubernetes-operator/pull/810#discussion_r1566975727 ## docs/content.zh/docs/concepts/overview.md: ## @@ -24,86 +24,93 @@ specific language governing permissions and limitations under the License.

Re: [PR] [FLINK-34549][API] Introduce config, context and processingTimerService for DataStream API V2 [flink]

2024-04-16 Thread via GitHub
reswqa commented on code in PR #24541: URL: https://github.com/apache/flink/pull/24541#discussion_r1566976014 ## flink-datastream-api/src/main/java/org/apache/flink/datastream/api/context/ProcessingTimeManager.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[jira] [Comment Edited] (FLINK-35039) Create Profiling JobManager/TaskManager Instance failed

2024-04-16 Thread JJJJude (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834758#comment-17834758 ] ude edited comment on FLINK-35039 at 4/16/24 8:36 AM: -- [~Yu Chen],[~yunta]  

Re: [PR] Fix pubsub topic name javadoc [flink-connector-gcp-pubsub]

2024-04-16 Thread via GitHub
snuyanzin commented on PR #23: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/23#issuecomment-2058526774 @joaquinfernandez131 could you please rebase to be sure that ci passes? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (FLINK-35123) Flink Kubernetes Operator should not do deleteHAData

2024-04-16 Thread Fei Feng (Jira)
Fei Feng created FLINK-35123: Summary: Flink Kubernetes Operator should not do deleteHAData Key: FLINK-35123 URL: https://issues.apache.org/jira/browse/FLINK-35123 Project: Flink Issue Type:

[jira] [Comment Edited] (FLINK-34752) "legacy-flink-cdc-sources" Page of TIDB for Flink CDC Chinese Documentation.

2024-04-16 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837579#comment-17837579 ] 牛一凡 edited comment on FLINK-34752 at 4/16/24 8:09 AM: -- Hi [~kunni]  ,I am a Chinese

[jira] (FLINK-34747) "legacy-flink-cdc-sources" Page of DB2 for Flink CDC Chinese Documentation.

2024-04-16 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34747 ] 牛一凡 deleted comment on FLINK-34747: - was (Author: JIRAUSER304780): I am willing to do this.Can it be assigned to me?:) > "legacy-flink-cdc-sources" Page of DB2 for Flink CDC Chinese Documentation.

[jira] [Resolved] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-04-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-31472. --- Resolution: Fixed > AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread >

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-04-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837580#comment-17837580 ] Danny Cranmer commented on FLINK-31472: --- I was waiting for the backports to be merged. Now merged:

Re: [PR] [FLINK-31472] Remove external timer service reference from AsyncSinkThrottling Test [flink]

2024-04-16 Thread via GitHub
dannycranmer merged PR #24668: URL: https://github.com/apache/flink/pull/24668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] (FLINK-34735) "Developer Guide - Understanding Flink CDC API" Page for Flink CDC Chinese Documentation

2024-04-16 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34735 ] 牛一凡 deleted comment on FLINK-34735: - was (Author: JIRAUSER304780): I am willing to do this.Can it be assigned to me?:) > "Developer Guide - Understanding Flink CDC API" Page for Flink CDC Chinese

[jira] [Assigned] (FLINK-32892) Handle Kafka clients JMX mBean errors by disabling JMX metrics

2024-04-16 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen reassigned FLINK-32892: -- Assignee: Mason Chen > Handle Kafka clients JMX mBean errors by disabling JMX metrics >

[jira] [Commented] (FLINK-34749) "legacy-flink-cdc-sources" Page of SQLServer for Flink CDC Chinese Documentation.

2024-04-16 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837582#comment-17837582 ] 牛一凡 commented on FLINK-34749: - Hi [~kunni]  ,I am a Chinese Speaker and glad to take this work , cloud you

[jira] (FLINK-34749) "legacy-flink-cdc-sources" Page of SQLServer for Flink CDC Chinese Documentation.

2024-04-16 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34749 ] 牛一凡 deleted comment on FLINK-34749: - was (Author: JIRAUSER304780): I am willing to do this.Can it be assigned to me?:) > "legacy-flink-cdc-sources" Page of SQLServer for Flink CDC Chinese >

[jira] [Comment Edited] (FLINK-34748) "legacy-flink-cdc-sources" Page of Oracle for Flink CDC Chinese Documentation.

2024-04-16 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837576#comment-17837576 ] 牛一凡 edited comment on FLINK-34748 at 4/16/24 8:10 AM: -- Hi [~kunni]  ,I am a Chinese

[jira] [Assigned] (FLINK-35111) Modify the spelling mistakes in the taskmanager html

2024-04-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-35111: - Assignee: Yun Tang > Modify the spelling mistakes in the taskmanager html >

Re: [PR] [hotfix][web] Correct the hint of options name of rest.profiling.enabled [flink]

2024-04-16 Thread via GitHub
dannycranmer commented on PR #24276: URL: https://github.com/apache/flink/pull/24276#issuecomment-2058472281 In parallel, a Jira was created for this. Referencing here https://issues.apache.org/jira/browse/FLINK-35111 -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (FLINK-35111) Modify the spelling mistakes in the taskmanager html

2024-04-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-35111: -- Component/s: Runtime / Web Frontend (was: Documentation) > Modify the

[jira] [Updated] (FLINK-35111) Modify the spelling mistakes in the taskmanager html

2024-04-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-35111: -- Fix Version/s: 1.20.0 > Modify the spelling mistakes in the taskmanager html >

[jira] [Updated] (FLINK-35111) Modify the spelling mistakes in the taskmanager html

2024-04-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-35111: -- Fix Version/s: (was: 1.20.0) > Modify the spelling mistakes in the taskmanager html >

[jira] [Commented] (FLINK-35111) Modify the spelling mistakes in the taskmanager html

2024-04-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837568#comment-17837568 ] Danny Cranmer commented on FLINK-35111: --- Ok great, thanks for the update [~wczhu] . Resolving this 

[jira] [Updated] (FLINK-35111) Modify the spelling mistakes in the taskmanager html

2024-04-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-35111: -- Fix Version/s: (was: 1.19.0) > Modify the spelling mistakes in the taskmanager html >

[jira] [Updated] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-04-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-31472: -- Fix Version/s: 1.18.2 1.19.1 > AsyncSinkWriterThrottlingTest failed with

[jira] [Commented] (FLINK-34752) "legacy-flink-cdc-sources" Page of TIDB for Flink CDC Chinese Documentation.

2024-04-16 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837579#comment-17837579 ] 牛一凡 commented on FLINK-34752: - I am willing to do this.Can it be assigned to me?:) >

[jira] [Commented] (FLINK-34749) "legacy-flink-cdc-sources" Page of SQLServer for Flink CDC Chinese Documentation.

2024-04-16 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837578#comment-17837578 ] 牛一凡 commented on FLINK-34749: - I am willing to do this.Can it be assigned to me?:) >

Re: [PR] [FLINK-31472][connectors/base] Remove external timer service reference from AsyncSinkThrottling Test [flink]

2024-04-16 Thread via GitHub
dannycranmer merged PR #24669: URL: https://github.com/apache/flink/pull/24669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (FLINK-31400) Add autoscaler integration for Iceberg source

2024-04-16 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen reassigned FLINK-31400: -- Assignee: Mason Chen (was: Mason Chen) > Add autoscaler integration for Iceberg source >

[jira] [Commented] (FLINK-34748) "legacy-flink-cdc-sources" Page of Oracle for Flink CDC Chinese Documentation.

2024-04-16 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837576#comment-17837576 ] 牛一凡 commented on FLINK-34748: - I am willing to do this.Can it be assigned to me?:) >

[jira] [Commented] (FLINK-34747) "legacy-flink-cdc-sources" Page of DB2 for Flink CDC Chinese Documentation.

2024-04-16 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837575#comment-17837575 ] 牛一凡 commented on FLINK-34747: - I am willing to do this.Can it be assigned to me?:) >

[jira] [Commented] (FLINK-34735) "Developer Guide - Understanding Flink CDC API" Page for Flink CDC Chinese Documentation

2024-04-16 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837571#comment-17837571 ] 牛一凡 commented on FLINK-34735: - I am willing to do this.Can it be assigned to me?:) > "Developer Guide -

[jira] [Resolved] (FLINK-34906) Don't start autoscaling when some tasks are not running

2024-04-16 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-34906. - Resolution: Fixed > Don't start autoscaling when some tasks are not running >

[jira] [Commented] (FLINK-34906) Don't start autoscaling when some tasks are not running

2024-04-16 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837557#comment-17837557 ] Rui Fan commented on FLINK-34906: - Merged to main(1.9.0) via : 75eb206e863993727b62bd7374adadbc4760e417

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-04-16 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837570#comment-17837570 ] Ahmed Hamdy commented on FLINK-31472: - Is there a reason why the issue is not Resolved? >

[jira] [Updated] (FLINK-35111) Modify the spelling mistakes in the taskmanager html

2024-04-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-35111: -- Component/s: Documentation (was: Runtime / Web Frontend) > Modify the

[jira] [Commented] (FLINK-35088) watermark alignment maxAllowedWatermarkDrift and updateInterval param need check

2024-04-16 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837569#comment-17837569 ] Mason Chen commented on FLINK-35088:   Watermark alignment was moved out of beta during the 1.18.0

[jira] [Resolved] (FLINK-35111) Modify the spelling mistakes in the taskmanager html

2024-04-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-35111. --- Fix Version/s: 1.20.0 Resolution: Fixed > Modify the spelling mistakes in the

[jira] [Created] (FLINK-35122) Implement Watermark Alignment for DynamicKafkaSource

2024-04-16 Thread Mason Chen (Jira)
Mason Chen created FLINK-35122: -- Summary: Implement Watermark Alignment for DynamicKafkaSource Key: FLINK-35122 URL: https://issues.apache.org/jira/browse/FLINK-35122 Project: Flink Issue Type:

[jira] [Updated] (FLINK-35122) Implement Watermark Alignment for DynamicKafkaSource

2024-04-16 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-35122: --- Component/s: Connectors / Kafka > Implement Watermark Alignment for DynamicKafkaSource >

[jira] [Commented] (FLINK-35115) Kinesis connector writes wrong Kinesis sequence number at stop with savepoint

2024-04-16 Thread Aleksandr Pilipenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837562#comment-17837562 ] Aleksandr Pilipenko commented on FLINK-35115: - [~vadim.vararu] are you able to reproduce

Re: [PR] [FLINK-34906] Only scale when all tasks are running [flink-kubernetes-operator]

2024-04-16 Thread via GitHub
1996fanrui merged PR #801: URL: https://github.com/apache/flink-kubernetes-operator/pull/801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34906] Only scale when all tasks are running [flink-kubernetes-operator]

2024-04-16 Thread via GitHub
1996fanrui commented on PR #801: URL: https://github.com/apache/flink-kubernetes-operator/pull/801#issuecomment-2058446456 Hi @mxm , I merge this PR first, feel free to ping me if you have any comment in the future, thanks~ -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (FLINK-35119) UPDATE DataChangeEvent deserialized data is incorrect

2024-04-16 Thread Qishang Zhong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qishang Zhong updated FLINK-35119: -- Description: When DebeziumChangelogMode is upsert, the before of DataChangeEvent is null,

[jira] [Commented] (FLINK-35121) CDC pipeline connector should verify requiredOptions and optionalOptions

2024-04-16 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837552#comment-17837552 ] Hongshun Wang commented on FLINK-35121: --- [~renqs] , CC > CDC pipeline connector should verify

[jira] [Created] (FLINK-35121) CDC pipeline connector should verify requiredOptions and optionalOptions

2024-04-16 Thread Hongshun Wang (Jira)
Hongshun Wang created FLINK-35121: - Summary: CDC pipeline connector should verify requiredOptions and optionalOptions Key: FLINK-35121 URL: https://issues.apache.org/jira/browse/FLINK-35121 Project:

Re: [PR] [FLINK-34633][table] Support unnesting array constants [flink]

2024-04-16 Thread via GitHub
LadyForest commented on code in PR #24510: URL: https://github.com/apache/flink/pull/24510#discussion_r1566868181 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/UncollectToTableFunctionScanRule.scala: ## @@ -0,0 +1,100 @@ +/*

Re: [PR] [FLINK-35045][state] Introduce ForStFlinkFileSystem to support reading and writing with ByteBuffer [flink]

2024-04-16 Thread via GitHub
ljz2051 commented on code in PR #24632: URL: https://github.com/apache/flink/pull/24632#discussion_r1566847884 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ByteBufferWritableFSDataOutputStream.java: ## @@ -0,0 +1,102 @@ +/* + *

Re: [PR] [FLINK-34970] Translate architecture documents into Chinese [flink-kubernetes-operator]

2024-04-16 Thread via GitHub
1996fanrui commented on code in PR #809: URL: https://github.com/apache/flink-kubernetes-operator/pull/809#discussion_r1566848357 ## docs/content.zh/docs/concepts/architecture.md: ## @@ -24,57 +24,66 @@ specific language governing permissions and limitations under the

Re: [PR] [FLINK-34444] Initial implementation of JM operator metric rest api [flink]

2024-04-16 Thread via GitHub
mas-chen commented on code in PR #24564: URL: https://github.com/apache/flink/pull/24564#discussion_r1566845916 ## docs/static/generated/rest_v1_dispatcher.yml: ## @@ -1089,6 +1089,37 @@ paths: application/json: schema: $ref:

Re: [PR] [FLINK-34369][connectors/elasticsearch] Elasticsearch connector supports SSL context [flink-connector-elasticsearch]

2024-04-16 Thread via GitHub
snuyanzin commented on PR #91: URL: https://github.com/apache/flink-connector-elasticsearch/pull/91#issuecomment-2058403397 @liuml07 thanks for the contribution it seems the ci failed because of `spotless` could you please apply spotless to the PR? -- This is an automated message

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-16 Thread via GitHub
zhongqishang commented on code in PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#discussion_r1566843014 ##

Re: [PR] [FLINK-34970] Translate architecture documents into Chinese [flink-kubernetes-operator]

2024-04-16 Thread via GitHub
1996fanrui commented on code in PR #809: URL: https://github.com/apache/flink-kubernetes-operator/pull/809#discussion_r1566834001 ## docs/content.zh/docs/concepts/architecture.md: ## @@ -24,57 +24,65 @@ specific language governing permissions and limitations under the

[jira] [Commented] (FLINK-35112) Membership for Row class does not include field names

2024-04-16 Thread Wouter Zorgdrager (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837538#comment-17837538 ] Wouter Zorgdrager commented on FLINK-35112: --- [~dianfu] sure, I can submit a PR for this!  >

Re: [PR] [FLINK-34970] Translate architecture documents into Chinese [flink-kubernetes-operator]

2024-04-16 Thread via GitHub
caicancai commented on code in PR #809: URL: https://github.com/apache/flink-kubernetes-operator/pull/809#discussion_r1566828007 ## docs/content.zh/docs/concepts/architecture.md: ## @@ -24,57 +24,65 @@ specific language governing permissions and limitations under the License.

[jira] [Commented] (FLINK-35103) [Plugin] Enhancing Flink Failure Management in Kubernetes with Dynamic Termination Log Integration

2024-04-16 Thread SwathiChandrashekar (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837541#comment-17837541 ] SwathiChandrashekar commented on FLINK-35103: - Thanks [~martijnvisser] . Have started a

Re: [PR] [FLINK-35120][doris] Add Doris integration test cases [flink-cdc]

2024-04-16 Thread via GitHub
yuxiqian commented on PR #3227: URL: https://github.com/apache/flink-cdc/pull/3227#issuecomment-2058385113 cc @PatrickRen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-35120) Add Doris Pipeline connector integration test cases

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35120: --- Labels: pull-request-available (was: ) > Add Doris Pipeline connector integration test

[PR] [FLINK-35120][doris] Add Doris integration test cases [flink-cdc]

2024-04-16 Thread via GitHub
yuxiqian opened a new pull request, #3227: URL: https://github.com/apache/flink-cdc/pull/3227 This closes [FLINK-35120](https://issues.apache.org/jira/browse/FLINK-35120). Currently, Flink CDC Doris pipeline connector has very limited test cases (which only covers row convertion).

Re: [PR] [FLINK-34633][table] Support unnesting array constants [flink]

2024-04-16 Thread via GitHub
LadyForest commented on PR #24510: URL: https://github.com/apache/flink/pull/24510#issuecomment-2058380570 > Thanks for your review @LadyForest. I rebased and addressed your comments. Could you please re-check the PR in your available time? Thanks Apologies for the delayed response,

Re: [PR] [FLINK-34970] Translate architecture documents into Chinese [flink-kubernetes-operator]

2024-04-16 Thread via GitHub
1996fanrui commented on code in PR #809: URL: https://github.com/apache/flink-kubernetes-operator/pull/809#discussion_r1566817400 ## docs/content.zh/docs/concepts/architecture.md: ## @@ -24,57 +24,65 @@ specific language governing permissions and limitations under the

[jira] [Commented] (FLINK-35115) Kinesis connector writes wrong Kinesis sequence number at stop with savepoint

2024-04-16 Thread Vadim Vararu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837533#comment-17837533 ] Vadim Vararu commented on FLINK-35115: -- FYI it's reproducible in Kinesis -> Flink -> S3 sink also.

Re: [PR] [FLINK-34970] Translate architecture documents into Chinese [flink-kubernetes-operator]

2024-04-16 Thread via GitHub
1996fanrui commented on code in PR #809: URL: https://github.com/apache/flink-kubernetes-operator/pull/809#discussion_r1566812379 ## docs/content.zh/docs/concepts/architecture.md: ## @@ -24,57 +24,65 @@ specific language governing permissions and limitations under the

[jira] [Created] (FLINK-35120) Add Doris Pipeline connector integration test cases

2024-04-16 Thread Xiqian YU (Jira)
Xiqian YU created FLINK-35120: - Summary: Add Doris Pipeline connector integration test cases Key: FLINK-35120 URL: https://issues.apache.org/jira/browse/FLINK-35120 Project: Flink Issue Type:

Re: [PR] [FLINK-35105][autoscaler] Support setting default Autoscaler options at autoscaler standalone level [flink-kubernetes-operator]

2024-04-16 Thread via GitHub
1996fanrui commented on code in PR #814: URL: https://github.com/apache/flink-kubernetes-operator/pull/814#discussion_r1566801016 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/JobListFetcher.java: ## @@ -19,12 +19,19 @@ import

[jira] [Commented] (FLINK-34508) Migrate S3-related ITCases and e2e tests to Minio

2024-04-16 Thread Muhammet Orazov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837531#comment-17837531 ] Muhammet Orazov commented on FLINK-34508: - Hey [~mapohl], On the GitHub CI, the S3

[jira] [Commented] (FLINK-34508) Migrate S3-related ITCases and e2e tests to Minio

2024-04-16 Thread Muhammet Orazov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837530#comment-17837530 ] Muhammet Orazov commented on FLINK-34508: - In the Azure Pipeline the YarnFileStageTestS3ITCase

[jira] [Updated] (FLINK-35089) Two input AbstractStreamOperator may throw NPE when receiving RecordAttributes

2024-04-16 Thread Xuannan Su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuannan Su updated FLINK-35089: --- Description: Currently the `lastRecordAttributes1` and `lastRecordAttributes2` in the

[jira] [Closed] (FLINK-30081) Local executor can not accept different jvm-overhead.min/max values

2024-04-16 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-30081. Fix Version/s: 1.20.0 Resolution: Fixed master (1.20):

Re: [PR] Support skip verify ssl certificate and hostname [flink-connector-elasticsearch]

2024-04-16 Thread via GitHub
liuml07 commented on PR #96: URL: https://github.com/apache/flink-connector-elasticsearch/pull/96#issuecomment-2058320749 Have you checked this PR? https://github.com/apache/flink-connector-elasticsearch/pull/91 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-30081][runtime] Reset unused options like jvm-overhead.min/max for local executor [flink]

2024-04-16 Thread via GitHub
xintongsong closed pull request #22547: [FLINK-30081][runtime] Reset unused options like jvm-overhead.min/max for local executor URL: https://github.com/apache/flink/pull/22547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-30081][runtime] Reset unused options like jvm-overhead.min/max for local executor [flink]

2024-04-16 Thread via GitHub
xintongsong commented on code in PR #22547: URL: https://github.com/apache/flink/pull/22547#discussion_r1566773890 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorResourceUtils.java: ## @@ -285,4 +286,15 @@ private static void

[jira] [Comment Edited] (FLINK-34508) Migrate S3-related ITCases and e2e tests to Minio

2024-04-16 Thread Muhammet Orazov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837486#comment-17837486 ] Muhammet Orazov edited comment on FLINK-34508 at 4/16/24 6:19 AM: -- Hey

Re: [PR] [FLINK-34369][connectors/elasticsearch] Elasticsearch connector supports SSL context [flink-connector-elasticsearch]

2024-04-16 Thread via GitHub
liuml07 commented on PR #91: URL: https://github.com/apache/flink-connector-elasticsearch/pull/91#issuecomment-2058316069 @reta Thanks for the advice. I have updated the patch accordingly. I think the `allowInsecure` and the `sslContextSupplier` are mutually exclusive, so I added some

Re: [PR] [FLINK-35025][Runtime/State] Abstract stream operators for async state processing [flink]

2024-04-16 Thread via GitHub
fredia commented on code in PR #24657: URL: https://github.com/apache/flink/pull/24657#discussion_r1566767092 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/multipleinput/input/FirstInputOfTwoInput.java: ## @@ -54,4 +57,17 @@ public

[jira] [Assigned] (FLINK-35089) Two input AbstractStreamOperator may throw NPE when receiving RecordAttributes

2024-04-16 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-35089: Assignee: Xuannan Su > Two input AbstractStreamOperator may throw NPE when receiving

Re: [PR] [FLINK-35026][runtime][config] Introduce async execution configurations [flink]

2024-04-16 Thread via GitHub
yunfengzhou-hub commented on code in PR #24667: URL: https://github.com/apache/flink/pull/24667#discussion_r1566744878 ## flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java: ## @@ -1085,6 +1085,54 @@ public void setUseSnapshotCompression(boolean

<    1   2